selectables 0.2.0

Lock-free channels with a unified select! macro for recv and send arms
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
//! Bounded multi-producer, single-consumer channel with lock-free send and recv.
//!
//! # Overview
//!
//! A bounded MPSC channel allows multiple senders to push messages into a fixed-size ring buffer,
//! while a single receiver consumes them. This is ideal for scenarios with many producers
//! and one consumer (e.g., worker threads reporting to a main thread).
//!
//! # Capacity and backpressure
//!
//! When the buffer is full:
//! - `send()` returns `Err(SendError(msg))` immediately (non-blocking, fail-fast)
//! - No blocking, no waiting for space — the message is returned to the sender
//! - As the receiver pops messages, space opens up and subsequent sends succeed
//!
//! # Lock-free design
//!
//! - `send()` is entirely lock-free: uses atomics and ring buffer operations only
//! - `try_recv()` is entirely lock-free: fast-path pop without contention
//! - `recv()` is lock-free on the hot path; only locks during slow-path waiter registration
//! - Wake semantics: one send wakes one waiting receiver (efficient for MPSC model)
//!
//! # Cloning
//!
//! - `Sender` is cloneable, creating additional independent send handles
//! - `Receiver` is also cloneable; the "SC" in MPSC describes typical single-consumer
//!   usage, but cloning the receiver is supported (e.g. for `select!` arms)
//!
//! # Example
//!
//! ```ignore
//! let (tx, rx) = bounded_mpsc::channel(16);
//!
//! // Multiple senders
//! let tx1 = tx.clone();
//! std::thread::spawn(move || { tx1.send(1).ok(); });
//! std::thread::spawn(move || { tx.send(2).ok(); });
//!
//! // Single consumer receives all messages
//! assert!(rx.recv().is_ok());
//! assert!(rx.recv().is_ok());
//! ```

use std::{
    sync::Arc,
    sync::atomic::{AtomicPtr, AtomicUsize, Ordering::*},
    thread,
};

use crate::{
    error::{RecvError, SendError, TryRecvError},
    internals::LockFreeBoundedRing,
    waiter::{
        RecvWaiterList, SelectWaiter, abort_select_waiters, drain_select_waiters,
        new_recv_waiter_list, push_select_waiter, register_plain_recv_waiter,
        wake_all_recv_waiters, wake_all_unselected_recv_waiters, wake_select_all, wake_select_one,
    },
};

// ════════════════════════════════════════════════════════════════════════════
// MPSC Channel Internals
// ════════════════════════════════════════════════════════════════════════════

pub(crate) struct Chan<T> {
    ring: LockFreeBoundedRing<T>,
    recv_waiters: RecvWaiterList,
    select_waiters: Arc<AtomicPtr<SelectWaiter>>,
    sender_count: AtomicUsize,
    receiver_count: AtomicUsize,
    /// Select waiters for send arms; woken when buffer space is freed or receivers disconnect.
    send_select_waiters: Arc<AtomicPtr<SelectWaiter>>,
}

// ════════════════════════════════════════════════════════════════════════════
// MPSC Sender
// ════════════════════════════════════════════════════════════════════════════

pub struct Sender<T>(pub(crate) Arc<Chan<T>>);

impl<T> Sender<T> {
    /// Returns `true` if all [`Receiver`] handles have been dropped.
    pub fn is_closed(&self) -> bool {
        self.0.receiver_count.load(Acquire) == 0
    }

    pub fn send(&self, msg: T) -> Result<(), SendError<T>> {
        // Lock-free early-out: bail if all receivers are gone.
        if self.0.receiver_count.load(Acquire) == 0 {
            return Err(SendError(msg));
        }
        // Lock-free enqueue.
        // Note: Ok(()) confirms enqueue but not that a receiver is still live;
        // the last receiver may drop concurrently after the check above.
        match self.0.ring.try_push(msg) {
            Err(msg) => return Err(SendError(msg)), // full or zero-capacity
            Ok(()) => {}
        }
        // Wake up all threads waiting for a message (select or plain recv).
        wake_all_unselected_recv_waiters(&self.0.recv_waiters);
        wake_select_one(&self.0.select_waiters);
        Ok(())
    }
}

impl<T> Clone for Sender<T> {
    fn clone(&self) -> Self {
        self.0.sender_count.fetch_add(1, Relaxed);
        Sender(Arc::clone(&self.0))
    }
}

impl<T> Drop for Sender<T> {
    fn drop(&mut self) {
        let prev = self.0.sender_count.fetch_sub(1, AcqRel);
        if prev == 1 {
            // Last sender dropped — wake all waiting receivers so they can
            // observe the disconnected state.
            wake_all_recv_waiters(&self.0.recv_waiters);
            wake_select_all(&self.0.select_waiters);
        }
    }
}

// ════════════════════════════════════════════════════════════════════════════
// MPSC Receiver
// ════════════════════════════════════════════════════════════════════════════

pub struct Receiver<T>(pub(crate) Arc<Chan<T>>);

impl<T> Clone for Receiver<T> {
    fn clone(&self) -> Self {
        self.0.receiver_count.fetch_add(1, Relaxed);
        Receiver(Arc::clone(&self.0))
    }
}

impl<T> Receiver<T> {
    /// Non-blocking receive — entirely lock-free.
    pub fn try_recv(&self) -> Result<T, TryRecvError> {
        if let Some(msg) = self.0.ring.try_pop() {
            // Space freed — wake one send-side select waiter.
            wake_select_one(&self.0.send_select_waiters);
            return Ok(msg);
        }
        if self.0.sender_count.load(Acquire) == 0 {
            Err(TryRecvError::Disconnected)
        } else {
            Err(TryRecvError::Empty)
        }
    }

    /// Blocking receive.
    ///
    /// Fast path is lock-free.  When the queue is empty, the thread registers
    /// itself in the waiter list (under the waiters lock), re-checks the queue
    /// to close the lost-wakeup window, then parks until a sender unparks it.
    pub fn recv(&self) -> Result<T, RecvError> {
        loop {
            // --- fast path (lock-free) ---
            if let Some(msg) = self.0.ring.try_pop() {
                wake_select_one(&self.0.send_select_waiters);
                return Ok(msg);
            }
            if self.0.sender_count.load(Acquire) == 0 {
                return Err(RecvError::Disconnected);
            }

            // --- slow path: register waiter, re-check, park ---
            let _guard = register_plain_recv_waiter(&self.0.recv_waiters);

            // Re-check after registration to close the lost-wakeup window.
            if let Some(msg) = self.0.ring.try_pop() {
                wake_select_one(&self.0.send_select_waiters);
                return Ok(msg);
            }
            if self.0.sender_count.load(Acquire) == 0 {
                return Err(RecvError::Disconnected);
            }

            thread::park();
        }
    }

    /// Lock-free readiness check used by the select protocol.
    pub(crate) fn is_ready(&self) -> bool {
        !self.0.ring.is_empty() || self.0.sender_count.load(Acquire) == 0
    }

    pub(crate) fn register_select(&self, case_id: usize, selected: Arc<AtomicUsize>) {
        let ptr = SelectWaiter::alloc(case_id, selected);
        push_select_waiter(ptr, &self.0.select_waiters);
    }

    pub(crate) fn abort_select(&self, selected: &Arc<AtomicUsize>) {
        abort_select_waiters(&self.0.select_waiters, selected);
    }

    /// Called by `select!` after this arm wins. Calls `recv()` so that if a
    /// concurrent consumer raced ahead and took the item, we wait for the next
    /// one rather than returning a spurious `Disconnected`.
    pub(crate) fn complete_recv(&self) -> Result<T, RecvError> {
        self.recv()
    }
}

impl_selectable_receiver!([T] Receiver<T>, T);

impl<T> Drop for Receiver<T> {
    fn drop(&mut self) {
        let prev = self.0.receiver_count.fetch_sub(1, AcqRel);
        if prev == 1 {
            drain_select_waiters(&self.0.select_waiters);
            // Wake all send-side select waiters so blocked send arms observe disconnect.
            wake_select_all(&self.0.send_select_waiters);
        }
    }
}

// ════════════════════════════════════════════════════════════════════════════
// SelectableSender impl for Sender<T>
// ════════════════════════════════════════════════════════════════════════════

impl<T: Send + 'static> crate::SelectableSender for Sender<T> {
    type Input = T;

    fn is_ready(&self) -> bool {
        !self.0.ring.is_full() || self.0.receiver_count.load(Acquire) == 0
    }

    fn register_select(&self, case_id: usize, selected: Arc<AtomicUsize>) {
        let ptr = SelectWaiter::alloc(case_id, selected);
        push_select_waiter(ptr, &self.0.send_select_waiters);
    }

    fn abort_select(&self, selected: &Arc<AtomicUsize>) {
        abort_select_waiters(&self.0.send_select_waiters, selected);
    }

    fn complete_send(&self, value: T) -> Result<(), crate::SendError<T>> {
        self.send(value)
    }
}

// ════════════════════════════════════════════════════════════════════════════
// Constructors
// ════════════════════════════════════════════════════════════════════════════

/// Create a bounded MPSC channel with the given capacity.
/// `send` fails immediately if the buffer is full.
///
/// **Note**: `channel(0)` creates a permanently-full channel where every
/// `send` fails immediately. This is **not** a rendezvous channel.
/// For synchronous sender-receiver handoff, use [`crate::rendezvous::channel`].
pub fn channel<T>(capacity: usize) -> (Sender<T>, Receiver<T>) {
    let chan: Arc<Chan<T>> = Arc::new(Chan {
        ring: LockFreeBoundedRing::new(capacity),
        recv_waiters: new_recv_waiter_list(),
        select_waiters: Arc::new(AtomicPtr::new(std::ptr::null_mut())),
        sender_count: AtomicUsize::new(1),
        receiver_count: AtomicUsize::new(1),
        send_select_waiters: Arc::new(AtomicPtr::new(std::ptr::null_mut())),
    });
    (Sender(Arc::clone(&chan)), Receiver(chan))
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::thread;
    use std::time::Duration;

    use crate::select;

    #[test]
    fn basic_send_recv() {
        let (tx, rx) = channel(10);
        tx.send(42).unwrap();
        assert_eq!(rx.recv().unwrap(), 42);
    }

    #[test]
    fn try_recv() {
        let (tx, rx) = channel(10);
        assert!(rx.try_recv().is_err()); // Empty
        tx.send(123).unwrap();
        assert_eq!(rx.try_recv().unwrap(), 123);
    }

    #[test]
    fn bounded_capacity() {
        let (tx, rx) = channel(2);
        tx.send(1).unwrap();
        tx.send(2).unwrap();
        assert!(tx.send(3).is_err()); // Full
        assert_eq!(rx.recv().unwrap(), 1);
        tx.send(3).unwrap(); // Now space
        assert_eq!(rx.recv().unwrap(), 2);
        assert_eq!(rx.recv().unwrap(), 3);
    }

    #[test]
    fn multiple_senders() {
        let (tx1, rx) = channel(10);
        let tx2 = tx1.clone();
        let tx3 = tx1.clone();

        tx1.send("a").unwrap();
        tx2.send("b").unwrap();
        tx3.send("c").unwrap();

        // Order not guaranteed, but all should be received
        let mut received = vec![];
        for _ in 0..3 {
            received.push(rx.recv().unwrap());
        }
        received.sort();
        assert_eq!(received, vec!["a", "b", "c"]);
    }

    #[test]
    fn sender_cloneable() {
        let (tx1, _rx) = channel::<i32>(10);
        let tx2 = tx1.clone();
        let tx3 = tx2.clone();
        // All should be able to send
        tx1.send(1).unwrap();
        tx2.send(2).unwrap();
        tx3.send(3).unwrap();
    }

    #[test]
    fn receiver_drop_causes_send_error() {
        let (tx, rx) = channel(10);
        drop(rx);
        assert!(tx.send(42).is_err());
    }

    #[test]
    fn sender_drop_causes_recv_disconnect() {
        let (tx, rx) = channel::<i32>(10);
        drop(tx);
        assert!(rx.recv().is_err()); // Disconnected
    }

    #[test]
    fn select_hooks() {
        let (tx, rx) = channel(10);

        // Initially not ready
        assert!(!rx.is_ready());

        // Send something
        tx.send(42).unwrap();
        assert!(rx.is_ready());

        // Complete recv
        assert_eq!(rx.complete_recv().unwrap(), 42);
        assert!(!rx.is_ready());
    }

    #[test]
    fn zero_capacity() {
        let (tx, rx) = channel::<i32>(0);
        assert!(tx.send(42).is_err()); // Can't send to zero capacity
        // Receiver not ready until sender drops
        assert!(!rx.is_ready());
        drop(tx);
        assert!(rx.is_ready());
        assert!(rx.recv().is_err()); // Disconnected
    }

    #[test]
    fn concurrent_send_recv() {
        let (tx, rx) = channel(100);

        let handle = thread::spawn(move || {
            for i in 0..50 {
                tx.send(i).unwrap();
            }
        });

        handle.join().unwrap();

        for i in 0..50 {
            assert_eq!(rx.recv().unwrap(), i);
        }
    }

    #[test]
    fn fifo_ordering() {
        let (tx, rx) = channel(16);
        for i in 0..8u32 {
            tx.send(i).unwrap();
        }
        for i in 0..8u32 {
            assert_eq!(rx.recv().unwrap(), i);
        }
    }

    #[test]
    fn blocking_recv_woken_by_disconnect() {
        let (tx, rx) = channel::<i32>(4);
        let handle = thread::spawn(move || rx.recv());
        thread::sleep(Duration::from_millis(20));
        drop(tx);
        assert_eq!(
            handle.join().unwrap(),
            Err(crate::error::RecvError::Disconnected)
        );
    }

    #[test]
    fn blocking_recv_drains_before_disconnect() {
        let (tx, rx) = channel(4);
        tx.send(1).unwrap();
        tx.send(2).unwrap();
        drop(tx);
        // Items buffered before sender drop are still returned.
        assert_eq!(rx.recv().unwrap(), 1);
        assert_eq!(rx.recv().unwrap(), 2);
        assert!(rx.recv().is_err());
    }

    #[test]
    fn drop_values_in_buffer() {
        use std::sync::Arc;
        use std::sync::atomic::{AtomicUsize, Ordering};

        let counter = Arc::new(AtomicUsize::new(0));

        #[derive(Debug)]
        struct Guard(Arc<AtomicUsize>);
        impl Drop for Guard {
            fn drop(&mut self) {
                self.0.fetch_add(1, Ordering::Relaxed);
            }
        }

        let (tx, rx) = channel(4);
        tx.send(Guard(Arc::clone(&counter))).unwrap();
        tx.send(Guard(Arc::clone(&counter))).unwrap();
        drop(tx);
        drop(rx); // Both Guards should be dropped via the channel's Drop impl.
        assert_eq!(counter.load(Ordering::Relaxed), 2);
    }

    #[test]
    fn send_select_wakes_when_receiver_pops() {
        // Fill the buffer so is_ready() returns false for the sender.
        let (tx, rx) = channel::<i32>(1);
        tx.send(1).unwrap(); // full

        let tx2 = tx.clone();
        // Spawn a thread that will wait on the send select arm.
        let sent = std::sync::Arc::new(std::sync::atomic::AtomicBool::new(false));
        let sent2 = std::sync::Arc::clone(&sent);
        let handle = thread::spawn(move || {
            select! {
                send(tx2, 99) -> res => {
                    assert!(res.is_ok());
                    sent2.store(true, std::sync::atomic::Ordering::Relaxed);
                },
            }
        });

        thread::sleep(Duration::from_millis(20));
        // Pop from buffer to create space → wakes the send-select arm.
        assert_eq!(rx.recv().unwrap(), 1);
        handle.join().unwrap();
        assert!(sent.load(std::sync::atomic::Ordering::Relaxed));
        assert_eq!(rx.recv().unwrap(), 99);
    }
}