selectables 0.1.0

Lock-free channels with a unified select! macro for recv and send arms
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
//! Single-send, single-delivery channel for one-time messages.
//!
//! # Overview
//!
//! A oneshot channel allows exactly one sender to deliver exactly one message to one receiver.
//! Perfect for one-time responses, futures resolution, and join semantics. Once a value is
//! sent or either end is dropped, the channel is "consumed".
//!
//! # Semantics
//!
//! - `Sender` can only call `send()` once; consumes the sender
//! - `Receiver` can only call `recv()` once; consumes the receiver
//! - Attempting to send twice is a compile error (type state: `Sender` moves into itself on send)
//! - If sender drops without sending, receiver gets `RecvError::Disconnected`
//! - If receiver drops without receiving, sender's `send()` returns `SendError(value)`
//!
//! # Lock-free storage
//!
//! - Value stored in `ArcSwapOption<ValueCell<T>>` for atomic single-take semantics
//! - `recv()` uses CAS to atomically take the value exactly once
//! - No spurious wakeups: atomic check-before-park pattern
//!
//! # Example
//!
//! ```ignore
//! let (tx, rx) = oneshot::channel();
//!
//! std::thread::spawn(move || {
//!     std::thread::sleep(Duration::from_millis(10));
//!     tx.send("done").ok(); // Consumes tx
//! });
//!
//! // Blocks until sender sends or drops
//! match rx.recv() {
//!     Ok(msg) => println!("Got: {}", msg),
//!     Err(RecvError::Disconnected) => println!("Sender dropped"),
//!     Err(RecvError::Lagged { .. }) => unreachable!("oneshot cannot lag"),
//! }
//! ```
//!
//! # Integration with select!
//!
//! Oneshot receivers work in select arms just like other channels:
//!
//! ```ignore
//! let (tx_data, rx_data) = unbounded_mpmc::channel();
//! let (tx_once, rx_once) = oneshot::channel();
//!
//! select! {
//!     recv(rx_data) -> msg => println!("Data: {:?}", msg),
//!     recv(rx_once) -> msg => println!("Once: {:?}", msg),
//! }
//! ```

use std::sync::{
    Arc,
    atomic::{AtomicPtr, AtomicUsize, Ordering::*},
};
use std::thread;

use arc_swap::ArcSwapOption;

use crate::{
    error::{RecvError, SendError, TryRecvError},
    waiter::{
        RecvWaiter, RecvWaiterGuard, RecvWaiterList, SelectWaiter, UNSELECTED,
        abort_select_waiters, drain_select_waiters, new_recv_waiter_list, push_select_waiter,
        wake_all_recv_waiters, wake_one_recv_waiter, wake_select_all, wake_select_one,
    },
};

const SENDER_OPEN: usize = 0;
const SENDER_SENT: usize = 1;
const SENDER_DROPPED: usize = 2;

struct ValueCell<T> {
    taken: std::sync::atomic::AtomicBool,
    value: std::cell::UnsafeCell<std::mem::MaybeUninit<T>>,
}

// SAFETY: ValueCell only exposes mutation through atomic single-take CAS.
unsafe impl<T: Send> Send for ValueCell<T> {}
// SAFETY: Shared access is synchronized by `taken` and ownership protocol.
unsafe impl<T: Send> Sync for ValueCell<T> {}

impl<T> ValueCell<T> {
    fn new(value: T) -> Self {
        ValueCell {
            taken: std::sync::atomic::AtomicBool::new(false),
            value: std::cell::UnsafeCell::new(std::mem::MaybeUninit::new(value)),
        }
    }

    fn take(&self) -> Option<T> {
        if self
            .taken
            .compare_exchange(false, true, AcqRel, Acquire)
            .is_err()
        {
            return None;
        }
        // SAFETY: successful CAS grants unique ownership of initialized value.
        Some(unsafe { (*self.value.get()).assume_init_read() })
    }
}

impl<T> Drop for ValueCell<T> {
    fn drop(&mut self) {
        if !*self.taken.get_mut() {
            // SAFETY: value is initialized iff it was never taken.
            unsafe { (*self.value.get()).assume_init_drop() };
        }
    }
}

pub(crate) struct Chan<T> {
    value: ArcSwapOption<ValueCell<T>>,
    // Lock-free stack for simple recv() waiters
    recv_waiters: RecvWaiterList,
    // Lock-free stack for select() waiters (heap-allocated SelectWaiter nodes)
    select_waiters: Arc<AtomicPtr<SelectWaiter>>,
    sender_state: AtomicUsize,
    receiver_count: AtomicUsize,
}

pub struct Sender<T>(pub(crate) Arc<Chan<T>>);

impl<T> Sender<T> {
    pub fn send(self, val: T) -> Result<(), SendError<T>> {
        if self.0.receiver_count.load(Acquire) == 0 {
            return Err(SendError(val));
        }

        if self.0.receiver_count.load(Acquire) == 0 {
            return Err(SendError(val));
        }

        self.0.value.store(Some(Arc::new(ValueCell::new(val))));

        self.0.sender_state.store(SENDER_SENT, Release);
        // Wake one from recv lock-free stack
        wake_one_recv_waiter(&self.0.recv_waiters, UNSELECTED);
        // Wake one select waiter (lock-free)
        wake_select_one(&self.0.select_waiters);
        Ok(())
    }
}

impl<T> Drop for Sender<T> {
    fn drop(&mut self) {
        if self
            .0
            .sender_state
            .compare_exchange(SENDER_OPEN, SENDER_DROPPED, AcqRel, Acquire)
            .is_ok()
        {
            // Wake all recv waiters (lock-free)
            wake_all_recv_waiters(&self.0.recv_waiters, UNSELECTED);
            // Wake all select waiters (lock-free, frees nodes)
            wake_select_all(&self.0.select_waiters);
        }
    }
}

pub struct Receiver<T>(pub(crate) Arc<Chan<T>>);

impl<T> Clone for Receiver<T> {
    fn clone(&self) -> Self {
        self.0.receiver_count.fetch_add(1, Relaxed);
        Receiver(Arc::clone(&self.0))
    }
}

impl<T> Drop for Receiver<T> {
    fn drop(&mut self) {
        let prev = self.0.receiver_count.fetch_sub(1, Release);
        if prev == 1 {
            // Last receiver dropped — drain any heap-allocated select waiters
            // to avoid memory leaks.
            drain_select_waiters(&self.0.select_waiters);
        }
    }
}

impl<T> Receiver<T> {
    pub fn try_recv(&self) -> Result<T, TryRecvError> {
        if self.0.sender_state.load(Acquire) == SENDER_SENT {
            if let Some(cell) = self.0.value.swap(None) {
                if let Some(val) = cell.take() {
                    return Ok(val);
                }
            }
            return Err(TryRecvError::Disconnected);
        }

        if self.0.sender_state.load(Acquire) == SENDER_OPEN {
            Err(TryRecvError::Empty)
        } else {
            Err(TryRecvError::Disconnected)
        }
    }

    pub fn recv(&self) -> Result<T, RecvError> {
        let marker = Arc::new(AtomicUsize::new(UNSELECTED));
        loop {
            match self.try_recv() {
                Ok(v) => return Ok(v),
                Err(TryRecvError::Disconnected) => return Err(RecvError::Disconnected),
                Err(TryRecvError::Lagged { skipped }) => {
                    return Err(RecvError::Lagged { skipped });
                }
                Err(TryRecvError::Empty) => {}
            }

            // TOCTOU check before parking: try_recv again and check sender state
            if let Some(v) = self.try_recv().ok() {
                return Ok(v);
            }
            if self.0.sender_state.load(Acquire) != SENDER_OPEN {
                return Err(RecvError::Disconnected);
            }

            // Create waiter and push onto lock-free stack (recv path only)
            let waiter = RecvWaiter::new(usize::MAX, Arc::clone(&marker));
            let _guard = RecvWaiterGuard::register(waiter, &self.0.recv_waiters);

            // Another TOCTOU check after pushing (sender might have sent while we pushed)
            if let Some(v) = self.try_recv().ok() {
                return Ok(v);
            }
            if self.0.sender_state.load(Acquire) != SENDER_OPEN {
                return Err(RecvError::Disconnected);
            }

            // Check if we were already selected (by sender)
            if marker.load(Acquire) != UNSELECTED {
                // Sender beat us to marking; try recv again
                if let Some(v) = self.try_recv().ok() {
                    return Ok(v);
                }
                // Sender said done but value not available (race); treat as disconnected
                return Err(RecvError::Disconnected);
            }

            // Park until woken
            thread::park();
        }
    }

    pub(crate) fn is_ready(&self) -> bool {
        self.0.sender_state.load(Acquire) != SENDER_OPEN
    }

    pub(crate) fn register_select(&self, case_id: usize, selected: Arc<AtomicUsize>) {
        // Fast check: if channel already delivered/dropped, no need to register.
        if self.0.sender_state.load(Acquire) != SENDER_OPEN {
            return;
        }
        // Allocate and push onto lock-free stack. Node is freed by sender or drain.
        let ptr = SelectWaiter::alloc(case_id, selected);
        push_select_waiter(ptr, &self.0.select_waiters);
    }

    pub(crate) fn abort_select(&self, selected: &Arc<AtomicUsize>) {
        // Mark matching nodes as aborted (O(n) traversal, O(1) per node).
        // Nodes are freed when the sender next iterates the stack.
        abort_select_waiters(&self.0.select_waiters, selected);
    }

    pub fn complete_recv(&self) -> Result<T, RecvError> {
        self.recv()
    }
}

impl<T> crate::SelectableReceiver for Receiver<T> {
    type Output = T;

    fn is_ready(&self) -> bool {
        self.is_ready()
    }

    fn register_select(
        &self,
        case_id: usize,
        selected: std::sync::Arc<std::sync::atomic::AtomicUsize>,
    ) {
        self.register_select(case_id, selected)
    }

    fn abort_select(&self, selected: &std::sync::Arc<std::sync::atomic::AtomicUsize>) {
        self.abort_select(selected)
    }

    fn complete(&self) -> Result<Self::Output, crate::RecvError> {
        self.complete_recv()
    }
}

pub fn channel<T>() -> (Sender<T>, Receiver<T>) {
    let chan = Arc::new(Chan {
        value: ArcSwapOption::empty(),
        recv_waiters: new_recv_waiter_list(),
        select_waiters: Arc::new(AtomicPtr::new(std::ptr::null_mut())),
        sender_state: AtomicUsize::new(SENDER_OPEN),
        receiver_count: AtomicUsize::new(1),
    });
    (Sender(Arc::clone(&chan)), Receiver(chan))
}

#[cfg(test)]
mod tests {
    use std::thread;
    use std::time::Duration;

    use crate::{select, unbounded_mpmc};

    use super::*;

    #[test]
    fn basic_send_recv() {
        let (tx, rx) = channel();
        tx.send(42).unwrap();
        assert_eq!(rx.recv(), Ok(42));
    }

    #[test]
    fn try_recv_empty_then_value() {
        let (tx, rx) = channel();
        assert_eq!(rx.try_recv(), Err(TryRecvError::Empty));
        tx.send(7).unwrap();
        assert_eq!(rx.try_recv(), Ok(7));
    }

    #[test]
    fn sender_drop_disconnects_receiver() {
        let (tx, rx) = channel::<i32>();
        drop(tx);
        assert_eq!(rx.recv(), Err(RecvError::Disconnected));
    }

    #[test]
    fn receiver_drop_causes_send_error() {
        let (tx, rx) = channel::<i32>();
        drop(rx);
        assert_eq!(tx.send(10), Err(SendError(10)));
    }

    #[test]
    fn single_delivery_across_clones() {
        let (tx, rx) = channel();
        let rx2 = rx.clone();
        tx.send(11).unwrap();

        let a = rx.try_recv();
        let b = rx2.try_recv();

        assert!(matches!(a, Ok(11)) || matches!(b, Ok(11)));
        assert!(
            matches!(a, Err(TryRecvError::Disconnected))
                || matches!(b, Err(TryRecvError::Disconnected))
        );
    }

    #[test]
    fn select_with_default_timeout_and_mixed_arms() {
        let (otx, orx) = channel::<&str>();
        let (tx, rx) = unbounded_mpmc::channel::<i32>();

        select! {
            recv(orx) -> _msg => panic!("oneshot must not be ready yet"),
            recv(rx) -> _msg => panic!("mpmc must not be ready yet"),
            default => {}
        }

        thread::spawn(move || {
            thread::sleep(Duration::from_millis(10));
            otx.send("done").unwrap();
            let _ = tx.send(1);
        });

        select! {
            recv(orx) -> msg => assert_eq!(msg, Ok("done")),
            recv(rx) -> _msg => panic!("oneshot should win this race"),
        }
    }

    #[test]
    fn blocking_recv_waits_for_send() {
        let (tx, rx) = channel::<i32>();
        let handle = thread::spawn(move || rx.recv().unwrap());
        thread::sleep(Duration::from_millis(20));
        tx.send(77).unwrap();
        assert_eq!(handle.join().unwrap(), 77);
    }

    #[test]
    fn try_recv_disconnected_after_delivery() {
        let (tx, rx) = channel::<i32>();
        tx.send(42).unwrap();
        assert_eq!(rx.try_recv(), Ok(42));
        // After the value was taken the sender end is gone too; Disconnected.
        assert_eq!(rx.try_recv(), Err(TryRecvError::Disconnected));
    }

    #[test]
    fn is_ready_reflects_state() {
        let (tx, rx) = channel::<i32>();
        assert!(!rx.is_ready());
        tx.send(1).unwrap();
        assert!(rx.is_ready());
        rx.complete_recv().unwrap();
        // After delivery the value is gone and sender is consumed; Disconnected → ready.
        assert!(rx.is_ready());
    }

    #[test]
    fn complete_recv_blocks_if_not_yet_sent() {
        let (tx, rx) = channel::<i32>();
        let handle = thread::spawn(move || rx.complete_recv().unwrap());
        thread::sleep(Duration::from_millis(15));
        tx.send(5).unwrap();
        assert_eq!(handle.join().unwrap(), 5);
    }
}