secunit-core 0.6.1

Registry, evidence, hashing, and verification primitives for secunit.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
//! Integration tests for the report data assembler. Stages the
//! multi-system fixture, seals real runs through the runner, then asserts
//! the assembled payload counts them — including the PLAN Phase 6 case of
//! a weekly control that missed consecutive periods.

use std::fs;
use std::path::{Path, PathBuf};

use chrono::NaiveDate;
use secunit_core::evidence::manifest::{RunOutcome, RunResult, SystemOutcome, SystemResult};
use secunit_core::evidence::runner::{self, PrepareOpts};
use secunit_core::model::Cadence;
use secunit_core::registry::loader;
use secunit_core::reports;
use secunit_core::risks::{self, FindingRef, Severity, Status};
use secunit_core::SCHEMA_VERSION;
use tempfile::TempDir;
use walkdir::WalkDir;

const CONTROL: &str = "sca-weekly-dependency-scan";

fn fixture_root() -> PathBuf {
    PathBuf::from(env!("CARGO_MANIFEST_DIR"))
        .join("../..")
        .join("testdata/orgs/multi-system")
        .canonicalize()
        .expect("fixture must exist")
}

fn staged_fixture() -> (TempDir, PathBuf) {
    let src = fixture_root();
    let tmp = tempfile::tempdir().expect("tempdir");
    let dst = tmp.path().to_path_buf();
    copy_tree(&src, &dst);
    git_init_and_commit(&dst);
    (tmp, dst)
}

fn git_init_and_commit(root: &Path) {
    use std::process::Command;
    // Build the placeholder identity dynamically so source scanners
    // don't flag a literal placeholder email.
    let identity_email = format!("test{at}local.invalid", at = "@");
    let run = |args: &[&str]| {
        let status = Command::new("git")
            .current_dir(root)
            .args(args)
            .status()
            .expect("git in PATH");
        assert!(status.success(), "git {args:?} failed");
    };
    run(&["init", "-q", "-b", "main"]);
    run(&["config", "user.email", &identity_email]);
    run(&["config", "user.name", "test"]);
    run(&["add", "-A"]);
    run(&["commit", "-q", "-m", "fixture import"]);
}

fn copy_tree(src: &Path, dst: &Path) {
    fs::create_dir_all(dst).unwrap();
    for entry in WalkDir::new(src) {
        let entry = entry.unwrap();
        let rel = entry.path().strip_prefix(src).unwrap();
        let target = dst.join(rel);
        if entry.file_type().is_dir() {
            fs::create_dir_all(&target).unwrap();
        } else if entry.file_type().is_file() {
            if let Some(parent) = target.parent() {
                fs::create_dir_all(parent).unwrap();
            }
            fs::copy(entry.path(), &target).unwrap();
        }
    }
}

/// Seal one complete run of `CONTROL` stamped at `today` (noon UTC).
fn run_one(root: &Path, today: NaiveDate) {
    run_one_claiming(root, today, None);
}

/// Like [`run_one`], but claiming an explicit period (the `--period`
/// catch-up flow).
fn run_one_claiming(root: &Path, today: NaiveDate, period_id: Option<&str>) {
    let (reg, report) = loader::load(root);
    assert!(report.errors.is_empty(), "load errors: {:?}", report.errors);

    let opts = PrepareOpts {
        today: Some(today),
        period_id: period_id.map(str::to_string),
        ..Default::default()
    };
    let ctx = runner::prepare(&reg, CONTROL, &opts).expect("prepare");

    for sys in &ctx.resolved_scope {
        let raw = ctx.run_dir.join("by-system").join(&sys.name).join("raw");
        fs::write(
            raw.join("scan.json"),
            format!("{{\"system\":\"{}\"}}", sys.name),
        )
        .unwrap();
    }
    fs::write(ctx.run_dir.join("findings.md"), b"# findings\nnone\n").unwrap();

    let result = RunResult {
        schema_version: SCHEMA_VERSION,
        control_id: ctx.control_id.clone(),
        run_id: ctx.run_id.clone(),
        status: RunOutcome::Complete,
        by_system: ctx
            .resolved_scope
            .iter()
            .map(|s| SystemResult {
                name: s.name.clone(),
                status: SystemOutcome::Complete,
                note: None,
            })
            .collect(),
        draft_risks: Vec::new(),
        draft_issues: Vec::new(),
        external_links: Vec::new(),
    };
    fs::write(
        ctx.run_dir.join("result.json"),
        serde_json::to_vec_pretty(&result).unwrap(),
    )
    .unwrap();

    let completed_at = today.and_hms_opt(12, 0, 0).unwrap().and_utc();
    runner::finalize_at(&reg, &ctx.run_dir, completed_at).expect("finalize");
}

fn d(y: i32, m: u32, day: u32) -> NaiveDate {
    NaiveDate::from_ymd_opt(y, m, day).unwrap()
}

#[test]
fn monthly_window_counts_runs_and_surfaces_missed_weeks() {
    let (_tmp, root) = staged_fixture();

    // Seal W19 and W20; leave W18, W21, W22 unrun. May 2026 touches ISO
    // weeks W18 (Apr 27) through W22 (May 25).
    run_one(&root, d(2026, 5, 4)); // W19
    run_one(&root, d(2026, 5, 11)); // W20

    let (reg, _) = loader::load(&root);
    let data = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 6, 1),
    )
    .expect("assemble");

    assert_eq!(data.period.label, "2026-05");
    let sca = data
        .controls
        .iter()
        .find(|c| c.id == CONTROL)
        .expect("weekly control present");

    assert_eq!(sca.counts.satisfied, 2, "W19 + W20 sealed");
    assert_eq!(
        sca.counts.gaps, 3,
        "W18, W21, W22 missed — the report must call out consecutive misses"
    );
    assert_eq!(sca.runs.len(), 2);
    assert!(sca.runs.iter().all(|r| r.path.starts_with("evidence/")));
    assert_eq!(data.totals.runs, 2);
    assert!(data.totals.gaps >= 2);

    // overdue follows the resolver, matching `secunit due`: a cached due
    // date that passed without a completed run holds (and is past the
    // 3-day weekly grace by 2026-06-01), so the never-refreshed weekly
    // control is overdue — and not double-listed under upcoming.
    let aa = data
        .overdue
        .iter()
        .find(|o| o.id == "aa-weekly-audit-review")
        .expect("stale weekly control should be overdue");
    assert_eq!(aa.next_due, d(2026, 5, 4));
    assert_eq!(aa.days_overdue, 28);
    assert!(
        !data
            .upcoming
            .iter()
            .any(|u| u.id == "aa-weekly-audit-review"),
        "an overdue control belongs in overdue, not upcoming"
    );
}

#[test]
fn weekly_window_scopes_to_one_week() {
    let (_tmp, root) = staged_fixture();
    run_one(&root, d(2026, 5, 4)); // W19

    let (reg, _) = loader::load(&root);
    let data = reports::assemble(
        &reg,
        "2026-W19",
        Cadence::Weekly,
        d(2026, 5, 4),
        d(2026, 5, 10),
        d(2026, 5, 11),
    )
    .expect("assemble");

    let sca = data.controls.iter().find(|c| c.id == CONTROL).unwrap();
    assert_eq!(sca.periods.len(), 1);
    assert_eq!(sca.periods[0].period_id, "2026-W19");
    assert_eq!(sca.counts.satisfied, 1);
    assert_eq!(sca.counts.gaps, 0);
    assert_eq!(sca.runs.len(), 1);

    // The quarterly control's surrounding period appears for context.
    let vuln = data
        .controls
        .iter()
        .find(|c| c.id == "ca-quarterly-vuln-scan")
        .expect("quarterly control present");
    assert_eq!(vuln.periods[0].period_id, "2026-q2");
}

#[test]
fn risk_register_delta_counts_events_in_window() {
    let (_tmp, root) = staged_fixture();

    let finding_ref = |fid: &str| FindingRef {
        control_id: CONTROL.to_string(),
        run_id: "2026-05-04-run-001".to_string(),
        manifest_sha256: "0".repeat(64),
        finding_id: fid.to_string(),
        body_path: None,
    };
    let ts = |day: u32| d(2026, 5, day).and_hms_opt(9, 0, 0).unwrap().and_utc();

    // Opened in May, still open, past SLA by report time.
    let r1 = risks::open(
        &root,
        finding_ref("F-001"),
        "vulnerable dependency",
        Severity::High,
        4,
        3,
        vec!["api".into()],
        7,
        d(2026, 5, 12),
        "tester",
        None,
        Some(ts(5)),
    )
    .expect("open r1");

    // Opened in May and remediated in May.
    let r2 = risks::open(
        &root,
        finding_ref("F-002"),
        "stale access grant",
        Severity::Medium,
        3,
        2,
        vec!["api".into()],
        30,
        d(2026, 6, 4),
        "tester",
        None,
        Some(ts(6)),
    )
    .expect("open r2");
    risks::append(
        &root,
        &r2.risk_id,
        risks::EventData::StatusChanged {
            from: Status::Open,
            to: Status::InProgress,
            reason: "assigned".into(),
        },
        "tester",
        None,
        Some(ts(15)),
    )
    .expect("start r2");
    risks::append(
        &root,
        &r2.risk_id,
        risks::EventData::Remediated {
            resolved_run_ref: None,
            note: "revoked".into(),
        },
        "tester",
        None,
        Some(ts(20)),
    )
    .expect("remediate r2");

    let (reg, _) = loader::load(&root);
    let data = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 6, 1),
    )
    .expect("assemble");

    assert_eq!(data.risks.opened_in_period, 2);
    assert_eq!(data.risks.reopened_in_period, 0);
    assert_eq!(data.risks.closed_in_period, 1);
    assert_eq!(data.risks.open.len(), 1);
    assert_eq!(data.risks.open[0].risk_id, r1.risk_id);
    assert_eq!(data.risks.open[0].status, Status::Open);
    assert!(data.risks.open[0].past_sla, "due 5-12 < today 6-1");
    assert_eq!(data.risks.past_sla, 1);
    assert_eq!(
        data.risks.open[0].source_control.as_deref(),
        Some(CONTROL),
        "open risk traces back to its source control"
    );

    // A June window sees no May events and one still-open risk.
    let june = reports::assemble(
        &reg,
        "2026-06",
        Cadence::Monthly,
        d(2026, 6, 1),
        d(2026, 6, 30),
        d(2026, 6, 15),
    )
    .expect("assemble june");
    assert_eq!(june.risks.opened_in_period, 0);
    assert_eq!(june.risks.closed_in_period, 0);
    assert_eq!(june.risks.open.len(), 1);
}

#[test]
fn risk_delta_counts_per_risk_through_reopen_churn() {
    let (_tmp, root) = staged_fixture();

    let finding_ref = |fid: &str| FindingRef {
        control_id: CONTROL.to_string(),
        run_id: "2026-05-04-run-001".to_string(),
        manifest_sha256: "0".repeat(64),
        finding_id: fid.to_string(),
        body_path: None,
    };
    let ts = |m: u32, day: u32| d(2026, m, day).and_hms_opt(9, 0, 0).unwrap().and_utc();
    let start = |root: &Path, id: &str, when| {
        risks::append(
            root,
            id,
            risks::EventData::StatusChanged {
                from: Status::Open,
                to: Status::InProgress,
                reason: "assigned".into(),
            },
            "tester",
            None,
            Some(when),
        )
        .expect("start");
    };
    let remediate = |root: &Path, id: &str, when| {
        risks::append(
            root,
            id,
            risks::EventData::Remediated {
                resolved_run_ref: None,
                note: "fixed".into(),
            },
            "tester",
            None,
            Some(when),
        )
        .expect("remediate");
    };
    let reopen = |root: &Path, id: &str, when| {
        risks::append(
            root,
            id,
            risks::EventData::Reopened {
                reason: "regressed".into(),
            },
            "tester",
            None,
            Some(when),
        )
        .expect("reopen");
    };

    // r1: closed, reopened, and closed again all inside May — one risk,
    // one closure, one reopen; never double-counted.
    let r1 = risks::open(
        &root,
        finding_ref("F-010"),
        "flapping control drift",
        Severity::Medium,
        3,
        2,
        vec!["api".into()],
        30,
        d(2026, 6, 1),
        "tester",
        None,
        Some(ts(5, 2)),
    )
    .expect("open r1");
    start(&root, &r1.risk_id, ts(5, 3));
    remediate(&root, &r1.risk_id, ts(5, 5));
    reopen(&root, &r1.risk_id, ts(5, 10));
    start(&root, &r1.risk_id, ts(5, 11));
    remediate(&root, &r1.risk_id, ts(5, 20));

    // r2: remediated in April, reopened in May, still open — must count
    // as reopened, not vanish from the delta while growing the open list.
    let r2 = risks::open(
        &root,
        finding_ref("F-011"),
        "regressed hardening",
        Severity::High,
        4,
        3,
        vec!["api".into()],
        30,
        d(2026, 5, 10),
        "tester",
        None,
        Some(ts(4, 2)),
    )
    .expect("open r2");
    start(&root, &r2.risk_id, ts(4, 3));
    remediate(&root, &r2.risk_id, ts(4, 10));
    reopen(&root, &r2.risk_id, ts(5, 12));

    let (reg, _) = loader::load(&root);
    let may = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 6, 1),
    )
    .expect("assemble may");

    assert_eq!(may.risks.opened_in_period, 1, "only r1 was created in May");
    assert_eq!(may.risks.reopened_in_period, 2, "r1 and r2 both reopened");
    assert_eq!(
        may.risks.closed_in_period, 1,
        "r1's double close counts once; r2's April close is out of window"
    );
    assert_eq!(may.risks.open.len(), 1, "only r2 is open at report time");
    assert_eq!(may.risks.open[0].risk_id, r2.risk_id);

    // April: r2's close was undone by a May reopen — but at April's end it
    // stood closed, so April's report still counts it.
    let april = reports::assemble(
        &reg,
        "2026-04",
        Cadence::Monthly,
        d(2026, 4, 1),
        d(2026, 4, 30),
        d(2026, 6, 1),
    )
    .expect("assemble april");
    assert_eq!(april.risks.opened_in_period, 1);
    assert_eq!(april.risks.closed_in_period, 1, "closed as of April 30");
    assert_eq!(april.risks.reopened_in_period, 0);
}

#[test]
fn catch_up_run_sealed_in_window_is_reported() {
    let (_tmp, root) = staged_fixture();
    // W18 was missed; the catch-up run seals on Tuesday of W19 while
    // claiming the prior week — the flow report.md documents.
    run_one_claiming(&root, d(2026, 5, 5), Some("2026-W18"));

    let (reg, _) = loader::load(&root);
    let data = reports::assemble(
        &reg,
        "2026-W19",
        Cadence::Weekly,
        d(2026, 5, 4),
        d(2026, 5, 10),
        d(2026, 5, 11),
    )
    .expect("assemble");

    let sca = data.controls.iter().find(|c| c.id == CONTROL).unwrap();
    assert_eq!(
        sca.runs.len(),
        1,
        "a run sealed inside W19 must appear even though it claims W18"
    );
    assert_eq!(sca.runs[0].period_id.as_deref(), Some("2026-W18"));
    // The claimed period is outside the window, so W19 itself stays
    // unsatisfied — the run is activity context, not period coverage.
    assert_eq!(sca.counts.satisfied, 0);
}

#[test]
fn corrupt_risk_log_degrades_to_register_error() {
    let (_tmp, root) = staged_fixture();

    let finding_ref = |fid: &str| FindingRef {
        control_id: CONTROL.to_string(),
        run_id: "2026-05-04-run-001".to_string(),
        manifest_sha256: "0".repeat(64),
        finding_id: fid.to_string(),
        body_path: None,
    };
    let ts = d(2026, 5, 5).and_hms_opt(9, 0, 0).unwrap().and_utc();
    let good = risks::open(
        &root,
        finding_ref("F-001"),
        "vulnerable dependency",
        Severity::High,
        4,
        3,
        vec!["api".into()],
        30,
        d(2026, 6, 4),
        "tester",
        None,
        Some(ts),
    )
    .expect("open good risk");
    let bad = risks::open(
        &root,
        finding_ref("F-002"),
        "stale access grant",
        Severity::Medium,
        3,
        2,
        vec!["api".into()],
        30,
        d(2026, 6, 4),
        "tester",
        None,
        Some(ts),
    )
    .expect("open bad risk");
    // Truncate the second log mid-line — a crashed append.
    let log = root.join("risks").join(&bad.risk_id).join("events.jsonl");
    let text = fs::read_to_string(&log).unwrap();
    fs::write(&log, &text[..text.len() / 2]).unwrap();

    let (reg, _) = loader::load(&root);
    let data = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 6, 1),
    )
    .expect("one broken log must not abort the report");

    assert_eq!(data.risks.opened_in_period, 1, "good risk still counted");
    assert_eq!(data.risks.open.len(), 1);
    assert_eq!(data.risks.open[0].risk_id, good.risk_id);
    assert_eq!(data.risks.register_errors.len(), 1);
    assert_eq!(data.risks.register_errors[0].risk_id, bad.risk_id);
    // Diagnostics are store-relative — these strings get headlined and
    // possibly published, so the absolute root must not leak.
    let err = &data.risks.register_errors[0].error;
    assert!(
        !err.contains(&root.display().to_string()),
        "error leaks the store root: {err}"
    );
    assert!(
        err.contains("risks/"),
        "error should keep the relative path: {err}"
    );
}

#[test]
fn late_assembly_looks_forward_from_today() {
    let (_tmp, root) = staged_fixture();
    let (reg, _) = loader::load(&root);

    // May's report assembled on 2026-07-10 — well past June, the period
    // the horizon would naively end at. The horizon floors at the period
    // containing today, so July dues still surface.
    let data = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 7, 10),
    )
    .expect("assemble late");

    assert_eq!(data.period.horizon, d(2026, 7, 31), "end of today's month");
    assert_eq!(data.period.cadence, Cadence::Monthly);

    // Every resolver row with an in-horizon due date lands in exactly one
    // list — nothing due soon may vanish just because the report is late.
    for row in secunit_core::registry::resolver::due_rows(&reg, d(2026, 7, 10)) {
        let Some(next_due) = row.next_due else {
            continue;
        };
        if next_due > data.period.horizon {
            continue;
        }
        let in_overdue = data.overdue.iter().any(|o| o.id == row.control_id);
        let in_upcoming = data.upcoming.iter().any(|u| u.id == row.control_id);
        assert!(
            in_overdue ^ in_upcoming,
            "{} (due {next_due}) must appear in exactly one of overdue/upcoming",
            row.control_id
        );
    }
}

#[test]
fn corrupt_manifest_degrades_to_manifest_error() {
    let (_tmp, root) = staged_fixture();
    run_one(&root, d(2026, 5, 4)); // W19
    run_one(&root, d(2026, 5, 11)); // W20

    // Truncate W19's manifest mid-file — present but unparseable.
    let w19_dir = root.join("evidence/2026/q2");
    let run_dir = fs::read_dir(w19_dir.join(CONTROL))
        .unwrap()
        .map(|e| e.unwrap().path())
        .min()
        .unwrap();
    let mpath = run_dir.join("manifest.json");
    let text = fs::read_to_string(&mpath).unwrap();
    fs::write(&mpath, &text[..text.len() / 2]).unwrap();

    let (reg, _) = loader::load(&root);
    let data = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 6, 1),
    )
    .expect("one corrupt manifest must not abort the report");

    let sca = data.controls.iter().find(|c| c.id == CONTROL).unwrap();
    assert_eq!(sca.runs.len(), 1, "W20 still counted");
    assert_eq!(data.manifest_errors.len(), 1);
    let err = &data.manifest_errors[0];
    assert_eq!(err.control_id, CONTROL);
    assert!(
        err.path.starts_with("evidence/"),
        "path must be store-relative: {}",
        err.path
    );
    assert!(err.error.contains("parse manifest.json"));
}

#[test]
fn lapsed_accepted_exception_is_surfaced() {
    let (_tmp, root) = staged_fixture();

    let finding_ref = FindingRef {
        control_id: CONTROL.to_string(),
        run_id: "2026-05-04-run-001".to_string(),
        manifest_sha256: "0".repeat(64),
        finding_id: "F-001".to_string(),
        body_path: None,
    };
    let ts = |day: u32| d(2026, 5, day).and_hms_opt(9, 0, 0).unwrap().and_utc();
    let r = risks::open(
        &root,
        finding_ref,
        "single-region BCP exposure",
        Severity::High,
        4,
        3,
        vec!["api".into()],
        30,
        d(2026, 6, 3),
        "tester",
        None,
        Some(ts(4)),
    )
    .expect("open");
    risks::append(
        &root,
        &r.risk_id,
        risks::EventData::ExceptionDocumented {
            rationale: "accepted for the quarter".into(),
            approved_by: "cto".into(),
            expires_at: d(2026, 5, 20),
        },
        "tester",
        None,
        Some(ts(5)),
    )
    .expect("except");

    let (reg, _) = loader::load(&root);
    let data = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 6, 1),
    )
    .expect("assemble");

    // Not open — but the pass expired May 20, so it must not vanish.
    assert!(data.risks.open.is_empty());
    assert_eq!(data.risks.lapsed_exceptions.len(), 1);
    let lapsed = &data.risks.lapsed_exceptions[0];
    assert_eq!(lapsed.risk_id, r.risk_id);
    assert_eq!(lapsed.expired_on, d(2026, 5, 20));

    // An exception still inside its window stays out of the list.
    let may20 = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 5, 15),
    )
    .expect("assemble mid-may");
    assert!(may20.risks.lapsed_exceptions.is_empty());
}

#[test]
fn orphan_risk_dir_warns_in_verify_and_stays_out_of_reports() {
    use secunit_core::evidence::verifier;

    let (_tmp, root) = staged_fixture();
    let finding_ref = FindingRef {
        control_id: CONTROL.to_string(),
        run_id: "2026-05-04-run-001".to_string(),
        manifest_sha256: "0".repeat(64),
        finding_id: "F-001".to_string(),
        body_path: None,
    };
    let r = risks::open(
        &root,
        finding_ref,
        "vulnerable dependency",
        Severity::High,
        4,
        3,
        vec!["api".into()],
        30,
        d(2026, 6, 4),
        "tester",
        None,
        Some(d(2026, 5, 5).and_hms_opt(9, 0, 0).unwrap().and_utc()),
    )
    .expect("open");

    // A backup copy with a valid log but a non-member name.
    let src = root.join("risks").join(&r.risk_id);
    let orphan = root.join("risks").join(format!("{}-copy", r.risk_id));
    fs::create_dir_all(&orphan).unwrap();
    fs::copy(src.join("events.jsonl"), orphan.join("events.jsonl")).unwrap();

    // Reports count only the member risk — one open risk, no errors.
    let (reg, _) = loader::load(&root);
    let data = reports::assemble(
        &reg,
        "2026-05",
        Cadence::Monthly,
        d(2026, 5, 1),
        d(2026, 5, 31),
        d(2026, 6, 1),
    )
    .expect("assemble");
    assert_eq!(data.risks.open.len(), 1);
    assert!(data.risks.register_errors.is_empty());

    // Verify shares the membership rule and warns about the orphan
    // instead of vouching for it.
    let report = verifier::verify(&root, None).expect("verify");
    assert!(
        report.verified_risks.iter().all(|v| v.risk_id == r.risk_id),
        "only the member risk is verified"
    );
    assert_eq!(report.risk_warnings.len(), 1);
    assert!(report.risk_warnings[0].dir.ends_with("-copy"));
    // The synthetic finding_ref can't resolve (no matching sealed run in
    // the fixture), so the member risk fails on that — but the orphan
    // contributes a warning only, never a failure.
    assert!(report.risk_failures.iter().all(|f| f.risk_id == r.risk_id));
}