second-brain-api 0.13.5

HTTP API server for second-brain: REST endpoints for recall, remember, and ingest
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
use std::sync::Arc;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::time::{Duration, Instant};

use axum::Json;
use axum::extract::State;
use axum::http::StatusCode;
use axum::response::IntoResponse;
use chrono::Utc;
use second_brain_core::query::{QueryEngine, QueryFilters, QueryRequest};
use second_brain_core::retrieval::{Candidates, ProjectScope, RerankScorer, Retriever, blend};
use second_brain_core::schema::Memory;
use second_brain_core::sqlite_store::{ReadDeadline, SqliteStore};
use serde::{Deserialize, Serialize};
use uuid::Uuid;

use super::project_names::refuse_unknown_project;
use super::raw_answer::{self, HotOutcome, RawPassageResponse, RawQuery};
use super::rerank_budget::{Budgeted, TimedRerank, doc_chars_for, embed_query, tunables_for};
use super::{MemoryResponse, bad_request, internal_error, parse_memory_type, to_response};
use crate::AppState;
use crate::value_metrics::{RecallEvent, RecallVerdict};

const DEFAULT_RECALL_LIMIT: usize = 10;

/// The MCP schema states the same bound; the two must agree.
const MAX_RECALL_LIMIT: usize = 100;

#[derive(Deserialize)]
pub(super) struct RecallRequest {
    query: String,
    limit: Option<usize>,
    source: Option<String>,
    memory_type: Option<String>,
    project: Option<String>,
    current_project: Option<String>,
    #[serde(default)]
    all_projects: bool,
    /// False leaves access_count and last_accessed alone; ranking reads both.
    record_access: Option<bool>,
    /// A Claude Code session id whose own memories are left out: the agent
    /// asking already holds them in its context.
    exclude_session: Option<String>,
    /// The caller's agent session, counted in the value metrics; falls back
    /// to `exclude_session`.
    session: Option<String>,
    /// Milliseconds the caller will wait. Within it the query embeds and
    /// reranks only on loaded, free sessions, never reloading a model, and
    /// no rerank starts past it; an answer without the rerank has no bar.
    budget_ms: Option<u64>,
    /// At most this many fused candidates, below the daemon's own fuse_top,
    /// go on to the rerank (or the cosine gate without one), trading depth
    /// for time; it also caps the ranked results.
    rerank_top: Option<usize>,
    /// At most this many characters of each document are reranked, below
    /// the reranker's own cap, trading score fidelity for time.
    rerank_doc_chars: Option<usize>,
    /// False ranks `current_project` in one wide pass, its results moved
    /// first, instead of searching the project alone before the wide scope:
    /// one rerank instead of up to two.
    project_pass: Option<bool>,
}

#[derive(Serialize)]
struct RecallResponse {
    memories: Vec<MemoryResponse>,
    /// Set when the answer did not come from the ranked semantic path:
    /// `text-fallback` means substring matches, newest first, unranked.
    #[serde(skip_serializing_if = "Option::is_none")]
    degraded: Option<&'static str>,
    /// Set when `current_project` drove the search: `project` when the answer
    /// came from it, `other-projects` when nothing there cleared the bar.
    #[serde(skip_serializing_if = "Option::is_none")]
    scope: Option<&'static str>,
    /// The relevance bar the answer abstained at, set only when the reranked
    /// answer was gated by it; results below it may still follow one that
    /// reaches it.
    #[serde(skip_serializing_if = "Option::is_none")]
    abstain_bar: Option<f32>,
    /// Raw transcript passages, present only when nothing distilled cleared
    /// the abstention bar and a raw passage did.
    #[serde(skip_serializing_if = "Vec::is_empty")]
    raw: Vec<RawPassageResponse>,
}

struct RecallOutcome {
    memories: Vec<(Memory, Option<f32>, Option<f32>)>,
    degraded: Option<&'static str>,
    scope: Option<&'static str>,
    abstain_bar: Option<f32>,
    raw: Vec<RawPassageResponse>,
}

/// Extra rows the unranked fallbacks fetch when a session is excluded, so
/// they can still fill `limit` after its memories are dropped. The ranked
/// path drops them from the candidates instead and ranks at `limit`.
const SAME_SESSION_HEADROOM: usize = 20;

/// The candidates less any that came from `session`.
fn without_session(
    mut pool: Candidates,
    sqlite: &SqliteStore,
    session: Option<&str>,
) -> anyhow::Result<Candidates> {
    let Some(session) = session else {
        return Ok(pool);
    };
    let ids: Vec<Uuid> = pool
        .dense
        .iter()
        .chain(&pool.lexical)
        .map(|(id, _)| *id)
        .collect();
    let excluded = sqlite.memories_from_session(&ids, session)?;
    pool.dense.retain(|(id, _)| !excluded.contains(id));
    pool.lexical.retain(|(id, _)| !excluded.contains(id));
    pool.best_chunk.retain(|id, _| !excluded.contains(id));
    Ok(pool)
}

fn drop_session<T>(
    items: &mut Vec<T>,
    id: impl Fn(&T) -> Uuid,
    sqlite: &SqliteStore,
    session: Option<&str>,
) -> anyhow::Result<()> {
    let Some(session) = session else {
        return Ok(());
    };
    let ids: Vec<Uuid> = items.iter().map(&id).collect();
    let excluded = sqlite.memories_from_session(&ids, session)?;
    items.retain(|item| !excluded.contains(&id(item)));
    Ok(())
}

fn applied_bar(abstained: bool, reranked: bool) -> Option<f32> {
    (abstained && reranked).then_some(blend::ABSTAIN_RERANK_BAR)
}

/// Results no bar judged, an empty answer included, are unjudged unless
/// nothing could judge them, and a degraded answer (a text search after the
/// query could not be embedded) is unjudged even when empty. A caller with a deadline shows only what
/// clears the bar; any other caller was shown every result.
fn recall_event(
    session: Option<String>,
    shown: &[(Uuid, Option<f32>)],
    raw: &[Option<Uuid>],
    abstain_bar: Option<f32>,
    has_reranker: bool,
    shows_only_cleared: bool,
    degraded: bool,
) -> RecallEvent {
    if degraded {
        let memory_ids = if shows_only_cleared {
            Vec::new()
        } else {
            shown.iter().map(|(id, _)| *id).collect()
        };
        return RecallEvent {
            session,
            verdict: RecallVerdict::Unjudged,
            memory_ids,
        };
    }
    let (verdict, memory_ids) = if shown.is_empty() {
        if !raw.is_empty() {
            (RecallVerdict::Hit, raw.iter().flatten().copied().collect())
        } else if abstain_bar.is_none() && has_reranker {
            (RecallVerdict::Unjudged, Vec::new())
        } else {
            (RecallVerdict::Empty, Vec::new())
        }
    } else if let Some(bar) = abstain_bar {
        let cleared: Vec<Uuid> = shown
            .iter()
            .filter(|(_, relevance)| relevance.is_some_and(|r| r >= bar))
            .map(|(id, _)| *id)
            .collect();
        let verdict = if cleared.is_empty() {
            RecallVerdict::LowScore
        } else {
            RecallVerdict::Hit
        };
        if shows_only_cleared {
            (verdict, cleared)
        } else {
            (verdict, shown.iter().map(|(id, _)| *id).collect())
        }
    } else {
        let all = shown.iter().map(|(id, _)| *id).collect();
        if shows_only_cleared {
            (RecallVerdict::Unjudged, Vec::new())
        } else if has_reranker {
            (RecallVerdict::Unjudged, all)
        } else {
            (RecallVerdict::Hit, all)
        }
    };
    RecallEvent {
        session,
        verdict,
        memory_ids,
    }
}

fn scope_name(scope: ProjectScope) -> &'static str {
    match scope {
        ProjectScope::Project => "project",
        ProjectScope::OtherProjects => "other-projects",
    }
}

static RECALLS_IN_FLIGHT: AtomicUsize = AtomicUsize::new(0);

/// Counts recalls whose blocking work has not finished, including ones
/// whose caller hung up, which a dropped handler does not stop.
struct InFlight(&'static AtomicUsize);

impl InFlight {
    fn enter(counter: &'static AtomicUsize) -> Self {
        counter.fetch_add(1, Ordering::SeqCst);
        InFlight(counter)
    }
}

impl Drop for InFlight {
    fn drop(&mut self) {
        self.0.fetch_sub(1, Ordering::SeqCst);
    }
}

pub(super) fn recalls_in_flight() -> usize {
    RECALLS_IN_FLIGHT.load(Ordering::SeqCst)
}

pub(super) async fn recall(
    State(state): State<Arc<AppState>>,
    Json(req): Json<RecallRequest>,
) -> impl IntoResponse {
    let deadline = req
        .budget_ms
        .map(|ms| Instant::now() + Duration::from_millis(ms));
    let limit = req.limit.unwrap_or(DEFAULT_RECALL_LIMIT);
    if !(1..=MAX_RECALL_LIMIT).contains(&limit) {
        return bad_request(format!(
            "limit must be between 1 and {MAX_RECALL_LIMIT}, got {limit}"
        ));
    }
    let session_named = |session: Option<&str>| {
        session
            .map(str::trim)
            .filter(|s| !s.is_empty())
            .map(str::to_string)
    };
    let exclude_session = session_named(req.exclude_session.as_deref());
    let shows_only_cleared = req.budget_ms.is_some();
    let caller_session = session_named(req.session.as_deref()).or_else(|| exclude_session.clone());
    let fetch_limit = match exclude_session {
        Some(_) => (limit + SAME_SESSION_HEADROOM).min(MAX_RECALL_LIMIT),
        None => limit,
    };
    let query_text = req.query.clone();
    let source_filter = req.source.clone();
    let type_filter = match req.memory_type.as_deref().map(parse_memory_type) {
        None => None,
        Some(Ok(t)) => Some(t),
        Some(Err(message)) => return bad_request(message),
    };
    if req.project.is_some() && req.all_projects {
        return bad_request("pass project or all_projects, not both");
    }
    let project_filter = req.project.clone();
    let current_project = req
        .current_project
        .clone()
        .filter(|_| req.project.is_none() && !req.all_projects);

    let store = state.store.clone();
    let sqlite = state.sqlite.clone();
    let indexes = state.indexes.clone();
    let raw_index = state.raw_index.clone();
    let archive = state.archive.clone();
    let reranker = state.reranker.clone();
    let tunables = match tunables_for(state.tunables, req.rerank_top) {
        Ok(tunables) => tunables,
        Err(message) => return bad_request(message),
    };
    let doc_chars = match doc_chars_for(req.rerank_doc_chars) {
        Ok(doc_chars) => doc_chars,
        Err(message) => return bad_request(message),
    };
    let project_pass = req.project_pass.unwrap_or(true);
    let embedder = state.embedder.clone();
    let gate = state.gate.clone();
    let accessed = store.clone();
    let record_access = req.record_access.unwrap_or(true);
    let record_accesses = move |ids: &[Uuid]| {
        if !record_access {
            return Ok(());
        }
        match gate.try_enter() {
            Some(_slot) => accessed.record_accesses(ids),
            None => Ok(()),
        }
    };

    let in_flight = InFlight::enter(&RECALLS_IN_FLIGHT);
    let result =
        tokio::task::spawn_blocking(move || -> anyhow::Result<Result<RecallOutcome, String>> {
            let _in_flight = in_flight;
            let _reads = deadline.map(ReadDeadline::set);
            if let Some(ref project) = project_filter
                && let Some(refusal) = refuse_unknown_project(&sqlite, project)?
            {
                return Ok(Err(refusal));
            }
            let embedding = match embedder {
                Some(ref emb) => match embed_query(emb, &query_text, deadline) {
                    Ok(embedding) => Some(embedding),
                    Err(e) => {
                        tracing::warn!(
                            "embedding the recall query failed, using the text fallback: {e}"
                        );
                        None
                    }
                },
                None => None,
            };
            // A budgeted recall can miss or skip the rerank before reaching
            // it, so the reload starts here for the next one to find warm:
            // after the embed, whose own reload must not queue behind it.
            if deadline.is_some()
                && let Some(ref reranker) = reranker
            {
                reranker.warm_in_background();
            }
            if let Some(embedding) = embedding {
                let request = QueryRequest {
                    text: query_text.clone(),
                    embedding,
                    limit,
                    filters: QueryFilters {
                        source: source_filter.clone(),
                        memory_type: type_filter,
                        min_confidence: None,
                        entity_names: crate::link_query_entities(&query_text),
                        project_path: project_filter.clone(),
                    },
                };
                let budgeted = reranker.as_deref().map(|r| {
                    Budgeted::new(r as &dyn TimedRerank, deadline).with_doc_chars(doc_chars)
                });
                let scorer = budgeted.as_ref().map(|b| b as &dyn RerankScorer);
                let (mut results, scope) = match indexes {
                    Some(ref idx) => {
                        let retriever = Retriever { tunables };
                        let generate = |request: &QueryRequest| {
                            let guard = match idx.read() {
                                Ok(g) => g,
                                Err(poisoned) => poisoned.into_inner(),
                            };
                            let pool = retriever.candidates(&guard, &sqlite, request)?;
                            without_session(pool, &sqlite, exclude_session.as_deref())
                        };
                        match current_project {
                            Some(ref project) => {
                                let answer = if project_pass {
                                    retriever.rank_project_first(
                                        store.as_ref(),
                                        &request,
                                        project,
                                        generate,
                                        scorer,
                                    )?
                                } else {
                                    retriever.rank_project_preferred(
                                        store.as_ref(),
                                        &request,
                                        project,
                                        generate,
                                        scorer,
                                    )?
                                };
                                (answer.results, Some(scope_name(answer.scope)))
                            }
                            None => {
                                let pool = generate(&request)?;
                                (
                                    retriever.rank(store.as_ref(), &request, &pool, scorer)?,
                                    None,
                                )
                            }
                        }
                    }
                    None => (Vec::new(), None),
                };
                // An abstaining ranked answer is final: the fallbacks below are
                // unranked and would hand back exactly the weak matches it dropped.
                let abstained = tunables.abstain && indexes.is_some();
                let hot_reranked = budgeted.as_ref().is_some_and(Budgeted::reranked);
                let raw = raw_answer::fallback(
                    raw_index.as_deref(),
                    scorer,
                    HotOutcome {
                        results: results.len(),
                        abstention_on: abstained,
                        narrowed: type_filter.is_some() || source_filter.is_some(),
                        budgeted: deadline.is_some(),
                        excludes_session: exclude_session.is_some(),
                    },
                    &sqlite,
                    RawQuery {
                        text: &query_text,
                        embedding: &request.embedding,
                        project: project_filter.as_deref(),
                        limit,
                        archive: archive.as_deref(),
                    },
                );
                if results.is_empty() && !abstained {
                    let engine = QueryEngine::new(store.as_ref());
                    results = engine.recall(&QueryRequest {
                        limit: fetch_limit,
                        ..request.clone()
                    })?;
                }
                if !results.is_empty() || abstained {
                    drop_session(
                        &mut results,
                        |r| r.memory.id,
                        &sqlite,
                        exclude_session.as_deref(),
                    )?;
                    results.truncate(limit);
                    let ids: Vec<Uuid> = results.iter().map(|r| r.memory.id).collect();
                    record_accesses(&ids)?;
                    return Ok(Ok(RecallOutcome {
                        memories: results
                            .into_iter()
                            .map(|r| (r.memory, Some(r.score), Some(r.relevance)))
                            .collect(),
                        degraded: None,
                        scope,
                        abstain_bar: applied_bar(abstained, hot_reranked),
                        raw,
                    }));
                }
            }

            // The filters apply before the limit, so a recall narrowed to a
            // small slice of the store still finds that slice's matches.
            let mut text_results = sqlite.scoped_text_search(
                &query_text,
                source_filter.as_deref(),
                type_filter,
                project_filter.as_deref(),
                fetch_limit,
            )?;
            drop_session(
                &mut text_results,
                |m| m.id,
                &sqlite,
                exclude_session.as_deref(),
            )?;
            text_results.truncate(limit);
            let ids: Vec<Uuid> = text_results.iter().map(|m| m.id).collect();
            record_accesses(&ids)?;
            Ok(Ok(RecallOutcome {
                memories: text_results.into_iter().map(|m| (m, None, None)).collect(),
                degraded: Some("text-fallback"),
                scope: None,
                abstain_bar: None,
                raw: Vec::new(),
            }))
        })
        .await;

    let outcome = match result {
        Ok(Ok(Ok(outcome))) => outcome,
        Ok(Ok(Err(message))) => return bad_request(message),
        Ok(Err(e)) => return internal_error(e),
        Err(e) => return internal_error(e),
    };

    let machine_names = match state.store.get_all_machines() {
        Ok(names) => names,
        Err(e) => return internal_error(e),
    };

    let ids: Vec<_> = outcome.memories.iter().map(|(m, _, _)| m.id).collect();
    let corrected = match state.sqlite.corrected_at(&ids) {
        Ok(marks) => marks,
        Err(e) => return internal_error(e),
    };

    let shown: Vec<(Uuid, Option<f32>)> = outcome
        .memories
        .iter()
        .map(|(m, _, relevance)| (m.id, *relevance))
        .collect();
    let raw_shown: Vec<Option<Uuid>> = outcome.raw.iter().map(|p| p.memory_id()).collect();
    state.health.recalled(
        recall_event(
            caller_session,
            &shown,
            &raw_shown,
            outcome.abstain_bar,
            state.reranker.is_some(),
            shows_only_cleared,
            outcome.degraded.is_some(),
        ),
        Utc::now(),
    );

    Json(RecallResponse {
        memories: outcome
            .memories
            .into_iter()
            .map(|(m, score, relevance)| {
                let at = corrected.get(&m.id).map(|t| t.to_rfc3339());
                MemoryResponse {
                    corrected_at: at,
                    ..to_response(m, score, relevance, &machine_names)
                }
            })
            .collect(),
        degraded: outcome.degraded,
        scope: outcome.scope,
        abstain_bar: outcome.abstain_bar,
        raw: outcome.raw,
    })
    .into_response()
}

#[derive(Deserialize)]
pub(super) struct ContextRequest {
    project: String,
    depth: Option<u32>,
}

#[derive(Serialize)]
struct ContextResponse {
    memories: Vec<ContextMemory>,
}

#[derive(Serialize)]
struct ContextMemory {
    id: String,
    content: String,
    memory_type: String,
    confidence: f32,
    session_at: Option<String>,
    connected: Vec<String>,
}

pub(super) async fn context(
    State(state): State<Arc<AppState>>,
    Json(req): Json<ContextRequest>,
) -> impl IntoResponse {
    let project = req.project.clone();
    let depth = req.depth.unwrap_or(2);
    let store = state.store.clone();

    let result = tokio::task::spawn_blocking(move || -> anyhow::Result<Vec<ContextMemory>> {
        let relevant = store.memories_by_project_path(&project)?;

        let mut out = Vec::new();
        for memory in &relevant {
            let connected: Vec<String> = store
                .traverse(memory.id, depth)?
                .into_iter()
                .map(|(m, _)| truncate(&m.content, 100))
                .collect();

            out.push(ContextMemory {
                id: memory.id.to_string(),
                content: memory.content.clone(),
                memory_type: format!("{:?}", memory.memory_type).to_lowercase(),
                confidence: memory.confidence,
                session_at: memory.session_at.map(|t| t.to_rfc3339()),
                connected,
            });
        }
        Ok(out)
    })
    .await;

    match result {
        Ok(Ok(memories)) => Json(ContextResponse { memories }).into_response(),
        Ok(Err(e)) => (
            StatusCode::INTERNAL_SERVER_ERROR,
            Json(serde_json::json!({"error": e.to_string()})),
        )
            .into_response(),
        Err(e) => (
            StatusCode::INTERNAL_SERVER_ERROR,
            Json(serde_json::json!({"error": e.to_string()})),
        )
            .into_response(),
    }
}

fn truncate(s: &str, max_len: usize) -> String {
    if s.len() <= max_len {
        s.to_string()
    } else {
        let mut end = max_len.min(s.len());
        while end > 0 && !s.is_char_boundary(end) {
            end -= 1;
        }
        format!("{}...", &s[..end])
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn the_bar_is_reported_only_for_an_abstaining_reranked_answer() {
        assert_eq!(applied_bar(true, true), Some(blend::ABSTAIN_RERANK_BAR));
        assert_eq!(applied_bar(true, false), None);
        assert_eq!(applied_bar(false, true), None);
        assert_eq!(applied_bar(false, false), None);
    }

    #[test]
    fn a_recall_is_classified_by_its_results_bar_and_reranker() {
        let (a, b) = (Uuid::new_v4(), Uuid::new_v4());
        let bar = 0.5;
        let cases = vec![
            (vec![], None, false, RecallVerdict::Empty, vec![]),
            (vec![], Some(bar), true, RecallVerdict::Empty, vec![]),
            (vec![], None, true, RecallVerdict::Unjudged, vec![]),
            (
                vec![(a, Some(0.7)), (b, Some(0.2))],
                Some(bar),
                true,
                RecallVerdict::Hit,
                vec![a, b],
            ),
            (
                vec![(a, Some(0.2)), (b, Some(0.5))],
                Some(bar),
                true,
                RecallVerdict::Hit,
                vec![a, b],
            ),
            (
                vec![(a, Some(0.2)), (b, None)],
                Some(bar),
                true,
                RecallVerdict::LowScore,
                vec![a, b],
            ),
            (
                vec![(a, None), (b, Some(0.1))],
                None,
                false,
                RecallVerdict::Hit,
                vec![a, b],
            ),
            (
                vec![(a, Some(0.9)), (b, None)],
                None,
                true,
                RecallVerdict::Unjudged,
                vec![a, b],
            ),
        ];
        for (shown, abstain_bar, has_reranker, verdict, ids) in cases {
            let event = recall_event(
                Some("s1".to_string()),
                &shown,
                &[],
                abstain_bar,
                has_reranker,
                false,
                false,
            );
            assert_eq!(
                event,
                RecallEvent {
                    session: Some("s1".to_string()),
                    verdict,
                    memory_ids: ids,
                },
                "{shown:?} bar {abstain_bar:?} reranker {has_reranker}"
            );
        }
    }

    #[test]
    fn a_deadline_answer_without_a_bar_is_unjudged_and_shows_nothing() {
        let (a, b) = (Uuid::new_v4(), Uuid::new_v4());
        let shown = [(a, Some(0.9)), (b, None)];
        for has_reranker in [true, false] {
            let event = recall_event(None, &shown, &[], None, has_reranker, true, false);
            assert_eq!(event.verdict, RecallVerdict::Unjudged, "{has_reranker}");
            assert_eq!(event.memory_ids, Vec::<Uuid>::new(), "{has_reranker}");
        }
        let event = recall_event(None, &shown, &[], Some(0.5), true, true, false);
        assert_eq!(event.verdict, RecallVerdict::Hit);
        assert_eq!(event.memory_ids, vec![a]);
    }

    #[test]
    fn a_degraded_answer_is_unjudged_even_when_empty() {
        let a = Uuid::new_v4();
        let cases = [
            (vec![], true, vec![]),
            (vec![], false, vec![]),
            (vec![(a, None)], true, vec![]),
            (vec![(a, None)], false, vec![a]),
        ];
        for (shown, deadline, ids) in cases {
            for has_reranker in [true, false] {
                let event = recall_event(None, &shown, &[], None, has_reranker, deadline, true);
                assert_eq!(
                    (event.verdict, event.memory_ids),
                    (RecallVerdict::Unjudged, ids.clone()),
                    "{shown:?} deadline {deadline} reranker {has_reranker}"
                );
            }
        }
    }

    #[test]
    fn raw_passages_make_an_abstained_recall_a_hit_on_their_memories() {
        let (a, b) = (Uuid::new_v4(), Uuid::new_v4());
        let event = recall_event(
            None,
            &[],
            &[Some(a), None, Some(b)],
            Some(0.5),
            true,
            false,
            false,
        );
        assert_eq!(
            event,
            RecallEvent {
                session: None,
                verdict: RecallVerdict::Hit,
                memory_ids: vec![a, b],
            }
        );
        let event = recall_event(
            None,
            &[(a, Some(0.9))],
            &[Some(b)],
            Some(0.5),
            true,
            false,
            false,
        );
        assert_eq!(
            event.memory_ids,
            vec![a],
            "raw only answers an empty recall"
        );
    }

    #[test]
    fn a_pool_without_a_session_keeps_only_other_sessions_candidates() {
        use second_brain_core::schema::MemoryType;
        use second_brain_core::store::Store;

        let sqlite = SqliteStore::in_memory("m".to_string()).unwrap();
        let stored = |source_id: &str| {
            let memory = Memory::new(
                source_id.to_string(),
                MemoryType::Episodic,
                "claude-code".to_string(),
                source_id.to_string(),
            );
            sqlite.store_memory(&memory).unwrap();
            memory.id
        };
        let own = stored("/h/.claude/projects/-a/s1.jsonl");
        let other = stored("/h/.claude/projects/-a/s2.jsonl");
        let mut pool = Candidates::new(vec![(own, 0.9), (other, 0.8)], vec![(own, 3.0)]);
        pool.best_chunk.insert(own, (0, 0.9));

        let kept = without_session(pool.clone(), &sqlite, Some("s1")).unwrap();
        assert_eq!(kept.dense, vec![(other, 0.8)]);
        assert!(kept.lexical.is_empty());
        assert!(kept.best_chunk.is_empty());

        let untouched = without_session(pool, &sqlite, None).unwrap();
        assert_eq!(untouched.dense.len(), 2);
    }

    #[test]
    fn a_recall_counts_as_in_flight_until_its_work_is_dropped() {
        static COUNTER: AtomicUsize = AtomicUsize::new(0);
        let first = InFlight::enter(&COUNTER);
        let second = InFlight::enter(&COUNTER);
        assert_eq!(COUNTER.load(Ordering::SeqCst), 2);
        drop(first);
        assert_eq!(COUNTER.load(Ordering::SeqCst), 1);
        drop(second);
        assert_eq!(COUNTER.load(Ordering::SeqCst), 0);
    }
}