sdforge 0.3.1

Multi-protocol SDK framework with unified macro configuration
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55

// Copyright (c) 2026 Kirky.X
// SPDX-License-Identifier: MIT
//! WebSocket broadcast logic.
//!
//! Implements the [`ConnectionManager::broadcast`] method that sends a single
//! message to every active connection. Failed sends are tracked and the
//! affected connections are pruned from the manager to avoid leaking stale
//! entries.

#[cfg(feature = "websocket")]
use std::sync::Arc;

#[cfg(feature = "websocket")]
use crate::websocket::connection::ConnectionManager;
#[cfg(feature = "websocket")]
use crate::websocket::message::WebSocketMessage;
#[cfg(feature = "websocket")]
use crate::websocket::WebSocketConnection;

#[cfg(feature = "websocket")]
impl ConnectionManager {
    /// Broadcast a message to all connections (optimized with Arc)
    ///
    /// Security fix: Handle broadcast errors properly and clean up failed connections.
    /// Connections whose receiver has been dropped are removed from the manager
    /// so subsequent broadcasts do not repeatedly attempt to deliver to dead channels.
    pub async fn broadcast(&self, message: &Arc<WebSocketMessage>) {
        let mut failed_connections: Vec<String> = Vec::new();

        // Collect connection clones first so we don't hold the lock across
        // `.await` points (which would risk deadlock and is not `Send`-safe).
        let conns: Vec<WebSocketConnection> = {
            match self.connections.read() {
                Ok(map) => map.values().cloned().collect(),
                Err(_) => {
                    log::warn!("websocket connections lock poisoned; broadcast aborted");
                    return;
                }
            }
        };

        for conn in conns {
            if conn.send(message.as_ref().clone()).await.is_err() {
                // Track failed connections for cleanup
                // Don't log every failure to avoid log spam
                failed_connections.push(conn.id().to_string());
            }
        }

        // Clean up failed connections
        for conn_id in failed_connections {
            self.remove_connection(&conn_id).await;
        }
    }
}