scud-cli 1.67.0

Fast, simple task master for AI-driven development
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
use anyhow::Result;
use colored::Colorize;
use indicatif::{ProgressBar, ProgressStyle};
use serde::{Deserialize, Serialize};
use std::collections::HashSet;
use std::path::{Path, PathBuf};

use crate::llm::{LLMClient, Prompts};
use crate::models::{Phase, TaskStatus};
use crate::storage::Storage;

/// Results from dependency validation
#[derive(Debug, Default)]
pub struct DepCheckResults {
    pub missing_deps: Vec<(String, String, String)>, // (tag, task_id, missing_dep)
    pub invalid_zero_deps: Vec<(String, String)>,    // (tag, task_id)
    pub self_refs: Vec<(String, String)>,            // (tag, task_id)
    pub cancelled_deps: Vec<(String, String, String)>, // (tag, task_id, cancelled_dep)
}

impl DepCheckResults {
    pub fn has_issues(&self) -> bool {
        !self.missing_deps.is_empty()
            || !self.invalid_zero_deps.is_empty()
            || !self.self_refs.is_empty()
            || !self.cancelled_deps.is_empty()
    }

    pub fn issue_count(&self) -> usize {
        self.missing_deps.len()
            + self.invalid_zero_deps.len()
            + self.self_refs.len()
            + self.cancelled_deps.len()
    }
}

/// PRD validation result structures
#[derive(Debug, Deserialize, Serialize)]
pub struct PrdValidationResult {
    pub coverage_score: u32,
    #[serde(default)]
    pub missing_requirements: Vec<MissingRequirement>,
    #[serde(default)]
    pub incomplete_coverage: Vec<IncompleteCoverage>,
    #[serde(default)]
    pub misaligned_tasks: Vec<MisalignedTask>,
    #[serde(default)]
    pub extra_tasks: Vec<ExtraTask>,
    #[serde(default)]
    pub dependency_suggestions: Vec<DependencySuggestion>,
    #[serde(default)]
    pub agent_type_issues: Vec<AgentTypeIssue>,
    pub summary: String,
}

#[derive(Debug, Deserialize, Serialize)]
pub struct AgentTypeIssue {
    pub task_id: String,
    pub current_agent_type: Option<String>,
    pub suggested_agent_type: String,
    pub reasoning: String,
}

#[derive(Debug, Deserialize, Serialize)]
pub struct MissingRequirement {
    pub requirement: String,
    pub prd_section: String,
    pub suggested_task: String,
}

#[derive(Debug, Deserialize, Serialize)]
pub struct IncompleteCoverage {
    pub requirement: String,
    pub existing_tasks: Vec<String>,
    pub gap: String,
}

#[derive(Debug, Deserialize, Serialize)]
pub struct MisalignedTask {
    pub task_id: String,
    pub issue: String,
    pub suggestion: String,
}

#[derive(Debug, Deserialize, Serialize)]
pub struct ExtraTask {
    pub task_id: String,
    pub note: String,
}

#[derive(Debug, Deserialize, Serialize)]
pub struct DependencySuggestion {
    pub task_id: String,
    pub should_depend_on: Vec<String>,
    pub reasoning: String,
}

/// Struct for PRD fix response
#[derive(Debug, Deserialize)]
pub struct PrdFix {
    pub action: String, // "update_task", "add_task", "update_dependency", "update_agent_type"
    pub task_id: Option<String>,
    pub new_title: Option<String>,
    pub new_description: Option<String>,
    pub add_dependencies: Option<Vec<String>>,
    pub remove_dependencies: Option<Vec<String>>,
    pub new_agent_type: Option<String>,
    pub reasoning: String,
}

pub async fn run(
    project_root: Option<PathBuf>,
    tag: Option<&str>,
    all_tags: bool,
    prd_file: Option<&Path>,
    fix: bool,
    model: Option<&str>,
) -> Result<()> {
    let storage = Storage::new(project_root.clone());

    if !storage.is_initialized() {
        anyhow::bail!("SCUD not initialized. Run: scud init");
    }

    // Validate --fix requires --prd
    if fix && prd_file.is_none() {
        anyhow::bail!("--fix requires --prd to be specified");
    }

    let mut all_phases = storage.load_tasks()?;

    if all_phases.is_empty() {
        println!("{}", "No tasks found.".yellow());
        return Ok(());
    }

    // Determine which phases to check
    let phases_to_check: Vec<String> = match tag {
        Some(t) if !all_tags => {
            if !all_phases.contains_key(t) {
                anyhow::bail!("Tag '{}' not found", t);
            }
            vec![t.to_string()]
        }
        _ => all_phases.keys().cloned().collect(),
    };

    println!(
        "{} Checking dependencies across {} phase(s)...\n",
        "Validating".blue(),
        phases_to_check.len()
    );

    let mut results = DepCheckResults::default();

    // Build global task ID set for cross-phase validation
    let all_task_ids: HashSet<String> = all_phases
        .iter()
        .flat_map(|(tag, phase)| {
            phase.tasks.iter().flat_map(move |t| {
                let mut ids = vec![t.id.clone(), format!("{}:{}", tag, t.id)];
                // Also add subtask IDs if present
                for subtask_id in &t.subtasks {
                    ids.push(subtask_id.clone());
                    ids.push(format!("{}:{}", tag, subtask_id));
                }
                ids
            })
        })
        .collect();

    // Validate each phase
    for tag in &phases_to_check {
        if let Some(phase) = all_phases.get(tag) {
            validate_phase(tag, phase, &all_task_ids, &mut results);
        }
    }

    // Print dependency results
    print_dep_results(&results);

    let mut has_prd_issues = false;

    // PRD validation if file provided
    if let Some(prd_path) = prd_file {
        println!();
        println!("{}", "".repeat(50).blue());
        println!("{}", "PRD Coverage Validation".blue().bold());
        println!("{}", "".repeat(50).blue());
        println!();

        // Read PRD file
        let prd_content = storage.read_file(prd_path)?;

        // Build tasks JSON for LLM
        let tasks_json = build_tasks_json(&all_phases, &phases_to_check);

        // Create LLM client
        let client = match project_root {
            Some(root) => LLMClient::new_with_project_root(root)?,
            None => LLMClient::new()?,
        };

        // Show model info
        let model_info = client.smart_model_info(model);
        println!("{} {}", "Using".blue(), model_info.to_string().cyan());
        println!();

        // Show progress
        let spinner = ProgressBar::new_spinner();
        spinner.set_style(
            ProgressStyle::default_spinner()
                .template("{spinner:.blue} {msg}")
                .unwrap(),
        );
        spinner.set_message("Validating tasks against PRD with AI...");
        spinner.enable_steady_tick(std::time::Duration::from_millis(100));

        // Call LLM to validate (use smart model for validation tasks)
        let prompt = Prompts::validate_tasks_against_prd(&prd_content, &tasks_json);
        let validation: PrdValidationResult = client.complete_json_smart(&prompt, model).await?;

        spinner.finish_and_clear();

        // Print PRD validation results
        has_prd_issues = print_prd_results(&validation);

        // Apply fixes if requested
        if fix && has_prd_issues {
            println!();
            println!("{}", "".repeat(50).green());
            println!("{}", "Applying PRD Fixes".green().bold());
            println!("{}", "".repeat(50).green());
            println!();

            // Show progress for fix generation
            let fix_spinner = ProgressBar::new_spinner();
            fix_spinner.set_style(
                ProgressStyle::default_spinner()
                    .template("{spinner:.green} {msg}")
                    .unwrap(),
            );
            fix_spinner.set_message("Generating fixes based on PRD validation...");
            fix_spinner.enable_steady_tick(std::time::Duration::from_millis(100));

            // Call LLM to generate fixes
            let fix_prompt = Prompts::fix_prd_issues(&prd_content, &tasks_json, &validation);
            let fixes: Vec<PrdFix> = client.complete_json_smart(&fix_prompt, model).await?;

            fix_spinner.finish_and_clear();

            if fixes.is_empty() {
                println!("  {} No automatic fixes available", "".blue());
            } else {
                println!("  {} Generated {} fix(es):\n", "".green(), fixes.len());

                let mut changes_made = 0;

                for fix_item in &fixes {
                    println!("  {} {}", "".cyan(), fix_item.action.cyan().bold());
                    println!("    {}", fix_item.reasoning.dimmed());

                    match fix_item.action.as_str() {
                        "update_task" => {
                            if let Some(task_id) = &fix_item.task_id {
                                // Parse tag:id format
                                let (fix_tag, fix_task_id) =
                                    parse_task_id(task_id, &phases_to_check);

                                if let Some(phase) = all_phases.get_mut(&fix_tag) {
                                    if let Some(task) =
                                        phase.tasks.iter_mut().find(|t| t.id == fix_task_id)
                                    {
                                        if let Some(new_title) = &fix_item.new_title {
                                            println!("    {} {}", "Title:".green(), new_title);
                                            task.title = new_title.clone();
                                            changes_made += 1;
                                        }
                                        if let Some(new_desc) = &fix_item.new_description {
                                            println!(
                                                "    {} {} chars",
                                                "Description:".green(),
                                                new_desc.len()
                                            );
                                            task.description = new_desc.clone();
                                            changes_made += 1;
                                        }
                                    }
                                }
                            }
                        }
                        "update_dependency" => {
                            if let Some(task_id) = &fix_item.task_id {
                                let (fix_tag, fix_task_id) =
                                    parse_task_id(task_id, &phases_to_check);

                                if let Some(phase) = all_phases.get_mut(&fix_tag) {
                                    if let Some(task) =
                                        phase.tasks.iter_mut().find(|t| t.id == fix_task_id)
                                    {
                                        if let Some(add_deps) = &fix_item.add_dependencies {
                                            for dep in add_deps {
                                                if !task.dependencies.contains(dep) {
                                                    println!("    {} +{}", "Dep:".green(), dep);
                                                    task.dependencies.push(dep.clone());
                                                    changes_made += 1;
                                                }
                                            }
                                        }
                                        if let Some(remove_deps) = &fix_item.remove_dependencies {
                                            for dep in remove_deps {
                                                if task.dependencies.contains(dep) {
                                                    println!("    {} -{}", "Dep:".red(), dep);
                                                    task.dependencies.retain(|d| d != dep);
                                                    changes_made += 1;
                                                }
                                            }
                                        }
                                    }
                                }
                            }
                        }
                        "update_agent_type" => {
                            if let Some(task_id) = &fix_item.task_id {
                                let (fix_tag, fix_task_id) =
                                    parse_task_id(task_id, &phases_to_check);

                                if let Some(phase) = all_phases.get_mut(&fix_tag) {
                                    if let Some(task) =
                                        phase.tasks.iter_mut().find(|t| t.id == fix_task_id)
                                    {
                                        if let Some(new_agent_type) = &fix_item.new_agent_type {
                                            println!(
                                                "    {} {}{}",
                                                "Agent:".green(),
                                                task.agent_type.as_deref().unwrap_or("none"),
                                                new_agent_type
                                            );
                                            task.agent_type = Some(new_agent_type.clone());
                                            changes_made += 1;
                                        }
                                    }
                                }
                            }
                        }
                        _ => {
                            println!(
                                "    {} Unsupported action: {}",
                                "".yellow(),
                                fix_item.action
                            );
                        }
                    }
                    println!();
                }

                if changes_made > 0 {
                    storage.save_tasks(&all_phases)?;
                    println!(
                        "{}",
                        format!("✓ Applied {} change(s) successfully!", changes_made)
                            .green()
                            .bold()
                    );
                    has_prd_issues = false; // Don't exit with error since we fixed things
                } else {
                    println!(
                        "  {} No changes could be applied automatically",
                        "".yellow()
                    );
                    println!(
                        "  {} Some issues may require manual intervention",
                        "".yellow()
                    );
                }
            }
        }
    }

    if results.has_issues() || has_prd_issues {
        std::process::exit(1);
    }

    Ok(())
}

/// Parse task_id in format "tag:id" or just "id"
fn parse_task_id(task_id: &str, phases_to_check: &[String]) -> (String, String) {
    if task_id.contains(':') {
        let parts: Vec<&str> = task_id.split(':').collect();
        (parts[0].to_string(), parts[1..].join(":"))
    } else {
        let tag = phases_to_check.first().cloned().unwrap_or_default();
        (tag, task_id.to_string())
    }
}

fn build_tasks_json(
    all_phases: &std::collections::HashMap<String, Phase>,
    phases_to_check: &[String],
) -> String {
    let mut tasks_list = Vec::new();

    for tag in phases_to_check {
        if let Some(phase) = all_phases.get(tag) {
            for task in &phase.tasks {
                tasks_list.push(serde_json::json!({
                    "id": format!("{}:{}", tag, task.id),
                    "title": task.title,
                    "description": task.description,
                    "status": format!("{:?}", task.status),
                    "priority": format!("{:?}", task.priority),
                    "complexity": task.complexity,
                    "dependencies": task.dependencies,
                    "agent_type": task.agent_type,
                }));
            }
        }
    }

    serde_json::to_string_pretty(&tasks_list).unwrap_or_else(|_| "[]".to_string())
}

pub fn validate_phase(
    tag: &str,
    phase: &Phase,
    all_task_ids: &HashSet<String>,
    results: &mut DepCheckResults,
) {
    let local_ids: HashSet<_> = phase.tasks.iter().map(|t| t.id.clone()).collect();

    for task in &phase.tasks {
        // Skip completed/cancelled tasks
        if matches!(task.status, TaskStatus::Done | TaskStatus::Cancelled) {
            continue;
        }

        for dep in &task.dependencies {
            // Check for invalid "0" reference
            if dep == "0" || dep.ends_with(":0") {
                results
                    .invalid_zero_deps
                    .push((tag.to_string(), task.id.clone()));
                continue;
            }

            // Check for self-reference
            if dep == &task.id || dep == &format!("{}:{}", tag, task.id) {
                results.self_refs.push((tag.to_string(), task.id.clone()));
                continue;
            }

            // Check if dependency exists
            let exists = local_ids.contains(dep)
                || all_task_ids.contains(dep)
                || all_task_ids.contains(&format!("{}:{}", tag, dep));

            if !exists {
                results
                    .missing_deps
                    .push((tag.to_string(), task.id.clone(), dep.clone()));
                continue;
            }

            // Check if dependency is cancelled
            if let Some(dep_task) = phase.get_task(dep) {
                if dep_task.status == TaskStatus::Cancelled {
                    results
                        .cancelled_deps
                        .push((tag.to_string(), task.id.clone(), dep.clone()));
                }
            }
        }
    }
}

fn print_dep_results(results: &DepCheckResults) {
    if !results.has_issues() {
        println!("{}", "✓ No dependency issues found!".green().bold());
        return;
    }

    // Invalid zero references
    if !results.invalid_zero_deps.is_empty() {
        println!("{}", "Invalid Task Zero References".red().bold());
        println!("{}", "-".repeat(40).red());
        for (tag, task_id) in &results.invalid_zero_deps {
            println!(
                "  {} Task {} references invalid task \"0\"",
                "".red(),
                format!("{}:{}", tag, task_id).cyan()
            );
            println!(
                "    {}",
                "→ Task indices start at 1. Remove or update this dependency.".dimmed()
            );
        }
        println!();
    }

    // Missing dependencies
    if !results.missing_deps.is_empty() {
        println!("{}", "Missing Dependencies".red().bold());
        println!("{}", "-".repeat(40).red());
        for (tag, task_id, dep) in &results.missing_deps {
            println!(
                "  {} Task {} depends on non-existent task {}",
                "".red(),
                format!("{}:{}", tag, task_id).cyan(),
                dep.yellow()
            );
            println!(
                "    {}",
                format!("→ Remove dependency or create task {}", dep).dimmed()
            );
        }
        println!();
    }

    // Self-references
    if !results.self_refs.is_empty() {
        println!("{}", "Self-Referencing Dependencies".red().bold());
        println!("{}", "-".repeat(40).red());
        for (tag, task_id) in &results.self_refs {
            println!(
                "  {} Task {} depends on itself",
                "".red(),
                format!("{}:{}", tag, task_id).cyan()
            );
            println!("    {}", "→ Remove self-referencing dependency.".dimmed());
        }
        println!();
    }

    // Cancelled dependencies
    if !results.cancelled_deps.is_empty() {
        println!("{}", "Dependencies on Cancelled Tasks".yellow().bold());
        println!("{}", "-".repeat(40).yellow());
        for (tag, task_id, dep) in &results.cancelled_deps {
            println!(
                "  {} Task {} depends on cancelled task {}",
                "".yellow(),
                format!("{}:{}", tag, task_id).cyan(),
                dep.yellow()
            );
            println!(
                "    {}",
                format!("→ Remove dependency or un-cancel {}", dep).dimmed()
            );
        }
        println!();
    }

    // Summary
    println!("{}", "Dependency Summary".blue().bold());
    println!("{}", "-".repeat(40).blue());
    println!(
        "  Total issues: {}",
        results.issue_count().to_string().red()
    );
    println!();
    println!("{}", "To fix issues:".blue());
    println!("  - Edit .scud/<tag>.scg directly");
    println!("  - Or run: scud reanalyze-deps --apply");
}

fn print_prd_results(validation: &PrdValidationResult) -> bool {
    // Coverage score with color coding
    let score_color = if validation.coverage_score >= 90 {
        validation.coverage_score.to_string().green()
    } else if validation.coverage_score >= 70 {
        validation.coverage_score.to_string().yellow()
    } else {
        validation.coverage_score.to_string().red()
    };

    println!(
        "{} {}%",
        "Coverage Score:".blue().bold(),
        score_color.bold()
    );
    println!();

    let has_issues = !validation.missing_requirements.is_empty()
        || !validation.incomplete_coverage.is_empty()
        || !validation.misaligned_tasks.is_empty();

    if !validation.missing_requirements.is_empty() {
        println!("{}", "Missing Requirements".red().bold());
        println!("{}", "-".repeat(40).red());
        for req in &validation.missing_requirements {
            println!("  {} {}", "".red(), req.requirement.white());
            println!("    {} {}", "Section:".dimmed(), req.prd_section.dimmed());
            println!(
                "    {} {}",
                "Suggested task:".cyan(),
                req.suggested_task.cyan()
            );
        }
        println!();
    }

    if !validation.incomplete_coverage.is_empty() {
        println!("{}", "Incomplete Coverage".yellow().bold());
        println!("{}", "-".repeat(40).yellow());
        for cov in &validation.incomplete_coverage {
            println!("  {} {}", "".yellow(), cov.requirement.white());
            println!(
                "    {} {}",
                "Covered by:".dimmed(),
                cov.existing_tasks.join(", ").dimmed()
            );
            println!("    {} {}", "Gap:".cyan(), cov.gap.cyan());
        }
        println!();
    }

    if !validation.misaligned_tasks.is_empty() {
        println!("{}", "Misaligned Tasks".red().bold());
        println!("{}", "-".repeat(40).red());
        for task in &validation.misaligned_tasks {
            println!("  {} Task {}", "".red(), task.task_id.cyan());
            println!("    {} {}", "Issue:".dimmed(), task.issue.white());
            println!("    {} {}", "Fix:".green(), task.suggestion.green());
        }
        println!();
    }

    if !validation.extra_tasks.is_empty() {
        println!("{}", "Extra Tasks (beyond PRD scope)".blue().bold());
        println!("{}", "-".repeat(40).blue());
        for task in &validation.extra_tasks {
            println!("  {} Task {}", "".blue(), task.task_id.cyan());
            println!("    {}", task.note.dimmed());
        }
        println!();
    }

    if !validation.dependency_suggestions.is_empty() {
        println!(
            "{}",
            "Suggested Dependencies (from PRD context)".cyan().bold()
        );
        println!("{}", "-".repeat(40).cyan());
        for dep in &validation.dependency_suggestions {
            println!(
                "  {} Task {} should depend on {}",
                "".cyan(),
                dep.task_id.cyan(),
                dep.should_depend_on.join(", ").yellow()
            );
            println!("    {}", dep.reasoning.dimmed());
        }
        println!();
    }

    // Summary
    println!("{}", "PRD Validation Summary".blue().bold());
    println!("{}", "-".repeat(40).blue());
    println!("  {}", validation.summary);
    println!();

    if !has_issues && validation.coverage_score >= 90 {
        println!("{}", "✓ Tasks adequately cover the PRD!".green().bold());
    } else if has_issues {
        println!(
            "{}",
            "✗ PRD coverage issues found. Consider updating tasks.".red()
        );
    }

    has_issues || validation.coverage_score < 70
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::models::Task;

    #[test]
    fn test_results_has_issues() {
        let mut results = DepCheckResults::default();
        assert!(!results.has_issues());

        results
            .missing_deps
            .push(("test".to_string(), "1".to_string(), "99".to_string()));
        assert!(results.has_issues());
    }

    #[test]
    fn test_detect_invalid_zero() {
        let mut phase = Phase::new("test".to_string());
        let mut task = Task::new("1".to_string(), "Test".to_string(), "".to_string());
        task.dependencies = vec!["0".to_string()];
        phase.add_task(task);

        let all_ids: HashSet<String> = ["1".to_string()].into_iter().collect();
        let mut results = DepCheckResults::default();

        validate_phase("test", &phase, &all_ids, &mut results);

        assert_eq!(results.invalid_zero_deps.len(), 1);
        assert_eq!(
            results.invalid_zero_deps[0],
            ("test".to_string(), "1".to_string())
        );
    }

    #[test]
    fn test_detect_missing_dep() {
        let mut phase = Phase::new("test".to_string());
        let mut task = Task::new("1".to_string(), "Test".to_string(), "".to_string());
        task.dependencies = vec!["99".to_string()];
        phase.add_task(task);

        let all_ids: HashSet<String> = ["1".to_string()].into_iter().collect();
        let mut results = DepCheckResults::default();

        validate_phase("test", &phase, &all_ids, &mut results);

        assert_eq!(results.missing_deps.len(), 1);
    }

    #[test]
    fn test_valid_deps_no_issues() {
        let mut phase = Phase::new("test".to_string());

        let task1 = Task::new("1".to_string(), "First".to_string(), "".to_string());
        let mut task2 = Task::new("2".to_string(), "Second".to_string(), "".to_string());
        task2.dependencies = vec!["1".to_string()];

        phase.add_task(task1);
        phase.add_task(task2);

        let all_ids: HashSet<String> = ["1".to_string(), "2".to_string()].into_iter().collect();
        let mut results = DepCheckResults::default();

        validate_phase("test", &phase, &all_ids, &mut results);

        assert!(!results.has_issues());
    }
}