scry-learn 0.1.0

Machine learning toolkit in pure Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
// SPDX-License-Identifier: MIT OR Apache-2.0
//! Neural network engine — chains layers for forward/backward propagation.
//!
//! The [`Network`] struct manages a stack of layers implementing the
//! [`Layer`](super::traits::Layer) trait and provides a unified
//! forward/backward interface used by both `MLPClassifier` and `MLPRegressor`.

use crate::accel::{self, ComputeBackend, GpuBackwardLayer, GpuForwardLayer};
use crate::neural::activation::Activation;
use crate::neural::layer::{DenseLayer, FastRng};
use crate::neural::optimizer::OptimizerState;
use crate::neural::traits::Layer;

/// GPU dispatch threshold: use GPU path when batch * max_dim exceeds this.
/// Applies to both forward and backward passes in MLP mode.
const GPU_THRESHOLD: usize = 4096;

/// A feedforward neural network.
///
/// Holds a heterogeneous stack of layers (Dense, Conv2D, MaxPool, Flatten, etc.)
/// behind the [`Layer`] trait. For MLP-only networks, all layers are [`DenseLayer`].
pub(crate) struct Network {
    pub layers: Vec<Box<dyn Layer>>,
    /// Legacy access to dense layers for GPU-accelerated forward pass.
    /// Only populated when the network is constructed via `Network::new()`.
    dense_layers: Vec<DenseLayer>,
    /// Whether this network was built as a pure-MLP network.
    is_mlp: bool,
    backend: Box<dyn ComputeBackend>,
}

impl Network {
    /// Build a network from layer sizes (including input and output).
    ///
    /// `sizes` example: `[n_features, 100, 50, n_outputs]`
    /// `activation` is applied to all hidden layers; the output layer uses Identity.
    ///
    /// This constructor creates a pure-MLP network (all dense layers).
    pub fn new(sizes: &[usize], activation: Activation, seed: u64) -> Self {
        assert!(sizes.len() >= 2, "need at least input and output sizes");
        let mut rng = FastRng::new(seed);
        let n_layers = sizes.len() - 1;

        let mut dense_layers = Vec::with_capacity(n_layers);
        for i in 0..n_layers {
            let act = if i < n_layers - 1 {
                activation
            } else {
                // Output layer: Identity (softmax/loss handled separately)
                Activation::Identity
            };
            dense_layers.push(DenseLayer::new(sizes[i], sizes[i + 1], act, &mut rng));
        }

        Self {
            layers: Vec::new(), // not used in MLP mode
            dense_layers,
            is_mlp: true,
            backend: accel::auto(),
        }
    }

    /// Build a network from a heterogeneous stack of layers.
    ///
    /// Use this for CNN/mixed architectures.
    #[cfg(feature = "experimental")]
    #[allow(dead_code)]
    pub fn from_layers(layers: Vec<Box<dyn Layer>>) -> Self {
        Self {
            layers,
            dense_layers: Vec::new(),
            is_mlp: false,
            backend: accel::auto(),
        }
    }

    /// Build an MLP network with dropout layers between hidden layers.
    ///
    /// Interleaves `DropoutLayer(p)` after every hidden `DenseLayer`.
    /// The output layer does NOT have dropout applied.
    ///
    /// Falls back to `Network::new()` if `dropout_p` is 0.0 or negative.
    pub fn new_with_dropout(
        sizes: &[usize],
        activation: Activation,
        seed: u64,
        dropout_p: f64,
    ) -> Self {
        if dropout_p <= 0.0 {
            return Self::new(sizes, activation, seed);
        }

        assert!(sizes.len() >= 2, "need at least input and output sizes");
        let mut rng = FastRng::new(seed);
        let n_layers = sizes.len() - 1;

        let mut layers: Vec<Box<dyn Layer>> = Vec::new();
        for i in 0..n_layers {
            let act = if i < n_layers - 1 {
                activation
            } else {
                Activation::Identity
            };
            layers.push(Box::new(DenseLayer::new(
                sizes[i],
                sizes[i + 1],
                act,
                &mut rng,
            )));

            // Insert dropout after every hidden layer (not after the output layer).
            if i < n_layers - 1 && dropout_p > 0.0 {
                layers.push(Box::new(crate::neural::dropout::DropoutLayer::new(
                    dropout_p,
                    sizes[i + 1],
                    seed.wrapping_add(i as u64 + 100),
                )));
            }
        }

        Self {
            layers,
            dense_layers: Vec::new(),
            is_mlp: false,
            backend: accel::auto(),
        }
    }

    /// Forward pass through all layers.
    ///
    /// `input` is row-major `[batch, n_features]`.
    /// Returns the output `[batch, n_outputs]`.
    pub fn forward(&mut self, input: &[f64], batch: usize, training: bool) -> Vec<f64> {
        if self.is_mlp {
            self.forward_mlp(input, batch, training)
        } else {
            self.forward_generic(input, batch, training)
        }
    }

    /// MLP-optimized forward pass with GPU dispatch.
    ///
    /// When the input is large enough to benefit from GPU acceleration,
    /// uses the GPU-resident path: upload once → chain matmul/bias/activation
    /// on device → download once. This eliminates ~98% of PCIe transfers
    /// compared to the per-layer upload/download path.
    fn forward_mlp(&mut self, input: &[f64], batch: usize, training: bool) -> Vec<f64> {
        let use_gpu = batch * self.max_dim_mlp() >= GPU_THRESHOLD;

        if use_gpu {
            self.forward_mlp_gpu(input, batch, training)
        } else {
            let mut current = input.to_vec();
            for layer in &mut self.dense_layers {
                current = layer.forward(&current, batch, training);
            }
            current
        }
    }

    /// GPU-resident MLP forward pass using batched dispatch.
    ///
    /// Chains matmul → bias_add → activation across all layers in a single
    /// GPU command buffer submission (one fence wait). When training, caches
    /// are kept on GPU for the batched backward pass.
    fn forward_mlp_gpu(&mut self, input: &[f64], batch: usize, training: bool) -> Vec<f64> {
        let backend = &*self.backend;

        // Ensure weights are uploaded for all layers.
        for layer in &mut self.dense_layers {
            layer.ensure_gpu_weights(backend);
        }

        // Build per-layer descriptors.
        let descs: Vec<GpuForwardLayer<'_>> = self
            .dense_layers
            .iter()
            .map(|l| GpuForwardLayer {
                weights_t: l.weights_gpu.as_ref().unwrap(),
                bias: l.biases_gpu.as_ref().unwrap(),
                activation: l.activation.to_gpu(),
                in_size: l.in_size,
                out_size: l.out_size,
            })
            .collect();

        let in_size = self.dense_layers[0].in_size;
        let input_tensor = backend.gpu_upload(input, batch, in_size);

        let (output, caches) = backend.gpu_forward_batch(&input_tensor, batch, &descs, training);

        // Store per-layer caches for the backward pass.
        if training {
            for (layer, cache) in self.dense_layers.iter_mut().zip(caches) {
                layer.cache_input_gpu = Some(cache.input);
                layer.cache_z_gpu = Some(cache.z);
                layer.cache_a_gpu = Some(cache.a);
                layer.cache_batch = cache.batch;
            }
        }

        backend.gpu_download(&output)
    }

    /// Generic forward pass through trait-based layers.
    fn forward_generic(&mut self, input: &[f64], batch: usize, training: bool) -> Vec<f64> {
        let mut current = input.to_vec();
        for layer in &mut self.layers {
            current = layer.forward(&current, batch, training);
        }
        current
    }

    /// Backward pass through all layers.
    ///
    /// `grad_output` is `[batch, n_outputs]` — the gradient of loss w.r.t. network output.
    /// `alpha` is the L2 regularization strength.
    ///
    /// Uses GPU when the forward pass cached on device (gpu_backward path).
    ///
    /// Returns weight and bias gradients for all layers.
    pub fn backward(&mut self, grad_output: &[f64], alpha: f64) -> Vec<(Vec<f64>, Vec<f64>)> {
        if self.is_mlp && self.has_gpu_caches() {
            self.backward_mlp_gpu(grad_output, alpha)
        } else if self.is_mlp {
            self.backward_mlp(grad_output, alpha)
        } else {
            self.backward_generic(grad_output, alpha)
        }
    }

    /// Whether the forward pass cached on GPU (backward should use GPU too).
    fn has_gpu_caches(&self) -> bool {
        self.dense_layers
            .first()
            .is_some_and(|l| l.cache_z_gpu.is_some())
    }

    /// GPU-resident MLP backward pass using batched dispatch.
    ///
    /// Chains activation_backward → reduce_cols → transpose → matmul(dW) →
    /// scale → matmul(grad_input) across all layers in a single GPU
    /// submission. Only dw/db are downloaded for the CPU optimizer step.
    fn backward_mlp_gpu(&mut self, grad_output: &[f64], alpha: f64) -> Vec<(Vec<f64>, Vec<f64>)> {
        let backend = &*self.backend;
        let n = self.dense_layers.len();
        let batch = self.dense_layers.last().map_or(0, |l| l.cache_batch);
        let last_out = self.dense_layers.last().map_or(0, |l| l.out_size);

        // Build backward layer descriptors in reverse order (last layer first).
        let descs: Vec<GpuBackwardLayer<'_>> = (0..n)
            .rev()
            .map(|i| {
                let l = &self.dense_layers[i];
                GpuBackwardLayer {
                    z_cache: l.cache_z_gpu.as_ref().unwrap(),
                    a_cache: l.cache_a_gpu.as_ref().unwrap(),
                    input_cache: l.cache_input_gpu.as_ref().unwrap(),
                    weights_w: l.weights_w_gpu.as_ref().unwrap(),
                    activation: l.activation.to_gpu(),
                    batch,
                    in_size: l.in_size,
                    out_size: l.out_size,
                }
            })
            .collect();

        let grad_tensor = backend.gpu_upload(grad_output, batch, last_out);
        let mut grads = backend.gpu_backward_batch(&grad_tensor, &descs);

        // Apply L2 regularization. Grads are in reverse layer order.
        if alpha > 0.0 {
            for (j, (ref mut dw, _)) in grads.iter_mut().enumerate() {
                let layer_idx = n - 1 - j;
                for (w_idx, dw_val) in dw.iter_mut().enumerate() {
                    *dw_val += alpha * self.dense_layers[layer_idx].weights[w_idx];
                }
            }
        }

        // Reverse to match layer order [0..n].
        grads.reverse();

        // Clear GPU caches (consumed).
        for layer in &mut self.dense_layers {
            layer.cache_z_gpu = None;
            layer.cache_a_gpu = None;
            layer.cache_input_gpu = None;
        }

        grads
    }

    /// MLP backward pass — CPU path.
    fn backward_mlp(&self, grad_output: &[f64], alpha: f64) -> Vec<(Vec<f64>, Vec<f64>)> {
        let n = self.dense_layers.len();
        let mut grads = Vec::with_capacity(n);
        let mut current_grad = grad_output.to_vec();

        for i in (0..n).rev() {
            let layer = &self.dense_layers[i];
            let mut dw = vec![0.0; layer.out_size * layer.in_size];
            let mut db = vec![0.0; layer.out_size];

            current_grad = layer.backward(&current_grad, &mut dw, &mut db);

            // L2 regularization on weights only (not biases)
            if alpha > 0.0 {
                for (w_idx, dw_val) in dw.iter_mut().enumerate() {
                    *dw_val += alpha * layer.weights[w_idx];
                }
            }

            grads.push((dw, db));
        }

        // Reverse so grads[i] corresponds to layers[i]
        grads.reverse();
        grads
    }

    fn backward_generic(&self, grad_output: &[f64], alpha: f64) -> Vec<(Vec<f64>, Vec<f64>)> {
        let mut all_grads = Vec::new();
        let mut current_grad = grad_output.to_vec();

        for layer in self.layers.iter().rev() {
            let (grad_input, param_grads) = layer.backward(&current_grad);
            current_grad = grad_input;

            // Collect parameter gradients (may be empty for param-free layers).
            for (mut dw, db) in param_grads {
                // L2 regularization on weights.
                if alpha > 0.0 {
                    let saved = layer.save_params();
                    if let Some((ref weights, _)) = saved.first() {
                        for (w_idx, dw_val) in dw.iter_mut().enumerate() {
                            if w_idx < weights.len() {
                                *dw_val += alpha * weights[w_idx];
                            }
                        }
                    }
                }
                all_grads.push((dw, db));
            }
        }

        all_grads.reverse();
        all_grads
    }

    /// Apply optimizer step to all layers.
    ///
    /// Invalidates GPU weight caches since weights have changed.
    pub fn apply_gradients(
        &mut self,
        grads: &[(Vec<f64>, Vec<f64>)],
        optimizer: &mut OptimizerState,
    ) {
        if self.is_mlp {
            for (i, layer) in self.dense_layers.iter_mut().enumerate() {
                let (ref dw, ref db) = grads[i];
                let w_idx = i * 2;
                let b_idx = i * 2 + 1;
                optimizer.step(w_idx, &mut layer.weights, dw);
                optimizer.step(b_idx, &mut layer.biases, db);
                layer.invalidate_gpu_weights();
            }
        } else {
            let mut grad_idx = 0;
            let mut opt_idx = 0;
            for layer in &mut self.layers {
                let params = layer.params_mut();
                for (weights, biases) in params {
                    if grad_idx < grads.len() {
                        let (ref dw, ref db) = grads[grad_idx];
                        optimizer.step(opt_idx, weights, dw);
                        optimizer.step(opt_idx + 1, biases, db);
                        grad_idx += 1;
                        opt_idx += 2;
                    }
                }
            }
        }
    }

    /// Build optimizer param group sizes: [w0_size, b0_size, w1_size, b1_size, ...].
    pub fn param_group_sizes(&self) -> Vec<usize> {
        if self.is_mlp {
            let mut sizes = Vec::with_capacity(self.dense_layers.len() * 2);
            for layer in &self.dense_layers {
                sizes.push(layer.weights.len());
                sizes.push(layer.biases.len());
            }
            sizes
        } else {
            let mut sizes = Vec::new();
            for layer in &self.layers {
                let params = layer.save_params();
                for (w, b) in &params {
                    sizes.push(w.len());
                    sizes.push(b.len());
                }
            }
            sizes
        }
    }

    /// Total number of trainable parameters.
    #[allow(dead_code)]
    pub fn n_params(&self) -> usize {
        if self.is_mlp {
            self.dense_layers.iter().map(DenseLayer::n_params).sum()
        } else {
            self.layers
                .iter()
                .map(|l| {
                    l.save_params()
                        .iter()
                        .map(|(w, b)| w.len() + b.len())
                        .sum::<usize>()
                })
                .sum()
        }
    }

    /// Get the maximum dimension across all layers (for GPU threshold).
    fn max_dim_mlp(&self) -> usize {
        self.dense_layers
            .iter()
            .map(|l| l.in_size.max(l.out_size))
            .max()
            .unwrap_or(0)
    }

    /// Clone all weights and biases (for early stopping best-weight saving).
    pub fn save_weights(&self) -> Vec<(Vec<f64>, Vec<f64>)> {
        if self.is_mlp {
            self.dense_layers
                .iter()
                .map(|l| (l.weights.clone(), l.biases.clone()))
                .collect()
        } else {
            self.layers.iter().flat_map(|l| l.save_params()).collect()
        }
    }

    /// Restore weights and biases from a saved snapshot.
    pub fn restore_weights(&mut self, saved: &[(Vec<f64>, Vec<f64>)]) {
        if self.is_mlp {
            for (layer, (w, b)) in self.dense_layers.iter_mut().zip(saved.iter()) {
                layer.weights.clone_from(w);
                layer.biases.clone_from(b);
                layer.invalidate_gpu_weights();
            }
        } else {
            let mut idx = 0;
            for layer in &mut self.layers {
                let n = layer.n_param_groups();
                if n > 0 && idx + n <= saved.len() {
                    layer.restore_params(&saved[idx..idx + n]);
                    idx += n;
                }
            }
        }
    }

    /// Get weights for each layer (for visualization).
    #[allow(dead_code)]
    pub fn layer_weights(&self) -> Vec<&[f64]> {
        if self.is_mlp {
            self.dense_layers
                .iter()
                .map(|l| l.weights.as_slice())
                .collect()
        } else {
            vec![] // generic layers don't expose raw weight slices
        }
    }

    /// Get layer dimensions: (in_size, out_size) for each layer.
    pub fn layer_dims(&self) -> Vec<(usize, usize)> {
        if self.is_mlp {
            self.dense_layers
                .iter()
                .map(|l| (l.in_size, l.out_size))
                .collect()
        } else {
            self.layers
                .iter()
                .map(|l| (l.in_size(), l.out_size()))
                .collect()
        }
    }
}

// ── Loss functions ──

/// Cross-entropy loss with numerically stable log-sum-exp.
///
/// `logits` is `[batch, n_classes]` (raw network output, no softmax).
/// `targets` is `[batch]` with class indices as f64.
///
/// Returns (mean loss, gradient `[batch, n_classes]`).
pub(crate) fn cross_entropy_loss(
    logits: &[f64],
    targets: &[f64],
    batch: usize,
    n_classes: usize,
) -> (f64, Vec<f64>) {
    debug_assert_eq!(logits.len(), batch * n_classes);
    debug_assert_eq!(targets.len(), batch);

    let mut grad = vec![0.0; batch * n_classes];
    let mut total_loss = 0.0;

    for i in 0..batch {
        let row = &logits[i * n_classes..(i + 1) * n_classes];
        let target_class = targets[i] as usize;

        // Log-sum-exp trick for numerical stability
        let max_logit = row.iter().copied().fold(f64::NEG_INFINITY, f64::max);
        let sum_exp: f64 = row.iter().map(|&x| (x - max_logit).exp()).sum();
        let log_sum_exp = max_logit + sum_exp.ln();

        // Loss = -log(softmax[target]) = -(logit[target] - log_sum_exp)
        total_loss += log_sum_exp - row[target_class];

        // Gradient of cross-entropy w.r.t. logits = softmax - one_hot
        for j in 0..n_classes {
            let softmax_j = (row[j] - log_sum_exp).exp();
            grad[i * n_classes + j] = softmax_j;
        }
        grad[i * n_classes + target_class] -= 1.0;
    }

    (total_loss / batch as f64, grad)
}

/// Mean squared error loss.
///
/// `predictions` is `[batch, 1]` (or `[batch]` flattened).
/// `targets` is `[batch]`.
///
/// Returns (mean loss, gradient `[batch, 1]`).
pub(crate) fn mse_loss(predictions: &[f64], targets: &[f64], batch: usize) -> (f64, Vec<f64>) {
    debug_assert_eq!(predictions.len(), batch);
    debug_assert_eq!(targets.len(), batch);

    let mut total_loss = 0.0;
    let mut grad = vec![0.0; batch];
    let batch_f = batch as f64;

    for i in 0..batch {
        let diff = predictions[i] - targets[i];
        total_loss += diff * diff;
        grad[i] = 2.0 * diff / batch_f;
    }

    (total_loss / batch_f, grad)
}

/// Convert softmax probabilities to class predictions.
pub(crate) fn argmax_predictions(probs: &[f64], batch: usize, n_classes: usize) -> Vec<f64> {
    let mut preds = Vec::with_capacity(batch);
    for i in 0..batch {
        let row = &probs[i * n_classes..(i + 1) * n_classes];
        let (max_idx, _) =
            row.iter()
                .enumerate()
                .fold((0, f64::NEG_INFINITY), |(bi, bv), (idx, &v)| {
                    if v > bv {
                        (idx, v)
                    } else {
                        (bi, bv)
                    }
                });
        preds.push(max_idx as f64);
    }
    preds
}

/// Compute softmax probabilities from logits.
pub(crate) fn softmax(logits: &[f64], batch: usize, n_classes: usize) -> Vec<f64> {
    let mut probs = vec![0.0; batch * n_classes];
    for i in 0..batch {
        let row = &logits[i * n_classes..(i + 1) * n_classes];
        let max_val = row.iter().copied().fold(f64::NEG_INFINITY, f64::max);
        let sum_exp: f64 = row.iter().map(|&x| (x - max_val).exp()).sum();
        for j in 0..n_classes {
            probs[i * n_classes + j] = (row[j] - max_val).exp() / sum_exp;
        }
    }
    probs
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn network_forward_shape() {
        let mut net = Network::new(&[4, 10, 3], Activation::Relu, 42);
        let input = vec![1.0; 2 * 4]; // batch=2, features=4
        let output = net.forward(&input, 2, false);
        assert_eq!(output.len(), 2 * 3);
    }

    #[test]
    fn cross_entropy_gradient_sums_to_zero() {
        let logits = vec![2.0, 1.0, 0.1, 0.5, 2.5, 0.3];
        let targets = vec![0.0, 2.0];
        let (_, grad) = cross_entropy_loss(&logits, &targets, 2, 3);
        // Each row of gradient should sum to 0 (softmax sums to 1, minus one-hot sums to 1)
        let row0_sum: f64 = grad[0..3].iter().sum();
        let row1_sum: f64 = grad[3..6].iter().sum();
        assert!(row0_sum.abs() < 1e-10);
        assert!(row1_sum.abs() < 1e-10);
    }

    #[test]
    fn mse_loss_basic() {
        let preds = vec![1.0, 2.0, 3.0];
        let targets = vec![1.0, 2.0, 3.0];
        let (loss, _) = mse_loss(&preds, &targets, 3);
        assert!(loss.abs() < 1e-10);
    }

    #[test]
    fn softmax_sums_to_one() {
        let logits = vec![2.0, 1.0, 0.5];
        let probs = softmax(&logits, 1, 3);
        let sum: f64 = probs.iter().sum();
        assert!((sum - 1.0).abs() < 1e-10);
    }

    #[test]
    fn network_backward_gradient_check() {
        let mut net = Network::new(&[3, 5, 2], Activation::Tanh, 42);
        let input = vec![0.5, -0.3, 0.8];
        let batch = 1;
        let targets = vec![1.0]; // class 1

        // Forward + loss
        let logits = net.forward(&input, batch, true);
        let (_loss, grad) = cross_entropy_loss(&logits, &targets, batch, 2);

        // Backward
        let layer_grads = net.backward(&grad, 0.0);

        // Numerical gradient check for first layer weights
        let eps = 1e-5;
        let n_weights = net.dense_layers[0].weights.len();
        for idx in 0..n_weights.min(6) {
            let orig = net.dense_layers[0].weights[idx];

            net.dense_layers[0].weights[idx] = orig + eps;
            let logits_p = net.forward(&input, batch, false);
            let (loss_p, _) = cross_entropy_loss(&logits_p, &targets, batch, 2);

            net.dense_layers[0].weights[idx] = orig - eps;
            let logits_m = net.forward(&input, batch, false);
            let (loss_m, _) = cross_entropy_loss(&logits_m, &targets, batch, 2);

            net.dense_layers[0].weights[idx] = orig;

            let numerical = (loss_p - loss_m) / (2.0 * eps);
            let analytic = layer_grads[0].0[idx];

            let diff = (analytic - numerical).abs();
            let denom = analytic.abs().max(numerical.abs()).max(1e-8);
            assert!(
                diff / denom < 1e-3,
                "layer 0 weight {idx}: analytic={analytic:.8}, numerical={numerical:.8}, rel_err={:.6}",
                diff / denom,
            );
        }
    }

    #[test]
    fn save_restore_weights() {
        let mut net = Network::new(&[3, 5, 2], Activation::Relu, 42);
        let saved = net.save_weights();

        // Mutate weights
        net.dense_layers[0].weights[0] = 999.0;
        assert!((net.dense_layers[0].weights[0] - 999.0).abs() < 1e-10);

        // Restore
        net.restore_weights(&saved);
        assert!((net.dense_layers[0].weights[0] - 999.0).abs() > 1e-5);
    }

    #[test]
    #[cfg(feature = "experimental")]
    fn generic_network_forward() {
        use crate::neural::conv::Conv2D;
        use crate::neural::flatten::Flatten;
        use crate::neural::pool::MaxPool2D;

        // Conv2D(1→2, 3×3) on 6×6 input → 2×4×4 → MaxPool(2) → 2×2×2 → Flatten → 8
        let mut pool = MaxPool2D::new(2, None);
        pool.channels = 2;

        let mut net = Network::from_layers(vec![
            Box::new(Conv2D::new(1, 2, 3, 1, 0, Activation::Relu, 42)),
            Box::new(pool),
            Box::new(Flatten::new()),
        ]);

        // batch=1, 1 channel, 6×6
        let input = vec![0.5; 36];
        let output = net.forward(&input, 1, false);
        // Conv: 6-3+1=4 → 2×4×4=32, Pool: 4/2=2 → 2×2×2=8, Flatten: 8
        assert_eq!(output.len(), 8);
    }
}