scivex-nn 0.1.1

Scivex — Neural networks, autograd, layers, optimizers
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
//! Attention mechanism variants: Multi-Query, Grouped-Query, and Flash Attention.

use scivex_core::random::Rng;
use scivex_core::{Float, Tensor};

use crate::error::{NnError, Result};
use crate::variable::Variable;

use super::Layer;
use super::linear::Linear;

// Re-use the row_softmax helper from the attention module pattern.
fn row_softmax<T: Float>(data: &mut [T], rows: usize, cols: usize) {
    for i in 0..rows {
        let row = &mut data[i * cols..(i + 1) * cols];
        let max = row.iter().copied().fold(T::neg_infinity(), T::max);
        let mut sum = T::zero();
        for v in row.iter_mut() {
            *v = (*v - max).exp();
            sum += *v;
        }
        if sum > T::zero() {
            for v in row.iter_mut() {
                *v /= sum;
            }
        }
    }
}

// ── MultiQueryAttention ──────────────────────────────────────────────────

/// Multi-Query Attention (MQA).
///
/// All query heads have their own projections, but K and V share a **single**
/// head.  This dramatically reduces KV-cache memory compared to standard MHA.
///
/// Input:  `[batch, seq_len * d_model]`
/// Output: `[batch, seq_len * d_model]`
pub struct MultiQueryAttention<T: Float> {
    w_q: Linear<T>,
    w_k: Linear<T>,
    w_v: Linear<T>,
    w_o: Linear<T>,
    num_heads: usize,
    d_model: usize,
    d_k: usize,
    seq_len: usize,
}

impl<T: Float> MultiQueryAttention<T> {
    /// Create a new Multi-Query Attention layer.
    ///
    /// `d_model` must be divisible by `num_heads`.
    /// K and V are projected to a single head of size `d_k = d_model / num_heads`.
    #[allow(clippy::manual_is_multiple_of)]
    pub fn new(d_model: usize, num_heads: usize, seq_len: usize, rng: &mut Rng) -> Result<Self> {
        if d_model % num_heads != 0 {
            return Err(NnError::InvalidParameter {
                name: "d_model",
                reason: "d_model must be divisible by num_heads",
            });
        }
        let d_k = d_model / num_heads;
        Ok(Self {
            w_q: Linear::new(d_model, d_model, true, rng), // [d_model -> d_model]
            w_k: Linear::new(d_model, d_k, true, rng),     // [d_model -> d_k] single head
            w_v: Linear::new(d_model, d_k, true, rng),     // [d_model -> d_k] single head
            w_o: Linear::new(d_model, d_model, true, rng),
            num_heads,
            d_model,
            d_k,
            seq_len,
        })
    }
}

impl<T: Float> Layer<T> for MultiQueryAttention<T> {
    #[allow(clippy::too_many_lines)]
    fn forward(&self, x: &Variable<T>) -> Result<Variable<T>> {
        let shape = x.shape();
        let expected_cols = self.seq_len * self.d_model;
        if shape.len() != 2 || shape[1] != expected_cols {
            return Err(NnError::ShapeMismatch {
                expected: vec![0, expected_cols],
                got: shape,
            });
        }
        let batch = shape[0];
        let seq = self.seq_len;
        let dm = self.d_model;
        let nh = self.num_heads;
        let dk = self.d_k;

        // Reshape to [batch * seq, d_model]
        let xd = x.data();
        let xs = xd.as_slice();
        let flat_tensor =
            Tensor::from_vec(xs.to_vec(), vec![batch * seq, dm]).expect("valid shape");
        let flat_var = Variable::new(flat_tensor, x.requires_grad());

        // Q: [batch * seq, d_model],  K: [batch * seq, d_k],  V: [batch * seq, d_k]
        let q_flat = self.w_q.forward(&flat_var)?;
        let k_flat = self.w_k.forward(&flat_var)?;
        let v_flat = self.w_v.forward(&flat_var)?;

        let qd = q_flat.data();
        let qs = qd.as_slice();
        let kd = k_flat.data();
        let ks = kd.as_slice();
        let vd = v_flat.data();
        let vs = vd.as_slice();

        let scale = T::from_f64(1.0 / (dk as f64).sqrt());

        let mut attn_out = vec![T::zero(); batch * seq * dm];

        for b in 0..batch {
            // Extract single K, V head for this batch: [seq, d_k]
            let mut k_shared = vec![T::zero(); seq * dk];
            let mut v_shared = vec![T::zero(); seq * dk];
            for s in 0..seq {
                let base = (b * seq + s) * dk;
                for d in 0..dk {
                    k_shared[s * dk + d] = ks[base + d];
                    v_shared[s * dk + d] = vs[base + d];
                }
            }

            for h in 0..nh {
                // Extract Q_h for this head: [seq, d_k]
                let mut q_h = vec![T::zero(); seq * dk];
                for s in 0..seq {
                    let base = (b * seq + s) * dm + h * dk;
                    for d in 0..dk {
                        q_h[s * dk + d] = qs[base + d];
                    }
                }

                // scores = Q_h @ K^T * scale -> [seq, seq]
                let mut scores = vec![T::zero(); seq * seq];
                for i in 0..seq {
                    for j in 0..seq {
                        let mut sum = T::zero();
                        for d in 0..dk {
                            sum += q_h[i * dk + d] * k_shared[j * dk + d];
                        }
                        scores[i * seq + j] = sum * scale;
                    }
                }

                row_softmax(&mut scores, seq, seq);

                // out_h = attn @ V -> [seq, d_k]
                for i in 0..seq {
                    for d in 0..dk {
                        let mut sum = T::zero();
                        for j in 0..seq {
                            sum += scores[i * seq + j] * v_shared[j * dk + d];
                        }
                        attn_out[b * seq * dm + i * dm + h * dk + d] = sum;
                    }
                }
            }
        }

        // Output projection
        let concat_tensor = Tensor::from_vec(attn_out, vec![batch * seq, dm]).expect("valid shape");
        let concat_var = Variable::new(concat_tensor, true);
        let projected = self.w_o.forward(&concat_var)?;

        let pd = projected.data();
        let ps = pd.as_slice();
        let out_tensor = Tensor::from_vec(ps.to_vec(), vec![batch, seq * dm]).expect("valid shape");

        let grad_fn = Box::new(move |g: &Tensor<T>| {
            let gs = g.as_slice();
            let gx = gs.to_vec();
            vec![
                Tensor::from_vec(gx, vec![batch, seq * dm]).expect("valid"),
                Tensor::zeros(vec![batch * seq, dm]),
                Tensor::zeros(vec![batch * seq, dk]),
                Tensor::zeros(vec![batch * seq, dk]),
                Tensor::from_vec(gs.to_vec(), vec![batch * seq, dm]).expect("valid"),
            ]
        });

        Ok(Variable::from_op(
            out_tensor,
            vec![x.clone(), q_flat, k_flat, v_flat, projected],
            grad_fn,
        ))
    }

    fn parameters(&self) -> Vec<Variable<T>> {
        let mut params = self.w_q.parameters();
        params.extend(self.w_k.parameters());
        params.extend(self.w_v.parameters());
        params.extend(self.w_o.parameters());
        params
    }

    fn train(&mut self) {}
    fn eval(&mut self) {}
}

// ── GroupedQueryAttention ─────────────────────────────────────────────────

/// Grouped-Query Attention (GQA).
///
/// Queries are divided into groups; each group shares K/V heads (Llama 2 style).
/// When `num_kv_heads == 1` this is equivalent to MQA.
/// When `num_kv_heads == num_heads` this is equivalent to standard MHA.
///
/// Input:  `[batch, seq_len * d_model]`
/// Output: `[batch, seq_len * d_model]`
pub struct GroupedQueryAttention<T: Float> {
    w_q: Linear<T>,
    w_k: Linear<T>,
    w_v: Linear<T>,
    w_o: Linear<T>,
    num_heads: usize,
    num_kv_heads: usize,
    d_model: usize,
    d_k: usize,
    seq_len: usize,
}

impl<T: Float> GroupedQueryAttention<T> {
    /// Create a new Grouped-Query Attention layer.
    ///
    /// `d_model` must be divisible by `num_heads`, and `num_heads` must be
    /// divisible by `num_kv_heads`.
    #[allow(clippy::manual_is_multiple_of)]
    pub fn new(
        d_model: usize,
        num_heads: usize,
        num_kv_heads: usize,
        seq_len: usize,
        rng: &mut Rng,
    ) -> Result<Self> {
        if d_model % num_heads != 0 {
            return Err(NnError::InvalidParameter {
                name: "d_model",
                reason: "d_model must be divisible by num_heads",
            });
        }
        if num_heads % num_kv_heads != 0 {
            return Err(NnError::InvalidParameter {
                name: "num_heads",
                reason: "num_heads must be divisible by num_kv_heads",
            });
        }
        let d_k = d_model / num_heads;
        let kv_dim = num_kv_heads * d_k;
        Ok(Self {
            w_q: Linear::new(d_model, d_model, true, rng), // [d_model -> d_model]
            w_k: Linear::new(d_model, kv_dim, true, rng),  // [d_model -> kv_dim]
            w_v: Linear::new(d_model, kv_dim, true, rng),  // [d_model -> kv_dim]
            w_o: Linear::new(d_model, d_model, true, rng),
            num_heads,
            num_kv_heads,
            d_model,
            d_k,
            seq_len,
        })
    }
}

impl<T: Float> Layer<T> for GroupedQueryAttention<T> {
    #[allow(clippy::too_many_lines)]
    fn forward(&self, x: &Variable<T>) -> Result<Variable<T>> {
        let shape = x.shape();
        let expected_cols = self.seq_len * self.d_model;
        if shape.len() != 2 || shape[1] != expected_cols {
            return Err(NnError::ShapeMismatch {
                expected: vec![0, expected_cols],
                got: shape,
            });
        }
        let batch = shape[0];
        let seq = self.seq_len;
        let dm = self.d_model;
        let nh = self.num_heads;
        let nkv = self.num_kv_heads;
        let dk = self.d_k;
        let kv_dim = nkv * dk;
        let heads_per_group = nh / nkv;

        // Reshape to [batch * seq, d_model]
        let xd = x.data();
        let xs = xd.as_slice();
        let flat_tensor =
            Tensor::from_vec(xs.to_vec(), vec![batch * seq, dm]).expect("valid shape");
        let flat_var = Variable::new(flat_tensor, x.requires_grad());

        // Q: [batch * seq, d_model],  K: [batch * seq, kv_dim],  V: [batch * seq, kv_dim]
        let q_flat = self.w_q.forward(&flat_var)?;
        let k_flat = self.w_k.forward(&flat_var)?;
        let v_flat = self.w_v.forward(&flat_var)?;

        let qd = q_flat.data();
        let qs = qd.as_slice();
        let kd = k_flat.data();
        let ks = kd.as_slice();
        let vd = v_flat.data();
        let vs = vd.as_slice();

        let scale = T::from_f64(1.0 / (dk as f64).sqrt());

        let mut attn_out = vec![T::zero(); batch * seq * dm];

        for b in 0..batch {
            for h in 0..nh {
                let kv_head = h / heads_per_group; // which KV head this query head uses

                // Extract Q_h: [seq, d_k]
                let mut q_h = vec![T::zero(); seq * dk];
                for s in 0..seq {
                    let base_q = (b * seq + s) * dm + h * dk;
                    for d in 0..dk {
                        q_h[s * dk + d] = qs[base_q + d];
                    }
                }

                // Extract K_kv, V_kv for the shared kv_head: [seq, d_k]
                let mut k_h = vec![T::zero(); seq * dk];
                let mut v_h = vec![T::zero(); seq * dk];
                for s in 0..seq {
                    let base_kv = (b * seq + s) * kv_dim + kv_head * dk;
                    for d in 0..dk {
                        k_h[s * dk + d] = ks[base_kv + d];
                        v_h[s * dk + d] = vs[base_kv + d];
                    }
                }

                // scores = Q_h @ K_h^T * scale -> [seq, seq]
                let mut scores = vec![T::zero(); seq * seq];
                for i in 0..seq {
                    for j in 0..seq {
                        let mut sum = T::zero();
                        for d in 0..dk {
                            sum += q_h[i * dk + d] * k_h[j * dk + d];
                        }
                        scores[i * seq + j] = sum * scale;
                    }
                }

                row_softmax(&mut scores, seq, seq);

                // out_h = attn @ V_h -> [seq, d_k]
                for i in 0..seq {
                    for d in 0..dk {
                        let mut sum = T::zero();
                        for j in 0..seq {
                            sum += scores[i * seq + j] * v_h[j * dk + d];
                        }
                        attn_out[b * seq * dm + i * dm + h * dk + d] = sum;
                    }
                }
            }
        }

        // Output projection
        let concat_tensor = Tensor::from_vec(attn_out, vec![batch * seq, dm]).expect("valid shape");
        let concat_var = Variable::new(concat_tensor, true);
        let projected = self.w_o.forward(&concat_var)?;

        let pd = projected.data();
        let ps = pd.as_slice();
        let out_tensor = Tensor::from_vec(ps.to_vec(), vec![batch, seq * dm]).expect("valid shape");

        let grad_fn = Box::new(move |g: &Tensor<T>| {
            let gs = g.as_slice();
            let gx = gs.to_vec();
            vec![
                Tensor::from_vec(gx, vec![batch, seq * dm]).expect("valid"),
                Tensor::zeros(vec![batch * seq, dm]),
                Tensor::zeros(vec![batch * seq, kv_dim]),
                Tensor::zeros(vec![batch * seq, kv_dim]),
                Tensor::from_vec(gs.to_vec(), vec![batch * seq, dm]).expect("valid"),
            ]
        });

        Ok(Variable::from_op(
            out_tensor,
            vec![x.clone(), q_flat, k_flat, v_flat, projected],
            grad_fn,
        ))
    }

    fn parameters(&self) -> Vec<Variable<T>> {
        let mut params = self.w_q.parameters();
        params.extend(self.w_k.parameters());
        params.extend(self.w_v.parameters());
        params.extend(self.w_o.parameters());
        params
    }

    fn train(&mut self) {}
    fn eval(&mut self) {}
}

// ── FlashAttention ───────────────────────────────────────────────────────

/// Memory-efficient "Flash" Attention.
///
/// Computes scaled dot-product attention in tiles without materializing the
/// full `[seq, seq]` attention matrix.  Uses the online softmax algorithm
/// (running max + running sum) to accumulate results block-by-block.
///
/// Input:  `[batch, seq_len * d_model]`
/// Output: `[batch, seq_len * d_model]`
pub struct FlashAttention<T: Float> {
    w_q: Linear<T>,
    w_k: Linear<T>,
    w_v: Linear<T>,
    w_o: Linear<T>,
    num_heads: usize,
    d_model: usize,
    d_k: usize,
    seq_len: usize,
    block_size: usize,
}

impl<T: Float> FlashAttention<T> {
    /// Create a new Flash Attention layer.
    ///
    /// `d_model` must be divisible by `num_heads`.
    /// `block_size` controls the tile size for the block-wise computation.
    #[allow(clippy::manual_is_multiple_of)]
    pub fn new(
        d_model: usize,
        num_heads: usize,
        seq_len: usize,
        block_size: usize,
        rng: &mut Rng,
    ) -> Result<Self> {
        if d_model % num_heads != 0 {
            return Err(NnError::InvalidParameter {
                name: "d_model",
                reason: "d_model must be divisible by num_heads",
            });
        }
        if block_size == 0 {
            return Err(NnError::InvalidParameter {
                name: "block_size",
                reason: "block_size must be > 0",
            });
        }
        let d_k = d_model / num_heads;
        Ok(Self {
            w_q: Linear::new(d_model, d_model, true, rng),
            w_k: Linear::new(d_model, d_model, true, rng),
            w_v: Linear::new(d_model, d_model, true, rng),
            w_o: Linear::new(d_model, d_model, true, rng),
            num_heads,
            d_model,
            d_k,
            seq_len,
            block_size,
        })
    }
}

impl<T: Float> Layer<T> for FlashAttention<T> {
    #[allow(clippy::too_many_lines)]
    fn forward(&self, x: &Variable<T>) -> Result<Variable<T>> {
        let shape = x.shape();
        let expected_cols = self.seq_len * self.d_model;
        if shape.len() != 2 || shape[1] != expected_cols {
            return Err(NnError::ShapeMismatch {
                expected: vec![0, expected_cols],
                got: shape,
            });
        }
        let batch = shape[0];
        let seq = self.seq_len;
        let dm = self.d_model;
        let nh = self.num_heads;
        let dk = self.d_k;
        let bs = self.block_size;

        // Reshape to [batch * seq, d_model]
        let xd = x.data();
        let xs = xd.as_slice();
        let flat_tensor =
            Tensor::from_vec(xs.to_vec(), vec![batch * seq, dm]).expect("valid shape");
        let flat_var = Variable::new(flat_tensor, x.requires_grad());

        let q_flat = self.w_q.forward(&flat_var)?;
        let k_flat = self.w_k.forward(&flat_var)?;
        let v_flat = self.w_v.forward(&flat_var)?;

        let qd = q_flat.data();
        let qs = qd.as_slice();
        let kd = k_flat.data();
        let ks = kd.as_slice();
        let vd = v_flat.data();
        let vs = vd.as_slice();

        let scale = T::from_f64(1.0 / (dk as f64).sqrt());

        let mut attn_out = vec![T::zero(); batch * seq * dm];

        for b in 0..batch {
            for h in 0..nh {
                // Extract Q_h, K_h, V_h: [seq, d_k]
                let mut q_h = vec![T::zero(); seq * dk];
                let mut k_h = vec![T::zero(); seq * dk];
                let mut v_h = vec![T::zero(); seq * dk];

                for s in 0..seq {
                    let base = (b * seq + s) * dm + h * dk;
                    for d in 0..dk {
                        q_h[s * dk + d] = qs[base + d];
                        k_h[s * dk + d] = ks[base + d];
                        v_h[s * dk + d] = vs[base + d];
                    }
                }

                // Block-wise (tiled) attention with online softmax.
                // For each block of query rows, accumulate attention over K/V blocks.
                //
                // Per query row i we maintain:
                //   m_i : running max of scores
                //   l_i : running sum of exp(score - m_i)
                //   o_i : running weighted sum (unnormalised)
                let mut m_vec = vec![T::neg_infinity(); seq]; // running max per query row
                let mut l_vec = vec![T::zero(); seq]; // running sum per query row
                let mut o_buf = vec![T::zero(); seq * dk]; // running output per query row

                // Iterate over key blocks
                let num_k_blocks = seq.div_ceil(bs);
                for kb in 0..num_k_blocks {
                    let k_start = kb * bs;
                    let k_end = (k_start + bs).min(seq);
                    let k_len = k_end - k_start;

                    // Iterate over query blocks
                    let num_q_blocks = seq.div_ceil(bs);
                    for qb in 0..num_q_blocks {
                        let q_start = qb * bs;
                        let q_end = (q_start + bs).min(seq);

                        for qi in q_start..q_end {
                            // Compute scores for this query row against the key block
                            // and update online softmax accumulators.
                            let old_m = m_vec[qi];

                            // Find new local max
                            let mut block_max = T::neg_infinity();
                            for kj in 0..k_len {
                                let mut dot = T::zero();
                                for d in 0..dk {
                                    dot += q_h[qi * dk + d] * k_h[(k_start + kj) * dk + d];
                                }
                                let s = dot * scale;
                                if s > block_max {
                                    block_max = s;
                                }
                            }

                            let new_m = if block_max > old_m { block_max } else { old_m };

                            // Correction factor for old accumulators
                            let correction = (old_m - new_m).exp();

                            // Scale old accumulator
                            l_vec[qi] *= correction;
                            for d in 0..dk {
                                o_buf[qi * dk + d] *= correction;
                            }

                            // Accumulate new block
                            for kj in 0..k_len {
                                let mut dot = T::zero();
                                for d in 0..dk {
                                    dot += q_h[qi * dk + d] * k_h[(k_start + kj) * dk + d];
                                }
                                let s = dot * scale;
                                let w = (s - new_m).exp();
                                l_vec[qi] += w;
                                for d in 0..dk {
                                    o_buf[qi * dk + d] += w * v_h[(k_start + kj) * dk + d];
                                }
                            }

                            m_vec[qi] = new_m;
                        }
                    }
                }

                // Normalise: o_i / l_i
                for i in 0..seq {
                    let li = l_vec[i];
                    if li > T::zero() {
                        for d in 0..dk {
                            let val = o_buf[i * dk + d] / li;
                            attn_out[b * seq * dm + i * dm + h * dk + d] = val;
                        }
                    }
                }
            }
        }

        // Output projection
        let concat_tensor = Tensor::from_vec(attn_out, vec![batch * seq, dm]).expect("valid shape");
        let concat_var = Variable::new(concat_tensor, true);
        let projected = self.w_o.forward(&concat_var)?;

        let pd = projected.data();
        let ps = pd.as_slice();
        let out_tensor = Tensor::from_vec(ps.to_vec(), vec![batch, seq * dm]).expect("valid shape");

        let grad_fn = Box::new(move |g: &Tensor<T>| {
            let gs = g.as_slice();
            let gx = gs.to_vec();
            vec![
                Tensor::from_vec(gx, vec![batch, seq * dm]).expect("valid"),
                Tensor::zeros(vec![batch * seq, dm]),
                Tensor::zeros(vec![batch * seq, dm]),
                Tensor::zeros(vec![batch * seq, dm]),
                Tensor::from_vec(gs.to_vec(), vec![batch * seq, dm]).expect("valid"),
            ]
        });

        Ok(Variable::from_op(
            out_tensor,
            vec![x.clone(), q_flat, k_flat, v_flat, projected],
            grad_fn,
        ))
    }

    fn parameters(&self) -> Vec<Variable<T>> {
        let mut params = self.w_q.parameters();
        params.extend(self.w_k.parameters());
        params.extend(self.w_v.parameters());
        params.extend(self.w_o.parameters());
        params
    }

    fn train(&mut self) {}
    fn eval(&mut self) {}
}

#[cfg(test)]
mod tests {
    use super::*;
    use scivex_core::Tensor;

    #[test]
    fn test_mqa_output_shape() {
        let mut rng = Rng::new(42);
        let mqa = MultiQueryAttention::<f64>::new(8, 2, 4, &mut rng).unwrap();
        // batch=2, seq=4, d_model=8 -> input [2, 32]
        let x = Variable::new(Tensor::ones(vec![2, 32]), true);
        let y = mqa.forward(&x).unwrap();
        assert_eq!(y.shape(), vec![2, 32]);
    }

    #[test]
    fn test_mqa_fewer_kv_params() {
        use crate::layer::attention::MultiHeadAttention;

        let mut rng = Rng::new(42);
        let mha = MultiHeadAttention::<f64>::new(8, 2, 4, &mut rng);
        let mha_params: usize = mha
            .parameters()
            .iter()
            .map(|p| p.data().as_slice().len())
            .sum();

        let mut rng2 = Rng::new(42);
        let mqa = MultiQueryAttention::<f64>::new(8, 2, 4, &mut rng2).unwrap();
        let mqa_params: usize = mqa
            .parameters()
            .iter()
            .map(|p| p.data().as_slice().len())
            .sum();

        // MQA should have fewer total parameter elements because K, V project
        // to d_k instead of d_model.
        assert!(
            mqa_params < mha_params,
            "MQA params ({mqa_params}) should be fewer than MHA params ({mha_params})"
        );
    }

    #[test]
    fn test_gqa_output_shape() {
        let mut rng = Rng::new(42);
        let gqa = GroupedQueryAttention::<f64>::new(8, 4, 2, 4, &mut rng).unwrap();
        // batch=1, seq=4, d_model=8 -> input [1, 32]
        let x = Variable::new(Tensor::ones(vec![1, 32]), true);
        let y = gqa.forward(&x).unwrap();
        assert_eq!(y.shape(), vec![1, 32]);
    }

    #[test]
    fn test_gqa_num_heads_divisibility() {
        let mut rng = Rng::new(42);
        // num_heads=4, num_kv_heads=3 -> 4 % 3 != 0, should fail
        let result = GroupedQueryAttention::<f64>::new(8, 4, 3, 4, &mut rng);
        assert!(result.is_err());
    }

    #[test]
    fn test_flash_attention_output_shape() {
        let mut rng = Rng::new(42);
        let flash = FlashAttention::<f64>::new(8, 2, 4, 2, &mut rng).unwrap();
        // batch=2, seq=4, d_model=8 -> input [2, 32]
        let x = Variable::new(Tensor::ones(vec![2, 32]), true);
        let y = flash.forward(&x).unwrap();
        assert_eq!(y.shape(), vec![2, 32]);
    }
}