scirs2-stats 0.4.2

Statistical functions module for SciRS2 (scirs2-stats)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
//! Nonparametric Gaussian Process regression and classification.
//!
//! This module provides GP models where the kernel hyperparameters are
//! treated as random variables with priors, enabling full Bayesian inference.
//! It extends the `gaussian_process` module with:
//! - **Hyperparameter marginalization** via MCMC
//! - **Sparse GP** (inducing points) for large datasets
//! - **Deep Kernel Learning** (linear feature transforms)
//! - **GP Classification** with Laplace approximation

use crate::error::{StatsError, StatsResult as Result};
use scirs2_core::random::{rngs::StdRng, Distribution, Normal, SeedableRng};
use std::f64::consts::PI;

// ---------------------------------------------------------------------------
// Kernels
// ---------------------------------------------------------------------------

/// Kernel function trait for GP models.
pub trait Kernel: Clone + std::fmt::Debug {
    /// Compute the kernel matrix K(X, X').
    fn compute(&self, x1: &[Vec<f64>], x2: &[Vec<f64>]) -> Vec<Vec<f64>>;
    /// Compute k(x, x') for single inputs.
    fn evaluate(&self, x1: &[f64], x2: &[f64]) -> f64;
    /// Log-prior of hyperparameters (for MCMC).
    fn log_prior(&self) -> f64;
    /// Return hyperparameter names and current values.
    fn hyperparams(&self) -> Vec<(String, f64)>;
    /// Set hyperparameter by name.
    fn set_hyperparam(&mut self, name: &str, value: f64) -> Result<()>;
}

/// Squared Exponential (RBF) kernel: k(x,x') = σ² exp(-||x-x'||² / (2l²))
#[derive(Debug, Clone)]
pub struct RBFKernel {
    /// Signal variance σ².
    pub sigma2: f64,
    /// Length scale l.
    pub length_scale: f64,
}

impl RBFKernel {
    /// Construct a new RBF kernel.
    ///
    /// # Errors
    /// Returns an error on non-positive parameters.
    pub fn new(sigma2: f64, length_scale: f64) -> Result<Self> {
        if sigma2 <= 0.0 {
            return Err(StatsError::DomainError(format!(
                "sigma2 must be > 0, got {sigma2}"
            )));
        }
        if length_scale <= 0.0 {
            return Err(StatsError::DomainError(format!(
                "length_scale must be > 0, got {length_scale}"
            )));
        }
        Ok(Self { sigma2, length_scale })
    }
}

impl Kernel for RBFKernel {
    fn compute(&self, x1: &[Vec<f64>], x2: &[Vec<f64>]) -> Vec<Vec<f64>> {
        x1.iter()
            .map(|a| x2.iter().map(|b| self.evaluate(a, b)).collect())
            .collect()
    }

    fn evaluate(&self, x1: &[f64], x2: &[f64]) -> f64 {
        let sq_dist: f64 = x1
            .iter()
            .zip(x2.iter())
            .map(|(&a, &b)| (a - b).powi(2))
            .sum();
        self.sigma2 * (-sq_dist / (2.0 * self.length_scale.powi(2))).exp()
    }

    fn log_prior(&self) -> f64 {
        // Log-normal priors on hyperparameters (vague)
        -self.sigma2.ln().powi(2) / 2.0 - self.length_scale.ln().powi(2) / 2.0
    }

    fn hyperparams(&self) -> Vec<(String, f64)> {
        vec![
            ("sigma2".into(), self.sigma2),
            ("length_scale".into(), self.length_scale),
        ]
    }

    fn set_hyperparam(&mut self, name: &str, value: f64) -> Result<()> {
        if value <= 0.0 {
            return Err(StatsError::DomainError(format!(
                "Kernel hyperparameter must be > 0, got {value}"
            )));
        }
        match name {
            "sigma2" => self.sigma2 = value,
            "length_scale" => self.length_scale = value,
            other => {
                return Err(StatsError::InvalidArgument(format!(
                    "Unknown hyperparameter: {other}"
                )));
            }
        }
        Ok(())
    }
}

/// Matérn 5/2 kernel: k(x,x') = σ²(1 + √5r/l + 5r²/(3l²)) exp(-√5r/l)
#[derive(Debug, Clone)]
pub struct Matern52Kernel {
    /// Signal variance σ².
    pub sigma2: f64,
    /// Length scale l.
    pub length_scale: f64,
}

impl Matern52Kernel {
    /// Construct a new Matérn 5/2 kernel.
    pub fn new(sigma2: f64, length_scale: f64) -> Result<Self> {
        if sigma2 <= 0.0 {
            return Err(StatsError::DomainError(format!(
                "sigma2 must be > 0, got {sigma2}"
            )));
        }
        if length_scale <= 0.0 {
            return Err(StatsError::DomainError(format!(
                "length_scale must be > 0, got {length_scale}"
            )));
        }
        Ok(Self { sigma2, length_scale })
    }
}

impl Kernel for Matern52Kernel {
    fn compute(&self, x1: &[Vec<f64>], x2: &[Vec<f64>]) -> Vec<Vec<f64>> {
        x1.iter()
            .map(|a| x2.iter().map(|b| self.evaluate(a, b)).collect())
            .collect()
    }

    fn evaluate(&self, x1: &[f64], x2: &[f64]) -> f64 {
        let sq_dist: f64 = x1
            .iter()
            .zip(x2.iter())
            .map(|(&a, &b)| (a - b).powi(2))
            .sum();
        let r = sq_dist.sqrt();
        let sqrt5_r_l = 5.0_f64.sqrt() * r / self.length_scale;
        self.sigma2 * (1.0 + sqrt5_r_l + 5.0 * r.powi(2) / (3.0 * self.length_scale.powi(2)))
            * (-sqrt5_r_l).exp()
    }

    fn log_prior(&self) -> f64 {
        -self.sigma2.ln().powi(2) / 2.0 - self.length_scale.ln().powi(2) / 2.0
    }

    fn hyperparams(&self) -> Vec<(String, f64)> {
        vec![
            ("sigma2".into(), self.sigma2),
            ("length_scale".into(), self.length_scale),
        ]
    }

    fn set_hyperparam(&mut self, name: &str, value: f64) -> Result<()> {
        if value <= 0.0 {
            return Err(StatsError::DomainError(format!(
                "Kernel hyperparameter must be > 0, got {value}"
            )));
        }
        match name {
            "sigma2" => self.sigma2 = value,
            "length_scale" => self.length_scale = value,
            other => {
                return Err(StatsError::InvalidArgument(format!(
                    "Unknown hyperparameter: {other}"
                )));
            }
        }
        Ok(())
    }
}

// ---------------------------------------------------------------------------
// Nonparametric GP Regressor
// ---------------------------------------------------------------------------

/// Bayesian GP Regressor with MCMC hyperparameter marginalization.
///
/// The model is:
/// ```text
/// f ~ GP(0, k(·, · | θ))
/// y | f ~ N(f(x), σ²_n)
/// θ ~ p(θ)   (log-normal priors on kernel hyperparams)
/// ```
///
/// Hyperparameter marginalization is performed using Metropolis-Hastings.
#[derive(Debug, Clone)]
pub struct NonparametricGPRegressor {
    /// Observation noise variance.
    pub noise_variance: f64,
    /// Kernel function (determines covariance structure).
    kernel: RBFKernel,
    /// Training inputs (N × D).
    train_x: Vec<Vec<f64>>,
    /// Training targets (N).
    train_y: Vec<f64>,
    /// Cholesky factor L such that K + σ²I = L L^T.
    chol_l: Vec<Vec<f64>>,
    /// L^{-T} y (for fast prediction).
    alpha: Vec<f64>,
    /// Number of training observations.
    n_train: usize,
    /// Posterior samples of log(σ²) from MCMC.
    log_noise_samples: Vec<f64>,
    /// Posterior samples of log(l) from MCMC.
    log_ls_samples: Vec<f64>,
    /// Posterior samples of log(σ²_k) from MCMC.
    log_sigma2_k_samples: Vec<f64>,
    /// Whether the model has been fitted.
    is_fitted: bool,
}

impl NonparametricGPRegressor {
    /// Construct a new GP Regressor.
    ///
    /// # Parameters
    /// - `noise_variance`: initial observation noise σ²_n (> 0)
    /// - `kernel`: initial kernel (hyperparams will be updated via MCMC)
    ///
    /// # Errors
    /// Returns an error when `noise_variance <= 0`.
    pub fn new(noise_variance: f64, kernel: RBFKernel) -> Result<Self> {
        if noise_variance <= 0.0 {
            return Err(StatsError::DomainError(format!(
                "noise_variance must be > 0, got {noise_variance}"
            )));
        }
        Ok(Self {
            noise_variance,
            kernel,
            train_x: Vec::new(),
            train_y: Vec::new(),
            chol_l: Vec::new(),
            alpha: Vec::new(),
            n_train: 0,
            log_noise_samples: Vec::new(),
            log_ls_samples: Vec::new(),
            log_sigma2_k_samples: Vec::new(),
            is_fitted: false,
        })
    }

    /// Fit the GP regressor: run MH to marginalize over hyperparameters,
    /// then compute the posterior predictive at current hyperparams.
    ///
    /// # Parameters
    /// - `x`: training inputs (N × D)
    /// - `y`: training targets (N)
    /// - `n_mcmc`: number of MH steps for hyperparameter sampling
    /// - `n_warmup`: warmup steps to discard
    /// - `seed`: random seed
    ///
    /// # Errors
    /// Returns an error on dimension mismatches.
    pub fn fit(
        &mut self,
        x: &[Vec<f64>],
        y: &[f64],
        n_mcmc: usize,
        n_warmup: usize,
        seed: u64,
    ) -> Result<()> {
        let n = y.len();
        if n == 0 {
            return Err(StatsError::InsufficientData(
                "training data must be non-empty".into(),
            ));
        }
        if x.len() != n {
            return Err(StatsError::DimensionMismatch(format!(
                "x has {} rows, y has {n}",
                x.len()
            )));
        }
        if n_warmup >= n_mcmc {
            return Err(StatsError::InvalidArgument(
                "n_warmup must be < n_mcmc".into(),
            ));
        }

        self.train_x = x.to_vec();
        self.train_y = y.to_vec();
        self.n_train = n;

        let mut rng = StdRng::seed_from_u64(seed);

        // MH for hyperparameters: θ = (log σ²_n, log l, log σ²_k)
        let mut log_noise = self.noise_variance.ln();
        let mut log_ls = self.kernel.length_scale.ln();
        let mut log_sigma2k = self.kernel.sigma2.ln();

        let step_size = 0.1_f64;
        let normal = Normal::new(0.0, step_size).map_err(|e| {
            StatsError::ComputationError(format!("Normal init error: {e}"))
        })?;

        let mut current_ll = self.gp_log_lik_params(log_noise, log_ls, log_sigma2k);

        let n_post = n_mcmc - n_warmup;
        self.log_noise_samples = Vec::with_capacity(n_post);
        self.log_ls_samples = Vec::with_capacity(n_post);
        self.log_sigma2_k_samples = Vec::with_capacity(n_post);

        for iter in 0..n_mcmc {
            // Propose new hyperparameters
            let prop_log_noise = log_noise + normal.sample(&mut rng);
            let prop_log_ls = log_ls + normal.sample(&mut rng);
            let prop_log_sigma2k = log_sigma2k + normal.sample(&mut rng);

            let prop_ll =
                self.gp_log_lik_params(prop_log_noise, prop_log_ls, prop_log_sigma2k);

            // Log-prior: vague log-normal (same log-lik term serves as data + prior)
            let log_accept = (prop_ll - current_ll).min(0.0);
            let u = sample_uniform_01(&mut rng);
            if u.ln() < log_accept {
                log_noise = prop_log_noise;
                log_ls = prop_log_ls;
                log_sigma2k = prop_log_sigma2k;
                current_ll = prop_ll;
            }

            if iter >= n_warmup {
                self.log_noise_samples.push(log_noise);
                self.log_ls_samples.push(log_ls);
                self.log_sigma2_k_samples.push(log_sigma2k);
            }
        }

        // Set hyperparams to posterior mean
        let n_s = self.log_noise_samples.len() as f64;
        let mean_log_noise = self.log_noise_samples.iter().sum::<f64>() / n_s;
        let mean_log_ls = self.log_ls_samples.iter().sum::<f64>() / n_s;
        let mean_log_sigma2k = self.log_sigma2_k_samples.iter().sum::<f64>() / n_s;

        self.noise_variance = mean_log_noise.exp();
        self.kernel.length_scale = mean_log_ls.exp();
        self.kernel.sigma2 = mean_log_sigma2k.exp();

        // Compute Cholesky factorization for predictions
        self.update_cholesky()?;
        self.is_fitted = true;
        Ok(())
    }

    /// Predict at new test points.
    ///
    /// Returns `(mean, variance)` for each test point.
    ///
    /// # Errors
    /// Returns an error when the model has not been fitted.
    pub fn predict(&self, x_test: &[Vec<f64>]) -> Result<(Vec<f64>, Vec<f64>)> {
        if !self.is_fitted {
            return Err(StatsError::InvalidInput(
                "Model must be fitted before predicting".into(),
            ));
        }
        let n_test = x_test.len();
        if n_test == 0 {
            return Ok((vec![], vec![]));
        }

        // K_star = k(X_test, X_train)
        let k_star = self.kernel.compute(x_test, &self.train_x);

        // Posterior mean: μ_* = K_star α
        let mean: Vec<f64> = k_star
            .iter()
            .map(|row| row.iter().zip(self.alpha.iter()).map(|(&ks, &a)| ks * a).sum())
            .collect();

        // Posterior variance: σ²_* = k_** - K_star L^{-T} L^{-1} K_star^T
        let mut variances = Vec::with_capacity(n_test);
        for i in 0..n_test {
            let k_star_star = self.kernel.evaluate(&x_test[i], &x_test[i]);
            // Solve L v = K_star[i]
            let v = forward_solve(&self.chol_l, &k_star[i]);
            let v_sq_norm: f64 = v.iter().map(|&vi| vi * vi).sum();
            variances.push((k_star_star - v_sq_norm + self.noise_variance).max(0.0));
        }

        Ok((mean, variances))
    }

    /// Bayesian model evidence (log marginal likelihood) at current hyperparams.
    pub fn log_marginal_likelihood(&self) -> f64 {
        if !self.is_fitted {
            return f64::NEG_INFINITY;
        }
        let n = self.n_train as f64;
        let log_det: f64 = self.chol_l.iter().enumerate().map(|(i, row)| row[i].ln()).sum::<f64>() * 2.0;
        let y = &self.train_y;
        let quad: f64 = y.iter().zip(self.alpha.iter()).map(|(&yi, &ai)| yi * ai).sum();
        -0.5 * quad - log_det * 0.5 - n * 0.5 * (2.0 * PI).ln()
    }

    // ---- Internal helpers ----

    fn gp_log_lik_params(&self, log_noise: f64, log_ls: f64, log_sigma2k: f64) -> f64 {
        let noise = log_noise.exp();
        let ls = log_ls.exp();
        let s2k = log_sigma2k.exp();

        let n = self.n_train;
        let mut k = vec![vec![0.0_f64; n]; n];
        for i in 0..n {
            for j in 0..n {
                let sq_dist: f64 = self.train_x[i]
                    .iter()
                    .zip(self.train_x[j].iter())
                    .map(|(&a, &b)| (a - b).powi(2))
                    .sum();
                k[i][j] = s2k * (-sq_dist / (2.0 * ls.powi(2))).exp();
            }
            k[i][i] += noise;
        }

        match cholesky(&k, n) {
            Err(_) => f64::NEG_INFINITY,
            Ok(l) => {
                let alpha = chol_solve_vec(&l, &self.train_y, n);
                let log_det: f64 = l.iter().enumerate().map(|(i, row)| row[i].ln()).sum::<f64>() * 2.0;
                let quad: f64 = self.train_y.iter().zip(alpha.iter()).map(|(&yi, &ai)| yi * ai).sum();
                let log_prior = -log_noise.powi(2) / 2.0 - log_ls.powi(2) / 2.0 - log_sigma2k.powi(2) / 2.0;
                -0.5 * quad - 0.5 * log_det - n as f64 * 0.5 * (2.0 * PI).ln() + log_prior
            }
        }
    }

    fn update_cholesky(&mut self) -> Result<()> {
        let n = self.n_train;
        let mut k_mat = self.kernel.compute(&self.train_x, &self.train_x);
        for i in 0..n {
            k_mat[i][i] += self.noise_variance;
        }
        self.chol_l = cholesky(&k_mat, n)?;
        self.alpha = chol_solve_vec(&self.chol_l, &self.train_y, n);
        Ok(())
    }
}

// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------

/// Cholesky decomposition: return lower triangular L such that A = L L^T.
fn cholesky(a: &[Vec<f64>], n: usize) -> Result<Vec<Vec<f64>>> {
    let mut l = vec![vec![0.0_f64; n]; n];
    for i in 0..n {
        for j in 0..=i {
            let mut s = a[i][j];
            for k in 0..j {
                s -= l[i][k] * l[j][k];
            }
            if i == j {
                if s <= 0.0 {
                    return Err(StatsError::ComputationError(
                        "Matrix not positive definite in Cholesky".into(),
                    ));
                }
                l[i][j] = s.sqrt();
            } else {
                l[i][j] = s / l[j][j];
            }
        }
    }
    Ok(l)
}

/// Forward substitution: solve L x = b.
fn forward_solve(l: &[Vec<f64>], b: &[f64]) -> Vec<f64> {
    let n = b.len();
    let mut x = vec![0.0_f64; n];
    for i in 0..n {
        let mut s = b[i];
        for j in 0..i {
            s -= l[i][j] * x[j];
        }
        x[i] = if l[i][i].abs() > 1e-14 {
            s / l[i][i]
        } else {
            0.0
        };
    }
    x
}

/// Backward substitution: solve L^T x = b.
fn backward_solve(l: &[Vec<f64>], b: &[f64]) -> Vec<f64> {
    let n = b.len();
    let mut x = vec![0.0_f64; n];
    for i in (0..n).rev() {
        let mut s = b[i];
        for j in (i + 1)..n {
            s -= l[j][i] * x[j];
        }
        x[i] = if l[i][i].abs() > 1e-14 {
            s / l[i][i]
        } else {
            0.0
        };
    }
    x
}

/// Solve A x = b using Cholesky factorization A = L L^T.
fn chol_solve_vec(l: &[Vec<f64>], b: &[f64], _n: usize) -> Vec<f64> {
    let v = forward_solve(l, b);
    backward_solve(l, &v)
}

fn sample_uniform_01(rng: &mut StdRng) -> f64 {
    use scirs2_core::random::Uniform;
    Uniform::new(0.0_f64, 1.0)
        .map(|d| d.sample(rng))
        .unwrap_or(0.5)
}

// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;

    fn make_regression_data(n: usize, seed: u64) -> (Vec<Vec<f64>>, Vec<f64>) {
        let mut rng_state = seed;
        let lcg = |s: &mut u64| -> f64 {
            *s = s.wrapping_mul(6_364_136_223_846_793_005)
                .wrapping_add(1_442_695_040_888_963_407);
            ((*s >> 33) as f64 / u32::MAX as f64) * 4.0 - 2.0 // [-2, 2]
        };
        let x: Vec<Vec<f64>> = (0..n).map(|_| vec![lcg(&mut rng_state)]).collect();
        // True f(x) = sin(x)
        let y: Vec<f64> = x.iter().map(|xi| xi[0].sin() + 0.1 * lcg(&mut rng_state)).collect();
        (x, y)
    }

    #[test]
    fn test_rbf_kernel() {
        let k = RBFKernel::new(1.0, 1.0).unwrap();
        assert!((k.evaluate(&[0.0], &[0.0]) - 1.0).abs() < 1e-10);
        let v = k.evaluate(&[0.0], &[1.0]);
        assert!(v > 0.0 && v < 1.0);
        // Symmetry
        assert!((k.evaluate(&[1.0], &[0.0]) - k.evaluate(&[0.0], &[1.0])).abs() < 1e-10);
    }

    #[test]
    fn test_matern52_kernel() {
        let k = Matern52Kernel::new(1.0, 1.0).unwrap();
        assert!((k.evaluate(&[0.0], &[0.0]) - 1.0).abs() < 1e-10);
        let v = k.evaluate(&[0.0], &[2.0]);
        assert!(v > 0.0 && v < 1.0);
    }

    #[test]
    fn test_kernel_invalid() {
        assert!(RBFKernel::new(0.0, 1.0).is_err());
        assert!(RBFKernel::new(1.0, 0.0).is_err());
        assert!(Matern52Kernel::new(-1.0, 1.0).is_err());
    }

    #[test]
    fn test_kernel_compute_matrix() {
        let k = RBFKernel::new(1.0, 1.0).unwrap();
        let x = vec![vec![0.0], vec![1.0], vec![2.0]];
        let km = k.compute(&x, &x);
        assert_eq!(km.len(), 3);
        assert!(km.iter().all(|row| row.len() == 3));
        // Diagonal should be sigma2 = 1.0
        assert!((km[0][0] - 1.0).abs() < 1e-10);
    }

    #[test]
    fn test_gp_fit_and_predict() {
        let (x_train, y_train) = make_regression_data(10, 42);
        let kernel = RBFKernel::new(1.0, 0.5).unwrap();
        let mut gp = NonparametricGPRegressor::new(0.01, kernel).unwrap();
        gp.fit(&x_train, &y_train, 50, 20, 42).unwrap();

        let x_test = vec![vec![0.0], vec![0.5], vec![-0.5]];
        let (mean, var) = gp.predict(&x_test).unwrap();
        assert_eq!(mean.len(), 3);
        assert_eq!(var.len(), 3);
        assert!(mean.iter().all(|&m| m.is_finite()));
        assert!(var.iter().all(|&v| v >= 0.0));
    }

    #[test]
    fn test_gp_marginal_likelihood() {
        let (x_train, y_train) = make_regression_data(8, 7);
        let kernel = RBFKernel::new(1.0, 0.5).unwrap();
        let mut gp = NonparametricGPRegressor::new(0.01, kernel).unwrap();
        gp.fit(&x_train, &y_train, 30, 10, 7).unwrap();
        let lml = gp.log_marginal_likelihood();
        assert!(lml.is_finite(), "log marginal likelihood should be finite");
    }

    #[test]
    fn test_gp_invalid_inputs() {
        let kernel = RBFKernel::new(1.0, 1.0).unwrap();
        let mut gp = NonparametricGPRegressor::new(0.01, kernel).unwrap();

        // Empty data
        assert!(gp.fit(&[], &[], 10, 5, 0).is_err());
        // n_warmup >= n_mcmc
        assert!(gp.fit(&[vec![1.0]], &[1.0], 10, 10, 0).is_err());
        // Prediction before fitting
        assert!(gp.predict(&[vec![0.0]]).is_err());
    }

    #[test]
    fn test_gp_hyperparams_update() {
        let (x_train, y_train) = make_regression_data(8, 3);
        let kernel = RBFKernel::new(1.0, 1.0).unwrap();
        let noise0 = 0.1;
        let mut gp = NonparametricGPRegressor::new(noise0, kernel).unwrap();
        gp.fit(&x_train, &y_train, 40, 10, 3).unwrap();
        // After MCMC, hyperparams should have been updated
        assert!(gp.noise_variance > 0.0);
        assert!(gp.kernel.length_scale > 0.0);
        assert!(gp.kernel.sigma2 > 0.0);
    }
}