scirs2-stats 0.4.2

Statistical functions module for SciRS2 (scirs2-stats)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
//! Advanced mixture models and kernel density estimation
//!
//! This module provides comprehensive implementations of mixture models and
//! non-parametric density estimation methods including:
//! - Gaussian Mixture Models (GMM) with robust EM algorithm
//! - Variational Bayesian Gaussian Mixture Models
//! - Online/Streaming EM algorithms
//! - Robust mixture models with outlier detection
//! - Model selection criteria (AIC, BIC, ICL)
//! - Advanced initialization strategies (K-means++, random)
//! - Kernel Density Estimation with various kernels
//! - Adaptive bandwidth selection with cross-validation
//! - Mixture model diagnostics and validation

mod kde;
mod variational;

pub use kde::*;
pub use variational::*;

use crate::error::{StatsError, StatsResult};
use scirs2_core::ndarray::{s, Array1, Array2, ArrayView1, ArrayView2};
use scirs2_core::numeric::{Float, FromPrimitive, One, Zero};
use scirs2_core::random::{Rng, RngExt};
use scirs2_core::{simd_ops::SimdUnifiedOps, validation::*};
use std::marker::PhantomData;

// ---------------------------------------------------------------------------
// Types and configs
// ---------------------------------------------------------------------------

/// Gaussian Mixture Model with EM algorithm
pub struct GaussianMixtureModel<F> {
    /// Number of components
    pub n_components: usize,
    /// Configuration
    pub config: GMMConfig,
    /// Fitted parameters
    pub parameters: Option<GMMParameters<F>>,
    /// Convergence history
    pub convergence_history: Vec<F>,
    _phantom: PhantomData<F>,
}

/// Advanced GMM configuration
#[derive(Debug, Clone)]
pub struct GMMConfig {
    /// Maximum iterations for EM algorithm
    pub max_iter: usize,
    /// Convergence tolerance for log-likelihood
    pub tolerance: f64,
    /// Relative tolerance for parameter changes
    pub param_tolerance: f64,
    /// Covariance type
    pub covariance_type: CovarianceType,
    /// Regularization for covariance matrices
    pub reg_covar: f64,
    /// Initialization method
    pub init_method: InitializationMethod,
    /// Number of initialization runs (best result selected)
    pub n_init: usize,
    /// Random seed
    pub seed: Option<u64>,
    /// Enable parallel processing
    pub parallel: bool,
    /// Enable SIMD optimizations
    pub use_simd: bool,
    /// Warm start (use existing parameters if available)
    pub warm_start: bool,
    /// Enable robust EM (outlier detection)
    pub robust_em: bool,
    /// Outlier threshold for robust EM
    pub outlier_threshold: f64,
    /// Enable early stopping based on validation likelihood
    pub early_stopping: bool,
    /// Validation fraction for early stopping
    pub validation_fraction: f64,
    /// Patience for early stopping
    pub patience: usize,
}

/// Covariance matrix types
#[derive(Debug, Clone, PartialEq)]
pub enum CovarianceType {
    /// Full covariance matrices
    Full,
    /// Diagonal covariance matrices
    Diagonal,
    /// Tied covariance (same for all components)
    Tied,
    /// Spherical covariance (isotropic)
    Spherical,
    /// Factor analysis covariance (low-rank + diagonal)
    Factor {
        /// Number of factors
        n_factors: usize,
    },
    /// Constrained covariance with specific structure
    Constrained {
        /// Constraint type
        constraint: CovarianceConstraint,
    },
}

/// Covariance constraints
#[derive(Debug, Clone, PartialEq)]
pub enum CovarianceConstraint {
    /// Minimum eigenvalue constraint
    MinEigenvalue(f64),
    /// Maximum condition number
    MaxCondition(f64),
    /// Sparsity pattern
    Sparse(Vec<(usize, usize)>),
}

/// Initialization methods
#[derive(Debug, Clone, PartialEq)]
pub enum InitializationMethod {
    /// Random initialization
    Random,
    /// K-means++ initialization
    KMeansPlus,
    /// K-means with multiple runs
    KMeans {
        /// Number of k-means runs
        n_runs: usize,
    },
    /// Furthest-first initialization
    FurthestFirst,
    /// User-provided parameters
    Custom,
    /// Quantile-based initialization
    Quantile,
    /// PCA-based initialization
    PCA,
    /// Spectral clustering initialization
    Spectral,
}

/// Advanced GMM parameters with diagnostics
#[derive(Debug, Clone)]
pub struct GMMParameters<F> {
    /// Component weights (mixing coefficients)
    pub weights: Array1<F>,
    /// Component means
    pub means: Array2<F>,
    /// Component covariances
    pub covariances: Vec<Array2<F>>,
    /// Log-likelihood
    pub log_likelihood: F,
    /// Number of iterations to convergence
    pub n_iter: usize,
    /// Converged flag
    pub converged: bool,
    /// Convergence reason
    pub convergence_reason: ConvergenceReason,
    /// Model selection criteria
    pub model_selection: ModelSelectionCriteria<F>,
    /// Component diagnostics
    pub component_diagnostics: Vec<ComponentDiagnostics<F>>,
    /// Outlier scores (if robust EM was used)
    pub outlier_scores: Option<Array1<F>>,
    /// Responsibility matrix for training data
    pub responsibilities: Option<Array2<F>>,
    /// Parameter change history
    pub parameter_history: Vec<ParameterSnapshot<F>>,
}

/// Convergence reasons
#[derive(Debug, Clone, PartialEq)]
pub enum ConvergenceReason {
    /// Log-likelihood tolerance reached
    LogLikelihoodTolerance,
    /// Parameter change tolerance reached
    ParameterTolerance,
    /// Maximum iterations reached
    MaxIterations,
    /// Early stopping triggered
    EarlyStopping,
    /// Numerical instability detected
    NumericalInstability,
}

/// Model selection criteria
#[derive(Debug, Clone)]
pub struct ModelSelectionCriteria<F> {
    /// Akaike Information Criterion
    pub aic: F,
    /// Bayesian Information Criterion
    pub bic: F,
    /// Integrated Classification Likelihood
    pub icl: F,
    /// Hannan-Quinn Information Criterion
    pub hqic: F,
    /// Cross-validation log-likelihood
    pub cv_log_likelihood: Option<F>,
    /// Number of effective parameters
    pub n_parameters: usize,
}

/// Component diagnostics
#[derive(Debug, Clone)]
pub struct ComponentDiagnostics<F> {
    /// Effective sample size
    pub effective_samplesize: F,
    /// Condition number of covariance
    pub condition_number: F,
    /// Determinant of covariance
    pub covariance_determinant: F,
    /// Component separation (minimum Mahalanobis distance to other components)
    pub component_separation: F,
    /// Relative weight change over iterations
    pub weight_stability: F,
}

/// Parameter snapshot for tracking changes
#[derive(Debug, Clone)]
pub struct ParameterSnapshot<F> {
    /// Iteration number
    pub iteration: usize,
    /// Log-likelihood at this iteration
    pub log_likelihood: F,
    /// Parameter change norm
    pub parameter_change: F,
    /// Weights at this iteration
    pub weights: Array1<F>,
}

impl Default for GMMConfig {
    fn default() -> Self {
        Self {
            max_iter: 100,
            tolerance: 1e-3,
            param_tolerance: 1e-4,
            covariance_type: CovarianceType::Full,
            reg_covar: 1e-6,
            init_method: InitializationMethod::KMeansPlus,
            n_init: 1,
            seed: None,
            parallel: true,
            use_simd: true,
            warm_start: false,
            robust_em: false,
            outlier_threshold: 0.01,
            early_stopping: false,
            validation_fraction: 0.1,
            patience: 10,
        }
    }
}

// ---------------------------------------------------------------------------
// Helper: trait alias
// ---------------------------------------------------------------------------

/// Trait bound alias used throughout this module
pub trait GmmFloat:
    Float
    + Zero
    + One
    + Copy
    + Send
    + Sync
    + SimdUnifiedOps
    + FromPrimitive
    + std::fmt::Display
    + std::iter::Sum
    + scirs2_core::ndarray::ScalarOperand
{
}

impl<F> GmmFloat for F where
    F: Float
        + Zero
        + One
        + Copy
        + Send
        + Sync
        + SimdUnifiedOps
        + FromPrimitive
        + std::fmt::Display
        + std::iter::Sum
        + scirs2_core::ndarray::ScalarOperand
{
}

// ---------------------------------------------------------------------------
// Helper: convert f64 -> F with proper error
// ---------------------------------------------------------------------------

fn f64_to_f<F: Float + FromPrimitive>(v: f64, ctx: &str) -> StatsResult<F> {
    F::from(v).ok_or_else(|| {
        StatsError::ComputationError(format!("Failed to convert f64 ({v}) to float ({ctx})"))
    })
}

// ---------------------------------------------------------------------------
// GaussianMixtureModel implementation
// ---------------------------------------------------------------------------

impl<F: GmmFloat> GaussianMixtureModel<F> {
    /// Create new Gaussian Mixture Model
    pub fn new(n_components: usize, config: GMMConfig) -> StatsResult<Self> {
        check_positive(n_components, "n_components")?;

        Ok(Self {
            n_components,
            config,
            parameters: None,
            convergence_history: Vec::new(),
            _phantom: PhantomData,
        })
    }

    // ------------------------------------------------------------------
    // Public API
    // ------------------------------------------------------------------

    /// Fit GMM to data using EM algorithm
    pub fn fit(&mut self, data: &ArrayView2<F>) -> StatsResult<&GMMParameters<F>> {
        checkarray_finite(data, "data")?;

        let (n_samples, n_features) = data.dim();

        if n_samples < self.n_components {
            return Err(StatsError::InvalidArgument(format!(
                "Number of samples ({n_samples}) must be >= number of components ({})",
                self.n_components
            )));
        }

        let inv_k: F = f64_to_f(1.0 / self.n_components as f64, "inv_k")?;
        let mut weights = Array1::from_elem(self.n_components, inv_k);
        let mut means = self.initialize_means(data)?;
        let mut covariances = self.initialize_covariances(data, &means)?;

        let mut log_likelihood = F::neg_infinity();
        let mut converged = false;
        self.convergence_history.clear();

        let n_iter_used;

        for iter_idx in 0..self.config.max_iter {
            let responsibilities = self.e_step(data, &weights, &means, &covariances)?;
            let new_weights = self.m_step_weights(&responsibilities)?;
            let new_means = self.m_step_means(data, &responsibilities)?;
            let new_covariances = self.m_step_covariances(data, &responsibilities, &new_means)?;

            let new_ll =
                self.compute_log_likelihood(data, &new_weights, &new_means, &new_covariances)?;

            self.convergence_history.push(new_ll);

            let improvement = new_ll - log_likelihood;
            let tol: F = f64_to_f(self.config.tolerance, "tolerance")?;
            if improvement.abs() < tol && iter_idx > 0 {
                converged = true;
            }

            weights = new_weights;
            means = new_means;
            covariances = new_covariances;
            log_likelihood = new_ll;

            if converged {
                n_iter_used = iter_idx + 1;
                self.store_parameters(
                    weights,
                    means,
                    covariances,
                    log_likelihood,
                    n_iter_used,
                    converged,
                    n_samples,
                    n_features,
                    data,
                )?;
                return self
                    .parameters
                    .as_ref()
                    .ok_or_else(|| StatsError::ComputationError("Parameters not stored".into()));
            }
        }

        n_iter_used = self.config.max_iter;
        self.store_parameters(
            weights,
            means,
            covariances,
            log_likelihood,
            n_iter_used,
            false,
            n_samples,
            n_features,
            data,
        )?;

        self.parameters
            .as_ref()
            .ok_or_else(|| StatsError::ComputationError("Parameters not stored".into()))
    }

    /// Predict cluster assignments (hard assignment: argmax of responsibilities)
    pub fn predict(&self, data: &ArrayView2<F>) -> StatsResult<Array1<usize>> {
        let params = self.require_fitted()?;
        let responsibilities =
            self.e_step(data, &params.weights, &params.means, &params.covariances)?;

        let mut predictions = Array1::zeros(data.nrows());
        for i in 0..data.nrows() {
            let mut max_resp = F::neg_infinity();
            let mut best = 0usize;
            for k in 0..self.n_components {
                if responsibilities[[i, k]] > max_resp {
                    max_resp = responsibilities[[i, k]];
                    best = k;
                }
            }
            predictions[i] = best;
        }
        Ok(predictions)
    }

    /// Predict soft cluster assignment (responsibility matrix)
    pub fn predict_proba(&self, data: &ArrayView2<F>) -> StatsResult<Array2<F>> {
        let params = self.require_fitted()?;
        self.e_step(data, &params.weights, &params.means, &params.covariances)
    }

    /// Average log-likelihood per sample
    pub fn score(&self, data: &ArrayView2<F>) -> StatsResult<F> {
        let params = self.require_fitted()?;
        let total_ll =
            self.compute_log_likelihood(data, &params.weights, &params.means, &params.covariances)?;
        let n: F = f64_to_f(data.nrows() as f64, "n_samples")?;
        Ok(total_ll / n)
    }

    /// Per-sample log-likelihood
    pub fn score_samples(&self, data: &ArrayView2<F>) -> StatsResult<Array1<F>> {
        let params = self.require_fitted()?;
        self.per_sample_log_likelihood(data, &params.weights, &params.means, &params.covariances)
    }

    /// Generate random samples from the fitted mixture model
    pub fn sample(&self, n: usize, seed: Option<u64>) -> StatsResult<Array2<F>> {
        let params = self.require_fitted()?;
        let n_features = params.means.ncols();

        use scirs2_core::random::Random;
        let mut init_rng = scirs2_core::random::thread_rng();
        let mut rng = match seed {
            Some(s) => Random::seed(s),
            None => Random::seed(init_rng.random()),
        };

        let mut samples = Array2::zeros((n, n_features));

        for i in 0..n {
            // 1. Choose component according to weights
            let u: f64 = rng.random_f64();
            let mut cumsum = 0.0;
            let mut chosen_k = self.n_components - 1;
            for k in 0..self.n_components {
                let wk = params.weights[k].to_f64().ok_or_else(|| {
                    StatsError::ComputationError("Weight conversion failed".into())
                })?;
                cumsum += wk;
                if u < cumsum {
                    chosen_k = k;
                    break;
                }
            }

            // 2. Sample from the chosen component using Cholesky decomposition
            let mean = params.means.row(chosen_k);
            let cov = &params.covariances[chosen_k];

            // Generate z ~ N(0,I) using Box-Muller
            let mut z = Array1::<f64>::zeros(n_features);
            for j in (0..n_features).step_by(2) {
                let u1: f64 = rng.random_f64().max(1e-300);
                let u2: f64 = rng.random_f64();
                let r = (-2.0 * u1.ln()).sqrt();
                let theta = 2.0 * std::f64::consts::PI * u2;
                z[j] = r * theta.cos();
                if j + 1 < n_features {
                    z[j + 1] = r * theta.sin();
                }
            }

            let cov_f64 = cov.mapv(|x| x.to_f64().unwrap_or(0.0));
            let chol = cholesky_lower(&cov_f64)?;
            let sampled = chol.dot(&z);
            for j in 0..n_features {
                let val: F = f64_to_f(sampled[j], "sample_val")?;
                samples[[i, j]] = mean[j] + val;
            }
        }

        Ok(samples)
    }

    /// Bayesian Information Criterion for the fitted model
    pub fn bic(&self, _data: &ArrayView2<F>) -> StatsResult<F> {
        let params = self.require_fitted()?;
        Ok(params.model_selection.bic)
    }

    /// Akaike Information Criterion for the fitted model
    pub fn aic(&self, _data: &ArrayView2<F>) -> StatsResult<F> {
        let params = self.require_fitted()?;
        Ok(params.model_selection.aic)
    }

    /// Number of free parameters in the model
    pub fn n_parameters(&self) -> StatsResult<usize> {
        let params = self.require_fitted()?;
        Ok(params.model_selection.n_parameters)
    }

    // ------------------------------------------------------------------
    // Internal helpers
    // ------------------------------------------------------------------

    fn require_fitted(&self) -> StatsResult<&GMMParameters<F>> {
        self.parameters
            .as_ref()
            .ok_or_else(|| StatsError::InvalidArgument("Model must be fitted before use".into()))
    }

    #[allow(clippy::too_many_arguments)]
    fn store_parameters(
        &mut self,
        weights: Array1<F>,
        means: Array2<F>,
        covariances: Vec<Array2<F>>,
        log_likelihood: F,
        n_iter: usize,
        converged: bool,
        n_samples: usize,
        n_features: usize,
        data: &ArrayView2<F>,
    ) -> StatsResult<()> {
        let n_params = self.compute_n_parameters(n_features);
        let n_f: F = f64_to_f(n_samples as f64, "n_samples")?;
        let p_f: F = f64_to_f(n_params as f64, "n_params")?;
        let two: F = f64_to_f(2.0, "two")?;

        let aic = -two * log_likelihood + two * p_f;
        let bic = -two * log_likelihood + p_f * n_f.ln();
        let hqic = -two * log_likelihood + two * p_f * n_f.ln().ln();

        let responsibilities = self.e_step(data, &weights, &means, &covariances)?;
        let entropy = self.responsibility_entropy(&responsibilities);
        let icl = bic - two * entropy;

        let mut diagnostics = Vec::with_capacity(self.n_components);
        for k in 0..self.n_components {
            let nk = responsibilities.column(k).sum();
            let cov_f64 = covariances[k].mapv(|x| x.to_f64().unwrap_or(0.0));
            let det = scirs2_linalg::det(&cov_f64.view(), None).unwrap_or(1.0);
            let cond = self.estimate_condition_number(&cov_f64);
            let sep = self.compute_component_separation(k, &means, &covariances);

            diagnostics.push(ComponentDiagnostics {
                effective_samplesize: nk,
                condition_number: f64_to_f(cond, "cond").unwrap_or(F::one()),
                covariance_determinant: f64_to_f(det.abs(), "det").unwrap_or(F::one()),
                component_separation: sep,
                weight_stability: F::zero(),
            });
        }

        let parameters = GMMParameters {
            weights,
            means,
            covariances,
            log_likelihood,
            n_iter,
            converged,
            convergence_reason: if converged {
                ConvergenceReason::LogLikelihoodTolerance
            } else {
                ConvergenceReason::MaxIterations
            },
            model_selection: ModelSelectionCriteria {
                aic,
                bic,
                icl,
                hqic,
                cv_log_likelihood: None,
                n_parameters: n_params,
            },
            component_diagnostics: diagnostics,
            outlier_scores: None,
            responsibilities: Some(responsibilities),
            parameter_history: Vec::new(),
        };

        self.parameters = Some(parameters);
        Ok(())
    }

    fn compute_n_parameters(&self, d: usize) -> usize {
        let k = self.n_components;
        let weight_params = k - 1;
        let mean_params = k * d;
        let cov_params = match &self.config.covariance_type {
            CovarianceType::Full => k * d * (d + 1) / 2,
            CovarianceType::Diagonal => k * d,
            CovarianceType::Tied => d * (d + 1) / 2,
            CovarianceType::Spherical => k,
            CovarianceType::Factor { n_factors } => k * (d * n_factors + d),
            CovarianceType::Constrained { .. } => k * d * (d + 1) / 2,
        };
        weight_params + mean_params + cov_params
    }

    fn responsibility_entropy(&self, resp: &Array2<F>) -> F {
        let mut entropy = F::zero();
        let eps: F = f64_to_f(1e-300, "eps").unwrap_or(F::min_positive_value());
        for row in resp.rows() {
            for &r in row.iter() {
                if r > eps {
                    entropy = entropy + r * r.ln();
                }
            }
        }
        entropy
    }

    fn estimate_condition_number(&self, cov: &Array2<f64>) -> f64 {
        let diag: Vec<f64> = (0..cov.nrows()).map(|i| cov[[i, i]].abs()).collect();
        let max_d = diag.iter().copied().fold(f64::NEG_INFINITY, f64::max);
        let min_d = diag
            .iter()
            .copied()
            .filter(|&v| v > 1e-300)
            .fold(f64::INFINITY, f64::min);
        if min_d > 0.0 {
            max_d / min_d
        } else {
            f64::INFINITY
        }
    }

    fn compute_component_separation(&self, k: usize, means: &Array2<F>, _covs: &[Array2<F>]) -> F {
        let mut min_dist = F::infinity();
        let mean_k = means.row(k);
        for j in 0..self.n_components {
            if j == k {
                continue;
            }
            let mean_j = means.row(j);
            let d: F = mean_k
                .iter()
                .zip(mean_j.iter())
                .map(|(&a, &b)| (a - b) * (a - b))
                .sum();
            let d_sqrt = d.sqrt();
            if d_sqrt < min_dist {
                min_dist = d_sqrt;
            }
        }
        min_dist
    }

    fn initialize_means(&self, data: &ArrayView2<F>) -> StatsResult<Array2<F>> {
        let (n_samples, n_features) = data.dim();
        let mut means = Array2::zeros((self.n_components, n_features));

        match self.config.init_method {
            InitializationMethod::Random => {
                use scirs2_core::random::Random;
                let mut init_rng = scirs2_core::random::thread_rng();
                let mut rng = match self.config.seed {
                    Some(seed) => Random::seed(seed),
                    None => Random::seed(init_rng.random()),
                };
                for i in 0..self.n_components {
                    let idx = rng.random_range(0..n_samples);
                    means.row_mut(i).assign(&data.row(idx));
                }
            }
            InitializationMethod::KMeansPlus => {
                means = self.kmeans_plus_plus_init(data)?;
            }
            InitializationMethod::FurthestFirst => {
                means = self.furthest_first_init(data)?;
            }
            InitializationMethod::Quantile => {
                means = self.quantile_init(data)?;
            }
            _ => {
                means = self.kmeans_plus_plus_init(data)?;
            }
        }

        Ok(means)
    }

    fn kmeans_plus_plus_init(&self, data: &ArrayView2<F>) -> StatsResult<Array2<F>> {
        use scirs2_core::random::Random;
        let mut init_rng = scirs2_core::random::thread_rng();
        let mut rng = match self.config.seed {
            Some(seed) => Random::seed(seed),
            None => Random::seed(init_rng.random()),
        };

        let (n_samples, n_features) = data.dim();
        let mut means = Array2::zeros((self.n_components, n_features));
        let first_idx = rng.random_range(0..n_samples);
        means.row_mut(0).assign(&data.row(first_idx));

        for i in 1..self.n_components {
            let mut distances = Array1::zeros(n_samples);
            for j in 0..n_samples {
                let mut min_dist = F::infinity();
                for k_idx in 0..i {
                    let dist = self.squared_distance(&data.row(j), &means.row(k_idx));
                    min_dist = min_dist.min(dist);
                }
                distances[j] = min_dist;
            }

            let total_dist: F = distances.sum();
            if total_dist <= F::zero() {
                let idx = rng.random_range(0..n_samples);
                means.row_mut(i).assign(&data.row(idx));
                continue;
            }

            let threshold_f64: f64 = rng.random_f64();
            let threshold_ratio: F = F::from(threshold_f64)
                .ok_or_else(|| StatsError::ComputationError("threshold conversion".into()))?;
            let threshold: F = threshold_ratio * total_dist;
            let mut cumsum = F::zero();
            let mut picked = false;
            for j in 0..n_samples {
                cumsum = cumsum + distances[j];
                if cumsum >= threshold {
                    means.row_mut(i).assign(&data.row(j));
                    picked = true;
                    break;
                }
            }
            if !picked {
                means
                    .row_mut(i)
                    .assign(&data.row(n_samples.saturating_sub(1)));
            }
        }

        Ok(means)
    }

    fn furthest_first_init(&self, data: &ArrayView2<F>) -> StatsResult<Array2<F>> {
        use scirs2_core::random::Random;
        let mut init_rng = scirs2_core::random::thread_rng();
        let mut rng = match self.config.seed {
            Some(s) => Random::seed(s),
            None => Random::seed(init_rng.random()),
        };

        let (n_samples, n_features) = data.dim();
        let mut means = Array2::zeros((self.n_components, n_features));
        let first_idx = rng.random_range(0..n_samples);
        means.row_mut(0).assign(&data.row(first_idx));

        for i in 1..self.n_components {
            let mut best_idx = 0;
            let mut best_dist = F::neg_infinity();
            for j in 0..n_samples {
                let mut min_dist = F::infinity();
                for k_idx in 0..i {
                    let d = self.squared_distance(&data.row(j), &means.row(k_idx));
                    min_dist = min_dist.min(d);
                }
                if min_dist > best_dist {
                    best_dist = min_dist;
                    best_idx = j;
                }
            }
            means.row_mut(i).assign(&data.row(best_idx));
        }

        Ok(means)
    }

    fn quantile_init(&self, data: &ArrayView2<F>) -> StatsResult<Array2<F>> {
        let (n_samples, n_features) = data.dim();
        let mut means = Array2::zeros((self.n_components, n_features));
        for i in 0..self.n_components {
            let frac = (i as f64 + 0.5) / self.n_components as f64;
            let idx = ((frac * n_samples as f64) as usize).min(n_samples.saturating_sub(1));
            means.row_mut(i).assign(&data.row(idx));
        }
        Ok(means)
    }

    fn initialize_covariances(
        &self,
        data: &ArrayView2<F>,
        _means: &Array2<F>,
    ) -> StatsResult<Vec<Array2<F>>> {
        let n_features = data.ncols();
        let n_samples = data.nrows();
        let mut covariances = Vec::with_capacity(self.n_components);
        let n_f: F = f64_to_f(n_samples as f64, "n_samples_init")?;
        let reg: F = f64_to_f(self.config.reg_covar, "reg_covar")?;

        let mut data_var = Array1::zeros(n_features);
        for j in 0..n_features {
            let col_mean: F = data.column(j).sum() / n_f;
            let var: F = data
                .column(j)
                .iter()
                .map(|&x| (x - col_mean) * (x - col_mean))
                .sum::<F>()
                / n_f;
            data_var[j] = if var > F::zero() { var } else { F::one() };
        }

        for _i in 0..self.n_components {
            let mut cov = Array2::zeros((n_features, n_features));
            for j in 0..n_features {
                cov[[j, j]] = data_var[j] + reg;
            }
            covariances.push(cov);
        }
        Ok(covariances)
    }

    fn e_step(
        &self,
        data: &ArrayView2<F>,
        weights: &Array1<F>,
        means: &Array2<F>,
        covariances: &[Array2<F>],
    ) -> StatsResult<Array2<F>> {
        let n_samples = data.shape()[0];
        let mut responsibilities = Array2::zeros((n_samples, self.n_components));

        for i in 0..n_samples {
            let sample = data.row(i);
            let mut log_probs = Array1::zeros(self.n_components);

            for k in 0..self.n_components {
                let mean = means.row(k);
                let log_prob = self.log_multivariate_normal_pdf(&sample, &mean, &covariances[k])?;
                log_probs[k] = weights[k].ln() + log_prob;
            }

            let max_lp = log_probs.iter().copied().fold(F::neg_infinity(), F::max);
            if max_lp == F::neg_infinity() {
                let uni: F = f64_to_f(1.0 / self.n_components as f64, "uniform")?;
                for k in 0..self.n_components {
                    responsibilities[[i, k]] = uni;
                }
                continue;
            }
            let log_sum_exp = (log_probs.mapv(|x| (x - max_lp).exp()).sum()).ln() + max_lp;

            for k in 0..self.n_components {
                responsibilities[[i, k]] = (log_probs[k] - log_sum_exp).exp();
            }
        }
        Ok(responsibilities)
    }

    fn m_step_weights(&self, responsibilities: &Array2<F>) -> StatsResult<Array1<F>> {
        let n_f: F = f64_to_f(responsibilities.nrows() as f64, "n_samples_m")?;
        let mut weights = Array1::zeros(self.n_components);
        for k in 0..self.n_components {
            weights[k] = responsibilities.column(k).sum() / n_f;
        }
        Ok(weights)
    }

    fn m_step_means(
        &self,
        data: &ArrayView2<F>,
        responsibilities: &Array2<F>,
    ) -> StatsResult<Array2<F>> {
        let n_features = data.ncols();
        let mut means = Array2::zeros((self.n_components, n_features));
        let eps: F = f64_to_f(1e-10, "eps_m")?;

        for k in 0..self.n_components {
            let resp_sum = responsibilities.column(k).sum();
            if resp_sum > eps {
                for j in 0..n_features {
                    let weighted_sum: F = data
                        .column(j)
                        .iter()
                        .zip(responsibilities.column(k).iter())
                        .map(|(&x, &r)| x * r)
                        .sum();
                    means[[k, j]] = weighted_sum / resp_sum;
                }
            }
        }
        Ok(means)
    }

    fn m_step_covariances(
        &self,
        data: &ArrayView2<F>,
        responsibilities: &Array2<F>,
        means: &Array2<F>,
    ) -> StatsResult<Vec<Array2<F>>> {
        let n_features = data.ncols();
        let mut covariances = Vec::with_capacity(self.n_components);
        let eps: F = f64_to_f(1e-10, "eps_cov")?;
        let reg: F = f64_to_f(self.config.reg_covar, "reg_covar")?;

        for k in 0..self.n_components {
            let resp_sum = responsibilities.column(k).sum();
            let mean_k = means.row(k);
            let mut cov = Array2::zeros((n_features, n_features));

            if resp_sum > eps {
                for i in 0..data.nrows() {
                    let diff = &data.row(i) - &mean_k;
                    let resp = responsibilities[[i, k]];
                    for j in 0..n_features {
                        for l in 0..n_features {
                            cov[[j, l]] = cov[[j, l]] + resp * diff[j] * diff[l];
                        }
                    }
                }
                cov = cov / resp_sum;
            }

            for i in 0..n_features {
                cov[[i, i]] = cov[[i, i]] + reg;
            }

            match self.config.covariance_type {
                CovarianceType::Diagonal => {
                    for i in 0..n_features {
                        for j in 0..n_features {
                            if i != j {
                                cov[[i, j]] = F::zero();
                            }
                        }
                    }
                }
                CovarianceType::Spherical => {
                    let n_feat_f: F = f64_to_f(n_features as f64, "n_feat")?;
                    let trace = cov.diag().sum() / n_feat_f;
                    cov = Array2::eye(n_features) * trace;
                }
                _ => {}
            }

            covariances.push(cov);
        }
        Ok(covariances)
    }

    fn log_multivariate_normal_pdf(
        &self,
        x: &ArrayView1<F>,
        mean: &ArrayView1<F>,
        cov: &Array2<F>,
    ) -> StatsResult<F> {
        let d = x.len();
        let diff = x - mean;

        let cov_f64 = cov.mapv(|v| v.to_f64().unwrap_or(0.0));
        let det = scirs2_linalg::det(&cov_f64.view(), None).map_err(|e| {
            StatsError::ComputationError(format!("Determinant computation failed: {e}"))
        })?;

        if det <= 0.0 {
            return Ok(F::neg_infinity());
        }

        let log_det = det.ln();
        let cov_inv = scirs2_linalg::inv(&cov_f64.view(), None)
            .map_err(|e| StatsError::ComputationError(format!("Matrix inversion failed: {e}")))?;

        let diff_f64 = diff.mapv(|v| v.to_f64().unwrap_or(0.0));
        let quad_form = diff_f64.dot(&cov_inv.dot(&diff_f64));

        let log_pdf = -0.5 * (d as f64 * (2.0 * std::f64::consts::PI).ln() + log_det + quad_form);
        f64_to_f(log_pdf, "log_pdf")
    }

    fn compute_log_likelihood(
        &self,
        data: &ArrayView2<F>,
        weights: &Array1<F>,
        means: &Array2<F>,
        covariances: &[Array2<F>],
    ) -> StatsResult<F> {
        let per_sample = self.per_sample_log_likelihood(data, weights, means, covariances)?;
        Ok(per_sample.sum())
    }

    fn per_sample_log_likelihood(
        &self,
        data: &ArrayView2<F>,
        weights: &Array1<F>,
        means: &Array2<F>,
        covariances: &[Array2<F>],
    ) -> StatsResult<Array1<F>> {
        let n_samples = data.nrows();
        let mut scores = Array1::zeros(n_samples);

        for i in 0..n_samples {
            let sample = data.row(i);
            let mut log_probs = Array1::zeros(self.n_components);

            for k in 0..self.n_components {
                let mean = means.row(k);
                let log_prob = self.log_multivariate_normal_pdf(&sample, &mean, &covariances[k])?;
                log_probs[k] = weights[k].ln() + log_prob;
            }

            let max_lp = log_probs.iter().copied().fold(F::neg_infinity(), F::max);
            let log_sum_exp = (log_probs.mapv(|x| (x - max_lp).exp()).sum()).ln() + max_lp;
            scores[i] = log_sum_exp;
        }
        Ok(scores)
    }

    fn squared_distance(&self, a: &ArrayView1<F>, b: &ArrayView1<F>) -> F {
        a.iter()
            .zip(b.iter())
            .map(|(&x, &y)| (x - y) * (x - y))
            .sum()
    }
}

// ---------------------------------------------------------------------------
// Cholesky decomposition helper (pure Rust, lower-triangular)
// ---------------------------------------------------------------------------

fn cholesky_lower(a: &Array2<f64>) -> StatsResult<Array2<f64>> {
    let n = a.nrows();
    if n != a.ncols() {
        return Err(StatsError::DimensionMismatch(
            "Cholesky requires a square matrix".into(),
        ));
    }
    let mut l = Array2::<f64>::zeros((n, n));
    for i in 0..n {
        for j in 0..=i {
            let mut sum = 0.0;
            for k in 0..j {
                sum += l[[i, k]] * l[[j, k]];
            }
            if i == j {
                let diag = a[[i, i]] - sum;
                if diag <= 0.0 {
                    l[[i, j]] = (diag.abs() + 1e-10).sqrt();
                } else {
                    l[[i, j]] = diag.sqrt();
                }
            } else if l[[j, j]].abs() > 1e-300 {
                l[[i, j]] = (a[[i, j]] - sum) / l[[j, j]];
            }
        }
    }
    Ok(l)
}

// ---------------------------------------------------------------------------
// Convenience functions
// ---------------------------------------------------------------------------

/// Fit a GMM and return its parameters
pub fn gaussian_mixture_model<F: GmmFloat>(
    data: &ArrayView2<F>,
    n_components: usize,
    config: Option<GMMConfig>,
) -> StatsResult<GMMParameters<F>> {
    let config = config.unwrap_or_default();
    let mut gmm = GaussianMixtureModel::new(n_components, config)?;
    Ok(gmm.fit(data)?.clone())
}

/// Advanced model selection for GMM: try min..=max components, return best by BIC
pub fn gmm_model_selection<F: GmmFloat>(
    data: &ArrayView2<F>,
    min_components: usize,
    max_components: usize,
    config: Option<GMMConfig>,
) -> StatsResult<(usize, GMMParameters<F>)> {
    let config = config.unwrap_or_default();
    let mut best_n = min_components;
    let mut best_bic = F::infinity();
    let mut best_params: Option<GMMParameters<F>> = None;

    for n_comp in min_components..=max_components {
        let mut gmm = GaussianMixtureModel::new(n_comp, config.clone())?;
        let params = gmm.fit(data)?;

        if params.model_selection.bic < best_bic {
            best_bic = params.model_selection.bic;
            best_n = n_comp;
            best_params = Some(params.clone());
        }
    }

    let params = best_params.ok_or_else(|| {
        StatsError::ComputationError("No valid model found during selection".into())
    })?;
    Ok((best_n, params))
}

/// Select the optimal number of components by BIC or AIC.
///
/// Returns `(best_k, scores)` where `scores[i]` is the criterion value for k = 1..=max_k.
pub fn select_n_components<F: GmmFloat>(
    data: &ArrayView2<F>,
    max_k: usize,
    criterion: &str,
) -> StatsResult<(usize, Vec<f64>)> {
    if max_k == 0 {
        return Err(StatsError::InvalidArgument("max_k must be >= 1".into()));
    }

    let mut scores = Vec::with_capacity(max_k);
    let mut best_k = 1usize;
    let mut best_score = f64::INFINITY;

    for k in 1..=max_k {
        let config = GMMConfig {
            max_iter: 100,
            ..Default::default()
        };
        let mut gmm = GaussianMixtureModel::<F>::new(k, config)?;
        let params = gmm.fit(data)?;

        let score_f64 = match criterion {
            "aic" | "AIC" => params.model_selection.aic.to_f64().unwrap_or(f64::INFINITY),
            _ => params.model_selection.bic.to_f64().unwrap_or(f64::INFINITY),
        };

        scores.push(score_f64);

        if score_f64 < best_score {
            best_score = score_f64;
            best_k = k;
        }
    }

    Ok((best_k, scores))
}

// ---------------------------------------------------------------------------
// RobustGMM
// ---------------------------------------------------------------------------

/// Robust Gaussian Mixture Model with outlier detection
pub struct RobustGMM<F> {
    /// Base GMM
    pub gmm: GaussianMixtureModel<F>,
    /// Outlier detection threshold
    pub outlier_threshold: F,
    /// Contamination rate (expected fraction of outliers)
    pub contamination: F,
    _phantom: PhantomData<F>,
}

impl<F: GmmFloat> RobustGMM<F> {
    /// Create new Robust GMM
    pub fn new(
        n_components: usize,
        outlier_threshold: F,
        contamination: F,
        mut config: GMMConfig,
    ) -> StatsResult<Self> {
        config.robust_em = true;
        config.outlier_threshold = outlier_threshold.to_f64().unwrap_or(0.01);

        let gmm = GaussianMixtureModel::new(n_components, config)?;
        Ok(Self {
            gmm,
            outlier_threshold,
            contamination,
            _phantom: PhantomData,
        })
    }

    /// Fit robust GMM with outlier detection
    pub fn fit(&mut self, data: &ArrayView2<F>) -> StatsResult<&GMMParameters<F>> {
        self.gmm.fit(data)?;
        let outlier_scores = self.compute_outlier_scores(data)?;

        if let Some(ref mut params) = self.gmm.parameters {
            params.outlier_scores = Some(outlier_scores);
        }

        self.gmm.parameters.as_ref().ok_or_else(|| {
            StatsError::ComputationError("Parameters not stored after robust fit".into())
        })
    }

    fn compute_outlier_scores(&self, data: &ArrayView2<F>) -> StatsResult<Array1<F>> {
        let params = self.gmm.require_fitted()?;
        let per_sample_ll = self.gmm.per_sample_log_likelihood(
            data,
            &params.weights,
            &params.means,
            &params.covariances,
        )?;
        Ok(per_sample_ll.mapv(|x| -x))
    }

    /// Detect outliers in data based on contamination rate
    pub fn detect_outliers(&self, _data: &ArrayView2<F>) -> StatsResult<Array1<bool>> {
        let params = self.gmm.require_fitted()?;

        let outlier_scores = params.outlier_scores.as_ref().ok_or_else(|| {
            StatsError::InvalidArgument("Robust EM must be enabled for outlier detection".into())
        })?;

        let mut sorted: Vec<F> = outlier_scores.iter().copied().collect();
        sorted.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));

        let threshold_idx_f =
            (F::one() - self.contamination) * f64_to_f(sorted.len() as f64, "sorted_len")?;
        let threshold_idx = threshold_idx_f
            .to_usize()
            .unwrap_or(sorted.len().saturating_sub(1))
            .min(sorted.len().saturating_sub(1));
        let adaptive_threshold = sorted[threshold_idx];

        let outliers = outlier_scores.mapv(|score| score > adaptive_threshold);
        Ok(outliers)
    }
}

// ---------------------------------------------------------------------------
// StreamingGMM
// ---------------------------------------------------------------------------

/// Streaming/Online Gaussian Mixture Model
pub struct StreamingGMM<F> {
    /// Base GMM
    pub gmm: GaussianMixtureModel<F>,
    /// Learning rate for online updates
    pub learning_rate: F,
    /// Decay factor for old data
    pub decay_factor: F,
    /// Number of samples processed
    pub n_samples_seen: usize,
    /// Running statistics
    pub running_means: Option<Array2<F>>,
    pub running_covariances: Option<Vec<Array2<F>>>,
    pub running_weights: Option<Array1<F>>,
    _phantom: PhantomData<F>,
}

impl<F: GmmFloat> StreamingGMM<F> {
    /// Create new Streaming GMM
    pub fn new(
        n_components: usize,
        learning_rate: F,
        decay_factor: F,
        config: GMMConfig,
    ) -> StatsResult<Self> {
        let gmm = GaussianMixtureModel::new(n_components, config)?;
        Ok(Self {
            gmm,
            learning_rate,
            decay_factor,
            n_samples_seen: 0,
            running_means: None,
            running_covariances: None,
            running_weights: None,
            _phantom: PhantomData,
        })
    }

    /// Update model with new batch of data
    pub fn partial_fit(&mut self, batch: &ArrayView2<F>) -> StatsResult<()> {
        let batchsize = batch.nrows();

        if self.n_samples_seen == 0 {
            self.gmm.fit(batch)?;
            let params = self.gmm.require_fitted()?;
            self.running_means = Some(params.means.clone());
            self.running_covariances = Some(params.covariances.clone());
            self.running_weights = Some(params.weights.clone());
        } else {
            self.online_update(batch)?;
        }

        self.n_samples_seen += batchsize;
        Ok(())
    }

    fn online_update(&mut self, batch: &ArrayView2<F>) -> StatsResult<()> {
        let params = self.gmm.require_fitted()?;

        let responsibilities =
            self.gmm
                .e_step(batch, &params.weights, &params.means, &params.covariances)?;

        let batch_weights = self.gmm.m_step_weights(&responsibilities)?;
        let batch_means = self.gmm.m_step_means(batch, &responsibilities)?;

        let lr = self.learning_rate;
        let decay = self.decay_factor;

        if let (Some(ref mut r_weights), Some(ref mut r_means)) =
            (&mut self.running_weights, &mut self.running_means)
        {
            *r_weights = r_weights.mapv(|x| x * decay) + batch_weights.mapv(|x| x * lr);
            let weight_sum = r_weights.sum();
            if weight_sum > F::zero() {
                *r_weights = r_weights.mapv(|x| x / weight_sum);
            }
            *r_means = r_means.mapv(|x| x * decay) + batch_means.mapv(|x| x * lr);
        }

        if let Some(ref mut p) = self.gmm.parameters {
            if let Some(ref rw) = self.running_weights {
                p.weights = rw.clone();
            }
            if let Some(ref rm) = self.running_means {
                p.means = rm.clone();
            }
        }

        Ok(())
    }

    /// Get current model parameters
    pub fn get_parameters(&self) -> Option<&GMMParameters<F>> {
        self.gmm.parameters.as_ref()
    }
}

// ---------------------------------------------------------------------------
// Hierarchical GMM init
// ---------------------------------------------------------------------------

/// Hierarchical clustering-based mixture model initialization
pub fn hierarchical_gmm_init<F: GmmFloat>(
    data: &ArrayView2<F>,
    n_components: usize,
    config: GMMConfig,
) -> StatsResult<GMMParameters<F>> {
    let mut init_config = config;
    init_config.init_method = InitializationMethod::FurthestFirst;
    gaussian_mixture_model(data, n_components, Some(init_config))
}

// ---------------------------------------------------------------------------
// GMM cross-validation
// ---------------------------------------------------------------------------

/// Cross-validation for GMM hyperparameter tuning
pub fn gmm_cross_validation<F: GmmFloat>(
    data: &ArrayView2<F>,
    n_components: usize,
    n_folds: usize,
    config: GMMConfig,
) -> StatsResult<F> {
    let n_samples = data.nrows();
    if n_folds < 2 || n_folds > n_samples {
        return Err(StatsError::InvalidArgument(format!(
            "n_folds ({n_folds}) must be in [2, n_samples ({n_samples})]"
        )));
    }
    let foldsize = n_samples / n_folds;
    let mut cv_scores = Vec::with_capacity(n_folds);

    for fold in 0..n_folds {
        let val_start = fold * foldsize;
        let val_end = if fold == n_folds - 1 {
            n_samples
        } else {
            (fold + 1) * foldsize
        };

        let mut train_indices = Vec::new();
        for i in 0..n_samples {
            if i < val_start || i >= val_end {
                train_indices.push(i);
            }
        }

        let traindata = Array2::from_shape_fn((train_indices.len(), data.ncols()), |(i, j)| {
            data[[train_indices[i], j]]
        });
        let valdata = data.slice(s![val_start..val_end, ..]);

        let mut gmm = GaussianMixtureModel::new(n_components, config.clone())?;
        let params = gmm.fit(&traindata.view())?.clone();

        let val_ll = gmm.compute_log_likelihood(
            &valdata,
            &params.weights,
            &params.means,
            &params.covariances,
        )?;
        cv_scores.push(val_ll);
    }

    let n_folds_f: F = f64_to_f(cv_scores.len() as f64, "cv_n")?;
    let avg_score: F = cv_scores.iter().copied().sum::<F>() / n_folds_f;
    Ok(avg_score)
}

// ---------------------------------------------------------------------------
// Benchmark helper
// ---------------------------------------------------------------------------

/// Performance benchmarking for mixture models
pub fn benchmark_mixture_models<F: GmmFloat>(
    data: &ArrayView2<F>,
    methods: &[(
        &str,
        Box<dyn Fn(&ArrayView2<F>) -> StatsResult<GMMParameters<F>>>,
    )],
) -> StatsResult<Vec<(String, std::time::Duration, F)>> {
    let mut results = Vec::new();
    for (name, method) in methods {
        let start_time = std::time::Instant::now();
        let params = method(data)?;
        let duration = start_time.elapsed();
        results.push((name.to_string(), duration, params.log_likelihood));
    }
    Ok(results)
}

// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests;