scirs2-stats 0.4.2

Statistical functions module for SciRS2 (scirs2-stats)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
//! Wishart distribution functions
//!
//! This module provides functionality for the Wishart distribution.

use crate::error::{StatsError, StatsResult};
use crate::sampling::SampleableDistribution;
use scirs2_core::ndarray::{Array1, Array2, ArrayBase, Data, Ix2};
use scirs2_core::random::prelude::*;
use scirs2_core::random::{ChiSquared, Distribution, Normal as RandNormal};
use std::fmt::Debug;

// Import helper functions from the multivariate module
use super::normal::{compute_cholesky, compute_inverse_from_cholesky};

/// Implementation of the natural logarithm of the gamma function
/// This is a workaround for the unstable gamma function in Rust
#[allow(dead_code)]
fn lgamma(x: f64) -> f64 {
    if x <= 0.0 {
        panic!("lgamma requires positive input");
    }

    // For integers, we can use a simpler calculation
    if x.fract() == 0.0 && x <= 20.0 {
        let n = x as usize;
        if n == 1 || n == 2 {
            return 0.0; // ln(1) = 0
        }

        let mut result = 0.0;
        for i in 2..n {
            result += (i as f64).ln();
        }
        return result;
    }

    // For x = 0.5, we have Γ(0.5) = sqrt(π)
    if (x - 0.5).abs() < 1e-10 {
        return (std::f64::consts::PI.sqrt()).ln();
    }

    // For x > 1, use the recurrence relation: Γ(x+1) = x * Γ(x)
    if x > 1.0 {
        return (x - 1.0).ln() + lgamma(x - 1.0);
    }

    // For 0 < x < 1, use the reflection formula: Γ(x) * Γ(1-x) = π/sin(πx)
    if x < 1.0 {
        return (std::f64::consts::PI / (std::f64::consts::PI * x).sin()).ln() - lgamma(1.0 - x);
    }

    // Lanczos approximation for other values around 1
    let p = [
        676.5203681218851,
        -1259.1392167224028,
        771.323_428_777_653_1,
        -176.615_029_162_140_6,
        12.507343278686905,
        -0.13857109526572012,
        9.984_369_578_019_572e-6,
        1.5056327351493116e-7,
    ];

    let x_adj = x - 1.0;
    let t = x_adj + 7.5;

    let mut sum = 0.0;
    for (i, &coef) in p.iter().enumerate() {
        sum += coef / (x_adj + (i + 1) as f64);
    }

    let pi = std::f64::consts::PI;
    let sqrt_2pi = (2.0 * pi).sqrt();

    sqrt_2pi.ln() + sum.ln() + (x_adj + 0.5) * t.ln() - t
}

/// Calculates the multivariate gamma function (natural log)
///
/// This is defined as:
/// ln Γₚ(n/2) = ln (π^(p(p-1)/4) ∏ᵢ₌₁ᵖ Γ((n+1-i)/2))
///
/// where p is the dimension and n is the degrees of freedom
#[allow(dead_code)]
pub fn lmultigamma(n: f64, p: usize) -> f64 {
    // Calculate ln(π^(p(p-1)/4))
    let pi = std::f64::consts::PI;
    let term1 = (p * (p - 1)) as f64 / 4.0 * pi.ln();

    // Calculate ln(∏ᵢ₌₁ᵖ Γ((n+1-i)/2))
    let mut term2 = 0.0;
    for i in 1..=p {
        let arg = (n + 1.0 - i as f64) / 2.0;
        term2 += lgamma(arg);
    }

    term1 + term2
}

/// Wishart distribution structure
#[derive(Debug, Clone)]
pub struct Wishart {
    /// Scale matrix
    pub scale: Array2<f64>,
    /// Degrees of freedom
    pub df: f64,
    /// Dimension of the distribution (p x p)
    pub dim: usize,
    /// Cholesky decomposition of the scale matrix
    scale_chol: Array2<f64>,
    /// Determinant of the scale matrix
    scale_det: f64,
}

impl Wishart {
    /// Create a new Wishart distribution with given parameters
    ///
    /// # Arguments
    ///
    /// * `scale` - Scale matrix (p x p, symmetric positive-definite)
    /// * `df` - Degrees of freedom (must be greater than or equal to the dimension)
    ///
    /// # Returns
    ///
    /// * A new Wishart distribution instance
    ///
    /// # Examples
    ///
    /// ```
    /// use scirs2_core::ndarray::array;
    /// use scirs2_stats::distributions::multivariate::wishart::Wishart;
    ///
    /// // Create a 2D Wishart distribution with 5 degrees of freedom
    /// let scale = array![[1.0, 0.5], [0.5, 2.0]];
    /// let df = 5.0;
    /// let wishart = Wishart::new(scale, df).expect("Operation failed");
    /// ```
    pub fn new<D>(scale: ArrayBase<D, Ix2>, df: f64) -> StatsResult<Self>
    where
        D: Data<Elem = f64>,
    {
        let scale_owned = scale.to_owned();
        let dim = scale_owned.shape()[0];

        // Check if the matrix is square
        if scale_owned.shape()[1] != dim {
            return Err(StatsError::DimensionMismatch(
                "Scale matrix must be square".to_string(),
            ));
        }

        // Check the degrees of freedom constraint: df >= dim
        if df < dim as f64 {
            return Err(StatsError::DomainError(format!(
                "Degrees of freedom ({}) must be greater than or equal to dimension ({})",
                df, dim
            )));
        }

        // Compute Cholesky decomposition to check if the matrix is positive definite
        let scale_chol = compute_cholesky(&scale_owned).map_err(|_| {
            StatsError::DomainError("Scale matrix must be positive definite".to_string())
        })?;

        // Compute determinant of the _scale matrix
        let scale_det = {
            let mut det = 1.0;
            for i in 0..dim {
                det *= scale_chol[[i, i]];
            }
            det * det // Square it since det(Σ) = det(L)^2
        };

        Ok(Wishart {
            scale: scale_owned,
            df,
            dim,
            scale_chol,
            scale_det,
        })
    }

    /// Calculate the probability density function (PDF) at a given matrix point
    ///
    /// # Arguments
    ///
    /// * `x` - The matrix at which to evaluate the PDF (p x p)
    ///
    /// # Returns
    ///
    /// * The value of the PDF at the given point
    ///
    /// # Examples
    ///
    /// ```
    /// use scirs2_core::ndarray::array;
    /// use scirs2_stats::distributions::multivariate::wishart::Wishart;
    ///
    /// let scale = array![[1.0, 0.0], [0.0, 1.0]];
    /// let df = 5.0;
    /// let wishart = Wishart::new(scale, df).expect("Operation failed");
    ///
    /// let x = array![[5.0, 1.0], [1.0, 5.0]];
    /// let pdf_value = wishart.pdf(&x);
    /// ```
    pub fn pdf<D>(&self, x: &ArrayBase<D, Ix2>) -> f64
    where
        D: Data<Elem = f64>,
    {
        // Check if x has the right dimensions
        if x.shape()[0] != self.dim || x.shape()[1] != self.dim {
            return 0.0;
        }

        // Check if x is symmetric and positive definite
        let x_owned = x.to_owned();
        let x_chol = match compute_cholesky(&x_owned) {
            Ok(chol) => chol,
            Err(_) => return 0.0, // Not positive definite, PDF is 0
        };

        // Compute the log PDF and exponentiate
        self.logpdf_with_cholesky(x, &x_chol).exp()
    }

    /// Calculate the log PDF with precomputed Cholesky decomposition of x
    fn logpdf_with_cholesky<D>(&self, x: &ArrayBase<D, Ix2>, xchol: &Array2<f64>) -> f64
    where
        D: Data<Elem = f64>,
    {
        // Calculate determinant of x
        let mut x_det = 1.0;
        for i in 0..self.dim {
            x_det *= xchol[[i, i]];
        }
        x_det = x_det * x_det; // Square it since det(X) = det(L)^2

        // Calculate trace(Σ^-1 X)
        let scale_inv = compute_inverse_from_cholesky(&self.scale_chol)
            .expect("Failed to compute matrix inverse");

        let mut trace = 0.0;
        for i in 0..self.dim {
            for j in 0..self.dim {
                trace += scale_inv[[i, j]] * x[[j, i]];
            }
        }

        // Calculate log PDF
        // ln(PDF) = -0.5 * [tr(Σ^-1 X) + n ln|Σ| + p ln 2 + 2 ln Γₚ(n/2)] + 0.5 * (n - p - 1) ln|X|
        let p = self.dim as f64;
        let n = self.df;

        let term1 = -0.5 * trace;
        let term2 = -0.5 * n * self.scale_det.ln();
        let term3 = -0.5 * p * (2.0f64).ln();
        let term4 = -lmultigamma(n, self.dim);
        let term5 = 0.5 * (n - p - 1.0) * x_det.ln();

        term1 + term2 + term3 + term4 + term5
    }

    /// Calculate the log probability density function (log PDF) at a given matrix point
    ///
    /// # Arguments
    ///
    /// * `x` - The matrix at which to evaluate the log PDF (p x p)
    ///
    /// # Returns
    ///
    /// * The value of the log PDF at the given point
    ///
    /// # Examples
    ///
    /// ```
    /// use scirs2_core::ndarray::array;
    /// use scirs2_stats::distributions::multivariate::wishart::Wishart;
    ///
    /// let scale = array![[1.0, 0.0], [0.0, 1.0]];
    /// let df = 5.0;
    /// let wishart = Wishart::new(scale, df).expect("Operation failed");
    ///
    /// let x = array![[5.0, 1.0], [1.0, 5.0]];
    /// let logpdf_value = wishart.logpdf(&x);
    /// ```
    pub fn logpdf<D>(&self, x: &ArrayBase<D, Ix2>) -> f64
    where
        D: Data<Elem = f64>,
    {
        // Check if x has the right dimensions
        if x.shape()[0] != self.dim || x.shape()[1] != self.dim {
            return f64::NEG_INFINITY;
        }

        // Check if x is symmetric and positive definite
        let x_owned = x.to_owned();
        let x_chol = match compute_cholesky(&x_owned) {
            Ok(chol) => chol,
            Err(_) => return f64::NEG_INFINITY, // Not positive definite, log PDF is -∞
        };

        // Compute the log PDF
        self.logpdf_with_cholesky(x, &x_chol)
    }

    /// Generate random samples from the distribution
    ///
    /// # Arguments
    ///
    /// * `size` - Number of samples to generate
    ///
    /// # Returns
    ///
    /// * Vector of random matrix samples
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use scirs2_core::ndarray::array;
    /// use scirs2_stats::distributions::multivariate::wishart::Wishart;
    ///
    /// let scale = array![[1.0, 0.5], [0.5, 2.0]];
    /// let df = 5.0;
    /// let wishart = Wishart::new(scale, df).expect("Operation failed");
    ///
    /// let samples = wishart.rvs(10).expect("Operation failed");
    /// assert_eq!(samples.len(), 10);
    /// assert_eq!(samples[0].shape(), &[2, 2]);
    /// ```
    pub fn rvs(&self, size: usize) -> StatsResult<Vec<Array2<f64>>> {
        let mut rng = thread_rng();
        let normal_dist = RandNormal::new(0.0, 1.0).expect("Operation failed");
        let mut samples = Vec::with_capacity(size);

        for _ in 0..size {
            // For integer degrees of freedom, we use the sum of outer products method
            if self.df.fract() == 0.0 {
                let n = self.df as usize;
                let mut x = Array2::<f64>::zeros((self.dim, self.dim));

                // Generate n independent vectors
                for _ in 0..n {
                    // Generate standard normal vector
                    let mut z = Array1::<f64>::zeros(self.dim);
                    for j in 0..self.dim {
                        z[j] = normal_dist.sample(&mut rng);
                    }

                    // Transform using Cholesky decomposition
                    let az = self.scale_chol.dot(&z);

                    // Add outer product to X
                    for i in 0..self.dim {
                        for j in 0..self.dim {
                            x[[i, j]] += az[i] * az[j];
                        }
                    }
                }

                samples.push(x);
            } else {
                // For non-integer df, we use Bartlett's decomposition
                // Generate lower triangular matrix A
                let mut a = Array2::<f64>::zeros((self.dim, self.dim));

                // Diagonal elements from chi-square distributions
                for i in 0..self.dim {
                    let df_i = self.df - (i as f64);
                    let chi2_dist = ChiSquared::new(df_i).map_err(|_| {
                        StatsError::ComputationError(
                            "Failed to create chi-square distribution".to_string(),
                        )
                    })?;

                    // sqrt because we need to sample from sqrt(χ²) here
                    a[[i, i]] = chi2_dist.sample(&mut rng).sqrt();
                }

                // Off-diagonal elements from standard normal distribution
                for i in 0..self.dim {
                    for j in 0..i {
                        a[[i, j]] = normal_dist.sample(&mut rng);
                    }
                }

                // Compute B = L·A where L is the Cholesky decomposition of scale matrix
                let b = self.scale_chol.dot(&a);

                // Compute X = B·B'
                let mut x = Array2::<f64>::zeros((self.dim, self.dim));
                for i in 0..self.dim {
                    for j in 0..=i {
                        // Only compute lower triangular part
                        let mut sum = 0.0;
                        for k in 0..self.dim {
                            sum += b[[i, k]] * b[[j, k]];
                        }
                        x[[i, j]] = sum;
                        if i != j {
                            x[[j, i]] = sum; // Symmetric
                        }
                    }
                }

                samples.push(x);
            }
        }

        Ok(samples)
    }

    /// Generate a single random sample from the distribution
    ///
    /// # Returns
    ///
    /// * A random matrix sample
    ///
    /// # Examples
    ///
    /// ```ignore
    /// use scirs2_core::ndarray::array;
    /// use scirs2_stats::distributions::multivariate::wishart::Wishart;
    ///
    /// let scale = array![[1.0, 0.5], [0.5, 2.0]];
    /// let df = 5.0;
    /// let wishart = Wishart::new(scale, df).expect("Operation failed");
    ///
    /// let sample = wishart.rvs_single().expect("Operation failed");
    /// assert_eq!(sample.shape(), &[2, 2]);
    /// ```
    pub fn rvs_single(&self) -> StatsResult<Array2<f64>> {
        let samples = self.rvs(1)?;
        Ok(samples[0].clone())
    }

    /// Mean of the Wishart distribution
    ///
    /// # Returns
    ///
    /// * Mean matrix (ν × Σ)
    ///
    /// # Examples
    ///
    /// ```
    /// use scirs2_core::ndarray::array;
    /// use scirs2_stats::distributions::multivariate::wishart::Wishart;
    ///
    /// let scale = array![[1.0, 0.5], [0.5, 2.0]];
    /// let df = 5.0;
    /// let wishart = Wishart::new(scale, df).expect("Operation failed");
    ///
    /// let mean = wishart.mean();
    /// ```
    pub fn mean(&self) -> Array2<f64> {
        // E[X] = ν × Σ
        let mut mean = self.scale.clone();
        mean *= self.df;
        mean
    }

    /// Mode of the Wishart distribution (only defined for ν ≥ p + 1)
    ///
    /// # Returns
    ///
    /// * Mode matrix ((ν - p - 1) × Σ) if ν ≥ p + 1, otherwise None
    ///
    /// # Examples
    ///
    /// ```
    /// use scirs2_core::ndarray::array;
    /// use scirs2_stats::distributions::multivariate::wishart::Wishart;
    ///
    /// let scale = array![[1.0, 0.5], [0.5, 2.0]];
    /// let df = 5.0;  // For 2x2 matrix, mode exists when df ≥ 3
    /// let wishart = Wishart::new(scale, df).expect("Operation failed");
    ///
    /// if let Some(mode) = wishart.mode() {
    ///     println!("Mode exists: {:?}", mode);
    /// }
    /// ```
    pub fn mode(&self) -> Option<Array2<f64>> {
        let p = self.dim as f64;
        if self.df < p + 1.0 {
            None // Mode doesn't exist
        } else {
            let mut mode = self.scale.clone();
            mode *= self.df - p - 1.0;
            Some(mode)
        }
    }
}

/// Create a Wishart distribution with the given parameters.
///
/// This is a convenience function to create a Wishart distribution with
/// the given scale matrix and degrees of freedom.
///
/// # Arguments
///
/// * `scale` - Scale matrix (p x p, symmetric positive-definite)
/// * `df` - Degrees of freedom (must be greater than or equal to the dimension)
///
/// # Returns
///
/// * A Wishart distribution object
///
/// # Examples
///
/// ```
/// use scirs2_core::ndarray::array;
/// use scirs2_stats::distributions::multivariate;
///
/// let scale = array![[1.0, 0.5], [0.5, 2.0]];
/// let df = 5.0;
/// let wishart = multivariate::wishart(scale, df).expect("Operation failed");
/// ```
#[allow(dead_code)]
pub fn wishart<D>(scale: ArrayBase<D, Ix2>, df: f64) -> StatsResult<Wishart>
where
    D: Data<Elem = f64>,
{
    Wishart::new(scale, df)
}

/// Implementation of SampleableDistribution for Wishart
impl SampleableDistribution<Array2<f64>> for Wishart {
    fn rvs(&self, size: usize) -> StatsResult<Vec<Array2<f64>>> {
        self.rvs(size)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use approx::assert_relative_eq;
    use scirs2_core::ndarray::array;

    #[test]
    fn test_wishart_creation() {
        // 2x2 Wishart with identity scale
        let scale = array![[1.0, 0.0], [0.0, 1.0]];
        let df = 5.0;
        let wishart = Wishart::new(scale.clone(), df).expect("Operation failed");

        assert_eq!(wishart.dim, 2);
        assert_eq!(wishart.df, df);
        assert_eq!(wishart.scale, scale);

        // 3x3 Wishart with custom scale
        let scale3 = array![[2.0, 0.5, 0.3], [0.5, 1.0, 0.1], [0.3, 0.1, 1.5]];
        let df3 = 10.0;
        let wishart3 = Wishart::new(scale3.clone(), df3).expect("Operation failed");

        assert_eq!(wishart3.dim, 3);
        assert_eq!(wishart3.df, df3);
        assert_eq!(wishart3.scale, scale3);
    }

    #[test]
    fn test_wishart_creation_errors() {
        // Non-square scale matrix
        let non_square_scale = array![[1.0, 0.5, 0.3], [0.5, 1.0, 0.1]];
        assert!(Wishart::new(non_square_scale, 5.0).is_err());

        // Degrees of freedom too small
        let scale = array![[1.0, 0.0], [0.0, 1.0]];
        assert!(Wishart::new(scale.clone(), 1.0).is_err()); // df < dim

        // Non-positive definite scale matrix
        let non_pd_scale = array![[1.0, 2.0], [2.0, 1.0]]; // Not positive definite
        assert!(Wishart::new(non_pd_scale, 5.0).is_err());
    }

    #[test]
    fn test_wishart_mean() {
        let scale = array![[1.0, 0.5], [0.5, 2.0]];
        let df = 5.0;
        let wishart = Wishart::new(scale.clone(), df).expect("Operation failed");

        let mean = wishart.mean();
        let expected_mean = scale * df;

        for i in 0..2 {
            for j in 0..2 {
                assert_relative_eq!(mean[[i, j]], expected_mean[[i, j]], epsilon = 1e-10);
            }
        }
    }

    #[test]
    fn test_wishart_mode() {
        let scale = array![[1.0, 0.5], [0.5, 2.0]];
        let df = 5.0; // df = 5 > p + 1 = 3, so mode exists
        let wishart = Wishart::new(scale.clone(), df).expect("Operation failed");

        let mode = wishart.mode().expect("Operation failed"); // Mode should exist
        let expected_mode = scale.clone() * (df - 3.0); // (ν - p - 1) × Σ where p = 2

        for i in 0..2 {
            for j in 0..2 {
                assert_relative_eq!(mode[[i, j]], expected_mode[[i, j]], epsilon = 1e-10);
            }
        }

        // Test case when mode doesn't exist
        let wishart2 = Wishart::new(scale, 2.5).expect("Operation failed"); // df = 2.5 < p + 1 = 3
        assert!(wishart2.mode().is_none()); // Mode should not exist
    }

    #[test]
    fn test_wishart_pdf() {
        // Simple identity scale case
        let scale = array![[1.0, 0.0], [0.0, 1.0]];
        let df = 5.0;
        let wishart = Wishart::new(scale, df).expect("Operation failed");

        // PDF at identity matrix
        let x = array![[1.0, 0.0], [0.0, 1.0]];
        let pdf_at_id = wishart.pdf(&x);
        assert!(pdf_at_id > 0.0);

        // PDF at another matrix
        let x2 = array![[2.0, 0.5], [0.5, 3.0]];
        let pdf_at_x2 = wishart.pdf(&x2);
        assert!(pdf_at_x2 > 0.0);

        // Check pdf of non-positive definite matrix is zero
        let non_pd = array![[1.0, 2.0], [2.0, 1.0]];
        assert_eq!(wishart.pdf(&non_pd), 0.0);
    }

    #[test]
    fn test_wishart_logpdf() {
        let scale = array![[1.0, 0.0], [0.0, 1.0]];
        let df = 5.0;
        let wishart = Wishart::new(scale, df).expect("Operation failed");

        // Check that exp(logPDF) = PDF
        let x = array![[2.0, 0.5], [0.5, 3.0]];
        let pdf = wishart.pdf(&x);
        let logpdf = wishart.logpdf(&x);
        assert_relative_eq!(logpdf.exp(), pdf, epsilon = 1e-10);

        // Check logpdf of non-positive definite matrix is -∞
        let non_pd = array![[1.0, 2.0], [2.0, 1.0]];
        assert_eq!(wishart.logpdf(&non_pd), f64::NEG_INFINITY);
    }

    #[test]
    fn test_wishart_rvs() {
        let scale = array![[1.0, 0.5], [0.5, 2.0]];
        let df = 5.0;
        let wishart = Wishart::new(scale.clone(), df).expect("Operation failed");

        // Generate samples (increased from 100 to 1000 for robustness)
        let n_samples_ = 1000;
        let samples = wishart.rvs(n_samples_).expect("Operation failed");

        // Check number of samples
        assert_eq!(samples.len(), n_samples_);

        // Check dimensions of each sample
        for sample in &samples {
            assert_eq!(sample.shape(), &[2, 2]);
        }

        // Compute sample mean
        let mut sample_mean = Array2::<f64>::zeros((2, 2));
        for sample in &samples {
            sample_mean += sample;
        }
        sample_mean /= n_samples_ as f64;

        // Expected mean is ν × Σ
        let expected_mean = scale * df;

        // Check that sample mean is close to expected mean (allowing for sampling variation)
        for i in 0..2 {
            for j in 0..2 {
                assert_relative_eq!(
                    sample_mean[[i, j]],
                    expected_mean[[i, j]],
                    epsilon = 0.8, // Larger epsilon for random sampling
                    max_relative = 0.3
                );
            }
        }
    }

    #[test]
    fn test_wishart_rvs_single() {
        let scale = array![[1.0, 0.5], [0.5, 2.0]];
        let df = 5.0;
        let wishart = Wishart::new(scale, df).expect("Operation failed");

        let sample = wishart.rvs_single().expect("Operation failed");

        // Check dimensions
        assert_eq!(sample.shape(), &[2, 2]);

        // Check that sample is symmetric
        assert_relative_eq!(sample[[0, 1]], sample[[1, 0]], epsilon = 1e-10);

        // Check that sample is positive definite (can compute Cholesky)
        assert!(compute_cholesky(&sample).is_ok());
    }
}