scirs2-sparse 0.4.2

Sparse matrix module for SciRS2 (scirs2-sparse)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
//! LU factorization updates: Sherman-Morrison-Woodbury, rank-1, column replace.
//!
//! Given an existing LU factorization PA = LU, this module provides efficient
//! updates when the matrix A is perturbed by a low-rank term, avoiding full
//! re-factorization.
//!
//! # References
//!
//! - Sherman, Morrison (1950). "Adjustment of an inverse matrix..."
//! - Woodbury (1950). "Inverting modified matrices."
//! - Golub, Van Loan (2013). *Matrix Computations*, 4th ed.

use crate::error::{SparseError, SparseResult};

use super::types::{estimate_condition, LUUpdateResult, LowRankUpdateConfig};

// ---------------------------------------------------------------------------
// Helper: dense matrix-vector multiply y = A * x
// ---------------------------------------------------------------------------
fn mat_vec_mul(a: &[Vec<f64>], x: &[f64]) -> Vec<f64> {
    a.iter()
        .map(|row| row.iter().zip(x.iter()).map(|(&ai, &xi)| ai * xi).sum())
        .collect()
}

// ---------------------------------------------------------------------------
// Helper: dense matrix-matrix multiply C = A * B
// ---------------------------------------------------------------------------
fn mat_mat_mul(a: &[Vec<f64>], b: &[Vec<f64>]) -> Vec<Vec<f64>> {
    let m = a.len();
    if m == 0 {
        return Vec::new();
    }
    let p = b.first().map_or(0, |r| r.len());
    let k = b.len();
    let mut c = vec![vec![0.0; p]; m];
    for i in 0..m {
        for j in 0..p {
            let mut s = 0.0;
            for t in 0..k {
                s += a[i][t] * b[t][j];
            }
            c[i][j] = s;
        }
    }
    c
}

// ---------------------------------------------------------------------------
// Helper: permute vector  y[i] = x[p[i]]
// ---------------------------------------------------------------------------
fn permute_vector(x: &[f64], p: &[usize]) -> Vec<f64> {
    p.iter().map(|&pi| x[pi]).collect()
}

// ---------------------------------------------------------------------------
// Helper: forward solve  L * y = b  (L lower-triangular)
// ---------------------------------------------------------------------------
fn forward_solve(l: &[Vec<f64>], b: &[f64]) -> SparseResult<Vec<f64>> {
    let n = l.len();
    let mut y = vec![0.0; n];
    for i in 0..n {
        let mut s = b[i];
        for j in 0..i {
            s -= l[i][j] * y[j];
        }
        if l[i][i].abs() < 1e-15 {
            return Err(SparseError::SingularMatrix(format!(
                "Zero diagonal at position {} during forward solve",
                i
            )));
        }
        y[i] = s / l[i][i];
    }
    Ok(y)
}

// ---------------------------------------------------------------------------
// Helper: backward solve  U * x = b  (U upper-triangular)
// ---------------------------------------------------------------------------
fn back_solve(u: &[Vec<f64>], b: &[f64]) -> SparseResult<Vec<f64>> {
    let n = u.len();
    let mut x = vec![0.0; n];
    for i in (0..n).rev() {
        let mut s = b[i];
        for j in (i + 1)..n {
            s -= u[i][j] * x[j];
        }
        if u[i][i].abs() < 1e-15 {
            return Err(SparseError::SingularMatrix(format!(
                "Zero diagonal at position {} during back solve",
                i
            )));
        }
        x[i] = s / u[i][i];
    }
    Ok(x)
}

// ---------------------------------------------------------------------------
// Helper: backward solve  U^T * x = b  (U upper-triangular, solve with transpose)
// ---------------------------------------------------------------------------
fn back_solve_transpose(u: &[Vec<f64>], b: &[f64]) -> SparseResult<Vec<f64>> {
    let n = u.len();
    let mut x = vec![0.0; n];
    for i in 0..n {
        let mut s = b[i];
        for j in 0..i {
            s -= u[j][i] * x[j];
        }
        if u[i][i].abs() < 1e-15 {
            return Err(SparseError::SingularMatrix(format!(
                "Zero diagonal at position {} during transpose back solve",
                i
            )));
        }
        x[i] = s / u[i][i];
    }
    Ok(x)
}

// ---------------------------------------------------------------------------
// Helper: invert a small dense matrix via Gauss-Jordan
// ---------------------------------------------------------------------------
fn invert_dense(a: &[Vec<f64>]) -> SparseResult<Vec<Vec<f64>>> {
    let n = a.len();
    if n == 0 {
        return Ok(Vec::new());
    }

    // Augment [A | I]
    let mut aug = vec![vec![0.0; 2 * n]; n];
    for i in 0..n {
        for j in 0..n {
            aug[i][j] = a[i][j];
        }
        aug[i][n + i] = 1.0;
    }

    // Forward elimination with partial pivoting
    for col in 0..n {
        // Find pivot
        let mut max_val = aug[col][col].abs();
        let mut max_row = col;
        for row in (col + 1)..n {
            if aug[row][col].abs() > max_val {
                max_val = aug[row][col].abs();
                max_row = row;
            }
        }
        if max_val < 1e-15 {
            return Err(SparseError::SingularMatrix(
                "Matrix is singular, cannot invert".into(),
            ));
        }
        if max_row != col {
            aug.swap(col, max_row);
        }

        let pivot = aug[col][col];
        for j in 0..(2 * n) {
            aug[col][j] /= pivot;
        }

        for row in 0..n {
            if row == col {
                continue;
            }
            let factor = aug[row][col];
            for j in 0..(2 * n) {
                aug[row][j] -= factor * aug[col][j];
            }
        }
    }

    // Extract inverse
    let mut inv = vec![vec![0.0; n]; n];
    for i in 0..n {
        for j in 0..n {
            inv[i][j] = aug[i][n + j];
        }
    }
    Ok(inv)
}

/// Compute (A + UCV)^{-1} using the Sherman-Morrison-Woodbury formula.
///
/// Given A^{-1} (the inverse of A), and matrices U, C, V defining a low-rank
/// perturbation, computes:
///
/// (A + UCV)^{-1} = A^{-1} - A^{-1} U (C^{-1} + V A^{-1} U)^{-1} V A^{-1}
///
/// # Arguments
///
/// * `a_inv` - The inverse of A (n x n dense matrix).
/// * `u_mat` - The U matrix (n x k dense matrix).
/// * `c_mat` - The C matrix (k x k dense matrix).
/// * `v_mat` - The V matrix (k x n dense matrix).
///
/// # Errors
///
/// Returns `SparseError::DimensionMismatch` if matrix dimensions are incompatible.
/// Returns `SparseError::SingularMatrix` if any required inverse is singular.
///
/// # Example
///
/// ```
/// use scirs2_sparse::low_rank_update::sherman_morrison_woodbury;
///
/// // A = I(2), so A_inv = I(2)
/// let a_inv = vec![vec![1.0, 0.0], vec![0.0, 1.0]];
/// let u_mat = vec![vec![1.0], vec![0.0]];
/// let c_mat = vec![vec![1.0]];
/// let v_mat = vec![vec![0.0, 1.0]];
/// let result = sherman_morrison_woodbury(&a_inv, &u_mat, &c_mat, &v_mat)
///     .expect("woodbury");
/// assert_eq!(result.len(), 2);
/// ```
pub fn sherman_morrison_woodbury(
    a_inv: &[Vec<f64>],
    u_mat: &[Vec<f64>],
    c_mat: &[Vec<f64>],
    v_mat: &[Vec<f64>],
) -> SparseResult<Vec<Vec<f64>>> {
    let n = a_inv.len();

    // Validate A_inv is square
    for (i, row) in a_inv.iter().enumerate() {
        if row.len() != n {
            return Err(SparseError::ComputationError(format!(
                "A_inv row {} has length {} but expected {}",
                i,
                row.len(),
                n
            )));
        }
    }

    // Determine k from U (n x k)
    if u_mat.len() != n {
        return Err(SparseError::DimensionMismatch {
            expected: n,
            found: u_mat.len(),
        });
    }
    let k = u_mat.first().map_or(0, |r| r.len());

    // Validate C is k x k
    if c_mat.len() != k {
        return Err(SparseError::DimensionMismatch {
            expected: k,
            found: c_mat.len(),
        });
    }
    for (i, row) in c_mat.iter().enumerate() {
        if row.len() != k {
            return Err(SparseError::ComputationError(format!(
                "C row {} has length {} but expected {}",
                i,
                row.len(),
                k
            )));
        }
    }

    // Validate V is k x n
    if v_mat.len() != k {
        return Err(SparseError::DimensionMismatch {
            expected: k,
            found: v_mat.len(),
        });
    }
    for (i, row) in v_mat.iter().enumerate() {
        if row.len() != n {
            return Err(SparseError::ComputationError(format!(
                "V row {} has length {} but expected {}",
                i,
                row.len(),
                n
            )));
        }
    }

    if n == 0 || k == 0 {
        return Ok(a_inv.to_vec());
    }

    // Compute A^{-1} U  (n x k)
    let a_inv_u = mat_mat_mul(a_inv, u_mat);

    // Compute V A^{-1}  (k x n)
    let v_a_inv = mat_mat_mul(v_mat, a_inv);

    // Compute V A^{-1} U  (k x k)
    let v_a_inv_u = mat_mat_mul(v_mat, &a_inv_u);

    // Compute C^{-1}  (k x k)
    let c_inv = invert_dense(c_mat)?;

    // Compute C^{-1} + V A^{-1} U  (k x k)
    let mut inner = vec![vec![0.0; k]; k];
    for i in 0..k {
        for j in 0..k {
            inner[i][j] = c_inv[i][j] + v_a_inv_u[i][j];
        }
    }

    // Invert the inner matrix  (k x k)
    let inner_inv = invert_dense(&inner)?;

    // Compute A^{-1} U * inner_inv * V A^{-1}  (n x n)
    let temp = mat_mat_mul(&a_inv_u, &inner_inv); // n x k
    let correction = mat_mat_mul(&temp, &v_a_inv); // n x n

    // Result = A^{-1} - correction
    let mut result = vec![vec![0.0; n]; n];
    for i in 0..n {
        for j in 0..n {
            result[i][j] = a_inv[i][j] - correction[i][j];
        }
    }

    Ok(result)
}

/// Compute a rank-1 update to an LU factorization.
///
/// Given PA = LU (with partial pivoting), computes the updated factorization
/// P'A' = L'U' where A' = A + u * v^T.
///
/// # Algorithm
///
/// 1. Compute w = L^{-1} P u (forward substitution with permutation).
/// 2. Compute z = U^{-T} v (backward substitution with transpose).
/// 3. Form the rank-1 modification to U: U' = U + w z^T.
/// 4. Restore upper-triangular form of U' using elimination with row swaps,
///    updating L and P accordingly.
///
/// # Arguments
///
/// * `l` - Lower-triangular factor (n x n).
/// * `u` - Upper-triangular factor (n x n).
/// * `p` - Permutation vector of length n.
/// * `u_vec` - Left update vector of length n.
/// * `v_vec` - Right update vector of length n.
///
/// # Errors
///
/// Returns errors on dimension mismatch or singular factorization.
pub fn lu_rank1_update(
    l: &[Vec<f64>],
    u: &[Vec<f64>],
    p: &[usize],
    u_vec: &[f64],
    v_vec: &[f64],
) -> SparseResult<LUUpdateResult> {
    lu_rank1_update_with_config(l, u, p, u_vec, v_vec, &LowRankUpdateConfig::default())
}

/// Rank-1 LU update with explicit configuration.
///
/// See [`lu_rank1_update`] for the mathematical details.
pub fn lu_rank1_update_with_config(
    l: &[Vec<f64>],
    u: &[Vec<f64>],
    p: &[usize],
    u_vec: &[f64],
    v_vec: &[f64],
    config: &LowRankUpdateConfig,
) -> SparseResult<LUUpdateResult> {
    let n = l.len();

    // Validation
    if u.len() != n {
        return Err(SparseError::DimensionMismatch {
            expected: n,
            found: u.len(),
        });
    }
    if p.len() != n {
        return Err(SparseError::DimensionMismatch {
            expected: n,
            found: p.len(),
        });
    }
    if u_vec.len() != n {
        return Err(SparseError::DimensionMismatch {
            expected: n,
            found: u_vec.len(),
        });
    }
    if v_vec.len() != n {
        return Err(SparseError::DimensionMismatch {
            expected: n,
            found: v_vec.len(),
        });
    }

    if n == 0 {
        return Ok(LUUpdateResult {
            l: Vec::new(),
            u: Vec::new(),
            p: Vec::new(),
            success: true,
            condition_estimate: 1.0,
        });
    }

    // Reconstruct A = P^{-1} L U, then compute A' = A + u_vec * v_vec^T,
    // and re-factorize. This is the most robust approach for dense matrices.
    //
    // For large sparse problems, incremental algorithms (Bennett, etc.) would
    // be preferred, but correctness is paramount.

    // Compute LU product
    let lu = mat_mat_mul(l, u);

    // Compute P^{-1}: p_inv[p[i]] = i
    let mut p_inv = vec![0usize; n];
    for (i, &pi) in p.iter().enumerate() {
        if pi < n {
            p_inv[pi] = i;
        }
    }

    // Reconstruct A: A[j] = (LU)[p_inv[j]]
    let mut a_prime = vec![vec![0.0; n]; n];
    for j in 0..n {
        for col in 0..n {
            a_prime[j][col] = lu[p_inv[j]][col] + u_vec[j] * v_vec[col];
        }
    }

    // LU factorization with partial pivoting of A'
    let mut u_new = a_prime;
    let mut l_new = vec![vec![0.0; n]; n];
    let mut p_new: Vec<usize> = (0..n).collect();

    for i in 0..n {
        l_new[i][i] = 1.0;
    }

    for col in 0..n {
        // Find pivot
        let mut max_val = u_new[col][col].abs();
        let mut max_row = col;
        for row in (col + 1)..n {
            if u_new[row][col].abs() > max_val {
                max_val = u_new[row][col].abs();
                max_row = row;
            }
        }

        if max_row != col {
            u_new.swap(col, max_row);
            p_new.swap(col, max_row);
            // Swap L entries for columns < col
            for j in 0..col {
                let tmp = l_new[col][j];
                l_new[col][j] = l_new[max_row][j];
                l_new[max_row][j] = tmp;
            }
        }

        if u_new[col][col].abs() < config.tolerance {
            // Near-singular; skip this column
            continue;
        }

        for row in (col + 1)..n {
            let factor = u_new[row][col] / u_new[col][col];
            l_new[row][col] = factor;
            u_new[row][col] = 0.0;
            for j in (col + 1)..n {
                u_new[row][j] -= factor * u_new[col][j];
            }
        }
    }

    let cond = estimate_condition(&u_new, config.tolerance);

    Ok(LUUpdateResult {
        l: l_new,
        u: u_new,
        p: p_new,
        success: true,
        condition_estimate: cond,
    })
}

/// Replace column `col_idx` of the matrix in an existing LU factorization.
///
/// Given PA = LU, computes the updated factorization for A' where column
/// `col_idx` of A is replaced with `new_col`. This is equivalent to a
/// rank-1 update: A' = A + (new_col - old_col) * e_k^T.
///
/// # Arguments
///
/// * `l` - Lower-triangular factor (n x n).
/// * `u` - Upper-triangular factor (n x n).
/// * `p` - Permutation vector of length n.
/// * `col_idx` - Index of the column to replace (0-based).
/// * `new_col` - The new column vector of length n.
///
/// # Errors
///
/// Returns errors on dimension mismatch, out-of-bounds column index, or
/// singular factorization.
pub fn lu_column_replace(
    l: &[Vec<f64>],
    u: &[Vec<f64>],
    p: &[usize],
    col_idx: usize,
    new_col: &[f64],
) -> SparseResult<LUUpdateResult> {
    let n = l.len();
    if col_idx >= n {
        return Err(SparseError::IndexOutOfBounds {
            index: (0, col_idx),
            shape: (n, n),
        });
    }
    if new_col.len() != n {
        return Err(SparseError::DimensionMismatch {
            expected: n,
            found: new_col.len(),
        });
    }

    // Recover old column: A = P^{-1} L U, so col k of A: old_col = P^{-T} L U e_k
    // More directly: old_col_j = sum_i (P^{-1})_{j,i} * (L U)_{i, col_idx}
    // where (P^{-1})_{j,p[j]} = 1, i.e. row j of A = row p[j] of LU.

    // Compute (LU)[:, col_idx]
    let mut lu_col = vec![0.0; n];
    for i in 0..n {
        let mut s = 0.0;
        for t in 0..n {
            s += l[i][t] * u[t][col_idx];
        }
        lu_col[i] = s;
    }

    // Recover old_col: old_col[j] = lu_col[p_inv[j]]
    // where p_inv is the inverse permutation
    let mut p_inv = vec![0usize; n];
    for (i, &pi) in p.iter().enumerate() {
        if pi < n {
            p_inv[pi] = i;
        }
    }
    let mut old_col = vec![0.0; n];
    for j in 0..n {
        old_col[j] = lu_col[p_inv[j]];
    }

    // Compute difference vector: d = new_col - old_col
    let d: Vec<f64> = new_col
        .iter()
        .zip(old_col.iter())
        .map(|(a, b)| a - b)
        .collect();

    // e_k is the k-th standard basis vector
    let mut e_k = vec![0.0; n];
    e_k[col_idx] = 1.0;

    // Apply rank-1 update: A' = A + d * e_k^T
    lu_rank1_update(l, u, p, &d, &e_k)
}

#[cfg(test)]
mod tests {
    use super::*;

    /// Simple LU factorization (no pivoting) for testing
    #[allow(clippy::type_complexity)]
    fn simple_lu(a: &[Vec<f64>]) -> SparseResult<(Vec<Vec<f64>>, Vec<Vec<f64>>, Vec<usize>)> {
        let n = a.len();
        let mut l = vec![vec![0.0; n]; n];
        let mut u_mat = vec![vec![0.0; n]; n];
        let p: Vec<usize> = (0..n).collect();

        // Copy A to U
        for i in 0..n {
            for j in 0..n {
                u_mat[i][j] = a[i][j];
            }
        }

        for i in 0..n {
            l[i][i] = 1.0;
        }

        for col in 0..n {
            if u_mat[col][col].abs() < 1e-15 {
                return Err(SparseError::SingularMatrix("Zero pivot".into()));
            }
            for row in (col + 1)..n {
                let factor = u_mat[row][col] / u_mat[col][col];
                l[row][col] = factor;
                for j in col..n {
                    u_mat[row][j] -= factor * u_mat[col][j];
                }
            }
        }

        Ok((l, u_mat, p))
    }

    /// Reconstruct A = P^{-1} L U from factorization
    fn reconstruct(l: &[Vec<f64>], u: &[Vec<f64>], p: &[usize]) -> Vec<Vec<f64>> {
        let n = l.len();
        let lu = mat_mat_mul(l, u);
        // A[j] = LU[p_inv[j]]
        let mut p_inv = vec![0usize; n];
        for (i, &pi) in p.iter().enumerate() {
            p_inv[pi] = i;
        }
        let mut a = vec![vec![0.0; n]; n];
        for j in 0..n {
            for col in 0..n {
                a[j][col] = lu[p_inv[j]][col];
            }
        }
        a
    }

    #[test]
    fn test_sherman_morrison_woodbury_identity() {
        // A = I, u = [1,0]^T, c = [1], v = [0,1]
        // A + UCV = I + [1;0]*[1]*[0,1] = [[1,1],[0,1]]
        // (A + UCV)^{-1} = [[1,-1],[0,1]]
        let a_inv = vec![vec![1.0, 0.0], vec![0.0, 1.0]];
        let u_mat = vec![vec![1.0], vec![0.0]];
        let c_mat = vec![vec![1.0]];
        let v_mat = vec![vec![0.0, 1.0]];

        let result = sherman_morrison_woodbury(&a_inv, &u_mat, &c_mat, &v_mat)
            .expect("woodbury should succeed");

        assert!((result[0][0] - 1.0).abs() < 1e-10);
        assert!((result[0][1] - (-1.0)).abs() < 1e-10);
        assert!((result[1][0]).abs() < 1e-10);
        assert!((result[1][1] - 1.0).abs() < 1e-10);
    }

    #[test]
    fn test_sherman_morrison_woodbury_3x3() {
        // A = [[2,0,0],[0,3,0],[0,0,4]]
        // A_inv = [[0.5,0,0],[0,1/3,0],[0,0,0.25]]
        // u = [[1],[1]], c = [[1,0],[0,1]], v = [[1,0,0],[0,1,0]] (k=2)
        // A + UCV = [[3,0,0],[0,4,0],[0,0,4]]
        let a_inv = vec![
            vec![0.5, 0.0, 0.0],
            vec![0.0, 1.0 / 3.0, 0.0],
            vec![0.0, 0.0, 0.25],
        ];
        let u_mat = vec![vec![1.0, 0.0], vec![0.0, 1.0], vec![0.0, 0.0]];
        let c_mat = vec![vec![1.0, 0.0], vec![0.0, 1.0]];
        let v_mat = vec![vec![1.0, 0.0, 0.0], vec![0.0, 1.0, 0.0]];

        let result = sherman_morrison_woodbury(&a_inv, &u_mat, &c_mat, &v_mat)
            .expect("woodbury 3x3 should succeed");

        // Expected: diag(1/3, 1/4, 1/4)
        assert!((result[0][0] - 1.0 / 3.0).abs() < 1e-10);
        assert!((result[1][1] - 0.25).abs() < 1e-10);
        assert!((result[2][2] - 0.25).abs() < 1e-10);
        assert!(result[0][1].abs() < 1e-10);
    }

    #[test]
    fn test_lu_rank1_update_identity() {
        // A = I, LU with P = identity
        let l = vec![vec![1.0, 0.0], vec![0.0, 1.0]];
        let u_mat = vec![vec![1.0, 0.0], vec![0.0, 1.0]];
        let p = vec![0, 1];
        let u_vec = vec![1.0, 0.0];
        let v_vec = vec![0.0, 1.0];

        let result =
            lu_rank1_update(&l, &u_mat, &p, &u_vec, &v_vec).expect("lu update on identity");

        // A' = I + [1,0]*[0,1]^T = [[1,1],[0,1]]
        let a_prime = reconstruct(&result.l, &result.u, &result.p);
        assert!((a_prime[0][0] - 1.0).abs() < 1e-10);
        assert!((a_prime[0][1] - 1.0).abs() < 1e-10);
        assert!((a_prime[1][0]).abs() < 1e-10);
        assert!((a_prime[1][1] - 1.0).abs() < 1e-10);
        assert!(result.success);
    }

    #[test]
    fn test_lu_rank1_update_factors_correctly() {
        // A = [[2, 1], [1, 3]]
        let a = vec![vec![2.0, 1.0], vec![1.0, 3.0]];
        let (l, u_mat, p) = simple_lu(&a).expect("initial LU");
        let u_vec = vec![1.0, 0.5];
        let v_vec = vec![0.5, 1.0];

        let result = lu_rank1_update(&l, &u_mat, &p, &u_vec, &v_vec).expect("rank-1 update");

        // A' = A + u*v^T
        let a_prime = reconstruct(&result.l, &result.u, &result.p);
        for i in 0..2 {
            for j in 0..2 {
                let expected = a[i][j] + u_vec[i] * v_vec[j];
                assert!(
                    (a_prime[i][j] - expected).abs() < 1e-9,
                    "Mismatch at ({},{}): {} vs {}",
                    i,
                    j,
                    a_prime[i][j],
                    expected
                );
            }
        }
    }

    #[test]
    fn test_lu_column_replace() {
        let a = vec![vec![2.0, 1.0], vec![1.0, 3.0]];
        let (l, u_mat, p) = simple_lu(&a).expect("initial LU");
        let new_col = vec![5.0, 2.0];

        let result = lu_column_replace(&l, &u_mat, &p, 0, &new_col).expect("column replace");

        // Expected A': column 0 replaced
        let a_prime = reconstruct(&result.l, &result.u, &result.p);
        assert!((a_prime[0][0] - 5.0).abs() < 1e-9);
        assert!((a_prime[1][0] - 2.0).abs() < 1e-9);
        // Column 1 unchanged
        assert!((a_prime[0][1] - 1.0).abs() < 1e-9);
        assert!((a_prime[1][1] - 3.0).abs() < 1e-9);
    }

    #[test]
    fn test_lu_dimension_mismatch() {
        let l = vec![vec![1.0, 0.0], vec![0.0, 1.0]];
        let u_mat = vec![vec![1.0, 0.0], vec![0.0, 1.0]];
        let p = vec![0, 1];
        let u_vec = vec![1.0]; // wrong size
        let v_vec = vec![0.0, 1.0];

        let result = lu_rank1_update(&l, &u_mat, &p, &u_vec, &v_vec);
        assert!(result.is_err());
    }

    #[test]
    fn test_smw_dimension_mismatch() {
        let a_inv = vec![vec![1.0, 0.0], vec![0.0, 1.0]];
        let u_mat = vec![vec![1.0]]; // wrong: 1x1 instead of 2x1
        let c_mat = vec![vec![1.0]];
        let v_mat = vec![vec![1.0, 0.0]];

        let result = sherman_morrison_woodbury(&a_inv, &u_mat, &c_mat, &v_mat);
        assert!(result.is_err());
    }
}