scirs2-optimize 0.4.2

Optimization module for SciRS2 (scirs2-optimize)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
//! Integration with scirs2-neural for machine learning optimization
//!
//! This module provides wrappers and utilities to use scirs2-optimize's
//! stochastic optimizers with scirs2-neural's neural network models.

use crate::error::OptimizeError;
use crate::stochastic::{StochasticMethod, StochasticOptions};
use scirs2_core::ndarray::{s, Array1, ScalarOperand};
use scirs2_core::numeric::Float;
use std::collections::HashMap;

/// Neural network parameter container
#[derive(Debug, Clone)]
pub struct NeuralParameters<F: Float + ScalarOperand> {
    /// Parameter vectors for each layer
    pub parameters: Vec<Array1<F>>,
    /// Gradient vectors for each layer
    pub gradients: Vec<Array1<F>>,
    /// Parameter names/ids for tracking
    pub names: Vec<String>,
}

impl<F: Float + ScalarOperand> Default for NeuralParameters<F> {
    fn default() -> Self {
        Self {
            parameters: Vec::new(),
            gradients: Vec::new(),
            names: Vec::new(),
        }
    }
}

impl<F: Float + ScalarOperand> NeuralParameters<F> {
    /// Create new neural parameters container
    pub fn new() -> Self {
        Self::default()
    }

    /// Add a parameter vector
    pub fn add_parameter(&mut self, name: String, param: Array1<F>) {
        self.names.push(name);
        self.gradients.push(Array1::zeros(param.raw_dim()));
        self.parameters.push(param);
    }

    /// Get total number of parameters
    pub fn total_parameters(&self) -> usize {
        self.parameters.iter().map(|p| p.len()).sum()
    }

    /// Flatten all parameters into a single vector
    pub fn flatten_parameters(&self) -> Array1<F> {
        let total_len = self.total_parameters();
        let mut flat = Array1::zeros(total_len);
        let mut offset = 0;

        for param in &self.parameters {
            let len = param.len();
            flat.slice_mut(s![offset..offset + len]).assign(param);
            offset += len;
        }

        flat
    }

    /// Flatten all gradients into a single vector
    pub fn flatten_gradients(&self) -> Array1<F> {
        let total_len = self.total_parameters();
        let mut flat = Array1::zeros(total_len);
        let mut offset = 0;

        for grad in &self.gradients {
            let len = grad.len();
            flat.slice_mut(s![offset..offset + len]).assign(grad);
            offset += len;
        }

        flat
    }

    /// Update parameters from flattened vector
    pub fn update_from_flat(&mut self, flat_params: &Array1<F>) {
        let mut offset = 0;

        for param in &mut self.parameters {
            let len = param.len();
            param.assign(&flat_params.slice(s![offset..offset + len]));
            offset += len;
        }
    }

    /// Update gradients from flattened vector
    pub fn update_gradients_from_flat(&mut self, flat_grads: &Array1<F>) {
        let mut offset = 0;

        for grad in &mut self.gradients {
            let len = grad.len();
            grad.assign(&flat_grads.slice(s![offset..offset + len]));
            offset += len;
        }
    }
}

/// Neural network optimizer that uses scirs2-optimize stochastic methods
pub struct NeuralOptimizer<F: Float + ScalarOperand> {
    method: StochasticMethod,
    options: StochasticOptions,
    /// Internal state for momentum-based optimizers
    momentum_buffers: HashMap<String, Array1<F>>,
    /// Internal state for Adam-family optimizers
    first_moment: HashMap<String, Array1<F>>,
    second_moment: HashMap<String, Array1<F>>,
    /// Step counter for bias correction
    step_count: usize,
}

impl<F: Float + ScalarOperand> NeuralOptimizer<F>
where
    F: 'static + Send + Sync,
{
    /// Create a new neural optimizer
    pub fn new(method: StochasticMethod, options: StochasticOptions) -> Self {
        Self {
            method,
            options,
            momentum_buffers: HashMap::new(),
            first_moment: HashMap::new(),
            second_moment: HashMap::new(),
            step_count: 0,
        }
    }

    /// Create SGD optimizer for neural networks
    pub fn sgd(learning_rate: F, max_iter: usize) -> Self {
        let options = StochasticOptions {
            learning_rate: learning_rate.to_f64().unwrap_or(0.01),
            max_iter,
            batch_size: None,
            tol: 1e-6,
            adaptive_lr: false,
            lr_decay: 0.99,
            lr_schedule: crate::stochastic::LearningRateSchedule::Constant,
            gradient_clip: None,
            early_stopping_patience: None,
        };

        Self::new(StochasticMethod::SGD, options)
    }

    /// Create Adam optimizer for neural networks
    pub fn adam(learning_rate: F, max_iter: usize) -> Self {
        let options = StochasticOptions {
            learning_rate: learning_rate.to_f64().unwrap_or(0.001),
            max_iter,
            batch_size: None,
            tol: 1e-6,
            adaptive_lr: false,
            lr_decay: 0.99,
            lr_schedule: crate::stochastic::LearningRateSchedule::Constant,
            gradient_clip: Some(1.0),
            early_stopping_patience: None,
        };

        Self::new(StochasticMethod::Adam, options)
    }

    /// Create AdamW optimizer for neural networks
    pub fn adamw(learning_rate: F, max_iter: usize) -> Self {
        let options = StochasticOptions {
            learning_rate: learning_rate.to_f64().unwrap_or(0.001),
            max_iter,
            batch_size: None,
            tol: 1e-6,
            adaptive_lr: false,
            lr_decay: 0.99,
            lr_schedule: crate::stochastic::LearningRateSchedule::Constant,
            gradient_clip: Some(1.0),
            early_stopping_patience: None,
        };

        Self::new(StochasticMethod::AdamW, options)
    }

    /// Update neural network parameters using the selected optimizer
    pub fn step(&mut self, params: &mut NeuralParameters<F>) -> Result<(), OptimizeError> {
        self.step_count += 1;

        match self.method {
            StochasticMethod::SGD => self.sgd_step(params),
            StochasticMethod::Momentum => self.momentum_step(params),
            StochasticMethod::Adam => self.adam_step(params),
            StochasticMethod::AdamW => self.adamw_step(params),
            StochasticMethod::RMSProp => self.rmsprop_step(params),
        }
    }

    /// SGD parameter update
    fn sgd_step(&self, params: &mut NeuralParameters<F>) -> Result<(), OptimizeError> {
        let lr = F::from(self.options.learning_rate)
            .unwrap_or_else(|| F::from(0.01).expect("Failed to convert constant to float"));

        for (param, grad) in params.parameters.iter_mut().zip(params.gradients.iter()) {
            *param = param.clone() - &(grad.clone() * lr);
        }

        Ok(())
    }

    /// Momentum SGD parameter update
    fn momentum_step(&mut self, params: &mut NeuralParameters<F>) -> Result<(), OptimizeError> {
        let lr = F::from(self.options.learning_rate)
            .unwrap_or_else(|| F::from(0.01).expect("Failed to convert constant to float"));
        let momentum = F::from(0.9).expect("Failed to convert constant to float");

        for (i, (param, grad)) in params
            .parameters
            .iter_mut()
            .zip(params.gradients.iter())
            .enumerate()
        {
            let param_name = format!("param_{}", i);

            // Initialize momentum buffer if not exists
            if !self.momentum_buffers.contains_key(&param_name) {
                self.momentum_buffers
                    .insert(param_name.clone(), Array1::zeros(param.raw_dim()));
            }

            let momentum_buffer = self
                .momentum_buffers
                .get_mut(&param_name)
                .expect("Operation failed");

            // v = momentum * v + grad
            *momentum_buffer = momentum_buffer.clone() * momentum + grad;

            // param = param - lr * v
            *param = param.clone() - &(momentum_buffer.clone() * lr);
        }

        Ok(())
    }

    /// Adam parameter update
    fn adam_step(&mut self, params: &mut NeuralParameters<F>) -> Result<(), OptimizeError> {
        let lr = F::from(self.options.learning_rate)
            .unwrap_or_else(|| F::from(0.001).expect("Failed to convert constant to float"));
        let beta1 = F::from(0.9).expect("Failed to convert constant to float");
        let beta2 = F::from(0.999).expect("Failed to convert constant to float");
        let epsilon = F::from(1e-8).expect("Failed to convert constant to float");

        for (i, (param, grad)) in params
            .parameters
            .iter_mut()
            .zip(params.gradients.iter())
            .enumerate()
        {
            let param_name = format!("param_{}", i);

            // Initialize moment buffers if not exists
            if !self.first_moment.contains_key(&param_name) {
                self.first_moment
                    .insert(param_name.clone(), Array1::zeros(param.raw_dim()));
                self.second_moment
                    .insert(param_name.clone(), Array1::zeros(param.raw_dim()));
            }

            let m = self
                .first_moment
                .get_mut(&param_name)
                .expect("Operation failed");
            let v = self
                .second_moment
                .get_mut(&param_name)
                .expect("Operation failed");

            // m = beta1 * m + (1 - beta1) * grad
            *m = m.clone() * beta1 + &(grad.clone() * (F::one() - beta1));

            // v = beta2 * v + (1 - beta2) * grad^2
            let grad_squared = grad.mapv(|x| x * x);
            *v = v.clone() * beta2 + &(grad_squared * (F::one() - beta2));

            // Bias correction
            let step_f = F::from(self.step_count).expect("Failed to convert to float");
            let m_hat = m.clone() / (F::one() - beta1.powf(step_f));
            let v_hat = v.clone() / (F::one() - beta2.powf(step_f));

            // param = param - lr * m_hat / (sqrt(v_hat) + epsilon)
            let denominator = v_hat.mapv(|x| x.sqrt()) + epsilon;
            let update = m_hat / denominator * lr;
            *param = param.clone() - &update;
        }

        Ok(())
    }

    /// AdamW parameter update (Adam with decoupled weight decay)
    fn adamw_step(&mut self, params: &mut NeuralParameters<F>) -> Result<(), OptimizeError> {
        let lr = F::from(self.options.learning_rate)
            .unwrap_or_else(|| F::from(0.001).expect("Failed to convert constant to float"));
        let beta1 = F::from(0.9).expect("Failed to convert constant to float");
        let beta2 = F::from(0.999).expect("Failed to convert constant to float");
        let epsilon = F::from(1e-8).expect("Failed to convert constant to float");
        let weight_decay = F::from(0.01).expect("Failed to convert constant to float");

        for (i, (param, grad)) in params
            .parameters
            .iter_mut()
            .zip(params.gradients.iter())
            .enumerate()
        {
            let param_name = format!("param_{}", i);

            // Initialize moment buffers if not exists
            if !self.first_moment.contains_key(&param_name) {
                self.first_moment
                    .insert(param_name.clone(), Array1::zeros(param.raw_dim()));
                self.second_moment
                    .insert(param_name.clone(), Array1::zeros(param.raw_dim()));
            }

            let m = self
                .first_moment
                .get_mut(&param_name)
                .expect("Operation failed");
            let v = self
                .second_moment
                .get_mut(&param_name)
                .expect("Operation failed");

            // m = beta1 * m + (1 - beta1) * grad
            *m = m.clone() * beta1 + &(grad.clone() * (F::one() - beta1));

            // v = beta2 * v + (1 - beta2) * grad^2
            let grad_squared = grad.mapv(|x| x * x);
            *v = v.clone() * beta2 + &(grad_squared * (F::one() - beta2));

            // Bias correction
            let step_f = F::from(self.step_count).expect("Failed to convert to float");
            let m_hat = m.clone() / (F::one() - beta1.powf(step_f));
            let v_hat = v.clone() / (F::one() - beta2.powf(step_f));

            // AdamW update: param = param - lr * (m_hat / (sqrt(v_hat) + epsilon) + weight_decay * param)
            let denominator = v_hat.mapv(|x| x.sqrt()) + epsilon;
            let adam_update = m_hat / denominator;
            let weight_decay_update = param.clone() * weight_decay;
            let total_update = (adam_update + weight_decay_update) * lr;

            *param = param.clone() - &total_update;
        }

        Ok(())
    }

    /// RMSprop parameter update
    fn rmsprop_step(&mut self, params: &mut NeuralParameters<F>) -> Result<(), OptimizeError> {
        let lr = F::from(self.options.learning_rate)
            .unwrap_or_else(|| F::from(0.001).expect("Failed to convert constant to float"));
        let alpha = F::from(0.99).expect("Failed to convert constant to float"); // decay rate
        let epsilon = F::from(1e-8).expect("Failed to convert constant to float");

        for (i, (param, grad)) in params
            .parameters
            .iter_mut()
            .zip(params.gradients.iter())
            .enumerate()
        {
            let param_name = format!("param_{}", i);

            // Initialize squared average buffer if not exists
            if !self.second_moment.contains_key(&param_name) {
                self.second_moment
                    .insert(param_name.clone(), Array1::zeros(param.raw_dim()));
            }

            let v = self
                .second_moment
                .get_mut(&param_name)
                .expect("Operation failed");

            // v = alpha * v + (1 - alpha) * grad^2
            let grad_squared = grad.mapv(|x| x * x);
            *v = v.clone() * alpha + &(grad_squared * (F::one() - alpha));

            // param = param - lr * grad / (sqrt(v) + epsilon)
            let denominator = v.mapv(|x| x.sqrt()) + epsilon;
            let update = grad.clone() / denominator * lr;
            *param = param.clone() - &update;
        }

        Ok(())
    }

    /// Get current learning rate
    pub fn get_learning_rate(&self) -> f64 {
        self.options.learning_rate
    }

    /// Set learning rate
    pub fn set_learning_rate(&mut self, lr: f64) {
        self.options.learning_rate = lr;
    }

    /// Reset internal state
    pub fn reset(&mut self) {
        self.momentum_buffers.clear();
        self.first_moment.clear();
        self.second_moment.clear();
        self.step_count = 0;
    }

    /// Get optimizer method name
    pub fn method_name(&self) -> &'static str {
        match self.method {
            StochasticMethod::SGD => "SGD",
            StochasticMethod::Momentum => "SGD with Momentum",
            StochasticMethod::Adam => "Adam",
            StochasticMethod::AdamW => "AdamW",
            StochasticMethod::RMSProp => "RMSprop",
        }
    }
}

/// Neural network trainer that combines optimization with training loops
pub struct NeuralTrainer<F: Float + ScalarOperand> {
    optimizer: NeuralOptimizer<F>,
    loss_history: Vec<F>,
    early_stopping_patience: Option<usize>,
    best_loss: Option<F>,
    patience_counter: usize,
}

impl<F: Float + ScalarOperand> NeuralTrainer<F>
where
    F: 'static + Send + Sync + std::fmt::Display,
{
    /// Create a new neural trainer
    pub fn new(optimizer: NeuralOptimizer<F>) -> Self {
        Self {
            optimizer,
            loss_history: Vec::new(),
            early_stopping_patience: None,
            best_loss: None,
            patience_counter: 0,
        }
    }

    /// Set early stopping patience
    pub fn with_early_stopping(mut self, patience: usize) -> Self {
        self.early_stopping_patience = Some(patience);
        self
    }

    /// Train for one epoch
    pub fn train_epoch<LossFn, GradFn>(
        &mut self,
        params: &mut NeuralParameters<F>,
        loss_fn: &mut LossFn,
        grad_fn: &mut GradFn,
    ) -> Result<F, OptimizeError>
    where
        LossFn: FnMut(&NeuralParameters<F>) -> F,
        GradFn: FnMut(&NeuralParameters<F>) -> Vec<Array1<F>>,
    {
        // Compute gradients
        let gradients = grad_fn(params);
        params.gradients = gradients;

        // Apply gradient clipping if specified
        if let Some(max_norm) = self.optimizer.options.gradient_clip {
            self.clip_gradients(params, max_norm);
        }

        // Update parameters
        self.optimizer.step(params)?;

        // Compute loss
        let loss = loss_fn(params);
        self.loss_history.push(loss);

        // Check early stopping
        if let Some(_patience) = self.early_stopping_patience {
            if let Some(best_loss) = self.best_loss {
                if loss < best_loss {
                    self.best_loss = Some(loss);
                    self.patience_counter = 0;
                } else {
                    self.patience_counter += 1;
                }
            } else {
                self.best_loss = Some(loss);
            }
        }

        Ok(loss)
    }

    /// Check if training should stop early
    pub fn should_stop_early(&self) -> bool {
        if let Some(patience) = self.early_stopping_patience {
            self.patience_counter >= patience
        } else {
            false
        }
    }

    /// Get loss history
    pub fn loss_history(&self) -> &[F] {
        &self.loss_history
    }

    /// Get current learning rate
    pub fn learning_rate(&self) -> f64 {
        self.optimizer.get_learning_rate()
    }

    /// Set learning rate
    pub fn set_learning_rate(&mut self, lr: f64) {
        self.optimizer.set_learning_rate(lr);
    }

    /// Clip gradients to prevent exploding gradients
    fn clip_gradients(&self, params: &mut NeuralParameters<F>, max_norm: f64) {
        let max_norm_f = F::from(max_norm).expect("Failed to convert to float");

        // Compute total gradient norm
        let mut total_norm_sq = F::zero();
        for grad in &params.gradients {
            total_norm_sq = total_norm_sq + grad.mapv(|x| x * x).sum();
        }
        let total_norm = total_norm_sq.sqrt();

        if total_norm > max_norm_f {
            let scale = max_norm_f / total_norm;
            for grad in &mut params.gradients {
                grad.mapv_inplace(|x| x * scale);
            }
        }
    }
}

/// Convenience functions for creating neural optimizers
pub mod optimizers {
    use super::*;

    /// Create SGD optimizer with default settings for neural networks
    pub fn sgd<F>(learning_rate: F) -> NeuralOptimizer<F>
    where
        F: Float + ScalarOperand + 'static + Send + Sync,
    {
        NeuralOptimizer::sgd(learning_rate, 1000)
    }

    /// Create Adam optimizer with default settings for neural networks
    pub fn adam<F>(learning_rate: F) -> NeuralOptimizer<F>
    where
        F: Float + ScalarOperand + 'static + Send + Sync,
    {
        NeuralOptimizer::adam(learning_rate, 1000)
    }

    /// Create AdamW optimizer with default settings for neural networks
    pub fn adamw<F>(learning_rate: F) -> NeuralOptimizer<F>
    where
        F: Float + ScalarOperand + 'static + Send + Sync,
    {
        NeuralOptimizer::adamw(learning_rate, 1000)
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use approx::assert_abs_diff_eq;

    #[test]
    fn test_neural_parameters() {
        let mut params = NeuralParameters::<f64>::new();

        // Add some parameters
        params.add_parameter("layer1".to_string(), Array1::from_vec(vec![1.0, 2.0, 3.0]));
        params.add_parameter("layer2".to_string(), Array1::from_vec(vec![4.0, 5.0]));

        assert_eq!(params.total_parameters(), 5);

        // Test flattening
        let flat = params.flatten_parameters();
        assert_eq!(
            flat.as_slice().expect("Operation failed"),
            &[1.0, 2.0, 3.0, 4.0, 5.0]
        );

        // Test updating from flat
        let new_flat = Array1::from_vec(vec![6.0, 7.0, 8.0, 9.0, 10.0]);
        params.update_from_flat(&new_flat);

        assert_eq!(
            params.parameters[0].as_slice().expect("Operation failed"),
            &[6.0, 7.0, 8.0]
        );
        assert_eq!(
            params.parameters[1].as_slice().expect("Operation failed"),
            &[9.0, 10.0]
        );
    }

    #[test]
    fn test_sgd_optimizer() {
        let mut optimizer = NeuralOptimizer::sgd(0.1, 100);
        let mut params = NeuralParameters::<f64>::new();

        // Add parameter
        params.add_parameter("test".to_string(), Array1::from_vec(vec![1.0, 2.0]));
        // Set gradient
        params.gradients[0] = Array1::from_vec(vec![0.5, 1.0]);

        // Perform one step
        optimizer.step(&mut params).expect("Operation failed");

        // Check update: param = param - lr * grad
        let expected = [1.0 - 0.1 * 0.5, 2.0 - 0.1 * 1.0];
        assert_abs_diff_eq!(params.parameters[0][0], expected[0], epsilon = 1e-10);
        assert_abs_diff_eq!(params.parameters[0][1], expected[1], epsilon = 1e-10);
    }

    #[test]
    fn test_adam_optimizer() {
        let mut optimizer = NeuralOptimizer::adam(0.001, 100);
        let mut params = NeuralParameters::<f64>::new();

        // Add parameter
        params.add_parameter("test".to_string(), Array1::from_vec(vec![1.0, 2.0]));
        // Set gradient
        params.gradients[0] = Array1::from_vec(vec![0.1, 0.2]);

        let original_params = params.parameters[0].clone();

        // Perform one step
        optimizer.step(&mut params).expect("Operation failed");

        // Parameters should have changed
        assert_ne!(params.parameters[0][0], original_params[0]);
        assert_ne!(params.parameters[0][1], original_params[1]);

        // Parameters should have decreased (since gradients are positive)
        assert!(params.parameters[0][0] < original_params[0]);
        assert!(params.parameters[0][1] < original_params[1]);
    }

    #[test]
    fn test_neural_trainer() {
        let optimizer = NeuralOptimizer::sgd(0.1, 100);
        let mut trainer = NeuralTrainer::new(optimizer).with_early_stopping(5);

        let mut params = NeuralParameters::<f64>::new();
        params.add_parameter("test".to_string(), Array1::from_vec(vec![1.0]));
        params.gradients[0] = Array1::from_vec(vec![1.0]);

        // Simple quadratic loss function
        let mut loss_fn = |p: &NeuralParameters<f64>| p.parameters[0][0] * p.parameters[0][0];
        let mut grad_fn =
            |p: &NeuralParameters<f64>| vec![Array1::from_vec(vec![2.0 * p.parameters[0][0]])];

        // Train for one epoch
        let loss = trainer
            .train_epoch(&mut params, &mut loss_fn, &mut grad_fn)
            .expect("Operation failed");

        // Loss should be computed
        assert_eq!(trainer.loss_history().len(), 1);
        assert_eq!(trainer.loss_history()[0], loss);
    }

    #[test]
    fn test_optimizer_convenience_functions() {
        let sgd_opt = optimizers::sgd(0.01);
        assert_eq!(sgd_opt.method_name(), "SGD");

        let adam_opt = optimizers::adam(0.001);
        assert_eq!(adam_opt.method_name(), "Adam");

        let adamw_opt = optimizers::adamw(0.001);
        assert_eq!(adamw_opt.method_name(), "AdamW");
    }
}