scirs2-neural 0.4.3

Neural network building blocks module for SciRS2 (scirs2-neural) - Minimal Version
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
//! Architecture encoding schemes for Neural Architecture Search

use crate::error::{NeuralError, Result};
use crate::nas::search_space::{Architecture, LayerType};
use std::collections::HashMap;
use std::fmt;

/// Trait for architecture encoding schemes
pub trait ArchitectureEncoding: Send + Sync + fmt::Display {
    /// Convert to a vector representation
    fn to_vector(&self) -> Vec<f64>;
    /// Create from a vector representation
    fn from_vector(vec: &[f64]) -> Result<Self>
    where
        Self: Sized;
    /// Get the dimensionality of the encoding
    fn dimension(&self) -> usize;
    /// Mutate the architecture
    fn mutate(&self, mutation_rate: f32) -> Result<Box<dyn ArchitectureEncoding>>;
    /// Crossover with another architecture
    fn crossover(&self, other: &dyn ArchitectureEncoding) -> Result<Box<dyn ArchitectureEncoding>>;
    /// Convert to Architecture struct
    fn to_architecture(&self) -> Result<Architecture>;
    /// Clone as trait object
    fn clone_box(&self) -> Box<dyn ArchitectureEncoding>;
}

/// Node type in a graph encoding
#[derive(Debug, Clone)]
pub struct NodeType {
    pub layer_type: LayerType,
    pub is_input: bool,
    pub is_output: bool,
}

/// Node attributes
#[derive(Debug, Clone)]
pub struct NodeAttributes {
    pub name: String,
    pub operation_type: String,
    pub parameters: HashMap<String, f64>,
}

/// Graph-based encoding (for complex topologies)
#[derive(Debug, Clone)]
pub struct GraphEncoding {
    /// Node types (layer types)
    pub nodes: Vec<NodeType>,
    /// Adjacency matrix
    pub edges: Vec<Vec<bool>>,
    /// Node attributes
    pub node_attrs: Vec<NodeAttributes>,
}

impl GraphEncoding {
    /// Create a new graph encoding
    pub fn new(nodes: Vec<NodeType>, edges: Vec<Vec<bool>>) -> Self {
        let node_attrs = nodes
            .iter()
            .enumerate()
            .map(|(i, _)| NodeAttributes {
                name: format!("node_{}", i),
                operation_type: "default".to_string(),
                parameters: HashMap::new(),
            })
            .collect();
        Self {
            nodes,
            edges,
            node_attrs,
        }
    }

    /// Create a random graph encoding
    pub fn random<R: scirs2_core::random::Rng>(
        rng: &mut scirs2_core::random::prelude::Random<R>,
    ) -> Result<Self> {
        let num_nodes = rng.random_range(3..=8);
        let mut nodes = Vec::with_capacity(num_nodes);
        nodes.push(NodeType {
            layer_type: LayerType::Dense(rng.random_range(64..=256)),
            is_input: true,
            is_output: false,
        });
        for _ in 1..num_nodes - 1 {
            let layer_type = match rng.random_range(0..5) {
                0 => LayerType::Dense(rng.random_range(32..=512)),
                1 => LayerType::Conv2D {
                    filters: rng.random_range(16..=256),
                    kernel_size: (3, 3),
                    stride: (1, 1),
                },
                2 => LayerType::Dropout(rng.random_range(10..50) as f32 / 100.0),
                3 => LayerType::BatchNorm,
                _ => LayerType::Activation("relu".to_string()),
            };
            nodes.push(NodeType {
                layer_type,
                is_input: false,
                is_output: false,
            });
        }
        nodes.push(NodeType {
            layer_type: LayerType::Dense(rng.random_range(1..=10)),
            is_input: false,
            is_output: true,
        });
        let mut edges = vec![vec![false; num_nodes]; num_nodes];
        for i in 0..num_nodes - 1 {
            edges[i][i + 1] = true;
        }
        for (i, row) in edges.iter_mut().enumerate().take(num_nodes) {
            for cell in row.iter_mut().take(num_nodes).skip(i + 2) {
                if rng.random_bool(0.2) {
                    *cell = true;
                }
            }
        }
        Ok(Self::new(nodes, edges))
    }

    fn compute_complexity_factor(&self) -> f32 {
        let mut layer_types = std::collections::HashSet::new();
        for node in &self.nodes {
            layer_types.insert(std::mem::discriminant(&node.layer_type));
        }
        let mut complexity = layer_types.len() as f32 / self.nodes.len().max(1) as f32;
        let mut connections = 0;
        for row in &self.edges {
            connections += row.iter().filter(|&&x| x).count();
        }
        let n = self.nodes.len();
        complexity += connections as f32 / (n * n).max(1) as f32;
        complexity.min(1.0)
    }

    fn choose_kernel_size<R: scirs2_core::random::Rng>(
        &self,
        rng: &mut scirs2_core::random::prelude::Random<R>,
    ) -> (usize, usize) {
        let sizes = [(1usize, 1usize), (3, 3), (5, 5), (7, 7)];
        let idx = rng.random_range(0..sizes.len());
        sizes[idx]
    }

    fn choose_stride<R: scirs2_core::random::Rng>(
        &self,
        rng: &mut scirs2_core::random::prelude::Random<R>,
    ) -> (usize, usize) {
        let strides = [(1usize, 1usize), (2, 2)];
        let idx = rng.random_range(0..strides.len());
        strides[idx]
    }

    fn choose_random_layer_type<R: scirs2_core::random::Rng>(
        &self,
        rng: &mut scirs2_core::random::prelude::Random<R>,
    ) -> LayerType {
        let k = self.choose_kernel_size(rng);
        let s = self.choose_stride(rng);
        match rng.random_range(0..5) {
            0 => LayerType::Dense(rng.random_range(32..=512)),
            1 => LayerType::Conv2D {
                filters: rng.random_range(16..=256),
                kernel_size: k,
                stride: s,
            },
            2 => LayerType::Dropout(rng.random_range(10..50) as f32 / 100.0),
            3 => LayerType::BatchNorm,
            _ => LayerType::Activation("relu".to_string()),
        }
    }

    fn would_disconnect_graph(
        &self,
        edges: &[Vec<bool>],
        from: usize,
        to: usize,
        num_nodes: usize,
    ) -> bool {
        let mut test_edges = edges.to_vec();
        test_edges[from][to] = !test_edges[from][to];
        let mut reachable = vec![false; num_nodes];
        for (i, node) in self.nodes.iter().enumerate() {
            if node.is_input {
                reachable[i] = true;
            }
        }
        let mut changed = true;
        while changed {
            changed = false;
            for i in 0..num_nodes {
                if reachable[i] {
                    for j in 0..num_nodes {
                        if test_edges[i][j] && !reachable[j] {
                            reachable[j] = true;
                            changed = true;
                        }
                    }
                }
            }
        }
        for (i, node) in self.nodes.iter().enumerate() {
            if node.is_output && !reachable[i] {
                return true;
            }
        }
        false
    }

    fn add_node<R: scirs2_core::random::Rng>(
        &self,
        mutated: &mut GraphEncoding,
        rng: &mut scirs2_core::random::prelude::Random<R>,
    ) -> Result<()> {
        let new_layer_type = self.choose_random_layer_type(rng);
        let new_node = NodeType {
            layer_type: new_layer_type,
            is_input: false,
            is_output: false,
        };
        mutated.nodes.push(new_node);
        let new_size = mutated.nodes.len();
        for row in &mut mutated.edges {
            row.push(false);
        }
        mutated.edges.push(vec![false; new_size]);
        mutated.node_attrs.push(NodeAttributes {
            name: format!("node_{}", new_size - 1),
            operation_type: "default".to_string(),
            parameters: HashMap::new(),
        });
        if new_size >= 2 {
            let from_idx = rng.random_range(0..new_size - 1);
            mutated.edges[from_idx][new_size - 1] = true;
            if new_size >= 2 {
                let to_idx = rng.random_range(0..new_size - 1);
                if to_idx != new_size - 1 {
                    mutated.edges[new_size - 1][to_idx] = true;
                }
            }
        }
        Ok(())
    }
}

impl ArchitectureEncoding for GraphEncoding {
    fn to_vector(&self) -> Vec<f64> {
        let mut vec = Vec::new();
        vec.push(self.nodes.len() as f64);
        for node in &self.nodes {
            vec.push(if node.is_input { 1.0 } else { 0.0 });
            vec.push(if node.is_output { 1.0 } else { 0.0 });
            match &node.layer_type {
                LayerType::Dense(units) => {
                    vec.push(1.0);
                    vec.push(*units as f64);
                }
                LayerType::Conv2D { filters, .. } => {
                    vec.push(2.0);
                    vec.push(*filters as f64);
                }
                LayerType::Dropout(rate) => {
                    vec.push(3.0);
                    vec.push(*rate as f64);
                }
                LayerType::BatchNorm => {
                    vec.push(4.0);
                    vec.push(0.0);
                }
                LayerType::Activation(_) => {
                    vec.push(5.0);
                    vec.push(0.0);
                }
                _ => {
                    vec.push(0.0);
                    vec.push(0.0);
                }
            }
        }
        for row in &self.edges {
            for &edge in row {
                vec.push(if edge { 1.0 } else { 0.0 });
            }
        }
        vec
    }

    fn from_vector(vec: &[f64]) -> Result<Self> {
        if vec.is_empty() {
            return Err(NeuralError::ConfigError(
                "Empty vector for GraphEncoding".to_string(),
            ));
        }
        let num_nodes = vec[0] as usize;
        if num_nodes == 0 {
            return Err(NeuralError::ConfigError(
                "GraphEncoding must have at least one node".to_string(),
            ));
        }
        let expected_size = 1 + num_nodes * 4 + num_nodes * num_nodes;
        if vec.len() < expected_size {
            return Err(NeuralError::ConfigError(format!(
                "Vector too short: expected at least {}, got {}",
                expected_size,
                vec.len()
            )));
        }
        let mut nodes = Vec::with_capacity(num_nodes);
        let mut node_attrs = Vec::with_capacity(num_nodes);
        let mut idx = 1;
        for i in 0..num_nodes {
            let is_input = vec[idx] > 0.5;
            let is_output = vec[idx + 1] > 0.5;
            let layer_type_code = vec[idx + 2] as i32;
            let layer_param = vec[idx + 3];
            let layer_type = match layer_type_code {
                1 => LayerType::Dense(layer_param as usize),
                2 => LayerType::Conv2D {
                    filters: layer_param as usize,
                    kernel_size: (3, 3),
                    stride: (1, 1),
                },
                3 => LayerType::Dropout(layer_param as f32),
                4 => LayerType::BatchNorm,
                5 => LayerType::Activation("relu".to_string()),
                _ => LayerType::Dense(64),
            };
            nodes.push(NodeType {
                layer_type,
                is_input,
                is_output,
            });
            node_attrs.push(NodeAttributes {
                name: format!("node_{}", i),
                operation_type: "default".to_string(),
                parameters: HashMap::new(),
            });
            idx += 4;
        }
        let mut edges = vec![vec![false; num_nodes]; num_nodes];
        for row in edges.iter_mut().take(num_nodes) {
            for cell in row.iter_mut().take(num_nodes) {
                if idx < vec.len() {
                    *cell = vec[idx] > 0.5;
                    idx += 1;
                }
            }
        }
        Ok(GraphEncoding {
            nodes,
            edges,
            node_attrs,
        })
    }

    fn dimension(&self) -> usize {
        1 + self.nodes.len() * 4 + self.edges.len() * self.edges.len()
    }

    fn mutate(&self, mutation_rate: f32) -> Result<Box<dyn ArchitectureEncoding>> {
        use scirs2_core::random::prelude::*;
        let mut rng = thread_rng();
        let mut mutated = self.clone();
        let complexity_factor = self.compute_complexity_factor();
        let adaptive_rate = mutation_rate * (1.0 + complexity_factor * 0.5);
        let mutation_type = rng.random_range(0..5);
        match mutation_type {
            0 => {
                // Mutate layer types
                for node in &mut mutated.nodes {
                    if !node.is_input && !node.is_output && rng.random_bool(adaptive_rate as f64) {
                        node.layer_type = self.choose_random_layer_type(&mut rng);
                    }
                }
            }
            1 => {
                // Mutate layer parameters
                for node in &mut mutated.nodes {
                    if !node.is_input && !node.is_output && rng.random_bool(adaptive_rate as f64) {
                        match &mut node.layer_type {
                            LayerType::Dense(ref mut units) => {
                                *units = rng.random_range(32..=512);
                            }
                            LayerType::Conv2D {
                                ref mut filters, ..
                            } => {
                                *filters = rng.random_range(16..=256);
                            }
                            LayerType::Dropout(ref mut rate) => {
                                *rate = rng.random_range(10..50) as f32 / 100.0;
                            }
                            _ => {}
                        }
                    }
                }
            }
            2 => {
                // Mutate connections
                let num_nodes = mutated.nodes.len();
                for i in 0..num_nodes {
                    for j in 0..num_nodes {
                        if i != j && rng.random_bool(adaptive_rate as f64) {
                            let would_disconnect =
                                self.would_disconnect_graph(&mutated.edges, i, j, num_nodes);
                            if !would_disconnect {
                                mutated.edges[i][j] = !mutated.edges[i][j];
                            }
                        }
                    }
                }
            }
            3 => {
                // Mutate architecture structure
                if rng.random_bool(adaptive_rate as f64) && mutated.nodes.len() < 20 {
                    self.add_node(&mut mutated, &mut rng)?;
                }
            }
            _ => {
                // Hybrid
                for node in &mut mutated.nodes {
                    if !node.is_input
                        && !node.is_output
                        && rng.random_bool(adaptive_rate as f64 * 0.3)
                    {
                        node.layer_type = self.choose_random_layer_type(&mut rng);
                    }
                }
                let num_nodes = mutated.nodes.len();
                for i in 0..num_nodes {
                    for j in 0..num_nodes {
                        if i != j && rng.random_bool(adaptive_rate as f64 * 0.2) {
                            let would_disconnect =
                                self.would_disconnect_graph(&mutated.edges, i, j, num_nodes);
                            if !would_disconnect {
                                mutated.edges[i][j] = !mutated.edges[i][j];
                            }
                        }
                    }
                }
            }
        }
        Ok(Box::new(mutated))
    }

    fn crossover(&self, other: &dyn ArchitectureEncoding) -> Result<Box<dyn ArchitectureEncoding>> {
        use scirs2_core::random::prelude::*;
        let mut rng = thread_rng();
        let self_vec = self.to_vector();
        let other_vec = other.to_vector();
        let min_len = self_vec.len().min(other_vec.len());
        let mut mixed_vec = Vec::with_capacity(self_vec.len().max(other_vec.len()));
        for i in 0..min_len {
            if rng.random_bool(0.5) {
                mixed_vec.push(self_vec[i]);
            } else {
                mixed_vec.push(other_vec[i]);
            }
        }
        if self_vec.len() > min_len {
            mixed_vec.extend_from_slice(&self_vec[min_len..]);
        } else if other_vec.len() > min_len {
            mixed_vec.extend_from_slice(&other_vec[min_len..]);
        }
        let result = GraphEncoding::from_vector(&mixed_vec)?;
        Ok(Box::new(result))
    }

    fn to_architecture(&self) -> Result<Architecture> {
        let mut layers = Vec::new();
        let mut connections = Vec::new();
        for node in &self.nodes {
            layers.push(node.layer_type.clone());
        }
        for (i, row) in self.edges.iter().enumerate() {
            for (j, &connected) in row.iter().enumerate() {
                if connected {
                    connections.push((i, j));
                }
            }
        }
        Architecture::new(layers, connections)
    }

    fn clone_box(&self) -> Box<dyn ArchitectureEncoding> {
        Box::new(self.clone())
    }
}

impl fmt::Display for GraphEncoding {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        writeln!(f, "GraphEncoding:")?;
        writeln!(f, "  Nodes: {}", self.nodes.len())?;
        for (i, node) in self.nodes.iter().enumerate() {
            write!(f, "    {}: {:?}", i, node.layer_type)?;
            if node.is_input {
                write!(f, " [INPUT]")?;
            }
            if node.is_output {
                write!(f, " [OUTPUT]")?;
            }
            writeln!(f)?;
        }
        writeln!(f, "  Edges:")?;
        for (i, row) in self.edges.iter().enumerate() {
            write!(f, "    {}: ", i)?;
            for (j, &connected) in row.iter().enumerate() {
                if connected {
                    write!(f, "{} ", j)?;
                }
            }
            writeln!(f)?;
        }
        Ok(())
    }
}

/// Sequential encoding (for simple feed-forward networks)
#[derive(Debug, Clone)]
pub struct SequentialEncoding {
    pub layers: Vec<LayerType>,
}

impl SequentialEncoding {
    pub fn new(layers: Vec<LayerType>) -> Self {
        Self { layers }
    }

    pub fn random<R: scirs2_core::random::Rng>(
        rng: &mut scirs2_core::random::prelude::Random<R>,
    ) -> Result<Self> {
        let num_layers = rng.random_range(3..=10);
        let mut layers = Vec::with_capacity(num_layers);
        layers.push(LayerType::Dense(rng.random_range(64..=512)));
        for _ in 1..num_layers - 1 {
            let layer_type = match rng.random_range(0..4) {
                0 => LayerType::Dense(rng.random_range(32..=512)),
                1 => LayerType::Dropout(rng.random_range(10..50) as f32 / 100.0),
                2 => LayerType::BatchNorm,
                _ => LayerType::Activation("relu".to_string()),
            };
            layers.push(layer_type);
        }
        layers.push(LayerType::Dense(rng.random_range(1..=10)));
        Ok(Self { layers })
    }
}

impl ArchitectureEncoding for SequentialEncoding {
    fn to_vector(&self) -> Vec<f64> {
        let mut vec = Vec::new();
        vec.push(self.layers.len() as f64);
        for layer in &self.layers {
            match layer {
                LayerType::Dense(units) => {
                    vec.push(1.0);
                    vec.push(*units as f64);
                    vec.push(0.0);
                }
                LayerType::Conv2D { filters, .. } => {
                    vec.push(2.0);
                    vec.push(*filters as f64);
                    vec.push(0.0);
                }
                LayerType::Dropout(rate) => {
                    vec.push(3.0);
                    vec.push(*rate as f64);
                    vec.push(0.0);
                }
                LayerType::BatchNorm => {
                    vec.push(4.0);
                    vec.push(0.0);
                    vec.push(0.0);
                }
                LayerType::Activation(_) => {
                    vec.push(5.0);
                    vec.push(0.0);
                    vec.push(0.0);
                }
                _ => {
                    vec.push(0.0);
                    vec.push(0.0);
                    vec.push(0.0);
                }
            }
        }
        vec
    }

    fn from_vector(vec: &[f64]) -> Result<Self> {
        if vec.is_empty() {
            return Err(NeuralError::ConfigError(
                "Empty vector for SequentialEncoding".to_string(),
            ));
        }
        let num_layers = vec[0] as usize;
        if num_layers == 0 {
            return Err(NeuralError::ConfigError(
                "SequentialEncoding must have at least one layer".to_string(),
            ));
        }
        let expected_size = 1 + num_layers * 3;
        if vec.len() < expected_size {
            return Err(NeuralError::ConfigError(format!(
                "Vector too short: expected {}, got {}",
                expected_size,
                vec.len()
            )));
        }
        let mut layers = Vec::with_capacity(num_layers);
        let mut idx = 1;
        for _ in 0..num_layers {
            let layer_type_code = vec[idx] as i32;
            let param1 = vec[idx + 1];
            let layer_type = match layer_type_code {
                1 => LayerType::Dense(param1 as usize),
                2 => LayerType::Conv2D {
                    filters: param1 as usize,
                    kernel_size: (3, 3),
                    stride: (1, 1),
                },
                3 => LayerType::Dropout(param1 as f32),
                4 => LayerType::BatchNorm,
                5 => LayerType::Activation("relu".to_string()),
                _ => LayerType::Dense(64),
            };
            layers.push(layer_type);
            idx += 3;
        }
        Ok(Self { layers })
    }

    fn dimension(&self) -> usize {
        1 + self.layers.len() * 3
    }

    fn mutate(&self, mutation_rate: f32) -> Result<Box<dyn ArchitectureEncoding>> {
        use scirs2_core::random::prelude::*;
        let mut rng = thread_rng();
        let mut mutated = self.clone();
        for layer in &mut mutated.layers {
            if rng.random_bool(mutation_rate as f64) {
                match layer {
                    LayerType::Dense(ref mut units) => {
                        *units = rng.random_range(32..=512);
                    }
                    LayerType::Conv2D {
                        ref mut filters, ..
                    } => {
                        *filters = rng.random_range(16..=256);
                    }
                    LayerType::Dropout(ref mut rate) => {
                        *rate = rng.random_range(10..50) as f32 / 100.0;
                    }
                    _ => {}
                }
            }
        }
        if rng.random_bool(mutation_rate as f64 * 0.1) {
            if mutated.layers.len() < 15 && rng.random_bool(0.7) {
                let pos = if mutated.layers.len() > 1 {
                    rng.random_range(1..mutated.layers.len())
                } else {
                    1
                };
                let new_layer = match rng.random_range(0..4) {
                    0 => LayerType::Dense(rng.random_range(32..=512)),
                    1 => LayerType::Dropout(rng.random_range(10..50) as f32 / 100.0),
                    2 => LayerType::BatchNorm,
                    _ => LayerType::Activation("relu".to_string()),
                };
                mutated.layers.insert(pos, new_layer);
            } else if mutated.layers.len() > 3 {
                let pos = rng.random_range(1..mutated.layers.len() - 1);
                mutated.layers.remove(pos);
            }
        }
        Ok(Box::new(mutated))
    }

    fn crossover(&self, other: &dyn ArchitectureEncoding) -> Result<Box<dyn ArchitectureEncoding>> {
        use scirs2_core::random::prelude::*;
        let mut rng = thread_rng();
        let self_vec = self.to_vector();
        let other_vec = other.to_vector();
        if self_vec.len() >= 4 && other_vec.len() >= 4 {
            let min_len = self_vec.len().min(other_vec.len());
            let crossover_point = rng.random_range(1..min_len);
            let mut child_vec = Vec::new();
            child_vec.extend_from_slice(&self_vec[..crossover_point]);
            child_vec.extend_from_slice(&other_vec[crossover_point..]);
            if let Ok(result) = SequentialEncoding::from_vector(&child_vec) {
                return Ok(Box::new(result));
            }
        }
        self.mutate(0.1)
    }

    fn to_architecture(&self) -> Result<Architecture> {
        let mut connections = Vec::new();
        for i in 0..self.layers.len().saturating_sub(1) {
            connections.push((i, i + 1));
        }
        Architecture::new(self.layers.clone(), connections)
    }

    fn clone_box(&self) -> Box<dyn ArchitectureEncoding> {
        Box::new(self.clone())
    }
}

impl fmt::Display for SequentialEncoding {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        writeln!(f, "SequentialEncoding:")?;
        for (i, layer) in self.layers.iter().enumerate() {
            writeln!(f, "  {}: {:?}", i, layer)?;
        }
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use scirs2_core::random::prelude::*;

    #[test]
    fn test_graph_encoding() {
        let nodes = vec![
            NodeType {
                layer_type: LayerType::Dense(64),
                is_input: true,
                is_output: false,
            },
            NodeType {
                layer_type: LayerType::Dense(32),
                is_input: false,
                is_output: false,
            },
            NodeType {
                layer_type: LayerType::Dense(10),
                is_input: false,
                is_output: true,
            },
        ];
        let edges = vec![
            vec![false, true, false],
            vec![false, false, true],
            vec![false, false, false],
        ];
        let encoding = GraphEncoding::new(nodes, edges);
        let vector = encoding.to_vector();
        let decoded = GraphEncoding::from_vector(&vector).expect("decode failed");
        assert_eq!(vector[0], 3.0);
        assert_eq!(decoded.nodes.len(), 3);
    }

    #[test]
    fn test_sequential_encoding() {
        let layers = vec![
            LayerType::Dense(128),
            LayerType::BatchNorm,
            LayerType::Activation("relu".to_string()),
            LayerType::Dropout(0.2),
            LayerType::Dense(10),
        ];
        let encoding = SequentialEncoding::new(layers);
        let vector = encoding.to_vector();
        let decoded = SequentialEncoding::from_vector(&vector).expect("decode failed");
        assert_eq!(vector[0], 5.0);
        assert_eq!(decoded.layers.len(), 5);
    }

    #[test]
    fn test_random_generation() {
        let mut rng_inst = thread_rng();
        let seq_encoding =
            SequentialEncoding::random(&mut rng_inst).expect("random generation failed");
        assert!(seq_encoding.layers.len() >= 3);
        assert!(seq_encoding.layers.len() <= 10);
    }
}