scirs2-linalg 0.4.0

Linear algebra module for SciRS2 (scirs2-linalg)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
//! Utility functions for quantization calibration
//!
//! This module contains helper functions used by both matrix and vector
//! calibration methods including min/max finding, histograms, KL divergence
//! optimization, and parameter creation.

use super::super::{QuantizationMethod, QuantizationParams};
use crate::error::LinalgResult;
use scirs2_core::ndarray::{ArrayView1, ArrayView2};
use std::fmt::Debug;

// -------------------------------------------------------------------------
// Helper functions
// -------------------------------------------------------------------------

/// Find the minimum and maximum values in a matrix
#[allow(dead_code)]
pub fn find_min_max<F>(matrix: &ArrayView2<F>) -> (f32, f32)
where
    F: scirs2_core::numeric::Float + scirs2_core::numeric::AsPrimitive<f32>,
{
    let mut min_val = f32::MAX;
    let mut max_val = f32::MIN;

    for &val in matrix.iter() {
        let val_f32 = val.as_();
        if val_f32.is_finite() {
            min_val = min_val.min(val_f32);
            max_val = max_val.max(val_f32);
        }
    }

    // Handle edge cases
    if !min_val.is_finite() || !max_val.is_finite() {
        min_val = 0.0;
        max_val = 1.0;
    }

    if min_val == max_val {
        min_val -= 1.0;
        max_val += 1.0;
    }

    (min_val, max_val)
}

/// Find the minimum and maximum values in a vector
#[allow(dead_code)]
pub fn find_min_max_vec<F>(vector: &ArrayView1<F>) -> (f32, f32)
where
    F: scirs2_core::numeric::Float + scirs2_core::numeric::AsPrimitive<f32>,
{
    let mut min_val = f32::MAX;
    let mut max_val = f32::MIN;

    for &val in vector.iter() {
        let val_f32 = val.as_();
        if val_f32.is_finite() {
            min_val = min_val.min(val_f32);
            max_val = max_val.max(val_f32);
        }
    }

    // Handle edge cases
    if !min_val.is_finite() || !max_val.is_finite() {
        min_val = 0.0;
        max_val = 1.0;
    }

    if min_val == max_val {
        min_val -= 1.0;
        max_val += 1.0;
    }

    (min_val, max_val)
}

/// Create a histogram of values from a matrix
#[allow(dead_code)]
pub fn create_histogram<F>(
    matrix: &ArrayView2<F>,
    min_val: f32,
    max_val: f32,
    num_bins: usize,
) -> Vec<usize>
where
    F: scirs2_core::numeric::Float + scirs2_core::numeric::AsPrimitive<f32>,
{
    let mut histogram = vec![0; num_bins];
    let bin_width = (max_val - min_val) / num_bins as f32;

    if bin_width == 0.0 {
        // All values are the same, put them all in the middle bin
        histogram[num_bins / 2] = matrix.len();
        return histogram;
    }

    for &_val in matrix.iter() {
        let val_f32 = _val.as_();
        if val_f32.is_finite() {
            let bin_idx = ((val_f32 - min_val) / bin_width).floor() as usize;
            let bin_idx = bin_idx.min(num_bins - 1); // Ensure we don't go out of bounds
            histogram[bin_idx] += 1;
        }
    }

    histogram
}

/// Create a histogram of values from a vector
#[allow(dead_code)]
pub fn create_histogram_vec<F>(
    vector: &ArrayView1<F>,
    min_val: f32,
    max_val: f32,
    num_bins: usize,
) -> Vec<usize>
where
    F: scirs2_core::numeric::Float + scirs2_core::numeric::AsPrimitive<f32>,
{
    let mut histogram = vec![0; num_bins];
    let bin_width = (max_val - min_val) / num_bins as f32;

    if bin_width == 0.0 {
        // All values are the same, put them all in the middle bin
        histogram[num_bins / 2] = vector.len();
        return histogram;
    }

    for &_val in vector.iter() {
        let val_f32 = _val.as_();
        if val_f32.is_finite() {
            let bin_idx = ((val_f32 - min_val) / bin_width).floor() as usize;
            let bin_idx = bin_idx.min(num_bins - 1); // Ensure we don't go out of bounds
            histogram[bin_idx] += 1;
        }
    }

    histogram
}

/// Optimize thresholds using KL divergence
#[allow(dead_code)]
pub fn optimize_thresholds_kl_divergence(
    histogram: &[usize],
    min_val: f32,
    max_val: f32,
    bits: u8,
    symmetric: bool,
) -> (f32, f32) {
    let num_bins = histogram.len();
    let bin_width = (max_val - min_val) / num_bins as f32;

    // Convert histogram to probability distribution
    let total_count = histogram.iter().sum::<usize>() as f32;
    let distribution: Vec<f32> = histogram
        .iter()
        .map(|&count| count as f32 / total_count)
        .collect();

    // Number of quantization levels
    let levels = if symmetric {
        (1 << (bits - 1)) as usize // For signed integers
    } else {
        (1 << bits) as usize // For unsigned integers
    };

    // For symmetric quantization, we want to find the optimal abs_max
    if symmetric {
        // Search for the optimal abs_max that minimizes KL divergence
        let mut best_abs_max = max_val.abs().max(min_val.abs());
        let mut min_kl = f32::MAX;

        // Try different abs_max values
        let step = (best_abs_max / 20.0).max(1e-6);
        for i in 0..40 {
            let abs_max = best_abs_max - 20.0 * step + i as f32 * step;
            if abs_max <= 0.0 {
                continue;
            }

            // Calculate quantization step
            let quantization_step = abs_max / (levels - 1) as f32;

            // Calculate KL divergence for this abs_max
            let kl = calculate_kl_divergence_symmetric(
                &distribution,
                min_val,
                max_val,
                bin_width,
                abs_max,
                quantization_step,
            );

            if kl < min_kl {
                min_kl = kl;
                best_abs_max = abs_max;
            }
        }

        // Return symmetric range
        (-best_abs_max, best_abs_max)
    } else {
        // For asymmetric quantization, find the best min and max
        let mut best_min = min_val;
        let mut best_max = max_val;
        let mut min_kl = f32::MAX;

        // Grid search for optimal min/max
        let min_step = (max_val - min_val) / 40.0;
        let max_step = min_step;

        for i in 0..10 {
            let trial_min = min_val + i as f32 * min_step;

            for j in 0..10 {
                let trial_max = max_val - j as f32 * max_step;

                if trial_min >= trial_max {
                    continue;
                }

                // Calculate quantization step
                let quantization_step = (trial_max - trial_min) / (levels - 1) as f32;

                // Calculate KL divergence for this range
                let kl = calculate_kl_divergence_asymmetric(
                    &distribution,
                    min_val,
                    max_val,
                    bin_width,
                    trial_min,
                    trial_max,
                    quantization_step,
                );

                if kl < min_kl {
                    min_kl = kl;
                    best_min = trial_min;
                    best_max = trial_max;
                }
            }
        }

        (best_min, best_max)
    }
}

/// Calculate KL divergence for symmetric quantization
#[allow(dead_code)]
fn calculate_kl_divergence_symmetric(
    distribution: &[f32],
    min_val: f32,
    _max_val: f32,
    bin_width: f32,
    abs_max: f32,
    quantization_step: f32,
) -> f32 {
    let num_bins = distribution.len();

    // Create quantized probability distribution
    let mut quantized_dist = vec![0.0; num_bins];

    for (bin_idx, &prob) in distribution.iter().enumerate() {
        // Original value at the center of this bin
        let orig_val = min_val + (bin_idx as f32 + 0.5) * bin_width;

        // Quantize the value
        let quantized_val = if orig_val > abs_max {
            abs_max
        } else if orig_val < -abs_max {
            -abs_max
        } else {
            // Round to nearest quantization step
            (orig_val / quantization_step).round() * quantization_step
        };

        // Map back to bin index
        let new_bin_idx = ((quantized_val - min_val) / bin_width).floor() as i32;

        if new_bin_idx >= 0 && new_bin_idx < num_bins as i32 {
            quantized_dist[new_bin_idx as usize] += prob;
        }
    }

    // Calculate KL divergence: sum(p * log(p / q))
    let mut kl = 0.0;
    for (i, &p) in distribution.iter().enumerate() {
        if p > 0.0 {
            let q = quantized_dist[i].max(1e-10); // Avoid division by zero
            kl += p * (p / q).ln();
        }
    }

    kl
}

/// Calculate KL divergence for asymmetric quantization
#[allow(dead_code)]
fn calculate_kl_divergence_asymmetric(
    distribution: &[f32],
    min_val: f32,
    _max_val: f32,
    bin_width: f32,
    quant_min: f32,
    quant_max: f32,
    quantization_step: f32,
) -> f32 {
    let num_bins = distribution.len();

    // Create quantized probability distribution
    let mut quantized_dist = vec![0.0; num_bins];

    for (bin_idx, &prob) in distribution.iter().enumerate() {
        // Original value at the center of this bin
        let orig_val = min_val + (bin_idx as f32 + 0.5) * bin_width;

        // Quantize the value
        let quantized_val = if orig_val > quant_max {
            quant_max
        } else if orig_val < quant_min {
            quant_min
        } else {
            // Round to nearest quantization step
            let steps = ((orig_val - quant_min) / quantization_step).round();
            quant_min + steps * quantization_step
        };

        // Map back to bin index
        let new_bin_idx = ((quantized_val - min_val) / bin_width).floor() as i32;

        if new_bin_idx >= 0 && new_bin_idx < num_bins as i32 {
            quantized_dist[new_bin_idx as usize] += prob;
        }
    }

    // Calculate KL divergence: sum(p * log(p / q))
    let mut kl = 0.0;
    for (i, &p) in distribution.iter().enumerate() {
        if p > 0.0 {
            let q = quantized_dist[i].max(1e-10); // Avoid division by zero
            kl += p * (p / q).ln();
        }
    }

    kl
}

/// Optimize symmetric scale factor using MSE
#[allow(dead_code)]
pub fn optimize_symmetric_scale<F>(matrix: &ArrayView2<F>, bits: u8, basescale: f32) -> f32
where
    F: scirs2_core::numeric::Float
        + Debug
        + scirs2_core::numeric::AsPrimitive<f32>
        + scirs2_core::numeric::FromPrimitive,
    f32: scirs2_core::numeric::AsPrimitive<F>,
{
    let num_trials = 20;
    let scales: Vec<f32> = (0..num_trials)
        .map(|i| {
            let factor = 0.5 + 1.5 * (i as f32 / (num_trials - 1) as f32);
            basescale * factor
        })
        .collect();

    let mut best_scale = basescale;
    let mut min_mse = f32::MAX;

    // Test each scale factor
    for &scale in &scales {
        // Create temporary quantization parameters
        let abs_max = matrix
            .mapv(|x| x.as_().abs())
            .fold(0.0, |a: f32, &b| a.max(b));
        let params = QuantizationParams {
            bits,
            scale,
            zero_point: 0,
            min_val: -abs_max,
            max_val: abs_max,
            method: if bits == 4 {
                QuantizationMethod::Int4
            } else {
                QuantizationMethod::Symmetric
            },
            data_type: determine_data_type(bits),
            channel_scales: None,
            channel_zero_points: None,
        };

        // Manually simulate quantization and dequantization for F type
        let matrix_f32 = matrix.mapv(|x| x.as_());
        let current_scale = params.scale;
        let dequantized = matrix_f32.mapv(|x| {
            let quantized = (x / scale)
                .round()
                .clamp(-(1 << (bits - 1)) as f32, ((1 << (bits - 1)) - 1) as f32);
            quantized * current_scale
        });

        // Calculate MSE
        let mse = (&matrix_f32 - &dequantized).mapv(|x| x * x).sum() / matrix.len() as f32;

        if mse < min_mse {
            min_mse = mse;
            best_scale = scale;
        }
    }

    best_scale
}

/// Optimize symmetric scale factor for vectors using MSE
#[allow(dead_code)]
pub fn optimize_symmetric_scale_vec<F>(_vector: &ArrayView1<F>, bits: u8, basescale: f32) -> f32
where
    F: scirs2_core::numeric::Float
        + Debug
        + scirs2_core::numeric::AsPrimitive<f32>
        + scirs2_core::numeric::FromPrimitive,
    f32: scirs2_core::numeric::AsPrimitive<F>,
{
    let num_trials = 20;
    let scales: Vec<f32> = (0..num_trials)
        .map(|i| {
            let factor = 0.5 + 1.5 * (i as f32 / (num_trials - 1) as f32);
            basescale * factor
        })
        .collect();

    let mut best_scale = basescale;
    let mut min_mse = f32::MAX;

    // Test each scale factor
    for &scale in &scales {
        // Create temporary QuantizationParams
        let abs_max = _vector
            .mapv(|x| x.as_().abs())
            .fold(0.0, |a: f32, &b| a.max(b));
        let params = QuantizationParams {
            bits,
            scale,
            zero_point: 0,
            min_val: -abs_max,
            max_val: abs_max,
            method: if bits == 4 {
                QuantizationMethod::Int4
            } else {
                QuantizationMethod::Symmetric
            },
            data_type: determine_data_type(bits),
            channel_scales: None,
            channel_zero_points: None,
        };

        // Manually simulate quantization and dequantization for F type
        let vector_f32 = _vector.mapv(|x| x.as_());
        let current_scale = params.scale;
        let dequantized = vector_f32.mapv(|x| {
            let quantized = (x / scale)
                .round()
                .clamp(-(1 << (bits - 1)) as f32, ((1 << (bits - 1)) - 1) as f32);
            quantized * current_scale
        });

        // Calculate MSE
        let mse = (&vector_f32 - &dequantized).mapv(|x| x * x).sum() / _vector.len() as f32;

        if mse < min_mse {
            min_mse = mse;
            best_scale = scale;
        }
    }

    best_scale
}

/// Optimize affine quantization parameters (scale and zero point) using MSE
#[allow(dead_code)]
pub fn optimize_affine_params<F>(
    matrix: &ArrayView2<F>,
    bits: u8,
    base_scale: f32,
    base_zero_point: i32,
) -> (f32, i32)
where
    F: scirs2_core::numeric::Float
        + Debug
        + scirs2_core::numeric::AsPrimitive<f32>
        + scirs2_core::numeric::FromPrimitive,
    f32: scirs2_core::numeric::AsPrimitive<F>,
{
    let num_scale_trials = 10;
    let num_zp_trials = 5;

    let scales: Vec<f32> = (0..num_scale_trials)
        .map(|i| {
            let factor = 0.8 + 0.4 * (i as f32 / (num_scale_trials - 1) as f32);
            base_scale * factor
        })
        .collect();

    let zero_points: Vec<i32> = (0..num_zp_trials)
        .map(|i| {
            let offset = -2 + i;
            base_zero_point + offset
        })
        .collect();

    let mut best_scale = base_scale;
    let mut best_zero_point = base_zero_point;
    let mut min_mse = f32::MAX;

    // Test each combination of scale and zero point
    for &_scale in &scales {
        for &zero_point in &zero_points {
            // Create temporary QuantizationParams
            let mut params = QuantizationParams {
                bits,
                scale: _scale,
                zero_point,
                min_val: 0.0, // Will be set by quantize_matrix
                max_val: 0.0, // Will be set by quantize_matrix
                method: QuantizationMethod::Affine,
                data_type: determine_data_type(bits),
                channel_scales: None,
                channel_zero_points: None,
            };

            // Manually simulate affine quantization and dequantization for F type
            let matrix_f32 = matrix.mapv(|x| x.as_());
            let scale = params.scale;
            let zero_point = params.zero_point;

            // Find min/max values for the matrix
            let mut min_val = f32::MAX;
            let mut max_val = f32::MIN;
            for &val in matrix_f32.iter() {
                if val.is_finite() {
                    min_val = min_val.min(val);
                    max_val = max_val.max(val);
                }
            }
            params.min_val = min_val;
            params.max_val = max_val;

            let dequantized = matrix_f32.mapv(|x| {
                let quantized = ((x / scale) + zero_point as f32)
                    .round()
                    .clamp(0.0, ((1 << bits) - 1) as f32);
                (quantized - zero_point as f32) * scale
            });

            // Calculate MSE
            let mse = (&matrix_f32 - &dequantized).mapv(|x| x * x).sum() / matrix.len() as f32;

            if mse < min_mse {
                min_mse = mse;
                best_scale = scale;
                best_zero_point = zero_point;
            }
        }
    }

    (best_scale, best_zero_point)
}

/// Optimize affine quantization parameters for vectors using MSE
#[allow(dead_code)]
pub fn optimize_affine_params_vec<F>(
    vector: &ArrayView1<F>,
    bits: u8,
    base_scale: f32,
    base_zero_point: i32,
) -> (f32, i32)
where
    F: scirs2_core::numeric::Float
        + Debug
        + scirs2_core::numeric::AsPrimitive<f32>
        + scirs2_core::numeric::FromPrimitive,
    f32: scirs2_core::numeric::AsPrimitive<F>,
{
    let num_scale_trials = 10;
    let num_zp_trials = 5;

    let scales: Vec<f32> = (0..num_scale_trials)
        .map(|i| {
            let factor = 0.8 + 0.4 * (i as f32 / (num_scale_trials - 1) as f32);
            base_scale * factor
        })
        .collect();

    let zero_points: Vec<i32> = (0..num_zp_trials)
        .map(|i| {
            let offset = -2 + i;
            base_zero_point + offset
        })
        .collect();

    let mut best_scale = base_scale;
    let mut best_zero_point = base_zero_point;
    let mut min_mse = f32::MAX;

    // Test each combination of scale and zero point
    for &_scale in &scales {
        for &zero_point in &zero_points {
            // Create temporary QuantizationParams
            let mut params = QuantizationParams {
                bits,
                scale: _scale,
                zero_point,
                min_val: 0.0, // Will be set by quantize_vector
                max_val: 0.0, // Will be set by quantize_vector
                method: QuantizationMethod::Affine,
                data_type: determine_data_type(bits),
                channel_scales: None,
                channel_zero_points: None,
            };

            // Manually simulate affine quantization and dequantization for F type
            let vector_f32 = vector.mapv(|x| x.as_());
            let scale = params.scale;
            let zero_point = params.zero_point;

            // Find min/max values for the vector
            let mut min_val = f32::MAX;
            let mut max_val = f32::MIN;
            for &val in vector_f32.iter() {
                if val.is_finite() {
                    min_val = min_val.min(val);
                    max_val = max_val.max(val);
                }
            }
            params.min_val = min_val;
            params.max_val = max_val;

            let dequantized = vector_f32.mapv(|x| {
                let quantized = ((x / scale) + zero_point as f32)
                    .round()
                    .clamp(0.0, ((1 << bits) - 1) as f32);
                (quantized - zero_point as f32) * scale
            });

            // Calculate MSE
            let mse = (&vector_f32 - &dequantized).mapv(|x| x * x).sum() / vector.len() as f32;

            if mse < min_mse {
                min_mse = mse;
                best_scale = scale;
                best_zero_point = zero_point;
            }
        }
    }

    (best_scale, best_zero_point)
}

/// Create QuantizationParams from a min-max range
#[allow(dead_code)]
pub fn create_params_from_range(
    bits: u8,
    min_val: f32,
    max_val: f32,
    symmetric: bool,
) -> LinalgResult<QuantizationParams> {
    let (method, scale, zero_point) = if symmetric {
        let abs_max = max_val.abs().max(min_val.abs());
        let scale = abs_max / ((1 << (bits - 1)) - 1) as f32;
        (QuantizationMethod::Symmetric, scale, 0)
    } else {
        let method = QuantizationMethod::Affine;
        let scale = (max_val - min_val) / ((1 << bits) - 1) as f32;
        let zero_point = (-min_val / scale).round() as i32;
        (method, scale, zero_point)
    };

    Ok(QuantizationParams {
        bits,
        scale,
        zero_point,
        min_val,
        max_val,
        method,
        data_type: determine_data_type(bits),
        channel_scales: None,
        channel_zero_points: None,
    })
}

/// Determine the appropriate data type based on bit width
#[allow(dead_code)]
pub fn determine_data_type(bits: u8) -> super::super::QuantizedDataType {
    use super::super::QuantizedDataType;

    match bits {
        4 => QuantizedDataType::Int4,     // Default to Int4 for 4-bit
        8 => QuantizedDataType::Int8,     // Default to Int8 for 8-bit
        16 => QuantizedDataType::Float16, // Default to Float16 for 16-bit
        _ => QuantizedDataType::Int8,     // Default to Int8 for other cases
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use approx::assert_relative_eq;
    use scirs2_core::ndarray::array;

    #[test]
    fn test_find_min_max() {
        let matrix = array![[1.0f32, 2.0, 3.0], [4.0, 5.0, 6.0], [7.0, 8.0, 9.0]];
        let (min_val, max_val) = find_min_max(&matrix.view());
        assert_eq!(min_val, 1.0);
        assert_eq!(max_val, 9.0);
    }

    #[test]
    fn test_find_min_max_vec() {
        let vector = array![1.0f32, 2.0, 3.0, 4.0, 5.0];
        let (min_val, max_val) = find_min_max_vec(&vector.view());
        assert_eq!(min_val, 1.0);
        assert_eq!(max_val, 5.0);
    }

    #[test]
    fn test_create_histogram() {
        let matrix = array![[1.0f32, 2.0, 3.0], [4.0, 5.0, 6.0]];
        let histogram = create_histogram(&matrix.view(), 1.0, 6.0, 5);

        // Each value should be in a different bin
        assert_eq!(histogram.iter().sum::<usize>(), 6); // Total count
        assert!(histogram.iter().all(|&count| count <= 2)); // No bin has more than 2 values
    }

    #[test]
    fn test_create_params_from_range() {
        // Test symmetric quantization
        let params = create_params_from_range(8, -5.0, 5.0, true).expect("Operation failed");
        assert_eq!(params.method, QuantizationMethod::Symmetric);
        assert_eq!(params.zero_point, 0);
        assert_relative_eq!(params.scale, 5.0 / 127.0, epsilon = 1e-6);

        // Test affine quantization
        let params = create_params_from_range(8, 1.0, 9.0, false).expect("Operation failed");
        assert_eq!(params.method, QuantizationMethod::Affine);
        assert_relative_eq!(params.scale, 8.0 / 255.0, epsilon = 1e-6);
        assert_eq!(params.zero_point, (-1.0 / params.scale).round() as i32);
    }
}