scirs2-io 0.4.2

Input/Output utilities module for SciRS2 (scirs2-io)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
//! ETL (Extract-Transform-Load) pipeline for composable data processing.
//!
//! Provides a trait-based pipeline architecture where [`Extractor`], [`Transformer`],
//! and [`Loader`] implementations can be composed into an [`ETLPipeline`].
//!
//! # Example
//!
//! ```rust,no_run
//! use scirs2_io::etl::{
//!     ETLPipeline, CSVExtractor, DeduplicateTransform, FillNullTransform, NormalizeTransform,
//! };
//! use scirs2_io::database::table::ColumnValue;
//!
//! // Build a pipeline: CSV → deduplicate → fill nulls → normalize
//! let pipeline = ETLPipeline::new()
//!     .extract(CSVExtractor::from_path("/data/raw.csv").has_header(true))
//!     .transform(DeduplicateTransform::on_column("id"))
//!     .transform(FillNullTransform::with_constant("score", ColumnValue::Float(0.0)))
//!     .transform(NormalizeTransform::min_max("score"));
//!
//! let table = pipeline.run().unwrap();
//! println!("Processed {} rows", table.row_count());
//! ```

#![allow(missing_docs)]

use crate::database::table::{
    AggFunc, ColumnSchema, ColumnType, ColumnValue, GroupBy, InMemoryTable, SortKey, TableFilter,
    TableSort, Predicate,
};
use crate::error::{IoError, Result};
use serde_json::Value as JsonValue;
use std::collections::HashMap;
use std::io::{BufRead, BufReader};

// ─── Extractor trait ─────────────────────────────────────────────────────────

/// Extracts data from a source and returns an [`InMemoryTable`].
pub trait Extractor: Send + Sync {
    /// Extract data and return an [`InMemoryTable`].
    fn extract(&self) -> Result<InMemoryTable>;

    /// Optional human-readable description.
    fn description(&self) -> &str {
        "extractor"
    }
}

// ─── Transformer trait ───────────────────────────────────────────────────────

/// Transforms an [`InMemoryTable`] and returns a new table.
pub trait Transformer: Send + Sync {
    /// Apply the transformation.
    fn transform(&self, table: InMemoryTable) -> Result<InMemoryTable>;

    /// Optional human-readable description.
    fn description(&self) -> &str {
        "transformer"
    }
}

// ─── Loader trait ────────────────────────────────────────────────────────────

/// Loads an [`InMemoryTable`] into a sink.
pub trait Loader: Send + Sync {
    /// Load the table into the target sink.
    fn load(&self, table: &InMemoryTable) -> Result<()>;

    /// Optional human-readable description.
    fn description(&self) -> &str {
        "loader"
    }
}

// ─── ETLPipeline ─────────────────────────────────────────────────────────────

/// A composable ETL pipeline.
///
/// Assembles an optional extractor, a chain of transformers, and an optional loader.
pub struct ETLPipeline {
    extractor: Option<Box<dyn Extractor>>,
    transformers: Vec<Box<dyn Transformer>>,
    loader: Option<Box<dyn Loader>>,
}

impl Default for ETLPipeline {
    fn default() -> Self {
        Self::new()
    }
}

impl ETLPipeline {
    /// Create an empty pipeline.
    pub fn new() -> Self {
        Self {
            extractor: None,
            transformers: Vec::new(),
            loader: None,
        }
    }

    /// Set the extractor.
    pub fn extract(mut self, e: impl Extractor + 'static) -> Self {
        self.extractor = Some(Box::new(e));
        self
    }

    /// Add a transformer to the chain.
    pub fn transform(mut self, t: impl Transformer + 'static) -> Self {
        self.transformers.push(Box::new(t));
        self
    }

    /// Set the loader.
    pub fn load_to(mut self, l: impl Loader + 'static) -> Self {
        self.loader = Some(Box::new(l));
        self
    }

    /// Run the pipeline and return the final table.
    ///
    /// 1. Calls the extractor (if set) to get the initial table.
    /// 2. Applies each transformer in order.
    /// 3. Calls the loader (if set) with the final table.
    pub fn run(&self) -> Result<InMemoryTable> {
        let mut table = match &self.extractor {
            Some(e) => e.extract()?,
            None => {
                return Err(IoError::ConfigError(
                    "ETLPipeline has no extractor set".to_string(),
                ))
            }
        };

        for transformer in &self.transformers {
            table = transformer.transform(table)?;
        }

        if let Some(loader) = &self.loader {
            loader.load(&table)?;
        }

        Ok(table)
    }

    /// Run the pipeline starting from a pre-extracted table (skips extractor).
    pub fn run_from(&self, input: InMemoryTable) -> Result<InMemoryTable> {
        let mut table = input;
        for transformer in &self.transformers {
            table = transformer.transform(table)?;
        }
        if let Some(loader) = &self.loader {
            loader.load(&table)?;
        }
        Ok(table)
    }
}

// ─── CSVExtractor ────────────────────────────────────────────────────────────

/// Extracts data from a CSV file.
pub struct CSVExtractor {
    path: String,
    has_header: bool,
    delimiter: char,
    column_types: Option<Vec<(String, ColumnType)>>,
    max_rows: Option<usize>,
    skip_rows: usize,
}

impl CSVExtractor {
    /// Create from a file path.
    pub fn from_path(path: impl Into<String>) -> Self {
        Self {
            path: path.into(),
            has_header: true,
            delimiter: ',',
            column_types: None,
            max_rows: None,
            skip_rows: 0,
        }
    }

    /// Set whether the file has a header row.
    pub fn has_header(mut self, v: bool) -> Self {
        self.has_header = v;
        self
    }

    /// Set the delimiter character.
    pub fn delimiter(mut self, d: char) -> Self {
        self.delimiter = d;
        self
    }

    /// Override column types.
    pub fn column_types(mut self, types: Vec<(String, ColumnType)>) -> Self {
        self.column_types = Some(types);
        self
    }

    /// Limit the number of data rows read.
    pub fn max_rows(mut self, n: usize) -> Self {
        self.max_rows = Some(n);
        self
    }

    /// Skip `n` rows before the header.
    pub fn skip_rows(mut self, n: usize) -> Self {
        self.skip_rows = n;
        self
    }

    fn split_row(&self, line: &str) -> Vec<String> {
        // Minimal CSV splitter supporting quoted fields
        let mut fields = Vec::new();
        let mut current = String::new();
        let mut in_quotes = false;
        let mut chars = line.chars().peekable();

        while let Some(c) = chars.next() {
            if c == '"' {
                if in_quotes {
                    if chars.peek() == Some(&'"') {
                        // Escaped quote
                        chars.next();
                        current.push('"');
                    } else {
                        in_quotes = false;
                    }
                } else {
                    in_quotes = true;
                }
            } else if c == self.delimiter && !in_quotes {
                fields.push(current.trim().to_string());
                current = String::new();
            } else {
                current.push(c);
            }
        }
        fields.push(current.trim().to_string());
        fields
    }
}

impl Extractor for CSVExtractor {
    fn extract(&self) -> Result<InMemoryTable> {
        let file = std::fs::File::open(&self.path).map_err(IoError::Io)?;
        let reader = BufReader::new(file);
        let mut lines = reader.lines();

        // Skip initial rows
        for _ in 0..self.skip_rows {
            lines.next();
        }

        // Parse header
        let headers: Vec<String> = if self.has_header {
            match lines.next() {
                Some(line) => self.split_row(&line.map_err(IoError::Io)?),
                None => {
                    return Err(IoError::ParseError("CSV file is empty".to_string()));
                }
            }
        } else {
            Vec::new() // Will be filled after first data row
        };

        let col_types: Vec<ColumnType> = if let Some(ref types) = self.column_types {
            types.iter().map(|(_, t)| t.clone()).collect()
        } else {
            vec![] // Will infer as Utf8
        };

        let mut table: Option<InMemoryTable> = None;
        let mut row_count = 0usize;
        let mut header_resolved = false;

        for line_result in lines {
            if let Some(max) = self.max_rows {
                if row_count >= max {
                    break;
                }
            }

            let line = line_result.map_err(IoError::Io)?;
            let line = line.trim();
            if line.is_empty() {
                continue;
            }

            let fields = self.split_row(line);

            // First data row: resolve schema
            if !header_resolved {
                let final_headers: Vec<String> = if self.has_header {
                    headers.clone()
                } else {
                    (0..fields.len())
                        .map(|i| format!("col_{i}"))
                        .collect()
                };

                let schema: Vec<(String, ColumnType)> = final_headers
                    .iter()
                    .enumerate()
                    .map(|(i, name)| {
                        let ct = col_types.get(i).cloned().unwrap_or(ColumnType::Utf8);
                        (name.clone(), ct)
                    })
                    .collect();

                table = Some(InMemoryTable::new(schema));
                header_resolved = true;
            }

            if let Some(ref mut t) = table {
                // Pad or truncate fields to column count
                let mut row: Vec<ColumnValue> = Vec::with_capacity(t.column_count());
                for (i, col) in t.columns.iter().enumerate() {
                    let val = fields.get(i).map(|s| s.as_str()).unwrap_or("");
                    row.push(parse_csv_value(val, &col.col_type));
                }
                t.push_row(&row)?;
                row_count += 1;
            }
        }

        match table {
            Some(t) => Ok(t),
            None => {
                // Empty file with header — return empty table
                let schema: Vec<(String, ColumnType)> = headers
                    .iter()
                    .map(|h| (h.clone(), ColumnType::Utf8))
                    .collect();
                Ok(InMemoryTable::new(schema))
            }
        }
    }

    fn description(&self) -> &str {
        "csv_extractor"
    }
}

fn parse_csv_value(s: &str, col_type: &ColumnType) -> ColumnValue {
    if s.is_empty() {
        return ColumnValue::Null;
    }
    match col_type {
        ColumnType::Int64 => s
            .parse::<i64>()
            .map(ColumnValue::Int)
            .unwrap_or(ColumnValue::Null),
        ColumnType::Float64 => s
            .parse::<f64>()
            .map(ColumnValue::Float)
            .unwrap_or(ColumnValue::Null),
        ColumnType::Boolean => match s.to_lowercase().as_str() {
            "true" | "1" | "yes" => ColumnValue::Boolean(true),
            "false" | "0" | "no" => ColumnValue::Boolean(false),
            _ => ColumnValue::Null,
        },
        ColumnType::Utf8 => ColumnValue::Utf8(s.to_string()),
        ColumnType::Nullable(inner) => parse_csv_value(s, inner),
    }
}

// ─── JSONExtractor ───────────────────────────────────────────────────────────

/// Extracts data from a JSON Lines (NDJSON) or JSON array file.
pub struct JSONExtractor {
    path: String,
    is_jsonl: bool,
    column_types: HashMap<String, ColumnType>,
    max_rows: Option<usize>,
}

impl JSONExtractor {
    /// Read a JSON Lines file (one JSON object per line).
    pub fn jsonl(path: impl Into<String>) -> Self {
        Self {
            path: path.into(),
            is_jsonl: true,
            column_types: HashMap::new(),
            max_rows: None,
        }
    }

    /// Read a JSON array file (`[{...}, {...}, ...]`).
    pub fn json_array(path: impl Into<String>) -> Self {
        Self {
            path: path.into(),
            is_jsonl: false,
            column_types: HashMap::new(),
            max_rows: None,
        }
    }

    /// Override the column type for a specific column name.
    pub fn column_type(mut self, name: impl Into<String>, ct: ColumnType) -> Self {
        self.column_types.insert(name.into(), ct);
        self
    }

    /// Limit rows.
    pub fn max_rows(mut self, n: usize) -> Self {
        self.max_rows = Some(n);
        self
    }

    fn json_objects_from_path(&self) -> Result<Vec<serde_json::Map<String, JsonValue>>> {
        let content = std::fs::read_to_string(&self.path).map_err(IoError::Io)?;
        if self.is_jsonl {
            let mut objects = Vec::new();
            for line in content.lines() {
                let line = line.trim();
                if line.is_empty() {
                    continue;
                }
                let v: JsonValue = serde_json::from_str(line)
                    .map_err(|e| IoError::ParseError(e.to_string()))?;
                if let JsonValue::Object(obj) = v {
                    objects.push(obj);
                }
                if let Some(max) = self.max_rows {
                    if objects.len() >= max {
                        break;
                    }
                }
            }
            Ok(objects)
        } else {
            let v: JsonValue =
                serde_json::from_str(&content).map_err(|e| IoError::ParseError(e.to_string()))?;
            match v {
                JsonValue::Array(arr) => {
                    let limit = self.max_rows.unwrap_or(arr.len()).min(arr.len());
                    Ok(arr[..limit]
                        .iter()
                        .filter_map(|item| {
                            if let JsonValue::Object(obj) = item {
                                Some(obj.clone())
                            } else {
                                None
                            }
                        })
                        .collect())
                }
                _ => Err(IoError::ParseError(
                    "Expected JSON array at top level".to_string(),
                )),
            }
        }
    }
}

impl Extractor for JSONExtractor {
    fn extract(&self) -> Result<InMemoryTable> {
        let objects = self.json_objects_from_path()?;
        if objects.is_empty() {
            return Ok(InMemoryTable::new(vec![]));
        }

        // Collect all column names in order
        let mut col_names: Vec<String> = Vec::new();
        for obj in &objects {
            for key in obj.keys() {
                if !col_names.contains(key) {
                    col_names.push(key.clone());
                }
            }
        }

        // Determine column types
        let schema: Vec<(String, ColumnType)> = col_names
            .iter()
            .map(|name| {
                let ct = self
                    .column_types
                    .get(name)
                    .cloned()
                    .unwrap_or(ColumnType::Utf8);
                (name.clone(), ct)
            })
            .collect();

        let mut table = InMemoryTable::new(schema);

        for obj in &objects {
            let row: Vec<ColumnValue> = table
                .columns
                .iter()
                .map(|col| {
                    obj.get(&col.name)
                        .map(|v| json_to_column_value(v, &col.col_type))
                        .unwrap_or(ColumnValue::Null)
                })
                .collect();
            table.push_row(&row)?;
        }

        Ok(table)
    }

    fn description(&self) -> &str {
        "json_extractor"
    }
}

fn json_to_column_value(v: &JsonValue, ct: &ColumnType) -> ColumnValue {
    match (ct, v) {
        (_, JsonValue::Null) => ColumnValue::Null,
        (ColumnType::Int64, JsonValue::Number(n)) => {
            ColumnValue::Int(n.as_i64().unwrap_or_default())
        }
        (ColumnType::Float64, JsonValue::Number(n)) => {
            ColumnValue::Float(n.as_f64().unwrap_or_default())
        }
        (ColumnType::Boolean, JsonValue::Bool(b)) => ColumnValue::Boolean(*b),
        (ColumnType::Utf8, JsonValue::String(s)) => ColumnValue::Utf8(s.clone()),
        (ColumnType::Utf8, other) => ColumnValue::Utf8(other.to_string()),
        (ColumnType::Nullable(inner), val) => json_to_column_value(val, inner),
        _ => ColumnValue::Utf8(v.to_string()),
    }
}

// ─── ParquetExtractor ────────────────────────────────────────────────────────

/// Extracts data from a Parquet-lite file (scirs2-io native format).
pub struct ParquetExtractor {
    path: String,
    max_rows: Option<usize>,
}

impl ParquetExtractor {
    /// Create from path.
    pub fn from_path(path: impl Into<String>) -> Self {
        Self {
            path: path.into(),
            max_rows: None,
        }
    }

    /// Limit rows.
    pub fn max_rows(mut self, n: usize) -> Self {
        self.max_rows = Some(n);
        self
    }
}

impl Extractor for ParquetExtractor {
    fn extract(&self) -> Result<InMemoryTable> {
        use crate::parquet_lite::{ColumnData, ColumnType as PqType, ParquetReader};

        let bytes = std::fs::read(&self.path).map_err(IoError::Io)?;
        let (schema, all_col_data) = ParquetReader::read_typed(&bytes)
            .map_err(|e| IoError::ParseError(format!("Parquet read error: {e}")))?;

        let table_schema: Vec<(String, ColumnType)> = schema
            .columns
            .iter()
            .map(|(name, pq_type)| {
                let ct = match pq_type {
                    PqType::Float64 | PqType::Float32 => ColumnType::Float64,
                    PqType::Int64 | PqType::Int32 => ColumnType::Int64,
                    PqType::Boolean => ColumnType::Boolean,
                    _ => ColumnType::Utf8,
                };
                (name.clone(), ct)
            })
            .collect();

        let mut table = InMemoryTable::new(table_schema);

        let row_count = all_col_data
            .first()
            .map(|c| c.len())
            .unwrap_or(0);

        let limit = self.max_rows.unwrap_or(row_count).min(row_count);

        for row_idx in 0..limit {
            let row: Vec<ColumnValue> = all_col_data
                .iter()
                .map(|col| match col {
                    ColumnData::Float64(v) => v
                        .get(row_idx)
                        .copied()
                        .map(ColumnValue::Float)
                        .unwrap_or(ColumnValue::Null),
                    ColumnData::Float32(v) => v
                        .get(row_idx)
                        .copied()
                        .map(|x| ColumnValue::Float(x as f64))
                        .unwrap_or(ColumnValue::Null),
                    ColumnData::Int64(v) => v
                        .get(row_idx)
                        .copied()
                        .map(ColumnValue::Int)
                        .unwrap_or(ColumnValue::Null),
                    ColumnData::Int32(v) => v
                        .get(row_idx)
                        .copied()
                        .map(|x| ColumnValue::Int(x as i64))
                        .unwrap_or(ColumnValue::Null),
                    ColumnData::Boolean(v) => v
                        .get(row_idx)
                        .copied()
                        .map(ColumnValue::Boolean)
                        .unwrap_or(ColumnValue::Null),
                    ColumnData::Utf8(v) => v
                        .get(row_idx)
                        .cloned()
                        .map(ColumnValue::Utf8)
                        .unwrap_or(ColumnValue::Null),
                })
                .collect();
            table.push_row(&row)?;
        }

        Ok(table)
    }

    fn description(&self) -> &str {
        "parquet_extractor"
    }
}
// ─── InMemoryExtractor ───────────────────────────────────────────────────────

/// Wraps an existing [`InMemoryTable`] as an extractor.
pub struct InMemoryExtractor {
    table: InMemoryTable,
}

impl InMemoryExtractor {
    /// Create from an existing table.
    pub fn new(table: InMemoryTable) -> Self {
        Self { table }
    }
}

impl Extractor for InMemoryExtractor {
    fn extract(&self) -> Result<InMemoryTable> {
        Ok(self.table.clone())
    }

    fn description(&self) -> &str {
        "in_memory_extractor"
    }
}

// ─── DeduplicateTransform ────────────────────────────────────────────────────

/// Removes duplicate rows based on a key column or all columns.
pub struct DeduplicateTransform {
    key_columns: Option<Vec<String>>,
}

impl DeduplicateTransform {
    /// Deduplicate on all columns.
    pub fn all_columns() -> Self {
        Self { key_columns: None }
    }

    /// Deduplicate based on a single column.
    pub fn on_column(col: impl Into<String>) -> Self {
        Self {
            key_columns: Some(vec![col.into()]),
        }
    }

    /// Deduplicate based on multiple columns.
    pub fn on_columns(cols: Vec<String>) -> Self {
        Self {
            key_columns: Some(cols),
        }
    }
}

impl Transformer for DeduplicateTransform {
    fn transform(&self, table: InMemoryTable) -> Result<InMemoryTable> {
        let key_indices: Vec<usize> = match &self.key_columns {
            Some(cols) => cols
                .iter()
                .map(|c| {
                    table.column_index(c).ok_or_else(|| {
                        IoError::ValidationError(format!(
                            "Deduplicate column '{}' not found",
                            c
                        ))
                    })
                })
                .collect::<Result<Vec<_>>>()?,
            None => (0..table.column_count()).collect(),
        };

        let mut seen: std::collections::HashSet<Vec<String>> =
            std::collections::HashSet::new();
        let mut new_rows: Vec<Vec<ColumnValue>> = Vec::new();

        for row in &table.rows {
            let key: Vec<String> = key_indices.iter().map(|&i| row[i].to_string()).collect();
            if seen.insert(key) {
                new_rows.push(row.clone());
            }
        }

        Ok(InMemoryTable {
            columns: table.columns,
            rows: new_rows,
            name: table.name,
        })
    }

    fn description(&self) -> &str {
        "deduplicate_transform"
    }
}

// ─── FillNullTransform ───────────────────────────────────────────────────────

/// Fills NULL values with a constant or aggregated value.
pub struct FillNullTransform {
    column: String,
    strategy: FillNullStrategy,
}

/// Strategy for filling null values.
#[derive(Debug, Clone)]
pub enum FillNullStrategy {
    /// Fill with a constant value
    Constant(ColumnValue),
    /// Fill with the column mean
    Mean,
    /// Fill with the column median
    Median,
    /// Fill forward (use previous non-null value)
    ForwardFill,
    /// Fill backward (use next non-null value)
    BackwardFill,
}

impl FillNullTransform {
    /// Fill nulls in `column` with a constant.
    pub fn with_constant(column: impl Into<String>, value: ColumnValue) -> Self {
        Self {
            column: column.into(),
            strategy: FillNullStrategy::Constant(value),
        }
    }

    /// Fill nulls in `column` with the column mean.
    pub fn with_mean(column: impl Into<String>) -> Self {
        Self {
            column: column.into(),
            strategy: FillNullStrategy::Mean,
        }
    }

    /// Fill nulls in `column` with the column median.
    pub fn with_median(column: impl Into<String>) -> Self {
        Self {
            column: column.into(),
            strategy: FillNullStrategy::Median,
        }
    }

    /// Forward fill.
    pub fn forward_fill(column: impl Into<String>) -> Self {
        Self {
            column: column.into(),
            strategy: FillNullStrategy::ForwardFill,
        }
    }

    /// Backward fill.
    pub fn backward_fill(column: impl Into<String>) -> Self {
        Self {
            column: column.into(),
            strategy: FillNullStrategy::BackwardFill,
        }
    }
}

impl Transformer for FillNullTransform {
    fn transform(&self, mut table: InMemoryTable) -> Result<InMemoryTable> {
        let col_idx = table.column_index(&self.column).ok_or_else(|| {
            IoError::ValidationError(format!(
                "FillNull column '{}' not found",
                self.column
            ))
        })?;

        let fill_value = match &self.strategy {
            FillNullStrategy::Constant(v) => v.clone(),
            FillNullStrategy::Mean => {
                let vals: Vec<f64> = table
                    .rows
                    .iter()
                    .filter_map(|r| r[col_idx].as_f64())
                    .collect();
                if vals.is_empty() {
                    ColumnValue::Null
                } else {
                    ColumnValue::Float(vals.iter().sum::<f64>() / vals.len() as f64)
                }
            }
            FillNullStrategy::Median => {
                let mut vals: Vec<f64> = table
                    .rows
                    .iter()
                    .filter_map(|r| r[col_idx].as_f64())
                    .collect();
                if vals.is_empty() {
                    ColumnValue::Null
                } else {
                    vals.sort_by(|a, b| a.partial_cmp(b).unwrap_or(std::cmp::Ordering::Equal));
                    let mid = vals.len() / 2;
                    let median = if vals.len() % 2 == 0 {
                        (vals[mid - 1] + vals[mid]) / 2.0
                    } else {
                        vals[mid]
                    };
                    ColumnValue::Float(median)
                }
            }
            FillNullStrategy::ForwardFill => {
                let mut last_non_null: Option<ColumnValue> = None;
                for row in table.rows.iter_mut() {
                    if matches!(row[col_idx], ColumnValue::Null) {
                        if let Some(ref fill) = last_non_null {
                            row[col_idx] = fill.clone();
                        }
                    } else {
                        last_non_null = Some(row[col_idx].clone());
                    }
                }
                return Ok(table);
            }
            FillNullStrategy::BackwardFill => {
                let mut next_non_null: Option<ColumnValue> = None;
                for row in table.rows.iter_mut().rev() {
                    if matches!(row[col_idx], ColumnValue::Null) {
                        if let Some(ref fill) = next_non_null {
                            row[col_idx] = fill.clone();
                        }
                    } else {
                        next_non_null = Some(row[col_idx].clone());
                    }
                }
                return Ok(table);
            }
        };

        for row in table.rows.iter_mut() {
            if matches!(row[col_idx], ColumnValue::Null) {
                row[col_idx] = fill_value.clone();
            }
        }

        Ok(table)
    }

    fn description(&self) -> &str {
        "fill_null_transform"
    }
}

// ─── NormalizeTransform ──────────────────────────────────────────────────────

/// Normalizes a numeric column to [0, 1] (min-max) or z-score.
pub struct NormalizeTransform {
    column: String,
    method: NormMethod,
}

/// Normalization method.
#[derive(Debug, Clone)]
pub enum NormMethod {
    /// Min-max scaling to [0, 1]
    MinMax,
    /// Z-score normalization (subtract mean, divide by std)
    ZScore,
    /// Scale to [-1, 1]
    MaxAbs,
}

impl NormalizeTransform {
    /// Min-max normalization.
    pub fn min_max(column: impl Into<String>) -> Self {
        Self {
            column: column.into(),
            method: NormMethod::MinMax,
        }
    }

    /// Z-score normalization.
    pub fn z_score(column: impl Into<String>) -> Self {
        Self {
            column: column.into(),
            method: NormMethod::ZScore,
        }
    }

    /// Max-abs normalization to [-1, 1].
    pub fn max_abs(column: impl Into<String>) -> Self {
        Self {
            column: column.into(),
            method: NormMethod::MaxAbs,
        }
    }
}

impl Transformer for NormalizeTransform {
    fn transform(&self, mut table: InMemoryTable) -> Result<InMemoryTable> {
        let col_idx = table.column_index(&self.column).ok_or_else(|| {
            IoError::ValidationError(format!(
                "Normalize column '{}' not found",
                self.column
            ))
        })?;

        let vals: Vec<f64> = table
            .rows
            .iter()
            .filter_map(|r| r[col_idx].as_f64())
            .collect();

        if vals.is_empty() {
            return Ok(table);
        }

        match &self.method {
            NormMethod::MinMax => {
                let min = vals.iter().cloned().fold(f64::INFINITY, f64::min);
                let max = vals.iter().cloned().fold(f64::NEG_INFINITY, f64::max);
                let range = max - min;
                if range.abs() < f64::EPSILON {
                    return Ok(table); // All same value; no-op
                }
                for row in table.rows.iter_mut() {
                    if let Some(f) = row[col_idx].as_f64() {
                        row[col_idx] = ColumnValue::Float((f - min) / range);
                    }
                }
            }
            NormMethod::ZScore => {
                let n = vals.len() as f64;
                let mean = vals.iter().sum::<f64>() / n;
                let variance = vals.iter().map(|v| (v - mean).powi(2)).sum::<f64>() / n;
                let std_dev = variance.sqrt();
                if std_dev < f64::EPSILON {
                    return Ok(table);
                }
                for row in table.rows.iter_mut() {
                    if let Some(f) = row[col_idx].as_f64() {
                        row[col_idx] = ColumnValue::Float((f - mean) / std_dev);
                    }
                }
            }
            NormMethod::MaxAbs => {
                let max_abs = vals.iter().map(|v| v.abs()).fold(0.0f64, f64::max);
                if max_abs < f64::EPSILON {
                    return Ok(table);
                }
                for row in table.rows.iter_mut() {
                    if let Some(f) = row[col_idx].as_f64() {
                        row[col_idx] = ColumnValue::Float(f / max_abs);
                    }
                }
            }
        }

        Ok(table)
    }

    fn description(&self) -> &str {
        "normalize_transform"
    }
}

// ─── FilterTransform ────────────────────────────────────────────────────────

/// Apply a predicate-based row filter as a transformer step.
pub struct FilterTransform {
    predicate: Predicate,
}

impl FilterTransform {
    /// Create a filter with the given predicate.
    pub fn new(predicate: Predicate) -> Self {
        Self { predicate }
    }
}

impl Transformer for FilterTransform {
    fn transform(&self, table: InMemoryTable) -> Result<InMemoryTable> {
        TableFilter::new(&table)
            .predicate(self.predicate.clone())
            .apply()
    }

    fn description(&self) -> &str {
        "filter_transform"
    }
}

// ─── SortTransform ──────────────────────────────────────────────────────────

/// Sort the table as a transformer step.
pub struct SortTransform {
    keys: Vec<SortKey>,
}

impl SortTransform {
    /// Create a sort transform with the given keys.
    pub fn new(keys: Vec<SortKey>) -> Self {
        Self { keys }
    }
}

impl Transformer for SortTransform {
    fn transform(&self, table: InMemoryTable) -> Result<InMemoryTable> {
        TableSort::sort(&table, &self.keys)
    }

    fn description(&self) -> &str {
        "sort_transform"
    }
}

// ─── RenameTransform ────────────────────────────────────────────────────────

/// Rename columns in the table.
pub struct RenameTransform {
    renames: HashMap<String, String>,
}

impl RenameTransform {
    /// Create a rename transformer.
    pub fn new(renames: HashMap<String, String>) -> Self {
        Self { renames }
    }

    /// Single column rename.
    pub fn one(from: impl Into<String>, to: impl Into<String>) -> Self {
        let mut m = HashMap::new();
        m.insert(from.into(), to.into());
        Self { renames: m }
    }
}

impl Transformer for RenameTransform {
    fn transform(&self, mut table: InMemoryTable) -> Result<InMemoryTable> {
        for col in table.columns.iter_mut() {
            if let Some(new_name) = self.renames.get(&col.name) {
                col.name = new_name.clone();
            }
        }
        Ok(table)
    }

    fn description(&self) -> &str {
        "rename_transform"
    }
}

// ─── CastTransform ──────────────────────────────────────────────────────────

/// Cast a column to a different type.
pub struct CastTransform {
    column: String,
    target_type: ColumnType,
}

impl CastTransform {
    /// Create a cast transformer.
    pub fn new(column: impl Into<String>, target_type: ColumnType) -> Self {
        Self {
            column: column.into(),
            target_type,
        }
    }
}

impl Transformer for CastTransform {
    fn transform(&self, mut table: InMemoryTable) -> Result<InMemoryTable> {
        let col_idx = table.column_index(&self.column).ok_or_else(|| {
            IoError::ValidationError(format!("Cast column '{}' not found", self.column))
        })?;

        for row in table.rows.iter_mut() {
            let new_val = cast_value(&row[col_idx], &self.target_type);
            row[col_idx] = new_val;
        }

        // Update schema type
        table.columns[col_idx].col_type = self.target_type.clone();
        Ok(table)
    }

    fn description(&self) -> &str {
        "cast_transform"
    }
}

fn cast_value(val: &ColumnValue, target: &ColumnType) -> ColumnValue {
    match (target, val) {
        (_, ColumnValue::Null) => ColumnValue::Null,
        (ColumnType::Int64, ColumnValue::Float(f)) => ColumnValue::Int(*f as i64),
        (ColumnType::Int64, ColumnValue::Boolean(b)) => ColumnValue::Int(if *b { 1 } else { 0 }),
        (ColumnType::Int64, ColumnValue::Utf8(s)) => s
            .parse::<i64>()
            .map(ColumnValue::Int)
            .unwrap_or(ColumnValue::Null),
        (ColumnType::Float64, ColumnValue::Int(i)) => ColumnValue::Float(*i as f64),
        (ColumnType::Float64, ColumnValue::Boolean(b)) => {
            ColumnValue::Float(if *b { 1.0 } else { 0.0 })
        }
        (ColumnType::Float64, ColumnValue::Utf8(s)) => s
            .parse::<f64>()
            .map(ColumnValue::Float)
            .unwrap_or(ColumnValue::Null),
        (ColumnType::Boolean, ColumnValue::Int(i)) => ColumnValue::Boolean(*i != 0),
        (ColumnType::Boolean, ColumnValue::Float(f)) => ColumnValue::Boolean(*f != 0.0),
        (ColumnType::Boolean, ColumnValue::Utf8(s)) => match s.to_lowercase().as_str() {
            "true" | "1" | "yes" => ColumnValue::Boolean(true),
            _ => ColumnValue::Boolean(false),
        },
        (ColumnType::Utf8, v) => ColumnValue::Utf8(v.to_string()),
        _ => val.clone(),
    }
}

// ─── AggregateTransform ──────────────────────────────────────────────────────

/// Group-by aggregation as a transformer step.
pub struct AggregateTransform {
    group_cols: Vec<String>,
    agg_funcs: Vec<AggFunc>,
}

impl AggregateTransform {
    /// Create an aggregate transformer.
    pub fn new(group_cols: Vec<String>, agg_funcs: Vec<AggFunc>) -> Self {
        Self {
            group_cols,
            agg_funcs,
        }
    }
}

impl Transformer for AggregateTransform {
    fn transform(&self, table: InMemoryTable) -> Result<InMemoryTable> {
        let mut gb = GroupBy::new(&table, self.group_cols.clone());
        for f in &self.agg_funcs {
            gb = gb.agg(f.clone());
        }
        gb.apply()
    }

    fn description(&self) -> &str {
        "aggregate_transform"
    }
}

// ─── InMemoryLoader ──────────────────────────────────────────────────────────

/// Loads the result into an [`InMemoryTable`] stored in a `Mutex`.
pub struct InMemoryLoader {
    target: std::sync::Arc<std::sync::Mutex<Option<InMemoryTable>>>,
}

impl InMemoryLoader {
    /// Create a new in-memory loader.
    pub fn new() -> (Self, std::sync::Arc<std::sync::Mutex<Option<InMemoryTable>>>) {
        let target = std::sync::Arc::new(std::sync::Mutex::new(None));
        let loader = Self {
            target: target.clone(),
        };
        (loader, target)
    }
}

impl Default for InMemoryLoader {
    fn default() -> Self {
        Self {
            target: std::sync::Arc::new(std::sync::Mutex::new(None)),
        }
    }
}

impl Loader for InMemoryLoader {
    fn load(&self, table: &InMemoryTable) -> Result<()> {
        let mut guard = self
            .target
            .lock()
            .map_err(|e| IoError::Other(format!("InMemoryLoader lock error: {e}")))?;
        *guard = Some(table.clone());
        Ok(())
    }

    fn description(&self) -> &str {
        "in_memory_loader"
    }
}

// ─── CSVLoader ───────────────────────────────────────────────────────────────

/// Saves the result to a CSV file.
pub struct CSVLoader {
    path: String,
    write_header: bool,
    delimiter: char,
}

impl CSVLoader {
    /// Create a CSV loader.
    pub fn new(path: impl Into<String>) -> Self {
        Self {
            path: path.into(),
            write_header: true,
            delimiter: ',',
        }
    }

    /// Set whether to write a header row.
    pub fn write_header(mut self, v: bool) -> Self {
        self.write_header = v;
        self
    }

    /// Set the delimiter.
    pub fn delimiter(mut self, d: char) -> Self {
        self.delimiter = d;
        self
    }
}

impl Loader for CSVLoader {
    fn load(&self, table: &InMemoryTable) -> Result<()> {
        use std::io::Write;
        let file = std::fs::File::create(&self.path).map_err(IoError::Io)?;
        let mut writer = std::io::BufWriter::new(file);

        if self.write_header {
            let header: Vec<String> = table.columns.iter().map(|c| c.name.clone()).collect();
            writeln!(writer, "{}", header.join(&self.delimiter.to_string()))
                .map_err(IoError::Io)?;
        }

        for row in &table.rows {
            let fields: Vec<String> = row
                .iter()
                .map(|v| {
                    let s = v.to_string();
                    if s.contains(self.delimiter) || s.contains('"') || s.contains('\n') {
                        format!("\"{}\"", s.replace('"', "\"\""))
                    } else {
                        s
                    }
                })
                .collect();
            writeln!(writer, "{}", fields.join(&self.delimiter.to_string()))
                .map_err(IoError::Io)?;
        }

        writer.flush().map_err(IoError::Io)?;
        Ok(())
    }

    fn description(&self) -> &str {
        "csv_loader"
    }
}

// ─── JSONLinesLoader ─────────────────────────────────────────────────────────

/// Saves the result to a JSON Lines file.
pub struct JSONLinesLoader {
    path: String,
}

impl JSONLinesLoader {
    /// Create a JSON Lines loader.
    pub fn new(path: impl Into<String>) -> Self {
        Self { path: path.into() }
    }
}

impl Loader for JSONLinesLoader {
    fn load(&self, table: &InMemoryTable) -> Result<()> {
        use std::io::Write;
        let file = std::fs::File::create(&self.path).map_err(IoError::Io)?;
        let mut writer = std::io::BufWriter::new(file);

        for row in &table.rows {
            let obj: serde_json::Map<String, JsonValue> = table
                .columns
                .iter()
                .zip(row.iter())
                .map(|(col, val)| (col.name.clone(), val.to_json()))
                .collect();
            let line = serde_json::to_string(&obj)
                .map_err(|e| IoError::SerializationError(e.to_string()))?;
            writeln!(writer, "{line}").map_err(IoError::Io)?;
        }
        writer.flush().map_err(IoError::Io)?;
        Ok(())
    }

    fn description(&self) -> &str {
        "jsonlines_loader"
    }
}

// ─── Tests ───────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;
    use std::io::Write;

    fn write_temp_csv(content: &str) -> String {
        let path = std::env::temp_dir()
            .join(format!("etl_test_{}.csv", uuid::Uuid::new_v4()))
            .to_str()
            .expect("temp path")
            .to_string();
        let mut f = std::fs::File::create(&path).unwrap();
        f.write_all(content.as_bytes()).unwrap();
        path
    }

    #[test]
    fn test_csv_extractor_basic() {
        let content = "id,name,score\n1,Alice,95.0\n2,Bob,82.5\n3,Carol,91.0\n";
        let path = write_temp_csv(content);
        let extractor = CSVExtractor::from_path(&path).has_header(true);
        let table = extractor.extract().unwrap();
        assert_eq!(table.row_count(), 3);
        assert_eq!(table.column_count(), 3);
        let _ = std::fs::remove_file(&path);
    }

    #[test]
    fn test_deduplicate_transform() {
        let mut t = InMemoryTable::new(vec![
            ("id".to_string(), ColumnType::Int64),
            ("val".to_string(), ColumnType::Float64),
        ]);
        t.push_row(&[ColumnValue::Int(1), ColumnValue::Float(1.0)]).unwrap();
        t.push_row(&[ColumnValue::Int(1), ColumnValue::Float(1.0)]).unwrap(); // dup
        t.push_row(&[ColumnValue::Int(2), ColumnValue::Float(2.0)]).unwrap();

        let dedup = DeduplicateTransform::on_column("id");
        let result = dedup.transform(t).unwrap();
        assert_eq!(result.row_count(), 2);
    }

    #[test]
    fn test_fill_null_constant() {
        let mut t = InMemoryTable::new(vec![
            ("x".to_string(), ColumnType::Float64),
        ]);
        t.push_row(&[ColumnValue::Float(1.0)]).unwrap();
        t.push_row(&[ColumnValue::Null]).unwrap();
        t.push_row(&[ColumnValue::Float(3.0)]).unwrap();

        let transform = FillNullTransform::with_constant("x", ColumnValue::Float(0.0));
        let result = transform.transform(t).unwrap();
        assert_eq!(result.rows[1][0], ColumnValue::Float(0.0));
    }

    #[test]
    fn test_fill_null_mean() {
        let mut t = InMemoryTable::new(vec![("x".to_string(), ColumnType::Float64)]);
        t.push_row(&[ColumnValue::Float(2.0)]).unwrap();
        t.push_row(&[ColumnValue::Null]).unwrap();
        t.push_row(&[ColumnValue::Float(4.0)]).unwrap();

        let transform = FillNullTransform::with_mean("x");
        let result = transform.transform(t).unwrap();
        if let ColumnValue::Float(v) = result.rows[1][0] {
            assert!((v - 3.0).abs() < 1e-9, "expected mean 3.0, got {v}");
        } else {
            panic!("Expected float");
        }
    }

    #[test]
    fn test_fill_null_forward_fill() {
        let mut t = InMemoryTable::new(vec![("x".to_string(), ColumnType::Float64)]);
        t.push_row(&[ColumnValue::Float(5.0)]).unwrap();
        t.push_row(&[ColumnValue::Null]).unwrap();
        t.push_row(&[ColumnValue::Null]).unwrap();
        t.push_row(&[ColumnValue::Float(9.0)]).unwrap();

        let transform = FillNullTransform::forward_fill("x");
        let result = transform.transform(t).unwrap();
        assert_eq!(result.rows[1][0], ColumnValue::Float(5.0));
        assert_eq!(result.rows[2][0], ColumnValue::Float(5.0));
        assert_eq!(result.rows[3][0], ColumnValue::Float(9.0));
    }

    #[test]
    fn test_normalize_min_max() {
        let mut t = InMemoryTable::new(vec![("v".to_string(), ColumnType::Float64)]);
        t.push_row(&[ColumnValue::Float(0.0)]).unwrap();
        t.push_row(&[ColumnValue::Float(5.0)]).unwrap();
        t.push_row(&[ColumnValue::Float(10.0)]).unwrap();

        let norm = NormalizeTransform::min_max("v");
        let result = norm.transform(t).unwrap();
        assert_eq!(result.rows[0][0], ColumnValue::Float(0.0));
        assert_eq!(result.rows[1][0], ColumnValue::Float(0.5));
        assert_eq!(result.rows[2][0], ColumnValue::Float(1.0));
    }

    #[test]
    fn test_normalize_z_score() {
        let mut t = InMemoryTable::new(vec![("v".to_string(), ColumnType::Float64)]);
        // Mean=2, Std=1
        t.push_row(&[ColumnValue::Float(1.0)]).unwrap();
        t.push_row(&[ColumnValue::Float(2.0)]).unwrap();
        t.push_row(&[ColumnValue::Float(3.0)]).unwrap();

        let norm = NormalizeTransform::z_score("v");
        let result = norm.transform(t).unwrap();
        if let ColumnValue::Float(v) = result.rows[1][0] {
            assert!(v.abs() < 1e-9, "z-score of mean should be ~0, got {v}");
        }
    }

    #[test]
    fn test_cast_transform_float_to_int() {
        let mut t = InMemoryTable::new(vec![("x".to_string(), ColumnType::Float64)]);
        t.push_row(&[ColumnValue::Float(3.7)]).unwrap();

        let cast = CastTransform::new("x", ColumnType::Int64);
        let result = cast.transform(t).unwrap();
        assert_eq!(result.rows[0][0], ColumnValue::Int(3));
    }

    #[test]
    fn test_pipeline_csv_to_normalize() {
        let content = "x\n1.0\n2.0\n3.0\n4.0\n5.0\n";
        let path = write_temp_csv(content);

        let pipeline = ETLPipeline::new()
            .extract(
                CSVExtractor::from_path(&path)
                    .has_header(true)
                    .column_types(vec![("x".to_string(), ColumnType::Float64)]),
            )
            .transform(NormalizeTransform::min_max("x"));

        let table = pipeline.run().unwrap();
        assert_eq!(table.row_count(), 5);
        assert_eq!(table.rows[0][0], ColumnValue::Float(0.0));
        assert_eq!(table.rows[4][0], ColumnValue::Float(1.0));

        let _ = std::fs::remove_file(&path);
    }

    #[test]
    fn test_pipeline_csv_loader_roundtrip() {
        let content = "id,name\n1,Alice\n2,Bob\n";
        let src_path = write_temp_csv(content);
        let dst_path = std::env::temp_dir()
            .join(format!("etl_out_{}.csv", uuid::Uuid::new_v4()))
            .to_str()
            .expect("temp path")
            .to_string();

        let (loader, _) = InMemoryLoader::new();
        let _ = ETLPipeline::new()
            .extract(CSVExtractor::from_path(&src_path).has_header(true))
            .load_to(CSVLoader::new(&dst_path))
            .run()
            .unwrap();

        // Verify output file
        let content_out = std::fs::read_to_string(&dst_path).unwrap();
        assert!(content_out.contains("id,name"));
        assert!(content_out.contains("Alice"));

        let _ = std::fs::remove_file(&src_path);
        let _ = std::fs::remove_file(&dst_path);
        drop(loader);
    }

    #[test]
    fn test_rename_transform() {
        let mut t = InMemoryTable::new(vec![
            ("old_name".to_string(), ColumnType::Utf8),
        ]);
        t.push_row(&[ColumnValue::Utf8("Alice".to_string())]).unwrap();

        let rename = RenameTransform::one("old_name", "new_name");
        let result = rename.transform(t).unwrap();
        assert_eq!(result.columns[0].name, "new_name");
    }

    #[test]
    fn test_aggregate_transform() {
        let mut t = InMemoryTable::new(vec![
            ("dept".to_string(), ColumnType::Utf8),
            ("salary".to_string(), ColumnType::Float64),
        ]);
        t.push_row(&[ColumnValue::Utf8("eng".to_string()), ColumnValue::Float(100.0)]).unwrap();
        t.push_row(&[ColumnValue::Utf8("eng".to_string()), ColumnValue::Float(200.0)]).unwrap();
        t.push_row(&[ColumnValue::Utf8("hr".to_string()), ColumnValue::Float(80.0)]).unwrap();

        let agg = AggregateTransform::new(
            vec!["dept".to_string()],
            vec![AggFunc::Sum("salary".to_string()), AggFunc::Count],
        );
        let result = agg.transform(t).unwrap();
        assert_eq!(result.row_count(), 2);
    }
}