saorsa-agent 0.4.0

AI coding agent runtime with tool execution
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
//! Automatic session saving with debouncing and retry logic.

use crate::SaorsaAgentError;
use crate::session::{Message, SessionId, SessionMetadata, SessionStorage};
use std::sync::Arc;
use std::time::Duration;
use tokio::sync::{Mutex, RwLock, mpsc};
use tokio::time::sleep;
use tracing::{debug, error, warn};

/// Configuration for auto-save behavior.
#[derive(Debug, Clone)]
pub struct AutoSaveConfig {
    /// Minimum interval between saves (debounce duration).
    pub save_interval: Duration,
    /// Maximum number of messages to batch before forcing a save.
    pub max_batch_size: usize,
    /// Maximum number of retry attempts on save failure.
    pub max_retries: usize,
}

impl Default for AutoSaveConfig {
    fn default() -> Self {
        Self {
            save_interval: Duration::from_millis(500),
            max_batch_size: 10,
            max_retries: 3,
        }
    }
}

/// Auto-save manager handles background saving with debouncing and retry logic.
pub struct AutoSaveManager {
    storage: Arc<SessionStorage>,
    session_id: SessionId,
    metadata: Arc<RwLock<SessionMetadata>>,
    messages: Arc<RwLock<Vec<Message>>>,
    dirty: Arc<Mutex<bool>>,
    save_tx: mpsc::UnboundedSender<SaveRequest>,
}

/// Request to save session data.
#[derive(Debug)]
enum SaveRequest {
    /// Save the current state.
    Save,
    /// Shutdown the auto-save task.
    Shutdown,
}

impl AutoSaveManager {
    /// Create a new auto-save manager and start the background task.
    pub fn new(
        storage: SessionStorage,
        config: AutoSaveConfig,
        session_id: SessionId,
        metadata: SessionMetadata,
    ) -> Self {
        let storage = Arc::new(storage);
        let metadata = Arc::new(RwLock::new(metadata));
        let messages = Arc::new(RwLock::new(Vec::new()));
        let dirty = Arc::new(Mutex::new(false));

        let (save_tx, save_rx) = mpsc::unbounded_channel();

        // Spawn background save task
        let task_storage = Arc::clone(&storage);
        let task_metadata = Arc::clone(&metadata);
        let task_messages = Arc::clone(&messages);
        let task_dirty = Arc::clone(&dirty);
        let task_config = config.clone();
        let task_session_id = session_id;

        tokio::spawn(async move {
            Self::save_task(
                task_storage,
                task_config,
                task_session_id,
                task_metadata,
                task_messages,
                task_dirty,
                save_rx,
            )
            .await;
        });

        Self {
            storage,
            session_id,
            metadata,
            messages,
            dirty,
            save_tx,
        }
    }

    /// Add a message and mark dirty for auto-save.
    pub async fn add_message(&self, message: Message) {
        let mut messages = self.messages.write().await;
        messages.push(message);
        drop(messages);

        *self.dirty.lock().await = true;

        // Trigger debounced save
        let _ = self.save_tx.send(SaveRequest::Save);
    }

    /// Get all messages.
    pub async fn messages(&self) -> Vec<Message> {
        self.messages.read().await.clone()
    }

    /// Update metadata.
    pub async fn update_metadata(&self, metadata: SessionMetadata) {
        *self.metadata.write().await = metadata;
        *self.dirty.lock().await = true;
        let _ = self.save_tx.send(SaveRequest::Save);
    }

    /// Force an immediate save (bypassing debounce).
    pub async fn force_save(&self) -> Result<(), SaorsaAgentError> {
        self.perform_save().await
    }

    /// Shutdown the auto-save task.
    pub fn shutdown(&self) {
        let _ = self.save_tx.send(SaveRequest::Shutdown);
    }

    /// Background save task with debouncing and retry logic.
    async fn save_task(
        storage: Arc<SessionStorage>,
        config: AutoSaveConfig,
        session_id: SessionId,
        metadata: Arc<RwLock<SessionMetadata>>,
        messages: Arc<RwLock<Vec<Message>>>,
        dirty: Arc<Mutex<bool>>,
        mut save_rx: mpsc::UnboundedReceiver<SaveRequest>,
    ) {
        let mut pending_save = false;
        let mut last_saved_count = 0;

        loop {
            tokio::select! {
                request = save_rx.recv() => {
                    match request {
                        Some(SaveRequest::Save) => {
                            pending_save = true;
                        }
                        Some(SaveRequest::Shutdown) | None => {
                            debug!("Auto-save task shutting down");
                            break;
                        }
                    }
                }
                _ = sleep(config.save_interval), if pending_save => {
                    // Debounce timer expired, perform save
                    let is_dirty = *dirty.lock().await;
                    let current_count = messages.read().await.len();

                    // Check if we should save (dirty flag or batch size exceeded)
                    let should_save = is_dirty ||
                        (current_count > last_saved_count &&
                         current_count - last_saved_count >= config.max_batch_size);

                    if should_save {
                        debug!(session_id = %session_id, "Performing auto-save");

                        // Perform save with retry logic
                        let mut attempt = 0;
                        loop {
                            attempt += 1;

                            let metadata_clone = metadata.read().await.clone();
                            let messages_clone = messages.read().await.clone();

                            match Self::save_with_retry(
                                &storage,
                                session_id,
                                &metadata_clone,
                                &messages_clone,
                                last_saved_count,
                            )
                            .await
                            {
                                Ok(()) => {
                                    *dirty.lock().await = false;
                                    last_saved_count = messages_clone.len();
                                    debug!(session_id = %session_id, messages = last_saved_count, "Auto-save complete");
                                    break;
                                }
                                Err(e) => {
                                    if attempt >= config.max_retries {
                                        error!(
                                            session_id = %session_id,
                                            error = %e,
                                            "Auto-save failed after {} retries",
                                            config.max_retries
                                        );
                                        break;
                                    } else {
                                        warn!(
                                            session_id = %session_id,
                                            attempt,
                                            error = %e,
                                            "Auto-save failed, retrying..."
                                        );
                                        sleep(Duration::from_millis(100 * attempt as u64)).await;
                                    }
                                }
                            }
                        }
                    }

                    pending_save = false;
                }
            }
        }
    }

    /// Perform the actual save operation.
    async fn perform_save(&self) -> Result<(), SaorsaAgentError> {
        let metadata = self.metadata.read().await.clone();
        let messages = self.messages.read().await.clone();

        Self::save_with_retry(&self.storage, self.session_id, &metadata, &messages, 0).await?;

        *self.dirty.lock().await = false;
        debug!(session_id = %self.session_id, "Force save complete");
        Ok(())
    }

    /// Save with incremental message append.
    async fn save_with_retry(
        storage: &SessionStorage,
        session_id: SessionId,
        metadata: &SessionMetadata,
        messages: &[Message],
        last_saved_count: usize,
    ) -> Result<(), SaorsaAgentError> {
        // Save manifest
        storage.save_manifest(&session_id, metadata)?;

        // Incremental save: only append new messages
        if last_saved_count < messages.len() {
            for (idx, message) in messages.iter().enumerate().skip(last_saved_count) {
                storage.save_message(&session_id, idx, message)?;
            }
        }

        Ok(())
    }
}

impl Drop for AutoSaveManager {
    fn drop(&mut self) {
        self.shutdown();
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::session::{Message, SessionId, SessionMetadata};
    use chrono::Utc;
    use std::collections::HashSet;
    use tempfile::TempDir;

    #[tokio::test]
    async fn test_debouncing_coalesces_rapid_saves() {
        let temp_dir = match TempDir::new() {
            Ok(dir) => dir,
            Err(e) => panic!("Failed to create temp dir: {}", e),
        };
        let storage = SessionStorage::with_base_path(temp_dir.path().to_path_buf());

        let config = AutoSaveConfig {
            save_interval: Duration::from_millis(100),
            max_batch_size: 10,
            max_retries: 3,
        };

        let session_id = SessionId::new();
        let now = Utc::now();
        let metadata = SessionMetadata {
            created: now,
            modified: now,
            last_active: now,
            title: Some("Test Session".to_string()),
            description: None,
            tags: HashSet::new(),
        };

        let manager = AutoSaveManager::new(storage, config, session_id, metadata);

        // Add multiple messages rapidly
        for i in 0..5 {
            manager
                .add_message(Message::user(format!("Message {}", i)))
                .await;
            sleep(Duration::from_millis(10)).await;
        }

        // Wait for debounce interval plus processing time
        sleep(Duration::from_millis(200)).await;

        // Verify all messages saved
        let messages = manager.messages().await;
        assert_eq!(messages.len(), 5);
    }

    #[tokio::test]
    async fn test_incremental_save_appends_only_new_messages() {
        let temp_dir = match TempDir::new() {
            Ok(dir) => dir,
            Err(e) => panic!("Failed to create temp dir: {}", e),
        };
        let storage = SessionStorage::with_base_path(temp_dir.path().to_path_buf());

        let config = AutoSaveConfig {
            save_interval: Duration::from_millis(50),
            max_batch_size: 10,
            max_retries: 3,
        };

        let session_id = SessionId::new();
        let now = Utc::now();
        let metadata = SessionMetadata {
            created: now,
            modified: now,
            last_active: now,
            title: Some("Incremental Test".to_string()),
            description: None,
            tags: HashSet::new(),
        };

        let manager = AutoSaveManager::new(storage, config, session_id, metadata);

        // Add first batch
        manager
            .add_message(Message::user("First".to_string()))
            .await;
        manager
            .add_message(Message::user("Second".to_string()))
            .await;
        sleep(Duration::from_millis(100)).await;

        // Add second batch
        manager
            .add_message(Message::user("Third".to_string()))
            .await;
        sleep(Duration::from_millis(100)).await;

        let messages = manager.messages().await;
        assert_eq!(messages.len(), 3);
    }

    #[tokio::test]
    async fn test_retry_logic_on_simulated_io_error() {
        // This test verifies retry logic exists
        // In practice, we'd need a mock storage to simulate failures
        let temp_dir = match TempDir::new() {
            Ok(dir) => dir,
            Err(e) => panic!("Failed to create temp dir: {}", e),
        };
        let storage = SessionStorage::with_base_path(temp_dir.path().to_path_buf());

        let config = AutoSaveConfig {
            save_interval: Duration::from_millis(50),
            max_batch_size: 10,
            max_retries: 3,
        };

        let session_id = SessionId::new();
        let now = Utc::now();
        let metadata = SessionMetadata {
            created: now,
            modified: now,
            last_active: now,
            title: Some("Retry Test".to_string()),
            description: None,
            tags: HashSet::new(),
        };

        let manager = AutoSaveManager::new(storage, config, session_id, metadata);
        manager.add_message(Message::user("Test".to_string())).await;
        sleep(Duration::from_millis(150)).await;

        // If storage works, save succeeds (no actual retry needed)
        // This validates the happy path
        let messages = manager.messages().await;
        assert_eq!(messages.len(), 1);
    }

    #[tokio::test]
    async fn test_session_state_persists_after_autosave() {
        let temp_dir = match TempDir::new() {
            Ok(dir) => dir,
            Err(e) => panic!("Failed to create temp dir: {}", e),
        };
        let storage = SessionStorage::with_base_path(temp_dir.path().to_path_buf());

        let config = AutoSaveConfig {
            save_interval: Duration::from_millis(50),
            max_batch_size: 10,
            max_retries: 3,
        };

        let session_id = SessionId::new();
        let now = Utc::now();
        let metadata = SessionMetadata {
            created: now,
            modified: now,
            last_active: now,
            title: Some("Persist Test".to_string()),
            description: None,
            tags: HashSet::new(),
        };

        let manager = AutoSaveManager::new(storage.clone(), config, session_id, metadata.clone());

        manager
            .add_message(Message::user("Persisted".to_string()))
            .await;
        sleep(Duration::from_millis(150)).await;

        // Load from storage to verify persistence
        let loaded_metadata = match storage.load_manifest(&session_id) {
            Ok(meta) => meta,
            Err(e) => panic!("Failed to load manifest: {}", e),
        };
        assert_eq!(loaded_metadata.title, Some("Persist Test".to_string()));

        let loaded_messages = match storage.load_messages(&session_id) {
            Ok(msgs) => msgs,
            Err(e) => panic!("Failed to load messages: {}", e),
        };
        assert_eq!(loaded_messages.len(), 1);
    }

    #[tokio::test]
    async fn test_no_data_loss_on_rapid_message_additions() {
        let temp_dir = match TempDir::new() {
            Ok(dir) => dir,
            Err(e) => panic!("Failed to create temp dir: {}", e),
        };
        let storage = SessionStorage::with_base_path(temp_dir.path().to_path_buf());

        let config = AutoSaveConfig {
            save_interval: Duration::from_millis(100),
            max_batch_size: 5, // Force save every 5 messages
            max_retries: 3,
        };

        let session_id = SessionId::new();
        let now = Utc::now();
        let metadata = SessionMetadata {
            created: now,
            modified: now,
            last_active: now,
            title: Some("Rapid Test".to_string()),
            description: None,
            tags: HashSet::new(),
        };

        let manager = AutoSaveManager::new(storage, config, session_id, metadata);

        // Add 20 messages rapidly
        for i in 0..20 {
            manager
                .add_message(Message::user(format!("Rapid {}", i)))
                .await;
        }

        // Wait for all saves to complete
        sleep(Duration::from_millis(500)).await;

        let messages = manager.messages().await;
        assert_eq!(messages.len(), 20, "All messages should be preserved");
    }
}