safe_chains/engine/resolve.rs
1//! The profile resolver — turning a parsed command into its behavior profile
2//! (annex `behavioral-taxonomy-engine`). Runs via `engine::bridge`, which is
3//! AUTHORITATIVE for every command it can resolve (`engine_verdict(tokens).unwrap_or(legacy)`
4//! in `cst::check::leaf_verdict`) — there is no opt-out.
5//!
6//! This file holds the dispatch (`resolve`) and the per-command `resolve_*` functions;
7//! the shared toolkit they build on lives in submodules: `flags` (the getopt-style
8//! flag walker), `locus` (`classify_locus` — the [`LocalLocus`] ladder that refines the
9//! old `is_safe_write_target` boolean, v1.4 §2.2), and `capability` (the builders that
10//! stamp out each `Capability` with the facet pairing its operation warrants).
11
12use super::facet::*;
13use crate::parse::{Token, has_flag};
14
15mod backup;
16mod capability;
17mod path_verdicts;
18pub(crate) use path_verdicts::{
19 read_content_verdict, read_tree_verdict, rebind_is_stricter_than_write, worst_path_element, write_target_verdict,
20};
21mod flags;
22pub(crate) mod locus;
23pub(crate) mod regions;
24#[cfg(test)]
25mod scenarios;
26
27use capability::{
28 breadth_scale, creates, destroys, executes, mutates, observes, observes_path, overwrites, reads_content, reads_path, reads_to_model,
29 relocates, transfer_profile, worst, writes_export_file,
30};
31use flags::{walk_positionals, walk_value};
32pub(crate) use locus::is_unpinnable;
33pub(crate) use locus::{FrozenWrite, anchoring_of, frozen_write_kind, names_credential_store};
34use locus::{classify_locus, read_locus, write_locus};
35
36/// For `for VAR in ITEMS; do …$VAR…`, the representatives to bind `$VAR` to in the body: the
37/// worst-READ item and the worst-WRITE item of the list (they can differ, so a read and a
38/// write of `$VAR` each get their list's worst case). `$VAR` then inherits the list's locus
39/// per operation — the `find … {}`→path binding, one layer up. `None` for an empty list, which
40/// leaves `$VAR` fail-closed (machine). An item the classifier cannot bound — an UNDECLARED command
41/// substitution, a process substitution, arithmetic — worst-cases to machine via a `$`-carrying
42/// sentinel representative. An item from a substitution whose inner command DECLARED its output
43/// locus is bounded, so it is classified like any other path: `for f in $(fd a app/)` reads the
44/// worktree, and `for f in $(fd a /etc)` still lands at machine because that is what the tag says.
45/// (The test here used to be a `__SAFE_CHAINS_` PREFIX match, which caught the bounded sentinel too
46/// and made the loop form deny while the bare `cat $(fd a app/)` was allowed.)
47pub(crate) fn loop_reprs(items: &[String]) -> Option<(String, String)> {
48 if items.is_empty() {
49 return None;
50 }
51 let faced: Vec<(String, LocalLocus, LocalLocus)> = items
52 .iter()
53 .map(|s| {
54 if crate::cst::check::is_opaque_value(s) {
55 ("$loop_sub".to_string(), LocalLocus::Machine, LocalLocus::Machine)
56 } else {
57 (s.clone(), read_locus(s), write_locus(s))
58 }
59 })
60 .collect();
61 let read_item = faced.iter().max_by_key(|(_, r, _)| *r).map(|(s, _, _)| s.clone())?;
62 let write_item = faced.iter().max_by_key(|(_, _, w)| *w).map(|(s, _, _)| s.clone())?;
63 // Freeze against the CURRENT (outer) loop bindings, so an inner representative like `$d/x`
64 // doesn't carry a stale outer variable into the body — nested loops compose.
65 //
66 // A GLOB item above the workspace gets no representative at all. `for f in /etc/*` binds `$f`
67 // to the literal `/etc/*`, and the body then reads a path whose last component the glob will
68 // choose — `/etc/shadow` among them — while the shield is asked about a string containing a
69 // `*`, which names nothing and clears every time.
70 let read_repr = if crate::engine::resolve::locus::glob_above_workspace(&read_item) {
71 crate::engine::resolve::locus::UNKNOWABLE_ITEM.to_string()
72 } else {
73 crate::pathctx::expand_vars(&read_item, false).into_owned()
74 };
75 let write_repr = crate::pathctx::expand_vars(&write_item, true).into_owned();
76 Some((read_repr, write_repr))
77}
78
79/// The verdict for EXECUTING the code in file `path` — used to gate an interpreter/runner's
80/// script operand (`bash x.sh`, `python x.py`, `node x.js`, `go run pkg/`) by its EXECUTOR
81/// locus. A worktree-local script is the dev loop → admitted at `developer`; a foreign one
82/// (`/tmp/x.sh`, `~/x.py`, `/usr/local/bin/x`) or an unpinnable path (`$VAR`, glob, `..`
83/// beyond cwd → `machine`) denies. `CallerFile` trust (code from a named file). See
84/// docs/design/behavioral-taxonomy-execution-origin.md.
85pub(crate) fn execute_file_verdict(path: &str) -> crate::verdict::Verdict {
86 // A GLOB executor (`bash *.sh`) names no specific file — the matched code is unknown, so
87 // it cannot be pinned to a worktree executor; deny (design §6). ($VAR/../cmdsub are already
88 // worst-cased by classify_locus.) A glob stays fine as a read/write OPERAND, where every
89 // match is locus-gated; only as an EXECUTOR is the code it would run unknowable.
90 if path.contains(['*', '?', '[']) {
91 return crate::engine::bridge::project(&worst("glob executor — the code that would run is unknown (§6)"));
92 }
93 // A PROCESS-SUBSTITUTION executor (`sh <(curl …)`) runs the OUTPUT of the inner command, not
94 // the inner command. The inner command is checked separately and is usually safe on its own —
95 // `curl` prints, `echo` prints — which is exactly how this hid: `sh <(curl …)` auto-approved
96 // while the identical `curl … | sh` denied. A command that is safe to RUN is not the same as a
97 // command whose output is safe to EXECUTE.
98 //
99 // Only in the executor slot. As a DATA operand the sentinel stays worktree-ordinary on purpose,
100 // because reading a `/dev/fd` pipe really is as safe as the inner command (`diff <(ls) <(ls)`).
101 if path.contains(crate::cst::eval::PROCSUB_SENTINEL) {
102 return crate::engine::bridge::project(&worst(
103 "process-substitution executor — the code that would run is a command's output (§6)",
104 ));
105 }
106 // A URL executor (`borg --rsh http://evil/x`, `rsync -e file:~`) is not a workspace file. The
107 // locus layer admits a network URL at `worktree` on purpose — for a network OPERAND the
108 // command's own handler gates the network, and a URL's `..` is a path segment rather than a
109 // filesystem escape. In an EXECUTOR slot that reasoning inverts: the thing has to be a local
110 // file the project owns, and `http://…` is not one however harmless its `..` are. Third member
111 // of the same family as the glob and process-substitution rules above.
112 if crate::engine::resolve::locus::is_url(path) {
113 return crate::engine::bridge::project(&worst("URL executor — the code that would run is not a workspace file (§6)"));
114 }
115 // An executor slot names a PATH. A value carrying whitespace is a command LINE, and judging it
116 // as one path is how `BORG_RSH='sh -c evil'` and `rsync -e 'sh -c evil'` were auto-approved:
117 // the whole string read as one oddly-named executable, which satisfied the bare-name rule.
118 //
119 // Every whitespace-separated token must therefore look like a path. That keeps the documented
120 // space-separated forms working (`LD_PRELOAD='/a.so /b.so'` judges both), while a token that is
121 // not a path — an interpreter's `-c`, the inline code after it — means the value was never a
122 // path and cannot be judged as one. Stated as a requirement ON the value, not as a list of
123 // forbidden programs: `sh -c evil` fails because `-c` is not a path, not because it is `sh`.
124 //
125 // Fail-CLOSED and known to over-deny: `rsync -e 'ssh -p 2222'` is a legitimate idiom that now
126 // refuses, because vetting a transport's own flags is a question this layer cannot answer.
127 if path.split_whitespace().count() > 1 {
128 let mut worst_seen = None;
129 for token in path.split_whitespace() {
130 if token.starts_with('-') {
131 return crate::engine::bridge::project(&worst(
132 "executor value is a command line, not a path — a non-path token means the \
133 code that would run is unknown",
134 ));
135 }
136 let v = execute_file_verdict(token);
137 worst_seen = Some(match worst_seen {
138 None => v,
139 Some(prev) => crate::verdict::Verdict::combine(prev, v),
140 });
141 }
142 return worst_seen.unwrap_or_else(|| crate::engine::bridge::project(&worst("empty executor value")));
143 }
144 let cap = executes(classify_locus(path), ExecutionTrust::CallerFile, "runs code from a named file");
145 crate::engine::bridge::project(&Profile::of(vec![cap]))
146}
147
148/// The verdict for running the CURRENT PROJECT's own code — an implicit-project runner
149/// (`cargo run`, `dotnet run`, `swift run`) with no path operand and no redirect out of the
150/// worktree. `SelfCode` @ `Worktree` → admitted at `developer`. A runner redirected out of the
151/// project (`cargo run --manifest-path ~/o/Cargo.toml`) resolves that path through
152/// [`execute_file_verdict`] instead. See docs/design/behavioral-taxonomy-execution-origin.md.
153pub(crate) fn execute_project_verdict() -> crate::verdict::Verdict {
154 let cap = executes(LocalLocus::Worktree, ExecutionTrust::SelfCode, "runs the current project's own code");
155 crate::engine::bridge::project(&Profile::of(vec![cap]))
156}
157
158/// Resolve a command's leaf tokens to its behavior profile, or `None` if the command
159/// has no resolver yet (the caller then worst-cases / falls back to the legacy
160/// classifier — §0 fail-closed). Redirects, substitutions, and chain semantics are the
161/// surrounding CST's job, not this leaf's (annex `…-engine` §1).
162pub fn resolve(tokens: &[Token]) -> Option<Profile> {
163 let arg0 = tokens.first()?;
164 // Canonicalize the invoked token through the registry's alias map (`gcat` → `cat`) BEFORE the
165 // resolver lookup: Homebrew installs GNU coreutils as g-prefixed aliases, and without this
166 // they'd miss every resolver and fall through to the ungated legacy classifier (a fail-open —
167 // `gtee /etc/cron.d/job`, `gcat /etc/shadow`). The `tokens` are passed through unchanged; the
168 // resolver gates operands by position, not by re-reading the command name.
169 let canonical = crate::registry::canonical_name(arg0.command_name());
170 // `sudo`/`doas` ELEVATE the wrapped command's authority — they are a delegating wrapper, not a
171 // command of their own. Resolve the inner command and lift its authority to root (or `other-user`
172 // for `-u`), so the safety of `sudo X` is the safety of `X` run privileged: `sudo cat ./notes`
173 // → a root READ (local-admin), `sudo rm -rf /` → the catastrophe corner (denied everywhere).
174 if canonical == "openssl" {
175 return resolve_openssl(arg0, tokens);
176 }
177 if matches!(canonical, "sudo" | "doas") {
178 return resolve_privilege_wrapper(arg0, tokens);
179 }
180 // Phase 1: a subcommand tagged with a facet archetype (`profile = …`) classifies as that
181 // archetype's static capability — the derived, self-documenting successor to `candidate = true`.
182 // Checked BEFORE command-level behavior, since a subcommand tool carries no `[command.behavior]`.
183 if let Some(names) = crate::registry::sub_archetypes(tokens) {
184 if !trusted_command_path(arg0.as_str()) {
185 return Some(worst("resolvable name invoked from a non-standard path — possible spoof (§0)"));
186 }
187 // An endpoint flag pointed at THIS machine makes the sub a DIFFERENT operation, not the same
188 // one with softened edges: `put-item --endpoint-url http://localhost:8000` writes to a
189 // process here, so `remote-mutate`'s `sends-host-data`, `effortful` reversibility and (for
190 // create) `metered` cost are all describing a cloud service that isn't in the picture. The
191 // sub names the archetype it becomes, so the substitution stays reviewable data rather than
192 // ad-hoc facet arithmetic at resolve time.
193 //
194 // Destroy archetypes may not declare a substitute at all — `assert_no_loopback_profile_on_
195 // destroy` refuses it at build time. We cannot verify the emulator claim (`ssh -L
196 // 8000:dynamodb.us-east-1.amazonaws.com:443` makes `localhost:8000` production, and no
197 // static classifier sees the tunnel), and that lie is only unrecoverable in the destroy
198 // direction.
199 // One capability per archetype (the sub's profile + each present escalating flag); the level
200 // algebra takes the max. Fail-closed: an unknown archetype name → a worst capability, so a
201 // typo or `unclassified` can never silently pass (a proptest catches typos at test time).
202 let mut caps: Vec<Capability> = names
203 .iter()
204 .map(|n| {
205 crate::engine::archetype::archetype(n)
206 .cloned()
207 .unwrap_or_else(|| Capability::worst("subcommand/flag declares an unknown archetype (§0)"))
208 })
209 .collect();
210 // Destination-trust (exposure §4): a sub tagged `network_destination` gets its send TARGET
211 // classified onto the base archetype's `locus.provenance` — established remote / literal URL
212 // / opaque `$VAR` — or, for a command-transport form (`ext::…`), worst-cased as RCE.
213 if let Some(dest) = crate::registry::sub_destination_token(tokens) {
214 match destination_provenance(dest) {
215 Some(prov) => {
216 if let Some(base) = caps.first_mut() {
217 base.locus.provenance = prov;
218 }
219 }
220 None => {
221 return Some(worst("send target is a command transport (ext::…) — runs a local command, RCE (§4)"));
222 }
223 }
224 }
225 // A `data-export` sub with an OUTPUT-FILE flag (`db dump -f out.sql`) writes its bulk result
226 // to a local file — a SECOND capability beyond the remote read, gated at the file's locus
227 // (worktree write vs a system-path clobber). Absent → the export streams to stdout, so the
228 // profile is the remote read alone.
229 if let Some(path) = crate::registry::sub_output_path_token(tokens) {
230 caps.push(writes_export_file(classify_locus(path)));
231 }
232 // A declared endpoint flag naming THIS machine changes WHERE the call goes, so it changes
233 // exactly the facets the destination determines and nothing else. That boundary is the whole
234 // design: `remote-mutate` describes a cloud service in four places — it reaches a fixed
235 // remote, talks outbound, sends host data off the machine, and bills — and all four are
236 // false for `http://localhost:8000`. Its other facets (what the operation DOES: the
237 // operation itself, scale, retrieval, reversibility, persistence, disclosure) are properties
238 // of the call, not of its destination, and stay untouched.
239 //
240 // Composing rather than substituting a whole "local" archetype matters twice over: the
241 // remote archetypes do not each need a local twin, and nothing here asserts a fact the
242 // destination cannot establish. (An earlier cut swapped in `local-mutate-recoverable`, which
243 // claims `locus.local = worktree` and `persistence = data` — both untrue of a container.)
244 //
245 // DESTROY is skipped here and refused outright at build time by
246 // `assert_loopback_localizes_is_coherent`. The emulator claim is unverifiable: `ssh -L
247 // 8000:dynamodb.<region>.amazonaws.com:443` makes `localhost:8000` production and no static
248 // classifier sees the tunnel. Being wrong costs a stray write; being wrong about a delete
249 // costs the data.
250 if crate::registry::sub_loopback_localizes(tokens) {
251 for c in &mut caps {
252 if c.operation == Operation::Destroy {
253 continue;
254 }
255 c.locus.remote = RemoteReach::None;
256 c.network.direction = NetDirection::Loopback;
257 c.network.payload = NetPayload::None;
258 c.cost = Cost::None;
259 // The archetype's prose describes the cloud call and is now half wrong; say so,
260 // or `--explain` prints "changes remote state" over a profile that reaches no
261 // remote. The facets carry the classification, but the prose is what a human reads.
262 c.because = format!("{} — but the endpoint names this machine, so no remote is reached", c.because);
263 }
264 }
265 return Some(Profile::of(caps));
266 }
267 // A flat command whose top-level classifying flag (`[[command.flag]]`) is present resolves to
268 // that flag's archetype — the flag-triggered mode of a bimodal tool: `age -d` / `sops --decrypt`
269 // reveal plaintext to the model (`decrypt-read`), while the bare/encrypt form falls through to
270 // ordinary resolution below. Checked after the profiled-sub walk (a sub match wins) so a
271 // subcommand form (`sops decrypt`) and the flag form (`sops -d`) both classify.
272 if let Some(names) = crate::registry::command_flag_archetypes(tokens) {
273 if !trusted_command_path(arg0.as_str()) {
274 return Some(worst("resolvable name invoked from a non-standard path — possible spoof (§0)"));
275 }
276 let caps: Vec<Capability> = names
277 .iter()
278 .map(|n| {
279 crate::engine::archetype::archetype(n)
280 .cloned()
281 .unwrap_or_else(|| Capability::worst("command flag declares an unknown archetype (§0)"))
282 })
283 .collect();
284 return Some(Profile::of(caps));
285 }
286 // Every facet-classified command declares `[command.behavior]` (the coreutils are all ported;
287 // dd/tar/sed/grep declare a `hook`). No declaration → the command is unresearched for the
288 // engine, so return `None` (the caller falls back to the legacy classifier).
289 let spec = crate::registry::command_behavior(canonical)?;
290 // A resolvable basename reached via a NON-STANDARD path (`./cat`, `/tmp/cat`, `~/bin/grep`)
291 // is not necessarily the real tool — a planted binary named `cat` would be certified as safe
292 // coreutils. Don't certify it; worst-case (§0). Bare names and standard bin paths are
293 // trusted. (Legacy classifies purely by basename and inherits the spoof; the engine is
294 // stricter here, which keeps it never-looser.)
295 if !trusted_command_path(arg0.as_str()) {
296 return Some(worst("resolvable name invoked from a non-standard path — possible spoof (§0)"));
297 }
298 Some(resolve_behavior(spec, tokens))
299}
300
301/// `sudo`/`doas`: resolve the wrapped command and ELEVATE its authority. Authority is the axis every
302/// level below `local-admin` pins to `user`, so a root capability lands at `local-admin` (or `yolo`)
303/// — the projection does the rest. Fail-closed: an unknown sudo option, a root shell/editor
304/// (`-i`/`-s`/`-e`), or an inner command from a non-standard path worst-cases; an unresolved inner
305/// returns `None` so the caller's legacy fallback denies it (never *looser* than the bare command).
306fn resolve_privilege_wrapper(arg0: &Token, tokens: &[Token]) -> Option<Profile> {
307 if !trusted_command_path(arg0.as_str()) {
308 return Some(worst("sudo/doas invoked from a non-standard path — possible spoof (§0)"));
309 }
310 let mut i = 1;
311 let mut run_as_other = false;
312 'scan: while let Some(tok) = tokens.get(i) {
313 let t = tok.as_str();
314 if t == "--" {
315 i += 1;
316 break;
317 }
318 if !t.starts_with('-') || t == "-" {
319 break; // the inner command starts here
320 }
321 if let Some(long) = t.strip_prefix("--") {
322 let (name, glued_val) = match long.split_once('=') {
323 Some((n, _)) => (n, true),
324 None => (long, false),
325 };
326 match name {
327 "login" | "shell" | "edit" => {
328 return Some(worst("sudo -i/-s/-e runs a root shell or editor — arbitrary code as root (§0)"));
329 }
330 "user" | "other-user" => {
331 run_as_other = true;
332 if !glued_val {
333 i += 1;
334 }
335 }
336 "group" | "prompt" | "close-from" | "host" | "role" | "type" | "command-timeout" | "chroot" | "chdir" | "preserve-env" => {
337 // `--preserve-env` is boolean OR `--preserve-env=list`; only the space form of the
338 // others consumes a value. A bare `--preserve-env` just falls through (no skip).
339 if !glued_val && name != "preserve-env" {
340 i += 1;
341 }
342 }
343 "background" | "stdin" | "non-interactive" | "reset-timestamp" | "remove-timestamp" | "set-home" | "askpass" | "help"
344 | "version" | "validate" | "list" | "bell" => {}
345 _ => return Some(worst("sudo: unrecognized option — fail-closed (§0)")),
346 }
347 } else {
348 // A short cluster (`-EH`, `-u root`, `-uroot`). Consume char by char; a valued flag eats
349 // the rest of the token as its value, or the next token if the rest is empty.
350 let rest = &t[1..];
351 for (idx, c) in rest.char_indices() {
352 match c {
353 'i' | 's' | 'e' => {
354 return Some(worst("sudo -i/-s/-e runs a root shell or editor — arbitrary code as root (§0)"));
355 }
356 'u' | 'U' | 'g' | 'p' | 'C' | 'h' | 'r' | 't' | 'T' | 'R' | 'D' => {
357 if c == 'u' || c == 'U' {
358 run_as_other = true;
359 }
360 if idx + c.len_utf8() == rest.len() {
361 i += 1;
362 } // value is the next token
363 i += 1;
364 continue 'scan; // rest of the token was this flag's value
365 }
366 'E' | 'H' | 'k' | 'K' | 'n' | 'b' | 'A' | 'S' | 'P' | 'B' | 'v' | 'l' => {}
367 _ => return Some(worst("sudo: unrecognized option — fail-closed (§0)")),
368 }
369 }
370 }
371 i += 1;
372 }
373 // A valued short flag at end-of-input (`sudo -u`, `doas -r`) consumes a "next token" that isn't
374 // there, pushing `i` one past the end — clamp so the slice can't panic (fail-OPEN crash of the
375 // hook). An overshoot means no command was left to elevate, same as the empty case below.
376 let inner = &tokens[i.min(tokens.len())..];
377 if inner.is_empty() {
378 return None; // `sudo` / `sudo -v` / `sudo -l` — no command to elevate; legacy decides
379 }
380 let elevated = if run_as_other { Authority::OtherUser } else { Authority::Root };
381 let caps = resolve(inner)?
382 .capabilities
383 .into_iter()
384 .map(|mut c| {
385 c.authority = c.authority.max(elevated);
386 c
387 })
388 .collect();
389 Some(Profile::of(caps))
390}
391
392/// openssl decrypt / private-key disclosure resolver. openssl's flag grammar defeats declarative
393/// flag-gating — it accepts `--opt` as an alias for `-opt` on every subcommand, `-text` dumps the
394/// PRIVATE key components to stdout past `-pubout`/`-noout`, and `-out`'s VALUE can itself be stdout
395/// (`-out -`, `-out /dev/stdout`) — so the disclosure-prone subs are classified here in Rust. Returns
396/// `decrypt-read` (→ yolo, denied below) only when private/decrypted material reaches the MODEL
397/// (stdout); returns `None` for public-key ops, to-FILE extraction, encrypt/sign, and the ~30 benign
398/// subs, which fall through to openssl's declarative (allow_all) classification. Fail-closed: a spoofed
399/// path worst-cases; a disclosure sub always yields a verdict rather than abstaining to the permissive
400/// legacy default.
401fn resolve_openssl(arg0: &Token, tokens: &[Token]) -> Option<Profile> {
402 if !trusted_command_path(arg0.as_str()) {
403 return Some(worst("openssl invoked from a non-standard path — possible spoof (§0)"));
404 }
405 let sub = tokens.get(1)?.as_str();
406 let args = &tokens[2..];
407 let discloses = match sub {
408 // Private-key subs: private material reaches the model UNLESS the input is public (`-pubin`),
409 // or it's public-key output (`-pubout`) with no `-text` side channel — and then only if the
410 // (private-key) output actually goes to stdout, not a file.
411 "rsa" | "pkey" | "ec" | "dsa" => {
412 if openssl_flag(args, "-pubin") {
413 false
414 } else if openssl_flag(args, "-text") {
415 true // dumps the private exponent/primes to stdout regardless of -out/-noout/-pubout
416 } else if openssl_flag(args, "-pubout") {
417 false // public-key PEM out, no -text
418 } else {
419 openssl_output_reaches_model(args)
420 }
421 }
422 // PKCS#8 is a private-key format with no public mode; disclosed if it reaches stdout.
423 "pkcs8" => openssl_flag(args, "-text") || openssl_output_reaches_model(args),
424 // Unencrypted key export (`-nodes`/`-noenc`, OpenSSL 3.0 spelling); disclosed if it hits stdout.
425 "pkcs12" => (openssl_flag(args, "-nodes") || openssl_flag(args, "-noenc")) && openssl_output_reaches_model(args),
426 // Symmetric decrypt: plaintext to the model only when it goes to stdout.
427 "enc" => openssl_flag(args, "-d") && openssl_output_reaches_model(args),
428 "smime" => openssl_flag(args, "-decrypt") && openssl_output_reaches_model(args),
429 "cms" => (openssl_flag(args, "-decrypt") || openssl_flag(args, "-EncryptedData_decrypt")) && openssl_output_reaches_model(args),
430 _ => return None, // benign subs — openssl's declarative (allow_all) classification
431 };
432 if discloses {
433 let cap = crate::engine::archetype::archetype("decrypt-read")
434 .cloned()
435 .unwrap_or_else(|| Capability::worst("decrypt-read archetype missing (§0)"));
436 Some(Profile::of(vec![cap]))
437 } else {
438 None // public / to-file / encrypt / benign → legacy allow_all classification
439 }
440}
441
442/// Whether an openssl BOOLEAN flag (`-d`, `-text`, `-pubout`) is present, accepting the `--` twin
443/// openssl honors on every subcommand (`--d`, `--text`). Value flags use [`openssl_flag_value`].
444fn openssl_flag(args: &[Token], flag: &str) -> bool {
445 args.iter().any(|t| {
446 let s = t.as_str();
447 s == flag || (s.starts_with("--") && s.len() > 2 && &s[1..] == flag)
448 })
449}
450
451/// Whether the sub's OUTPUT reaches the model. FAIL-CLOSED (a path string cannot be soundly matched
452/// against a denylist of device spellings — the OS collapses `//dev/stdout`, `/dev/./stdout`,
453/// `/dev/fd//1` to the same device, and openssl honors the LAST of duplicate `-out`s): the output
454/// reaches the model UNLESS it is provably diverted to a single plain FILE. So it's model-reaching
455/// when `-noout` is absent AND NOT (exactly one `-out` whose value is a plain file). `-noout`
456/// suppresses the PEM output (a validate); `-text` is checked by the caller BEFORE this, since it
457/// dumps to stdout past both `-noout` and `-out`.
458fn openssl_output_reaches_model(args: &[Token]) -> bool {
459 if openssl_flag(args, "-noout") {
460 return false;
461 }
462 let outs = openssl_flag_values(args, "-out");
463 // Diverted to disk ONLY when there is exactly one `-out` naming a plain file. No `-out` (default
464 // stdout), a duplicate `-out` (last-wins — the first is untrustworthy), or a device/`-` value all
465 // reach the model.
466 !matches!(outs.as_slice(), [only] if out_value_is_plain_file(only))
467}
468
469/// Whether an `-out` value names a plain FILE (a safe diversion), as opposed to stdout/`-`, or a
470/// device / fd / console path (`/dev/stdout`, `/dev/stderr`, `/dev/fd/1`, `/proc/self/fd/1`). Collapses
471/// redundant `/`, `.`, and `..` segments first so alternate spellings can't evade. Fail-closed: `-`,
472/// empty, or any `/dev/…` or `/proc/…/fd/…` path is NOT a plain file. (Symlinks are classified by their
473/// literal spelling — out of scope for a static classifier, per AGENTS.md.)
474///
475/// A value that is itself a FLAG token (starts with `-`) is NOT proof of diversion: openssl's own
476/// parser lets a preceding valued flag SWALLOW the `-out` token as its value (`-provider-path -out
477/// -provider-path f.pem` leaves openssl with no `-out` → stdout), and our scan then misreads the next
478/// flag as the filename. The tell in every such bypass is a dash-leading `-out` value — reject it.
479fn out_value_is_plain_file(value: &str) -> bool {
480 if value.is_empty() || value.starts_with('-') {
481 return false;
482 }
483 let norm = collapse_path(value).to_ascii_lowercase();
484 let device_or_fd = norm == "/dev" || norm.starts_with("/dev/") || (norm.starts_with("/proc/") && norm.contains("/fd/"));
485 !device_or_fd
486}
487
488/// Collapse a path's redundant `/` / `.` / `..` segments (what the kernel does before opening it), so
489/// `//dev/stdout`, `/dev/./stdout`, `/dev/fd//1`, `/foo/../dev/stdout` all normalize to the device
490/// path. A leading `..` on a relative path is kept (can't resolve above an unknown cwd).
491fn collapse_path(p: &str) -> String {
492 let absolute = p.starts_with('/');
493 let mut stack: Vec<&str> = Vec::new();
494 for seg in p.split('/') {
495 match seg {
496 "" | "." => {}
497 ".." => {
498 if matches!(stack.last(), Some(&s) if s != "..") {
499 stack.pop();
500 } else if !absolute {
501 stack.push("..");
502 }
503 }
504 s => stack.push(s),
505 }
506 }
507 let joined = stack.join("/");
508 if absolute { format!("/{joined}") } else { joined }
509}
510
511/// Every value of a valued openssl flag (`-out file` / `--out file` / `-out=file` / `--out=file`),
512/// accepting the `--` twin — ALL occurrences, in order (openssl honors the last; the caller fails
513/// closed on duplicates).
514fn openssl_flag_values<'a>(args: &'a [Token], flag: &str) -> Vec<&'a str> {
515 let twin = format!("-{flag}"); // `-out` → `--out`
516 let mut out = Vec::new();
517 let mut i = 0;
518 while i < args.len() {
519 let s = args[i].as_str();
520 if let Some(v) = s.strip_prefix(flag).or_else(|| s.strip_prefix(twin.as_str())).and_then(|r| r.strip_prefix('=')) {
521 out.push(v);
522 } else if (s == flag || s == twin)
523 && let Some(next) = args.get(i + 1)
524 {
525 out.push(next.as_str());
526 i += 1;
527 }
528 i += 1;
529 }
530 out
531}
532
533/// Classify a network-destination token's PROVENANCE (exposure §4). `None` (a bare invocation) is
534/// the configured default → `Established`. A command-transport form (`ext::<cmd>`) is not a
535/// destination but LOCAL CODE, signalled by a `None` return so the caller worst-cases it as RCE.
536fn destination_provenance(dest: Option<&str>) -> Option<Provenance> {
537 let Some(tok) = dest else {
538 return Some(Provenance::Established);
539 };
540 if tok.starts_with("ext::") {
541 return None; // `git push ext::sh -c …` runs a local command — RCE, not egress
542 }
543 // A variable / substitution: the actual target is not in the command string, so it cannot be
544 // reviewed — the fail-closed case.
545 if tok.contains('$') || tok.contains('`') {
546 return Some(Provenance::Opaque);
547 }
548 // Spelled inline: a URL scheme, an scp-style `user@host:path`, or a filesystem path. Otherwise a
549 // bare word is a reference to a configured remote (established by a prior `clone`/`remote add`).
550 let literal = tok.contains("://")
551 || (tok.contains('@') && tok.contains(':'))
552 || tok.starts_with('/')
553 || tok.starts_with("./")
554 || tok.starts_with("../");
555 Some(if literal { Provenance::Literal } else { Provenance::Established })
556}
557
558/// The generic, declaration-driven resolver: build a `Profile` from a command's
559/// `[command.behavior]` (`BehaviorSpec`) and its tokens. This is the non-legacy classification
560/// path expressed in TOML — the operation + operand-role + flag grammar are data, and this one
561/// function replaces a hardcoded `resolve_*`. Irreducible token logic a declaration can't
562/// express is delegated to a named `hook`.
563fn resolve_behavior(spec: &crate::registry::types::BehaviorSpec, tokens: &[Token]) -> Profile {
564 use crate::registry::types::{BehaviorHook, PositionalRole};
565 if let Some(hook) = spec.hook {
566 return match hook {
567 // grep's hook supplies the operand set (the irreducible token logic); the declared
568 // operation + the builders supply the facets — the composition seam (§8). grep is
569 // observe-only, so its operands become content reads.
570 BehaviorHook::Grep => {
571 let Some(g) = grep_operands(tokens) else {
572 return worst("grep: unrecognized flag or missing pattern — worst-cased (§0)");
573 };
574 let mut caps: Vec<Capability> = g
575 .pattern_files
576 .iter()
577 .map(|f| reads_path(f, Scale::Single, "reads a grep -f pattern file"))
578 .collect();
579 caps.extend(reads_to_model(&g.files, g.scale));
580 Profile::of(caps)
581 }
582 // dd/tar/sed parse their own irregular operand syntax (`key=value`, dashless mode
583 // bundles, a mini-language script) AND build their own multi-role profiles, so their
584 // hook returns the full `Profile` — the parser and the facets are entangled with the
585 // parse and stay in Rust (their DATA — flag/param sets — is small and audited).
586 BehaviorHook::Dd => resolve_dd(tokens),
587 BehaviorHook::Tar => resolve_tar(tokens),
588 BehaviorHook::Sed => resolve_sed(tokens),
589 BehaviorHook::Perl => resolve_perl(tokens),
590 };
591 }
592 // No path operands (echo): a pure stdout emitter, handled BEFORE the flag walk — echo has no
593 // flag grammar (it prints any `-x` verbatim), so walking would wrongly reject it. `observe`
594 // with model disclosure and no fs/net/exec; its args touch nothing.
595 if matches!(spec.positionals, PositionalRole::None) {
596 return match spec.operation {
597 Operation::Observe => {
598 let mut c = Capability::new(Operation::Observe);
599 c.disclosure.audience = DisclosureAudience::LocalProcess;
600 c.because = "behavior: prints its arguments to stdout; no fs/net/exec/secret".to_string();
601 Profile::of(vec![c])
602 }
603 _ => worst("behavior: none-operand role supports only observe (§0)"),
604 };
605 }
606 let long: Vec<&str> = spec.long.iter().map(String::as_str).collect();
607 let valued_long: Vec<&str> = spec.valued_long.iter().map(String::as_str).collect();
608 let Some(operands) = walk_positionals(&spec.short, &spec.valued_short, &long, &valued_long, spec.numeric_shorthand, tokens) else {
609 return worst("behavior: unrecognized flag — worst-cased (§0)");
610 };
611 let scale = behavior_scale(spec, &operands, tokens);
612 // Path-flag values (e.g. `touch -r REF`) are gated alongside the positional operands.
613 let flag_caps = path_flag_caps(spec, tokens);
614 match spec.positionals {
615 PositionalRole::Read => {
616 let mut caps = reads_to_model(&operands, scale);
617 caps.extend(flag_caps);
618 Profile::of(caps)
619 }
620 PositionalRole::Write => {
621 if operands.is_empty() {
622 // `rm --help` prints usage and exits. It is not a write whose target is hidden, so
623 // worst-casing it denied every informational invocation of every write command:
624 // `rm --help`, `mkdir --help`, `rmdir --version`. The flag already passed the
625 // command's own grammar to get here, and no operand survived the walk.
626 //
627 // LONG forms only, the same rule and the same reasoning the output-claim voider
628 // uses below: `-h`/`-V` are not reliably help/version (`sort -h` is human-numeric
629 // sort), so honoring the short spellings here would be guessing.
630 if tokens.iter().skip(1).any(|t| matches!(t.as_str(), "--help" | "--version")) {
631 let mut c = Capability::new(Operation::Observe);
632 c.disclosure.audience = DisclosureAudience::LocalProcess;
633 c.because = "behavior: prints usage and exits; nothing is written".to_string();
634 return Profile::of(vec![c]);
635 }
636 return worst("behavior: write operation with no operand — worst-cased (§0)");
637 }
638 let mut caps: Vec<Capability> = operands
639 .iter()
640 .map(|p| match spec.operation {
641 // A destroy UNBINDS the name, so it reads the rebind face: `rm -rf ~/.config`
642 // removes what the trust root points at, while `touch ~/.config/x` does not.
643 Operation::Destroy => destroys(locus::rebind_locus(p), scale),
644 Operation::Create => creates(classify_locus(p), scale),
645 Operation::Mutate => mutates(classify_locus(p), scale, "behavior: in-place mutate"),
646 _ => Capability::worst("behavior: unsupported write operation — worst-cased (§0)"),
647 })
648 .collect();
649 caps.extend(flag_caps);
650 Profile::of(caps)
651 }
652 PositionalRole::Transfer => resolve_transfer(spec, operands, flag_caps, tokens),
653 // None is handled above (before the flag walk); pattern-then-read routes through a hook
654 // (grep). Neither reaches here, so both fail closed.
655 PositionalRole::None | PositionalRole::PatternThenRead => worst("behavior: operand role not resolvable without a hook (§0)"),
656 }
657}
658
659/// The transfer arm of `resolve_behavior` (cp/mv/ln): split the operands into sources and a
660/// destination (`-t`/`--target-directory` value, else the last operand), gate each at its locus
661/// — a relocate source at its WRITE face — and fold in any path-flag capabilities. Fails closed
662/// on a missing spec, a missing dest, or a `-t` dest with no sources.
663fn resolve_transfer(
664 spec: &crate::registry::types::BehaviorSpec,
665 operands: Vec<&str>,
666 flag_caps: Vec<Capability>,
667 tokens: &[Token],
668) -> Profile {
669 use crate::registry::types::TransferSource;
670 let Some(t) = &spec.transfer else {
671 return worst("behavior: transfer role without transfer spec — worst-cased (§0)");
672 };
673 // Whether the destination is DEFINITIVELY a container rather than the entry being created.
674 // `-t DIR` says so outright, and with two or more sources the last operand must be a directory
675 // for the command to make sense at all. Only the two-operand form is ambiguous, and there the
676 // conservative reading (the destination is the entry) is the safe one.
677 let (sources, dest, dest_is_container) = if let Some(d) = walk_value(&spec.valued_short, tokens, b't', "--target-directory") {
678 if operands.is_empty() {
679 return worst("behavior: transfer -t with no source operand — worst-cased (§0)");
680 }
681 (operands, d, true)
682 } else {
683 match operands.split_last() {
684 Some((last, rest)) if !rest.is_empty() => (rest.to_vec(), *last, rest.len() >= 2),
685 _ => return worst("behavior: transfer needs a source and a destination — worst-cased (§0)"),
686 }
687 };
688 let no_clobber = if t.clobber_flags.is_empty() {
689 t.no_clobber_flags.iter().any(|f| behavior_flag_present(tokens, f))
690 } else {
691 // A clobber flag PRESENT means overwrite; its absence is the no-clobber default.
692 !t.clobber_flags.iter().any(|f| behavior_flag_present(tokens, f))
693 };
694 let recursive = t.recursive_flags.iter().any(|f| behavior_flag_present(tokens, f));
695 let transfer_scale = breadth_scale(&sources, recursive);
696 // A relocate REMOVES its source, so the source name stops referring to anything: that is a
697 // REBIND, not merely a write, and it is what makes `mv ~/.config elsewhere` a relocation of the
698 // trust root rather than an edit of it.
699 let source_face = match t.source {
700 TransferSource::Relocate => locus::Face::Rebind,
701 TransferSource::Observe => locus::Face::Read,
702 };
703 // `ln` points the destination NAME at something else; `cp`/`mv` write bytes at or under it.
704 // Both are `create`/`transfer`, so only the command's own declaration separates them.
705 //
706 // But the declaration is about the ENTRY the command creates, and `ln -t DIR a` or
707 // `ln a b DIR` puts that entry INSIDE the directory instead of replacing it. Treating those as
708 // rebinds denied `ln -t ~/.config a`, which is an ordinary link into a directory you granted —
709 // the same container-versus-object mistake the write face made before this face existed.
710 let dest_face = if t.rebinds_destination && !dest_is_container { locus::Face::Rebind } else { locus::Face::Write };
711 let mut prof = transfer_profile(
712 &sources,
713 dest,
714 transfer_scale,
715 source_face,
716 dest_face,
717 |loc, sc| match t.source {
718 TransferSource::Observe => observes(loc, sc, "transfer reads the source at its locus"),
719 TransferSource::Relocate => relocates(loc, sc),
720 },
721 |loc, sc| overwrites(loc, sc, no_clobber),
722 );
723 prof.capabilities.extend(flag_caps);
724 prof
725}
726
727/// Capabilities for a command's declared PATH-FLAGS: a valued flag whose value is a path
728/// (`touch -r REF` reads REF's timestamp) is gated by its role's locus, exactly like an operand
729/// — so an out-of-workspace value denies. Folds the `[command.path_gate]` idea into behavior.
730fn path_flag_caps(spec: &crate::registry::types::BehaviorSpec, tokens: &[Token]) -> Vec<Capability> {
731 use crate::registry::types::PathRole;
732 let mut caps = Vec::new();
733 for pf in &spec.path_flags {
734 let short = pf.short.unwrap_or(0);
735 let long = pf.long.as_deref().unwrap_or("");
736 if let Some(v) = walk_value(&spec.valued_short, tokens, short, long) {
737 caps.push(match pf.role {
738 PathRole::Read => observes_path(v, Scale::Single, "behavior: a flag value is a read path"),
739 PathRole::Write => mutates(write_locus(v), Scale::Single, "behavior: a flag value is a write path"),
740 });
741 }
742 }
743 caps
744}
745
746/// The `Scale` for a behavior resolution: `single` always yields one item; `breadth` widens on
747/// operand count, a glob, or a declared unbounded flag (`rm -r`) via `breadth_scale`.
748fn behavior_scale(spec: &crate::registry::types::BehaviorSpec, operands: &[&str], tokens: &[Token]) -> Scale {
749 use crate::registry::types::ScaleModel;
750 match spec.scale {
751 ScaleModel::Single => Scale::Single,
752 ScaleModel::Breadth => {
753 let recursive = spec.unbounded_flags.iter().any(|f| behavior_flag_present(tokens, f));
754 breadth_scale(operands, recursive)
755 }
756 }
757}
758
759/// Whether a declared behavior flag (a bare token like `-r` or `--recursive`) is present,
760/// via the shared `has_flag` (which handles short clustering and `--flag=value`).
761fn behavior_flag_present(tokens: &[Token], flag: &str) -> bool {
762 if flag.starts_with("--") { has_flag(tokens, None, Some(flag)) } else { has_flag(tokens, Some(flag), None) }
763}
764
765/// A command name with no resolver and no plausible future one — the stable stand-in for
766/// "unresearched" across engine tests. Using a real tool here is a trap: when `rm` gained
767/// a resolver, three tests that used `rm` as their unresearched example silently broke.
768/// A name that will never be a real tool can never be silently repurposed.
769#[cfg(test)]
770pub(crate) const UNRESOLVED_CMD: &[&str] = &["safe-chains-unresolved-sentinel"];
771
772/// Whether `arg0` is a trusted way to invoke a standard tool: a bare name (found via
773/// `$PATH`) or an absolute path under a standard system bin directory. A path elsewhere
774/// (`./x`, `/tmp/x`, `~/bin/x`) may be an impostor.
775fn trusted_command_path(arg0: &str) -> bool {
776 const STD_BINS: &[&str] = &["/usr/bin/", "/bin/", "/usr/local/bin/", "/opt/homebrew/bin/", "/sbin/", "/usr/sbin/"];
777 !arg0.contains('/') || STD_BINS.iter().any(|p| arg0.starts_with(p))
778}
779
780/// The classified operand set of a `grep` invocation: the positional file operands (read at
781/// `scale`, empty = stdin) and the `-f`/`--file` pattern files (each read once). This is the
782/// irreducible token logic a `[command.behavior]` declaration can't express — grep's
783/// pattern-vs-file disambiguation, `-e`/`-f` pattern flags, and the unknown-`--token`-is-a-
784/// pattern heuristic. The declared `operation` (observe) and the builders turn these operands
785/// into capabilities in `resolve_behavior`'s hook arm; this function assigns no facets.
786struct GrepOperands<'a> {
787 files: Vec<&'a str>,
788 pattern_files: Vec<&'a str>,
789 scale: Scale,
790}
791
792/// Walk a `grep` command into its `GrepOperands`, or `None` to fail closed (unrecognized flag,
793/// or no pattern operand). The behavior hook (`BehaviorHook::Grep`) for `commands/text/grep.toml`.
794fn grep_operands(tokens: &[Token]) -> Option<GrepOperands<'_>> {
795 // `-r` (or --recursive); `-R`/--dereference-recursive is not benign and worst-cases
796 // in the walk below, so it needn't be detected here.
797 let recursive = has_flag(tokens, Some("-r"), Some("--recursive"));
798 let scale = if recursive { Scale::Unbounded } else { Scale::Single };
799
800 let mut files = Vec::new(); // positional file operands
801 let mut pattern_files = Vec::new(); // -f/--file pattern files grep reads
802 let mut pattern_from_flag = false;
803 let mut unknown_flag = false;
804 let mut flags_done = false;
805 let mut i = 1;
806 while i < tokens.len() {
807 let t = tokens[i].as_str();
808 let next = tokens.get(i + 1).map(Token::as_str);
809 if !flags_done && t == "--" {
810 flags_done = true;
811 i += 1;
812 } else if flags_done || !t.starts_with('-') || t == "-" {
813 files.push(t);
814 i += 1;
815 } else if t.starts_with("--") {
816 if let Some(v) = t.strip_prefix("--file=") {
817 pattern_from_flag = true;
818 pattern_files.push(v);
819 i += 1;
820 } else if t == "--file" {
821 pattern_from_flag = true;
822 pattern_files.extend(next);
823 i += 2;
824 } else if t == "--regexp" {
825 pattern_from_flag = true;
826 i += 2;
827 } else if t.starts_with("--regexp=") {
828 pattern_from_flag = true;
829 i += 1;
830 } else if grep_long_known(t) {
831 i += 1;
832 } else if grep_long_dangerous(t) {
833 unknown_flag = true;
834 i += 1;
835 } else {
836 // An unrecognized `--token` is not a grep flag: it is the search PATTERN
837 // (grep patterns commonly look like `-->`, `---`, `--foo`). Treat it as a
838 // positional so the file operands classify the read, matching legacy.
839 files.push(t);
840 i += 1;
841 }
842 } else {
843 match grep_short_cluster(t, next) {
844 GrepShort::Unrecognized => {
845 unknown_flag = true;
846 i += 1;
847 }
848 GrepShort::Standalone => i += 1,
849 GrepShort::Pattern { file, consumes_next } => {
850 pattern_files.extend(file);
851 pattern_from_flag = true;
852 i += if consumes_next { 2 } else { 1 };
853 }
854 GrepShort::SkipValue { consumes_next } => i += if consumes_next { 2 } else { 1 },
855 }
856 }
857 }
858
859 if unknown_flag {
860 return None; // unrecognized flag → fail closed (§0)
861 }
862 if files.is_empty() {
863 // No positional operand → grep has no pattern (a `-e`/`-f` pattern still needs a
864 // search target). This is a usage error; the legacy classifier denies it, so the
865 // engine must not be looser — fail closed (§0).
866 return None;
867 }
868
869 if !pattern_from_flag {
870 files.remove(0); // the first positional is the PATTERN, not a file
871 }
872 if recursive && files.is_empty() {
873 files.push("."); // grep -r with no path searches the cwd
874 }
875
876 Some(GrepOperands { files, pattern_files, scale })
877}
878
879/// The outcome of parsing one grep short-option cluster.
880enum GrepShort<'a> {
881 /// An unrecognized short (e.g. `-R`, symlink-dereferencing recursive) → the caller worst-cases.
882 Unrecognized,
883 /// All chars benign; no value taken.
884 Standalone,
885 /// `-e`/`-f` supplied the pattern (so positionals are files); `-f`'s value, if any,
886 /// is a pattern file grep reads.
887 Pattern { file: Option<&'a str>, consumes_next: bool },
888 /// `-m`/`-A`/`-B`/`-C`/`-d` — a count/action value to skip.
889 SkipValue { consumes_next: bool },
890}
891
892/// Parse a grep short-option cluster (e.g. `-ifpatterns`), honoring GNU semantics that a
893/// value-taking short consumes the rest of its cluster (glued) or the next token.
894fn grep_short_cluster<'a>(cluster: &'a str, next: Option<&'a str>) -> GrepShort<'a> {
895 // NB: `r` (recursive) is benign, but `R` (--dereference-recursive) follows symlinks
896 // and can escape the classified locus, so it is NOT benign — it worst-cases. `P`
897 // (PCRE, `--perl-regexp`) IS benign: GNU grep's PCRE2 does not implement Perl's
898 // `(?{code})` execution, so it runs no code — it's just another regex engine like `-E`/`-F`.
899 const BENIGN: &[u8] = b"ivnclLoqswxHhaIrzZEFGbUP";
900 let bytes = cluster.as_bytes();
901 let mut k = 1;
902 while k < bytes.len() {
903 // Non-ASCII bytes aren't flags and would make `cluster[k + 1..]` slice mid-char.
904 if !bytes[k].is_ascii() {
905 return GrepShort::Unrecognized;
906 }
907 let glued = &cluster[k + 1..]; // safe: bytes[k] is ASCII → k+1 is a char boundary
908 let has = !glued.is_empty();
909 match bytes[k] {
910 b'f' => {
911 let file = if has { Some(glued) } else { next };
912 return GrepShort::Pattern { file, consumes_next: !has };
913 }
914 b'e' => return GrepShort::Pattern { file: None, consumes_next: !has },
915 b'm' | b'A' | b'B' | b'C' | b'd' => return GrepShort::SkipValue { consumes_next: !has },
916 b if BENIGN.contains(&b) => k += 1,
917 _ => return GrepShort::Unrecognized,
918 }
919 }
920 GrepShort::Standalone
921}
922
923/// Whether a grep long flag (its `--name`, ignoring any `=value`) is recognized-benign.
924/// `--dereference-recursive` and anything unlisted are not → worst-case (§0).
925fn grep_long_known(flag: &str) -> bool {
926 const KNOWN: &[&str] = &[
927 "--recursive", "--ignore-case", "--invert-match", // NB: --dereference-recursive
928 // (symlink-following) is intentionally absent → worst-case (M2)
929 "--line-number", "--count", "--files-with-matches", "--files-without-match", "--only-matching", "--perl-regexp", "--word-regexp",
930 "--line-regexp", "--fixed-strings", "--extended-regexp", "--basic-regexp", "--with-filename", "--no-filename", "--quiet",
931 "--silent", "--no-messages", "--null", "--byte-offset", "--text", "--color", "--colour", "--help", "--version", "--after-context",
932 "--before-context", "--context", "--max-count", "--include", "--exclude", "--exclude-dir", "--include-dir", "--binary-files",
933 "--devices", "--directories",
934 ];
935 let name = flag.split('=').next().unwrap_or(flag);
936 KNOWN.contains(&name)
937}
938
939/// The long spelling of the dangerous grep short `-R`: `--dereference-recursive` (follows
940/// symlinks out of the classified locus, M2). Recognized so both spellings worst-case; every
941/// OTHER unrecognized `--token` is a search pattern, not a flag. (`--perl-regexp`/`-P` is NOT
942/// here — PCRE2 executes no code, so it is benign, like `-E`/`-F`.)
943fn grep_long_dangerous(flag: &str) -> bool {
944 let name = flag.split('=').next().unwrap_or(flag);
945 matches!(name, "--dereference-recursive")
946}
947
948/// `dd if=IN of=OUT bs=… …` — the operand-model breaker: `dd` takes NO getopt flags or
949/// positionals, only `key=value` operands, so the shared `Flags`/`positionals` toolkit does
950/// not apply and it parses its own. `if=` reads (default stdin), `of=` writes (default
951/// stdout). It is still a transfer at the facet level — `dd if=~/.ssh/id_rsa of=./x` denies
952/// on the input locus, `dd if=./x of=/dev/rdisk0` denies on the output locus (a raw device
953/// is beneath the fs) — but the roles arrive inside `key=value`, not positional slots, which
954/// is why its conservation probe is `Operands::Custom`. `bs`/`count`/`conv`/… are benign
955/// transfer parameters; any other key, or a non-`key=value` operand, worst-cases (§0).
956fn resolve_dd(tokens: &[Token]) -> Profile {
957 const PARAMS: &[&str] = &["bs", "ibs", "obs", "cbs", "count", "skip", "seek", "conv", "iflag", "oflag", "status"];
958 let (mut input, mut output) = (None, None);
959 for t in &tokens[1..] {
960 let t = t.as_str();
961 if t == "--help" || t == "--version" {
962 continue;
963 }
964 let Some((key, val)) = t.split_once('=') else {
965 return worst("dd: non key=value operand — worst-cased (§0)");
966 };
967 match key {
968 "if" => input = Some(val),
969 "of" => output = Some(val),
970 k if PARAMS.contains(&k) => {}
971 _ => return worst("dd: unrecognized operand — worst-cased (§0)"),
972 }
973 }
974 // dd touches exactly one input and one output — a `single` blast radius, whatever the
975 // data VOLUME. The disk-wipe danger of `of=/dev/rdisk0` is carried by its device locus,
976 // not by scale.
977 // Built from the PATH, not just its locus: the locus says which rung `if=` reaches, and the
978 // shield is what says whether the file on that rung is a credential store. Reading the rung
979 // alone let `dd if=/etc/shadow of=./safe` copy a file `cat /etc/shadow` refuses, then read the
980 // copy out of the worktree — the shield was never asked.
981 match output {
982 // of= names a sink: read the input into it (no model disclosure) + write the sink.
983 Some(of) => Profile::of(vec![
984 match input {
985 Some(i) => observes_path(i, Scale::Single, "dd reads its input (if=) into the output"),
986 None => observes(LocalLocus::Process, Scale::Single, "dd reads stdin into the output"),
987 },
988 overwrites(classify_locus(of), Scale::Single, false),
989 ]),
990 // no of= → output is stdout, so the input content reaches the model (like `cat`).
991 None => Profile::of(vec![match input {
992 Some(i) => reads_path(i, Scale::Single, "dd copies its input to stdout (→ the model)"),
993 None => reads_content(LocalLocus::Process, Scale::Single, "dd copies stdin to stdout (→ the model)"),
994 }]),
995 }
996}
997
998/// `tar` — the flag-SYNTAX breaker: its options may be written WITHOUT a leading dash
999/// (`tar czf` == `tar -czf`), so the getopt walker misreads the cluster as a positional; tar
1000/// parses its own. The mode letter splits the profile sharply:
1001/// - create/append (`c`/`r`/`u`): reads each member (source) + writes the archive (dest) —
1002/// a bundler, so `tar czf - ~/.ssh` denies on the member locus (golden-set).
1003/// - list (`t`): reads the archive, prints member names to the model.
1004/// - extract (`x`) and the rarer modes: extraction writes an ARCHIVE-CONTROLLED set of
1005/// paths that `..`-traversal can send anywhere — unknowable without opening the archive,
1006/// so worst-case (§0). Any value-taking option we don't model (`-C`, `-T`, …) or an
1007/// unknown letter also worst-cases.
1008fn resolve_tar(tokens: &[Token]) -> Profile {
1009 let mut p = TarParse::default();
1010 // `-C DIR` changes the directory for the members that FOLLOW it, so a member's real locus
1011 // is `DIR/member` — the same `find … {}`→path binding. tar applies `-C` CUMULATIVELY: each
1012 // `-C` chdir's relative to the already-changed directory, so consecutive `-C / -C etc`
1013 // resolves to `/etc`, not `etc`. Compose relative values onto the active dir (via the same
1014 // `tar_bound` join, which also lets an absolute value replace and routes any `..` through
1015 // the unpinnable guard); stamp each positional with the accumulated dir.
1016 let mut dir: Option<String> = None;
1017 let mut i = 1;
1018 while i < tokens.len() {
1019 let t = tokens[i].as_str();
1020 if t == "-C" || t == "--directory" {
1021 dir = tokens.get(i + 1).map(|d| tar_bound(dir.as_deref(), d.as_str()));
1022 i += 2;
1023 continue;
1024 }
1025 if let Some(d) = t.strip_prefix("--directory=").or_else(|| t.strip_prefix("-C").filter(|d| !d.is_empty())) {
1026 dir = Some(tar_bound(dir.as_deref(), d));
1027 i += 1;
1028 continue;
1029 }
1030 if let Some(long) = t.strip_prefix("--") {
1031 p.long_option(long);
1032 } else if let Some(cluster) = t.strip_prefix('-').filter(|c| !c.is_empty()) {
1033 p.cluster(cluster);
1034 } else if i == 1 {
1035 p.cluster(t); // dashless old-style option bundle (only the first argument)
1036 } else {
1037 p.positionals.push((dir.clone(), t));
1038 }
1039 i += 1;
1040 }
1041 p.into_profile()
1042}
1043
1044/// A tar positional: a member/archive path with the accumulated `-C` directory active when it
1045/// appeared (already composed across consecutive `-C` options).
1046type TarPositional<'a> = (Option<String>, &'a str);
1047
1048/// A tar positional borrowed for classification: (`-C` dir, path).
1049type TarRef<'a> = (Option<&'a str>, &'a str);
1050
1051/// A tar member/archive path resolved against an active `-C` directory: `DIR/path` for a
1052/// relative path, or `path` unchanged when there is no `-C` or the path is absolute (an
1053/// absolute member ignores `-C`).
1054fn tar_bound(dir: Option<&str>, path: &str) -> String {
1055 match dir {
1056 Some(d) if !path.starts_with('/') && !path.starts_with('~') && !path.starts_with('-') => {
1057 format!("{}/{}", d.trim_end_matches('/'), path)
1058 }
1059 _ => path.to_string(),
1060 }
1061}
1062
1063/// Accumulated `tar` parse: the mode, whether `-f` wants an archive, and `reject` — set by
1064/// any option we can't model safely (an unknown letter, or a value-taking option like `-T`
1065/// / `-X` whose ordered operand consumption we don't track). `-C` IS modeled (see
1066/// `resolve_tar`); it only reaches `cluster` inside a mixed bundle, which still worst-cases.
1067#[derive(Default)]
1068struct TarParse<'a> {
1069 mode: Option<u8>,
1070 want_archive: bool,
1071 reject: bool,
1072 long_archive: Option<&'a str>,
1073 /// Each positional with the `-C` directory active when it appeared (`None` = cwd).
1074 positionals: Vec<TarPositional<'a>>,
1075}
1076
1077impl<'a> TarParse<'a> {
1078 fn cluster(&mut self, cluster: &str) {
1079 const NOVAL: &[u8] = b"vzjJZpkmOwhSlPa"; // benign no-value option letters
1080 for b in cluster.bytes() {
1081 match b {
1082 b'c' | b'x' | b't' | b'r' | b'u' | b'A' | b'd' => self.mode = Some(b),
1083 b'f' => self.want_archive = true,
1084 b'C' | b'T' | b'X' | b'b' | b'H' | b'g' | b'K' | b'N' => self.reject = true,
1085 x if NOVAL.contains(&x) => {}
1086 _ => self.reject = true,
1087 }
1088 }
1089 }
1090
1091 fn long_option(&mut self, long: &'a str) {
1092 let name = long.split('=').next().unwrap_or(long);
1093 match name {
1094 "create" => self.mode = Some(b'c'),
1095 "extract" | "get" => self.mode = Some(b'x'),
1096 "list" => self.mode = Some(b't'),
1097 "append" => self.mode = Some(b'r'),
1098 "update" => self.mode = Some(b'u'),
1099 "file" => match long.split_once('=') {
1100 Some((_, v)) => self.long_archive = Some(v),
1101 None => self.want_archive = true,
1102 },
1103 "gzip"
1104 | "bzip2"
1105 | "xz"
1106 | "zstd"
1107 | "compress"
1108 | "verbose"
1109 | "preserve-permissions"
1110 | "same-permissions"
1111 | "to-stdout"
1112 | "help"
1113 | "version"
1114 | "dereference"
1115 | "totals" => {}
1116 _ => self.reject = true,
1117 }
1118 }
1119
1120 fn into_profile(self) -> Profile {
1121 let Some(mode) = self.mode.filter(|_| !self.reject) else {
1122 return worst("tar: unrecognized/unmodeled option — worst-cased (§0)");
1123 };
1124 // Separate the archive from the members. `--file=X` names it directly; a bare `f`
1125 // (dashless `czf` or dashed `-czf`) takes the FIRST positional as the archive.
1126 let (archive, members): (Option<TarRef>, &[TarPositional]) = if let Some(a) = self.long_archive {
1127 (Some((None, a)), &self.positionals)
1128 } else if self.want_archive {
1129 match self.positionals.split_first() {
1130 Some((first, rest)) => (Some((first.0.as_deref(), first.1)), rest),
1131 None => return worst("tar: -f without an archive — worst-cased (§0)"),
1132 }
1133 } else {
1134 (None, &self.positionals) // archive is stdin/stdout
1135 };
1136 // A `-` archive (or none) is a stdout/stdin stream, not a file to gate.
1137 let archive_file = archive.filter(|(_, a)| *a != "-");
1138
1139 match mode {
1140 b'c' | b'r' | b'u' => {
1141 let mut caps: Vec<Capability> = members
1142 .iter()
1143 // UNBOUNDED, not bounded: a member that is a directory is archived with
1144 // everything under it, so `tar -cf x.tar ~` packs every key in home into a
1145 // worktree file that is then ordinary to read. The member names the root of a
1146 // sweep, not a file, and the shield cannot clear a root.
1147 .map(|(dir, m)| observes_path(&tar_bound(dir.as_deref(), m), Scale::Unbounded, "tar reads a member into the archive"))
1148 .collect();
1149 if let Some((dir, a)) = archive_file {
1150 caps.push(overwrites(classify_locus(&tar_bound(dir, a)), Scale::Single, false));
1151 }
1152 if caps.is_empty() {
1153 return worst("tar create with no members — worst-cased (§0)");
1154 }
1155 Profile::of(caps)
1156 }
1157 b't' => {
1158 // Gated on the archive's PATH, not just its rung: `tar tf /etc/shadow` opens the
1159 // credential store and reports what it found there, which is a read of it however
1160 // poorly it parses as an archive.
1161 Profile::of(vec![match archive_file {
1162 Some((dir, a)) => reads_path(&tar_bound(dir, a), Scale::Single, "tar lists the archive's members (names → the model)"),
1163 None => reads_content(LocalLocus::Process, Scale::Single, "tar lists stdin's members (names → the model)"),
1164 }])
1165 }
1166 // x (extract) and A/d: archive-controlled, ..-escapable writes → worst-case.
1167 _ => worst("tar extract writes an archive-controlled, ..-escapable path set — worst-cased (§0)"),
1168 }
1169 }
1170}
1171
1172/// `sed` — the read-becomes-WRITE breaker: `sed 's/…/…/' FILE` reads FILE and prints to the
1173/// model, but `sed -i` edits the SAME file operands **in place** (a mutate), so a single
1174/// flag flips the operation on the same slots. Two more wrinkles: `-i` takes an OPTIONAL
1175/// glued suffix (`-i.bak`) the getopt walker can't express, and — like `grep` — the first
1176/// positional is the SCRIPT unless `-e`/`-f` supplied it (`-f` also reads a script file).
1177/// So `sed` parses its own flags.
1178fn resolve_sed(tokens: &[Token]) -> Profile {
1179 // HP-7: sed is a mini-language. Its `e` command/modifier executes text as a shell command
1180 // (RCE), and its `w`/`W`/`r`/`R` commands write/read arbitrary files EMBEDDED in the script —
1181 // both invisible to flag parsing. Scan the script(s): an `e`/unknown command worst-cases; the
1182 // file commands' filenames get gated by locus below (a local write is fine, `/etc/cron.d/x` is
1183 // not), exactly like the operand files.
1184 let script = crate::handlers::coreutils::sed::scan_sed(tokens);
1185 if script.exec || script.unknown {
1186 return worst("sed: script has an `e` exec or unmodeled command — worst-cased (§0, HP-7)");
1187 }
1188 // A `-f`/`--file` script comes from a file we can't read — its `e`/`w`/`r` commands are invisible,
1189 // so we can't verify it (like `awk -f`, `bash script.sh`, mlr `--load`). Worst-case it.
1190 if script.script_file {
1191 return worst("sed: -f runs a script file we can't inspect — worst-cased (§0)");
1192 }
1193 const BOOL: &[u8] = b"nrEsuz"; // no-value short flags
1194 let mut in_place = false;
1195 let mut script_from_flag = false;
1196 let mut script_files: Vec<&str> = Vec::new(); // -f FILE — sed reads these
1197 let mut files: Vec<&str> = Vec::new();
1198 let mut flags_done = false;
1199 let mut i = 1;
1200 while i < tokens.len() {
1201 let t = tokens[i].as_str();
1202 let next = tokens.get(i + 1).map(Token::as_str);
1203 if !flags_done && t == "--" {
1204 flags_done = true;
1205 i += 1;
1206 } else if flags_done || t == "-" || !t.starts_with('-') {
1207 files.push(t);
1208 i += 1;
1209 } else if let Some(long) = t.strip_prefix("--") {
1210 match sed_long(long, next, &mut in_place, &mut script_from_flag, &mut script_files) {
1211 Some(consumed) => i += consumed,
1212 None => return worst("sed: unrecognized flag — worst-cased (§0)"),
1213 }
1214 } else {
1215 match sed_cluster(&t[1..], next, BOOL) {
1216 SedShort::Bad => return worst("sed: unrecognized flag — worst-cased (§0)"),
1217 SedShort::InPlace { consumes_next } => {
1218 in_place = true;
1219 i += usize::from(consumes_next) + 1;
1220 }
1221 SedShort::Standalone => i += 1,
1222 SedShort::Script { consumes_next } => {
1223 script_from_flag = true;
1224 i += usize::from(consumes_next) + 1;
1225 }
1226 SedShort::ScriptFile { file, consumes_next } => {
1227 script_from_flag = true;
1228 script_files.extend(file);
1229 i += usize::from(consumes_next) + 1;
1230 }
1231 SedShort::SkipValue { consumes_next } => i += usize::from(consumes_next) + 1,
1232 }
1233 }
1234 }
1235 // Without -e/-f, the first positional is the SCRIPT, not a file.
1236 if !script_from_flag && !files.is_empty() {
1237 files.remove(0);
1238 }
1239 // Blast radius: a glob (`sed -i … *`) or several operands is bounded, not single — so a
1240 // sweeping in-place edit is scored honestly (still worktree-bound by locus; a system or
1241 // home path denies whatever the scale).
1242 let scale = breadth_scale(&files, false);
1243 let mut caps: Vec<Capability> = script_files
1244 .iter()
1245 .map(|f| observes_path(f, Scale::Single, "sed reads an -f script file"))
1246 .collect();
1247 // Script-embedded file commands (`w`/`W` write, `r`/`R` read, `s///w` write) — gate each target
1248 // by its locus, just like an operand file.
1249 caps.extend(script.writes.iter().map(|f| mutates(classify_locus(f), Scale::Single, "sed w/W writes a file")));
1250 caps.extend(script.reads.iter().map(|f| observes_path(f, Scale::Single, "sed r/R reads a file")));
1251 if in_place {
1252 caps.extend(files.iter().map(|f| mutates(classify_locus(f), scale, "sed -i edits the file in place")));
1253 caps.extend(
1254 backup::in_place_backups(tokens, &files, true)
1255 .iter()
1256 .map(|b| mutates(classify_locus(b), scale, "sed -i writes a backup")),
1257 );
1258 } else {
1259 caps.extend(reads_to_model(&files, scale));
1260 }
1261 Profile::of(caps)
1262}
1263
1264/// The locus of the paths a `$( … )` can PRODUCE, or `None` when nothing bounds them.
1265///
1266/// This is a different question from "is the inner command safe to run", and conflating the two is
1267/// a fail-open: `echo` is inert and `$(echo /etc/shadow)` still names a credential file. So a
1268/// command only gets an answer here if it has declared one (`[command.output]`); everything else
1269/// stays unpinnable, exactly as before. See docs/design/behavioral-taxonomy-substitution-locus.md.
1270pub(crate) fn substitution_claim(script: &crate::cst::Script) -> Option<SubClaim> {
1271 // A pipeline's VALUE is its last stage's stdout; the earlier stages feed it and are verdicted
1272 // separately as usual. Pass-through filters (`… | head -1`) emit a SUBSET of what they were
1273 // given, so walking back over them reaches the stage that actually produced the paths.
1274 let [stmt] = script.0.as_slice() else { return None };
1275 let cmds = &stmt.pipeline.commands;
1276 let mut idx = cmds.len().checked_sub(1)?;
1277 loop {
1278 match stage_output_locus(cmds.get(idx)?)? {
1279 StageOutput::Locus(l) => return Some(SubClaim::Locus(l)),
1280 // A pass-through filter emits a SUBSET of its input words, so it cannot turn an atom
1281 // into something with a separator — the claim survives the filter unchanged.
1282 StageOutput::Atom => return Some(SubClaim::Atom),
1283 StageOutput::PassThrough => idx = idx.checked_sub(1)?,
1284 }
1285 }
1286}
1287
1288enum StageOutput {
1289 Locus(LocalLocus),
1290 /// Every word of this stage's stdout is separator-free, so no word can BE a path.
1291 Atom,
1292 /// This stage only filters; ask the stage before it.
1293 PassThrough,
1294}
1295
1296/// What a `$(…)` is known to yield. Two different kinds of claim, which is why this is not an
1297/// `Option<LocalLocus>`: a locus says the value NAMES something at a rung, an atom says the value
1298/// names nothing at all and cannot traverse. The second is the weaker claim and the more useful
1299/// one — it is what lets a literal prefix survive around an interpolated leaf.
1300pub(crate) enum SubClaim {
1301 Locus(LocalLocus),
1302 Atom,
1303}
1304
1305fn stage_output_locus(cmd: &crate::cst::Cmd) -> Option<StageOutput> {
1306 let crate::cst::Cmd::Simple(simple) = cmd else { return None };
1307 let words: Vec<String> = simple.words.iter().map(crate::cst::Word::eval).collect();
1308 use crate::registry::types::OutputLocus;
1309 let (name, args) = words.split_first()?;
1310 // A resolvable name reached from a non-standard path (`./fd`) may not be the real tool, so it
1311 // gets no output-locus claim — the same spoof rule `resolve` applies to the command itself.
1312 if !trusted_command_path(name) {
1313 return None;
1314 }
1315 let token = Token::from_raw(name.clone());
1316 let canonical = crate::registry::canonical_name(token.command_name());
1317 // A SUB's claim wins over the command's, and narrows `args` to what follows the sub path so the
1318 // sub name is not counted as a path operand (`git ls-files src/` must see `src/`, not `ls-files`).
1319 let (rule, args) = match crate::registry::sub_output_locus(canonical, args) {
1320 Some((rule, rest)) => (rule, rest),
1321 None => (crate::registry::command_output_locus(canonical)?, args),
1322 };
1323 // At least one required flag must be present, or the command prints something other than paths
1324 // entirely — `git diff` without `--name-only` prints a patch. Checked before `invalidated_by`
1325 // because it is the stronger condition: absent, there is no claim to invalidate.
1326 if !rule.requires.is_empty() && !rule.requires.iter().any(|r| args.iter().any(|a| flag_present(a, std::slice::from_ref(r)))) {
1327 return None;
1328 }
1329 // `--help` and `--version` replace the command's DATA output with prose, and EVERY output
1330 // claim is a statement about the data. GNU `seq --help` prints
1331 // `<https://www.gnu.org/software/coreutils/>` — slash-bearing words under an `atom` claim that
1332 // says no word can contain a separator. Handled here rather than in each command's
1333 // `invalidated_by` so it holds for claims that do not exist yet: the danger is not seq (whose
1334 // help leaks only URLs, which as paths are relative) but the next atom source whose help
1335 // prints `/etc/foo.conf`, which would hand an ABSOLUTE path to a caller told it was confined.
1336 //
1337 // Long forms only. `-h` and `-V` are not reliably help/version — `sort -h` is human-numeric
1338 // sort — so treating them as informational would void real claims. A command whose OWN grammar
1339 // maps a short flag to help lists it in `invalidated_by` (see seq).
1340 //
1341 // Not caught by the local install: macOS ships BSD seq, whose help is terse and slash-free.
1342 if args.iter().any(|a| a == "--help" || a == "--version") {
1343 return None;
1344 }
1345 // A flag that changes what stdout CONTAINS (`fd -x cat {}` prints file bodies, `fd -l` prints
1346 // `ls -l` rows) voids the claim — the output is no longer a path at all.
1347 if args.iter().any(|a| flag_present(a, &rule.invalidated_by)) {
1348 return None;
1349 }
1350
1351 match rule.locus_from {
1352 // An ATOM names no locus — a separator-free word is not a path and cannot stand in for
1353 // one. It pays off in the PATH layer instead: a literal prefix around a FLANKED atom leaf
1354 // is confinable, because the atom cannot introduce a `/` and the flanking rules out the
1355 // leaf being `.` or `..`. Both halves of that are enforced in `locus::neutralize_atoms`;
1356 // on its own this claim widens nothing, since an atom sentinel is `is_unpinnable`.
1357 OutputLocus::Atom => Some(StageOutput::Atom),
1358 // The cwd is the workspace root by construction (the harness passes it), so `$(pwd)` is a
1359 // worktree path. `pathctx` is what decides whether the cwd itself escaped the root.
1360 OutputLocus::Cwd => Some(StageOutput::Locus(read_locus("."))),
1361 // Output descends the command's own path operands, so it is bounded by their worst read
1362 // locus. `fd x app/ lib/` → worktree; `fd x /` → machine.
1363 OutputLocus::Operands => {
1364 // ANY unpinnable argument voids the claim, checked before the path-shape filter and
1365 // over every argument rather than the ones that look like roots. A `$VAR` root carries
1366 // no `/`, so shape-filtering first read `fd pat $SECRET` as having no root at all and
1367 // reported worktree — while the command searches wherever `$SECRET` points.
1368 if args.iter().any(|a| is_unpinnable(a)) {
1369 return None;
1370 }
1371 let roots = candidate_roots(args, &rule.valued);
1372 // No path operand means the command searches `.` (`fd pattern`), which is the cwd.
1373 let worst = roots.iter().map(|r| read_locus(r)).max().unwrap_or_else(|| read_locus("."));
1374 // A bounded claim is only meaningful BELOW `user`. At worktree/adjacent/temp nothing
1375 // under the root can be a credential store, so the rung is the whole truth about the
1376 // value. At `user` or above it is not: the claim carries a LOCUS and says nothing about
1377 // WHICH file, and which file is exactly what the shield needs to see.
1378 //
1379 // `cat $(fd pat ~/.ssh)` was allowed while `cat ~/.ssh/id_rsa` denied — the tag reported
1380 // `machine`, the shield was never consulted because there was no path to consult it
1381 // about, and a substitution ended up more permissive than a path it could produce.
1382 // Caught by no_abstraction_is_more_permissive_than_a_path_it_could_denote.
1383 //
1384 // Same rule, and the same reasoning, as the synthetic pipe representative in
1385 // `cst::check::stage_output_repr`. Dropping the claim leaves the ordinary unpinnable
1386 // sentinel, which `reads_path` then treats as unshieldable.
1387 if worst >= LocalLocus::User {
1388 return None;
1389 }
1390 Some(StageOutput::Locus(worst))
1391 }
1392 // Only a filter when it is filtering: given a file operand it prints that file's CONTENTS,
1393 // which are caller-controlled text and no kind of path.
1394 OutputLocus::Stdin => {
1395 if candidate_roots(args, &rule.valued).is_empty() {
1396 Some(StageOutput::PassThrough)
1397 } else {
1398 None
1399 }
1400 }
1401 }
1402}
1403
1404/// Whether `arg` is one of `flags`, in any spelling that carries a value (`-x`, `--exec`,
1405/// `--exec=…`). A short flag may also be CLUSTERED (`-lx`), so single-char forms are matched
1406/// against the cluster's letters.
1407fn flag_present(arg: &str, flags: &[String]) -> bool {
1408 let head = arg.split('=').next().unwrap_or(arg);
1409 flags.iter().any(|f| {
1410 if head == f {
1411 return true;
1412 }
1413 match (f.strip_prefix('-'), arg.strip_prefix('-')) {
1414 (Some(letter), Some(cluster)) if f.len() == 2 && !arg.starts_with("--") => cluster.contains(letter),
1415 _ => false,
1416 }
1417 })
1418}
1419
1420/// Every argument that could name a search ROOT, over-approximated on purpose.
1421///
1422/// Under-counting here is a fail-OPEN — a missed root means a lower locus than the command actually
1423/// reaches — so EVERY non-flag argument counts, plus any path glued to a flag
1424/// (`--search-path=/etc`, `-E/etc/x`). Over-counting only ever raises the locus, which denies.
1425///
1426/// It deliberately does NOT ask whether an argument looks like a path. That test (`looks_like_path`)
1427/// keys on a `/` or a `.`, so a bare `~` failed it and `cat $(fd pat ~)` auto-approved a sweep of
1428/// the home directory as though it were worktree-local. A shape heuristic cannot be the last word
1429/// on a question whose wrong answer opens a hole.
1430fn candidate_roots<'a>(args: &'a [String], valued: &[String]) -> Vec<&'a str> {
1431 let mut roots = Vec::new();
1432 let mut skip_value = false;
1433 for a in args {
1434 if std::mem::take(&mut skip_value) {
1435 continue;
1436 }
1437 if a.starts_with('-') {
1438 // `valued` declares "this flag's value is NOT a path" (a count, a separator), so its
1439 // value is skipped in BOTH spellings. Handling only the separated form denied
1440 // `head --lines=5` while `head -n 5` passed — the same operation, two spellings.
1441 let (head, glued_value) = match a.split_once('=') {
1442 Some((h, v)) => (h, Some(v)),
1443 None => (a.as_str(), None),
1444 };
1445 if valued.iter().any(|v| v == head) {
1446 skip_value = glued_value.is_none();
1447 continue;
1448 }
1449 // Otherwise a glued value can still name a root. After `=` the whole value counts —
1450 // keying on `/` alone missed `--search-path=~`, the same blind spot as the shape test.
1451 // Without an `=`, a glued short value starts at the first path-ish character.
1452 let glued = glued_value.or_else(|| a.find(['/', '~']).map(|i| &a[i..]));
1453 if let Some(v) = glued.filter(|v| !v.is_empty()) {
1454 roots.push(v);
1455 }
1456 continue;
1457 }
1458 roots.push(a.as_str());
1459 }
1460 roots
1461}
1462
1463fn resolve_perl(tokens: &[Token]) -> Profile {
1464 // perl's `-e` one-liner is arbitrary code, so the identifier gate in `handlers::perl` decides
1465 // whether the CODE is inert. What that gate cannot do is judge the OPERANDS: it never looked at
1466 // them, which is why `perl -pe s/a/b/ /etc/shadow` used to read a credential file and print it
1467 // to the model. Both halves are needed — an inert one-liner over a system file is still an
1468 // exfiltration, and a worktree file rewritten by unmodeled code is still RCE.
1469 use crate::handlers::perl::PerlCode;
1470 let Some(scan) = crate::handlers::perl::scan_perl(tokens) else {
1471 return worst("perl: unmodeled flag cluster — worst-cased (§0)");
1472 };
1473 match scan.code {
1474 PerlCode::None => {
1475 let mut c = Capability::new(Operation::Observe);
1476 c.disclosure.audience = DisclosureAudience::LocalProcess;
1477 c.because = "perl: reports its own version/usage".to_string();
1478 return Profile::of(vec![c]);
1479 }
1480 // No `-e`/`-E` means the first operand is a SCRIPT FILE whose contents we cannot inspect
1481 // (like `sed -f`, `awk -f`, `bash x.sh`), and a failed identifier gate means the one-liner
1482 // reached outside the modeled vocabulary. Neither is separable from arbitrary execution.
1483 PerlCode::Opaque => return worst("perl: no inspectable -e/-E one-liner — worst-cased (§0)"),
1484 PerlCode::Inspectable => {}
1485 }
1486 // A sweeping in-place edit (`perl -pi -e … *`) is bounded but not single; locus still binds
1487 // each operand, so breadth widens the blast radius without ever admitting a system path.
1488 let files: Vec<&str> = scan.files.iter().map(String::as_str).collect();
1489 let scale = breadth_scale(&files, false);
1490 // No `execute` capability, deliberately. perl does run code, so recording one looks more
1491 // honest — but it is the wrong model here and the experiment says so: an
1492 // `executes(caller-inline)` capability denies at every band, which would take out every perl
1493 // one-liner including the in-place edits this hook exists to admit. The reason it denies is
1494 // that the `execute` rung describes running code of UNKNOWN content, and by this point the
1495 // identifier gate has already established the opposite — the one-liner reaches nothing but
1496 // pure built-ins, no I/O, no exec, no network. What remains observable is the operand reads
1497 // and writes below, and those ARE the profile. If the gate's vocabulary ever admits an
1498 // identifier with side effects, the fix belongs in the gate, not in a capability here.
1499 let caps: Vec<Capability> = if scan.in_place {
1500 let backups = backup::in_place_backups(tokens, &files, false);
1501 files
1502 .iter()
1503 .copied()
1504 .chain(backups.iter().map(String::as_str))
1505 .map(|f| mutates(classify_locus(f), scale, "perl -i edits the file in place"))
1506 .collect()
1507 } else {
1508 reads_to_model(&files, scale)
1509 };
1510 Profile::of(caps.into_iter().chain(path_verdicts::runs_modules_from(&scan.load_paths)).collect())
1511}
1512
1513/// The outcome of parsing one `sed` short-option cluster.
1514enum SedShort<'a> {
1515 Bad,
1516 Standalone,
1517 InPlace { consumes_next: bool }, // -i[SUFFIX], or BSD's separate `-i ''`
1518 Script { consumes_next: bool }, // -e SCRIPT
1519 ScriptFile { file: Option<&'a str>, consumes_next: bool }, // -f FILE
1520 SkipValue { consumes_next: bool }, // -l N
1521}
1522
1523fn sed_cluster<'a>(cluster: &'a str, next: Option<&'a str>, boolset: &[u8]) -> SedShort<'a> {
1524 let bytes = cluster.as_bytes();
1525 let mut k = 0;
1526 while k < bytes.len() {
1527 // A flag byte is ASCII; a non-ASCII lead/continuation byte is not a flag, and slicing
1528 // `cluster[k + 1..]` at it would land mid-char and panic. Bail as unrecognized.
1529 if !bytes[k].is_ascii() {
1530 return SedShort::Bad;
1531 }
1532 let glued = &cluster[k + 1..]; // safe: bytes[k] is ASCII → k+1 is a char boundary
1533 let has = !glued.is_empty();
1534 match bytes[k] {
1535 // `-i[SUFFIX]` glued is the GNU spelling. BSD (macOS) requires the suffix as a SEPARATE
1536 // word, empty for "no backup", so `sed -i '' 's/a/b/' f` is the standard macOS form.
1537 //
1538 // Modelled GNU-only, `-i` consumed nothing, so `''` landed in the first positional —
1539 // which for sed is the SCRIPT. Everything shifted one: the real script became a FILE
1540 // operand, and since operands are word-split, any absolute-looking token inside it
1541 // decided the locus. A JS comment did it in practice — the `//` in
1542 // `s|…|// TEMP: no-op|` read as the filesystem root and the edit denied at `machine`.
1543 //
1544 // ONLY an empty next word is consumed. Under BSD the word after `-i` is a suffix, not a
1545 // path, so accepting a non-empty one would let `-i /etc/passwd` swallow a real operand.
1546 b'i' => return SedShort::InPlace { consumes_next: !has && next == Some("") },
1547 b'e' => return SedShort::Script { consumes_next: !has },
1548 b'f' => {
1549 let file = if has { Some(glued) } else { next };
1550 return SedShort::ScriptFile { file, consumes_next: !has };
1551 }
1552 b'l' if has || next.is_some() => return SedShort::SkipValue { consumes_next: !has }, // -l N
1553 b if boolset.contains(&b) => k += 1,
1554 _ => return SedShort::Bad,
1555 }
1556 }
1557 SedShort::Standalone
1558}
1559
1560/// Parse a `sed` long option, returning how many tokens it consumed, or `None` if unknown.
1561fn sed_long<'a>(
1562 long: &'a str,
1563 next: Option<&'a str>,
1564 in_place: &mut bool,
1565 script_from_flag: &mut bool,
1566 script_files: &mut Vec<&'a str>,
1567) -> Option<usize> {
1568 let name = long.split('=').next().unwrap_or(long);
1569 match name {
1570 "in-place" => *in_place = true, // --in-place[=SUFFIX] (glued only)
1571 "expression" => {
1572 *script_from_flag = true;
1573 return Some(if long.contains('=') { 1 } else { 2 });
1574 }
1575 "file" => {
1576 *script_from_flag = true;
1577 match long.split_once('=') {
1578 Some((_, v)) => script_files.push(v),
1579 None => {
1580 script_files.extend(next);
1581 return Some(2);
1582 }
1583 }
1584 }
1585 "quiet" | "silent" | "regexp-extended" | "null-data" | "separate" | "unbuffered" | "posix" | "help" | "version" | "debug"
1586 | "follow-symlinks" | "sandbox" | "zero-terminated" | "line-length" => {}
1587 _ => return None,
1588 }
1589 Some(1)
1590}
1591
1592#[cfg(test)]
1593mod tests {
1594 use super::*;
1595
1596 fn toks(parts: &[&str]) -> Vec<Token> {
1597 parts.iter().map(|p| Token::from_test(p)).collect()
1598 }
1599
1600 fn level(name: &str) -> &'static crate::engine::level::Level {
1601 crate::engine::authoring::default_levels().iter().find(|l| l.name == name).expect("level exists")
1602 }
1603
1604 fn inert() -> &'static crate::engine::level::Level {
1605 level("paranoid")
1606 }
1607
1608 fn read_local() -> &'static crate::engine::level::Level {
1609 level("reader")
1610 }
1611
1612 /// `resolve_openssl` contract: a private-key/decrypt form reaching the MODEL classifies as
1613 /// decrypt-read (secret=reads → refused by developer, admitted only by yolo); a public/to-file/
1614 /// validate form ABSTAINS (None → openssl's legacy allow_all); a spoofed path worst-cases.
1615 #[test]
1616 fn openssl_resolver_gates_model_disclosure_only() {
1617 let (dev, yolo) = (level("developer"), level("yolo"));
1618 for parts in [
1619 &["openssl", "rsa", "-in", "priv.pem"][..],
1620 &["openssl", "rsa", "-in", "priv.pem", "-pubout", "-text"], // -text past -pubout
1621 &["openssl", "rsa", "-in", "priv.pem", "-out", "/dev/stdout"], // -out value is stdout
1622 &["openssl", "rsa", "-in", "priv.pem", "-noout", "-text"],
1623 &["openssl", "pkcs8", "-in", "priv.pem"],
1624 &["openssl", "enc", "--d", "-k", "p", "-in", "c"], // --opt alias
1625 &["openssl", "cms", "-EncryptedData_decrypt", "-in", "m"],
1626 &["openssl", "pkcs12", "-in", "f.p12", "-noenc"],
1627 ] {
1628 let p = resolve(&toks(parts)).unwrap_or_else(|| panic!("resolves: {parts:?}"));
1629 assert!(p.capabilities.iter().any(|c| c.secret.level == SecretLevel::Reads), "secret=reads: {parts:?}",);
1630 assert!(!dev.admits(&p), "developer refuses: {parts:?}");
1631 assert!(yolo.admits(&p), "yolo admits: {parts:?}");
1632 }
1633 for parts in [
1634 &["openssl", "rsa", "-in", "priv.pem", "-pubout"][..],
1635 &["openssl", "rsa", "-in", "priv.pem", "-noout"], // validate, no output
1636 &["openssl", "rsa", "-in", "enc.pem", "-out", "clean.pem"], // to a FILE, off the model
1637 &["openssl", "pkey", "-in", "pub.pem", "-pubin", "-text"], // public input → public text
1638 &["openssl", "pkcs12", "-in", "f.p12", "-nodes", "-out", "k.pem"],
1639 &["openssl", "enc", "-e", "-in", "x", "-out", "x.enc", "-k", "p"],
1640 &["openssl", "x509", "-in", "c", "-noout", "-text"],
1641 ] {
1642 assert!(resolve(&toks(parts)).is_none(), "resolver abstains (→ legacy): {parts:?}");
1643 }
1644 }
1645
1646 /// The output-destination check is FAIL-CLOSED: only a single plain-file `-out` diverts the key
1647 /// off the model. Path-normalization spellings, `/dev/stderr`, and duplicate `-out` (openssl honors
1648 /// the last) must all read as model-reaching — the sign-off review found the old device-spelling
1649 /// denylist let these through.
1650 #[test]
1651 fn openssl_output_destination_is_fail_closed() {
1652 let dev = level("developer");
1653 let reaches_model = |args: &[&str]| {
1654 let mut parts = vec!["openssl", "rsa", "-in", "priv.pem"];
1655 parts.extend_from_slice(args);
1656 // decrypt-read (secret=reads, refused by developer) ⇔ the output reached the model; a
1657 // diverted output makes the resolver ABSTAIN (None → openssl's benign legacy).
1658 match resolve(&toks(&parts)) {
1659 None => false,
1660 Some(p) => p.capabilities.iter().any(|c| c.secret.level == SecretLevel::Reads) && !dev.admits(&p),
1661 }
1662 };
1663 for evasion in [
1664 &["-out", "//dev/stdout"][..],
1665 &["-out", "/dev/./stdout"],
1666 &["-out", "//dev/fd/1"],
1667 &["-out", "/dev/fd//1"],
1668 &["-out=//dev/stdout"],
1669 &["-out", "/dev/stderr"],
1670 &["-out", "/foo/../dev/stdout"],
1671 &["-out", "dup.pem", "-out", "/dev/stdout"], // last-wins
1672 &["-out", "-"],
1673 // openssl's parser lets `-provider-path` swallow the `-out` token → openssl writes to
1674 // stdout; our scan then misreads the trailing flag as the filename. A dash-leading `-out`
1675 // value is the tell → fail closed.
1676 &["-provider-path", "-out", "-provider-path", "safe.pem"],
1677 &["-out", "-anything"],
1678 ] {
1679 assert!(reaches_model(evasion), "must read as model-reaching: {evasion:?}");
1680 }
1681 for diverted in [
1682 &["-out", "clean.pem"][..],
1683 &["-out", "./sub/key.pem"],
1684 &["-out", "devnotes.pem"], // "dev" prefix on a filename is not the /dev device
1685 &["-out", "/home/u/key.pem"],
1686 &["-noout"],
1687 ] {
1688 assert!(!reaches_model(diverted), "must divert off the model: {diverted:?}");
1689 }
1690 }
1691
1692 #[test]
1693 fn echo_resolves_to_a_benign_inert_profile() {
1694 let p = resolve(&toks(&["echo", "hi"])).expect("echo has a resolver");
1695 assert_eq!(p.capabilities.len(), 1);
1696 let c = &p.capabilities[0];
1697 assert_eq!(c.operation, Operation::Observe);
1698 assert_eq!(c.locus.local, LocalLocus::Process);
1699 assert_eq!(c.disclosure.audience, DisclosureAudience::LocalProcess);
1700 assert!(!c.because.is_empty(), "a structural certification cites its reason");
1701 // admitted at the *strictest* level — every facet (network/exec/secret/…) is zero
1702 assert!(inert().admits(&p), "echo is fully certified and inert-safe");
1703 }
1704
1705 #[test]
1706 fn echo_flags_do_not_change_its_profile() {
1707 let bare = resolve(&toks(&["echo", "hi"])).expect("echo");
1708 let flagged = resolve(&toks(&["echo", "-n", "-e", "hi"])).expect("echo -n -e");
1709 assert_eq!(bare, flagged);
1710 assert!(inert().admits(&flagged));
1711 }
1712
1713 #[test]
1714 fn an_unresearched_command_has_no_resolver() {
1715 assert!(resolve(&toks(UNRESOLVED_CMD)).is_none(), "unresearched → caller worst-cases");
1716 assert!(resolve(&[]).is_none(), "empty tokens");
1717 }
1718
1719 #[test]
1720 fn cat_of_a_worktree_file_is_read_local() {
1721 let p = resolve(&toks(&["cat", "./notes.md"])).expect("cat");
1722 assert!(read_local().admits(&p), "cat ./notes.md");
1723 assert!(!inert().admits(&p), "reading a real file is above inert");
1724 }
1725
1726 #[test]
1727 fn cat_of_a_path_the_shield_cannot_clear_is_denied() {
1728 // What bounds a read is the shield, not the rung: a credential store, another user's
1729 // home, a raw device, or a path we cannot resolve well enough to ASK about.
1730 for path in [
1731 "~/.ssh/id_rsa", "/etc/shadow", "$SECRET", "/var/lib/mysql/data", "/dev/mem", "/root/.bashrc",
1732 // `resolve` alone has no cwd binding, so a `..` cannot be pinned to the directory it
1733 // would land in and the unpinnable guard takes it. With a cwd (the CLI, the hook) the
1734 // same path resolves and reads — `path_policy_corpus.tsv` covers that end.
1735 "../outside",
1736 ] {
1737 let p = resolve(&toks(&["cat", path])).expect("cat");
1738 assert!(!read_local().admits(&p), "cat {path} must not be admitted as a local read");
1739 }
1740 // …while ordinary files on those same rungs now read, which is the whole point of the
1741 // shield being a NAME test rather than a rung test.
1742 for path in ["~/notes", "/etc/hosts", "/usr/bin/python3"] {
1743 let p = resolve(&toks(&["cat", path])).expect("cat");
1744 assert!(read_local().admits(&p), "cat {path} is an ordinary read");
1745 }
1746 }
1747
1748 #[test]
1749 fn machine_config_reads_but_its_credential_bearing_files_do_not() {
1750 for path in ["/etc/hosts", "/etc/os-release", "/usr/local/etc/nginx/nginx.conf"] {
1751 let p = resolve(&toks(&["cat", path])).expect("cat");
1752 assert!(read_local().admits(&p), "cat {path} is ordinary machine config");
1753 }
1754 // Same rung, different answer, and the rung is not what decided it: an auth log records
1755 // credentials outright, so it is a store however public the directory around it looks.
1756 for path in ["/var/log/auth.log", "/etc/shadow"] {
1757 let p = resolve(&toks(&["cat", path])).expect("cat");
1758 assert!(!read_local().admits(&p), "cat {path} reads credentials");
1759 }
1760 }
1761
1762 /// Distributed package CONTENT is read-admitted; its WRITE face is not.
1763 ///
1764 /// A man page, a vendored crate README, a toolchain source file: read yes, WRITE no.
1765 ///
1766 /// These used to be readable via a `package-content` region role that admitted the roots
1767 /// explicitly. That role is gone — it existed to get reads working while the bound was low,
1768 /// and it cut `/usr` into halves (`share` readable, `etc` not) that nothing justified as a
1769 /// boundary. Reads reach these paths on the general policy now.
1770 ///
1771 /// The assertion that still earns its keep is the WRITE half. Opening reads must not have
1772 /// widened what the agent can alter, and these are the paths where a write would be an
1773 /// install rather than an edit.
1774 #[test]
1775 fn package_content_is_readable_but_never_writable() {
1776 for path in [
1777 "/usr/share/doc/x",
1778 "/usr/share/man/man1/git.1",
1779 "/usr/local/share/doc/x/README",
1780 "/opt/homebrew/lib/node_modules/npm/package.json",
1781 "/Library/Developer/CommandLineTools/usr/include/stdio.h",
1782 "/nix/store/abc/share/doc/README",
1783 "~/.cargo/registry/src/idx/serde-1.0/README.md",
1784 "~/.rustup/toolchains/stable/lib/rustlib/src/core/src/lib.rs",
1785 "~/go/pkg/mod/github.com/x/y@v1/README.md",
1786 "~/.local/share/mise/installs/node/22/README.md",
1787 ] {
1788 let read = resolve(&toks(&["cat", path])).expect("cat");
1789 assert!(read_local().admits(&read), "reading package content {path} should be admitted");
1790 let write = resolve(&toks(&["rm", "-rf", path])).expect("rm");
1791 assert!(!read_local().admits(&write), "package content {path} must NOT be writable — this widens disclosure only");
1792 }
1793 }
1794
1795 /// The credential shield outranks an admit prefix, whatever the specificity ordering says.
1796 ///
1797 /// Specificity ranks exact ≫ prefix ≫ segment, so every subtree admit outranked the shield's
1798 /// segment match: `/usr/share/.ssh/id_rsa` was APPROVED the moment package content became
1799 /// readable. A shield that a new admit node can widen is not a shield.
1800 #[test]
1801 fn an_admit_prefix_can_never_widen_the_credential_shield() {
1802 for path in [
1803 "/usr/share/.ssh/id_rsa", "/usr/local/lib/.aws/credentials", "/opt/homebrew/share/.gnupg/secring.gpg",
1804 "~/.cargo/registry/.ssh/id_ed25519", "/nix/store/x/.aws/credentials",
1805 ] {
1806 let p = resolve(&toks(&["cat", path])).expect("cat");
1807 assert!(!read_local().admits(&p), "an admit prefix widened the shield at {path}");
1808 }
1809 }
1810
1811 #[test]
1812 fn cat_stdin_is_process_scoped() {
1813 assert!(inert().admits(&resolve(&toks(&["cat"])).expect("cat")), "no operand → stdin");
1814 assert!(inert().admits(&resolve(&toks(&["cat", "-"])).expect("cat -")), "- → stdin");
1815 }
1816
1817 #[test]
1818 fn cat_reads_every_file_operand_and_one_home_read_sinks_it() {
1819 let p = resolve(&toks(&["cat", "-n", "a.txt", "src/b.rs"])).expect("cat");
1820 assert_eq!(p.capabilities.len(), 2, "-n is a flag; two files");
1821 assert!(read_local().admits(&p), "both worktree");
1822
1823 let mixed = resolve(&toks(&["cat", "a.txt", "~/.ssh/id_rsa"])).expect("cat");
1824 assert!(!read_local().admits(&mixed), "one home read sinks the whole profile");
1825 }
1826
1827 #[test]
1828 fn cat_double_dash_treats_the_rest_as_files() {
1829 let p = resolve(&toks(&["cat", "--", "-n"])).expect("cat");
1830 assert_eq!(p.capabilities.len(), 1, "-n after -- is a filename");
1831 assert!(read_local().admits(&p));
1832 }
1833
1834 #[test]
1835 fn head_tail_wc_read_like_cat_and_honor_numeric_shorthand() {
1836 use crate::engine::bridge::project;
1837 use crate::verdict::{SafetyLevel, Verdict};
1838 // worktree reads → read-local (SafeRead); home reads → denied by locus, same as cat.
1839 for cmd in [
1840 vec!["head", "README.md"],
1841 vec!["head", "-n", "5", "src/main.rs"],
1842 vec!["head", "-20", "src/main.rs"], // obsolete -NUM form must parse
1843 vec!["tail", "-f", "./log.txt"], // follow is still a bounded read
1844 vec!["tail", "-n", "100", "./log.txt"],
1845 vec!["wc", "-l", "./notes.md"],
1846 ] {
1847 assert_eq!(project(&resolve(&toks(&cmd)).expect("read")), Verdict::Allowed(SafetyLevel::SafeRead), "{cmd:?}");
1848 }
1849 // reading stdin (`-`) is process-scoped → inert, like `cat -`.
1850 assert_eq!(project(&resolve(&toks(&["wc", "-c", "-"])).expect("wc")), Verdict::Allowed(SafetyLevel::Inert), "wc stdin");
1851 for cmd in [vec!["head", "~/.ssh/id_rsa"], vec!["tail", "/etc/shadow"], vec!["wc", "-l", "$SECRET"]] {
1852 assert_eq!(project(&resolve(&toks(&cmd)).expect("read")), Verdict::Denied, "{cmd:?} beyond worktree");
1853 }
1854 // -NUM consumes no operand: `head -20 file` reads exactly `file`, not a phantom "20".
1855 let p = resolve(&toks(&["head", "-20", "src/main.rs"])).expect("head");
1856 assert_eq!(p.capabilities.len(), 1, "-20 is the count, not a file");
1857 // wc --files0-from reads an unpinnable set → worst-case → denied.
1858 assert_eq!(project(&resolve(&toks(&["wc", "--files0-from=list"])).expect("wc")), Verdict::Denied, "--files0-from");
1859 assert_eq!(project(&resolve(&toks(&["wc", "--files0-from", "-"])).expect("wc")), Verdict::Denied, "--files0-from -");
1860 // unknown flags fail closed.
1861 assert_eq!(project(&resolve(&toks(&["head", "-Z", "x"])).expect("head")), Verdict::Denied, "unknown flag");
1862 }
1863
1864 #[test]
1865 fn grep_reads_its_files_not_the_pattern() {
1866 let p = resolve(&toks(&["grep", "foo", "file.txt"])).expect("grep");
1867 assert_eq!(p.capabilities.len(), 1, "the pattern is not a file");
1868 assert!(read_local().admits(&p));
1869 }
1870
1871 #[test]
1872 fn grep_beyond_the_worktree_is_denied() {
1873 for args in [vec!["grep", "foo", "~/.ssh/config"], vec!["grep", "-r", "foo", "~"], vec!["grep", "foo", "$DIR"]] {
1874 let p = resolve(&toks(&args)).expect("grep");
1875 assert!(!read_local().admits(&p), "{args:?}");
1876 }
1877 }
1878
1879 #[test]
1880 fn grep_recursive_is_unbounded_and_defaults_to_cwd() {
1881 let p = resolve(&toks(&["grep", "-r", "foo", "src/"])).expect("grep");
1882 assert!(p.capabilities.iter().all(|c| c.scale == Scale::Unbounded), "-r → unbounded");
1883 assert!(read_local().admits(&p), "recursive worktree search");
1884
1885 let cwd = resolve(&toks(&["grep", "-r", "foo"])).expect("grep");
1886 assert!(cwd.capabilities.iter().all(|c| c.locus.local == LocalLocus::Worktree), "cwd, not stdin");
1887 assert!(read_local().admits(&cwd));
1888 }
1889
1890 #[test]
1891 fn grep_e_and_f_supply_the_pattern_so_positionals_are_files() {
1892 // -e: pattern is the flag's value; file.txt is the only file
1893 let e = resolve(&toks(&["grep", "-e", "foo", "file.txt"])).expect("grep -e");
1894 assert_eq!(e.capabilities.len(), 1);
1895 assert!(read_local().admits(&e));
1896
1897 // -f: the pattern FILE is itself a read
1898 let f = resolve(&toks(&["grep", "-f", "patterns.txt", "file.txt"])).expect("grep -f");
1899 assert_eq!(f.capabilities.len(), 2, "patterns.txt + file.txt");
1900 assert!(read_local().admits(&f));
1901
1902 // The `-f` value is gated as a read like any other operand: an ordinary home file is
1903 // readable now, a credential store is not — and the flag is what makes it a read at all.
1904 let home = resolve(&toks(&["grep", "-f", "~/.secret-patterns", "file.txt"])).expect("grep -f");
1905 assert!(read_local().admits(&home), "an ordinary home pattern file reads");
1906 let shielded = resolve(&toks(&["grep", "-f", "~/.ssh/id_rsa", "file.txt"])).expect("grep -f");
1907 assert!(!read_local().admits(&shielded), "a shielded pattern file is still a credential read");
1908
1909 // glued short value: -fpatterns.txt and -ifpatterns.txt both name a pattern file
1910 let glued = resolve(&toks(&["grep", "-fpatterns.txt", "file.txt"])).expect("grep -f glued");
1911 assert_eq!(glued.capabilities.len(), 2, "glued -f value is still a read");
1912 // The glued spelling classifies as the spaced one does — ordinary home file reads, a
1913 // shielded one does not. What must never differ between the two forms is the ANSWER.
1914 let glued_home = resolve(&toks(&["grep", "-if~/.secrets", "x"])).expect("grep -if glued");
1915 assert!(read_local().admits(&glued_home), "glued ordinary home pattern file reads");
1916 let glued_shield = resolve(&toks(&["grep", "-if~/.ssh/id_rsa", "x"])).expect("grep -if glued");
1917 assert!(!read_local().admits(&glued_shield), "glued shielded pattern file is a credential read");
1918 }
1919
1920 #[test]
1921 fn grep_long_flags() {
1922 // --file / --file= name a pattern file grep also reads (2 caps)
1923 assert_eq!(resolve(&toks(&["grep", "--file", "p.txt", "f.txt"])).expect("grep").capabilities.len(), 2);
1924 assert_eq!(resolve(&toks(&["grep", "--file=p.txt", "f.txt"])).expect("grep").capabilities.len(), 2);
1925
1926 // --regexp supplies the pattern; the positional is the file
1927 let r = resolve(&toks(&["grep", "--regexp", "foo", "f.txt"])).expect("grep");
1928 assert_eq!(r.capabilities.len(), 1);
1929 assert!(read_local().admits(&r));
1930
1931 // a space-separated long value (`--max-count 5`) is imprecise — `5` is read as a
1932 // phantom positional — but FAIL-SAFE: still worktree-bounded, admitted at
1933 // read-local, never looser. (Precise handling needs the TOML flag schema.)
1934 let m = resolve(&toks(&["grep", "--max-count", "5", "foo", "f.txt"])).expect("grep");
1935 assert!(read_local().admits(&m), "--max-count 5 is fail-safe (imprecise)");
1936
1937 // --perl-regexp (PCRE2) runs no code — benign like any regex-engine flag; reads read-local.
1938 let pcre = resolve(&toks(&["grep", "--perl-regexp", "foo", "f"])).expect("grep");
1939 assert!(read_local().admits(&pcre), "grep --perl-regexp reads a file, it does not exec");
1940 }
1941
1942 #[test]
1943 fn grep_dash_patterns_are_search_patterns_not_flags() {
1944 // A `--`-prefixed token that is not a recognized grep flag is a SEARCH PATTERN, not
1945 // an unknown flag — grep patterns commonly look like `-->`, `---`, `--foo`. The
1946 // engine must read the file operand at read-local, matching the legacy handler, not
1947 // worst-case it.
1948 for args in [
1949 vec!["grep", "-->", "file.txt"],
1950 vec!["grep", "---", "file.txt"],
1951 vec!["grep", "--some-pattern", "file.txt"],
1952 vec!["grep", "-rn", "-->", "src/"],
1953 vec!["grep", "-i", "-r", "-n", "-->", "src/"],
1954 ] {
1955 let p = resolve(&toks(&args)).expect("grep");
1956 assert!(read_local().admits(&p), "dash-pattern should read-local: {args:?}");
1957 assert!(!inert().admits(&p), "it still reads a file: {args:?}");
1958 }
1959 // but the genuinely-dangerous long (--dereference-recursive, symlink escape) worst-cases
1960 let args = vec!["grep", "--dereference-recursive", "foo", "dir"];
1961 let p = resolve(&toks(&args)).expect("grep");
1962 assert!(!read_local().admits(&p), "dangerous long must worst-case: {args:?}");
1963 // PCRE flags now read-local (PCRE2 execs no code): -P short, --perl-regexp long, -oP combined.
1964 for args in [vec!["grep", "-P", "foo", "f"], vec!["grep", "--perl-regexp", "foo", "f"], vec!["grep", "-oP", "foo", "f"]] {
1965 let p = resolve(&toks(&args)).expect("grep");
1966 assert!(read_local().admits(&p), "grep PCRE flag should read-local: {args:?}");
1967 }
1968 }
1969
1970 #[test]
1971 fn grep_stdin_and_standalone_flags() {
1972 assert!(inert().admits(&resolve(&toks(&["grep", "foo"])).expect("grep")), "no file → stdin");
1973 let p = resolve(&toks(&["grep", "-i", "-n", "foo", "file.txt"])).expect("grep");
1974 assert_eq!(p.capabilities.len(), 1, "-i -n standalone; foo pattern; file.txt file");
1975 assert!(read_local().admits(&p));
1976 }
1977
1978 /// The complete resolved capability for a single-capability invocation, with
1979 /// `because` cleared so the assertion is over the **facets** (not the prose).
1980 fn one_cap(cmd: &[&str]) -> Capability {
1981 let p = resolve(&toks(cmd)).expect("resolves");
1982 assert_eq!(p.capabilities.len(), 1, "{cmd:?} is a single-capability invocation");
1983 let mut c = p.capabilities[0].clone();
1984 c.because = String::new();
1985 c
1986 }
1987
1988 /// A read the credential shield cannot clear must SAY so, on the secret axis.
1989 ///
1990 /// Enumerated over the shield's own region nodes plus the unpinnable spellings, because the
1991 /// claim has to survive a new store being declared and a new reader being written. Two halves,
1992 /// and the second is the one that is easy to lose:
1993 ///
1994 /// - a path that NAMES a store (`~/.ssh/id_rsa`) — the shield can check it and it fails;
1995 /// - a path the shield cannot check AT ALL (`$VAR`, an undeclared `$(…)`, an xargs item) —
1996 /// unknowable, so possibly a credential, so refused.
1997 ///
1998 /// Today both also deny by locus, which is exactly why this guard is worth having: the locus
1999 /// cap makes the secret claim invisible in the verdict, so nothing else would notice it going
2000 /// missing — and it is the only thing that keeps `find / | xargs -I{} cat {}` refused once
2001 /// local reads open up (TODO.md).
2002 #[test]
2003 fn a_read_the_shield_cannot_clear_claims_secret() {
2004 let secret_of = |cmd: &str| {
2005 let toks: Vec<Token> = shell_words::split(cmd).expect("splits").into_iter().map(Token::from_raw).collect();
2006 resolve(&toks).map(|p| p.capabilities.iter().any(|c| c.secret.level == crate::engine::facet::SecretLevel::Reads))
2007 };
2008
2009 // Every declared credential store, read by the plainest reader there is.
2010 let mut checked = 0usize;
2011 for path in crate::engine::resolve::regions::declared_region_paths() {
2012 if !crate::engine::resolve::names_credential_store(&path) {
2013 continue;
2014 }
2015 // A node is a SUBTREE (`~/.ssh/`), a SEGMENT (`.ssh`) or an EXACT file
2016 // (`/etc/master.passwd`). Only the first two have anything beneath them; appending to
2017 // the exact form names a path that is not the node and is not shielded.
2018 // QUOTED, because several stores have a space in them (`~/Library/Application
2019 // Support/Firefox/`) and an unquoted probe splits into two tokens, neither of which is
2020 // the node — the guard would pass by never testing them.
2021 let probe = if path.ends_with('/') || !path.contains('/') {
2022 format!("cat '{}/probe'", path.trim_end_matches('/'))
2023 } else {
2024 format!("cat '{path}'")
2025 };
2026 if let Some(claims) = secret_of(&probe) {
2027 checked += 1;
2028 assert!(claims, "`{probe}` reads a declared credential store without claiming secret");
2029 }
2030 }
2031 assert!(checked > 0, "no credential store was probed — the guard is vacuous");
2032
2033 // Paths the shield cannot be consulted about at all.
2034 for cmd in ["cat $SOMEVAR", "cat $(hostname)", "head -c 20 ${HOME}x/$Y"] {
2035 assert_eq!(secret_of(cmd), Some(true), "`{cmd}` names a path the shield cannot check, so it must claim secret");
2036 }
2037
2038 // ...and an ordinary, checkable read does NOT — the claim has to discriminate, or it is
2039 // just a second way of spelling "deny everything".
2040 for cmd in ["cat ./README.md", "cat src/lib.rs"] {
2041 assert_eq!(secret_of(cmd), Some(false), "`{cmd}` must not claim a secret read");
2042 }
2043 }
2044
2045 /// Golden profiles: assert **every** facet of the resolved capability for
2046 /// representative invocations. This is the "all facets covered" check (§0) — struct
2047 /// equality means a facet the resolver forgot (left at a wrong default) or set wrong
2048 /// fails the test, per command. When commands carry TOML profiles, the expected
2049 /// profile is derived from the TOML instead of hand-built here.
2050 #[test]
2051 fn golden_profiles_cover_every_facet() {
2052 // echo — the reference `structural` profile: observe, process-scoped, output to
2053 // the model, and every other axis provably zero.
2054 let mut echo = Capability::new(Operation::Observe);
2055 echo.disclosure.audience = DisclosureAudience::LocalProcess;
2056 assert_eq!(one_cap(&["echo", "hi"]), echo, "echo");
2057
2058 // cat of a worktree file — observe · worktree · content-to-model.
2059 let mut cat = Capability::new(Operation::Observe);
2060 cat.locus.local = LocalLocus::Worktree;
2061 cat.disclosure.audience = DisclosureAudience::LocalProcess;
2062 assert_eq!(one_cap(&["cat", "./notes.md"]), cat, "cat ./notes.md");
2063
2064 // cat of a plain home file resolves to `user` — the rung the ladder defines for `~` and
2065 // that, until 2026-08-15, no production path ever reached (everything under home fell
2066 // through to `unknown`/`machine`, the same rung as /etc/hosts). Still denies: `user` sits
2067 // above the reader level's cap. The rung is now HONEST, which is the prerequisite for a
2068 // level admitting a home read without also admitting the whole machine.
2069 let mut cat_home = cat.clone();
2070 cat_home.locus.local = LocalLocus::User;
2071 assert_eq!(one_cap(&["cat", "~/notes.txt"]), cat_home, "cat ~/notes.txt");
2072
2073 // An ordinary home DOTFILE is ordinary: `.zshrc` is `user`, like any other file in home.
2074 assert_eq!(one_cap(&["cat", "~/.zshrc"]), cat_home, "cat ~/.zshrc");
2075
2076 // A CREDENTIAL dotfile is not, and it is the shield that says so rather than the rung.
2077 // Excluding dotfiles from the `user` rung protected nothing — an excluded path fell through
2078 // to machine, which the read policy admits — so the shield names them instead.
2079 let mut cat_dot = cat.clone();
2080 cat_dot.locus.local = LocalLocus::Machine;
2081 cat_dot.secret.level = SecretLevel::Reads;
2082 assert_eq!(one_cap(&["cat", "~/.git-credentials"]), cat_dot, "cat ~/.git-credentials");
2083
2084 // cat of a home CREDENTIAL store: machine locus AND — the part that was missing until
2085 // 2026-08-14 — a `secret · reads` claim. The region carried `reads_secret = true` all along,
2086 // but nothing put it on the capability, so this golden recorded "reading an SSH private key
2087 // claims no secret" and the denial rested entirely on the locus cap. Both facets now, which
2088 // is what lets the locus cap be relaxed without handing over the key.
2089 let mut cat_cred = cat.clone();
2090 cat_cred.locus.local = LocalLocus::Machine;
2091 cat_cred.secret.level = SecretLevel::Reads;
2092 assert_eq!(one_cap(&["cat", "~/.ssh/id_rsa"]), cat_cred, "cat ~/.ssh/id_rsa");
2093
2094 // grep of a worktree file — like cat, bounded to the single searched file.
2095 assert_eq!(one_cap(&["grep", "foo", "file.txt"]), cat, "grep foo file.txt");
2096
2097 // grep -r — the recursive search raises scale to unbounded and nothing else.
2098 let mut grep_r = cat.clone();
2099 grep_r.scale = Scale::Unbounded;
2100 assert_eq!(one_cap(&["grep", "-r", "foo", "src/"]), grep_r, "grep -r foo src/");
2101
2102 // rm — destroy · worktree · effortful; no net/exec/secret.
2103 let mut rm = Capability::new(Operation::Destroy);
2104 rm.locus.local = LocalLocus::Worktree;
2105 rm.reversibility = Reversibility::Effortful;
2106 assert_eq!(one_cap(&["rm", "./x"]), rm, "rm ./x");
2107
2108 // mkdir — create · worktree · trivial · leaves data. A fresh dir is rmdir-removable.
2109 let mut mkdir = Capability::new(Operation::Create);
2110 mkdir.locus.local = LocalLocus::Worktree;
2111 mkdir.reversibility = Reversibility::Trivial;
2112 mkdir.persistence.level = PersistenceLevel::Data;
2113 assert_eq!(one_cap(&["mkdir", "./build"]), mkdir, "mkdir ./build");
2114
2115 // touch — the same create · worktree · trivial · data shape as mkdir.
2116 assert_eq!(one_cap(&["touch", "./new.txt"]), mkdir, "touch ./new.txt");
2117
2118 // cp -n ./a ./b — a guaranteed-non-clobbering copy is TWO capabilities:
2119 // a source read (observe, worktree, NO model disclosure) and a trivial dest create.
2120 let cp = resolve(&toks(&["cp", "-n", "./a", "./b"])).expect("cp");
2121 assert_eq!(cp.capabilities.len(), 2, "cp = source read + dest write");
2122 let mut src = Capability::new(Operation::Observe);
2123 src.locus.local = LocalLocus::Worktree; // disclosure.audience stays `none`: file→file
2124 assert_eq!(clear_because(&cp.capabilities[0]), src, "cp source read");
2125 let mut dst = Capability::new(Operation::Create);
2126 dst.locus.local = LocalLocus::Worktree;
2127 dst.reversibility = Reversibility::Trivial; // -n → cannot overwrite
2128 dst.persistence.level = PersistenceLevel::Data;
2129 assert_eq!(clear_because(&cp.capabilities[1]), dst, "cp -n dest write");
2130
2131 // mv ./a ./b — a relocation: source MUTATE (trivial, transient — the entry leaves)
2132 // + dest CREATE (recoverable overwrite). Contrast cp's source, which is an observe.
2133 let mv = resolve(&toks(&["mv", "./a", "./b"])).expect("mv");
2134 let mut mv_src = Capability::new(Operation::Mutate);
2135 mv_src.locus.local = LocalLocus::Worktree;
2136 mv_src.reversibility = Reversibility::Trivial;
2137 assert_eq!(clear_because(&mv.capabilities[0]), mv_src, "mv source relocation");
2138 let mut mv_dst = Capability::new(Operation::Create);
2139 mv_dst.locus.local = LocalLocus::Worktree;
2140 mv_dst.reversibility = Reversibility::Recoverable;
2141 mv_dst.persistence.level = PersistenceLevel::Data;
2142 assert_eq!(clear_because(&mv.capabilities[1]), mv_dst, "mv dest write");
2143
2144 // ln ./a ./b — target bridged (observe, no model disclosure) + link create (trivial,
2145 // no -f). Same facet shapes as cp -n, the point being ln reuses `observes`.
2146 let ln = resolve(&toks(&["ln", "./a", "./b"])).expect("ln");
2147 let mut ln_tgt = Capability::new(Operation::Observe);
2148 ln_tgt.locus.local = LocalLocus::Worktree;
2149 assert_eq!(clear_because(&ln.capabilities[0]), ln_tgt, "ln target bridge");
2150 let mut ln_link = Capability::new(Operation::Create);
2151 ln_link.locus.local = LocalLocus::Worktree;
2152 ln_link.reversibility = Reversibility::Trivial;
2153 ln_link.persistence.level = PersistenceLevel::Data;
2154 assert_eq!(clear_because(&ln.capabilities[1]), ln_link, "ln link create");
2155 }
2156
2157 fn clear_because(c: &Capability) -> Capability {
2158 let mut c = c.clone();
2159 c.because = String::new();
2160 c
2161 }
2162
2163 #[test]
2164 fn mkdir_creates_in_the_worktree_but_not_beyond_it() {
2165 use crate::engine::bridge::project;
2166 use crate::verdict::{SafetyLevel, Verdict};
2167 // a fresh dir is a trivial-reversibility create → write-local (SafeWrite)
2168 for cmd in [vec!["mkdir", "./build"], vec!["mkdir", "-p", "a/b/c"], vec!["mkdir", "-m", "755", "./x"]] {
2169 assert_eq!(project(&resolve(&toks(&cmd)).expect("mkdir")), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
2170 }
2171 // outside the worktree → denied by locus
2172 for cmd in [vec!["mkdir", "/etc/evil"], vec!["mkdir", "~/newdir"], vec!["mkdir", "$HOME/x"]] {
2173 assert_eq!(project(&resolve(&toks(&cmd)).expect("mkdir")), Verdict::Denied, "{cmd:?}");
2174 }
2175 // a glued valued short (-m755) and its value must not be read as operands
2176 let g = resolve(&toks(&["mkdir", "-m755", "./x"])).expect("mkdir");
2177 assert_eq!(g.capabilities.len(), 1, "-m755 glued: only ./x is an operand");
2178 assert_eq!(g.capabilities[0].locus.local, LocalLocus::Worktree);
2179 // fail-closed on an unknown flag / no operand
2180 assert_eq!(project(&resolve(&toks(&["mkdir", "-Q", "x"])).expect("mkdir")), Verdict::Denied, "unknown flag");
2181 assert_eq!(project(&resolve(&toks(&["mkdir"])).expect("mkdir")), Verdict::Denied, "no operand");
2182 }
2183
2184 #[test]
2185 fn cp_splits_source_and_dest_loci_and_overwrite_gates_the_level() {
2186 use crate::engine::bridge::project;
2187 use crate::verdict::{SafetyLevel, Verdict};
2188
2189 // a copy is a create/overwrite, not a destroy → write-local (SafeWrite), matching
2190 // echo > config.json. Overwriting is recoverable; -n can't clobber (trivial). Both
2191 // write-local — the destroy-vs-create boundary keeps cp below rm.
2192 let plain = resolve(&toks(&["cp", "./a", "./b"])).expect("cp");
2193 assert_eq!(plain.capabilities.last().unwrap().reversibility, Reversibility::Recoverable, "dest overwrite");
2194 assert_eq!(project(&plain), Verdict::Allowed(SafetyLevel::SafeWrite), "cp ./a ./b");
2195 let nc = resolve(&toks(&["cp", "-n", "./a", "./b"])).expect("cp");
2196 assert_eq!(nc.capabilities.last().unwrap().reversibility, Reversibility::Trivial, "-n cannot clobber");
2197 assert_eq!(project(&nc), Verdict::Allowed(SafetyLevel::SafeWrite), "cp -n ./a ./b");
2198
2199 // reading a home/system SOURCE is denied by the source locus — no secret detector,
2200 // just the read locus (cp can't smuggle ~/.ssh/id_rsa into the worktree).
2201 assert_eq!(project(&resolve(&toks(&["cp", "~/.ssh/id_rsa", "./x"])).expect("cp")), Verdict::Denied, "home source");
2202 assert_eq!(project(&resolve(&toks(&["cp", "/etc/shadow", "./x"])).expect("cp")), Verdict::Denied, "system source");
2203 // writing a home/system DEST is denied by the dest locus.
2204 assert_eq!(project(&resolve(&toks(&["cp", "./x", "~/backdoor"])).expect("cp")), Verdict::Denied, "home dest");
2205 assert_eq!(project(&resolve(&toks(&["cp", "./x", "/etc/cron.d/x"])).expect("cp")), Verdict::Denied, "system dest");
2206
2207 // -t DIR makes every positional a source; the dir is the dest. All three spellings
2208 // (separate, --long=, and glued short) must parse the same way.
2209 for form in [
2210 vec!["cp", "-t", "./dest", "./a", "./b"],
2211 vec!["cp", "--target-directory=./dest", "./a", "./b"],
2212 vec!["cp", "-t./dest", "./a", "./b"], // glued short — previously worst-cased
2213 ] {
2214 let t = resolve(&toks(&form)).expect("cp -t");
2215 assert_eq!(t.capabilities.len(), 3, "{form:?}: 2 sources + 1 dest");
2216 assert_eq!(project(&t), Verdict::Allowed(SafetyLevel::SafeWrite), "{form:?}");
2217 }
2218 // a glued -t pointing outside the worktree is still denied by the dest locus.
2219 assert_eq!(project(&resolve(&toks(&["cp", "-t/etc", "./a"])).expect("cp")), Verdict::Denied, "cp -t/etc");
2220
2221 // optional-argument longs (--backup[=X], --preserve[=X]) must NOT swallow the
2222 // source operand: bare and glued forms both leave ./a a source and ./b the dest.
2223 for form in
2224 [vec!["cp", "--backup", "./a", "./b"], vec!["cp", "--preserve", "./a", "./b"], vec!["cp", "--preserve=mode", "./a", "./b"]]
2225 {
2226 let c = resolve(&toks(&form)).expect("cp");
2227 assert_eq!(c.capabilities.len(), 2, "{form:?}: source read + dest write");
2228 assert_eq!(project(&c), Verdict::Allowed(SafetyLevel::SafeWrite), "{form:?}");
2229 }
2230
2231 // recursion raises scale to unbounded; a lone operand / unknown flag worst-cases.
2232 assert_eq!(resolve(&toks(&["cp", "-r", "./a", "./b"])).expect("cp").capabilities[0].scale, Scale::Unbounded);
2233 assert_eq!(project(&resolve(&toks(&["cp", "./only"])).expect("cp")), Verdict::Denied, "no dest");
2234 assert_eq!(project(&resolve(&toks(&["cp", "-Q", "./a", "./b"])).expect("cp")), Verdict::Denied, "unknown flag");
2235 // -t naming a dest with NO source operands is a usage error → fail closed (not a lone,
2236 // benign dest write).
2237 assert_eq!(project(&resolve(&toks(&["cp", "-t", "./dest"])).expect("cp")), Verdict::Denied, "-t no source");
2238 }
2239
2240 #[test]
2241 fn mv_relocates_within_the_worktree_and_gates_both_loci() {
2242 use crate::engine::bridge::project;
2243 use crate::verdict::{SafetyLevel, Verdict};
2244
2245 // a move within the worktree is a mutate (source) + create (dest), both trivial/
2246 // recoverable → write-local, NOT developer. Unlike rm, a move relocates, not destroys.
2247 let m = resolve(&toks(&["mv", "./a", "./b"])).expect("mv");
2248 assert_eq!(m.capabilities[0].operation, Operation::Mutate, "source is a relocation, not a destroy");
2249 assert_eq!(m.capabilities[0].reversibility, Reversibility::Trivial, "mv back");
2250 assert_eq!(project(&m), Verdict::Allowed(SafetyLevel::SafeWrite), "mv ./a ./b");
2251
2252 // both loci are gated as writes: source-out and dest-out both deny.
2253 assert_eq!(project(&resolve(&toks(&["mv", "~/.ssh/id_rsa", "./x"])).expect("mv")), Verdict::Denied, "source in home");
2254 assert_eq!(project(&resolve(&toks(&["mv", "./x", "~/exfil"])).expect("mv")), Verdict::Denied, "dest in home");
2255 // moving a worktree-TRUSTED file mutates .git → denied, even though cp of it is
2256 // allowed (cp only READS .git/config; the dest write puts cp at SafeWrite).
2257 assert_eq!(project(&resolve(&toks(&["mv", ".git/config", "./x"])).expect("mv")), Verdict::Denied, "mv .git/config");
2258 assert_eq!(
2259 project(&resolve(&toks(&["cp", ".git/config", "./x"])).expect("cp")),
2260 Verdict::Allowed(SafetyLevel::SafeWrite),
2261 "cp .git/config reads"
2262 );
2263
2264 // The relocate source gates at its REBIND face, not its read face. safe-chains' own config
2265 // READS at worktree-trusted but rebinds at system-integrity (un-grantable, and above what
2266 // any level below yolo admits): `mv`ing it REMOVES it, so the removal must gate at the
2267 // rebind face; a `cp` of it only READS (worktree-trusted). Both deny by verdict, so assert
2268 // the source LOCUS to pin the face — this is the case a read-face relocate would fail open
2269 // on, and the value pins that the face is the strict one rather than plain `machine`.
2270 let cfg = "~/.config/safe-chains.toml";
2271 assert_eq!(
2272 resolve(&toks(&["mv", cfg, "./x"])).expect("mv").capabilities[0].locus.local,
2273 LocalLocus::SystemIntegrity,
2274 "mv source removal gates at the REBIND face",
2275 );
2276 assert_eq!(
2277 resolve(&toks(&["cp", cfg, "./x"])).expect("cp").capabilities[0].locus.local,
2278 LocalLocus::WorktreeTrusted,
2279 "cp source read gates at the READ face",
2280 );
2281
2282 // -t DIR and glued forms; fail-closed on unknown flag / lone operand.
2283 let t = resolve(&toks(&["mv", "-t", "./dest", "./a", "./b"])).expect("mv -t");
2284 assert_eq!(t.capabilities.len(), 3, "2 sources + 1 dest");
2285 assert_eq!(project(&resolve(&toks(&["mv", "./only"])).expect("mv")), Verdict::Denied, "no dest");
2286 assert_eq!(project(&resolve(&toks(&["mv", "-Q", "./a", "./b"])).expect("mv")), Verdict::Denied, "unknown flag");
2287 }
2288
2289 #[test]
2290 fn ln_is_cp_by_reference_and_gates_the_target_locus() {
2291 use crate::engine::bridge::project;
2292 use crate::verdict::{SafetyLevel, Verdict};
2293
2294 // a worktree link (hard or symbolic) is target-read + link-create → write-local.
2295 for cmd in [vec!["ln", "./a", "./b"], vec!["ln", "-s", "./target", "./link"]] {
2296 let p = resolve(&toks(&cmd)).expect("ln");
2297 assert_eq!(p.capabilities[0].operation, Operation::Observe, "target is a bridged read");
2298 assert_eq!(project(&p), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
2299 }
2300 // the cp-bypass is closed: linking a SECRET/unreadable TARGET denies on the target
2301 // locus, exactly as `cp` of it would (a link would otherwise alias the secret in).
2302 assert_eq!(project(&resolve(&toks(&["ln", "~/.ssh/id_rsa", "./x"])).expect("ln")), Verdict::Denied, "hard link to home credential");
2303 assert_eq!(project(&resolve(&toks(&["ln", "-s", "/etc/shadow", "./x"])).expect("ln")), Verdict::Denied, "symlink to secret");
2304 // An ORDINARY out-of-workspace target links fine, for the same reason `cat /etc/hosts`
2305 // reads: the link aliases whatever the target could disclose, no more. What the two
2306 // asserts above pin is that the alias cannot launder a target the shield refuses.
2307 assert_eq!(
2308 project(&resolve(&toks(&["ln", "-s", "/etc/hosts", "./x"])).expect("ln")),
2309 Verdict::Allowed(SafetyLevel::SafeWrite),
2310 "symlink to ordinary system path"
2311 );
2312 // writing the LINK outside the worktree denies on the link locus.
2313 assert_eq!(project(&resolve(&toks(&["ln", "-s", "./a", "~/evil"])).expect("ln")), Verdict::Denied, "link into home");
2314 // -t DIR, lone operand, unknown flag.
2315 assert_eq!(resolve(&toks(&["ln", "-t", "./dir", "./a", "./b"])).expect("ln -t").capabilities.len(), 3);
2316 assert_eq!(project(&resolve(&toks(&["ln", "./only"])).expect("ln")), Verdict::Denied, "no link name");
2317 assert_eq!(project(&resolve(&toks(&["ln", "-Q", "./a", "./b"])).expect("ln")), Verdict::Denied, "unknown flag");
2318 // -f (a clobber flag PRESENT) flips the link-create from the no-clobber default
2319 // (`trivial`) to `recoverable` — still write-local. Exercises the `clobber_flags`-present
2320 // branch of the transfer arm, the inverse of cp/mv's `no_clobber_flags`.
2321 let forced = resolve(&toks(&["ln", "-f", "./a", "./b"])).expect("ln -f");
2322 assert_eq!(project(&forced), Verdict::Allowed(SafetyLevel::SafeWrite), "ln -f worktree link");
2323 assert_eq!(forced.capabilities.last().unwrap().reversibility, Reversibility::Recoverable, "ln -f overwrites → recoverable");
2324 assert_eq!(
2325 resolve(&toks(&["ln", "./a", "./b"])).expect("ln").capabilities.last().unwrap().reversibility,
2326 Reversibility::Trivial,
2327 "ln default no-clobber → trivial",
2328 );
2329 }
2330
2331 #[test]
2332 fn dd_parses_key_value_operands_and_gates_both_sides() {
2333 use crate::engine::bridge::project;
2334 use crate::verdict::{SafetyLevel, Verdict};
2335
2336 // a worktree-to-worktree copy → write-local; params (bs/count/conv) are ignored.
2337 assert_eq!(
2338 project(&resolve(&toks(&["dd", "if=./a", "of=./b", "bs=1M", "count=10"])).expect("dd")),
2339 Verdict::Allowed(SafetyLevel::SafeWrite),
2340 "dd worktree copy",
2341 );
2342 // input from stdout (no of=) discloses the input content to the model, like cat.
2343 assert_eq!(project(&resolve(&toks(&["dd", "if=./notes"])).expect("dd")), Verdict::Allowed(SafetyLevel::SafeRead), "dd to stdout");
2344 assert_eq!(project(&resolve(&toks(&["dd"])).expect("dd")), Verdict::Allowed(SafetyLevel::Inert), "bare dd is stdin→stdout");
2345
2346 // both sides gated by locus: a home INPUT or a device/home OUTPUT denies.
2347 for cmd in [
2348 vec!["dd", "if=~/.ssh/id_rsa", "of=./x"], // read a home secret
2349 vec!["dd", "if=./x", "of=/dev/rdisk0"], // write a raw device (disk wipe)
2350 vec!["dd", "if=./x", "of=/dev/sda"],
2351 vec!["dd", "if=./x", "of=~/backup"], // write into home
2352 vec!["dd", "if=~/.ssh/id_rsa"], // home secret to stdout (→ model)
2353 ] {
2354 assert_eq!(project(&resolve(&toks(&cmd)).expect("dd")), Verdict::Denied, "{cmd:?}");
2355 }
2356 // fail-closed: a non key=value operand, or an unknown key, worst-cases.
2357 assert_eq!(project(&resolve(&toks(&["dd", "./file"])).expect("dd")), Verdict::Denied, "positional operand");
2358 assert_eq!(project(&resolve(&toks(&["dd", "exec=evil", "of=./x"])).expect("dd")), Verdict::Denied, "unknown key");
2359 }
2360
2361 #[test]
2362 fn tar_parses_dashless_bundles_and_splits_by_mode() {
2363 use crate::engine::bridge::project;
2364 use crate::verdict::{SafetyLevel, Verdict};
2365
2366 // dashless `czf` and dashed `-czf` and the long form all parse the same: a create is
2367 // members-read + archive-write → write-local for a worktree backup.
2368 for cmd in [
2369 vec!["tar", "czf", "backup.tar", "./src"],
2370 vec!["tar", "-czf", "backup.tar", "./src"],
2371 vec!["tar", "--create", "--file=backup.tar", "./src"],
2372 ] {
2373 assert_eq!(project(&resolve(&toks(&cmd)).expect("tar")), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
2374 }
2375 // list reads the archive → read-local.
2376 assert_eq!(project(&resolve(&toks(&["tar", "tzf", "backup.tar"])).expect("tar")), Verdict::Allowed(SafetyLevel::SafeRead), "list");
2377
2378 // the bundler-exfil case (golden-set): a home member denies on the member locus,
2379 // whether the archive goes to stdout or a file.
2380 assert_eq!(project(&resolve(&toks(&["tar", "czf", "-", "~/.ssh"])).expect("tar")), Verdict::Denied, "bundle secret to stdout");
2381 assert_eq!(project(&resolve(&toks(&["tar", "czf", "out.tar", "~/.aws"])).expect("tar")), Verdict::Denied, "bundle home member");
2382 // a home/system ARCHIVE denies on the archive write locus.
2383 assert_eq!(project(&resolve(&toks(&["tar", "cf", "~/backup.tar", "./src"])).expect("tar")), Verdict::Denied, "archive into home");
2384
2385 // extract is archive-controlled (..-escapable) → worst-case, even for a benign archive.
2386 assert_eq!(project(&resolve(&toks(&["tar", "xzf", "release.tar"])).expect("tar")), Verdict::Denied, "extract");
2387 // `tar cf backup.tar` with no members creates an empty archive — a benign worktree
2388 // write, so SafeWrite (not a fail-closed case).
2389 assert_eq!(
2390 project(&resolve(&toks(&["tar", "cf", "backup.tar"])).expect("tar")),
2391 Verdict::Allowed(SafetyLevel::SafeWrite),
2392 "empty archive"
2393 );
2394 // fail-closed: an unmodeled value option (-C), no mode, an empty profile, a bad letter.
2395 assert_eq!(project(&resolve(&toks(&["tar", "-C", "/etc", "xf", "a.tar"])).expect("tar")), Verdict::Denied, "-C unmodeled");
2396 assert_eq!(project(&resolve(&toks(&["tar", "c"])).expect("tar")), Verdict::Denied, "create to stdout, no members");
2397 assert_eq!(project(&resolve(&toks(&["tar", "zf", "backup.tar"])).expect("tar")), Verdict::Denied, "no mode letter");
2398 }
2399
2400 /// perl's two gates are independent and BOTH are required: the identifier allowlist decides
2401 /// whether the one-liner is inert, locus decides whether the operands may be touched. The
2402 /// second was missing — `perl -pe 's/a/b/' /etc/shadow` auto-approved, because the handler
2403 /// judged only the code — so the read cases below are the regression, and the `-i` cases are
2404 /// the capability the missing gate had been standing in for.
2405 /// Parse `line` and ask what a `$( … )` around it would evaluate to.
2406 #[cfg(test)]
2407 fn sub_locus(line: &str) -> Option<LocalLocus> {
2408 let script = crate::cst::parse(line).expect("parses");
2409 match substitution_claim(&script)? {
2410 SubClaim::Locus(l) => Some(l),
2411 // An atom names no locus, so these callers — which ask "which rung does this value
2412 // point at" — correctly see nothing.
2413 SubClaim::Atom => None,
2414 }
2415 }
2416
2417 /// No output claim survives `--help` / `--version`, for EVERY command that declares one.
2418 ///
2419 /// Enumerated over the registry rather than spot-checked on seq, because the failure is a
2420 /// property of what those flags DO — replace the command's data output with prose — and so it
2421 /// applies to every claim, including ones added later. The prose routinely carries paths and
2422 /// URLs: GNU `seq --help` prints `<https://www.gnu.org/software/coreutils/>` under an `atom`
2423 /// claim asserting no word holds a separator.
2424 ///
2425 /// Missed by hand-probing because macOS ships BSD seq, whose help is terse and slash-free —
2426 /// the local install disagreed with the upstream the claim is written against.
2427 #[test]
2428 fn no_output_claim_survives_a_help_or_version_flag() {
2429 let mut probed = 0usize;
2430 for (scope, spec) in crate::registry::output_claims() {
2431 // A claim gated on a required flag is only ever live WITH it, so the probe has to carry
2432 // it — otherwise the assertion holds for the boring reason and guards nothing.
2433 let scope = match spec.requires.first() {
2434 Some(required) => format!("{scope} {required}"),
2435 None => scope,
2436 };
2437 for flag in ["--help", "--version"] {
2438 let line = format!("{scope} {flag}");
2439 let Some(script) = crate::cst::parse(&line) else { continue };
2440 probed += 1;
2441 assert!(
2442 substitution_claim(&script).is_none(),
2443 "`{line}` still carries an output claim, but --help/--version print prose \
2444 rather than the command's data, so the claim does not describe it"
2445 );
2446 }
2447 }
2448 assert!(probed > 0, "nothing declares an output claim; this guard would be vacuous");
2449 }
2450
2451 /// A sub-scoped claim must survive every TRUSTED spelling of its command, and no other.
2452 ///
2453 /// The walker keys on the registry name, so it has to be handed the CANONICALIZED one — the
2454 /// same key the command-level lookup gets. Given the raw first word instead, `/usr/bin/git diff
2455 /// --name-only` silently lost the claim that bare `git` kept: one operation, two spellings, two
2456 /// answers, which is the false-deny class the flag-form guards exist to kill.
2457 ///
2458 /// The other half is that this must NOT extend trust: `./git` is a worktree binary that may not
2459 /// be git at all, and `trusted_command_path` is what keeps it claimless.
2460 #[test]
2461 fn a_sub_claim_follows_every_trusted_spelling_of_its_command() {
2462 let bare = sub_locus("git diff --name-only");
2463 assert!(bare.is_some(), "precondition: bare `git diff --name-only` should carry a claim");
2464 for spelling in ["/usr/bin/git", "/opt/homebrew/bin/git"] {
2465 assert_eq!(
2466 sub_locus(&format!("{spelling} diff --name-only")),
2467 bare,
2468 "`{spelling} diff --name-only` disagrees with the bare spelling",
2469 );
2470 }
2471 for untrusted in ["./git", "/tmp/git", "../git"] {
2472 assert_eq!(
2473 sub_locus(&format!("{untrusted} diff --name-only")),
2474 None,
2475 "`{untrusted}` is not a trusted path to git and must earn no output claim",
2476 );
2477 }
2478 }
2479
2480 /// A claim gated on `requires` must be DEAD without its flag. `git diff` prints a patch and
2481 /// `jj diff` a diff; only `--name-only` turns either into a list of paths, so the ungated
2482 /// invocation must stay unpinnable. Without this, `requires` could be silently ignored and the
2483 /// claim would widen every invocation of the sub.
2484 #[test]
2485 fn a_required_flag_is_necessary_for_its_claim() {
2486 let mut probed = 0usize;
2487 for (scope, spec) in crate::registry::output_claims() {
2488 if spec.requires.is_empty() {
2489 continue;
2490 }
2491 probed += 1;
2492 let Some(script) = crate::cst::parse(&scope) else { continue };
2493 assert_eq!(
2494 substitution_claim(&script).map(|_| ()),
2495 None,
2496 "`{scope}` carries an output claim without any of {:?}, which the declaration says \
2497 are required for the output to be paths at all",
2498 spec.requires,
2499 );
2500 // ...and LIVE with it, or the declaration describes nothing.
2501 for required in &spec.requires {
2502 let line = format!("{scope} {required}");
2503 let Some(script) = crate::cst::parse(&line) else { continue };
2504 assert!(
2505 substitution_claim(&script).is_some(),
2506 "`{line}` carries no output claim, but `{required}` is declared as one of the \
2507 flags that makes the claim hold"
2508 );
2509 }
2510 }
2511 assert!(probed > 0, "nothing declares `requires`; this guard would be vacuous");
2512 }
2513
2514 /// Fail-closed, enumerated over the REGISTRY: every `[command.output]` claim is probed on a HOT
2515 /// root, and must never report a locus below what reading that root reports. This is the
2516 /// fail-open the whole feature risks — a missed search root means the substitution is admitted
2517 /// at worktree while the command actually reaches `/etc`. The `match` is EXHAUSTIVE, so a new
2518 /// `OutputLocus` variant must state how it is probed or the build breaks.
2519 ///
2520 /// Red→green: drop the glued-value branch from `candidate_roots` and
2521 /// `fd --search-path=/etc x` stops reporting machine.
2522 #[test]
2523 fn every_output_claim_is_bounded_by_its_roots() {
2524 use crate::registry::types::OutputLocus;
2525
2526 let mut probed = 0usize;
2527 for (scope, spec) in crate::registry::output_claims() {
2528 probed += 1;
2529 // A `requires`-gated claim is only live with its flag, so every probe below carries it.
2530 // `name` is therefore the invocation PREFIX, not just a command name.
2531 let name = match spec.requires.first() {
2532 Some(required) => format!("{scope} {required}"),
2533 None => scope.clone(),
2534 };
2535 let name = name.as_str();
2536 match spec.locus_from {
2537 // An `atom` claim is that no output word can contain a separator, so the check is
2538 // the claim: run the command's OWN examples and read what they would print. A
2539 // command whose examples emit a `/` is mis-declared, and the consequence is not
2540 // subtle — the confinement layer treats the value as unable to leave its
2541 // component, so a separator would let it walk anywhere the prefix can reach.
2542 //
2543 // Enumerated over the registry rather than spot-checked, because the next command
2544 // to declare `atom` gets this for free, which is the only way a data-driven claim
2545 // stays honest as the data grows.
2546 // An `atom` claim cannot be checked the way the others can. The rest are probed by
2547 // asking the resolver where a HOT root lands, but "no output word contains a
2548 // separator" is a fact about the TOOL, and the only mechanical way to confirm it
2549 // would be to run the command — which a unit test must not do for arbitrary
2550 // registry entries.
2551 //
2552 // So this is a REVIEW gate, not a proof: the claim has to be argued per command,
2553 // and a new declaration fails here until someone does that and adds it. What makes
2554 // it worth having is the failure mode it guards — an atom is treated as unable to
2555 // leave its path component, so a tool that CAN emit a `/` would let the value walk
2556 // anywhere its prefix reaches. `seq`'s argument is in its TOML: numbers only, with
2557 // the three flags that inject caller text (`-s`, `-t`, `-f`) in `invalidated_by`.
2558 //
2559 // The soundness of the confinement ITSELF — that a separator-free value beside
2560 // literal text cannot escape — is proved separately, by
2561 // `a_flanked_atom_never_moves_where_the_write_lands`.
2562 OutputLocus::Atom => {
2563 const ARGUED: &[&str] = &["seq"];
2564 assert!(
2565 ARGUED.contains(&name),
2566 "command '{name}' declares `locus_from = \"atom\"`, which asserts that no \
2567 word it prints can contain a separator. That cannot be checked here \
2568 without running the command, so it must be argued in the command's TOML \
2569 (what it prints, and which flags reshape it into `invalidated_by`) and \
2570 then listed in ARGUED."
2571 );
2572 }
2573 OutputLocus::Operands => {
2574 // `~` is here as a named case, not just inside HOT_PATHS, because it is the
2575 // spelling that actually got through: it carries neither `/` nor `.`, so the
2576 // path-SHAPE test skipped it and `cat $(fd pat ~)` swept the home directory
2577 // while reporting worktree.
2578 let hot_roots: Vec<&str> = HOT_PATHS.iter().copied().chain(["~", "~/.ssh"]).collect();
2579 for hot in hot_roots {
2580 // Every spelling a root can arrive in: bare operand, separated flag value,
2581 // glued long value, glued short value. Missing any is the fail-open.
2582 for line in [
2583 format!("{name} pat {hot}"),
2584 format!("{name} --base-directory {hot} pat"),
2585 format!("{name} --search-path={hot} pat"),
2586 format!("{name} -E{hot} pat"),
2587 ] {
2588 let got = sub_locus(&line);
2589 let want = read_locus(hot);
2590 assert!(got.is_none_or(|l| l >= want), "`{line}`: reported {got:?}, but reading {hot} is {want:?}",);
2591 }
2592 }
2593 // A substitution in a root slot is unknowable — no claim.
2594 assert_eq!(sub_locus(&format!("{name} pat $(hostname)")), None, "{name}: nested sub");
2595 }
2596 // Its output is the cwd, which takes no root operand; the guard that matters is
2597 // that it does not somehow report BELOW the cwd's own locus.
2598 OutputLocus::Cwd => {
2599 assert_eq!(sub_locus(name), Some(read_locus(".")), "{name}: bare");
2600 }
2601 // A filter only filters while it has no file operand — given one it prints that
2602 // file's CONTENTS, which are not paths and must void the claim.
2603 OutputLocus::Stdin => {
2604 for hot in HOT_PATHS {
2605 assert_eq!(sub_locus(&format!("{name} {hot}")), None, "{name}: a file operand makes it print contents, not paths",);
2606 }
2607 }
2608 }
2609 // Every flag the command declares as invalidating must actually void the claim.
2610 for flag in &spec.invalidated_by {
2611 let line = format!("{name} {flag} pat");
2612 assert_eq!(sub_locus(&line), None, "`{line}`: {flag} is declared invalidating");
2613 }
2614 }
2615 assert!(probed > 0, "no command declares [command.output] — the guard is vacuous");
2616 // The enumeration must reach SUB-scoped claims, not just command-scoped ones. Without this
2617 // the extension is silently self-defeating: a walker that stopped at the top level would
2618 // make every `[command.sub.output]` skip the probes above and the guard would still be
2619 // green, reporting coverage it does not have.
2620 assert!(
2621 crate::registry::output_claims().iter().any(|(scope, _)| scope.contains(' ')),
2622 "no sub-scoped output claim was enumerated, so `[command.sub.output]` is unprobed",
2623 );
2624 }
2625
2626 /// Enumerated over the REGISTRY: a flag declared `valued` on `[command.output]` means "this
2627 /// value is not a path", and BOTH spellings must agree. Handling only the separated form denied
2628 /// `head --lines=5` while `head -n 5` passed — one operation, two spellings, two answers, which
2629 /// is the false-deny class the flag-form equivalence guards exist to kill.
2630 #[test]
2631 fn output_valued_flags_agree_across_spellings() {
2632 use crate::registry::types::OutputLocus;
2633 let mut checked = 0usize;
2634 for (scope, spec) in crate::registry::output_claims() {
2635 // As above: a `requires`-gated claim is only live with its flag, so the probe carries it.
2636 let name = match spec.requires.first() {
2637 Some(required) => format!("{scope} {required}"),
2638 None => scope.clone(),
2639 };
2640 let name = name.as_str();
2641 for flag in &spec.valued {
2642 // An invalidating flag voids the claim by design, so it is not a spelling case.
2643 if spec.invalidated_by.contains(flag) {
2644 continue;
2645 }
2646 // Two things are load-bearing about the probe shape, and without EITHER the
2647 // guard silently passes a broken skip:
2648 // - a PRODUCER stage, because a lone `stdin` command walks back off the end of
2649 // the pipeline and reports `None` whether or not it saw a file operand, hiding
2650 // the difference entirely;
2651 // - a TRAILING OPERAND, because a glued form that over-skips (swallowing the
2652 // next argument as if it were a separated value) is indistinguishable from a
2653 // correct one until there is a next argument to lose.
2654 // Together they expose the over-skip as a file operand going missing — which for
2655 // a `stdin` claim is a fail-open: contents get classified as if they were paths.
2656 let producer = match spec.locus_from {
2657 OutputLocus::Stdin => "fd a app/ | ",
2658 _ => "",
2659 };
2660 for tail in ["", " /etc/hosts"] {
2661 let separated = sub_locus(&format!("{producer}{name} {flag} 5{tail}"));
2662 let glued = sub_locus(&format!("{producer}{name} {flag}=5{tail}"));
2663 assert_eq!(separated, glued, "{name} {flag} (tail {tail:?}): separated {separated:?}, glued {glued:?}",);
2664 checked += 1;
2665 }
2666 }
2667 }
2668 assert!(checked > 0, "no output claim declares a valued flag — the guard is vacuous");
2669 }
2670
2671 /// The default is unpinnable. A command that has NOT been researched for its output locus must
2672 /// keep the opaque sentinel, so the feature can only ever widen through a deliberate
2673 /// declaration — never by a command happening to look read-only.
2674 #[test]
2675 fn undeclared_commands_get_no_output_claim() {
2676 // `echo` is the load-bearing case: as safe as a command gets, and its output is whatever
2677 // the caller typed. If it ever acquires a claim, `cat $(echo /etc/shadow)` opens up.
2678 for line in ["echo /etc/shadow", "hostname", "cat ./f", "ls", "git rev-parse --show-toplevel"] {
2679 assert_eq!(sub_locus(line), None, "`{line}` must have no output claim");
2680 }
2681 assert!(!crate::is_safe_command("cat $(echo /etc/shadow)"), "echo must not bound its output");
2682 }
2683
2684 #[test]
2685 fn perl_i_worktree_vs_system() {
2686 use crate::engine::bridge::project;
2687 use crate::verdict::{SafetyLevel, Verdict};
2688
2689 // No -i: the operands are content reads, gated by READ locus.
2690 let read = resolve(&toks(&["perl", "-pe", "s/x/y/", "./foo"])).expect("perl");
2691 assert_eq!(read.capabilities[0].operation, Operation::Observe, "no -i → read");
2692 assert_eq!(project(&read), Verdict::Allowed(SafetyLevel::SafeRead), "perl read");
2693
2694 // -i flips them to in-place MUTATES, admitted only in the worktree.
2695 let edit = resolve(&toks(&["perl", "-pi", "-e", "s/x/y/", "./foo"])).expect("perl");
2696 assert_eq!(edit.capabilities[0].operation, Operation::Mutate, "-i → in-place write");
2697 assert_eq!(project(&edit), Verdict::Allowed(SafetyLevel::SafeWrite), "perl -i worktree");
2698 let glued = resolve(&toks(&["perl", "-i.bak", "-pe", "s/x/y/", "./foo"])).expect("perl");
2699 assert_eq!(glued.capabilities[0].operation, Operation::Mutate, "-i.bak is still in-place");
2700
2701 // THE REGRESSION: an inert one-liner does not license the operand. It is gated exactly as
2702 // `cat` and `sed` gate theirs — so a credential store or an unpinnable path denies, while
2703 // an ordinary machine file (asserted below) reads.
2704 for cmd in [
2705 vec!["perl", "-pe", "s/a/b/", "/etc/shadow"],
2706 vec!["perl", "-ne", "print", "~/.ssh/id_rsa"],
2707 vec!["perl", "-pe", "s/a/b/", "$CONFIG"], // unpinnable
2708 vec!["perl", "-pi", "-e", "s/a/b/", "/etc/hosts"],
2709 vec!["perl", "-pi", "-e", "s/a/b/", "~/.bashrc"],
2710 vec!["perl", "-pi", "-e", "s/a/b/", "../outside"],
2711 ] {
2712 assert_eq!(project(&resolve(&toks(&cmd)).expect("perl")), Verdict::Denied, "{cmd:?} must deny");
2713 }
2714 // The WRITE half stays put: reading /etc/passwd is fine, rewriting it in place is not.
2715 assert_eq!(
2716 project(&resolve(&toks(&["perl", "-pe", "s/a/b/", "/etc/passwd"])).expect("perl")),
2717 Verdict::Allowed(SafetyLevel::SafeRead),
2718 "an inert one-liner over an ordinary machine file is a read"
2719 );
2720
2721 // Opaque code is refused whatever the operand: no `-e` means the first operand is a script
2722 // file we cannot read, and a failed identifier gate means the one-liner left the vocabulary.
2723 for cmd in [
2724 vec!["perl", "./script.pl"],
2725 vec!["perl", "-n", "./file.txt"],
2726 vec!["perl", "-e", "system(\"rm -rf /\")", "./foo"],
2727 vec!["perl", "-pie", "s/a/b/", "./foo"], // ambiguous suffix spelling — unmodeled
2728 ] {
2729 assert_eq!(project(&resolve(&toks(&cmd)).expect("perl")), Verdict::Denied, "{cmd:?} must deny");
2730 }
2731
2732 // A worktree-scoped sweep is bounded, not single — scored honestly, still admitted.
2733 let glob = resolve(&toks(&["perl", "-pi", "-e", "s/a/b/", "*"])).expect("perl");
2734 assert_eq!(glob.capabilities[0].scale, Scale::Bounded, "a glob is a bounded blast radius");
2735 assert_eq!(project(&glob), Verdict::Allowed(SafetyLevel::SafeWrite), "perl -i * (worktree)");
2736 }
2737
2738 #[test]
2739 fn sed_i_flips_read_to_write_and_locus_stops_system_wide_damage() {
2740 use crate::engine::bridge::project;
2741 use crate::verdict::{SafetyLevel, Verdict};
2742
2743 // -i turns the file operands from reads into in-place MUTATES.
2744 let read = resolve(&toks(&["sed", "s/x/y/", "./foo"])).expect("sed");
2745 assert_eq!(read.capabilities[0].operation, Operation::Observe, "no -i → read");
2746 assert_eq!(project(&read), Verdict::Allowed(SafetyLevel::SafeRead), "sed read");
2747 let edit = resolve(&toks(&["sed", "-i", "s/x/y/", "./foo"])).expect("sed");
2748 assert_eq!(edit.capabilities[0].operation, Operation::Mutate, "-i → in-place write");
2749 assert_eq!(project(&edit), Verdict::Allowed(SafetyLevel::SafeWrite), "sed -i worktree");
2750
2751 // THE CONCERN: a stray system-wide `sed -i` is stopped by LOCUS — a system, home, or
2752 // unpinnable target denies whatever the scale. Damage needs a target above the
2753 // worktree, and every such target is denied.
2754 for cmd in [
2755 vec!["sed", "-i", "s/a/b/", "/etc/passwd"],
2756 vec!["sed", "-i", "s/a/b/", "/etc/hosts"],
2757 vec!["sed", "-i", "s/a/b/", "~/.bashrc"],
2758 vec!["sed", "-i", "s/a/b/", "$CONFIG"], // unpinnable
2759 vec!["sed", "-i", "s/a/b/", "../outside"], // escapes the worktree
2760 vec!["sed", "-i", "-e", "s/a/b/", "/etc/x"], // -e script, system file
2761 ] {
2762 assert_eq!(project(&resolve(&toks(&cmd)).expect("sed")), Verdict::Denied, "{cmd:?} must deny");
2763 }
2764
2765 // A worktree-scoped sweep IS allowed — bounded, recoverable, your own project files.
2766 // The glob/multi-operand blast radius is scored as `bounded`, still write-local.
2767 let glob = resolve(&toks(&["sed", "-i", "s/a/b/", "*"])).expect("sed");
2768 assert_eq!(glob.capabilities[0].scale, Scale::Bounded, "a glob is a bounded blast radius");
2769 assert_eq!(project(&glob), Verdict::Allowed(SafetyLevel::SafeWrite), "sed -i * (worktree)");
2770 assert_eq!(
2771 project(&resolve(&toks(&["sed", "-i", "s/a/b/", "a", "b", "c"])).expect("sed")),
2772 Verdict::Allowed(SafetyLevel::SafeWrite),
2773 "multi-file"
2774 );
2775
2776 // -i.bak (optional glued suffix) still parses as in-place.
2777 assert_eq!(
2778 project(&resolve(&toks(&["sed", "-i.bak", "s/a/b/", "./foo"])).expect("sed")),
2779 Verdict::Allowed(SafetyLevel::SafeWrite),
2780 "-i.bak"
2781 );
2782 // -f runs a script file we can't inspect (its e/w/r commands are invisible) → denied, like
2783 // `awk -f`, `bash script.sh`, mlr `--load`.
2784 assert_eq!(
2785 project(&resolve(&toks(&["sed", "-f", "script.sed", "./foo"])).expect("sed")),
2786 Verdict::Denied,
2787 "-f script file unanalyzable"
2788 );
2789 // a home file read (no -i) still denies by locus, like cat.
2790 assert_eq!(project(&resolve(&toks(&["sed", "s/a/b/", "~/.ssh/id_rsa"])).expect("sed")), Verdict::Denied, "read home secret");
2791 assert_eq!(project(&resolve(&toks(&["sed", "-Q", "./foo"])).expect("sed")), Verdict::Denied, "unknown flag");
2792 }
2793
2794 #[test]
2795 fn sed_exec_command_is_worst_cased_at_parity_with_legacy() {
2796 use crate::engine::bridge::project;
2797 use crate::verdict::Verdict;
2798 // The `e` command/modifier executes text as a shell command (RCE). The resolver must
2799 // worst-case it — flag parsing alone treated the script as opaque and let it through.
2800 for cmd in [
2801 vec!["sed", "s/test/touch tmp/e", "file"], // s///e modifier
2802 vec!["sed", "-e", "s/x/cmd/e", "file"], // via -e
2803 vec!["sed", "s/x/cmd/ew", "file"], // e flag BEFORE the greedy w flag
2804 vec!["sed", "1e", "file"], // address + e
2805 vec!["sed", "e"], // bare e
2806 vec!["sed", "-e", "e"],
2807 vec!["sed", "1e reboot", "file"], // address + e WITH a command argument
2808 vec!["sed", "p;e id", "file"], // e after a `;` separator
2809 ] {
2810 assert_eq!(project(&resolve(&toks(&cmd)).expect("sed")), Verdict::Denied, "{cmd:?}: exec must deny");
2811 }
2812 // `s/x/cmd/we` is NOT here: `w` is greedy-to-EOL, so `we` writes to a file named `e` (a
2813 // local SafeWrite), not w-then-e exec. `sed '1e reboot'` — the former residual gap — is now
2814 // caught by the sed sub-parser (`scan_sed`).
2815 }
2816
2817 /// HP-19 #1 (engine): `classify_locus` now resolves relative paths against the ambient
2818 /// cwd/root. With no context it falls back to relative-is-worktree (status quo); under a
2819 /// `cd /etc` context the same operands resolve to `/etc/*` and deny.
2820 #[test]
2821 fn classify_locus_resolves_relative_operands_against_the_cwd_context() {
2822 use crate::engine::bridge::project;
2823 use crate::pathctx::PathCtx;
2824 use crate::verdict::{SafetyLevel, Verdict};
2825
2826 // No context → relative is worktree (fallback), and a sweeping edit is write-local.
2827 for p in ["*", "passwd", "config"] {
2828 assert_eq!(classify_locus(p), LocalLocus::Worktree, "{p}: no ctx → worktree");
2829 }
2830 assert_eq!(
2831 project(&resolve(&toks(&["sed", "-i", "s/a/b/", "*"])).expect("sed")),
2832 Verdict::Allowed(SafetyLevel::SafeWrite),
2833 "no ctx: sed -i *"
2834 );
2835
2836 // Context says the shell is in /etc → relative operands are /etc/* → machine → deny.
2837 let _g = crate::pathctx::enter(PathCtx { cwd: Some("/etc".into()), root: Some("/home/u/proj".into()), ..Default::default() });
2838 for p in ["*", "hosts", "config", "cron.d"] {
2839 assert_eq!(classify_locus(p), LocalLocus::Machine, "{p}: cwd=/etc → machine");
2840 }
2841 // /etc/passwd is the identity substrate: its WRITE face worst-cases to system-integrity
2842 // (above machine → above local-admin), even reached as a relative operand from cwd=/etc.
2843 assert_eq!(classify_locus("passwd"), LocalLocus::SystemIntegrity, "passwd: cwd=/etc → system-integrity");
2844 assert_eq!(project(&resolve(&toks(&["sed", "-i", "s/a/b/", "*"])).expect("sed")), Verdict::Denied, "cwd=/etc: sed -i * denied");
2845 assert_eq!(project(&resolve(&toks(&["dd", "if=./x", "of=passwd"])).expect("dd")), Verdict::Denied, "cwd=/etc: dd of=passwd denied");
2846 assert_eq!(project(&resolve(&toks(&["cp", "./payload", "config"])).expect("cp")), Verdict::Denied, "cwd=/etc: cp denied");
2847 }
2848
2849 /// One operation, three spellings of in-place, one answer.
2850 ///
2851 /// BSD (macOS) spells the empty in-place suffix as a SEPARATE word — `sed -i '' SCRIPT FILE` —
2852 /// and modelled GNU-only, `-i` consumed nothing, so `''` landed in the first positional, which
2853 /// for sed is the SCRIPT. Everything shifted one: the real script became a FILE operand, got
2854 /// word-split, and any absolute-looking token inside it picked the locus. That is not a
2855 /// contrived input — the decision log caught it on `s|…|// TEMP: no-op|`, where the `//` of a
2856 /// JavaScript comment read as the filesystem root and a worktree edit denied at `machine`.
2857 ///
2858 /// Enumerated over scripts that contain the tokens which make the shift visible (`$`, `//`, a
2859 /// leading `/`), because the bug is invisible on a script that happens to hold none of them.
2860 #[test]
2861 fn sed_in_place_classifies_the_same_in_every_spelling() {
2862 use crate::engine::bridge::project;
2863 use crate::verdict::{SafetyLevel, Verdict};
2864
2865 for script in ["1257,$d", "s|x|// TEMP|", "s|a|/b|", "1,$s/x/y/"] {
2866 let bsd = resolve(&toks(&["sed", "-i", "", script, "./app.css"])).expect("sed");
2867 let gnu = resolve(&toks(&["sed", "-i.bak", script, "./app.css"])).expect("sed");
2868 let read = resolve(&toks(&["sed", "-n", script, "./app.css"])).expect("sed");
2869 assert_eq!(project(&bsd), Verdict::Allowed(SafetyLevel::SafeWrite), "`sed -i '' {script} ./app.css` is a worktree edit");
2870 assert_eq!(project(&bsd), project(&gnu), "{script}: -i '' and -i.bak must agree");
2871 assert!(matches!(project(&read), Verdict::Allowed(_)), "{script}: -n is a plain read");
2872 }
2873
2874 // The separate word is consumed ONLY when empty. Under BSD the token after `-i` is a
2875 // SUFFIX, so accepting a non-empty one would let `-i` swallow a real operand — and the
2876 // operand it swallowed would be the one carrying the locus.
2877 assert_eq!(
2878 project(&resolve(&toks(&["sed", "-i", "", "s/a/b/", "/etc/passwd"])).expect("sed")),
2879 Verdict::Denied,
2880 "the FILE after a consumed `-i ''` is still gated"
2881 );
2882 }
2883
2884 /// Which word a short flag consumes decides which word is the FILE, and the file carries the
2885 /// locus. Each pair below differs only in what the flag swallowed, and a wrong count moves a
2886 /// system path into or out of the operand list.
2887 #[test]
2888 fn sed_short_flags_consume_exactly_their_own_value() {
2889 use crate::engine::bridge::project;
2890 use crate::verdict::{SafetyLevel, Verdict};
2891 let verdict = |cmd: &[&str]| project(&resolve(&toks(cmd)).expect("sed"));
2892
2893 // `-e SCRIPT` takes the next word; `-eSCRIPT` takes nothing more.
2894 assert_eq!(verdict(&["sed", "-i", "-e", "/x/d", "./foo"]), Verdict::Allowed(SafetyLevel::SafeWrite), "-e consumed /x/d");
2895 assert_eq!(verdict(&["sed", "-i", "-e/x/d", "/etc/hosts"]), Verdict::Denied, "-eS leaves the file an operand");
2896
2897 // `-l N` (line length) takes its value, glued or separate.
2898 for cmd in [["sed", "-l", "5", "s/a/b/", "./foo"].as_slice(), &["sed", "-l5", "s/a/b/", "./foo"]] {
2899 assert_eq!(verdict(cmd), Verdict::Allowed(SafetyLevel::SafeRead), "{cmd:?}");
2900 }
2901 // A trailing `-l` with no value is malformed, and malformed fails closed.
2902 assert_eq!(verdict(&["sed", "-e", "p", "./foo", "-l"]), Verdict::Denied, "-l without a value");
2903
2904 // An unknown byte in a cluster fails closed even when the script is harmless.
2905 for cmd in [["sed", "-Q", "s/a/b/", "./foo"], ["sed", "-nQ", "s/a/b/", "./foo"]] {
2906 assert_eq!(verdict(&cmd), Verdict::Denied, "{cmd:?}");
2907 }
2908 }
2909
2910 #[test]
2911 fn touch_creates_in_the_worktree_and_gates_the_reference_path() {
2912 use crate::engine::bridge::project;
2913 use crate::verdict::{SafetyLevel, Verdict};
2914 for cmd in [
2915 vec!["touch", "./new.txt"],
2916 vec!["touch", "-c", "existing"],
2917 vec!["touch", "-r", "ref.txt", "./out"], // worktree reference: a read + a create, both worktree
2918 vec!["touch", "-d", "-1 day", "./out"], // -d takes a DATE literal (not a path), dash-leading value
2919 ] {
2920 assert_eq!(project(&resolve(&toks(&cmd)).expect("touch")), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
2921 }
2922 // `-r REF` reads REF's timestamp — a path-flag gated by REF's locus. A worktree ref is a
2923 // worktree read (allowed, 2 caps), but an out-of-workspace reference DENIES (it would
2924 // otherwise be an mtime/existence oracle for arbitrary paths).
2925 let p = resolve(&toks(&["touch", "-r", "ref.txt", "./out"])).expect("touch");
2926 assert_eq!(p.capabilities.len(), 2, "./out create + ref.txt read");
2927 assert!(p.capabilities.iter().any(|c| c.operation == Operation::Observe), "the -r reference is a read");
2928 // An ordinary home reference is an ordinary read of its mtime; a credential store's is
2929 // not, and neither is a path the shield cannot be asked about.
2930 assert_eq!(
2931 project(&resolve(&toks(&["touch", "-r", "~/.bashrc", "./out"])).expect("touch")),
2932 Verdict::Allowed(SafetyLevel::SafeWrite),
2933 "ordinary home reference"
2934 );
2935 assert_eq!(project(&resolve(&toks(&["touch", "-r", "/etc/shadow", "./out"])).expect("touch")), Verdict::Denied, "system reference");
2936 assert_eq!(
2937 project(&resolve(&toks(&["touch", "--reference=/etc/shadow", "./out"])).expect("touch")),
2938 Verdict::Denied,
2939 "long glued reference"
2940 );
2941 assert_eq!(
2942 project(&resolve(&toks(&["touch", "--reference", "/etc/shadow", "./out"])).expect("touch")),
2943 Verdict::Denied,
2944 "long spaced reference"
2945 );
2946 // -d's dash-leading date literal is NOT a path and is NOT gated.
2947 assert_eq!(
2948 project(&resolve(&toks(&["touch", "-d", "-1 day", "/tmp/../etc/x"])).expect("touch")),
2949 Verdict::Denied,
2950 "operand still gated"
2951 );
2952 // beyond the worktree, and fail-closed cases
2953 assert_eq!(project(&resolve(&toks(&["touch", "/etc/x"])).expect("touch")), Verdict::Denied, "system path");
2954 assert_eq!(project(&resolve(&toks(&["touch", "-Z", "x"])).expect("touch")), Verdict::Denied, "unknown flag");
2955 assert_eq!(project(&resolve(&toks(&["touch"])).expect("touch")), Verdict::Denied, "no operand");
2956 }
2957
2958 #[test]
2959 fn worst_case_is_denied_even_by_a_permissive_yolo_shaped_level() {
2960 use crate::engine::level::{Clause, Level, OrdBound};
2961 // a yolo-shaped level: allow anything local up to `machine`, minus a destroy corner
2962 let yolo = Level::new("yolo-ish")
2963 .allowing(Clause { local_locus: Some(OrdBound::at_most(LocalLocus::Machine)), ..Default::default() })
2964 .denying(Clause {
2965 operation: Some(vec![Operation::Destroy]),
2966 reversibility: Some(OrdBound::at_least(Reversibility::Irreversible)),
2967 ..Default::default()
2968 });
2969 let wc = Profile::of(vec![Capability::worst("test")]);
2970 assert!(!yolo.admits(&wc), "worst_case (locus=kernel) exceeds even a machine-capped allow");
2971 }
2972
2973 #[test]
2974 fn rm_within_the_worktree_projects_to_developer_but_beyond_it_denies() {
2975 use crate::engine::bridge::project;
2976 use crate::verdict::{SafetyLevel, Verdict};
2977 // `developer` admits destroy WITHIN the worktree (golden-set decision 2), even
2978 // recursive/effortful; it maps to the legacy SafeWrite ceiling.
2979 for cmd in [
2980 vec!["rm", "./stale.log"],
2981 vec!["rm", "-rf", "./node_modules"],
2982 vec!["rm", "a", "b", "c"],
2983 vec!["rm", "--interactive=always", "./x"], // optional-arg long: must not worst-case
2984 ] {
2985 let p = resolve(&toks(&cmd)).expect("rm resolves");
2986 assert!(p.capabilities.iter().all(|c| c.operation == Operation::Destroy), "{cmd:?} destroys");
2987 assert_eq!(project(&p), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?} → developer");
2988 }
2989 // Deletion that reaches beyond the worktree (home/system) is above `developer`,
2990 // denied by locus — no clause admits a machine/user-scoped destroy.
2991 for cmd in [vec!["rm", "-rf", "/"], vec!["rm", "-rf", "~/notes"], vec!["rm", "/etc/hosts"]] {
2992 assert_eq!(project(&resolve(&toks(&cmd)).expect("rm")), Verdict::Denied, "{cmd:?} beyond worktree");
2993 }
2994 }
2995
2996 /// End-to-end: `rm -rf /` resolves to the `destroy · irreversible · unbounded` corner and
2997 /// is the one thing even a maximally-permissive yolo refuses — by facet, not by name.
2998 /// Everything one facet away stays yolo-admitted.
2999 #[test]
3000 fn rm_rf_root_is_the_one_thing_even_yolo_denies() {
3001 let yolo = level("yolo");
3002 let root = resolve(&toks(&["rm", "-rf", "/"])).expect("rm");
3003 assert_eq!(root.capabilities[0].reversibility, Reversibility::Irreversible, "rm -rf / is irreversible");
3004 assert_eq!(root.capabilities[0].scale, Scale::Unbounded);
3005 assert!(!yolo.admits(&root), "rm -rf / denied even at yolo");
3006 assert!(!yolo.admits(&resolve(&toks(&["rm", "-rf", "~/notes"])).expect("rm")), "rm -rf ~ likewise");
3007 // adjacent-by-one-facet stays yolo-allowed:
3008 assert!(yolo.admits(&resolve(&toks(&["rm", "-rf", "./node_modules"])).expect("rm")), "recoverable worktree");
3009 assert!(yolo.admits(&resolve(&toks(&["rm", "/etc/hosts"])).expect("rm")), "single (bounded) system delete");
3010 }
3011
3012 /// Phase 1 end-to-end: a subcommand tagged `profile = "<archetype>"` resolves (through the
3013 /// nested `<resource> <action>` grammar) to that archetype's exact static capability, so its
3014 /// verdict is DERIVED from facets, not hand-marked. Untagged sibling subs leave the engine
3015 /// abstaining (→ legacy).
3016 #[test]
3017 fn a_subcommand_profile_resolves_to_its_archetype() {
3018 let p = resolve(&toks(&["koyeb", "apps", "delete", "myapp"])).expect("koyeb apps delete resolves");
3019 assert_eq!(p.capabilities.len(), 1);
3020 assert_eq!(
3021 &p.capabilities[0],
3022 crate::engine::archetype::archetype("remote-destroy-recoverable").unwrap(),
3023 "the sub resolves to its declared archetype's capability",
3024 );
3025 // a differently-tagged action gets a different archetype
3026 let create = resolve(&toks(&["koyeb", "apps", "create", "myapp"])).expect("resolves");
3027 assert_eq!(create.capabilities[0].operation, Operation::Create);
3028 // an untagged read sub: no profile, no command behavior → the engine abstains (legacy decides)
3029 assert!(resolve(&toks(&["koyeb", "apps", "list"])).is_none(), "untagged sub → engine abstains");
3030 }
3031
3032 /// Per-flag escalation (Phase 1 layer): a dangerous flag ADDS a capability to the sub's profile,
3033 /// and the level algebra takes the max — so a benign base + a destructive flag lands at the
3034 /// flag's tier. `git push` is vcs-sync (network-admin); `git push --force` adds
3035 /// remote-destroy-irreversible and escalates past it, to yolo.
3036 #[test]
3037 fn an_escalating_flag_adds_a_capability_and_raises_the_tier() {
3038 let destroy = crate::engine::archetype::archetype("remote-destroy-irreversible").unwrap();
3039 // The vcs-sync base now carries the destination's provenance (exposure §4): `origin` and the
3040 // bare `--force` form (default remote) are both `established`.
3041 let vcs_sync = {
3042 let mut c = crate::engine::archetype::archetype("vcs-sync").unwrap().clone();
3043 c.locus.provenance = Provenance::Established;
3044 c
3045 };
3046
3047 let base = resolve(&toks(&["git", "push", "origin", "main"])).expect("git push resolves");
3048 assert_eq!(base.capabilities, vec![vcs_sync.clone()], "base is vcs-sync, established destination");
3049
3050 let forced = resolve(&toks(&["git", "push", "--force"])).expect("resolves");
3051 assert_eq!(forced.capabilities.len(), 2);
3052 assert!(
3053 forced.capabilities.contains(&vcs_sync) && forced.capabilities.contains(destroy),
3054 "--force ADDS remote-destroy-irreversible to the vcs-sync base"
3055 );
3056
3057 // the escalation MATTERS at the level layer: network-admin admits the base but not the
3058 // forced push; the flag pushed it up to yolo.
3059 let network_admin = level("network-admin");
3060 assert!(network_admin.admits(&base), "git push is network-admin");
3061 assert!(!network_admin.admits(&forced), "git push --force escalated past network-admin");
3062 assert!(level("yolo").admits(&forced), "and lands at yolo");
3063
3064 // the -f short form escalates identically
3065 assert_eq!(resolve(&toks(&["git", "push", "-f"])).unwrap().capabilities.len(), 2);
3066 }
3067
3068 /// Destination-trust (exposure §4): `git push`'s send TARGET is classified onto
3069 /// `locus.provenance`, and an `ext::` command-transport worst-cases as RCE. The one resolver
3070 /// that makes the `locus.provenance` facet actually bind to a command.
3071 #[test]
3072 fn git_push_destination_provenance_is_classified() {
3073 use crate::engine::bridge::project;
3074 use crate::verdict::Verdict;
3075
3076 let prov = |cmd: &[&str]| resolve(&toks(cmd)).expect("push resolves").capabilities[0].locus.provenance;
3077
3078 // bare (configured default) and a bare remote NAME → established (a prior deliberate act).
3079 assert_eq!(prov(&["git", "push"]), Provenance::Established, "bare push = default remote");
3080 assert_eq!(prov(&["git", "push", "origin", "main"]), Provenance::Established, "remote name");
3081 // a flag before the target doesn't hide it.
3082 assert_eq!(prov(&["git", "push", "--force", "origin"]), Provenance::Established, "flag then name");
3083 // spelled inline → literal (visible but injectable): URL, scp-path, filesystem path.
3084 assert_eq!(prov(&["git", "push", "https://h/x.git", "main"]), Provenance::Literal, "url");
3085 assert_eq!(prov(&["git", "push", "git@h:x.git"]), Provenance::Literal, "scp-style");
3086 assert_eq!(prov(&["git", "push", "/srv/mirror.git"]), Provenance::Literal, "path");
3087 // a variable / substitution → opaque (unreviewable).
3088 assert_eq!(prov(&["git", "push", "$REMOTE"]), Provenance::Opaque, "variable");
3089
3090 // network-admin admits established + literal, refuses opaque; the ext:: transport is RCE.
3091 let net = level("network-admin");
3092 assert!(net.admits(&resolve(&toks(&["git", "push", "origin"])).unwrap()), "established at network-admin");
3093 assert!(net.admits(&resolve(&toks(&["git", "push", "https://h/x.git"])).unwrap()), "literal URL at network-admin");
3094 assert!(!net.admits(&resolve(&toks(&["git", "push", "$REMOTE"])).unwrap()), "opaque above network-admin");
3095 // ext::<cmd> runs a local command — worst-cased, denied below yolo.
3096 assert_eq!(project(&resolve(&toks(&["git", "push", "ext::sh"])).unwrap()), Verdict::Denied, "ext:: is RCE");
3097 assert!(!net.admits(&resolve(&toks(&["git", "push", "ext::sh"])).unwrap()), "ext:: not at network-admin");
3098
3099 // `--repo=<dest>` OVERRIDES the positional (the fail-open the review found: `--repo=ext::sh`
3100 // slipping past a benign `origin`). Glued and space forms; a bare remote name still allows.
3101 assert_eq!(project(&resolve(&toks(&["git", "push", "--repo=ext::sh", "origin"])).unwrap()), Verdict::Denied, "--repo=ext:: is RCE");
3102 assert!(!net.admits(&resolve(&toks(&["git", "push", "--repo", "$VAR", "origin"])).unwrap()), "--repo $VAR is opaque");
3103 assert_eq!(prov(&["git", "push", "--repo=https://h/x.git", "main"]), Provenance::Literal, "--repo URL is literal");
3104 assert!(net.admits(&resolve(&toks(&["git", "push", "--repo=upstream", "main"])).unwrap()), "--repo=<remote name> is established");
3105 }
3106
3107 /// The `data-export` resolver: a bulk remote export (`supabase db dump`) is a read that
3108 /// auto-approves to stdout, but its OUTPUT-FILE form (`-f path`) adds a SECOND, path-gated local
3109 /// write — a dump to the worktree stays local (SafeWrite) while one to a system path gates on
3110 /// locus (denied), and the glued short `-f/path` spelling can't slip that gate. The unbounded
3111 /// `scale` records the volume without itself gating the read. See `behavioral-taxonomy-exposure.md`.
3112 #[test]
3113 fn data_export_gates_its_output_file() {
3114 use crate::engine::bridge::project;
3115 use crate::verdict::{SafetyLevel, Verdict};
3116
3117 // to stdout: the bulk remote read alone — one capability, auto-approves as a read.
3118 let stdout = resolve(&toks(&["supabase", "db", "dump", "--data-only"])).expect("dump resolves");
3119 assert_eq!(stdout.capabilities.len(), 1, "stdout dump = the remote read only");
3120 assert_eq!(stdout.capabilities[0].scale, Scale::Unbounded, "a dump records its volume");
3121 assert_eq!(project(&stdout), Verdict::Allowed(SafetyLevel::SafeRead), "bulk read auto-approves");
3122
3123 // -f into the worktree: read + a worktree write → still auto-approves (SafeWrite).
3124 for cmd in [vec!["supabase", "db", "dump", "-f", "dump.sql"], vec!["supabase", "db", "dump", "--file=dump.sql", "--data-only"]] {
3125 let p = resolve(&toks(&cmd)).expect("dump resolves");
3126 assert_eq!(p.capabilities.len(), 2, "{cmd:?}: the remote read + a local write");
3127 assert_eq!(project(&p), Verdict::Allowed(SafetyLevel::SafeWrite), "{cmd:?}");
3128 }
3129
3130 // -f onto a system path: the write gates on locus → denied, in every spelling — space,
3131 // glued `=`, AND the glued short `-f/path` that mustn't be a bypass.
3132 for cmd in [
3133 vec!["supabase", "db", "dump", "-f", "/etc/passwd"],
3134 vec!["supabase", "db", "dump", "--file=/etc/passwd"],
3135 vec!["supabase", "db", "dump", "-f/etc/passwd"],
3136 ] {
3137 assert_eq!(project(&resolve(&toks(&cmd)).expect("resolves")), Verdict::Denied, "{cmd:?} writes a system path");
3138 }
3139 }
3140
3141 /// `sudo`/`doas` elevate the wrapped command's AUTHORITY — the resolver that finally gives
3142 /// `local-admin` something to admit. `sudo <safe cmd>` = a root op (above every user-authority
3143 /// band); `sudo rm -rf /` stays the catastrophe corner; `-u`/`-i` and unknown options fail up.
3144 #[test]
3145 fn sudo_elevates_the_wrapped_commands_authority() {
3146 use crate::engine::bridge::project;
3147 use crate::verdict::Verdict;
3148 let (dev, local, net, yolo) = (level("developer"), level("local-admin"), level("network-admin"), level("yolo"));
3149
3150 // sudo cat ./notes — a ROOT read. Authority lifts to root; every band below local-admin pins
3151 // authority=user, so it lands at local-admin (and yolo), NOT developer/network-admin.
3152 let read = resolve(&toks(&["sudo", "cat", "./notes.md"])).expect("sudo cat resolves");
3153 assert_eq!(read.capabilities[0].authority, Authority::Root, "authority lifted to root");
3154 assert!(!dev.admits(&read) && !net.admits(&read), "a root op is above the user-authority bands");
3155 assert!(local.admits(&read) && yolo.admits(&read), "a root read is local-admin");
3156
3157 // benign flag clusters are skipped without losing the inner command (space + glued values too).
3158 assert_eq!(resolve(&toks(&["sudo", "-EH", "cat", "./x"])).unwrap().capabilities[0].authority, Authority::Root);
3159 assert_eq!(resolve(&toks(&["sudo", "-n", "-p", "pw", "cat", "./x"])).unwrap().capabilities[0].authority, Authority::Root);
3160
3161 // bumping authority does NOT rescue the catastrophe corner.
3162 assert_eq!(project(&resolve(&toks(&["sudo", "rm", "-rf", "/"])).unwrap()), Verdict::Denied, "sudo rm -rf / denied everywhere");
3163
3164 // -u (run as another user) → other-user authority → yolo-only (identity confusion tops the ladder).
3165 let other = resolve(&toks(&["sudo", "-u", "bob", "cat", "./x"])).expect("sudo -u resolves");
3166 assert_eq!(other.capabilities[0].authority, Authority::OtherUser, "-u = run as other user");
3167 assert!(!local.admits(&other) && yolo.admits(&other), "other-user is yolo-only");
3168 assert_eq!(
3169 resolve(&toks(&["sudo", "-ubob", "cat", "./x"])).unwrap().capabilities[0].authority,
3170 Authority::OtherUser,
3171 "glued -ubob"
3172 );
3173
3174 // -i / -s / -e launch a root shell or editor → arbitrary code, worst-cased.
3175 assert_eq!(project(&resolve(&toks(&["sudo", "-i"])).unwrap()), Verdict::Denied, "sudo -i is a root shell");
3176 assert!(!local.admits(&resolve(&toks(&["sudo", "-s", "bash"])).unwrap()), "root shell not local-admin");
3177
3178 // an UNRECOGNIZED sudo option fails closed.
3179 assert_eq!(project(&resolve(&toks(&["sudo", "--nonsense", "cat", "./x"])).unwrap()), Verdict::Denied, "unknown option worst-cases");
3180
3181 // an UNRESOLVED inner → None, so the caller's legacy fallback denies (never looser than bare).
3182 assert!(resolve(&toks(&["sudo", "totallyunknowncmd", "x"])).is_none(), "unresolved inner → legacy denies");
3183 // `sudo` with no command → None (legacy decides).
3184 assert!(resolve(&toks(&["sudo", "-v"])).is_none(), "no inner command");
3185
3186 // doas is the same wrapper.
3187 assert_eq!(resolve(&toks(&["doas", "cat", "./x"])).unwrap().capabilities[0].authority, Authority::Root);
3188
3189 // A valued short flag at end-of-input has no next-token value: `i` overshot the slice and
3190 // PANICKED (fail-open hook crash, found by the parse fuzzer). Now clamps → no inner → None.
3191 assert!(resolve(&toks(&["doas", "-r"])).is_none(), "doas -r must not panic");
3192 assert!(resolve(&toks(&["sudo", "-u"])).is_none(), "sudo -u must not panic");
3193 assert_eq!(crate::command_verdict("doas -r"), Verdict::Denied, "doas -r denied, not crashed");
3194
3195 // NEVER LOOSER: at the default band every `sudo …` is denied (root authority is auto-approved
3196 // by NO level below local-admin), exactly like the legacy classifier, which denies sudo whole.
3197 for cmd in ["sudo cat ./notes.md", "sudo rm -rf ./build", "sudo -EH cat ./x", "sudo -u bob ls"] {
3198 assert_eq!(crate::command_verdict(cmd), Verdict::Denied, "`{cmd}` must not auto-approve at the default band");
3199 }
3200 }
3201
3202 /// systemctl — the first REAL command user of the `local-privileged` archetype. Read subs stay
3203 /// SafeRead (any band); service-management subs land at local-admin; and `sudo systemctl restart`
3204 /// (previously fail-closed, since systemctl's inner sub was unmodeled) now resolves to local-admin.
3205 #[test]
3206 fn systemctl_service_management_is_local_admin() {
3207 use crate::verdict::Verdict;
3208 let (dev, local, net, yolo) = (level("developer"), level("local-admin"), level("network-admin"), level("yolo"));
3209
3210 // service management → local-privileged: local-admin and yolo admit; developer/network-admin don't.
3211 for sub in ["restart", "start", "stop", "enable", "disable", "mask", "daemon-reload", "kill"] {
3212 let p = resolve(&toks(&["systemctl", sub, "nginx"])).unwrap_or_else(|| panic!("systemctl {sub} resolves"));
3213 assert!(!dev.admits(&p) && !net.admits(&p), "systemctl {sub} is above developer/network-admin");
3214 assert!(local.admits(&p) && yolo.admits(&p), "systemctl {sub} is local-admin");
3215 }
3216 // reads stay auto-approvable (SafeRead), a power-state sub denies by omission (not modeled).
3217 assert!(crate::command_verdict("systemctl status nginx").is_allowed(), "status reads");
3218 assert_eq!(crate::command_verdict("systemctl reboot"), Verdict::Denied, "reboot omitted → denied");
3219
3220 // the fail-closed case is fixed: `sudo systemctl restart` resolves the inner sub (already root).
3221 let sudo_restart = resolve(&toks(&["sudo", "systemctl", "restart", "nginx"])).expect("resolves");
3222 assert!(local.admits(&sudo_restart), "sudo systemctl restart is local-admin");
3223 assert_eq!(crate::command_verdict("sudo systemctl restart nginx"), Verdict::Denied, "still not auto-approved at default");
3224 }
3225
3226 /// The flag-conditional-archetype resolver (the `when_absent` mechanism, npm exemplar):
3227 /// `npm ci --ignore-scripts` is a PINNED, scripts-off install → `local-install-pinned`
3228 /// (developer). Dropping `--ignore-scripts` escalates it to `supply-chain-build` (yolo — runs
3229 /// fetched code at install). `npm install`/`i` are FLOATING → always `supply-chain-build`. This
3230 /// is the pattern the package-manager fan-out replicates.
3231 #[test]
3232 fn npm_install_is_classified_by_pinning_and_scripts_off() {
3233 let (dev, yolo) = (level("developer"), level("yolo"));
3234
3235 // pinned (ci) + scripts-off → developer.
3236 let safe = resolve(&toks(&["npm", "ci", "--ignore-scripts"])).expect("npm ci --ignore-scripts");
3237 assert!(dev.admits(&safe), "pinned, scripts-off ci is developer");
3238
3239 // pinned but scripts-ON → the --ignore-scripts ABSENCE escalates to supply-chain-build → yolo.
3240 let scripts_on = resolve(&toks(&["npm", "ci"])).expect("npm ci");
3241 assert!(!dev.admits(&scripts_on), "ci without --ignore-scripts runs fetched code → above developer");
3242 assert!(yolo.admits(&scripts_on), "and lands at yolo");
3243
3244 // floating installs → supply-chain-build regardless of flags.
3245 for c in [&["npm", "install"][..], &["npm", "install", "left-pad"], &["npm", "i", "react"], &["npm", "install", "--ignore-scripts"]]
3246 {
3247 let p = resolve(&toks(c)).unwrap_or_else(|| panic!("{c:?} resolves"));
3248 assert!(!dev.admits(&p) && yolo.admits(&p), "{c:?}: floating install → supply-chain (yolo)");
3249 }
3250 }
3251
3252 #[test]
3253 fn rm_flag_and_operand_fail_closed() {
3254 use crate::engine::bridge::project;
3255 use crate::verdict::Verdict;
3256 for cmd in [
3257 vec!["rm", "--no-preserve-root", "-rf", "/"], // enables rm -rf / → must worst-case
3258 vec!["rm", "-Z", "x"], // unknown flag
3259 vec!["rm"], // no operand (usage error)
3260 vec!["./rm", "x"], // basename spoof
3261 ] {
3262 assert_eq!(project(&resolve(&toks(&cmd)).expect("resolves")), Verdict::Denied, "{cmd:?}");
3263 }
3264 }
3265
3266 #[test]
3267 fn rm_scale_and_force_semantics() {
3268 let cap = |cmd: &[&str]| resolve(&toks(cmd)).expect("rm").capabilities[0].clone();
3269 assert_eq!(cap(&["rm", "./x"]).scale, Scale::Single);
3270 assert_eq!(cap(&["rm", "a", "b"]).scale, Scale::Bounded, "multiple operands");
3271 assert_eq!(cap(&["rm", "*.log"]).scale, Scale::Bounded, "a glob");
3272 assert_eq!(cap(&["rm", "-r", "./dir"]).scale, Scale::Unbounded, "recursive");
3273 // -f only suppresses prompts — it does NOT raise reversibility for rm
3274 assert_eq!(cap(&["rm", "./x"]).reversibility, Reversibility::Effortful);
3275 assert_eq!(cap(&["rm", "-f", "./x"]).reversibility, Reversibility::Effortful, "-f is not a raiser");
3276 }
3277
3278 #[test]
3279 fn a_resolvable_name_from_a_non_standard_path_worst_cases() {
3280 // ./cat, /tmp/cat, ~/bin/grep may be impostors → worst-case, not certified safe
3281 for cmd in [vec!["./cat", "x"], vec!["/tmp/cat", "x"], vec!["~/bin/grep", "foo", "f"]] {
3282 let p = resolve(&toks(&cmd)).expect("resolvable name");
3283 assert!(!read_local().admits(&p), "{cmd:?} from a non-standard path must worst-case");
3284 }
3285 // bare names and standard bin paths resolve normally
3286 assert!(read_local().admits(&resolve(&toks(&["cat", "./notes.md"])).expect("cat")));
3287 assert!(read_local().admits(&resolve(&toks(&["/usr/bin/cat", "./notes.md"])).expect("cat")));
3288 // a non-resolvable command from any path → None (the engine doesn't claim it)
3289 assert!(resolve(&toks(&["/tmp/mytool", "x"])).is_none());
3290 }
3291
3292 #[test]
3293 fn unrecognized_flags_worst_case_fail_closed() {
3294 for cmd in [
3295 vec!["cat", "-Z", "./x"],
3296 vec!["cat", "--wat", "./x"],
3297 vec!["grep", "-Q", "foo", "f"], // unknown grep short char (-Z is benign: --null)
3298 vec!["grep", "-R", "foo", "dir"], // -R follows symlinks → escapes locus (M2)
3299 ] {
3300 let p = resolve(&toks(&cmd)).expect("resolver");
3301 assert!(!inert().admits(&p) && !read_local().admits(&p), "{cmd:?} must worst-case");
3302 }
3303 // recognized-benign flags still resolve normally
3304 assert!(read_local().admits(&resolve(&toks(&["cat", "-nA", "./x"])).expect("cat")));
3305 assert!(read_local().admits(&resolve(&toks(&["grep", "-rin", "foo", "src/"])).expect("grep")));
3306 }
3307
3308 use proptest::prelude::*;
3309
3310 /// The content-transfer commands: every one moves/bridges content between a source and
3311 /// a destination operand, so BOTH roles must be locus-gated. Extend this list as
3312 /// `install`/`dd`/`rsync`/`tar` land — a resolver that forgets to gate a role then fails
3313 /// the property below (the `ln` cp-bypass class, §HP re: capability laundering).
3314 const TRANSFER_CMDS: &[&str] = &["cp", "mv", "ln"];
3315
3316 /// A sensitive path that must never be laundered through a transfer command, in any
3317 /// role. Covers each locus rung above the worktree AND the two unpinnable markers.
3318 const HOT_PATHS: &[&str] = &["/etc/shadow", "~/.ssh/id_rsa", "$SECRET", "../out", "~/.aws"];
3319
3320 proptest! {
3321 /// No capability laundering: a hot path in EITHER operand role of a transfer command
3322 /// denies — you can neither pull a secret in (`cp ~/.ssh/id_rsa ./x`) nor push one
3323 /// out (`cp ./x /etc/cron.d/y`). This is the STRICT property that catches an ignored
3324 /// operand; plain locus-monotonicity does not, because ignoring a role leaves the
3325 /// verdict unchanged, and unchanged is "not looser".
3326 #[test]
3327 fn transfer_commands_gate_both_operand_roles(
3328 cmd in prop::sample::select(TRANSFER_CMDS),
3329 hot in prop::sample::select(HOT_PATHS),
3330 ) {
3331 use crate::engine::bridge::project;
3332 use crate::verdict::Verdict;
3333 let hot_source = resolve(&toks(&[cmd, hot, "./safe"])).expect("resolves");
3334 prop_assert_eq!(project(&hot_source), Verdict::Denied, "{} hot SOURCE ({})", cmd, hot);
3335 let hot_dest = resolve(&toks(&[cmd, "./safe", hot])).expect("resolves");
3336 prop_assert_eq!(project(&hot_dest), Verdict::Denied, "{} hot DEST ({})", cmd, hot);
3337 }
3338
3339 /// The sudo/doas flag walk must never panic (a panic in the resolver is a fail-OPEN hook
3340 /// crash) nor depend on evaluation order, for ANY flag salad — crucially a valued short flag
3341 /// at end-of-input (`doas -r`, `sudo -u`), which consumes a "next token" that isn't there and
3342 /// pushed `i` one past the end. That `&tokens[i..]` out-of-range is what the parse fuzzer hit
3343 /// on `doas -r`; uniform command sampling never lands on this resolver often enough to find it.
3344 #[test]
3345 fn sudo_family_flag_walk_never_panics(
3346 head in prop::sample::select(vec!["sudo", "doas"]),
3347 args in prop::collection::vec(
3348 prop_oneof![
3349 Just("-u".to_string()), Just("-r".to_string()), Just("-g".to_string()),
3350 Just("-i".to_string()), Just("-EH".to_string()), Just("-uEH".to_string()),
3351 Just("-uroot".to_string()), Just("--".to_string()), Just("-".to_string()),
3352 Just("root".to_string()), Just("cat".to_string()), Just("./x".to_string()),
3353 "-[a-zA-Z]{1,4}",
3354 ],
3355 0..6,
3356 ),
3357 ) {
3358 let parts: Vec<&str> =
3359 std::iter::once(head).chain(args.iter().map(String::as_str)).collect();
3360 let a = resolve(&toks(&parts)).is_some();
3361 let b = resolve(&toks(&parts)).is_some();
3362 prop_assert_eq!(a, b, "nondeterministic verdict for {:?}", parts);
3363 }
3364 }
3365
3366 /// The exact roster of commands classified by `[command.behavior]`. Pinning it turns a
3367 /// DROPPED or typo'd behavior block into a test failure: `TomlCommand` deliberately lacks
3368 /// `deny_unknown_fields` (it must tolerate `[[trusted]]`), so a mistyped top-level key
3369 /// (`behaviour = …`) is silently dropped and the command reverts to its PERMISSIVE legacy
3370 /// fallback — a fail-open the enumeration guards can't see (they `continue` on `None`). This
3371 /// roster is that missing tripwire, and the guards below derive their non-vacuity floors from
3372 /// it so the floors track reality. Update deliberately when porting a command. `echo` is a
3373 /// none-role printer; `dd`/`tar`/`sed` are hook commands; `grep` is a hook + pattern-then-read;
3374 /// the other 10 are the plain positional coreutils.
3375 const EXPECTED_BEHAVIOR_COMMANDS: &[&str] =
3376 &["cat", "cp", "dd", "echo", "grep", "head", "ln", "mkdir", "mv", "perl", "rm", "rmdir", "sed", "tail", "tar", "touch", "wc"];
3377
3378 /// The behavior roster is exactly `EXPECTED_BEHAVIOR_COMMANDS` — no command silently lost its
3379 /// `[command.behavior]` (fail-open) and none was added without being pinned. Red→green: delete
3380 /// one command's behavior block and this fails.
3381 #[test]
3382 fn behavior_command_roster_is_pinned() {
3383 use std::collections::BTreeSet;
3384 let actual: BTreeSet<&str> = crate::registry::toml_command_names()
3385 .into_iter()
3386 .filter(|n| crate::registry::command_behavior(n).is_some())
3387 .collect();
3388 let expected: BTreeSet<&str> = EXPECTED_BEHAVIOR_COMMANDS.iter().copied().collect();
3389 assert_eq!(
3390 actual, expected,
3391 "behavior-command roster drifted — a [command.behavior] block was added, dropped, or \
3392 typo'd. A dropped block silently reverts the command to its fail-open legacy path."
3393 );
3394 }
3395
3396 /// Hot-path probes for a `[command.behavior]` command, keyed on its declared operand role
3397 /// (the parallel of `probes` for the `Operands` enum). A `@` in a slot is the hot path.
3398 fn behavior_probes(cmd: &str, role: crate::registry::types::PositionalRole, hot: &str) -> Vec<Vec<String>> {
3399 use crate::registry::types::PositionalRole;
3400 let inv =
3401 |slots: &[&str]| -> Vec<String> { std::iter::once(cmd.to_string()).chain(slots.iter().map(|s| s.replace('@', hot))).collect() };
3402 match role {
3403 PositionalRole::None => vec![],
3404 PositionalRole::Read | PositionalRole::Write => vec![inv(&["@"])],
3405 PositionalRole::PatternThenRead => vec![inv(&["PATTERN", "@"])],
3406 PositionalRole::Transfer => vec![inv(&["@", "./safe"]), inv(&["./safe", "@"])],
3407 }
3408 }
3409
3410 /// Hot-path probes for a HOOK command, whose irregular operand syntax `behavior_probes`
3411 /// (positional roles) can't express — dd's `key=value`, tar's dashless mode bundles, sed's
3412 /// script. The `match` is EXHAUSTIVE, so a new `BehaviorHook` variant must declare its probe
3413 /// rows here or the build breaks — restoring the "new entry covered automatically" property the
3414 /// deleted `every_touched_path_operand_is_gated` had via `Operands::Custom`. `@` = the hot slot.
3415 fn hook_probes(hook: crate::registry::types::BehaviorHook, cmd: &str, hot: &str) -> Vec<Vec<String>> {
3416 use crate::registry::types::BehaviorHook;
3417 let inv =
3418 |slots: &[&str]| -> Vec<String> { std::iter::once(cmd.to_string()).chain(slots.iter().map(|s| s.replace('@', hot))).collect() };
3419 match hook {
3420 // grep is pattern-then-read → already probed by `behavior_probes`; no extra rows.
3421 BehaviorHook::Grep => vec![],
3422 BehaviorHook::Dd => vec![inv(&["if=@", "of=./safe"]), inv(&["if=./safe", "of=@"])],
3423 BehaviorHook::Tar => vec![inv(&["cf", "./s.tar", "@"]), inv(&["cf", "@", "./s"]), inv(&["tf", "@"])],
3424 BehaviorHook::Sed => vec![inv(&["s/x/y/", "@"]), inv(&["-i", "s/x/y/", "@"])],
3425 BehaviorHook::Perl => {
3426 vec![inv(&["-pe", "s/x/y/", "@"]), inv(&["-pi", "-e", "s/x/y/", "@"])]
3427 }
3428 }
3429 }
3430
3431 /// Every RECURSIVE transfer refuses a source above the workspace.
3432 ///
3433 /// The shield tests a name; a recursive source is a root standing for files nobody named, so
3434 /// it cannot be cleared. `cp ~/.ssh/id_rsa ./x` was refused all along and `cp -r ~ ./x` was
3435 /// not — same theft, one flag apart — because the claim that makes a read unclearable was
3436 /// written twice and only one copy learned about sweeps.
3437 ///
3438 /// Enumerated from the registry rather than listed, so a transfer command that declares
3439 /// `recursive_flags` later is covered the day it lands and does not need anyone to remember
3440 /// this test exists.
3441 #[test]
3442 fn every_recursive_transfer_refuses_a_source_above_the_workspace() {
3443 use crate::engine::bridge::project;
3444 use crate::verdict::Verdict;
3445
3446 let mut covered = 0usize;
3447 for name in crate::registry::toml_command_names() {
3448 let Some(b) = crate::registry::command_behavior(name) else { continue };
3449 let Some(t) = b.transfer.as_ref() else { continue };
3450 for flag in &t.recursive_flags {
3451 covered += 1;
3452 let hot = vec![name.to_string(), flag.clone(), "~".to_string(), "./dest".to_string()];
3453 let refs: Vec<&str> = hot.iter().map(String::as_str).collect();
3454 if let Some(p) = resolve(&toks(&refs)) {
3455 assert_eq!(project(&p), Verdict::Denied, "{hot:?}: a recursive read of home is unclearable");
3456 }
3457 // Non-vacuity: the same command and flag over the WORKTREE must still work, or
3458 // this would pass on a build that simply refused every recursive copy.
3459 let ok = vec![name.to_string(), flag.clone(), "./src".to_string(), "./dest".to_string()];
3460 let refs: Vec<&str> = ok.iter().map(String::as_str).collect();
3461 if let Some(p) = resolve(&toks(&refs)) {
3462 assert_ne!(project(&p), Verdict::Denied, "{ok:?}: a worktree recursive copy must still allow");
3463 }
3464 }
3465 }
3466 assert!(covered >= 3, "only {covered} recursive transfer flags swept — the registry lookup is wrong");
3467 }
3468
3469 /// Fail-closed, enumerated over the REGISTRY: every `[command.behavior]` command denies an
3470 /// operand on a hot path (a secret, home, system, or unpinnable locus), AND a write-role
3471 /// command denies a write into the worktree-trusted rung (`.git/config`). Restores and
3472 /// generalizes `every_touched_path_operand_is_gated` for the declarative path — a command
3473 /// ported off Rust is covered automatically. Red→green: make `resolve_behavior` skip
3474 /// `classify_locus` and this fails on the first probe.
3475 #[test]
3476 fn every_behavior_command_gates_hot_operands() {
3477 use crate::engine::bridge::project;
3478 use crate::registry::types::PositionalRole;
3479 use crate::verdict::Verdict;
3480
3481 let deny = |cmd: &[String], why: &str| {
3482 let refs: Vec<&str> = cmd.iter().map(String::as_str).collect();
3483 let profile = resolve(&toks(&refs)).expect("behavior command resolves");
3484 assert_eq!(project(&profile), Verdict::Denied, "{cmd:?}: {why}");
3485 };
3486
3487 let mut path_bearing = 0usize;
3488 let mut hook_bearing = 0usize;
3489 for name in crate::registry::toml_command_names() {
3490 let Some(b) = crate::registry::command_behavior(name) else { continue };
3491 if !matches!(b.positionals, PositionalRole::None) {
3492 path_bearing += 1;
3493 }
3494 if b.hook.is_some() {
3495 hook_bearing += 1;
3496 }
3497 for hot in HOT_PATHS {
3498 for cmd in behavior_probes(name, b.positionals, hot) {
3499 deny(&cmd, "touched hot path not gated");
3500 }
3501 // Hook commands (dd/tar/sed) have irregular operand syntax, so they are swept by
3502 // their own probe table — restoring the enumerated coverage the deleted RESOLVERS
3503 // sweep gave them.
3504 if let Some(hook) = b.hook {
3505 for cmd in hook_probes(hook, name, hot) {
3506 deny(&cmd, "hook: touched hot path not gated");
3507 }
3508 }
3509 }
3510 // Worktree-trusted is a WRITE boundary only: reading `.git/config` (cat/grep) is
3511 // legitimately allowed, but a write/destroy/relocate into it must deny. Probe the
3512 // write face — the destination slot for a transfer, the operand for a plain write.
3513 let inv =
3514 |slots: &[&str]| -> Vec<String> { std::iter::once(name.to_string()).chain(slots.iter().map(|s| s.to_string())).collect() };
3515 match b.positionals {
3516 PositionalRole::Write => deny(&inv(&[".git/config"]), "write into worktree-trusted not gated"),
3517 PositionalRole::Transfer => deny(&inv(&["./safe", ".git/config"]), "transfer dest into worktree-trusted not gated"),
3518 _ => {}
3519 }
3520 }
3521 // Non-vacuity: every path-bearing AND every hook command on the roster was reached and
3522 // probed. Derived from the roster (not a magic number) — none-role printers (echo) don't
3523 // positionally gate; hook commands (dd/tar/sed) gate via `hook_probes`.
3524 let count = |pred: fn(&crate::registry::types::BehaviorSpec) -> bool| {
3525 EXPECTED_BEHAVIOR_COMMANDS
3526 .iter()
3527 .filter(|n| crate::registry::command_behavior(n).is_some_and(pred))
3528 .count()
3529 };
3530 assert_eq!(
3531 path_bearing,
3532 count(|b| !matches!(b.positionals, PositionalRole::None)),
3533 "path-bearing behavior commands: saw {path_bearing}"
3534 );
3535 assert_eq!(hook_bearing, count(|b| b.hook.is_some()), "hook behavior commands: saw {hook_bearing}");
3536 }
3537
3538 /// Fail-closed on unknown flags, enumerated over the REGISTRY: every DECLARATIVE flag-walking
3539 /// behavior command (a Read/Write/Transfer role, hookless) worst-cases an unrecognized flag —
3540 /// the `walk_positionals` → `worst` path. Exempt: `grep` (its hook treats an unknown `--token`
3541 /// as a search pattern — keyed on `BehaviorHook::Grep` SPECIFICALLY, not `hook.is_some()`, so a
3542 /// future hook variant is not auto-exempted), and none-role commands (echo prints its args;
3543 /// dd/tar/sed parse their own irregular syntax — all covered by their own resolver tests, and
3544 /// none-role commands take no positional path operands, so an unknown flag can't unlock danger).
3545 #[test]
3546 fn every_hookless_behavior_command_worst_cases_unknown_flags() {
3547 use crate::engine::bridge::project;
3548 use crate::registry::types::{BehaviorHook, PositionalRole};
3549 use crate::verdict::Verdict;
3550
3551 let exempt = |b: &crate::registry::types::BehaviorSpec| {
3552 matches!(b.hook, Some(BehaviorHook::Grep)) || matches!(b.positionals, PositionalRole::None)
3553 };
3554 let mut checked = 0usize;
3555 for name in crate::registry::toml_command_names() {
3556 let Some(b) = crate::registry::command_behavior(name) else { continue };
3557 if exempt(b) {
3558 continue;
3559 }
3560 let profile = resolve(&toks(&[name, "--xyzzy-unknown-42", "./safe"])).expect("resolves");
3561 assert_eq!(project(&profile), Verdict::Denied, "{name}: unknown flag not worst-cased");
3562 checked += 1;
3563 }
3564 let expected = EXPECTED_BEHAVIOR_COMMANDS
3565 .iter()
3566 .filter(|n| crate::registry::command_behavior(n).is_some_and(|b| !exempt(b)))
3567 .count();
3568 assert_eq!(checked, expected, "declarative flag-walking behavior commands: saw {checked}");
3569 }
3570
3571 /// Fail-closed authoring guard: `path_flag_caps` (which gates a valued flag's path VALUE, e.g.
3572 /// `touch -r REF`) runs ONLY on the declarative Read/Write/Transfer path — the None arm (echo)
3573 /// and the hook arm (grep/dd/tar/sed) both return before it. So a `[command.behavior.flags]`
3574 /// path-role declared on a none-role or hook command would be SILENTLY UNGATED — a fail-open.
3575 /// Assert no command does that. Red→green: add `kind = "read"` to a hook command's flags.
3576 #[test]
3577 fn no_none_or_hook_command_declares_ungated_path_flags() {
3578 use crate::registry::types::PositionalRole;
3579 for name in crate::registry::toml_command_names() {
3580 let Some(b) = crate::registry::command_behavior(name) else { continue };
3581 if b.path_flags.is_empty() {
3582 continue;
3583 }
3584 assert!(
3585 b.hook.is_none() && !matches!(b.positionals, PositionalRole::None),
3586 "{name}: behavior path-flags are gated only on the Read/Write/Transfer path; on a \
3587 none-role or hook command they would be silently ungated (fail-open)"
3588 );
3589 }
3590 }
3591}