s3rm-rs 1.3.2

Fast Amazon S3 object deletion tool.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
//! Filter stages for the deletion pipeline.
//!
//! Reused from s3sync's pipeline/filter infrastructure with adaptations:
//! - Simplified for deletion-only operations (no source/target key map comparison)
//! - Uses `S3Object` instead of `S3syncObject`
//! - Uses `DeletionStatistics` instead of `SyncStatistics`
//!
//! Each filter reads objects from its input channel, applies filtering logic,
//! and forwards passing objects to its output channel. Filters are chained
//! in sequence to form the filter pipeline, with logical AND semantics.
//!
//! **Note**: Content-type, metadata, and tag regex filters are NOT separate stages.
//! They are implemented within ObjectDeleter (Task 8) because they require
//! fetching object metadata/tags via HeadObject/GetObjectTagging API calls.

use anyhow::Result;
use async_trait::async_trait;
use aws_sdk_s3::primitives::DateTimeFormat;
use tracing::debug;

use crate::config::FilterConfig;
use crate::stage::{SendResult, Stage};
use crate::types::event_callback::{EventData, EventType};
use crate::types::{DeletionStatistics, S3Object};

pub mod delete_marker_only;
pub mod exclude_regex;
pub mod include_regex;
pub mod keep_latest_only;
pub mod larger_size;
pub mod mtime_after;
pub mod mtime_before;
pub mod smaller_size;
pub mod user_defined;

pub use delete_marker_only::DeleteMarkerOnlyFilter;
pub use exclude_regex::ExcludeRegexFilter;
pub use include_regex::IncludeRegexFilter;
pub use keep_latest_only::KeepLatestOnlyFilter;
pub use larger_size::LargerSizeFilter;
pub use mtime_after::MtimeAfterFilter;
pub use mtime_before::MtimeBeforeFilter;
pub use smaller_size::SmallerSizeFilter;

/// Trait implemented by all filter stages in the deletion pipeline.
///
/// Reused from s3sync's ObjectFilter trait.
#[async_trait]
pub trait ObjectFilter {
    async fn filter(&self) -> Result<()>;
}

/// Base implementation for receive-and-filter loop shared by all simple filters.
///
/// Adapted from s3sync's ObjectFilterBase. Simplified by removing:
/// - `ObjectKeyMap` parameter (not needed for deletion, only for sync comparison)
/// - Test simulation code
pub struct ObjectFilterBase<'a> {
    name: &'a str,
    base: Stage,
}

impl ObjectFilterBase<'_> {
    /// Run the receive-and-filter loop with the given filter function.
    ///
    /// Objects where `filter_fn` returns `true` are forwarded to the next stage.
    /// Objects where it returns `false` are skipped (a `DeleteSkip` stat is sent).
    pub async fn filter<F>(&self, filter_fn: F) -> Result<()>
    where
        F: Fn(&S3Object, &FilterConfig) -> bool,
    {
        self.receive_and_filter(filter_fn).await
    }

    async fn receive_and_filter<F>(&self, filter_fn: F) -> Result<()>
    where
        F: Fn(&S3Object, &FilterConfig) -> bool,
    {
        // Yield to prevent task starvation under high load.
        // (from s3sync pipeline/filter/mod.rs)
        loop {
            tokio::task::yield_now().await;
            if self.base.cancellation_token.is_cancelled() {
                debug!(name = self.name, "filter has been cancelled.");
                return Ok(());
            }

            tokio::task::yield_now().await;
            match self
                .base
                .receiver
                .as_ref()
                .expect("filter stage receiver not initialized")
                .recv()
                .await
            {
                Ok(object) => {
                    tokio::task::yield_now().await;
                    if !filter_fn(&object, &self.base.config.filter_config) {
                        tokio::task::yield_now().await;

                        self.base
                            .send_stats(DeletionStatistics::DeleteSkip {
                                key: object.key().to_string(),
                            })
                            .await;

                        if self.base.config.event_manager.is_callback_registered() {
                            let mut event_data = EventData::new(EventType::DELETE_FILTERED);
                            event_data.key = Some(object.key().to_string());
                            event_data.version_id = object.version_id().map(|v| v.to_string());
                            event_data.size = Some(object.size() as u64);
                            event_data.last_modified = Some(
                                object
                                    .last_modified()
                                    .fmt(DateTimeFormat::DateTime)
                                    .unwrap_or_default(),
                            );
                            event_data.message = Some(format!("Object filtered by {}", self.name));
                            self.base
                                .config
                                .event_manager
                                .trigger_event(event_data)
                                .await;
                        }

                        continue;
                    }

                    tokio::task::yield_now().await;
                    if self.base.send(object).await? == SendResult::Closed {
                        return Ok(());
                    }
                }
                Err(_) => {
                    debug!(name = self.name, "filter has been completed.");
                    return Ok(());
                }
            }
        }
    }
}

#[cfg(test)]
pub(crate) mod tests {
    use super::*;
    use crate::config::Config;
    use crate::storage::{Storage, StorageTrait};
    use crate::test_utils::init_dummy_tracing_subscriber;
    use crate::types::token;
    use async_channel::Receiver;
    use aws_sdk_s3::types::Object;
    use std::sync::Arc;
    use std::sync::atomic::AtomicBool;

    #[tokio::test]
    async fn filter_true_passes_object() {
        init_dummy_tracing_subscriber();

        let (sender, receiver) = async_channel::bounded::<S3Object>(1000);
        let cancellation_token = token::create_pipeline_cancellation_token();
        let (base, next_stage_receiver) =
            create_base_helper(receiver, cancellation_token.clone()).await;
        let filter_base = ObjectFilterBase {
            base,
            name: "unittest",
        };
        let object = S3Object::NotVersioning(Object::builder().key("test").build());

        sender.send(object).await.unwrap();
        sender.close();

        filter_base.filter(|_, _| true).await.unwrap();

        let received_object = next_stage_receiver.recv().await.unwrap();
        assert_eq!(received_object.key(), "test");
    }

    #[tokio::test]
    async fn filter_false_skips_object() {
        init_dummy_tracing_subscriber();

        let (sender, receiver) = async_channel::bounded::<S3Object>(1000);
        let cancellation_token = token::create_pipeline_cancellation_token();
        let (base, next_stage_receiver) =
            create_base_helper(receiver, cancellation_token.clone()).await;
        let filter_base = ObjectFilterBase {
            base,
            name: "unittest",
        };
        let object = S3Object::NotVersioning(Object::builder().key("test").build());

        sender.send(object).await.unwrap();
        sender.close();

        filter_base.filter(|_, _| false).await.unwrap();

        assert!(next_stage_receiver.try_recv().is_err());
    }

    #[tokio::test]
    async fn filter_cancelled() {
        init_dummy_tracing_subscriber();

        let (_, receiver) = async_channel::bounded::<S3Object>(1000);
        let cancellation_token = token::create_pipeline_cancellation_token();
        let (base, next_stage_receiver) =
            create_base_helper(receiver, cancellation_token.clone()).await;
        let filter_base = ObjectFilterBase {
            base,
            name: "unittest",
        };

        cancellation_token.cancel();
        filter_base.filter(|_, _| false).await.unwrap();

        assert!(next_stage_receiver.try_recv().is_err());
    }

    #[tokio::test]
    async fn filter_receiver_closed() {
        init_dummy_tracing_subscriber();

        let (sender, receiver) = async_channel::bounded::<S3Object>(1000);
        let cancellation_token = token::create_pipeline_cancellation_token();
        let (base, next_stage_receiver) =
            create_base_helper(receiver, cancellation_token.clone()).await;
        let filter_base = ObjectFilterBase {
            base,
            name: "unittest",
        };
        let object = S3Object::NotVersioning(Object::builder().key("test").build());

        next_stage_receiver.close();
        sender.send(object).await.unwrap();

        filter_base.filter(|_, _| true).await.unwrap();
    }

    #[tokio::test]
    async fn filter_false_emits_delete_filtered_event() {
        use crate::callback::event_manager::EventManager;
        use crate::types::event_callback::{EventCallback, EventData, EventType};
        use async_trait::async_trait;
        use std::sync::Arc;
        use tokio::sync::Mutex;

        /// Collects events for test assertions.
        struct CollectingCallback {
            events: Arc<Mutex<Vec<EventData>>>,
        }

        #[async_trait]
        impl EventCallback for CollectingCallback {
            async fn on_event(&mut self, event_data: EventData) {
                self.events.lock().await.push(event_data);
            }
        }

        init_dummy_tracing_subscriber();

        let (sender, receiver) = async_channel::bounded::<S3Object>(1000);
        let cancellation_token = token::create_pipeline_cancellation_token();
        let (mut base, _next_stage_receiver) =
            create_base_helper(receiver, cancellation_token.clone()).await;

        // Register a collecting event callback
        let events = Arc::new(Mutex::new(Vec::new()));
        let callback = CollectingCallback {
            events: events.clone(),
        };
        let mut event_manager = EventManager::new();
        event_manager.register_callback(EventType::ALL_EVENTS, callback, false);
        base.config.event_manager = event_manager;

        let filter_base = ObjectFilterBase {
            base,
            name: "test_filter",
        };
        let object = S3Object::NotVersioning(
            Object::builder()
                .key("filtered-key")
                .size(100)
                .last_modified(aws_sdk_s3::primitives::DateTime::from_secs(1_700_000_000))
                .build(),
        );

        sender.send(object).await.unwrap();
        sender.close();

        filter_base.filter(|_, _| false).await.unwrap();

        let collected = events.lock().await;
        assert_eq!(collected.len(), 1);
        assert_eq!(collected[0].event_type, EventType::DELETE_FILTERED);
        assert_eq!(collected[0].key.as_deref(), Some("filtered-key"));
        assert!(collected[0].last_modified.is_some());
        assert!(
            collected[0]
                .message
                .as_ref()
                .unwrap()
                .contains("test_filter")
        );
    }

    // --- Test helpers ---

    pub(crate) async fn create_base_helper(
        receiver: Receiver<S3Object>,
        cancellation_token: crate::types::token::PipelineCancellationToken,
    ) -> (Stage, Receiver<S3Object>) {
        let (stats_sender, _stats_receiver) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));

        let storage = create_mock_storage(stats_sender, has_warning.clone());

        let (sender, next_stage_receiver) = async_channel::bounded::<S3Object>(1000);

        (
            Stage {
                config: create_test_config(),
                target: storage,
                receiver: Some(receiver),
                sender: Some(sender),
                cancellation_token,
                has_warning,
            },
            next_stage_receiver,
        )
    }

    pub(crate) fn create_test_config() -> Config {
        use crate::types::StoragePath;

        let mut config = crate::test_utils::make_test_config();
        config.target = StoragePath::S3 {
            bucket: "test-bucket".to_string(),
            prefix: String::new(),
        };
        config.worker_size = 1;
        config
    }

    pub(crate) fn create_mock_storage(
        stats_sender: async_channel::Sender<DeletionStatistics>,
        has_warning: Arc<AtomicBool>,
    ) -> Storage {
        Box::new(MockStorage {
            stats_sender,
            has_warning,
        })
    }

    /// Minimal mock storage for filter tests.
    ///
    /// Only implements get_stats_sender() and send_stats() since filters
    /// don't call S3 APIs directly.
    #[derive(Clone)]
    pub(crate) struct MockStorage {
        stats_sender: async_channel::Sender<DeletionStatistics>,
        has_warning: Arc<AtomicBool>,
    }

    #[async_trait]
    impl crate::storage::StorageTrait for MockStorage {
        fn is_express_onezone_storage(&self) -> bool {
            false
        }

        async fn list_objects(
            &self,
            _sender: &async_channel::Sender<S3Object>,
            _max_keys: i32,
        ) -> anyhow::Result<()> {
            Ok(())
        }

        async fn list_object_versions(
            &self,
            _sender: &async_channel::Sender<S3Object>,
            _max_keys: i32,
        ) -> anyhow::Result<()> {
            Ok(())
        }

        async fn head_object(
            &self,
            _relative_key: &str,
            _version_id: Option<String>,
        ) -> anyhow::Result<aws_sdk_s3::operation::head_object::HeadObjectOutput> {
            unimplemented!()
        }

        async fn get_object_tagging(
            &self,
            _relative_key: &str,
            _version_id: Option<String>,
        ) -> anyhow::Result<aws_sdk_s3::operation::get_object_tagging::GetObjectTaggingOutput>
        {
            unimplemented!()
        }

        async fn delete_object(
            &self,
            _relative_key: &str,
            _version_id: Option<String>,
            _if_match: Option<String>,
        ) -> anyhow::Result<aws_sdk_s3::operation::delete_object::DeleteObjectOutput> {
            unimplemented!()
        }

        async fn delete_objects(
            &self,
            _objects: Vec<aws_sdk_s3::types::ObjectIdentifier>,
        ) -> anyhow::Result<aws_sdk_s3::operation::delete_objects::DeleteObjectsOutput> {
            unimplemented!()
        }

        async fn is_versioning_enabled(&self) -> anyhow::Result<bool> {
            Ok(false)
        }

        fn get_client(&self) -> Option<Arc<aws_sdk_s3::Client>> {
            None
        }

        fn get_stats_sender(&self) -> async_channel::Sender<DeletionStatistics> {
            self.stats_sender.clone()
        }

        async fn send_stats(&self, stats: DeletionStatistics) {
            let _ = self.stats_sender.send(stats).await;
        }

        fn set_warning(&self) {
            self.has_warning
                .store(true, std::sync::atomic::Ordering::SeqCst);
        }
    }

    // --- MockStorage method tests ---

    #[test]
    fn mock_storage_is_express_onezone_returns_false() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        assert!(!mock.is_express_onezone_storage());
    }

    #[tokio::test]
    async fn mock_storage_list_objects_returns_ok() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        let (sender, _receiver) = async_channel::bounded::<S3Object>(10);
        assert!(mock.list_objects(&sender, 1000).await.is_ok());
    }

    #[tokio::test]
    async fn mock_storage_list_object_versions_returns_ok() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        let (sender, _receiver) = async_channel::bounded::<S3Object>(10);
        assert!(mock.list_object_versions(&sender, 1000).await.is_ok());
    }

    #[tokio::test]
    async fn mock_storage_is_versioning_enabled_returns_false() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        assert!(!mock.is_versioning_enabled().await.unwrap());
    }

    #[test]
    fn mock_storage_get_client_returns_none() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        assert!(mock.get_client().is_none());
    }

    #[tokio::test]
    async fn mock_storage_get_stats_sender_works() {
        let (stats_sender, stats_receiver) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        let sender = mock.get_stats_sender();
        sender
            .send(DeletionStatistics::DeleteBytes(77))
            .await
            .unwrap();
        let received = stats_receiver.recv().await.unwrap();
        assert!(matches!(received, DeletionStatistics::DeleteBytes(77)));
    }

    #[tokio::test]
    async fn mock_storage_send_stats_delivers_stat() {
        let (stats_sender, stats_receiver) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        mock.send_stats(DeletionStatistics::DeleteComplete {
            key: "k".to_string(),
        })
        .await;
        let received = stats_receiver.recv().await.unwrap();
        assert!(matches!(
            received,
            DeletionStatistics::DeleteComplete { .. }
        ));
    }

    #[tokio::test]
    #[should_panic(expected = "not implemented")]
    async fn mock_storage_head_object_panics_unimplemented() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        let _ = mock.head_object("key", None).await;
    }

    #[tokio::test]
    #[should_panic(expected = "not implemented")]
    async fn mock_storage_get_object_tagging_panics_unimplemented() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        let _ = mock.get_object_tagging("key", None).await;
    }

    #[tokio::test]
    #[should_panic(expected = "not implemented")]
    async fn mock_storage_delete_object_panics_unimplemented() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        let _ = mock.delete_object("key", None, None).await;
    }

    #[tokio::test]
    #[should_panic(expected = "not implemented")]
    async fn mock_storage_delete_objects_panics_unimplemented() {
        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning,
        };
        let _ = mock.delete_objects(vec![]).await;
    }

    #[test]
    fn mock_storage_set_warning_sets_has_warning_flag() {
        use std::sync::atomic::Ordering;

        let (stats_sender, _) = async_channel::unbounded();
        let has_warning = Arc::new(AtomicBool::new(false));
        let mock = MockStorage {
            stats_sender,
            has_warning: has_warning.clone(),
        };
        assert!(!has_warning.load(Ordering::SeqCst));
        mock.set_warning();
        assert!(has_warning.load(Ordering::SeqCst));
    }
}