s2-storage 0.1.2

Storage-layer internals shared by S2 server implementations
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
#[cfg(test)]
use bytes::BytesMut;
use bytes::{Buf, BufMut, Bytes};
use s2_common::{
    deep_size::DeepSize,
    encryption::EncryptionAlgorithm,
    record::{CommandRecord, Metered, MeteredSize, Record, SeqNum, Sequenced},
};

use super::{
    codec::{StoredRecordDecodeError, WireEncode, decode_command_record, decode_envelope_record},
    encryption::EncryptedRecord,
};

#[derive(Clone, Copy, Debug, PartialEq)]
#[repr(u8)]
enum RecordType {
    Command = 1,
    Envelope = 2,
    EncryptedEnvelope = 3,
}

impl TryFrom<u8> for RecordType {
    type Error = &'static str;

    fn try_from(value: u8) -> Result<Self, Self::Error> {
        match value {
            1 => Ok(Self::Command),
            2 => Ok(Self::Envelope),
            3 => Ok(Self::EncryptedEnvelope),
            _ => Err("invalid record type ordinal"),
        }
    }
}

#[derive(Copy, Clone, Debug, PartialEq)]
struct MagicByte {
    record_type: RecordType,
    metered_size_varlen: u8,
}

/// Read bytes to u32 in big-endian order.
fn read_vint_u32_be(bytes: &[u8]) -> u32 {
    if bytes.len() > size_of::<u32>() || bytes.is_empty() {
        panic!("invalid variable int bytes = {} len", bytes.len())
    }
    let mut acc: u32 = 0;
    for &byte in bytes {
        acc = (acc << 8) | byte as u32;
    }
    acc
}

pub fn try_metered_size(record_bytes: &[u8]) -> Result<u32, &'static str> {
    let magic_byte_u8 = *record_bytes.first().ok_or("byte range is empty")?;
    let magic_byte = MagicByte::try_from(magic_byte_u8)?;
    Ok(read_vint_u32_be(
        record_bytes
            .get(1..1 + magic_byte.metered_size_varlen as usize)
            .ok_or("byte range doesn't include bytes for metered size")?,
    ))
}

impl TryFrom<u8> for MagicByte {
    type Error = &'static str;

    fn try_from(value: u8) -> Result<Self, Self::Error> {
        let record_type = RecordType::try_from(value & 0b111)?;
        Ok(Self {
            record_type,
            metered_size_varlen: match (value >> 3) & 0b11 {
                0 => 1u8,
                1 => 2u8,
                2 => 3u8,
                _ => Err("invalid metered_size_varlen")?,
            },
        })
    }
}

impl From<MagicByte> for u8 {
    fn from(value: MagicByte) -> Self {
        ((value.metered_size_varlen - 1) << 3) | value.record_type as u8
    }
}

#[derive(Debug, PartialEq, Eq, Clone)]
pub enum StoredRecord {
    Plaintext(Record),
    /// Encrypted envelope record bytes plus the logical plaintext metered size.
    ///
    /// The stored `metered_size` must match the decrypted envelope record's
    /// metered size. Decoding preserves the encoded prefix, and decryption
    /// validates it before returning a logical record.
    Encrypted {
        metered_size: usize,
        record: EncryptedRecord,
    },
}

impl StoredRecord {
    pub(crate) fn encrypted(record: EncryptedRecord, metered_size: usize) -> Self {
        Self::Encrypted {
            metered_size,
            record,
        }
    }

    fn record_type(&self) -> RecordType {
        match self {
            Self::Plaintext(Record::Command(_)) => RecordType::Command,
            Self::Plaintext(Record::Envelope(_)) => RecordType::Envelope,
            Self::Encrypted { .. } => RecordType::EncryptedEnvelope,
        }
    }

    fn encoded_body_size(&self) -> usize {
        match self {
            Self::Plaintext(Record::Command(record)) => record.encoded_size(),
            Self::Plaintext(Record::Envelope(record)) => record.encoded_size(),
            Self::Encrypted { record, .. } => record.encoded_size(),
        }
    }

    fn encode_body_into(&self, buf: &mut impl BufMut) {
        match self {
            Self::Plaintext(Record::Command(record)) => record.encode_into(buf),
            Self::Plaintext(Record::Envelope(record)) => record.encode_into(buf),
            Self::Encrypted { record, .. } => record.encode_into(buf),
        }
    }

    pub fn encryption_algorithm(&self) -> Option<EncryptionAlgorithm> {
        match self {
            Self::Plaintext(_) => None,
            Self::Encrypted { record, .. } => Some(record.algorithm()),
        }
    }

    pub fn max_assignable_seq_num(&self) -> SeqNum {
        match self {
            Self::Plaintext(_) => SeqNum::MAX,
            Self::Encrypted { record, .. } => record.max_assignable_seq_num(),
        }
    }
}

impl DeepSize for StoredRecord {
    fn deep_size(&self) -> usize {
        match self {
            Self::Plaintext(record) => record.deep_size(),
            Self::Encrypted {
                metered_size,
                record,
            } => metered_size.deep_size() + record.deep_size(),
        }
    }
}

impl MeteredSize for StoredRecord {
    fn metered_size(&self) -> usize {
        match self {
            Self::Plaintext(record) => record.metered_size(),
            Self::Encrypted { metered_size, .. } => *metered_size,
        }
    }
}

impl From<Record> for StoredRecord {
    fn from(value: Record) -> Self {
        Self::Plaintext(value)
    }
}

pub fn decode_if_command_record(
    record: &[u8],
) -> Result<Option<CommandRecord>, StoredRecordDecodeError> {
    if record.is_empty() {
        return Err(StoredRecordDecodeError::Truncated("MagicByte"));
    }
    let magic_byte = MagicByte::try_from(record[0])
        .map_err(|msg| StoredRecordDecodeError::InvalidValue("MagicByte", msg))?;
    match magic_byte.record_type {
        RecordType::Command => {
            let offset = 1 + magic_byte.metered_size_varlen as usize;
            if record.len() < offset {
                return Err(StoredRecordDecodeError::Truncated("MeteredSize"));
            }
            Ok(Some(decode_command_record(&record[offset..])?))
        }
        RecordType::Envelope | RecordType::EncryptedEnvelope => Ok(None),
    }
}

pub fn encode_stored_record(record: Metered<&StoredRecord>) -> Bytes {
    record.to_bytes()
}

pub fn stored_record_encoded_size(record: Metered<&StoredRecord>) -> usize {
    record.encoded_size()
}

pub fn encode_stored_record_into(record: Metered<&StoredRecord>, buf: &mut impl BufMut) {
    record.encode_into(buf);
}

impl WireEncode for Metered<&StoredRecord> {
    fn encoded_size(&self) -> usize {
        1 + magic_byte(self).metered_size_varlen as usize + self.encoded_body_size()
    }

    fn encode_into(&self, buf: &mut impl BufMut) {
        let magic_byte = magic_byte(self);
        buf.put_u8(magic_byte.into());
        buf.put_uint(
            self.metered_size() as u64,
            magic_byte.metered_size_varlen as usize,
        );
        self.encode_body_into(buf);
    }
}

fn magic_byte(record: &Metered<&StoredRecord>) -> MagicByte {
    let metered_size = record.metered_size();
    let metered_size_varlen = 8 - (metered_size.leading_zeros() / 8) as u8;
    if metered_size_varlen > 3 {
        panic!("illegal metered size varlen {metered_size} for record")
    }
    MagicByte {
        record_type: record.record_type(),
        metered_size_varlen,
    }
}

pub type StoredSequencedBytes = Sequenced<Bytes>;
pub type StoredSequencedRecord = Sequenced<StoredRecord>;

pub fn decode_stored_record(
    mut buf: Bytes,
) -> Result<Metered<StoredRecord>, StoredRecordDecodeError> {
    if buf.is_empty() {
        return Err(StoredRecordDecodeError::Truncated("MagicByte"));
    }
    let magic_byte = MagicByte::try_from(buf.get_u8())
        .map_err(|msg| StoredRecordDecodeError::InvalidValue("MagicByte", msg))?;

    let metered_size =
        buf.try_get_uint(magic_byte.metered_size_varlen as usize)
            .map_err(|_| StoredRecordDecodeError::Truncated("MeteredSize"))? as usize;

    let record = match magic_byte.record_type {
        RecordType::Command => {
            StoredRecord::Plaintext(Record::Command(decode_command_record(buf.as_ref())?))
        }
        RecordType::Envelope => {
            StoredRecord::Plaintext(Record::Envelope(decode_envelope_record(buf)?))
        }
        RecordType::EncryptedEnvelope => {
            StoredRecord::encrypted(EncryptedRecord::try_from(buf)?, metered_size)
        }
    };
    Ok(Metered::with_size(metered_size, record))
}

pub fn decode_record(buf: Bytes) -> Result<Metered<Record>, StoredRecordDecodeError> {
    let stored = decode_stored_record(buf)?;
    let metered_size = stored.metered_size();
    match stored.into_inner() {
        StoredRecord::Plaintext(record) => Ok(record),
        StoredRecord::Encrypted { .. } => Err(StoredRecordDecodeError::InvalidValue(
            "RecordType",
            "encrypted envelope requires decryption",
        )),
    }
    .map(|record| Metered::with_size(metered_size, record))
}

#[cfg(test)]
mod test {
    use proptest::prelude::*;
    use rstest::rstest;
    use s2_common::record::{
        EnvelopeRecord, Header, MAX_FENCING_TOKEN_LENGTH, MeteredExt, StreamPosition, Timestamp,
    };

    use super::*;

    struct LegacyPlaintextFrame<'a> {
        record: &'a Record,
    }

    impl LegacyPlaintextFrame<'_> {
        fn magic_byte(&self) -> MagicByte {
            let metered_size = self.record.metered_size();
            let metered_size_varlen = 8 - (metered_size.leading_zeros() / 8) as u8;
            assert!(metered_size_varlen <= 3);

            MagicByte {
                record_type: match self.record {
                    Record::Command(_) => RecordType::Command,
                    Record::Envelope(_) => RecordType::Envelope,
                },
                metered_size_varlen,
            }
        }
    }

    impl WireEncode for LegacyPlaintextFrame<'_> {
        fn encoded_size(&self) -> usize {
            let body_size = match self.record {
                Record::Command(record) => record.encoded_size(),
                Record::Envelope(record) => record.encoded_size(),
            };
            1 + self.magic_byte().metered_size_varlen as usize + body_size
        }

        fn encode_into(&self, buf: &mut impl BufMut) {
            let magic_byte = self.magic_byte();
            buf.put_u8(magic_byte.into());
            buf.put_uint(
                self.record.metered_size() as u64,
                magic_byte.metered_size_varlen as usize,
            );
            match self.record {
                Record::Command(record) => record.encode_into(buf),
                Record::Envelope(record) => record.encode_into(buf),
            }
        }
    }

    fn legacy_plaintext_bytes(record: &Record) -> Bytes {
        LegacyPlaintextFrame { record }.to_bytes()
    }

    fn semantic_metered_size(record: &Record) -> usize {
        let (headers, body) = record.clone().into_parts();
        8 + (2 * headers.len())
            + headers
                .iter()
                .map(|header| header.name.len() + header.value.len())
                .sum::<usize>()
            + body.len()
    }

    fn bytes_strategy(allow_empty: bool) -> impl Strategy<Value = Bytes> {
        prop_oneof![
            prop::collection::vec(any::<u8>(), (if allow_empty { 0 } else { 1 })..10)
                .prop_map(Bytes::from),
            prop::collection::vec(any::<u8>(), 100..1000).prop_map(Bytes::from),
        ]
    }

    fn header_strategy() -> impl Strategy<Value = Header> {
        (bytes_strategy(false), bytes_strategy(true))
            .prop_map(|(name, value)| Header { name, value })
    }

    fn headers_strategy() -> impl Strategy<Value = Vec<Header>> {
        prop_oneof![
            prop::collection::vec(header_strategy(), 0..10),
            prop::collection::vec(header_strategy(), 200..300),
        ]
    }

    fn command_strategy() -> impl Strategy<Value = CommandRecord> {
        prop_oneof![
            proptest::string::string_regex(&format!("[ -~]{{0,{MAX_FENCING_TOKEN_LENGTH}}}"))
                .unwrap()
                .prop_map(|token| CommandRecord::Fence(token.parse().unwrap())),
            any::<SeqNum>().prop_map(CommandRecord::Trim),
        ]
    }

    proptest!(
        #![proptest_config(ProptestConfig::with_cases(10))]
        #[test]
        fn roundtrip_envelope(
            seq_num in any::<SeqNum>(),
            timestamp in any::<Timestamp>(),
            headers in headers_strategy(),
            body in bytes_strategy(true),
        ) {
            let record = Record::try_from_parts(headers, body).unwrap();
            let metered_record: Metered<Record> = record.clone().into();
            let encoded_record =
                encode_stored_record(StoredRecord::from(record.clone()).metered().as_ref());
            let legacy_record = legacy_plaintext_bytes(&record);
            prop_assert_eq!(encoded_record.as_ref(), legacy_record.as_ref());
            let decoded_record = decode_record(encoded_record).unwrap();
            prop_assert_eq!(&decoded_record, &metered_record);
            let sequenced = decoded_record.sequenced(StreamPosition { seq_num, timestamp });
            let (position, sequenced_record) = sequenced.into_parts();
            assert_eq!(position, StreamPosition { seq_num, timestamp });
            assert_eq!(sequenced_record.into_inner(), record);
        }
    );

    proptest!(
        #![proptest_config(ProptestConfig::with_cases(10))]
        #[test]
        fn roundtrip_metered(
            headers in headers_strategy(),
            body in bytes_strategy(true),
        ) {
            let record = Record::try_from_parts(headers.clone(), body.clone()).unwrap();
            let encoded_record =
                encode_stored_record(StoredRecord::from(record.clone()).metered().as_ref());
            assert_eq!(record.metered_size(), semantic_metered_size(&record));
            assert_eq!(record.metered_size(), try_metered_size(encoded_record.as_ref()).unwrap() as usize);
        }
    );

    proptest!(
        #![proptest_config(ProptestConfig::with_cases(10))]
        #[test]
        fn roundtrip_command_metered(command in command_strategy()) {
            let record = Record::Command(command);
            let encoded_record =
                encode_stored_record(StoredRecord::from(record.clone()).metered().as_ref());
            let expected_metered = semantic_metered_size(&record);
            let wire_metered = try_metered_size(encoded_record.as_ref()).unwrap() as usize;
            let decoded_record = decode_record(encoded_record).unwrap();

            assert_eq!(record.metered_size(), expected_metered);
            assert_eq!(record.metered_size(), wire_metered);
            prop_assert_eq!(decoded_record, Metered::<Record>::from(record));
        }
    );

    #[test]
    fn roundtrip_encrypted_stored_record() {
        let mut encoded = BytesMut::with_capacity(1 + 12 + 10 + 16);
        encoded.put_u8(0x02);
        encoded.put_slice(b"0123456789ab");
        encoded.put_slice(b"ciphertext");
        encoded.put_slice(b"0123456789abcdef");
        let record =
            StoredRecord::encrypted(EncryptedRecord::try_from(encoded.freeze()).unwrap(), 123);
        let metered_record = record.clone().metered();
        let encoded_record = encode_stored_record(metered_record.as_ref());
        let decoded_record = decode_stored_record(encoded_record).unwrap();
        assert_eq!(decoded_record, metered_record);
    }

    #[rstest]
    #[case(0b0000_0010, MagicByte { record_type: RecordType::Envelope, metered_size_varlen: 1})]
    #[case(0b0001_0010, MagicByte { record_type: RecordType::Envelope, metered_size_varlen: 3})]
    #[case(0b0000_0011, MagicByte { record_type: RecordType::EncryptedEnvelope, metered_size_varlen: 1})]
    #[case(0b0000_1001, MagicByte { record_type: RecordType::Command, metered_size_varlen: 2})]
    fn valid_magic_byte_parsing(#[case] as_u8: u8, #[case] magic_byte: MagicByte) {
        assert_eq!(MagicByte::try_from(as_u8).unwrap(), magic_byte);
        assert_eq!(u8::from(magic_byte), as_u8);
    }

    #[rstest]
    #[case(0b0000_1101, "invalid record type ordinal")]
    #[case(0b0001_1001, "invalid metered_size_varlen")]
    fn invalid_magic_byte_parsing(#[case] as_u8: u8, #[case] expected: &'static str) {
        assert_eq!(MagicByte::try_from(as_u8), Err(expected));
    }

    #[test]
    fn metered_record_truncated_after_magic_byte_returns_error() {
        // Magic byte: Envelope (0b0000_0010), metered_size_varlen = 1 -> expects 1 more byte.
        let truncated = Bytes::from_static(&[0b0000_0010]);
        let result = decode_record(truncated);
        assert_eq!(
            result,
            Err(StoredRecordDecodeError::Truncated("MeteredSize"))
        );
    }

    #[rstest]
    #[case::envelope_empty_headers(
        StoredRecord::from(Record::Envelope(
            EnvelopeRecord::try_from_parts(vec![], Bytes::from_static(b"hello")).unwrap()
        )),
        &[
            0x02, 0x0d, // envelope record, metered size 13
            0x00, // no headers
            b'h', b'e', b'l', b'l', b'o',
        ],
    )]
    #[case::envelope_with_header(
        StoredRecord::from(Record::Envelope(
            EnvelopeRecord::try_from_parts(
                vec![Header {
                    name: Bytes::from_static(b"k"),
                    value: Bytes::from_static(b"v"),
                }],
                Bytes::from_static(b"b"),
            ).unwrap()
        )),
        &[
            0x02, 0x0d, // envelope record, metered size 13
            0x10, 0x01, // one header, one byte for num headers
            0x01, b'k',
            0x01, b'v',
            b'b',
        ],
    )]
    #[case::command_trim(
        StoredRecord::from(Record::Command(CommandRecord::Trim(42))),
        &[
            0x01, 0x16, // command record, metered size 22
            0x01, // trim command ordinal
            0x00, 0x00, 0x00, 0x00,
            0x00, 0x00, 0x00, 0x2a,
        ],
    )]
    fn stored_record_encoding_matches_existing_wire_format(
        #[case] record: StoredRecord,
        #[case] expected: &[u8],
    ) {
        let metered_record = record.clone().metered();
        let encoded_size = stored_record_encoded_size(metered_record.as_ref());
        let encoded = encode_stored_record(metered_record.as_ref());
        let mut encoded_into = BytesMut::with_capacity(encoded_size);
        encode_stored_record_into(metered_record.as_ref(), &mut encoded_into);

        assert_eq!(encoded.len(), encoded_size);
        assert_eq!(encoded.as_ref(), expected);
        assert_eq!(encoded_into.as_ref(), expected);
        assert_eq!(decode_stored_record(encoded).unwrap().into_inner(), record);
    }

    #[test]
    fn encrypted_stored_record_encoding_matches_existing_wire_format() {
        let encrypted_payload = Bytes::from_static(b"\x020123456789abciphertext0123456789abcdef");
        let record = StoredRecord::encrypted(
            EncryptedRecord::try_from(encrypted_payload.clone()).unwrap(),
            123,
        );

        let encoded = encode_stored_record(record.clone().metered().as_ref());

        assert_eq!(
            encoded.as_ref(),
            [&[0x03, 0x7b], encrypted_payload.as_ref()].concat()
        );
        assert_eq!(decode_stored_record(encoded).unwrap().into_inner(), record);
    }

    #[test]
    fn decode_stored_record_preserves_encoded_metered_size_prefix() {
        let record = StoredRecord::from(Record::Envelope(
            EnvelopeRecord::try_from_parts(vec![], Bytes::from_static(b"hello")).unwrap(),
        ));
        let mut encoded = encode_stored_record(record.clone().metered().as_ref()).to_vec();
        encoded[1] = 99;

        let decoded = decode_stored_record(Bytes::from(encoded)).unwrap();

        assert_eq!(decoded.metered_size(), 99);
        assert_eq!(decoded.into_inner(), record);
    }

    #[test]
    fn decode_record_preserves_encoded_metered_size_prefix() {
        let record = Record::Envelope(
            EnvelopeRecord::try_from_parts(vec![], Bytes::from_static(b"hello")).unwrap(),
        );
        let mut encoded =
            encode_stored_record(StoredRecord::from(record.clone()).metered().as_ref()).to_vec();
        encoded[1] = 99;

        let decoded = decode_record(Bytes::from(encoded)).unwrap();

        assert_eq!(decoded.metered_size(), 99);
        assert_eq!(decoded.into_inner(), record);
    }

    #[test]
    fn test_read_varint() {
        let data = [0u8, 0, 0, 1, 0, 0, 0];

        assert_eq!(read_vint_u32_be(&data[..4]), 1u32);
        assert_eq!(read_vint_u32_be(&data[2..5]), 2u32.pow(8));
        assert_eq!(read_vint_u32_be(&data[2..6]), 2u32.pow(16));
        assert_eq!(read_vint_u32_be(&data[3..]), 2u32.pow(24));
    }
}