1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
//! Rule execution engine for RyoPattern
//!
//! Executes lint rules and produces diagnostics.
use crate::{
diagnostic::interpolate_message, Diagnostic, LintConfig, MatchResult, Rule, RuleOverride,
Severity,
};
use std::collections::HashMap;
use std::path::Path;
/// Rule execution engine
pub struct RuleEngine {
/// Loaded rules
rules: Vec<Rule>,
/// Rule overrides
overrides: HashMap<String, RuleOverride>,
/// Minimum severity threshold
severity_threshold: Option<Severity>,
}
impl RuleEngine {
/// Create a new engine with default settings
pub fn new() -> Self {
Self {
rules: Vec::new(),
overrides: HashMap::new(),
severity_threshold: None,
}
}
/// Create from a lint configuration
pub fn from_config(config: LintConfig) -> Self {
let mut engine = Self::new();
// Add inline rules
engine.rules.extend(config.inline_rules);
// Apply settings
if let Some(settings) = config.settings {
engine.severity_threshold = settings.severity_threshold;
}
// Apply overrides
if let Some(overrides) = config.rules {
engine.overrides = overrides.0;
}
engine
}
/// Add a rule
pub fn add_rule(&mut self, rule: Rule) {
self.rules.push(rule);
}
/// Add multiple rules
pub fn add_rules(&mut self, rules: impl IntoIterator<Item = Rule>) {
self.rules.extend(rules);
}
/// Set severity threshold
pub fn set_severity_threshold(&mut self, threshold: Severity) {
self.severity_threshold = Some(threshold);
}
/// Get all active rules (respecting overrides)
pub fn active_rules(&self) -> impl Iterator<Item = &Rule> {
self.rules.iter().filter(|rule| {
// Check if rule is enabled
if let Some(override_) = self.overrides.get(&rule.id) {
if !override_.enabled {
return false;
}
}
// Check severity threshold
if let Some(threshold) = self.severity_threshold {
let effective_severity = self
.overrides
.get(&rule.id)
.and_then(|o| o.severity)
.unwrap_or(rule.severity);
if !severity_meets_threshold(effective_severity, threshold) {
return false;
}
}
true
})
}
/// Get effective severity for a rule (considering overrides)
pub fn effective_severity(&self, rule: &Rule) -> Severity {
self.overrides
.get(&rule.id)
.and_then(|o| o.severity)
.unwrap_or(rule.severity)
}
/// Execute a rule and produce a MatchResult
///
/// Note: This is a placeholder that needs integration with ryo-analysis
/// for actual AST matching. Currently returns the match result structure.
pub fn execute_rule(&self, _rule: &Rule) -> Vec<MatchResult> {
// TODO: Integrate with ryo-analysis for actual pattern matching
// This will involve:
// 1. Query symbol registry for matching symbols
// 2. Match body patterns against function bodies
// 3. Check relation conditions via CodeGraphV2
// 4. Produce MatchResult with captures
Vec::new()
}
/// Execute all active rules
pub fn execute_all(&self) -> Vec<MatchResult> {
self.active_rules()
.flat_map(|rule| self.execute_rule(rule))
.collect()
}
/// Produce diagnostics from match results
pub fn diagnostics_from_results<'a>(
&self,
results: impl IntoIterator<Item = &'a MatchResult>,
file_path: impl AsRef<Path>,
) -> Vec<Diagnostic> {
results
.into_iter()
.filter_map(|result| Diagnostic::from_match_result(result, file_path.as_ref(), None))
.collect()
}
/// Process a MatchResult through message interpolation
pub fn process_result(&self, mut result: MatchResult, rule: &Rule) -> MatchResult {
// Apply rule info
result.rule_id = Some(rule.id.clone());
result.severity = Some(self.effective_severity(rule));
// Interpolate message
result.message = Some(interpolate_message(&rule.message, &result.captures));
// Copy suggestion
result.suggestion = rule.suggestion.clone();
result
}
}
impl Default for RuleEngine {
fn default() -> Self {
Self::new()
}
}
/// Check if a severity meets the threshold
fn severity_meets_threshold(severity: Severity, threshold: Severity) -> bool {
severity_level(severity) >= severity_level(threshold)
}
/// Get numeric level for severity (higher = more severe)
fn severity_level(severity: Severity) -> u8 {
match severity {
Severity::Hint => 0,
Severity::Info => 1,
Severity::Warning => 2,
Severity::Error => 3,
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::{CapturedNode, PatternQuery, Position, Span, SymbolKind};
fn test_rule() -> Rule {
Rule::new(
"RL001",
"no-unwrap",
Severity::Warning,
PatternQuery::new().kind(SymbolKind::Function),
"Found $UNWRAP in function",
)
.with_suggestion("Use ? operator")
}
#[test]
fn test_engine_add_rules() {
let mut engine = RuleEngine::new();
engine.add_rule(test_rule());
assert_eq!(engine.active_rules().count(), 1);
}
#[test]
fn test_engine_from_config() {
let config = LintConfig {
inline_rules: vec![test_rule()],
..Default::default()
};
let engine = RuleEngine::from_config(config);
assert_eq!(engine.active_rules().count(), 1);
}
#[test]
fn test_severity_threshold() {
let mut engine = RuleEngine::new();
// Add rules with different severities
engine.add_rule(Rule::new(
"RL001",
"error-rule",
Severity::Error,
PatternQuery::new(),
"Error",
));
engine.add_rule(Rule::new(
"RL002",
"warning-rule",
Severity::Warning,
PatternQuery::new(),
"Warning",
));
engine.add_rule(Rule::new(
"RL003",
"hint-rule",
Severity::Hint,
PatternQuery::new(),
"Hint",
));
// All rules active by default
assert_eq!(engine.active_rules().count(), 3);
// Set threshold to Warning
engine.set_severity_threshold(Severity::Warning);
assert_eq!(engine.active_rules().count(), 2);
// Set threshold to Error
engine.set_severity_threshold(Severity::Error);
assert_eq!(engine.active_rules().count(), 1);
}
#[test]
fn test_rule_override() {
let config = LintConfig {
inline_rules: vec![
Rule::new(
"RL001",
"rule1",
Severity::Warning,
PatternQuery::new(),
"msg",
),
Rule::new(
"RL002",
"rule2",
Severity::Warning,
PatternQuery::new(),
"msg",
),
],
rules: Some(crate::RuleOverrides({
let mut map = HashMap::new();
map.insert(
"RL001".to_string(),
RuleOverride {
enabled: false,
severity: None,
},
);
map.insert(
"RL002".to_string(),
RuleOverride {
enabled: true,
severity: Some(Severity::Error),
},
);
map
})),
..Default::default()
};
let engine = RuleEngine::from_config(config);
// RL001 should be disabled
// RL002 should be enabled with Error severity
let active: Vec<_> = engine.active_rules().collect();
assert_eq!(active.len(), 1);
assert_eq!(active[0].id, "RL002");
assert_eq!(engine.effective_severity(active[0]), Severity::Error);
}
#[test]
fn test_process_result() {
let engine = RuleEngine::new();
let rule = test_rule();
let result = MatchResult::matched().capture(
"$UNWRAP",
CapturedNode::new(
Span::new(
Position {
line: 10,
column: 5,
},
Position {
line: 10,
column: 20,
},
),
"x.unwrap()",
),
);
let processed = engine.process_result(result, &rule);
assert_eq!(processed.rule_id, Some("RL001".to_string()));
assert_eq!(processed.severity, Some(Severity::Warning));
assert_eq!(
processed.message,
Some("Found x.unwrap() in function".to_string())
);
}
}