rvoip-sip 0.3.8

SIP umbrella for RVoIP: api/* (UnifiedCoordinator, StreamPeer, CallbackPeer, Endpoint), server/* (B2BUA helpers), adapter/* (rvoip-core::ConnectionAdapter impl)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
//! Core API Types
//!
//! Defines the main types that developers interact with when using the session API.
//!
//! # Key Types Overview
//!
//! - **`SessionId`** - Unique identifier for each call session
//! - **`CallSession`** - Represents an active call with state and metadata
//! - **`IncomingCall`** - Data about an incoming call requiring a decision
//! - **`CallState`** - Current state of a call (Ringing, Active, etc.)
//! - **`CallDecision`** - How to handle an incoming call
//! - **`MediaInfo`** - Information about media streams and quality
//!
//! # Call Lifecycle Example
//!
//! ```rust
//! use rvoip_sip::api::types::{SessionId, CallDecision, CallSession};
//! use rvoip_sip::api::CallState;
//! use std::time::Instant;
//!
//! // In real usage, IncomingCall would be provided by the framework
//! // For this example, we'll work with the CallSession directly
//!
//! // 1. Create a call session
//! let session_id = SessionId::new();
//! let sdp_answer = "v=0\r\no=- 0 0 IN IP4 127.0.0.1\r\ns=-\r\nc=IN IP4 127.0.0.1\r\nt=0 0\r\nm=audio 5006 RTP/AVP 0\r\n";
//!
//! // 2. Handler makes a decision
//! let decision = CallDecision::Accept(Some(sdp_answer.to_string()));
//!
//! // 3. Call becomes active
//! let session = CallSession {
//!     id: session_id,
//!     from: "sip:alice@example.com".to_string(),
//!     to: "sip:bob@ourserver.com".to_string(),
//!     state: CallState::Active,
//!     started_at: Some(Instant::now()),
//!     sip_call_id: Some("call-123".to_string()),
//! };
//!
//! // 4. Monitor call state
//! match session.state() {
//!     CallState::Active => println!("Call is connected"),
//!     CallState::OnHold => println!("Call is on hold"),
//!     CallState::Failed(reason) => println!("Call failed: {}", reason),
//!     _ => {}
//! }
//! ```
//!
//! # Call States
//!
//! ```text
//! Initiating -> Ringing -> Active -> Terminated
//!                |           |
//!                |           +-----> OnHold -> Active
//!                |           |
//!                |           +-----> Transferring -> Terminated
//!                |
//!                +--------> Failed/Cancelled
//! ```
//!
//! # SDP Parsing
//!
//! ```rust
//! use rvoip_sip::api::parse_sdp_connection;
//!
//! fn parse_example() -> Result<(), Box<dyn std::error::Error>> {
//!     let sdp = r#"v=0
//! o=- 0 0 IN IP4 127.0.0.1
//! s=-
//! c=IN IP4 192.168.1.100
//! t=0 0
//! m=audio 5004 RTP/AVP 0 8 101
//! a=rtpmap:0 PCMU/8000
//! a=rtpmap:8 PCMA/8000
//! a=rtpmap:101 telephone-event/8000"#;
//!
//!     let info = parse_sdp_connection(sdp)?;
//!     assert_eq!(info.ip, "192.168.1.100");
//!     assert_eq!(info.port, 5004);
//!     assert!(info.codecs.contains(&"PCMU".to_string()));
//!     Ok(())
//! }
//! ```

use crate::errors::Result;
use crate::types::CallState;
use serde::{Deserialize, Serialize};
use std::fmt;
use std::time::Instant;
use uuid::Uuid;

// Re-export StatusCode for convenience
pub use rvoip_sip_core::StatusCode;

// Re-export SessionError as Error for compatibility
pub use crate::errors::SessionError as Error;

/// Unique identifier for a session
#[derive(Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub struct SessionId(pub String);

impl fmt::Debug for SessionId {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("SessionId")
            .field("bytes", &self.0.len())
            .finish()
    }
}

impl SessionId {
    /// Create a new random session ID
    pub fn new() -> Self {
        Self(format!("sess_{}", Uuid::new_v4()))
    }

    /// Create a session ID from a string
    pub fn from_string(id: String) -> Self {
        Self(id)
    }

    /// Borrow the session ID as a string slice.
    pub fn as_str(&self) -> &str {
        &self.0
    }
}

impl fmt::Display for SessionId {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        write!(f, "{}", self.0)
    }
}

impl Default for SessionId {
    fn default() -> Self {
        Self::new()
    }
}

/// Role of a session in a SIP dialog
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
pub enum SessionRole {
    /// User Agent Client - the party that initiates the call (caller)
    UAC,
    /// User Agent Server - the party that receives the call (callee)
    UAS,
}

/// Alias for CallSession for compatibility
pub type Session = CallSession;

/// Represents a prepared outgoing call with allocated resources
/// This is created before initiating the actual SIP INVITE
#[derive(Clone)]
pub struct PreparedCall {
    /// The session ID for this call
    pub session_id: SessionId,
    /// Local SIP URI
    pub from: String,
    /// Remote SIP URI
    pub to: String,
    /// Generated SDP offer with allocated media ports
    pub sdp_offer: String,
    /// Local RTP port that was allocated
    pub local_rtp_port: u16,
}

impl fmt::Debug for PreparedCall {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("PreparedCall")
            .field("session_id", &self.session_id)
            .field("from_bytes", &self.from.len())
            .field("to_bytes", &self.to.len())
            .field("sdp_offer_bytes", &self.sdp_offer.len())
            .field("local_rtp_port", &self.local_rtp_port)
            .finish()
    }
}

/// Represents an active call session
#[derive(Clone)]
pub struct CallSession {
    /// Session identifier for this call.
    pub id: SessionId,
    /// Local party URI (the `From` side for an outgoing call).
    pub from: String,
    /// Remote party URI (the `To` side for an outgoing call).
    pub to: String,
    /// Current call state.
    pub state: CallState,
    /// When the session was created, if tracked.
    pub started_at: Option<Instant>,
    /// SIP Call-ID header value that uniquely identifies this call across UAC and UAS
    pub sip_call_id: Option<String>,
}

impl fmt::Debug for CallSession {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("CallSession")
            .field("id", &self.id)
            .field("from_bytes", &self.from.len())
            .field("to_bytes", &self.to.len())
            .field("state", &self.state)
            .field("started", &self.started_at.is_some())
            .field("sip_call_id_present", &self.sip_call_id.is_some())
            .field(
                "sip_call_id_bytes",
                &self.sip_call_id.as_ref().map_or(0, String::len),
            )
            .finish()
    }
}

impl CallSession {
    /// Get the session ID
    pub fn id(&self) -> &SessionId {
        &self.id
    }

    /// Get the current call state
    pub fn state(&self) -> &CallState {
        &self.state
    }

    /// Check if the call is active (connected)
    pub fn is_active(&self) -> bool {
        matches!(self.state, CallState::Active)
    }

    /// Wait for the call to be answered
    /// Note: Use SessionManager::wait_for_answer() method instead
    pub async fn wait_for_answer(&self) -> Result<()> {
        // This method requires access to the event system
        Err(crate::errors::SessionError::Other(
            "Use SessionManager::wait_for_answer() method instead".to_string(),
        ))
    }

    /// Hold the call
    /// Note: Use SessionManager::hold_session() method instead
    pub async fn hold(&self) -> Result<()> {
        // This method now requires the caller to use SessionManager directly
        Err(crate::errors::SessionError::Other(
            "Use SessionManager::hold_session() method instead".to_string(),
        ))
    }

    /// Resume the call from hold
    /// Note: Use SessionManager::resume_session() method instead
    pub async fn resume(&self) -> Result<()> {
        // This method now requires the caller to use SessionManager directly
        Err(crate::errors::SessionError::Other(
            "Use SessionManager::resume_session() method instead".to_string(),
        ))
    }

    /// Transfer the call to another destination
    /// Note: Use SessionManager::transfer_session() method instead
    pub async fn transfer(&self, _target: &str) -> Result<()> {
        // This method now requires the caller to use SessionManager directly
        Err(crate::errors::SessionError::Other(
            "Use SessionManager::transfer_session() method instead".to_string(),
        ))
    }

    /// Terminate the call
    /// Note: Use SessionManager::terminate_session() method instead
    pub async fn terminate(&self) -> Result<()> {
        // This method now requires the caller to use SessionManager directly
        Err(crate::errors::SessionError::Other(
            "Use SessionManager::terminate_session() method instead".to_string(),
        ))
    }

    /// Start recording the media session
    pub async fn start_recording(&self) -> Result<()> {
        Err(crate::errors::SessionError::Other(
            "CallSession has no recording authority; use a coordinator-owned media API".to_string(),
        ))
    }

    /// Stop recording the media session
    pub async fn stop_recording(&self) -> Result<()> {
        Err(crate::errors::SessionError::Other(
            "CallSession has no recording authority; use a coordinator-owned media API".to_string(),
        ))
    }

    /// Play an audio file
    pub async fn play_audio(&self, _file: &str) -> Result<()> {
        Err(crate::errors::SessionError::Other(
            "CallSession has no media playback authority; use a coordinator-owned media API"
                .to_string(),
        ))
    }

    /// Start the media session
    pub async fn start_media(&self) -> Result<()> {
        Err(crate::errors::SessionError::Other(
            "CallSession has no media lifecycle authority; media starts through the session state machine"
                .to_string(),
        ))
    }
}

/// Represents an incoming call that needs to be handled
#[derive(Clone)]
pub struct IncomingCall {
    /// Session identifier assigned to this incoming call.
    pub id: SessionId,
    /// Caller URI from the SIP `From` header.
    pub from: String,
    /// Called URI from the SIP `To` header / request URI.
    pub to: String,
    /// Remote SDP offer, if the INVITE carried one.
    pub sdp: Option<String>,
    /// Selected SIP headers from the INVITE, keyed by header name.
    pub headers: std::collections::HashMap<String, String>,
    /// When the INVITE was received.
    pub received_at: Instant,
    /// SIP Call-ID header value that uniquely identifies this call across UAC and UAS
    pub sip_call_id: Option<String>,
    // Coordinator reference for accept/reject operations (set by handler)
    // pub(crate) coordinator: Option<Arc<crate::coordinator::SessionCoordinator>>, // Removed - use UnifiedCoordinator
}

impl fmt::Debug for IncomingCall {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("IncomingCall")
            .field("id", &self.id)
            .field("from_bytes", &self.from.len())
            .field("to_bytes", &self.to.len())
            .field("sdp_present", &self.sdp.is_some())
            .field("sdp_bytes", &self.sdp.as_ref().map_or(0, String::len))
            .field("header_count", &self.headers.len())
            .field("sip_call_id_present", &self.sip_call_id.is_some())
            .field(
                "sip_call_id_bytes",
                &self.sip_call_id.as_ref().map_or(0, String::len),
            )
            .finish()
    }
}

impl IncomingCall {
    /// Create a test incoming call (only for tests)
    #[doc(hidden)]
    pub fn new_test(
        id: SessionId,
        from: String,
        to: String,
        sdp: Option<String>,
        headers: std::collections::HashMap<String, String>,
        sip_call_id: Option<String>,
    ) -> Self {
        Self {
            id,
            from,
            to,
            sdp,
            headers,
            received_at: Instant::now(),
            sip_call_id,
            // coordinator: None, // Removed field
        }
    }

    // Commented out - depends on removed modules
    // TODO: Re-implement using unified API
    /*
    /// Accept the incoming call and get a SimpleCall handle
    ///
    /// This accepts the call and returns a SimpleCall object that provides
    /// symmetric capabilities with outgoing calls.
    pub async fn accept(self) -> Result<crate::api::call::SimpleCall> {
        unimplemented!("Use UnifiedSession for call control")
    }
    */

    /*
    /// Reject the incoming call with a reason
    ///
    /// This rejects the call with the specified reason.
    pub async fn reject(self, reason: &str) -> Result<()> {
        unimplemented!("Use UnifiedSession for call control")
    }
    */

    /*
    /// Forward the incoming call to another destination
    ///
    /// This sends a SIP redirect response to forward the call.
    pub async fn forward(self, target: &str) -> Result<()> {
        unimplemented!("Use UnifiedSession for call control")
    }
    */

    /// Get caller information
    pub fn caller(&self) -> &str {
        &self.from
    }

    /// Get called party information
    pub fn called(&self) -> &str {
        &self.to
    }
}

/// Decision on how to handle an incoming call
#[derive(Clone, PartialEq, Eq)]
pub enum CallDecision {
    /// Accept the call immediately, optionally with SDP answer
    Accept(Option<String>),
    /// Reject the call with a reason
    Reject(String),
    /// Defer the decision (e.g., add to queue)
    Defer,
    /// Forward the call to another destination
    Forward(String),
}

impl fmt::Debug for CallDecision {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            Self::Accept(sdp) => formatter
                .debug_struct("Accept")
                .field("sdp_present", &sdp.is_some())
                .field("sdp_bytes", &sdp.as_ref().map_or(0, String::len))
                .finish(),
            Self::Reject(reason) => formatter
                .debug_struct("Reject")
                .field("reason_bytes", &reason.len())
                .finish(),
            Self::Defer => formatter.write_str("Defer"),
            Self::Forward(target) => formatter
                .debug_struct("Forward")
                .field("target_bytes", &target.len())
                .finish(),
        }
    }
}

impl CallDecision {
    /// Create a reject decision with status code
    pub fn reject_with_code(status_code: StatusCode, reason: Option<String>) -> Self {
        CallDecision::Reject(reason.unwrap_or_else(|| status_code.to_string()))
    }

    /// Create an accept decision with optional SDP
    pub fn accept(sdp: Option<String>) -> Self {
        CallDecision::Accept(sdp)
    }

    /// Create a defer decision
    pub fn defer() -> Self {
        CallDecision::Defer
    }

    /// Create a forward decision
    pub fn forward(destination: impl Into<String>) -> Self {
        CallDecision::Forward(destination.into())
    }
}

/// Statistics about active sessions
#[derive(Debug, Clone)]
pub struct SessionStats {
    /// Total number of sessions created over the lifetime of the coordinator.
    pub total_sessions: usize,
    /// Number of currently active sessions.
    pub active_sessions: usize,
    /// Number of sessions that ended in failure.
    pub failed_sessions: usize,
    /// Average session duration, when computable.
    pub average_duration: Option<std::time::Duration>,
}

/// Media information for a session
#[derive(Clone)]
pub struct MediaInfo {
    /// Local SDP (offer or answer) for the session, if negotiated.
    pub local_sdp: Option<String>,
    /// Remote SDP (offer or answer) for the session, if negotiated.
    pub remote_sdp: Option<String>,
    /// Local RTP port allocated for the session.
    pub local_rtp_port: Option<u16>,
    /// Remote RTP port negotiated for the session.
    pub remote_rtp_port: Option<u16>,
    /// Negotiated audio codec name, when known.
    pub codec: Option<String>,
    // pub rtp_stats: Option<crate::media::stats::RtpSessionStats>, // TODO: Re-add when media stats are implemented
    // pub quality_metrics: Option<crate::media::stats::QualityMetrics>, // TODO: Re-add when media stats are implemented
}

impl fmt::Debug for MediaInfo {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("MediaInfo")
            .field("local_sdp_present", &self.local_sdp.is_some())
            .field(
                "local_sdp_bytes",
                &self.local_sdp.as_ref().map_or(0, String::len),
            )
            .field("remote_sdp_present", &self.remote_sdp.is_some())
            .field(
                "remote_sdp_bytes",
                &self.remote_sdp.as_ref().map_or(0, String::len),
            )
            .field("local_rtp_port", &self.local_rtp_port)
            .field("remote_rtp_port", &self.remote_rtp_port)
            .field("codec_present", &self.codec.is_some())
            .field("codec_bytes", &self.codec.as_ref().map_or(0, String::len))
            .finish()
    }
}

/// Call direction
#[derive(Debug, Clone, PartialEq)]
pub enum CallDirection {
    /// Outgoing call (UAC)
    Outgoing,
    /// Incoming call (UAS)
    Incoming,
}

/// Call termination reason
#[derive(Clone)]
pub enum TerminationReason {
    /// Normal hangup by local party
    LocalHangup,
    /// Normal hangup by remote party
    RemoteHangup,
    /// Call rejected
    Rejected(String),
    /// Call failed due to error
    Error(String),
    /// Call timed out
    Timeout,
}

impl fmt::Debug for TerminationReason {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            Self::LocalHangup => formatter.write_str("LocalHangup"),
            Self::RemoteHangup => formatter.write_str("RemoteHangup"),
            Self::Rejected(reason) => formatter
                .debug_struct("Rejected")
                .field("reason_bytes", &reason.len())
                .finish(),
            Self::Error(error) => formatter
                .debug_struct("Error")
                .field("error_bytes", &error.len())
                .finish(),
            Self::Timeout => formatter.write_str("Timeout"),
        }
    }
}

impl fmt::Display for TerminationReason {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            TerminationReason::LocalHangup => write!(f, "Local hangup"),
            TerminationReason::RemoteHangup => write!(f, "Remote hangup"),
            TerminationReason::Rejected(reason) => write!(f, "Rejected: {}", reason),
            TerminationReason::Error(error) => write!(f, "Error: {}", error),
            TerminationReason::Timeout => write!(f, "Timeout"),
        }
    }
}

/// Parsed SDP information for easier handling
#[derive(Clone)]
pub struct SdpInfo {
    /// Connection IP address
    pub ip: String,
    /// Media port (typically RTP port)
    pub port: u16,
    /// List of supported codecs
    pub codecs: Vec<String>,
}

impl fmt::Debug for SdpInfo {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("SdpInfo")
            .field("ip_bytes", &self.ip.len())
            .field("port", &self.port)
            .field("codec_count", &self.codecs.len())
            .finish()
    }
}

/// Parse SDP connection information
///
/// # Example
/// ```no_run
/// use rvoip_sip::api::parse_sdp_connection;
///
/// let sdp = "v=0\r\nc=IN IP4 192.168.1.100\r\nm=audio 5004 RTP/AVP 0 8\r\n";
/// if let Ok(info) = parse_sdp_connection(sdp) {
///     println!("Remote endpoint: {}:{}", info.ip, info.port);
/// }
/// ```
pub fn parse_sdp_connection(sdp: &str) -> Result<SdpInfo> {
    let mut ip = None;
    let mut port = None;
    let mut codecs = Vec::new();

    for line in sdp.lines() {
        if line.starts_with("c=IN IP4 ") {
            ip = line.strip_prefix("c=IN IP4 ").map(|s| s.to_string());
        } else if line.starts_with("m=audio ") {
            let parts: Vec<&str> = line.split_whitespace().collect();
            if parts.len() > 1 {
                port = parts[1].parse().ok();
            }
            // Extract codec numbers
            if parts.len() > 3 {
                for codec in &parts[3..] {
                    codecs.push(codec.to_string());
                }
            }
        } else if line.starts_with("a=rtpmap:") {
            // Parse codec names
            if let Some(codec_info) = line.strip_prefix("a=rtpmap:") {
                let parts: Vec<&str> = codec_info.split_whitespace().collect();
                if parts.len() >= 2 {
                    // Format: "0 PCMU/8000" -> add "PCMU" to codecs
                    if let Some(codec_name) = parts[1].split('/').next() {
                        codecs.push(codec_name.to_string());
                    }
                }
            }
        }
    }

    match (ip, port) {
        (Some(ip), Some(port)) => Ok(SdpInfo { ip, port, codecs }),
        _ => Err(crate::errors::SessionError::MediaIntegration {
            reason: "Failed to parse SDP connection information".to_string(),
        }),
    }
}

// =============================================================================
// AUDIO STREAMING TYPES
// =============================================================================

/// Re-export AudioFrame from media-core to unify the type across the codebase
/// This eliminates unnecessary conversions and potential issues
pub use rvoip_media_core::types::AudioFrame;

/// Configuration for audio streaming
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct AudioStreamConfig {
    /// Sample rate in Hz
    pub sample_rate: u32,
    /// Number of channels (1 for mono, 2 for stereo)
    pub channels: u8,
    /// Preferred codec (e.g., "PCMU", "PCMA", "Opus")
    pub codec: String,
    /// Frame size in milliseconds
    pub frame_size_ms: u32,
    /// Enable echo cancellation
    pub enable_aec: bool,
    /// Enable automatic gain control
    pub enable_agc: bool,
    /// Enable voice activity detection
    pub enable_vad: bool,
}

impl Default for AudioStreamConfig {
    fn default() -> Self {
        Self {
            sample_rate: 8000,         // Standard telephony
            channels: 1,               // Mono
            codec: "PCMU".to_string(), // G.711 μ-law
            frame_size_ms: 20,         // 20ms frames
            enable_aec: true,
            enable_agc: true,
            enable_vad: true,
        }
    }
}

impl AudioStreamConfig {
    /// Create a new audio stream configuration
    pub fn new(sample_rate: u32, channels: u8, codec: impl Into<String>) -> Self {
        Self {
            sample_rate,
            channels,
            codec: codec.into(),
            ..Default::default()
        }
    }

    /// Get the expected frame size in samples
    pub fn frame_size_samples(&self) -> usize {
        (self.sample_rate as usize * self.frame_size_ms as usize) / 1000
    }

    /// Get the expected frame size in bytes (for PCM)
    pub fn frame_size_bytes(&self) -> usize {
        self.frame_size_samples() * self.channels as usize * 2 // 16-bit samples
    }

    /// Create a telephony configuration (mono, 8kHz, G.711)
    pub fn telephony() -> Self {
        Self::default()
    }

    /// Create a wideband configuration (mono, 16kHz, Opus)
    pub fn wideband() -> Self {
        Self {
            sample_rate: 16000,
            codec: "Opus".to_string(),
            ..Default::default()
        }
    }

    /// Create a high-quality configuration (stereo, 48kHz, Opus)
    pub fn high_quality() -> Self {
        Self {
            sample_rate: 48000,
            channels: 2,
            codec: "Opus".to_string(),
            ..Default::default()
        }
    }
}

/// SIP-level identity of a dialog: the three values required to construct
/// a `Replaces` header (RFC 3891) for attended-transfer orchestration.
///
/// Obtain one via
/// [`SessionHandle::dialog_identity`](crate::api::handle::SessionHandle::dialog_identity).
/// To drive attended transfer from an orchestrator, read the identity of the
/// consultation session and pass its formatted form to
/// [`SessionHandle::transfer_attended`](crate::api::handle::SessionHandle::transfer_attended)
/// on the original session.
#[derive(Clone)]
pub struct DialogIdentity {
    /// SIP `Call-ID` header value.
    pub call_id: String,
    /// From-tag on our side of the dialog. `None` until the dialog is
    /// fully established.
    pub local_tag: Option<String>,
    /// To-tag from the remote side. `None` until a 2xx (or reliable 1xx)
    /// has been received and dialog is confirmed.
    pub remote_tag: Option<String>,
}

impl fmt::Debug for DialogIdentity {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("DialogIdentity")
            .field("call_id_bytes", &self.call_id.len())
            .field("local_tag_present", &self.local_tag.is_some())
            .field(
                "local_tag_bytes",
                &self.local_tag.as_ref().map_or(0, String::len),
            )
            .field("remote_tag_present", &self.remote_tag.is_some())
            .field(
                "remote_tag_bytes",
                &self.remote_tag.as_ref().map_or(0, String::len),
            )
            .finish()
    }
}

impl DialogIdentity {
    /// Format as a `Replaces` header *value* (no percent-encoding applied).
    /// Pass this to
    /// [`SessionHandle::transfer_attended`](crate::api::handle::SessionHandle::transfer_attended),
    /// which handles URI-escaping when embedding it in the Refer-To target.
    ///
    /// Returns `None` if either tag is missing (dialog not yet confirmed).
    pub fn to_replaces_value(&self) -> Option<String> {
        let (local, remote) = (self.local_tag.as_ref()?, self.remote_tag.as_ref()?);
        // RFC 3891 §3: `call-id;to-tag=<remote>;from-tag=<local>` — from the
        // transferee's perspective the "to-tag" is the *remote* party's tag
        // in the dialog being replaced.
        Some(format!(
            "{};to-tag={};from-tag={}",
            self.call_id, remote, local
        ))
    }
}

/// Subscriber for receiving decoded audio frames from a session.
///
/// This is the lower-level subscriber used by the coordinator. Most
/// application code should prefer [`SessionHandle::audio`](crate::SessionHandle::audio),
/// which wraps this in an [`AudioStream`](crate::AudioStream).
pub struct AudioFrameSubscriber {
    /// The session ID this subscriber is associated with
    session_id: SessionId,
    /// Receiver for audio frames (async tokio channel for non-blocking operation)
    receiver: tokio::sync::mpsc::Receiver<AudioFrame>,
}

impl fmt::Debug for AudioFrameSubscriber {
    fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result {
        formatter
            .debug_struct("AudioFrameSubscriber")
            .field("session_id", &self.session_id)
            .finish_non_exhaustive()
    }
}

impl AudioFrameSubscriber {
    /// Create a new audio frame subscriber
    pub fn new(session_id: SessionId, receiver: tokio::sync::mpsc::Receiver<AudioFrame>) -> Self {
        Self {
            session_id,
            receiver,
        }
    }

    /// Get the session ID this subscriber is associated with
    pub fn session_id(&self) -> &SessionId {
        &self.session_id
    }

    /// Receive the next audio frame (async)
    ///
    /// # Returns
    /// - `Some(audio_frame)` - Audio frame ready for playback
    /// - `None` - Channel is closed or session ended
    pub async fn recv(&mut self) -> Option<AudioFrame> {
        self.receiver.recv().await
    }

    /// Try to receive an audio frame (non-blocking)
    ///
    /// # Returns
    /// - `Ok(audio_frame)` - Audio frame ready for playback
    /// - `Err(TryRecvError::Empty)` - No frame available right now
    /// - `Err(TryRecvError::Disconnected)` - Channel is closed or session ended
    pub fn try_recv(
        &mut self,
    ) -> std::result::Result<AudioFrame, tokio::sync::mpsc::error::TryRecvError> {
        self.receiver.try_recv()
    }

    /// Check if the subscriber is still connected to the session
    pub fn is_connected(&self) -> bool {
        !self.receiver.is_closed()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_session_id_creation() {
        let id1 = SessionId::new();
        let id2 = SessionId::new();
        assert_ne!(id1, id2);
        assert!(id1.0.starts_with("sess_"));
    }

    #[test]
    fn test_call_state_display() {
        use crate::types::FailureReason;
        assert_eq!(CallState::Active.to_string(), "Active");
        assert_eq!(
            CallState::Failed(FailureReason::Timeout).to_string(),
            "Failed(Timeout)"
        );
    }

    #[test]
    fn public_call_type_debug_is_payload_free() {
        const SECRET: &str = "public-call-type-secret-canary";
        let incoming = IncomingCall::new_test(
            SessionId(SECRET.to_string()),
            SECRET.to_string(),
            SECRET.to_string(),
            Some(SECRET.to_string()),
            std::collections::HashMap::from([("Authorization".to_string(), SECRET.to_string())]),
            Some(SECRET.to_string()),
        );
        let prepared = PreparedCall {
            session_id: SessionId(SECRET.to_string()),
            from: SECRET.to_string(),
            to: SECRET.to_string(),
            sdp_offer: SECRET.to_string(),
            local_rtp_port: 5004,
        };
        let dialog = DialogIdentity {
            call_id: SECRET.to_string(),
            local_tag: Some(SECRET.to_string()),
            remote_tag: Some(SECRET.to_string()),
        };
        for rendered in [
            format!("{:?}", SessionId(SECRET.to_string())),
            format!("{incoming:?}"),
            format!("{prepared:?}"),
            format!("{:?}", CallDecision::Accept(Some(SECRET.to_string()))),
            format!("{:?}", TerminationReason::Error(SECRET.to_string())),
            format!("{dialog:?}"),
        ] {
            assert!(!rendered.contains(SECRET), "debug leaked: {rendered}");
        }
    }

    #[tokio::test]
    async fn detached_call_session_never_fabricates_media_success() {
        let call = CallSession {
            id: SessionId::new(),
            from: "sip:alice@example.invalid".to_string(),
            to: "sip:bob@example.invalid".to_string(),
            state: CallState::Active,
            started_at: None,
            sip_call_id: None,
        };

        assert!(call.start_recording().await.is_err());
        assert!(call.stop_recording().await.is_err());
        assert!(call.play_audio("unused.wav").await.is_err());
        assert!(call.start_media().await.is_err());
    }
}