rustqual 1.6.0

Comprehensive Rust code quality analyzer — seven dimensions: IOSP, Complexity, DRY, SRP, Coupling, Test Quality, Architecture
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160

use super::*;

type Pred = fn(&Classification) -> bool;
const NOT_VIOLATION: Pred = |c| !matches!(c, Classification::Violation { .. });

// Closures and iterator chains don't count as logic/own-calls in lenient
// (default) mode, so a fn whose only logic/calls live inside them is not a
// Violation; `strict_closures` / `strict_iterator_chains` flip that. A genuine
// logic+own-call mix is always a Violation; stdlib path ctors (String::new)
// never make an integration.
// (label, code, fn_name, strict_closures, strict_iterators, predicate)
const PREDICATE_CASES: &[(&str, &str, &str, bool, bool, Pred)] = &[
    (
        "logic+own-call mix is a violation",
        r#"
            fn helper(x: i32) { if x > 0 { violator(x); } }
            fn violator(x: i32) {
                let _y = x;
                if _y > 0 {
                    helper(_y);
                }
            }
            "#,
        "violator",
        false,
        false,
        |c| matches!(c, Classification::Violation { .. }),
    ),
    (
        "lenient: logic inside a closure is ignored",
        r#"
            fn f() {
                let v = vec![1, 2, 3];
                let _: Vec<_> = v.into_iter().collect();
                let _ = (|| { if true { 1 } else { 2 } })();
            }
            "#,
        "f",
        false,
        false,
        NOT_VIOLATION,
    ),
    (
        "strict closures: logic inside a closure counts",
        r#"
            fn f() {
                let v = vec![1, 2, 3];
                let _ = (|| { if true { 1 } else { 2 } })();
                let _ = v.len();
            }
            "#,
        "f",
        true,
        false,
        |c| {
            matches!(
                c,
                Classification::Operation | Classification::Violation { .. }
            )
        },
    ),
    (
        "lenient: own call inside a closure is ignored",
        r#"
            fn helper() {}
            fn f() {
                let c = || { helper(); };
                c();
                let _ = 1;
            }
            "#,
        "f",
        false,
        false,
        NOT_VIOLATION,
    ),
    (
        "strict closures: own call inside a closure counts",
        r#"
            fn helper() {}
            fn f() {
                let c = || { helper(); };
                c();
                let _ = 1;
            }
            "#,
        "f",
        true,
        false,
        |c| {
            matches!(
                c,
                Classification::Integration | Classification::Violation { .. }
            )
        },
    ),
    (
        "lenient: iterator methods are not own calls",
        r#"
            fn f() -> Vec<i32> {
                let v = vec![1, 2, 3];
                v.iter().map(|x| x + 1).collect()
            }
            "#,
        "f",
        false,
        false,
        NOT_VIOLATION,
    ),
    (
        "strict iterators: in-scope iterator methods count",
        r#"
            struct Foo;
            impl Foo {
                fn map(&self) {}
            }
            fn f() -> Vec<i32> {
                let v = vec![1, 2, 3];
                let x = v.iter().map(|x| x + 1).collect::<Vec<_>>();
                x
            }
            "#,
        "f",
        false,
        true,
        |c| {
            matches!(
                c,
                Classification::Integration | Classification::Violation { .. }
            )
        },
    ),
    (
        "stdlib path ctor is not an own call",
        r#"
            fn f() {
                let _a = String::new();
                let _b = String::new();
            }
            "#,
        "f",
        false,
        false,
        |c| !matches!(c, Classification::Integration),
    ),
];

#[test]
fn classification_predicate_lenient_vs_strict() {
    for (label, code, fn_name, strict_closures, strict_iterators, predicate) in PREDICATE_CASES {
        let mut config = Config::default();
        config.strict_closures = *strict_closures;
        config.strict_iterator_chains = *strict_iterators;
        let classification = classify_cfg(code, fn_name, &config);
        assert!(
            predicate(&classification),
            "case {label}: unexpected {classification:?}"
        );
    }
}