rustqual 1.4.1

Comprehensive Rust code quality analyzer — seven dimensions: IOSP, Complexity, DRY, SRP, Coupling, Test Quality, Architecture
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122

use super::*;

#[test]
fn test_complexity_metrics_present() {
    let code = r#"
        fn f(x: i32) {
            let _y = x;
            if x > 0 {
                if x > 10 {
                    let _ = x + 1;
                }
            }
        }
    "#;
    let results = parse_and_analyze(code);
    let f = results.iter().find(|r| r.name == "f").unwrap();
    let metrics = f
        .complexity
        .as_ref()
        .expect("Should have complexity metrics");
    assert!(metrics.logic_count > 0, "Should have logic count");
    assert!(metrics.max_nesting > 0, "Should have nesting depth");
}

#[test]
fn test_complexity_nesting_depth() {
    let code = r#"
        fn f(x: i32) {
            let _y = x;
            if x > 0 {
                if x > 10 {
                    while x > 100 {
                        break;
                    }
                }
            }
        }
    "#;
    let results = parse_and_analyze(code);
    let f = results.iter().find(|r| r.name == "f").unwrap();
    let metrics = f.complexity.as_ref().unwrap();
    assert_eq!(
        metrics.max_nesting, 3,
        "Expected nesting depth 3 (if > if > while)"
    );
}

// ---------------------------------------------------------------
// C2: Severity Tests
// ---------------------------------------------------------------

#[test]
fn test_severity_low() {
    let code = r#"
        fn helper(x: bool) { if x { f(false); } }
        fn f(x: bool) {
            let _y = x;
            if x { helper(true); }
        }
    "#;
    let results = parse_and_analyze(code);
    let f = results.iter().find(|r| r.name == "f").unwrap();
    assert_eq!(f.severity, Some(Severity::Low));
}

#[test]
fn test_severity_none_for_non_violation() {
    let code = r#"
        fn f(x: i32) {
            let _y = x;
            if x > 0 { }
        }
    "#;
    let results = parse_and_analyze(code);
    let f = results.iter().find(|r| r.name == "f").unwrap();
    assert_eq!(f.severity, None);
}

// ---------------------------------------------------------------
// Suppression Tests
// ---------------------------------------------------------------

#[test]
fn test_suppressed_flag_default_false() {
    let code = r#"
        fn f() {}
    "#;
    let results = parse_and_analyze(code);
    let f = results.iter().find(|r| r.name == "f").unwrap();
    assert!(!f.suppressed);
}

// ---------------------------------------------------------------
// D1/D7: qualified_name + severity fields
// ---------------------------------------------------------------

#[test]
fn test_qualified_name_free_fn() {
    let code = r#"
        fn my_function() {}
    "#;
    let results = parse_and_analyze(code);
    let f = results.iter().find(|r| r.name == "my_function").unwrap();
    assert_eq!(f.qualified_name, "my_function");
}

#[test]
fn test_qualified_name_impl_method() {
    let code = r#"
        struct Foo;
        impl Foo {
            fn bar(&self) {}
        }
    "#;
    let results = parse_and_analyze(code);
    let bar = results.iter().find(|r| r.name == "bar").unwrap();
    assert_eq!(bar.qualified_name, "Foo::bar");
}

// ---------------------------------------------------------------
// Bug Fix: Trivial Self-Getter Not Violation
// ---------------------------------------------------------------