rustqual 1.2.2

Comprehensive Rust code quality analyzer — seven dimensions: IOSP, Complexity, DRY, SRP, Coupling, Test Quality, Architecture
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135

use crate::adapters::analyzers::architecture::matcher::find_glob_imports;
use crate::adapters::analyzers::architecture::ViolationKind;

fn parse(src: &str) -> syn::File {
    syn::parse_str(src).expect("test fixture must parse")
}

fn find(src: &str) -> Vec<crate::adapters::analyzers::architecture::MatchLocation> {
    let ast = parse(src);
    find_glob_imports("fixture.rs", &ast)
}

// ── Positive matches ──────────────────────────────────────────────────

#[test]
fn matches_simple_glob_import() {
    let src = r#"use foo::*;"#;
    let hits = find(src);
    assert_eq!(hits.len(), 1, "one glob expected: {hits:?}");
    match &hits[0].kind {
        ViolationKind::GlobImport { base_path } => {
            assert_eq!(base_path, "foo");
        }
        other => panic!("expected GlobImport, got {other:?}"),
    }
}

#[test]
fn matches_nested_glob_import() {
    let src = r#"use foo::bar::baz::*;"#;
    let hits = find(src);
    assert_eq!(hits.len(), 1, "one glob expected: {hits:?}");
    match &hits[0].kind {
        ViolationKind::GlobImport { base_path } => {
            assert_eq!(base_path, "foo::bar::baz");
        }
        other => panic!("expected GlobImport, got {other:?}"),
    }
}

#[test]
fn matches_self_glob() {
    // `use self::*` is still a glob import — policies may accept it via scope,
    // not via the matcher itself.
    let src = r#"use self::*;"#;
    let hits = find(src);
    assert_eq!(hits.len(), 1);
    match &hits[0].kind {
        ViolationKind::GlobImport { base_path } => {
            assert_eq!(base_path, "self");
        }
        other => panic!("expected GlobImport, got {other:?}"),
    }
}

#[test]
fn matches_super_glob() {
    let src = r#"
        mod inner {
            use super::*;
        }
    "#;
    let hits = find(src);
    assert_eq!(hits.len(), 1);
    match &hits[0].kind {
        ViolationKind::GlobImport { base_path } => {
            assert_eq!(base_path, "super");
        }
        other => panic!("expected GlobImport, got {other:?}"),
    }
}

#[test]
fn matches_glob_inside_group() {
    // `use foo::{bar::*, baz}` contains one glob inside the group.
    let src = r#"use foo::{bar::*, baz};"#;
    let hits = find(src);
    assert_eq!(hits.len(), 1, "one glob expected, got: {hits:?}");
    match &hits[0].kind {
        ViolationKind::GlobImport { base_path } => {
            assert_eq!(base_path, "foo::bar");
        }
        other => panic!("expected GlobImport, got {other:?}"),
    }
}

#[test]
fn reports_multiple_globs_separately() {
    let src = r#"
        use foo::*;
        use bar::baz::*;
    "#;
    let hits = find(src);
    assert_eq!(hits.len(), 2, "two globs expected: {hits:?}");
}

// ── Negative matches ──────────────────────────────────────────────────

#[test]
fn does_not_match_named_import() {
    let src = r#"use foo::Bar;"#;
    let hits = find(src);
    assert!(hits.is_empty(), "named import must not match: {hits:?}");
}

#[test]
fn does_not_match_group_without_glob() {
    let src = r#"use foo::{bar, baz};"#;
    let hits = find(src);
    assert!(
        hits.is_empty(),
        "group without glob must not match: {hits:?}"
    );
}

#[test]
fn does_not_match_renamed_import() {
    let src = r#"use foo::Bar as Baz;"#;
    let hits = find(src);
    assert!(hits.is_empty(), "rename is not a glob: {hits:?}");
}

#[test]
fn does_not_match_empty_file() {
    let hits = find("");
    assert!(hits.is_empty());
}

#[test]
fn line_number_points_to_glob_statement() {
    let src = "\n\n\nuse foo::*;\n";
    let hits = find(src);
    assert_eq!(hits.len(), 1);
    assert_eq!(hits[0].line, 4, "should point to line of the glob");
}