rustqual 1.2.2

Comprehensive Rust code quality analyzer — seven dimensions: IOSP, Complexity, DRY, SRP, Coupling, Test Quality, Architecture
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101

//! Per-adapter coverage aggregation + adapter-reachable-targets BFS
//! for Check B.
//!
//! `AdapterCoverage` aggregates each adapter's per-handler touchpoint
//! sets into one union per adapter — Check B's orphan probe needs the
//! per-adapter-level set, not the per-handler grain that
//! `HandlerTouchpoints` carries. The reachable-targets BFS expands
//! the union forward through target-internal callers so post-boundary
//! plumbing wired into adapter coverage stays silent (only genuine
//! orphans / dead islands surface).

use super::anchor_index::is_anchor_target_capability;
use super::pub_fns::PubFnInfo;
use super::workspace_graph::{canonical_name_for_pub_fn, CallGraph};
use super::HandlerTouchpoints;
use crate::adapters::analyzers::architecture::compiled::CompiledCallParity;
use std::collections::{HashMap, HashSet, VecDeque};

/// Per-adapter aggregated touchpoint set: union of every adapter
/// pub-fn's individual touchpoint set, keyed by adapter layer name.
pub(super) type AdapterCoverage = HashMap<String, HashSet<String>>;

/// Build the per-adapter coverage view by unioning the cached
/// touchpoint sets across each adapter's handlers. Deprecated
/// handlers are already filtered out of `touchpoints`.
/// Operation: nested fold over the cache.
pub(super) fn build_adapter_coverage(
    pub_fns_by_layer: &HashMap<String, Vec<PubFnInfo<'_>>>,
    touchpoints: &HandlerTouchpoints,
    cp: &CompiledCallParity,
) -> AdapterCoverage {
    let mut coverage: AdapterCoverage = HashMap::new();
    for adapter in &cp.adapters {
        let mut union: HashSet<String> = HashSet::new();
        if let Some(handlers) = pub_fns_by_layer.get(adapter) {
            for info in handlers {
                let canonical = canonical_name_for_pub_fn(info);
                if let Some(tps) = touchpoints.get(&canonical) {
                    union.extend(tps.iter().cloned());
                }
            }
        }
        coverage.insert(adapter.clone(), union);
    }
    coverage
}

/// Target-capability nodes transitively reachable from any adapter
/// touchpoint. Distinguishes post-boundary plumbing (silent) from
/// genuine orphans (flagged). Forward BFS over `graph.forward`,
/// gated by `is_target_capability_node` so trait anchors reached
/// via target-internal callers stay visible.
pub(super) fn build_adapter_reachable_targets(
    coverage: &AdapterCoverage,
    graph: &CallGraph,
    target_layer: &str,
    adapter_layers: &[String],
) -> HashSet<String> {
    let mut reachable: HashSet<String> = HashSet::new();
    let mut queue: VecDeque<String> = VecDeque::new();
    for tps in coverage.values() {
        for tp in tps {
            if reachable.insert(tp.clone()) {
                queue.push_back(tp.clone());
            }
        }
    }
    while let Some(node) = queue.pop_front() {
        let Some(callees) = graph.forward.get(&node) else {
            continue;
        };
        for callee in callees {
            if is_target_capability_node(callee, graph, target_layer, adapter_layers)
                && reachable.insert(callee.clone())
            {
                queue.push_back(callee.clone());
            }
        }
    }
    reachable
}

/// True when `canonical` is a real target-layer graph node or a
/// trait-method anchor passing the unified target-capability rule.
/// Phantom edge sinks (e.g. fabricated `<Impl>::<method>` canonicals
/// from inherited-default impls) carry a cached `layer_of` but no
/// `forward` entry; they must not propagate as target capabilities.
fn is_target_capability_node(
    canonical: &str,
    graph: &CallGraph,
    target_layer: &str,
    adapter_layers: &[String],
) -> bool {
    if graph.layer_of(canonical) == Some(target_layer) && graph.forward.contains_key(canonical) {
        return true;
    }
    graph
        .trait_method_anchors
        .get(canonical)
        .is_some_and(|info| is_anchor_target_capability(info, target_layer, adapter_layers))
}