rustpix-tpx 1.0.3

//! rustpix-tpx: TPX3 packet parser, hit types, and file processor.
//!
//! This crate provides TPX3-specific data structures and parsing logic
//! for Timepix3 pixel detector data.
//!
#![warn(missing_docs)]
//!
//! # Key Components
//!
//! - [`Tpx3Packet`] - Low-level packet parser with bit field extraction
//! - `Tpx3Processor` - Section-aware file processor
//!
//! # Processing Pipeline
//!
//! 1. **Phase 1 (Sequential)**: Discover sections, propagate TDC state
//! 2. **Phase 2 (Parallel)**: Process sections into hits
//!

mod hit;
pub mod ordering;
mod packet;
pub mod section;

pub use hit::{calculate_tof, correct_timestamp_rollover};
pub use packet::Tpx3Packet;

use serde::{Deserialize, Serialize};
use std::fs::File;
use std::io::BufReader;
use std::path::Path;

/// Affine transformation for chip coordinate mapping.
///
/// Formula:
/// `global_x` = a * `local_x` + b * `local_y` + tx
/// `global_y` = c * `local_x` + d * `local_y` + ty
#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct ChipTransform {
    /// Local X coefficient for affine transform.
    pub a: i32,
    /// Local Y coefficient for affine transform in X output.
    pub b: i32,
    /// Local X coefficient for affine transform in Y output.
    pub c: i32,
    /// Local Y coefficient for affine transform.
    pub d: i32,
    /// Translation in X direction.
    pub tx: i32,
    /// Translation in Y direction.
    pub ty: i32,
}

impl ChipTransform {
    /// Create an identity transform.
    #[must_use]
    pub fn identity() -> Self {
        Self {
            a: 1,
            b: 0,
            c: 0,
            d: 1,
            tx: 0,
            ty: 0,
        }
    }

    /// Apply transform to local coordinates.
    ///
    /// # Note
    /// This method assumes the transform has been validated via `validate_bounds()`.
    /// Using an unvalidated transform may cause incorrect results due to integer overflow.
    #[inline]
    #[must_use]
    pub fn apply(&self, x: u16, y: u16) -> (u16, u16) {
        let x = i32::from(x);
        let y = i32::from(y);

        let gx = self.a * x + self.b * y + self.tx;
        let gy = self.c * x + self.d * y + self.ty;

        debug_assert!(
            u16::try_from(gx).is_ok(),
            "ChipTransform: X out of bounds: {gx}"
        );
        debug_assert!(
            u16::try_from(gy).is_ok(),
            "ChipTransform: Y out of bounds: {gy}"
        );

        // Safety: bounds validated upfront via validate_bounds()
        (
            u16::try_from(gx).unwrap_or(u16::MAX),
            u16::try_from(gy).unwrap_or(u16::MAX),
        )
    }

    /// Validate that this transform produces valid u16 coordinates
    /// for all inputs in the range [0, `chip_size_x`) x [0, `chip_size_y`).
    ///
    /// This checks all 4 corners of the input space, which is sufficient
    /// because affine transforms are linear (extremes occur at corners).
    /// # Errors
    /// Returns an error if the transform maps any corner outside the valid output range.
    pub fn validate_bounds(&self, chip_size_x: u16, chip_size_y: u16) -> Result<(), String> {
        let max_x = i32::from(chip_size_x.saturating_sub(1));
        let max_y = i32::from(chip_size_y.saturating_sub(1));

        // Check all 4 corners of the input space
        let corners = [(0, 0), (max_x, 0), (0, max_y), (max_x, max_y)];

        for (x, y) in corners {
            let gx = self.a * x + self.b * y + self.tx;
            let gy = self.c * x + self.d * y + self.ty;

            if gx < 0 || gx > i32::from(u16::MAX) {
                return Err(format!(
                    "Transform produces out-of-bounds x={gx} for input ({x}, {y}). \
                     Valid range is [0, 65535].",
                ));
            }
            if gy < 0 || gy > i32::from(u16::MAX) {
                return Err(format!(
                    "Transform produces out-of-bounds y={gy} for input ({x}, {y}). \
                     Valid range is [0, 65535].",
                ));
            }
        }

        Ok(())
    }
}

/// Detector configuration for TPX3 processing.
#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct DetectorConfig {
    /// TDC frequency in Hz (default: 60.0 for SNS).
    pub tdc_frequency_hz: f64,
    /// Enable missing TDC correction.
    pub enable_missing_tdc_correction: bool,
    /// Chip size X in pixels (default: 256).
    pub chip_size_x: u16,
    /// Chip size Y in pixels (default: 256).
    pub chip_size_y: u16,
    /// Per-chip affine transforms.
    pub chip_transforms: Vec<ChipTransform>,
}

impl Default for DetectorConfig {
    fn default() -> Self {
        Self::venus_defaults()
    }
}

// Intermediate structs for C++ compatible JSON schema
#[derive(Deserialize, Serialize)]
struct JsonConfig {
    detector: JsonDetector,
}

#[derive(Deserialize, Serialize, Default)]
#[serde(default)]
struct JsonDetector {
    timing: JsonTiming,
    chip_layout: JsonChipLayout,
    chip_transformations: Option<Vec<JsonChipTransform>>,
}

#[derive(Deserialize, Serialize)]
#[serde(default)]
struct JsonTiming {
    tdc_frequency_hz: f64,
    enable_missing_tdc_correction: bool,
}

impl Default for JsonTiming {
    fn default() -> Self {
        Self {
            tdc_frequency_hz: 60.0,
            enable_missing_tdc_correction: true,
        }
    }
}

#[derive(Deserialize, Serialize)]
#[serde(default)]
struct JsonChipLayout {
    chip_size_x: u16,
    chip_size_y: u16,
}

impl Default for JsonChipLayout {
    fn default() -> Self {
        Self {
            chip_size_x: 256,
            chip_size_y: 256,
        }
    }
}

#[derive(Deserialize, Serialize)]
struct JsonChipTransform {
    chip_id: u8,
    matrix: [[i32; 3]; 2],
}

impl DetectorConfig {
    /// Create VENUS/SNS default configuration.
    ///
    /// Uses specific affine transforms for the 4 chips:
    /// - Chip 0: Translation (258, 0)
    /// - Chip 1: Rotation 180 + Translation (513, 513)
    /// - Chip 2: Rotation 180 + Translation (255, 513)
    /// - Chip 3: Identity (0, 0)
    #[must_use]
    pub fn venus_defaults() -> Self {
        let transforms = vec![
            // Chip 0: [[1, 0, 258], [0, 1, 0]]
            ChipTransform {
                a: 1,
                b: 0,
                c: 0,
                d: 1,
                tx: 258,
                ty: 0,
            },
            // Chip 1: [[-1, 0, 513], [0, -1, 513]]
            ChipTransform {
                a: -1,
                b: 0,
                c: 0,
                d: -1,
                tx: 513,
                ty: 513,
            },
            // Chip 2: [[-1, 0, 255], [0, -1, 513]]
            ChipTransform {
                a: -1,
                b: 0,
                c: 0,
                d: -1,
                tx: 255,
                ty: 513,
            },
            // Chip 3: [[1, 0, 0], [0, 1, 0]]
            ChipTransform {
                a: 1,
                b: 0,
                c: 0,
                d: 1,
                tx: 0,
                ty: 0,
            },
        ];

        Self {
            tdc_frequency_hz: 60.0,
            enable_missing_tdc_correction: true,
            chip_size_x: 256,
            chip_size_y: 256,
            chip_transforms: transforms,
        }
    }

    /// Load configuration from a JSON file (C++ compatible schema).
    ///
    /// Validates all chip transforms to ensure they produce valid coordinates.
    ///
    /// # Errors
    /// Returns an error if the file cannot be read or the JSON is invalid.
    pub fn from_file<P: AsRef<Path>>(path: P) -> Result<Self, Box<dyn std::error::Error>> {
        let file = File::open(path)?;
        let reader = BufReader::new(file);
        let json_config: JsonConfig = serde_json::from_reader(reader)?;
        Self::from_json_config(json_config)
    }

    /// Load configuration from a JSON string (C++ compatible schema).
    ///
    /// Validates all chip transforms to ensure they produce valid coordinates.
    ///
    /// # Errors
    /// Returns an error if the JSON is invalid.
    pub fn from_json(json: &str) -> Result<Self, Box<dyn std::error::Error>> {
        let json_config: JsonConfig = serde_json::from_str(json)?;
        Self::from_json_config(json_config)
    }

    /// Serialize configuration to a JSON string (C++ compatible schema).
    ///
    /// # Errors
    /// Returns an error if serialization fails.
    pub fn to_json_string(&self) -> Result<String, Box<dyn std::error::Error>> {
        let transforms = {
            let transforms = self
                .chip_transforms
                .iter()
                .enumerate()
                .map(|(chip_id, transform)| {
                    let chip_id = u8::try_from(chip_id).map_err(|_| {
                        std::io::Error::new(
                            std::io::ErrorKind::InvalidInput,
                            format!("chip_id {chip_id} exceeds u8"),
                        )
                    })?;
                    Ok(JsonChipTransform {
                        chip_id,
                        matrix: [
                            [transform.a, transform.b, transform.tx],
                            [transform.c, transform.d, transform.ty],
                        ],
                    })
                })
                .collect::<Result<Vec<_>, std::io::Error>>()?;
            Some(transforms)
        };

        let json_config = JsonConfig {
            detector: JsonDetector {
                timing: JsonTiming {
                    tdc_frequency_hz: self.tdc_frequency_hz,
                    enable_missing_tdc_correction: self.enable_missing_tdc_correction,
                },
                chip_layout: JsonChipLayout {
                    chip_size_x: self.chip_size_x,
                    chip_size_y: self.chip_size_y,
                },
                chip_transformations: transforms,
            },
        };

        Ok(serde_json::to_string_pretty(&json_config)?)
    }

    /// Save configuration to a JSON file (C++ compatible schema).
    ///
    /// # Errors
    /// Returns an error if serialization or file I/O fails.
    pub fn to_file<P: AsRef<Path>>(&self, path: P) -> Result<(), Box<dyn std::error::Error>> {
        let json = self.to_json_string()?;
        std::fs::write(path, json)?;
        Ok(())
    }

    fn from_json_config(config: JsonConfig) -> Result<Self, Box<dyn std::error::Error>> {
        let detector = config.detector;

        let chip_size_x = detector.chip_layout.chip_size_x;
        let chip_size_y = detector.chip_layout.chip_size_y;

        // Use VENUS defaults if no transformations specified (like C++).
        // An explicit empty list means "no transforms".
        let transforms = match detector.chip_transformations {
            Some(transforms) => {
                if transforms.is_empty() {
                    Vec::new()
                } else {
                    // Find max chip ID to size the vector
                    let max_chip_id = transforms.iter().map(|t| t.chip_id).max().unwrap_or(0);

                    let mut t_vec = vec![ChipTransform::identity(); (max_chip_id + 1) as usize];

                    for t in transforms {
                        let matrix = t.matrix;
                        // C++ matrix: [[a, b, tx], [c, d, ty]]
                        t_vec[t.chip_id as usize] = ChipTransform {
                            a: matrix[0][0],
                            b: matrix[0][1],
                            tx: matrix[0][2],
                            c: matrix[1][0],
                            d: matrix[1][1],
                            ty: matrix[1][2],
                        };
                    }
                    t_vec
                }
            }
            None => {
                // Fall back to VENUS defaults (already validated)
                Self::venus_defaults().chip_transforms
            }
        };

        let config = Self {
            tdc_frequency_hz: detector.timing.tdc_frequency_hz,
            enable_missing_tdc_correction: detector.timing.enable_missing_tdc_correction,
            chip_size_x,
            chip_size_y,
            chip_transforms: transforms,
        };

        // Validate transforms once at load time (not per-hit)
        config.validate_transforms()?;

        Ok(config)
    }

    /// Validate all chip transforms produce valid u16 coordinates.
    ///
    /// This is called automatically when loading from JSON.
    /// For programmatically created configs, call this before processing.
    ///
    /// # Errors
    /// Returns an error if any transform is invalid.
    pub fn validate_transforms(&self) -> Result<(), Box<dyn std::error::Error>> {
        for (i, transform) in self.chip_transforms.iter().enumerate() {
            transform
                .validate_bounds(self.chip_size_x, self.chip_size_y)
                .map_err(|e| format!("Chip {i} transform invalid: {e}"))?;
        }
        Ok(())
    }

    /// TDC period in seconds.
    #[must_use]
    pub fn tdc_period_seconds(&self) -> f64 {
        1.0 / self.tdc_frequency_hz
    }

    /// TDC correction value in 25ns units.
    #[must_use]
    pub fn tdc_correction_25ns(&self) -> u32 {
        let correction = (self.tdc_period_seconds() / 25e-9).round();
        if correction <= 0.0 {
            return 0;
        }
        if correction >= f64::from(u32::MAX) {
            return u32::MAX;
        }
        format!("{correction:.0}")
            .parse::<u32>()
            .unwrap_or(u32::MAX)
    }

    /// Map local chip coordinates to global detector coordinates.
    ///
    /// Uses the configured affine transform for the given chip ID.
    /// If chip ID is out of bounds, returns local coordinates as-is (identity).
    #[must_use]
    pub fn map_chip_to_global(&self, chip_id: u8, x: u16, y: u16) -> (u16, u16) {
        if let Some(transform) = self.chip_transforms.get(chip_id as usize) {
            transform.apply(x, y)
        } else {
            (x, y)
        }
    }

    /// Calculate detector dimensions from chip layout and transforms.
    ///
    /// Returns `(width, height)` in pixels sized to include all transformed
    /// chip coordinates, preserving gaps/offsets introduced by transforms.
    #[must_use]
    pub fn detector_dimensions(&self) -> (usize, usize) {
        if self.chip_transforms.is_empty() {
            return (usize::from(self.chip_size_x), usize::from(self.chip_size_y));
        }

        let max_x = i32::from(self.chip_size_x.saturating_sub(1));
        let max_y = i32::from(self.chip_size_y.saturating_sub(1));
        let corners = [(0, 0), (max_x, 0), (0, max_y), (max_x, max_y)];

        let mut max_global_x = 0i32;
        let mut max_global_y = 0i32;

        for transform in &self.chip_transforms {
            for (x, y) in corners {
                let gx = transform.a * x + transform.b * y + transform.tx;
                let gy = transform.c * x + transform.d * y + transform.ty;
                if gx > max_global_x {
                    max_global_x = gx;
                }
                if gy > max_global_y {
                    max_global_y = gy;
                }
            }
        }

        let max_x = usize::try_from(max_global_x.max(0)).unwrap_or(0);
        let max_y = usize::try_from(max_global_y.max(0)).unwrap_or(0);
        (max_x.saturating_add(1), max_y.saturating_add(1))
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use serde_json::Value;

    fn assert_f64_eq(actual: f64, expected: f64) {
        assert!(
            (actual - expected).abs() <= f64::EPSILON,
            "expected {expected}, got {actual}"
        );
    }

    #[test]
    fn test_venus_defaults() {
        let config = DetectorConfig::venus_defaults();
        assert_f64_eq(config.tdc_frequency_hz, 60.0);
        assert!(config.enable_missing_tdc_correction);
        assert_eq!(config.chip_transforms.len(), 4);
    }

    #[test]
    fn test_venus_detector_dimensions() {
        let config = DetectorConfig::venus_defaults();
        let (width, height) = config.detector_dimensions();
        assert_eq!((width, height), (514, 514));
    }

    #[test]
    fn test_tdc_correction() {
        let config = DetectorConfig::venus_defaults();
        // 1/60 Hz = 16.67ms, in 25ns units = 666,667
        let correction = config.tdc_correction_25ns();
        assert!(correction > 600_000 && correction < 700_000);
    }

    #[test]
    fn test_venus_chip_mappings() {
        let config = DetectorConfig::venus_defaults();

        // Chip 0: local (100, 100) -> global (358, 100)
        // x = 1*100 + 0*100 + 258 = 358
        // y = 0*100 + 1*100 + 0 = 100
        let (gx, gy) = config.map_chip_to_global(0, 100, 100);
        assert_eq!((gx, gy), (358, 100));

        // Chip 1: local (100, 100) -> global (413, 413)
        // x = -1*100 + 0*100 + 513 = 413
        // y = 0*100 + -1*100 + 513 = 413
        let (gx, gy) = config.map_chip_to_global(1, 100, 100);
        assert_eq!((gx, gy), (413, 413));

        // Chip 2: local (100, 100) -> global (155, 413)
        // x = -1*100 + 0*100 + 255 = 155
        // y = 0*100 + -1*100 + 513 = 413
        let (gx, gy) = config.map_chip_to_global(2, 100, 100);
        assert_eq!((gx, gy), (155, 413));

        // Chip 3: local (100, 100) -> global (100, 100)
        // x = 1*100 + 0*100 + 0 = 100
        // y = 0*100 + 1*100 + 0 = 100
        let (gx, gy) = config.map_chip_to_global(3, 100, 100);
        assert_eq!((gx, gy), (100, 100));
    }
    #[test]
    fn test_json_loading() {
        let json = r#"{
            "detector": {
                "timing": {
                    "tdc_frequency_hz": 14.0,
                    "enable_missing_tdc_correction": false
                },
                "chip_layout": {
                    "chip_size_x": 256,
                    "chip_size_y": 256
                },
                "chip_transformations": [
                    {
                        "chip_id": 0,
                        "matrix": [[1, 0, 100], [0, 1, 200]]
                    },
                    {
                        "chip_id": 1,
                        "matrix": [[-1, 0, 300], [0, -1, 400]]
                    }
                ]
            }
        }"#;

        let config = DetectorConfig::from_json(json).expect("Failed to parse JSON");

        assert_f64_eq(config.tdc_frequency_hz, 14.0);
        assert!(!config.enable_missing_tdc_correction);
        assert_eq!(config.chip_size_x, 256);
        assert_eq!(config.chip_size_y, 256);
        assert_eq!(config.chip_transforms.len(), 2);

        // Check Chip 0: Identity + Translation (100, 200)
        let (gx, gy) = config.map_chip_to_global(0, 10, 20);
        // x = 1*10 + 0*20 + 100 = 110
        // y = 0*10 + 1*20 + 200 = 220
        assert_eq!((gx, gy), (110, 220));

        // Check Chip 1: Rotation 180 + Translation (300, 400)
        let (gx, gy) = config.map_chip_to_global(1, 10, 20);
        // x = -1*10 + 0*20 + 300 = 290
        // y = 0*10 + -1*20 + 400 = 380
        assert_eq!((gx, gy), (290, 380));
    }
    #[test]
    fn test_json_partial_config_frequency_only() {
        // User only wants to change frequency (common ESS use case)
        let json = r#"{
            "detector": {
                "timing": {
                    "tdc_frequency_hz": 14.0
                }
            }
        }"#;

        let config = DetectorConfig::from_json(json).expect("Should parse partial config");

        assert_f64_eq(config.tdc_frequency_hz, 14.0); // Changed
        assert!(config.enable_missing_tdc_correction); // Default: true
        assert_eq!(config.chip_size_x, 256); // Default
        assert_eq!(config.chip_size_y, 256); // Default
        assert_eq!(config.chip_transforms.len(), 4); // VENUS defaults
    }

    #[test]
    fn test_json_empty_detector() {
        // Minimal config - just use all defaults
        let json = r#"{ "detector": {} }"#;

        let config = DetectorConfig::from_json(json).expect("Should parse minimal config");

        assert_f64_eq(config.tdc_frequency_hz, 60.0); // VENUS default
        assert_eq!(config.chip_transforms.len(), 4); // VENUS defaults
    }

    #[test]
    fn test_json_custom_transforms_only() {
        // User only specifies chip transforms (detector swap)
        let json = r#"{
            "detector": {
                "chip_transformations": [
                    {"chip_id": 0, "matrix": [[1, 0, 260], [0, 1, 0]]}
                ]
            }
        }"#;

        let config = DetectorConfig::from_json(json).expect("Should parse");

        assert_f64_eq(config.tdc_frequency_hz, 60.0); // Default
        assert_eq!(config.chip_transforms[0].tx, 260); // Custom
    }

    fn assert_transform_eq(actual: &ChipTransform, expected: &ChipTransform) {
        assert_eq!(actual.a, expected.a);
        assert_eq!(actual.b, expected.b);
        assert_eq!(actual.c, expected.c);
        assert_eq!(actual.d, expected.d);
        assert_eq!(actual.tx, expected.tx);
        assert_eq!(actual.ty, expected.ty);
    }

    #[test]
    fn test_json_roundtrip_serialization() {
        let config = DetectorConfig {
            tdc_frequency_hz: 14.0,
            enable_missing_tdc_correction: false,
            chip_size_x: 128,
            chip_size_y: 64,
            chip_transforms: vec![
                ChipTransform {
                    a: 1,
                    b: 0,
                    c: 0,
                    d: 1,
                    tx: 10,
                    ty: 20,
                },
                ChipTransform {
                    a: -1,
                    b: 0,
                    c: 0,
                    d: -1,
                    tx: 127,
                    ty: 63,
                },
            ],
        };

        let json = config.to_json_string().expect("serialize config");
        let decoded = DetectorConfig::from_json(&json).expect("roundtrip decode");

        assert_f64_eq(decoded.tdc_frequency_hz, config.tdc_frequency_hz);
        assert_eq!(
            decoded.enable_missing_tdc_correction,
            config.enable_missing_tdc_correction
        );
        assert_eq!(decoded.chip_size_x, config.chip_size_x);
        assert_eq!(decoded.chip_size_y, config.chip_size_y);
        assert_eq!(decoded.chip_transforms.len(), config.chip_transforms.len());
        for (actual, expected) in decoded
            .chip_transforms
            .iter()
            .zip(config.chip_transforms.iter())
        {
            assert_transform_eq(actual, expected);
        }
    }

    #[test]
    fn test_json_serialization_schema() {
        let config = DetectorConfig::venus_defaults();
        let json = config.to_json_string().expect("serialize config");
        let value: Value = serde_json::from_str(&json).expect("parse json");

        let detector = value
            .get("detector")
            .and_then(|v| v.as_object())
            .expect("detector object");
        let timing = detector
            .get("timing")
            .and_then(|v| v.as_object())
            .expect("timing object");
        let layout = detector
            .get("chip_layout")
            .and_then(|v| v.as_object())
            .expect("chip_layout object");

        assert!(timing.contains_key("tdc_frequency_hz"));
        assert!(timing.contains_key("enable_missing_tdc_correction"));
        assert!(layout.contains_key("chip_size_x"));
        assert!(layout.contains_key("chip_size_y"));

        let transforms = detector
            .get("chip_transformations")
            .and_then(|v| v.as_array())
            .expect("chip_transformations array");
        assert_eq!(transforms.len(), config.chip_transforms.len());
        let first = transforms[0].as_object().expect("transform object");
        assert!(first.contains_key("chip_id"));
        let matrix = first
            .get("matrix")
            .and_then(|v| v.as_array())
            .expect("matrix array");
        assert_eq!(matrix.len(), 2);
        assert_eq!(matrix[0].as_array().expect("matrix row").len(), 3);
        assert_eq!(matrix[1].as_array().expect("matrix row").len(), 3);
    }

    #[test]
    fn test_json_empty_transforms_serialization() {
        let config = DetectorConfig {
            tdc_frequency_hz: 42.0,
            enable_missing_tdc_correction: true,
            chip_size_x: 256,
            chip_size_y: 256,
            chip_transforms: Vec::new(),
        };

        let json = config.to_json_string().expect("serialize config");
        let value: Value = serde_json::from_str(&json).expect("parse json");
        let detector = value
            .get("detector")
            .and_then(|v| v.as_object())
            .expect("detector object");

        let transforms = detector
            .get("chip_transformations")
            .and_then(|v| v.as_array())
            .expect("chip_transformations array");
        assert!(transforms.is_empty());

        let decoded = DetectorConfig::from_json(&json).expect("decode");
        assert_eq!(decoded.chip_size_x, 256);
        assert_eq!(decoded.chip_size_y, 256);
        assert!(decoded.chip_transforms.is_empty());
    }

    #[test]
    fn test_venus_transforms_valid() {
        // VENUS defaults should always pass validation
        let config = DetectorConfig::venus_defaults();
        assert!(config.validate_transforms().is_ok());
    }

    #[test]
    fn test_invalid_transform_negative_output() {
        // Transform that produces negative coordinates should be rejected
        // a=-1, tx=50 means x=100 -> gx = -100 + 50 = -50 (invalid!)
        let json = r#"{
            "detector": {
                "chip_transformations": [
                    {"chip_id": 0, "matrix": [[-1, 0, 50], [0, 1, 0]]}
                ]
            }
        }"#;

        let result = DetectorConfig::from_json(json);
        assert!(result.is_err());
        let err = result.unwrap_err().to_string();
        assert!(
            err.contains("out-of-bounds"),
            "Error should mention out-of-bounds: {err}"
        );
    }

    #[test]
    fn test_transform_validate_bounds_directly() {
        // Valid identity transform
        let identity = ChipTransform::identity();
        assert!(identity.validate_bounds(256, 256).is_ok());

        // Valid VENUS chip 1 transform (180° rotation)
        let chip1 = ChipTransform {
            a: -1,
            b: 0,
            c: 0,
            d: -1,
            tx: 513,
            ty: 513,
        };
        assert!(chip1.validate_bounds(256, 256).is_ok());

        // Invalid: negative output at corner (255, 0)
        // gx = -1*255 + 0*0 + 100 = -155
        let invalid = ChipTransform {
            a: -1,
            b: 0,
            c: 0,
            d: 1,
            tx: 100,
            ty: 0,
        };
        assert!(invalid.validate_bounds(256, 256).is_err());
    }
    #[test]
    fn test_json_accepts_non_square_chips() {
        let json = r#"{
            "detector": {
                "chip_layout": {
                    "chip_size_x": 256,
                    "chip_size_y": 128
                }
            }
        }"#;

        let config = DetectorConfig::from_json(json).expect("Should accept non-square chips");
        assert_eq!(config.chip_size_x, 256);
        assert_eq!(config.chip_size_y, 128);
    }
}