rustpbx 0.4.6

A SIP PBX implementation in Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
use crate::media::StreamWriter;
use crate::media::negotiate::NegotiatedLegProfile;
use crate::media::wav_writer::CodecWavWriter;
use anyhow::Result;
use audio_codec::{CodecType, Decoder, Encoder, create_decoder, create_encoder};
use bytes::Bytes;
use rustrtc::media::MediaSample;
use serde::{Deserialize, Serialize};
use std::collections::{BTreeMap, HashMap};
use std::fs::File;
use std::path::PathBuf;
use std::time::{Duration, Instant};
use tracing::debug;

#[derive(Debug, Deserialize, Serialize, Clone)]
#[serde(rename_all = "camelCase")]
#[serde(default)]
pub struct RecorderOption {
    #[serde(default)]
    pub recorder_file: String,
    #[serde(default)]
    pub samplerate: u32,
    #[serde(default)]
    pub ptime: u32,
}

impl RecorderOption {
    pub fn new(recorder_file: String) -> Self {
        Self {
            recorder_file,
            ..Default::default()
        }
    }
}

impl Default for RecorderOption {
    fn default() -> Self {
        Self {
            recorder_file: "".to_string(),
            samplerate: 16000,
            ptime: 200,
        }
    }
}

#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub enum Leg {
    A,
    B,
}

#[derive(Debug, Clone, Copy)]
struct DtmfEventState {
    digit_code: u8,
    rtp_timestamp: u32,
    absolute_timestamp: u32,
    duration_samples: u32,
}

pub struct Recorder {
    pub path: String,
    pub codec: CodecType,
    written_bytes: u32,
    sample_rate: u32,
    channels: u16,
    dtmf_gen: DtmfGenerator,
    encoder: Option<Box<dyn Encoder>>,

    // Dynamic decoders and resamplers per leg and payload type
    decoders: HashMap<(Leg, u8), Box<dyn Decoder>>,
    resamplers: HashMap<(Leg, u8), audio_codec::Resampler>,

    // Buffers store encoded data indexed by absolute recording timestamp (in samples)
    buffer_a: BTreeMap<u32, Bytes>,
    buffer_b: BTreeMap<u32, Bytes>,

    start_instant: Instant,
    last_flush: Instant,

    base_timestamp_a: Option<u32>,
    base_timestamp_b: Option<u32>,
    start_offset_a: u32, // in samples
    start_offset_b: u32, // in samples
    last_ssrc_a: Option<u32>,
    last_ssrc_b: Option<u32>,
    profile_a: NegotiatedLegProfile,
    profile_b: NegotiatedLegProfile,
    dtmf_state_a: Option<DtmfEventState>,
    dtmf_state_b: Option<DtmfEventState>,

    next_flush_ts: u32, // The next timestamp to be flushed
    ptime: Duration,

    written_samples: u64,
    writer: Box<dyn StreamWriter>,
}

impl Recorder {
    pub fn new(path: &str, codec: CodecType) -> Result<Self> {
        // ensure the directory exists
        if let Some(parent) = PathBuf::from(path).parent() {
            std::fs::create_dir_all(parent).ok();
        }
        let file = File::create(path)
            .map_err(|e| anyhow::anyhow!("Failed to create recorder file {}: {}", path, e))?;

        let src_codec = codec;
        let codec = match codec {
            CodecType::Opus => CodecType::PCMU,
            CodecType::G722 => CodecType::PCMU,
            _ => codec,
        };

        let sample_rate = codec.samplerate();
        let encoder = Some(create_encoder(codec));
        debug!(
            "Creating recorder: path={}, src_codec={:?} codec={:?}",
            path, src_codec, codec
        );
        // PCMU/PCMA are mono codecs (1 channel), we force stereo (2 channels) for better separation
        // of leg A and leg B audio in the recording.
        let channels = 2;
        let mut writer = Box::new(CodecWavWriter::new(file, sample_rate, channels, Some(codec)));
        writer.write_header()?;

        Ok(Self {
            path: path.to_string(),
            codec,
            written_bytes: 0,
            sample_rate,
            channels,
            dtmf_gen: DtmfGenerator::new(sample_rate),
            encoder,
            decoders: HashMap::new(),
            resamplers: HashMap::new(),
            buffer_a: BTreeMap::new(),
            buffer_b: BTreeMap::new(),
            start_instant: Instant::now(),
            last_flush: Instant::now(),
            base_timestamp_a: None,
            base_timestamp_b: None,
            start_offset_a: 0,
            start_offset_b: 0,
            last_ssrc_a: None,
            last_ssrc_b: None,
            profile_a: NegotiatedLegProfile::default(),
            profile_b: NegotiatedLegProfile::default(),
            dtmf_state_a: None,
            dtmf_state_b: None,
            next_flush_ts: 0,
            written_samples: 0,
            writer,
            ptime: Duration::from_millis(200),
        })
    }

    pub fn set_leg_profile(&mut self, leg: Leg, profile: NegotiatedLegProfile) {
        match leg {
            Leg::A => self.profile_a = profile,
            Leg::B => self.profile_b = profile,
        }
    }

    fn profile_for_leg(&self, leg: Leg) -> &NegotiatedLegProfile {
        match leg {
            Leg::A => &self.profile_a,
            Leg::B => &self.profile_b,
        }
    }

    pub fn write_sample(
        &mut self,
        leg: Leg,
        sample: &MediaSample,
        dtmf_pt: Option<u8>,
        dtmf_clock_rate: Option<u32>,
        codec_hint: Option<CodecType>,
    ) -> Result<()> {
        let frame = match sample {
            MediaSample::Audio(frame) => frame,
            _ => return Ok(()),
        };

        let (profile_audio_pt, profile_audio_codec, profile_dtmf_pt, profile_dtmf_clock_rate) = {
            let profile = self.profile_for_leg(leg);
            (
                profile.audio.as_ref().map(|codec| codec.payload_type),
                profile.audio.as_ref().map(|codec| codec.codec),
                profile.dtmf.as_ref().map(|codec| codec.payload_type),
                profile.dtmf.as_ref().map(|codec| codec.clock_rate),
            )
        };
        let dtmf_pt = dtmf_pt.or(profile_dtmf_pt);
        let dtmf_clock_rate = dtmf_clock_rate.or(profile_dtmf_clock_rate);
        if let (Some(pt), Some(dpt)) = (frame.payload_type, dtmf_pt)
            && pt == dpt
        {
            return self.write_dtmf_payload(
                leg,
                &frame.data,
                frame.rtp_timestamp,
                dtmf_clock_rate.unwrap_or(self.sample_rate),
            );
        }

        let codec_hint = codec_hint.or(match (frame.payload_type, profile_audio_pt) {
            (Some(pt), Some(audio_pt)) if pt == audio_pt => profile_audio_codec,
            _ => None,
        });

        let decoder_type = match codec_hint {
            Some(codec) => codec,
            None => CodecType::try_from(frame.payload_type.unwrap_or(0))?,
        };
        let packet_ssrc = frame.raw_packet.as_ref().map(|packet| packet.header.ssrc);
        let (mut encoded, frame_clock_rate) = match sample {
            MediaSample::Audio(frame) => match frame.raw_packet.as_ref() {
                Some(packet) => (
                    Bytes::copy_from_slice(&packet.payload),
                    decoder_type.clock_rate().max(1),
                ),
                None => (frame.data.clone(), frame.clock_rate.max(1)),
            },
            _ => return Ok(()),
        };

        if decoder_type != self.codec {
            let decoder = self
                .decoders
                .entry((leg, decoder_type.payload_type()))
                .or_insert_with(|| create_decoder(decoder_type));
            let pcm = decoder.decode(&encoded);
            let resampler = self
                .resamplers
                .entry((leg, decoder_type.payload_type()))
                .or_insert_with(|| {
                    audio_codec::Resampler::new(
                        decoder.sample_rate() as usize,
                        self.sample_rate as usize,
                    )
                });
            let pcm = resampler.resample(&pcm);
            encoded = if let Some(enc) = self.encoder.as_mut() {
                enc.encode(&pcm)
            } else {
                audio_codec::samples_to_bytes(&pcm)
            }
            .into();
        }
        self.maybe_reset_leg_timeline(
            leg,
            frame.rtp_timestamp,
            frame_clock_rate,
            packet_ssrc,
            &encoded,
        );
        let absolute_ts = self.timestamp_to_absolute(leg, frame.rtp_timestamp, frame_clock_rate);
        self.insert_audio_block(leg, absolute_ts, encoded);
        if self.last_flush.elapsed() >= self.ptime {
            self.flush()?;
        }
        Ok(())
    }

    fn maybe_reset_leg_timeline(
        &mut self,
        leg: Leg,
        rtp_timestamp: u32,
        frame_clock_rate: u32,
        packet_ssrc: Option<u32>,
        encoded: &[u8],
    ) {
        let leg_end = self.leg_end_ts(leg);
        let (base_timestamp, start_offset, last_ssrc) = match leg {
            Leg::A => (
                &mut self.base_timestamp_a,
                &mut self.start_offset_a,
                &mut self.last_ssrc_a,
            ),
            Leg::B => (
                &mut self.base_timestamp_b,
                &mut self.start_offset_b,
                &mut self.last_ssrc_b,
            ),
        };

        let Some(base) = *base_timestamp else {
            *last_ssrc = packet_ssrc;
            return;
        };

        let projected = start_offset.wrapping_add(
            ((rtp_timestamp.wrapping_sub(base)) as u64 * self.sample_rate as u64
                / frame_clock_rate.max(1) as u64) as u32,
        );
        let max_gap = self.sample_rate * 2;
        let ssrc_changed =
            matches!((*last_ssrc, packet_ssrc), (Some(prev), Some(curr)) if prev != curr);
        let timestamp_far_ahead = projected > leg_end.saturating_add(max_gap);
        let timestamp_far_behind = leg_end > projected.saturating_add(max_gap);
        let prev_ssrc = *last_ssrc;

        if ssrc_changed || timestamp_far_ahead || timestamp_far_behind {
            debug!(
                recorder_path = %self.path,
                leg = ?leg,
                base_timestamp = base,
                rtp_timestamp,
                frame_clock_rate,
                prev_ssrc,
                packet_ssrc,
                leg_end,
                projected,
                max_gap,
                ssrc_changed,
                timestamp_far_ahead,
                timestamp_far_behind,
                encoded_len = encoded.len(),
                "Recorder timeline discontinuity detected, resetting leg base"
            );
            *base_timestamp = Some(rtp_timestamp);
            *start_offset = leg_end;
        }

        *last_ssrc = packet_ssrc.or(*last_ssrc);
    }

    fn leg_end_ts(&self, leg: Leg) -> u32 {
        let (samples_per_block, bytes_per_block) = self.block_info();
        let buffered_end = match leg {
            Leg::A => self.buffer_a.last_key_value(),
            Leg::B => self.buffer_b.last_key_value(),
        }
        .map(|(k, v)| k + (v.len() / bytes_per_block) as u32 * samples_per_block)
        .unwrap_or(self.next_flush_ts);

        buffered_end.max(self.next_flush_ts)
    }

    fn block_span_samples(&self, data: &[u8]) -> u32 {
        let (samples_per_block, bytes_per_block) = self.block_info();
        (data.len() / bytes_per_block) as u32 * samples_per_block
    }

    fn timestamp_to_absolute(&mut self, leg: Leg, timestamp: u32, clock_rate: u32) -> u32 {
        let timestamp_clock_rate = clock_rate.max(1);
        match leg {
            Leg::A => {
                if self.base_timestamp_a.is_none() {
                    self.base_timestamp_a = Some(timestamp);
                    self.start_offset_a = (self.start_instant.elapsed().as_millis() as u64
                        * self.sample_rate as u64
                        / 1000) as u32;
                }
                let relative = timestamp.wrapping_sub(self.base_timestamp_a.unwrap());
                let scaled_relative = (relative as u64 * self.sample_rate as u64
                    / timestamp_clock_rate as u64) as u32;
                self.start_offset_a.wrapping_add(scaled_relative)
            }
            Leg::B => {
                if self.base_timestamp_b.is_none() {
                    self.base_timestamp_b = Some(timestamp);
                    self.start_offset_b = (self.start_instant.elapsed().as_millis() as u64
                        * self.sample_rate as u64
                        / 1000) as u32;
                }
                let relative = timestamp.wrapping_sub(self.base_timestamp_b.unwrap());
                let scaled_relative = (relative as u64 * self.sample_rate as u64
                    / timestamp_clock_rate as u64) as u32;
                self.start_offset_b.wrapping_add(scaled_relative)
            }
        }
    }

    fn active_dtmf_state(&self, leg: Leg) -> Option<DtmfEventState> {
        match leg {
            Leg::A => self.dtmf_state_a,
            Leg::B => self.dtmf_state_b,
        }
    }

    fn set_dtmf_state(&mut self, leg: Leg, state: DtmfEventState) {
        match leg {
            Leg::A => self.dtmf_state_a = Some(state),
            Leg::B => self.dtmf_state_b = Some(state),
        }
    }

    fn trim_front(&self, data: &Bytes, drop_samples: u32) -> Option<(u32, Bytes)> {
        let (samples_per_block, bytes_per_block) = self.block_info();
        let drop_blocks = drop_samples.div_ceil(samples_per_block) as usize;
        let drop_bytes = drop_blocks * bytes_per_block;
        if drop_bytes >= data.len() {
            None
        } else {
            Some((
                drop_blocks as u32 * samples_per_block,
                Bytes::copy_from_slice(&data[drop_bytes..]),
            ))
        }
    }

    fn trim_back(&self, data: &Bytes, keep_samples: u32) -> Option<Bytes> {
        let (samples_per_block, bytes_per_block) = self.block_info();
        let keep_blocks = (keep_samples / samples_per_block) as usize;
        let keep_bytes = keep_blocks * bytes_per_block;
        if keep_bytes == 0 {
            None
        } else {
            Some(Bytes::copy_from_slice(&data[..keep_bytes.min(data.len())]))
        }
    }

    fn overlay_dtmf_range(&mut self, leg: Leg, start_ts: u32, end_ts: u32, encoded: Bytes) {
        let overlapping_keys: Vec<u32> = match leg {
            Leg::A => self.buffer_a.range(..end_ts).map(|(k, _)| *k).collect(),
            Leg::B => self.buffer_b.range(..end_ts).map(|(k, _)| *k).collect(),
        };

        for key in overlapping_keys {
            let data = match leg {
                Leg::A => self.buffer_a.remove(&key),
                Leg::B => self.buffer_b.remove(&key),
            };
            let Some(data) = data else {
                continue;
            };
            let block_end = key.saturating_add(self.block_span_samples(&data));
            if block_end <= start_ts || key >= end_ts {
                match leg {
                    Leg::A => {
                        self.buffer_a.insert(key, data);
                    }
                    Leg::B => {
                        self.buffer_b.insert(key, data);
                    }
                }
                continue;
            }

            if key < start_ts
                && let Some(prefix) = self.trim_back(&data, start_ts - key)
            {
                match leg {
                    Leg::A => {
                        self.buffer_a.insert(key, prefix);
                    }
                    Leg::B => {
                        self.buffer_b.insert(key, prefix);
                    }
                }
            }

            if block_end > end_ts
                && let Some((trimmed_samples, suffix)) =
                    self.trim_front(&data, end_ts.saturating_sub(key))
            {
                let suffix_ts = key.saturating_add(trimmed_samples);
                match leg {
                    Leg::A => {
                        self.buffer_a.insert(suffix_ts, suffix);
                    }
                    Leg::B => {
                        self.buffer_b.insert(suffix_ts, suffix);
                    }
                }
            }
        }

        match leg {
            Leg::A => {
                self.buffer_a.insert(start_ts, encoded);
            }
            Leg::B => {
                self.buffer_b.insert(start_ts, encoded);
            }
        }
    }

    fn insert_audio_block(&mut self, leg: Leg, start_ts: u32, encoded: Bytes) {
        let mut inserts = vec![(start_ts, encoded)];
        if let Some(state) = self.active_dtmf_state(leg) {
            let dtmf_start = state.absolute_timestamp;
            let dtmf_end = state
                .absolute_timestamp
                .saturating_add(state.duration_samples);
            let mut next_inserts = Vec::new();

            for (ts, data) in inserts {
                let block_end = ts.saturating_add(self.block_span_samples(&data));
                if block_end <= dtmf_start || ts >= dtmf_end {
                    next_inserts.push((ts, data));
                    continue;
                }

                if ts < dtmf_start
                    && let Some(prefix) = self.trim_back(&data, dtmf_start - ts)
                {
                    next_inserts.push((ts, prefix));
                }

                if block_end > dtmf_end
                    && let Some((trimmed_samples, suffix)) =
                        self.trim_front(&data, dtmf_end.saturating_sub(ts))
                {
                    next_inserts.push((ts.saturating_add(trimmed_samples), suffix));
                }
            }
            inserts = next_inserts;
        }

        for (ts, data) in inserts {
            match leg {
                Leg::A => {
                    self.buffer_a.insert(ts, data);
                }
                Leg::B => {
                    self.buffer_b.insert(ts, data);
                }
            }
        }
    }

    pub fn write_dtmf_payload(
        &mut self,
        leg: Leg,
        payload: &[u8],
        timestamp: u32,
        clock_rate: u32,
    ) -> Result<()> {
        if payload.len() < 4 {
            return Ok(());
        }
        let digit_code = payload[0];
        let Some(digit) = crate::media::telephone_event::dtmf_code_to_char(digit_code) else {
            return Ok(());
        };

        let end_bit = (payload[1] & 0x80) != 0;
        let duration = u16::from_be_bytes([payload[2], payload[3]]) as u32;
        let duration_samples =
            (duration as u64 * self.sample_rate as u64).div_ceil(clock_rate.max(1) as u64) as u32;
        let duration_ms = (duration as u64 * 1000).div_ceil(clock_rate.max(1) as u64) as u32;

        if let Some(state) = self.active_dtmf_state(leg)
            && state.digit_code == digit_code
            && state.rtp_timestamp == timestamp
            && duration_samples <= state.duration_samples
        {
            return Ok(());
        }

        let absolute_ts = self.timestamp_to_absolute(leg, timestamp, clock_rate);

        debug!(
            leg = ?leg,
            digit = %digit,
            duration_ms = %duration_ms,
            duration_samples,
            "Recording DTMF digit"
        );
        let pcm = self
            .dtmf_gen
            .generate_samples(digit, duration_samples as usize);
        let encoded = if let Some(enc) = self.encoder.as_mut() {
            Bytes::from(enc.encode(&pcm))
        } else {
            Bytes::from(audio_codec::samples_to_bytes(&pcm))
        };
        let end_ts = absolute_ts.saturating_add(duration_samples);
        self.overlay_dtmf_range(leg, absolute_ts, end_ts, encoded);

        self.set_dtmf_state(
            leg,
            DtmfEventState {
                digit_code,
                rtp_timestamp: timestamp,
                absolute_timestamp: absolute_ts,
                duration_samples,
            },
        );

        if end_bit {
            self.flush()?;
        }
        Ok(())
    }

    pub fn write_dtmf(
        &mut self,
        leg: Leg,
        digit: char,
        duration_ms: u32,
        timestamp: Option<u32>,
        timestamp_clock_rate: Option<u32>,
    ) -> Result<()> {
        let pcm = self.dtmf_gen.generate(digit, duration_ms);
        debug!(
            "Recording DTMF: leg={:?}, digit={}, duration={}ms, samples={}",
            leg,
            digit,
            duration_ms,
            pcm.len()
        );

        // Determine absolute timestamp
        let ts = if let Some(t) = timestamp {
            self.timestamp_to_absolute(leg, t, timestamp_clock_rate.unwrap_or(self.sample_rate))
        } else {
            // If no timestamp provided, append to the end of the buffer
            match leg {
                Leg::A => self
                    .buffer_a
                    .last_key_value()
                    .map(|(k, v)| k + v.len() as u32)
                    .unwrap_or(self.next_flush_ts),
                Leg::B => self
                    .buffer_b
                    .last_key_value()
                    .map(|(k, v)| k + v.len() as u32)
                    .unwrap_or(self.next_flush_ts),
            }
        };

        let encoded = if let Some(enc) = self.encoder.as_mut() {
            Bytes::from(enc.encode(&pcm))
        } else {
            Bytes::from(audio_codec::samples_to_bytes(&pcm))
        };

        let end_ts = ts.saturating_add(self.block_span_samples(&encoded));
        self.overlay_dtmf_range(leg, ts, end_ts, encoded);

        self.flush()?;
        Ok(())
    }

    fn flush(&mut self) -> Result<()> {
        self.last_flush = Instant::now();

        let max_ts_a = self
            .buffer_a
            .last_key_value()
            .map(|(k, v)| {
                let (_, bytes_per_block) = self.block_info();
                let samples_per_block = self.samples_per_block();
                k + (v.len() / bytes_per_block) as u32 * samples_per_block
            })
            .unwrap_or(0);
        let max_ts_b = self
            .buffer_b
            .last_key_value()
            .map(|(k, v)| {
                let (_, bytes_per_block) = self.block_info();
                let samples_per_block = self.samples_per_block();
                k + (v.len() / bytes_per_block) as u32 * samples_per_block
            })
            .unwrap_or(0);
        let max_available_ts = max_ts_a.max(max_ts_b);

        if max_available_ts <= self.next_flush_ts {
            return Ok(());
        }

        let mut flush_len = max_available_ts - self.next_flush_ts;

        // Limit flush length to prevent huge memory allocation (e.g., 10 seconds max)
        let max_flush_samples = self.sample_rate * 10;
        if flush_len > max_flush_samples {
            flush_len = max_flush_samples;
        }

        let (samples_per_block, _) = self.block_info();
        flush_len = (flush_len / samples_per_block) * samples_per_block;

        if flush_len == 0 {
            return Ok(());
        }

        let data_a = self.get_leg_data(Leg::A, flush_len)?;
        let data_b = self.get_leg_data(Leg::B, flush_len)?;

        self.next_flush_ts += flush_len;

        let output = if self.channels == 1 {
            // Mono: mix both legs
            self.mix(&data_a, &data_b)?
        } else {
            // Stereo: interleave both legs
            self.interleave(&data_a, &data_b)?
        };

        self.writer.write_packet(&output, flush_len as usize)?;
        self.written_bytes += output.len() as u32;
        self.written_samples += flush_len as u64;

        Ok(())
    }

    pub fn finalize(&mut self) -> Result<()> {
        self.flush()?;
        self.writer.finalize()?;
        Ok(())
    }

    fn block_info(&self) -> (u32, usize) {
        match self.codec {
            CodecType::G729 => (80, 10),
            CodecType::PCMU | CodecType::PCMA => (1, 1),
            CodecType::G722 => (2, 1),
            CodecType::Opus => (1, 2), // Buffering PCM
            _ => (1, 2),               // PCM
        }
    }

    fn samples_per_block(&self) -> u32 {
        self.block_info().0
    }

    fn get_silence_bytes(&mut self, _leg: Leg, blocks: usize) -> Result<Bytes> {
        let (samples_per_block, _) = self.block_info();
        let mut num_samples = (blocks as u32 * samples_per_block) as usize;

        // Safety cap: never allocate more than 10 seconds of silence in one go
        let max_samples = (self.sample_rate * 10) as usize;
        if num_samples > max_samples {
            num_samples = max_samples;
        }

        let silence_pcm = vec![0i16; num_samples];

        if let Some(enc) = self.encoder.as_mut() {
            Ok(enc.encode(&silence_pcm).into())
        } else {
            Ok(audio_codec::samples_to_bytes(&silence_pcm).into())
        }
    }

    fn get_leg_data(&mut self, leg: Leg, samples: u32) -> Result<Vec<u8>> {
        let (samples_per_block, bytes_per_block) = self.block_info();
        let num_blocks = samples / samples_per_block;
        let mut result = Vec::with_capacity((num_blocks * bytes_per_block as u32) as usize);

        let mut current_ts = self.next_flush_ts;
        let flush_to = self.next_flush_ts + samples;

        while current_ts < flush_to {
            let next_ts = match leg {
                Leg::A => self.buffer_a.first_key_value().map(|(k, _)| *k),
                Leg::B => self.buffer_b.first_key_value().map(|(k, _)| *k),
            };

            if let Some(ts) = next_ts {
                if ts < flush_to {
                    // Check for gap
                    if ts > current_ts {
                        let mut gap_samples = ts - current_ts;
                        let max_gap = self.sample_rate; // Max 1 second of silence
                        if gap_samples > max_gap {
                            debug!(
                                "Recorder gap too large: {} samples, capping to {}",
                                gap_samples, max_gap
                            );
                            gap_samples = max_gap;
                        }
                        let gap_blocks = gap_samples / samples_per_block;
                        result.extend(self.get_silence_bytes(leg, gap_blocks as usize)?);
                        current_ts = ts;
                    }

                    let data = match leg {
                        Leg::A => self.buffer_a.pop_first().unwrap().1,
                        Leg::B => self.buffer_b.pop_first().unwrap().1,
                    };
                    let data_samples = (data.len() / bytes_per_block) as u32 * samples_per_block;
                    if current_ts + data_samples > flush_to {
                        let keep_samples = flush_to - current_ts;
                        let keep_blocks = keep_samples / samples_per_block;
                        let keep_bytes = keep_blocks as usize * bytes_per_block;
                        if keep_bytes > 0 {
                            result.extend_from_slice(&data[..keep_bytes]);
                            let rest_bytes = &data[keep_bytes..];
                            if !rest_bytes.is_empty() {
                                let rest_ts = current_ts + (keep_blocks * samples_per_block);
                                match leg {
                                    Leg::A => self
                                        .buffer_a
                                        .insert(rest_ts, Bytes::copy_from_slice(rest_bytes)),
                                    Leg::B => self
                                        .buffer_b
                                        .insert(rest_ts, Bytes::copy_from_slice(rest_bytes)),
                                };
                            }
                            current_ts += keep_blocks * samples_per_block;
                        } else {
                            // Put it all back
                            match leg {
                                Leg::A => self.buffer_a.insert(ts, data),
                                Leg::B => self.buffer_b.insert(ts, data),
                            };
                            break;
                        }
                    } else {
                        result.extend_from_slice(&data);
                        current_ts += data_samples;
                    }
                } else {
                    break;
                }
            } else {
                break;
            }
        }

        // Fill remaining with silence
        if current_ts < flush_to {
            let gap_samples = flush_to - current_ts;
            let gap_blocks = gap_samples / samples_per_block;
            result.extend(self.get_silence_bytes(leg, gap_blocks as usize)?);
        }

        Ok(result)
    }

    fn interleave(&mut self, data_a: &[u8], data_b: &[u8]) -> Result<Vec<u8>> {
        let (_, bytes_per_block) = self.block_info();
        let len = data_a.len().min(data_b.len());
        let mut interleaved = Vec::with_capacity(len * 2);
        let num_blocks = len / bytes_per_block;
        for i in 0..num_blocks {
            interleaved.extend_from_slice(&data_a[i * bytes_per_block..(i + 1) * bytes_per_block]);
            interleaved.extend_from_slice(&data_b[i * bytes_per_block..(i + 1) * bytes_per_block]);
        }
        Ok(interleaved)
    }

    fn mix(&mut self, data_a: &[u8], data_b: &[u8]) -> Result<Vec<u8>> {
        let (_, bytes_per_block) = self.block_info();
        let len = data_a.len().min(data_b.len());
        let mut mixed = Vec::with_capacity(len);

        match self.codec {
            CodecType::PCMU | CodecType::PCMA => {
                // For μ-law/A-law, decode to PCM, mix, and re-encode
                let mut decoder_a = create_decoder(self.codec);
                let pcm_a = decoder_a.decode(data_a);

                let mut decoder_b = create_decoder(self.codec);
                let pcm_b = decoder_b.decode(data_b);

                // Mix PCM samples (average to prevent clipping)
                let mut pcm_mixed = Vec::with_capacity(pcm_a.len().min(pcm_b.len()));
                for i in 0..pcm_a.len().min(pcm_b.len()) {
                    let sample = ((pcm_a[i] as i32 + pcm_b[i] as i32) / 2) as i16;
                    pcm_mixed.push(sample);
                }

                // Re-encode to target codec
                if let Some(enc) = self.encoder.as_mut() {
                    mixed = enc.encode(&pcm_mixed);
                } else {
                    mixed = audio_codec::samples_to_bytes(&pcm_mixed);
                }
            }
            _ => {
                // For PCM data, mix directly
                let num_blocks = len / bytes_per_block;
                for i in 0..num_blocks {
                    let start = i * bytes_per_block;
                    let end = (i + 1) * bytes_per_block;
                    for j in start..end.min(data_a.len()).min(data_b.len()) {
                        // Mix by averaging (simple approach)
                        let sample = ((data_a[j] as i16 + data_b[j] as i16) / 2) as u8;
                        mixed.push(sample);
                    }
                }
            }
        }

        Ok(mixed)
    }
}

impl Drop for Recorder {
    fn drop(&mut self) {
        let _ = self.finalize();
    }
}

pub struct DtmfGenerator {
    sample_rate: u32,
}

impl DtmfGenerator {
    pub fn new(sample_rate: u32) -> Self {
        Self { sample_rate }
    }

    pub fn generate(&self, digit: char, duration_ms: u32) -> Vec<i16> {
        let num_samples = (self.sample_rate as f32 * (duration_ms as f32 / 1000.0)) as usize;
        self.generate_samples(digit, num_samples)
    }

    pub fn generate_samples(&self, digit: char, num_samples: usize) -> Vec<i16> {
        let freqs = match digit {
            '1' => (697.0, 1209.0),
            '2' => (697.0, 1336.0),
            '3' => (697.0, 1477.0),
            '4' => (770.0, 1209.0),
            '5' => (770.0, 1336.0),
            '6' => (770.0, 1477.0),
            '7' => (852.0, 1209.0),
            '8' => (852.0, 1336.0),
            '9' => (852.0, 1477.0),
            '*' => (941.0, 1209.0),
            '0' => (941.0, 1336.0),
            '#' => (941.0, 1477.0),
            'A' => (697.0, 1633.0),
            'B' => (770.0, 1633.0),
            'C' => (852.0, 1633.0),
            'D' => (941.0, 1633.0),
            _ => return Vec::new(),
        };
        let mut samples = Vec::with_capacity(num_samples);

        for i in 0..num_samples {
            let t = i as f32 / self.sample_rate as f32;
            let s1 = (2.0 * std::f32::consts::PI * freqs.0 * t).sin();
            let s2 = (2.0 * std::f32::consts::PI * freqs.1 * t).sin();
            let s = (s1 + s2) / 2.0;
            samples.push((s * 32767.0) as i16);
        }

        samples
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use audio_codec::{CodecType, create_decoder, create_encoder};

    #[test]
    fn test_mix_pcmu_both_silent() {
        // Test mixing two silent audio streams
        let mut recorder = create_test_recorder(CodecType::PCMU, 1);

        // Create silent PCM samples (all zeros)
        let pcm_silent = vec![0i16; 160];

        // Encode to PCMU
        let mut encoder = create_encoder(CodecType::PCMU);
        let data_a = encoder.encode(&pcm_silent);
        let data_b = encoder.encode(&pcm_silent);

        // Mix the data
        let mixed = recorder.mix(&data_a, &data_b).unwrap();

        // Decode and verify
        let mut decoder = create_decoder(CodecType::PCMU);
        let pcm_result = decoder.decode(&mixed);

        // All samples should be near zero (silence)
        let max_sample = pcm_result.iter().map(|&s| s.abs()).max().unwrap_or(0);
        assert!(
            max_sample < 100,
            "Mixed silent audio should remain silent, got max={}",
            max_sample
        );
    }

    #[test]
    fn test_mix_pcmu_one_silent() {
        // Test mixing one silent and one active audio stream
        let mut recorder = create_test_recorder(CodecType::PCMU, 1);

        // Create test PCM samples
        let pcm_silent = vec![0i16; 160];
        let pcm_active: Vec<i16> = (0..160)
            .map(|i| ((i as f32 / 10.0).sin() * 5000.0) as i16)
            .collect();

        // Encode to PCMU
        let mut encoder_a = create_encoder(CodecType::PCMU);
        let mut encoder_b = create_encoder(CodecType::PCMU);
        let data_a = encoder_a.encode(&pcm_silent);
        let data_b = encoder_b.encode(&pcm_active);

        // Mix the data
        let mixed = recorder.mix(&data_a, &data_b).unwrap();

        // Decode and verify
        let mut decoder = create_decoder(CodecType::PCMU);
        let pcm_result = decoder.decode(&mixed);

        // The mixed result should be roughly half the amplitude of the active stream
        // since we're averaging with silence (0)
        let mut decoder_b = create_decoder(CodecType::PCMU);
        let pcm_b_decoded = decoder_b.decode(&data_b);

        // Check that mixed amplitude is roughly half of the original
        let avg_mixed: i32 = pcm_result
            .iter()
            .take(100)
            .map(|&s| s.abs() as i32)
            .sum::<i32>()
            / 100;
        let avg_original: i32 = pcm_b_decoded
            .iter()
            .take(100)
            .map(|&s| s.abs() as i32)
            .sum::<i32>()
            / 100;

        // Both should have non-zero amplitude
        assert!(
            avg_original > 100,
            "Original signal should be non-zero, got {}",
            avg_original
        );
        assert!(
            avg_mixed > 50,
            "Mixed signal should be non-zero, got {}",
            avg_mixed
        );

        let ratio = avg_mixed as f32 / avg_original as f32;
        assert!(
            ratio > 0.35 && ratio < 0.65,
            "Mixed amplitude should be ~0.5x original, got ratio={} (mixed={}, orig={})",
            ratio,
            avg_mixed,
            avg_original
        );
    }

    #[test]
    fn test_mix_pcmu_both_active() {
        // Test mixing two active audio streams with different amplitudes
        let mut recorder = create_test_recorder(CodecType::PCMU, 1);

        // Create test PCM samples with different amplitudes
        let pcm_a: Vec<i16> = (0..160)
            .map(|i| (i as f32 * 50.0).sin() as i16 * 2000)
            .collect();
        let pcm_b: Vec<i16> = (0..160)
            .map(|i| (i as f32 * 70.0).sin() as i16 * 3000)
            .collect();

        // Encode to PCMU
        let mut encoder_a = create_encoder(CodecType::PCMU);
        let mut encoder_b = create_encoder(CodecType::PCMU);
        let data_a = encoder_a.encode(&pcm_a);
        let data_b = encoder_b.encode(&pcm_b);

        // Mix the data
        let mixed = recorder.mix(&data_a, &data_b).unwrap();

        // Verify the output length is correct (same as inputs for PCMU)
        assert_eq!(mixed.len(), data_a.len());
        assert_eq!(mixed.len(), data_b.len());

        // Decode all three and verify averaging
        let mut decoder_a = create_decoder(CodecType::PCMU);
        let mut decoder_b = create_decoder(CodecType::PCMU);
        let mut decoder_mixed = create_decoder(CodecType::PCMU);

        let pcm_a_decoded = decoder_a.decode(&data_a);
        let pcm_b_decoded = decoder_b.decode(&data_b);
        let pcm_mixed = decoder_mixed.decode(&mixed);

        // Check that mixed samples are approximately the average
        let sample_idx = 50; // Check middle sample
        let expected =
            ((pcm_a_decoded[sample_idx] as i32 + pcm_b_decoded[sample_idx] as i32) / 2) as i16;
        let actual = pcm_mixed[sample_idx];
        let diff = (expected - actual).abs();

        // Allow some tolerance due to codec quantization
        assert!(
            diff < 200,
            "Mixed sample should be average of inputs, expected ~{}, got {}, diff={}",
            expected,
            actual,
            diff
        );
    }

    #[test]
    fn test_interleave_pcmu() {
        // Test interleaving two audio streams for stereo recording
        let mut recorder = create_test_recorder(CodecType::PCMU, 2);

        // Create distinct test data
        let data_a: Vec<u8> = (0..160).map(|i| (i % 256) as u8).collect();
        let data_b: Vec<u8> = (0..160).map(|i| ((i + 128) % 256) as u8).collect();

        // Interleave the data
        let interleaved = recorder.interleave(&data_a, &data_b).unwrap();

        // Verify length is double
        assert_eq!(interleaved.len(), data_a.len() + data_b.len());

        // Verify interleaving pattern: A[0], B[0], A[1], B[1], ...
        for i in 0..10 {
            assert_eq!(
                interleaved[i * 2],
                data_a[i],
                "Interleaved data should alternate: A at position {}",
                i * 2
            );
            assert_eq!(
                interleaved[i * 2 + 1],
                data_b[i],
                "Interleaved data should alternate: B at position {}",
                i * 2 + 1
            );
        }
    }

    #[test]
    fn test_channel_selection_mono() {
        // Verify that mono recording (channels=1) uses mix
        let recorder = create_test_recorder(CodecType::PCMU, 1);
        assert_eq!(recorder.channels, 1, "Mono recorder should have 1 channel");
    }

    #[test]
    fn test_channel_selection_stereo() {
        // Verify that stereo recording (channels=2) for wideband codecs
        let recorder = create_test_recorder(CodecType::Opus, 2);
        assert_eq!(recorder.channels, 2, "Opus recorder should have 2 channels");

        let recorder_g722 = create_test_recorder(CodecType::G722, 2);
        assert_eq!(
            recorder_g722.channels, 2,
            "G722 recorder should have 2 channels"
        );
    }

    #[test]
    fn test_mix_prevents_clipping() {
        // Test that mixing prevents clipping by averaging instead of adding
        let mut recorder = create_test_recorder(CodecType::PCMU, 1);

        // Create high-amplitude samples near the maximum
        let pcm_high = vec![20000i16; 160];

        // Encode to PCMU
        let mut encoder_a = create_encoder(CodecType::PCMU);
        let mut encoder_b = create_encoder(CodecType::PCMU);
        let data_a = encoder_a.encode(&pcm_high);
        let data_b = encoder_b.encode(&pcm_high);

        // Mix the data
        let mixed = recorder.mix(&data_a, &data_b).unwrap();

        // Decode and verify no clipping
        let mut decoder = create_decoder(CodecType::PCMU);
        let pcm_result = decoder.decode(&mixed);

        // The result should be around 20000 (averaged), not 40000 (which would clip)
        let avg_result: i32 =
            pcm_result.iter().map(|&s| s as i32).sum::<i32>() / pcm_result.len() as i32;
        assert!(
            avg_result > 15000 && avg_result < 25000,
            "Mixed high-amplitude audio should not clip, avg={}",
            avg_result
        );
    }

    // Helper function to create a test recorder
    fn create_test_recorder(codec: CodecType, channels: u16) -> Recorder {
        let sample_rate = codec.samplerate();
        let encoder = Some(create_encoder(codec));

        Recorder {
            path: "test.wav".to_string(),
            codec,
            written_bytes: 0,
            sample_rate,
            channels,
            dtmf_gen: DtmfGenerator::new(sample_rate),
            encoder,
            decoders: HashMap::new(),
            resamplers: HashMap::new(),
            buffer_a: BTreeMap::new(),
            buffer_b: BTreeMap::new(),
            start_instant: Instant::now(),
            last_flush: Instant::now(),
            base_timestamp_a: None,
            base_timestamp_b: None,
            start_offset_a: 0,
            start_offset_b: 0,
            last_ssrc_a: None,
            last_ssrc_b: None,
            profile_a: NegotiatedLegProfile::default(),
            profile_b: NegotiatedLegProfile::default(),
            dtmf_state_a: None,
            dtmf_state_b: None,
            next_flush_ts: 0,
            written_samples: 0,
            writer: Box::new(TestWriter::new()),
            ptime: Duration::from_millis(20),
        }
    }

    // Mock writer for testing
    struct TestWriter {
        data: Vec<u8>,
    }

    impl TestWriter {
        fn new() -> Self {
            Self { data: Vec::new() }
        }
    }

    impl StreamWriter for TestWriter {
        fn write_header(&mut self) -> Result<()> {
            Ok(())
        }

        fn write_packet(&mut self, data: &[u8], _samples: usize) -> Result<()> {
            self.data.extend_from_slice(data);
            Ok(())
        }

        fn finalize(&mut self) -> Result<()> {
            Ok(())
        }
    }
}