rustls 0.24.0-dev.1

Rustls is a modern TLS library written in Rust.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
use alloc::collections::VecDeque;
use alloc::vec::Vec;
use core::mem;
use std::io;

use crate::crypto::cipher::OutboundPlain;

/// This is a byte buffer that is built from a deque of byte vectors.
///
/// This avoids extra copies when appending a new byte vector,
/// at the expense of more complexity when reading out.
pub(crate) struct ChunkVecBuffer {
    /// How many bytes have been consumed in the first chunk.
    ///
    /// Invariant: zero if `chunks.is_empty()`
    /// Invariant: 0 <= `prefix_used` < `chunks[0].len()`
    prefix_used: usize,

    chunks: VecDeque<Vec<u8>>,

    /// The total upper limit (in bytes) of this object.
    limit: Option<usize>,

    /// Fully-consumed chunks retained for reuse via `take_spare()`.
    ///
    /// `None` means recycling is disabled and spent chunks are freed.
    /// Retention is opt-in (via `new_recycling()`) because it only pays
    /// off for a buffer whose owner takes chunks back out, i.e. the send
    /// path's `sendable_tls`. Elsewhere it would hold dead memory for
    /// the connection's lifetime.
    spare: Option<Vec<Vec<u8>>>,
}

impl ChunkVecBuffer {
    pub(crate) fn new(limit: Option<usize>) -> Self {
        Self {
            prefix_used: 0,
            chunks: VecDeque::new(),
            limit,
            spare: None,
        }
    }

    /// Like `new()`, but fully-consumed chunks are retained and can be
    /// reused via `take_spare()`.
    ///
    /// The total capacity retained this way is bounded by `limit`. The
    /// `ChunkVecBuffer` never holds more spare capacity than it is allowed
    /// to hold queued data. An unlimited buffer retains every spent chunk,
    /// so its spare capacity is bounded by its peak queued size.
    ///
    /// Since chunks are only spent by being consumed, retained chunks only
    /// ever contain data that has already been written to the wire.
    pub(crate) fn new_recycling(limit: Option<usize>) -> Self {
        Self {
            prefix_used: 0,
            chunks: VecDeque::new(),
            limit,
            spare: Some(Vec::new()),
        }
    }

    /// Take a previously-spent chunk for reuse, if one is available.
    ///
    /// The returned vector has unspecified length and contents. Callers
    /// must resize it and overwrite its contents before use.
    pub(crate) fn take_spare(&mut self) -> Vec<u8> {
        self.spare
            .as_mut()
            .and_then(|spare| spare.pop())
            .unwrap_or_default()
    }

    /// Sets the upper limit on how many bytes this
    /// object can store.
    ///
    /// Setting a lower limit than the currently stored
    /// data is not an error.
    ///
    /// A [`None`] limit is interpreted as no limit.
    pub(crate) fn set_limit(&mut self, new_limit: Option<usize>) {
        self.limit = new_limit;
    }

    /// If we're empty
    pub(crate) fn is_empty(&self) -> bool {
        self.chunks.is_empty()
    }

    /// How many bytes we're storing
    pub(crate) fn len(&self) -> usize {
        self.chunks
            .iter()
            .fold(0usize, |acc, chunk| acc + chunk.len())
            - self.prefix_used
    }

    /// Take and append the given `bytes`.
    pub(crate) fn append(&mut self, bytes: Vec<u8>) -> usize {
        let len = bytes.len();

        if !bytes.is_empty() {
            if self.chunks.is_empty() {
                debug_assert_eq!(self.prefix_used, 0);
            }

            self.chunks.push_back(bytes);
        }

        len
    }

    pub(crate) fn take(&mut self) -> Vec<Vec<u8>> {
        if self.chunks.is_empty() {
            return Vec::new();
        }

        let mut chunks = Vec::from(mem::take(&mut self.chunks));
        // slice off `prefix_used` if needed (uncommon)
        let prefix = mem::take(&mut self.prefix_used);
        chunks[0].drain(0..prefix);
        chunks
    }

    pub(crate) fn take_one_vec(&mut self) -> Vec<u8> {
        // `pop()` slices off `prefix_used`
        let Some(mut first) = self.pop() else {
            return Vec::new();
        };

        while let Some(chunk) = self.chunks.pop_front() {
            first.extend_from_slice(&chunk);
        }

        first
    }

    /// Take one of the chunks from this object.
    ///
    /// This function returns `None` if the object `is_empty`.
    pub(crate) fn pop(&mut self) -> Option<Vec<u8>> {
        let mut first = self.chunks.pop_front();

        if let Some(first) = &mut first {
            // slice off `prefix_used` if needed (uncommon)
            let prefix = mem::take(&mut self.prefix_used);
            first.drain(0..prefix);
        }

        first
    }

    /// Inspect the first chunk from this object.
    pub(crate) fn peek(&self) -> Option<&[u8]> {
        self.chunks
            .front()
            .map(|ch| ch.as_slice())
    }
}

impl ChunkVecBuffer {
    pub(crate) fn is_full(&self) -> bool {
        self.limit
            .map(|limit| self.len() >= limit)
            .unwrap_or_default()
    }

    /// Append a copy of `bytes`, perhaps a prefix if
    /// we're near the limit.
    pub(crate) fn append_limited_copy(&mut self, payload: OutboundPlain<'_>) -> usize {
        let take = self.apply_limit(payload.len());
        self.append(payload.split_at(take).0.to_vec());
        take
    }

    /// For a proposed append of `len` bytes, how many
    /// bytes should we actually append to adhere to the
    /// currently set `limit`?
    pub(crate) fn apply_limit(&self, len: usize) -> usize {
        let Some(limit) = self.limit else {
            return len;
        };

        let space = limit.saturating_sub(self.len());
        Ord::min(len, space)
    }

    /// Read data out of this object, writing it into `buf`
    /// and returning how many bytes were written there.
    pub(crate) fn read(&mut self, buf: &mut [u8]) -> usize {
        let mut offs = 0;

        while offs < buf.len() && !self.is_empty() {
            let chunk = &self.chunks[0][self.prefix_used..];
            let used = Ord::min(chunk.len(), buf.len() - offs);
            buf[offs..offs + used].copy_from_slice(&chunk[..used]);

            self.consume(used);
            offs += used;
        }

        offs
    }

    pub(crate) fn consume_first_chunk(&mut self, used: usize) {
        // this backs (infallible) `BufRead::consume`, where `used` is
        // user-supplied.
        assert!(
            used <= self
                .chunk()
                .map(|ch| ch.len())
                .unwrap_or_default(),
            "illegal `BufRead::consume` usage",
        );
        self.consume(used);
    }

    fn consume(&mut self, used: usize) {
        // first, mark the rightmost extent of the used buffer
        self.prefix_used += used;

        // then reduce `prefix_used` by discarding wholly-covered
        // buffers
        while let Some(buf) = self.chunks.front() {
            if self.prefix_used < buf.len() {
                return;
            }

            self.prefix_used -= buf.len();
            if let Some(spent) = self.chunks.pop_front() {
                self.recycle(spent);
            }
        }

        debug_assert_eq!(
            self.prefix_used, 0,
            "attempted to `ChunkVecBuffer::consume` more than available"
        );
    }

    /// Retain `spent` for reuse via `take_spare()`, if recycling is enabled and there is capacity
    /// relative to the limit.
    fn recycle(&mut self, spent: Vec<u8>) {
        let Some(spare) = &mut self.spare else {
            return;
        };

        if let Some(limit) = self.limit {
            let retained = spare
                .iter()
                .map(|chunk| chunk.capacity())
                .sum::<usize>();
            if retained + spent.capacity() > limit {
                return;
            }
        }

        spare.push(spent);
    }

    /// Read data out of this object, passing it `wr`
    pub(crate) fn write_to(&mut self, wr: &mut dyn io::Write) -> io::Result<usize> {
        if self.is_empty() {
            return Ok(0);
        }

        let mut prefix = self.prefix_used;
        let mut bufs = [io::IoSlice::new(&[]); 64];
        for (iov, chunk) in bufs.iter_mut().zip(self.chunks.iter()) {
            *iov = io::IoSlice::new(&chunk[prefix..]);
            prefix = 0;
        }
        let len = Ord::min(bufs.len(), self.chunks.len());
        let bufs = &bufs[..len];
        let used = wr.write_vectored(bufs)?;
        let available_bytes = bufs.iter().map(|ch| ch.len()).sum();

        if used > available_bytes {
            // This is really unrecoverable, since the amount of data written
            // is now unknown.  Consume all the potentially-written data in
            // case the caller ignores the error.
            // See <https://github.com/rustls/rustls/issues/2316> for background.
            self.consume(available_bytes);
            return Err(io::Error::other(std::format!(
                "illegal write_vectored return value ({used} > {available_bytes})"
            )));
        }
        self.consume(used);
        Ok(used)
    }

    /// Returns the first contiguous chunk of data, or None if empty.
    pub(crate) fn chunk(&self) -> Option<&[u8]> {
        self.chunks
            .front()
            .map(|chunk| &chunk[self.prefix_used..])
    }
}

#[cfg(test)]
mod tests {
    use alloc::vec;
    use alloc::vec::Vec;

    use super::ChunkVecBuffer;

    #[test]
    fn short_append_copy_with_limit() {
        let mut cvb = ChunkVecBuffer::new(Some(12));
        assert_eq!(cvb.append_limited_copy(b"hello"[..].into()), 5);
        assert_eq!(cvb.append_limited_copy(b"world"[..].into()), 5);
        assert_eq!(cvb.append_limited_copy(b"hello"[..].into()), 2);
        assert_eq!(cvb.append_limited_copy(b"world"[..].into()), 0);

        let mut buf = [0u8; 12];
        assert_eq!(cvb.read(&mut buf), 12);
        assert_eq!(buf.to_vec(), b"helloworldhe".to_vec());
    }

    #[test]
    fn recycling_retains_spent_chunks() {
        let mut cvb = ChunkVecBuffer::new_recycling(None);
        assert!(cvb.take_spare().is_empty());

        cvb.append(b"first".to_vec());
        cvb.append(b"second".to_vec());
        let mut buf = [0u8; 11];
        assert_eq!(cvb.read(&mut buf), 11);

        // spent chunks are returned most-recently-spent first, unaltered
        assert_eq!(cvb.take_spare(), b"second");
        assert_eq!(cvb.take_spare(), b"first");
        assert!(cvb.take_spare().is_empty());

        // no retention without recycling enabled
        let mut cvb = ChunkVecBuffer::new(None);
        cvb.append(b"first".to_vec());
        assert_eq!(cvb.read(&mut buf), 5);
        assert!(cvb.take_spare().is_empty());
    }

    #[test]
    fn recycling_bounded_by_limit() {
        let mut cvb = ChunkVecBuffer::new_recycling(Some(8));
        cvb.append(vec![1u8; 6]);
        cvb.append(vec![2u8; 6]);
        let mut buf = [0u8; 12];
        assert_eq!(cvb.read(&mut buf), 12);

        // only the first spent chunk fits under the 8-byte cap
        assert_eq!(cvb.take_spare(), vec![1u8; 6]);
        assert!(cvb.take_spare().is_empty());
    }

    #[test]
    fn take_slices_off_consumed_prefix() {
        let mut cvb = ChunkVecBuffer::new(None);
        cvb.append(b"hello".to_vec());
        cvb.append(b"world".to_vec());
        assert_eq!(cvb.read(&mut [0u8; 3]), 3);
        assert_eq!(cvb.take(), [b"lo".to_vec(), b"world".to_vec()]);
        assert_eq!(cvb.len(), 0);

        let mut cvb = ChunkVecBuffer::new(None);
        cvb.append(b"hello".to_vec());
        cvb.append(b"world".to_vec());
        assert_eq!(cvb.read(&mut [0u8; 3]), 3);
        assert_eq!(cvb.take_one_vec(), b"loworld");
        assert_eq!(cvb.len(), 0);
    }

    #[test]
    fn read_byte_by_byte() {
        let mut cvb = ChunkVecBuffer::new(None);
        cvb.append(b"test fixture data".to_vec());
        assert!(!cvb.is_empty());
        for expect in b"test fixture data" {
            let mut byte = [0];
            assert_eq!(cvb.read(&mut byte), 1);
            assert_eq!(byte[0], *expect);
        }

        assert_eq!(cvb.read(&mut [0]), 0);
    }

    #[test]
    fn every_possible_chunk_interleaving() {
        let input = (0..=0xffu8)
            .cycle()
            .take(4096)
            .collect::<Vec<u8>>();

        for input_chunk_len in 1..64usize {
            for output_chunk_len in 1..65usize {
                std::println!("check input={input_chunk_len} output={output_chunk_len}");
                let mut cvb = ChunkVecBuffer::new(None);
                for chunk in input.chunks(input_chunk_len) {
                    cvb.append(chunk.to_vec());
                }

                assert_eq!(cvb.len(), input.len());
                let mut buf = vec![0u8; output_chunk_len];

                for expect in input.chunks(output_chunk_len) {
                    assert_eq!(expect.len(), cvb.read(&mut buf));
                    assert_eq!(expect, &buf[..expect.len()]);
                }

                assert_eq!(cvb.read(&mut [0]), 0);
            }
        }
    }
}

#[cfg(all(test, bench))]
mod benchmarks {
    use alloc::vec;

    use super::ChunkVecBuffer;

    #[bench]
    fn read_one_byte_from_large_message(b: &mut test::Bencher) {
        b.iter(|| {
            let mut cvb = ChunkVecBuffer::new(None);
            cvb.append(vec![0u8; 16_384]);
            assert_eq!(1, cvb.read(&mut [0u8]));
        });
    }

    #[bench]
    fn read_all_individual_from_large_message(b: &mut test::Bencher) {
        b.iter(|| {
            let mut cvb = ChunkVecBuffer::new(None);
            cvb.append(vec![0u8; 16_384]);
            loop {
                if cvb.read(&mut [0u8]) == 0 {
                    break;
                }
            }
        });
    }

    #[bench]
    fn read_half_bytes_from_large_message(b: &mut test::Bencher) {
        b.iter(|| {
            let mut cvb = ChunkVecBuffer::new(None);
            cvb.append(vec![0u8; 16_384]);
            assert_eq!(8192, cvb.read(&mut [0u8; 8192]));
            assert_eq!(8192, cvb.read(&mut [0u8; 8192]));
        });
    }

    #[bench]
    fn read_entire_large_message(b: &mut test::Bencher) {
        b.iter(|| {
            let mut cvb = ChunkVecBuffer::new(None);
            cvb.append(vec![0u8; 16_384]);
            assert_eq!(16_384, cvb.read(&mut [0u8; 16_384]));
        });
    }
}