rustfs-ecstore 1.0.1

Erasure coding storage backend for RustFS, providing efficient data storage and retrieval with redundancy.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
// Copyright 2024 RustFS Team
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

use crate::cluster::rpc::{
    build_auth_headers, build_put_file_auth_trailer, verify_ns_scanner_capability_with_tier_registry_generation,
    verify_put_file_capability,
};
use crate::disk::error::{Error, Result};
use crate::disk::{FileReader, FileWriter};
use crate::storage_api_contracts::internode::{
    NS_SCANNER_BODY_SHA256_QUERY, NS_SCANNER_CAPABILITY_CHALLENGE_QUERY, NS_SCANNER_CYCLE_QUERY, NS_SCANNER_LEADER_EPOCH_QUERY,
    NS_SCANNER_PROTOCOL_VERSION, NS_SCANNER_PROTOCOL_VERSION_QUERY, NS_SCANNER_REQUEST_ID_QUERY, NS_SCANNER_SERVER_EPOCH_QUERY,
    NS_SCANNER_SESSION_ID_QUERY, NS_SCANNER_SESSION_SEQUENCE_QUERY, NS_SCANNER_TIER_REGISTRY_GENERATION_QUERY,
    NsScannerCapabilityResponse, PUT_FILE_AUTH_QUERY, PUT_FILE_AUTH_V1, PUT_FILE_CAPABILITY_CHALLENGE_QUERY,
    PUT_FILE_CAPABILITY_QUERY, PUT_FILE_CAPABILITY_VERSION, PUT_FILE_NONCE_QUERY, PUT_FILE_SERVER_EPOCH_QUERY,
    PutFileCapabilityResponse, WALK_DIR_BODY_SHA256_QUERY, WALK_DIR_STREAM_COMPLETION_QUERY, WALK_DIR_STREAM_COMPLETION_V1,
};
use async_trait::async_trait;
use http::{HeaderMap, HeaderValue, Method, header::CONTENT_TYPE};
use rustfs_config::{
    DEFAULT_INTERNODE_DATA_TRANSPORT, ENV_RUSTFS_INTERNODE_DATA_TRANSPORT, INTERNODE_DATA_TRANSPORT_TCP,
    KNOWN_INTERNODE_DATA_TRANSPORT_BACKENDS,
};
use rustfs_rio::{ChunkReaderBox, HttpChunkReader, HttpReader, HttpWriter};
use sha2::{Digest, Sha256};
use std::collections::HashMap;
use std::future::Future;
use std::io;
use std::pin::Pin;
use std::sync::{Arc, LazyLock, OnceLock};
use std::task::{Context, Poll};
use std::time::{Duration, Instant};
use tokio::io::{AsyncReadExt, AsyncWrite};
use tokio::sync::OnceCell;
use uuid::Uuid;

#[allow(
    dead_code,
    reason = "live in the cfg(not(test)) half of build_internode_data_transport_from_env (backlog#1823)"
)]
static INTERNODE_DATA_TRANSPORT: OnceLock<std::result::Result<Arc<dyn InternodeDataTransport>, String>> = OnceLock::new();

const READ_FILE_STREAM_PATH: &str = "/rustfs/rpc/read_file_stream";
const PUT_FILE_STREAM_PATH: &str = "/rustfs/rpc/put_file_stream";
const PUT_FILE_AUTH_STREAM_PATH: &str = "/rustfs/rpc/put_file_stream_v1";
const PUT_FILE_CAPABILITY_PATH: &str = "/rustfs/rpc/put_file_capability";
const WALK_DIR_PATH: &str = "/rustfs/rpc/walk_dir";
const NS_SCANNER_PATH: &str = "/rustfs/rpc/ns_scanner";
const NS_SCANNER_MAX_CAPABILITY_RESPONSE_SIZE: usize = 1024;
const PUT_FILE_MAX_CAPABILITY_RESPONSE_SIZE: usize = 1024;
const PUT_FILE_LEGACY_CAPABILITY_TTL: Duration = Duration::from_secs(30);
const PUT_FILE_V1_CAPABILITY_TTL: Duration = Duration::from_secs(30);
const PUT_FILE_CAPABILITY_PROBE_TIMEOUT: Duration = Duration::from_secs(5);
const CONTENT_TYPE_JSON: &str = "application/json";
const CONTENT_TYPE_MSGPACK: &str = "application/msgpack";

fn unsupported_transport_message(transport: &str) -> String {
    format!(
        "invalid {ENV_RUSTFS_INTERNODE_DATA_TRANSPORT}={transport:?}; supported values: {}",
        KNOWN_INTERNODE_DATA_TRANSPORT_BACKENDS.join(", ")
    )
}

#[derive(Debug, Clone, Copy)]
enum PutFileCapabilityState {
    LegacyUntil(Instant),
    V1 { server_epoch: Uuid, revalidate_after: Instant },
}

#[derive(Debug)]
struct PutFileCapabilityProbeFailure(Error);

impl PutFileCapabilityProbeFailure {
    fn to_error(&self) -> Error {
        match &self.0 {
            Error::Io(error) => rustfs_rio::clone_internode_http_io_error(error)
                .map(Error::Io)
                .unwrap_or_else(|| self.0.clone()),
            _ => self.0.clone(),
        }
    }
}

type PutFileCapabilityProbeOutcome = std::result::Result<Option<Uuid>, PutFileCapabilityProbeFailure>;

#[derive(Debug, Clone)]
struct PutFileCapabilityFlight {
    generation: u64,
    v1_was_pinned: bool,
    outcome: Arc<OnceCell<PutFileCapabilityProbeOutcome>>,
}

#[derive(Debug, Default)]
struct PutFileCapabilityCacheState {
    cached: Option<PutFileCapabilityState>,
    generation: u64,
    in_flight: Option<PutFileCapabilityFlight>,
    rejected_server_epoch: Option<Uuid>,
}

// The registry lock is released before taking an entry lock. Entry guards cover
// only cache transitions, never a probe or await; poll-based writers must be
// able to reject an epoch atomically with those transitions.
type PutFileCapabilityCacheEntry = Arc<parking_lot::RwLock<PutFileCapabilityCacheState>>;

static PUT_FILE_CAPABILITY_CACHE: LazyLock<parking_lot::RwLock<HashMap<String, PutFileCapabilityCacheEntry>>> =
    LazyLock::new(|| parking_lot::RwLock::new(HashMap::new()));

fn put_file_capability_cache_entry(endpoint: &str) -> PutFileCapabilityCacheEntry {
    if let Some(entry) = PUT_FILE_CAPABILITY_CACHE.read().get(endpoint).cloned() {
        return entry;
    }
    PUT_FILE_CAPABILITY_CACHE
        .write()
        .entry(endpoint.to_owned())
        .or_insert_with(|| Arc::new(parking_lot::RwLock::new(PutFileCapabilityCacheState::default())))
        .clone()
}

fn fresh_put_file_capability(state: Option<PutFileCapabilityState>, now: Instant) -> Option<Option<Uuid>> {
    match state {
        Some(PutFileCapabilityState::V1 {
            server_epoch,
            revalidate_after,
        }) if now < revalidate_after => Some(Some(server_epoch)),
        Some(PutFileCapabilityState::LegacyUntil(expires_at)) if now < expires_at => Some(None),
        Some(PutFileCapabilityState::V1 { .. }) | Some(PutFileCapabilityState::LegacyUntil(_)) | None => None,
    }
}

fn reject_put_file_server_epoch(endpoint: &str, server_epoch: Uuid) {
    let entry = PUT_FILE_CAPABILITY_CACHE.read().get(endpoint).cloned();
    if let Some(entry) = entry {
        let mut state = entry.write();
        if matches!(state.cached, Some(PutFileCapabilityState::V1 { server_epoch: cached, .. }) if cached == server_epoch) {
            state.rejected_server_epoch = Some(server_epoch);
        }
    }
}

fn usable_put_file_capability(state: &PutFileCapabilityCacheState, now: Instant) -> Option<Option<Uuid>> {
    match fresh_put_file_capability(state.cached, now)? {
        Some(server_epoch) if state.rejected_server_epoch == Some(server_epoch) => None,
        capability => Some(capability),
    }
}

fn put_file_capability_status_is_legacy(status: u16) -> bool {
    status == 404
}

fn ns_scanner_capability_error_allows_legacy(error: &Error) -> bool {
    [400, 404, 405, 426]
        .into_iter()
        .any(|status| error.is_internode_http_status(status))
}

#[derive(Debug, Clone, Copy, Eq, PartialEq)]
#[allow(
    dead_code,
    reason = "capability-negotiation seam; constructed only by transport test doubles (backlog#1823)"
)]
pub struct InternodeDataTransportCapabilities {
    /// Backend can open a streaming remote disk reader.
    pub streaming_read: bool,
    /// Backend can open a streaming remote disk writer.
    pub streaming_write: bool,
    /// Backend can stream walk-dir responses.
    pub streaming_walk_dir: bool,
    /// Backend preserves in-order delivery for each opened transfer.
    pub ordered_delivery: bool,
    /// Largest payload the backend accepts for one transfer, or no RustFS-level cap.
    pub max_transfer_size: Option<usize>,
    /// Backend can participate in the behavior-preserving TCP fallback path.
    pub fallback_supported: bool,
}

impl InternodeDataTransportCapabilities {
    #[allow(
        dead_code,
        reason = "capability-negotiation seam; used by transport test doubles (backlog#1823)"
    )]
    pub const fn tcp_http() -> Self {
        Self {
            streaming_read: true,
            streaming_write: true,
            streaming_walk_dir: true,
            ordered_delivery: true,
            max_transfer_size: None,
            fallback_supported: true,
        }
    }
}

#[derive(Debug, Clone)]
pub struct ReadStreamRequest {
    pub endpoint: String,
    pub disk: String,
    pub volume: String,
    pub path: String,
    pub offset: usize,
    pub length: usize,
    pub stall_timeout: Option<Duration>,
}

#[derive(Debug, Clone)]
pub struct WriteStreamRequest {
    pub endpoint: String,
    pub disk: String,
    pub volume: String,
    pub path: String,
    pub append: bool,
    pub size: i64,
}

#[derive(Debug, Clone)]
pub struct WalkDirStreamRequest {
    pub endpoint: String,
    pub disk: String,
    pub body: Vec<u8>,
    pub stall_timeout: Option<Duration>,
}

#[derive(Debug, Clone)]
pub struct NsScannerStreamRequest {
    pub endpoint: String,
    pub disk: String,
    pub request_id: Uuid,
    pub server_epoch: Uuid,
    pub session_id: Uuid,
    pub session_sequence: u64,
    pub next_cycle: u64,
    pub leader_epoch: u64,
    pub body: Vec<u8>,
    pub stall_timeout: Option<Duration>,
}

#[derive(Debug, Clone)]
pub struct NsScannerCapabilityRequest {
    pub endpoint: String,
    pub supports_tier_registry_generation: bool,
}

/// Data-plane stream opener used by `RemoteDisk`.
///
/// This boundary is limited to remote disk streams that can move large payloads.
/// Internode metadata, lock, health, and administrative calls remain on the
/// existing gRPC control plane.
///
/// Buffer ownership, backend selection, and fallback expectations are documented
/// in `crates/ecstore/docs/internode-transport/`.
#[async_trait]
pub trait InternodeDataTransport: Send + Sync + std::fmt::Debug {
    async fn open_read(&self, request: ReadStreamRequest) -> Result<FileReader>;
    async fn open_read_fresh(&self, request: ReadStreamRequest) -> Result<FileReader> {
        self.open_read(request).await
    }
    /// Opens an owned-chunk stream when this transport can retain receive-buffer
    /// ownership. `None` preserves the established `open_read` fallback.
    async fn open_read_chunks(&self, _request: ReadStreamRequest) -> Result<Option<ChunkReaderBox>> {
        Ok(None)
    }
    async fn open_read_chunks_fresh(&self, request: ReadStreamRequest) -> Result<Option<ChunkReaderBox>> {
        self.open_read_chunks(request).await
    }
    async fn open_write(&self, request: WriteStreamRequest) -> Result<FileWriter>;
    async fn open_walk_dir(&self, request: WalkDirStreamRequest) -> Result<FileReader>;
    async fn open_ns_scanner(&self, _request: NsScannerStreamRequest) -> Result<FileReader> {
        Err(Error::MethodNotAllowed)
    }
    async fn probe_ns_scanner(&self, _request: NsScannerCapabilityRequest) -> Result<Uuid> {
        Err(Error::MethodNotAllowed)
    }
    async fn probe_ns_scanner_capability(&self, request: NsScannerCapabilityRequest) -> Result<NsScannerCapabilityResponse> {
        let server_epoch = self.probe_ns_scanner(request).await?;
        Ok(NsScannerCapabilityResponse {
            version: NS_SCANNER_PROTOCOL_VERSION,
            server_epoch,
            proof: Vec::new(),
            supports_tier_registry_generation: None,
        })
    }
    // Interface facet nobody calls yet: every transport implements both, but no
    // caller negotiates on them. Kept for the internode transport split
    // (backlog#1350); deleting them would delete the seam and six impls.
    #[allow(dead_code, reason = "unused capability-negotiation facet (backlog#1823)")]
    fn name(&self) -> &'static str;
    #[allow(dead_code, reason = "unused capability-negotiation facet (backlog#1823)")]
    fn capabilities(&self) -> InternodeDataTransportCapabilities;
}

#[derive(Debug, Default)]
pub struct TcpHttpInternodeDataTransport;

#[async_trait]
impl InternodeDataTransport for TcpHttpInternodeDataTransport {
    async fn open_read(&self, request: ReadStreamRequest) -> Result<FileReader> {
        let url = build_read_file_stream_url(&request);
        let mut headers = json_headers();
        build_auth_headers(&url, &Method::GET, &mut headers)?;
        Ok(Box::new(
            HttpReader::new_with_stall_timeout(url, Method::GET, headers, None, request.stall_timeout).await?,
        ))
    }

    async fn open_read_fresh(&self, request: ReadStreamRequest) -> Result<FileReader> {
        let url = build_read_file_stream_url(&request);
        let mut headers = json_headers();
        build_auth_headers(&url, &Method::GET, &mut headers)?;
        Ok(Box::new(
            HttpReader::new_fresh_connection_with_stall_timeout(url, Method::GET, headers, None, request.stall_timeout).await?,
        ))
    }

    async fn open_read_chunks(&self, request: ReadStreamRequest) -> Result<Option<ChunkReaderBox>> {
        let url = build_read_file_stream_url(&request);
        let mut headers = json_headers();
        build_auth_headers(&url, &Method::GET, &mut headers)?;
        Ok(Some(Box::new(
            HttpChunkReader::new_with_stall_timeout(url, Method::GET, headers, None, request.stall_timeout).await?,
        )))
    }

    async fn open_read_chunks_fresh(&self, request: ReadStreamRequest) -> Result<Option<ChunkReaderBox>> {
        let url = build_read_file_stream_url(&request);
        let mut headers = json_headers();
        build_auth_headers(&url, &Method::GET, &mut headers)?;
        Ok(Some(Box::new(
            HttpChunkReader::new_fresh_connection_with_stall_timeout(url, Method::GET, headers, None, request.stall_timeout)
                .await?,
        )))
    }

    async fn open_write(&self, request: WriteStreamRequest) -> Result<FileWriter> {
        let server_epoch = self.put_file_auth_capability(&request.endpoint).await?;
        let auth_scope = server_epoch.map(|server_epoch| (Uuid::new_v4(), server_epoch));
        let url = build_put_file_stream_url(&request, auth_scope);
        let endpoint = request.endpoint;
        let mut headers = json_headers();
        build_auth_headers(&url, &Method::PUT, &mut headers)?;
        let writer = HttpWriter::new(url.clone(), Method::PUT, headers).await?;
        match auth_scope {
            Some((nonce, server_epoch)) => Ok(Box::new(PutFileAuthWriter::new(writer, url, nonce, endpoint, server_epoch))),
            None => Ok(Box::new(writer)),
        }
    }

    async fn open_walk_dir(&self, request: WalkDirStreamRequest) -> Result<FileReader> {
        let url = build_walk_dir_url(&request);
        let mut headers = json_headers();
        build_auth_headers(&url, &Method::GET, &mut headers)?;
        Ok(Box::new(
            HttpReader::new_with_stall_timeout(url, Method::GET, headers, Some(request.body), request.stall_timeout).await?,
        ))
    }

    async fn open_ns_scanner(&self, request: NsScannerStreamRequest) -> Result<FileReader> {
        let url = build_ns_scanner_url(&request);
        let mut headers = msgpack_headers();
        build_auth_headers(&url, &Method::POST, &mut headers)?;
        Ok(Box::new(
            HttpReader::new_with_stall_timeout(url, Method::POST, headers, Some(request.body), request.stall_timeout).await?,
        ))
    }

    async fn probe_ns_scanner(&self, request: NsScannerCapabilityRequest) -> Result<Uuid> {
        Ok(self.probe_ns_scanner_capability(request).await?.server_epoch)
    }

    async fn probe_ns_scanner_capability(&self, request: NsScannerCapabilityRequest) -> Result<NsScannerCapabilityResponse> {
        if request.supports_tier_registry_generation {
            return match self.probe_ns_scanner_capability_once(&request).await {
                Ok(response) => Ok(response),
                Err(marked_error) if ns_scanner_capability_error_allows_legacy(&marked_error) => {
                    // A v3 peer may reject the additive query marker, ignore
                    // it, or return its legacy proof. Retry once without the
                    // marker and only downgrade after that legacy response is
                    // authenticated; an unverified epoch is never trusted.
                    let legacy_request = NsScannerCapabilityRequest {
                        endpoint: request.endpoint.clone(),
                        supports_tier_registry_generation: false,
                    };
                    match self.probe_ns_scanner_capability_once(&legacy_request).await {
                        Ok(mut response) => {
                            response.supports_tier_registry_generation = None;
                            Ok(response)
                        }
                        Err(legacy_error) if ns_scanner_capability_error_allows_legacy(&legacy_error) => {
                            // Some old deployments expose only the legacy
                            // protocol response (or advertise 426). Treat
                            // the pair as an explicit unsupported result so
                            // the scanner can use its coordinator fallback.
                            Err(Error::MethodNotAllowed)
                        }
                        Err(_) => Err(marked_error),
                    }
                }
                // A server failure, network failure, or authentication error
                // is not evidence of an old parser. Do not issue an
                // unauthenticated legacy probe or silently downgrade.
                Err(marked_error) => Err(marked_error),
            };
        }
        self.probe_ns_scanner_capability_once(&request).await
    }

    fn name(&self) -> &'static str {
        DEFAULT_INTERNODE_DATA_TRANSPORT
    }

    fn capabilities(&self) -> InternodeDataTransportCapabilities {
        InternodeDataTransportCapabilities::tcp_http()
    }
}

impl TcpHttpInternodeDataTransport {
    async fn probe_ns_scanner_capability_once(
        &self,
        request: &NsScannerCapabilityRequest,
    ) -> Result<NsScannerCapabilityResponse> {
        let challenge = Uuid::new_v4();
        let url = build_ns_scanner_capability_url(request, challenge);
        let mut headers = msgpack_headers();
        build_auth_headers(&url, &Method::GET, &mut headers)?;
        let reader = HttpReader::new(url, Method::GET, headers, None).await?;
        let mut body = Vec::new();
        reader
            .take(u64::try_from(NS_SCANNER_MAX_CAPABILITY_RESPONSE_SIZE + 1).unwrap_or(u64::MAX))
            .read_to_end(&mut body)
            .await?;
        if body.is_empty() || body.len() > NS_SCANNER_MAX_CAPABILITY_RESPONSE_SIZE {
            return Err(Error::other("invalid remote namespace scanner capability response size"));
        }
        let mut response: NsScannerCapabilityResponse =
            rmp_serde::from_slice(&body).map_err(|_| Error::other("invalid remote namespace scanner capability response"))?;
        if response.version != NS_SCANNER_PROTOCOL_VERSION || response.server_epoch.is_nil() {
            return Err(Error::other("incompatible remote namespace scanner capability response"));
        }
        if let Err(err) = verify_ns_scanner_capability_with_tier_registry_generation(
            challenge,
            response.server_epoch,
            &response.proof,
            request.supports_tier_registry_generation,
        ) {
            // A permissive older peer can ignore the additive marker and
            // return a valid legacy-scope proof with HTTP 200. Accept that
            // response only after independently authenticating the legacy
            // scope; all other verification failures remain fail-closed.
            if request.supports_tier_registry_generation && ns_scanner_capability_legacy_proof_is_valid(challenge, &response) {
                response.supports_tier_registry_generation = None;
                return Ok(response);
            }
            return Err(Error::other(format!("remote namespace scanner capability authentication failed: {err}")));
        }
        // The proof authenticates the requested capability scope, not the
        // optional response field. Derive the client-facing bit from that
        // verified scope so an intermediary cannot strip or rewrite the field
        // and force a silent downgrade after a successful generation-bound
        // handshake.
        normalize_ns_scanner_capability_response(&mut response, request.supports_tier_registry_generation);
        Ok(response)
    }

    async fn put_file_auth_capability(&self, endpoint: &str) -> Result<Option<Uuid>> {
        resolve_put_file_auth_capability(endpoint, || async {
            tokio::time::timeout(PUT_FILE_CAPABILITY_PROBE_TIMEOUT, self.probe_put_file_auth(endpoint))
                .await
                .map_err(|_| {
                    Error::from(rustfs_rio::internode_http_timeout_error(
                        &Method::GET,
                        &format!("{endpoint}{PUT_FILE_CAPABILITY_PATH}"),
                    ))
                })?
        })
        .await
    }

    async fn probe_put_file_auth(&self, endpoint: &str) -> Result<Option<Uuid>> {
        let challenge = Uuid::new_v4();
        let url = build_put_file_capability_url(endpoint, challenge);
        let mut headers = msgpack_headers();
        build_auth_headers(&url, &Method::GET, &mut headers)?;
        let reader = match HttpReader::new(url, Method::GET, headers, None).await {
            Ok(reader) => reader,
            Err(err) => {
                let err = Error::from(err);
                if matches!(
                    err.internode_http_error_kind(),
                    Some(rustfs_rio::InternodeHttpErrorKind::HttpStatus(status))
                        if put_file_capability_status_is_legacy(status.as_u16())
                ) {
                    return Ok(None);
                }
                return Err(err);
            }
        };
        let mut body = Vec::new();
        reader
            .take(u64::try_from(PUT_FILE_MAX_CAPABILITY_RESPONSE_SIZE + 1).unwrap_or(u64::MAX))
            .read_to_end(&mut body)
            .await?;
        Ok(Some(verify_put_file_capability_response(challenge, &body)?))
    }
}

async fn resolve_put_file_auth_capability<F, Fut>(endpoint: &str, probe: F) -> Result<Option<Uuid>>
where
    F: FnOnce() -> Fut,
    Fut: Future<Output = Result<Option<Uuid>>>,
{
    let entry = put_file_capability_cache_entry(endpoint);
    {
        let state = entry.read();
        if let Some(cached) = usable_put_file_capability(&state, Instant::now()) {
            return Ok(cached);
        }
    }

    let flight = {
        let mut state = entry.write();
        if let Some(cached) = usable_put_file_capability(&state, Instant::now()) {
            return Ok(cached);
        }
        if let Some(flight) = state.in_flight.clone() {
            flight
        } else {
            state.generation = state
                .generation
                .checked_add(1)
                .ok_or_else(|| Error::other("put_file capability probe generation exhausted"))?;
            let flight = PutFileCapabilityFlight {
                generation: state.generation,
                v1_was_pinned: matches!(state.cached, Some(PutFileCapabilityState::V1 { .. })),
                outcome: Arc::new(OnceCell::new()),
            };
            state.in_flight = Some(flight.clone());
            flight
        }
    };

    let outcome = flight
        .outcome
        .get_or_init(|| async { probe().await.map_err(PutFileCapabilityProbeFailure) })
        .await;

    {
        let mut state = entry.write();
        let is_current_flight = state
            .in_flight
            .as_ref()
            .is_some_and(|current| current.generation == flight.generation && Arc::ptr_eq(&current.outcome, &flight.outcome));
        if is_current_flight {
            match outcome {
                Ok(Some(server_epoch)) => {
                    if state.rejected_server_epoch != Some(*server_epoch) {
                        state.rejected_server_epoch = None;
                    }
                    state.cached = Some(PutFileCapabilityState::V1 {
                        server_epoch: *server_epoch,
                        revalidate_after: Instant::now() + PUT_FILE_V1_CAPABILITY_TTL,
                    });
                }
                Ok(None) if !flight.v1_was_pinned => {
                    state.cached = Some(PutFileCapabilityState::LegacyUntil(Instant::now() + PUT_FILE_LEGACY_CAPABILITY_TTL));
                }
                Ok(None) | Err(_) => {}
            }
            state.in_flight = None;
        }
    }

    match outcome {
        Ok(Some(server_epoch)) => Ok(Some(*server_epoch)),
        Ok(None) if flight.v1_was_pinned => Err(Error::other("remote put_file capability downgrade rejected")),
        Ok(None) => Ok(None),
        Err(failure) => Err(failure.to_error()),
    }
}

fn verify_put_file_capability_response(challenge: Uuid, body: &[u8]) -> Result<Uuid> {
    if body.is_empty() || body.len() > PUT_FILE_MAX_CAPABILITY_RESPONSE_SIZE {
        return Err(Error::other("invalid remote put_file capability response size"));
    }
    let response: PutFileCapabilityResponse =
        rmp_serde::from_slice(body).map_err(|_| Error::other("invalid remote put_file capability response"))?;
    if response.version != PUT_FILE_CAPABILITY_VERSION || response.server_epoch.is_nil() {
        return Err(Error::other("incompatible remote put_file capability response"));
    }
    verify_put_file_capability(challenge, response.server_epoch, response.version, &response.proof)
        .map_err(|err| Error::other(format!("remote put_file capability authentication failed: {err}")))?;
    Ok(response.server_epoch)
}

fn build_read_file_stream_url(request: &ReadStreamRequest) -> String {
    format!(
        "{}{}?disk={}&volume={}&path={}&offset={}&length={}",
        request.endpoint,
        READ_FILE_STREAM_PATH,
        urlencoding::encode(&request.disk),
        urlencoding::encode(&request.volume),
        urlencoding::encode(&request.path),
        request.offset,
        request.length
    )
}

fn build_put_file_stream_url(request: &WriteStreamRequest, auth_scope: Option<(Uuid, Uuid)>) -> String {
    let stream_path = if auth_scope.is_some() {
        PUT_FILE_AUTH_STREAM_PATH
    } else {
        PUT_FILE_STREAM_PATH
    };
    let mut url = format!(
        "{}{}?disk={}&volume={}&path={}&append={}&size={}",
        request.endpoint,
        stream_path,
        urlencoding::encode(&request.disk),
        urlencoding::encode(&request.volume),
        urlencoding::encode(&request.path),
        request.append,
        request.size
    );
    if let Some((nonce, server_epoch)) = auth_scope {
        url.push_str(&format!(
            "&{}={}&{}={}&{}={}",
            PUT_FILE_AUTH_QUERY, PUT_FILE_AUTH_V1, PUT_FILE_NONCE_QUERY, nonce, PUT_FILE_SERVER_EPOCH_QUERY, server_epoch
        ));
    }
    url
}

fn build_put_file_capability_url(endpoint: &str, challenge: Uuid) -> String {
    format!(
        "{}{}?{}={}&{}={}",
        endpoint,
        PUT_FILE_CAPABILITY_PATH,
        PUT_FILE_CAPABILITY_QUERY,
        PUT_FILE_CAPABILITY_VERSION,
        PUT_FILE_CAPABILITY_CHALLENGE_QUERY,
        challenge
    )
}

struct PutFileAuthWriter<W> {
    inner: W,
    url: String,
    nonce: Uuid,
    endpoint: String,
    server_epoch: Uuid,
    server_epoch_rejected: bool,
    hasher: Sha256,
    trailer: Option<Vec<u8>>,
    trailer_offset: usize,
}

impl<W> PutFileAuthWriter<W> {
    fn new(inner: W, url: String, nonce: Uuid, endpoint: String, server_epoch: Uuid) -> Self {
        Self {
            inner,
            url,
            nonce,
            endpoint,
            server_epoch,
            server_epoch_rejected: false,
            hasher: Sha256::new(),
            trailer: None,
            trailer_offset: 0,
        }
    }

    fn ensure_trailer(&mut self) -> std::io::Result<()> {
        if self.trailer.is_some() {
            return Ok(());
        }
        let digest = hex_simd::encode_to_string(self.hasher.clone().finalize(), hex_simd::AsciiCase::Lower);
        self.trailer = Some(build_put_file_auth_trailer(&self.url, &Method::PUT, self.nonce, &digest)?);
        Ok(())
    }

    fn reject_server_epoch_on_conflict(&mut self, error: &io::Error) {
        if self.server_epoch_rejected || !io_error_has_put_file_epoch_conflict(error) {
            return;
        }
        reject_put_file_server_epoch(&self.endpoint, self.server_epoch);
        self.server_epoch_rejected = true;
    }

    fn poll_write_trailer(&mut self, cx: &mut Context<'_>) -> Poll<std::io::Result<()>>
    where
        W: AsyncWrite + Unpin,
    {
        self.ensure_trailer()?;
        let Some(trailer) = self.trailer.as_ref() else {
            return Poll::Ready(Err(std::io::Error::other("put_file auth trailer missing")));
        };
        while self.trailer_offset < trailer.len() {
            let written = match Pin::new(&mut self.inner).poll_write(cx, &trailer[self.trailer_offset..]) {
                Poll::Ready(Ok(0)) => {
                    return Poll::Ready(Err(std::io::Error::new(
                        std::io::ErrorKind::WriteZero,
                        "failed to write put_file auth trailer",
                    )));
                }
                Poll::Ready(Ok(written)) => written,
                Poll::Ready(Err(err)) => {
                    self.reject_server_epoch_on_conflict(&err);
                    return Poll::Ready(Err(err));
                }
                Poll::Pending => return Poll::Pending,
            };
            self.trailer_offset += written;
        }
        Poll::Ready(Ok(()))
    }
}

fn io_error_has_put_file_epoch_conflict(error: &io::Error) -> bool {
    error
        .get_ref()
        .and_then(|source| source.downcast_ref::<rustfs_rio::InternodeHttpError>())
        .is_some_and(
            |error| matches!(error.kind(), rustfs_rio::InternodeHttpErrorKind::HttpStatus(status) if status.as_u16() == 409),
        )
}

impl<W> AsyncWrite for PutFileAuthWriter<W>
where
    W: AsyncWrite + Unpin,
{
    fn poll_write(mut self: Pin<&mut Self>, cx: &mut Context<'_>, buf: &[u8]) -> Poll<std::io::Result<usize>> {
        if self.trailer.is_some() {
            return Poll::Ready(Err(std::io::Error::new(
                std::io::ErrorKind::BrokenPipe,
                "cannot write after put_file auth trailer",
            )));
        }
        match Pin::new(&mut self.inner).poll_write(cx, buf) {
            Poll::Ready(Ok(written)) => {
                self.hasher.update(&buf[..written]);
                Poll::Ready(Ok(written))
            }
            Poll::Ready(Err(err)) => {
                self.reject_server_epoch_on_conflict(&err);
                Poll::Ready(Err(err))
            }
            Poll::Pending => Poll::Pending,
        }
    }

    fn poll_flush(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<std::io::Result<()>> {
        match Pin::new(&mut self.inner).poll_flush(cx) {
            Poll::Ready(Err(err)) => {
                self.reject_server_epoch_on_conflict(&err);
                Poll::Ready(Err(err))
            }
            other => other,
        }
    }

    fn poll_shutdown(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<std::io::Result<()>> {
        match self.poll_write_trailer(cx) {
            Poll::Ready(Ok(())) => {}
            Poll::Ready(Err(err)) => return Poll::Ready(Err(err)),
            Poll::Pending => return Poll::Pending,
        }
        match Pin::new(&mut self.inner).poll_shutdown(cx) {
            Poll::Ready(Err(err)) => {
                self.reject_server_epoch_on_conflict(&err);
                Poll::Ready(Err(err))
            }
            other => other,
        }
    }
}

fn build_walk_dir_url(request: &WalkDirStreamRequest) -> String {
    let body_sha256 = hex_simd::encode_to_string(Sha256::digest(&request.body), hex_simd::AsciiCase::Lower);
    format!(
        "{}{}?disk={}&{}={}&{}={}",
        request.endpoint,
        WALK_DIR_PATH,
        urlencoding::encode(&request.disk),
        WALK_DIR_STREAM_COMPLETION_QUERY,
        WALK_DIR_STREAM_COMPLETION_V1,
        WALK_DIR_BODY_SHA256_QUERY,
        body_sha256
    )
}

fn normalize_ns_scanner_capability_response(response: &mut NsScannerCapabilityResponse, requested_generation_support: bool) {
    response.supports_tier_registry_generation = requested_generation_support.then_some(true);
}

fn ns_scanner_capability_legacy_proof_is_valid(challenge: Uuid, response: &NsScannerCapabilityResponse) -> bool {
    verify_ns_scanner_capability_with_tier_registry_generation(challenge, response.server_epoch, &response.proof, false).is_ok()
}

fn build_ns_scanner_url(request: &NsScannerStreamRequest) -> String {
    let body_sha256 = hex_simd::encode_to_string(Sha256::digest(&request.body), hex_simd::AsciiCase::Lower);
    format!(
        "{}{}?disk={}&{}={}&{}={}&{}={}&{}={}&{}={}&{}={}&{}={}",
        request.endpoint,
        NS_SCANNER_PATH,
        urlencoding::encode(&request.disk),
        NS_SCANNER_REQUEST_ID_QUERY,
        request.request_id,
        NS_SCANNER_SERVER_EPOCH_QUERY,
        request.server_epoch,
        NS_SCANNER_SESSION_ID_QUERY,
        request.session_id,
        NS_SCANNER_SESSION_SEQUENCE_QUERY,
        request.session_sequence,
        NS_SCANNER_CYCLE_QUERY,
        request.next_cycle,
        NS_SCANNER_LEADER_EPOCH_QUERY,
        request.leader_epoch,
        NS_SCANNER_BODY_SHA256_QUERY,
        body_sha256
    )
}

fn build_ns_scanner_capability_url(request: &NsScannerCapabilityRequest, challenge: Uuid) -> String {
    format!(
        "{}{}?{}={}&{}={}{}",
        request.endpoint,
        NS_SCANNER_PATH,
        NS_SCANNER_PROTOCOL_VERSION_QUERY,
        NS_SCANNER_PROTOCOL_VERSION,
        NS_SCANNER_CAPABILITY_CHALLENGE_QUERY,
        challenge,
        if request.supports_tier_registry_generation {
            format!("&{}=true", NS_SCANNER_TIER_REGISTRY_GENERATION_QUERY)
        } else {
            String::new()
        }
    )
}

fn json_headers() -> HeaderMap {
    let mut headers = HeaderMap::new();
    headers.insert(CONTENT_TYPE, HeaderValue::from_static(CONTENT_TYPE_JSON));
    headers
}

fn msgpack_headers() -> HeaderMap {
    let mut headers = HeaderMap::new();
    headers.insert(CONTENT_TYPE, HeaderValue::from_static(CONTENT_TYPE_MSGPACK));
    headers
}

fn build_internode_data_transport_result(
    configured_transport: Option<&str>,
) -> std::result::Result<Arc<dyn InternodeDataTransport>, String> {
    match configured_transport.map(str::trim).filter(|transport| !transport.is_empty()) {
        None => Ok(Arc::new(TcpHttpInternodeDataTransport)),
        Some(transport)
            if transport.eq_ignore_ascii_case(DEFAULT_INTERNODE_DATA_TRANSPORT)
                || transport.eq_ignore_ascii_case(INTERNODE_DATA_TRANSPORT_TCP) =>
        {
            Ok(Arc::new(TcpHttpInternodeDataTransport))
        }
        Some(transport) => Err(unsupported_transport_message(transport)),
    }
}

#[allow(
    dead_code,
    reason = "live in the cfg(test) half of build_internode_data_transport_from_env, which bypasses the process static (backlog#1823)"
)]
pub fn build_internode_data_transport(configured_transport: Option<&str>) -> Result<Arc<dyn InternodeDataTransport>> {
    build_internode_data_transport_result(configured_transport).map_err(Error::other)
}

pub fn build_internode_data_transport_from_env() -> Result<Arc<dyn InternodeDataTransport>> {
    let configured_transport = std::env::var(ENV_RUSTFS_INTERNODE_DATA_TRANSPORT).ok();
    #[cfg(test)]
    {
        build_internode_data_transport(configured_transport.as_deref())
    }

    #[cfg(not(test))]
    INTERNODE_DATA_TRANSPORT
        .get_or_init(|| build_internode_data_transport_result(configured_transport.as_deref()))
        .as_ref()
        .map(Arc::clone)
        .map_err(|err| Error::other(err.clone()))
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::sync::atomic::{AtomicBool, AtomicUsize, Ordering};
    use tokio::io::AsyncWriteExt;
    use tokio::sync::{Barrier, Notify};

    async fn wait_for_capability_flight_waiters(entry: &PutFileCapabilityCacheEntry, waiters: usize) {
        tokio::time::timeout(Duration::from_secs(5), async {
            loop {
                let strong_count = entry
                    .read()
                    .in_flight
                    .as_ref()
                    .map(|flight| Arc::strong_count(&flight.outcome))
                    .unwrap_or_default();
                if strong_count > waiters {
                    return;
                }
                tokio::task::yield_now().await;
            }
        })
        .await
        .expect("capability callers should join the in-flight probe");
    }

    #[derive(Debug)]
    struct LegacyTestTransport;

    #[derive(Clone, Copy, Debug)]
    enum PutFileFailurePhase {
        Write,
        Flush,
        Shutdown,
    }

    struct PutFileFailureWriter {
        phase: PutFileFailurePhase,
        status: reqwest::StatusCode,
    }

    impl PutFileFailureWriter {
        fn error(&self) -> io::Error {
            rustfs_rio::new_test_internode_http_io_error(rustfs_rio::InternodeHttpErrorKind::HttpStatus(self.status))
        }
    }

    impl tokio::io::AsyncWrite for PutFileFailureWriter {
        fn poll_write(self: Pin<&mut Self>, _cx: &mut Context<'_>, buf: &[u8]) -> Poll<std::io::Result<usize>> {
            Poll::Ready(if matches!(self.phase, PutFileFailurePhase::Write) {
                Err(self.error())
            } else {
                Ok(buf.len())
            })
        }

        fn poll_flush(self: Pin<&mut Self>, _cx: &mut Context<'_>) -> Poll<std::io::Result<()>> {
            Poll::Ready(if matches!(self.phase, PutFileFailurePhase::Flush) {
                Err(self.error())
            } else {
                Ok(())
            })
        }

        fn poll_shutdown(self: Pin<&mut Self>, _cx: &mut Context<'_>) -> Poll<std::io::Result<()>> {
            Poll::Ready(if matches!(self.phase, PutFileFailurePhase::Shutdown) {
                Err(self.error())
            } else {
                Ok(())
            })
        }
    }

    #[async_trait::async_trait]
    impl InternodeDataTransport for LegacyTestTransport {
        async fn open_read(&self, _request: ReadStreamRequest) -> Result<FileReader> {
            Ok(Box::new(tokio::io::empty()))
        }

        async fn open_write(&self, _request: WriteStreamRequest) -> Result<FileWriter> {
            Ok(Box::new(tokio::io::sink()))
        }

        async fn open_walk_dir(&self, _request: WalkDirStreamRequest) -> Result<FileReader> {
            Ok(Box::new(tokio::io::empty()))
        }

        fn name(&self) -> &'static str {
            "legacy-test"
        }

        fn capabilities(&self) -> InternodeDataTransportCapabilities {
            InternodeDataTransportCapabilities::tcp_http()
        }
    }

    #[tokio::test]
    async fn legacy_transport_defaults_namespace_scanner_to_unsupported() {
        let transport = LegacyTestTransport;

        let probe_err = transport
            .probe_ns_scanner(NsScannerCapabilityRequest {
                endpoint: "http://node1:9000".to_string(),
                supports_tier_registry_generation: false,
            })
            .await
            .expect_err("legacy transport should report namespace scanner as unsupported");
        assert!(matches!(probe_err, Error::MethodNotAllowed));

        let open_result = transport
            .open_ns_scanner(NsScannerStreamRequest {
                endpoint: "http://node1:9000".to_string(),
                disk: "http://node1:9000/data/rustfs0".to_string(),
                request_id: Uuid::new_v4(),
                server_epoch: Uuid::new_v4(),
                session_id: Uuid::new_v4(),
                session_sequence: 0,
                next_cycle: 7,
                leader_epoch: 9,
                body: Vec::new(),
                stall_timeout: None,
            })
            .await;
        let open_err = match open_result {
            Ok(_) => panic!("legacy transport should not open namespace scanner streams"),
            Err(err) => err,
        };
        assert!(matches!(open_err, Error::MethodNotAllowed));
    }

    #[tokio::test]
    async fn walk_dir_restores_explicit_remote_missing_error() {
        let _ = rustfs_credentials::set_global_rpc_secret("walk-dir-error-test-secret".to_string());
        let listener = match tokio::net::TcpListener::bind("127.0.0.1:0").await {
            Ok(listener) => listener,
            Err(err) if err.kind() == io::ErrorKind::PermissionDenied => return,
            Err(err) => panic!("test listener should bind: {err}"),
        };
        let addr = listener.local_addr().expect("test listener address should be available");
        let server = tokio::spawn(async move {
            let (mut socket, _) = listener.accept().await.expect("test server should accept the request");
            let mut request = [0_u8; 2048];
            let _ = socket.read(&mut request).await.expect("request should be readable");
            socket
                .write_all(
                    b"HTTP/1.1 500 Internal Server Error\r\nx-rustfs-disk-error: file-not-found\r\ncontent-length: 0\r\nconnection: close\r\n\r\n",
                )
                .await
                .expect("typed disk error response should be writable");
        });

        let endpoint = format!("http://{addr}");
        let error = match TcpHttpInternodeDataTransport
            .open_walk_dir(WalkDirStreamRequest {
                endpoint: endpoint.clone(),
                disk: "disk-a".to_string(),
                body: b"{}".to_vec(),
                stall_timeout: Some(Duration::from_secs(2)),
            })
            .await
        {
            Ok(_) => panic!("an explicit remote missing-path response must fail the open"),
            Err(error) => error,
        };

        assert!(matches!(error, Error::FileNotFound));
        server.await.expect("test server task should finish");
    }

    #[test]
    fn tcp_http_capabilities_are_behavior_preserving() {
        let transport = TcpHttpInternodeDataTransport;

        assert_eq!(transport.name(), DEFAULT_INTERNODE_DATA_TRANSPORT);
        assert_eq!(
            transport.capabilities(),
            InternodeDataTransportCapabilities {
                streaming_read: true,
                streaming_write: true,
                streaming_walk_dir: true,
                ordered_delivery: true,
                max_transfer_size: None,
                fallback_supported: true,
            }
        );
    }

    #[test]
    fn tcp_http_capabilities_are_conservative() {
        let capabilities = TcpHttpInternodeDataTransport.capabilities();

        assert!(capabilities.ordered_delivery);
        assert_eq!(capabilities.max_transfer_size, None);
        assert!(capabilities.fallback_supported);
    }

    #[test]
    fn read_file_stream_url_encodes_query_values() {
        let url = build_read_file_stream_url(&ReadStreamRequest {
            endpoint: "http://node1:9000".to_string(),
            disk: "http://node1:9000/data/rustfs0".to_string(),
            volume: ".rustfs.sys".to_string(),
            path: "pool.bin/../part.1".to_string(),
            offset: 7,
            length: 11,
            stall_timeout: None,
        });

        assert_eq!(
            url,
            "http://node1:9000/rustfs/rpc/read_file_stream?disk=http%3A%2F%2Fnode1%3A9000%2Fdata%2Frustfs0&volume=.rustfs.sys&path=pool.bin%2F..%2Fpart.1&offset=7&length=11"
        );
    }

    #[test]
    fn put_file_stream_url_encodes_query_values() {
        let url = build_put_file_stream_url(
            &WriteStreamRequest {
                endpoint: "http://node1:9000".to_string(),
                disk: "http://node1:9000/data/rustfs0".to_string(),
                volume: "bucket".to_string(),
                path: "object/part.1".to_string(),
                append: false,
                size: 4096,
            },
            None,
        );

        assert_eq!(
            url,
            "http://node1:9000/rustfs/rpc/put_file_stream?disk=http%3A%2F%2Fnode1%3A9000%2Fdata%2Frustfs0&volume=bucket&path=object%2Fpart.1&append=false&size=4096"
        );
    }

    #[test]
    fn put_file_stream_url_advertises_auth_nonce_when_enabled() {
        let nonce = Uuid::parse_str("11111111-2222-4333-8444-555555555555").expect("nonce");
        let server_epoch = Uuid::parse_str("aaaaaaaa-bbbb-4ccc-8ddd-eeeeeeeeeeee").expect("server epoch");
        let url = build_put_file_stream_url(
            &WriteStreamRequest {
                endpoint: "http://node1:9000".to_string(),
                disk: "http://node1:9000/data/rustfs0".to_string(),
                volume: "bucket".to_string(),
                path: "object/part.1".to_string(),
                append: false,
                size: 4096,
            },
            Some((nonce, server_epoch)),
        );

        assert_eq!(
            url,
            concat!(
                "http://node1:9000/rustfs/rpc/put_file_stream_v1?disk=http%3A%2F%2Fnode1%3A9000%2Fdata%2Frustfs0",
                "&volume=bucket&path=object%2Fpart.1&append=false&size=4096",
                "&put_file_auth=digest-trailer-v1&put_file_nonce=11111111-2222-4333-8444-555555555555",
                "&put_file_server_epoch=aaaaaaaa-bbbb-4ccc-8ddd-eeeeeeeeeeee"
            )
        );
    }

    #[test]
    fn put_file_capability_url_binds_version_and_challenge() {
        let challenge = Uuid::parse_str("11111111-2222-4333-8444-555555555555").expect("challenge");

        assert_eq!(
            build_put_file_capability_url("http://node1:9000", challenge),
            concat!(
                "http://node1:9000/rustfs/rpc/put_file_capability?put_file_capability=1",
                "&put_file_challenge=11111111-2222-4333-8444-555555555555"
            )
        );
    }

    #[test]
    fn put_file_capability_legacy_statuses_are_exact() {
        assert!(put_file_capability_status_is_legacy(404));
        for status in [200, 400, 401, 403, 405, 408, 426, 429, 500, 503] {
            assert!(!put_file_capability_status_is_legacy(status));
        }
    }

    #[test]
    fn put_file_capability_timeout_is_retryable() {
        let error = Error::from(rustfs_rio::internode_http_timeout_error(
            &Method::GET,
            "http://node:9000/rustfs/rpc/put_file_capability",
        ));

        assert_eq!(
            error.internode_http_error_kind(),
            Some(rustfs_rio::InternodeHttpErrorKind::ConnectTimeout)
        );
        assert!(error.is_retryable_internode_write_failure());
    }

    #[tokio::test]
    async fn put_file_capability_cache_pins_v1_and_honors_live_legacy_ttl() {
        let transport = TcpHttpInternodeDataTransport;
        let v1_endpoint = format!("http://v1-{}.invalid", Uuid::new_v4());
        let v1_entry = put_file_capability_cache_entry(&v1_endpoint);
        let server_epoch = Uuid::new_v4();
        v1_entry.write().cached = Some(PutFileCapabilityState::V1 {
            server_epoch,
            revalidate_after: Instant::now() + PUT_FILE_V1_CAPABILITY_TTL,
        });
        assert_eq!(
            transport.put_file_auth_capability(&v1_endpoint).await.expect("v1 cache"),
            Some(server_epoch)
        );
        let cache_probe_called = AtomicBool::new(false);
        assert_eq!(
            resolve_put_file_auth_capability(&v1_endpoint, || async {
                cache_probe_called.store(true, Ordering::SeqCst);
                Ok(None)
            })
            .await
            .expect("live v1 cache"),
            Some(server_epoch)
        );
        assert!(!cache_probe_called.load(Ordering::SeqCst));
        v1_entry.write().cached = Some(PutFileCapabilityState::V1 {
            server_epoch,
            revalidate_after: Instant::now(),
        });
        assert!(
            resolve_put_file_auth_capability(&v1_endpoint, || async { Ok(None) })
                .await
                .is_err()
        );
        let replacement_epoch = Uuid::new_v4();
        assert_eq!(
            resolve_put_file_auth_capability(&v1_endpoint, || async { Ok(Some(replacement_epoch)) })
                .await
                .expect("authenticated replacement should refresh the epoch"),
            Some(replacement_epoch)
        );

        let legacy_endpoint = format!("http://legacy-{}.invalid", Uuid::new_v4());
        let legacy_entry = put_file_capability_cache_entry(&legacy_endpoint);
        legacy_entry.write().cached = Some(PutFileCapabilityState::LegacyUntil(Instant::now() + PUT_FILE_LEGACY_CAPABILITY_TTL));
        assert!(
            transport
                .put_file_auth_capability(&legacy_endpoint)
                .await
                .expect("legacy cache")
                .is_none()
        );

        let expired_endpoint = format!("http://expired-legacy-{}.invalid", Uuid::new_v4());
        let expired_entry = put_file_capability_cache_entry(&expired_endpoint);
        expired_entry.write().cached = Some(PutFileCapabilityState::LegacyUntil(Instant::now()));
        let reprobed = std::sync::atomic::AtomicBool::new(false);
        assert_eq!(
            resolve_put_file_auth_capability(&expired_endpoint, || async {
                reprobed.store(true, std::sync::atomic::Ordering::SeqCst);
                Ok(Some(server_epoch))
            })
            .await
            .expect("expired legacy cache should reprobe"),
            Some(server_epoch)
        );
        assert!(reprobed.load(std::sync::atomic::Ordering::SeqCst));
    }

    #[tokio::test]
    async fn legacy_put_file_capability_omits_the_auth_trailer_protocol() {
        let endpoint = format!("http://legacy-selection-{}.invalid", Uuid::new_v4());
        let server_epoch = resolve_put_file_auth_capability(&endpoint, || async { Ok(None) })
            .await
            .expect("legacy capability result");
        let auth_scope = server_epoch.map(|epoch| (Uuid::new_v4(), epoch));
        let url = build_put_file_stream_url(
            &WriteStreamRequest {
                endpoint,
                disk: "http://node1:9000/data/rustfs0".to_string(),
                volume: "bucket".to_string(),
                path: "object/part.1".to_string(),
                append: false,
                size: 4096,
            },
            auth_scope,
        );

        assert!(auth_scope.is_none());
        assert!(!url.contains(PUT_FILE_AUTH_QUERY));
        assert!(!url.contains(PUT_FILE_NONCE_QUERY));
    }

    #[tokio::test]
    async fn put_file_capability_probe_is_singleflight_per_endpoint() {
        let endpoint = format!("http://singleflight-{}.invalid", Uuid::new_v4());
        let entry = put_file_capability_cache_entry(&endpoint);
        let calls = Arc::new(AtomicUsize::new(0));
        let release = Arc::new(Notify::new());
        let start = Arc::new(Barrier::new(65));
        let mut tasks = Vec::with_capacity(64);

        for _ in 0..64 {
            let endpoint = endpoint.clone();
            let calls = Arc::clone(&calls);
            let release = Arc::clone(&release);
            let start = Arc::clone(&start);
            tasks.push(tokio::spawn(async move {
                start.wait().await;
                resolve_put_file_auth_capability(&endpoint, || async move {
                    calls.fetch_add(1, Ordering::SeqCst);
                    release.notified().await;
                    Err(Error::from(rustfs_rio::new_test_internode_http_io_error(
                        rustfs_rio::InternodeHttpErrorKind::ConnectionRefused,
                    )))
                })
                .await
            }));
        }

        start.wait().await;
        wait_for_capability_flight_waiters(&entry, 64).await;
        assert_eq!(calls.load(Ordering::SeqCst), 1);
        release.notify_waiters();

        let results = tokio::time::timeout(Duration::from_secs(1), futures::future::join_all(tasks))
            .await
            .expect("all callers should finish within one probe window");
        for result in results {
            let error = result.expect("capability task should finish").expect_err("probe should fail");
            assert_eq!(
                error.internode_http_error_kind(),
                Some(rustfs_rio::InternodeHttpErrorKind::ConnectionRefused)
            );
            assert!(error.is_retryable_internode_write_failure());
        }
        assert_eq!(calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn put_file_capability_probe_recovers_when_initializer_is_cancelled() {
        let endpoint = format!("http://cancelled-singleflight-{}.invalid", Uuid::new_v4());
        let entry = put_file_capability_cache_entry(&endpoint);
        let calls = Arc::new(AtomicUsize::new(0));
        let initializer_started = Arc::new(Notify::new());
        let never_release = Arc::new(Notify::new());

        let first = {
            let endpoint = endpoint.clone();
            let calls = Arc::clone(&calls);
            let initializer_started = Arc::clone(&initializer_started);
            let never_release = Arc::clone(&never_release);
            tokio::spawn(async move {
                resolve_put_file_auth_capability(&endpoint, || async move {
                    calls.fetch_add(1, Ordering::SeqCst);
                    initializer_started.notify_one();
                    never_release.notified().await;
                    Ok(Some(Uuid::new_v4()))
                })
                .await
            })
        };
        initializer_started.notified().await;

        let replacement_epoch = Uuid::new_v4();
        let second = {
            let endpoint = endpoint.clone();
            let calls = Arc::clone(&calls);
            tokio::spawn(async move {
                resolve_put_file_auth_capability(&endpoint, || async move {
                    calls.fetch_add(1, Ordering::SeqCst);
                    Ok(Some(replacement_epoch))
                })
                .await
            })
        };
        wait_for_capability_flight_waiters(&entry, 2).await;
        first.abort();
        assert!(first.await.expect_err("initializer should be cancelled").is_cancelled());

        assert_eq!(
            second.await.expect("waiter should finish").expect("waiter should take over"),
            Some(replacement_epoch)
        );
        assert_eq!(calls.load(Ordering::SeqCst), 2);
    }

    #[tokio::test]
    async fn put_file_capability_probe_recovers_after_all_callers_cancel() {
        let endpoint = format!("http://all-cancelled-{}.invalid", Uuid::new_v4());
        let entry = put_file_capability_cache_entry(&endpoint);
        let calls = Arc::new(AtomicUsize::new(0));
        let initializer_started = Arc::new(Notify::new());
        let never_release = Arc::new(Notify::new());

        let first = {
            let endpoint = endpoint.clone();
            let calls = Arc::clone(&calls);
            let initializer_started = Arc::clone(&initializer_started);
            let never_release = Arc::clone(&never_release);
            tokio::spawn(async move {
                resolve_put_file_auth_capability(&endpoint, || async move {
                    calls.fetch_add(1, Ordering::SeqCst);
                    initializer_started.notify_one();
                    never_release.notified().await;
                    Ok(None)
                })
                .await
            })
        };
        initializer_started.notified().await;
        let second = {
            let endpoint = endpoint.clone();
            let calls = Arc::clone(&calls);
            tokio::spawn(async move {
                resolve_put_file_auth_capability(&endpoint, || async move {
                    calls.fetch_add(1, Ordering::SeqCst);
                    Ok(None)
                })
                .await
            })
        };
        wait_for_capability_flight_waiters(&entry, 2).await;
        first.abort();
        second.abort();
        assert!(first.await.expect_err("initializer should be cancelled").is_cancelled());
        assert!(second.await.expect_err("waiter should be cancelled").is_cancelled());

        let server_epoch = Uuid::new_v4();
        assert_eq!(
            resolve_put_file_auth_capability(&endpoint, || async {
                calls.fetch_add(1, Ordering::SeqCst);
                Ok(Some(server_epoch))
            })
            .await
            .expect("later caller should initialize the abandoned flight"),
            Some(server_epoch)
        );
        assert_eq!(calls.load(Ordering::SeqCst), 2);
    }

    #[tokio::test]
    async fn put_file_capability_failed_wave_can_retry_immediately() {
        let endpoint = format!("http://retry-after-failure-{}.invalid", Uuid::new_v4());
        let first = resolve_put_file_auth_capability(&endpoint, || async { Err(Error::Timeout) }).await;
        assert!(matches!(first, Err(Error::Timeout)));

        let server_epoch = Uuid::new_v4();
        assert_eq!(
            resolve_put_file_auth_capability(&endpoint, || async { Ok(Some(server_epoch)) })
                .await
                .expect("new request should reprobe"),
            Some(server_epoch)
        );
    }

    #[tokio::test]
    async fn put_file_capability_probes_different_endpoints_in_parallel() {
        let first_endpoint = format!("http://parallel-a-{}.invalid", Uuid::new_v4());
        let second_endpoint = format!("http://parallel-b-{}.invalid", Uuid::new_v4());
        let probes_started = Arc::new(Barrier::new(2));
        let first_barrier = Arc::clone(&probes_started);
        let second_barrier = Arc::clone(&probes_started);

        let results = tokio::time::timeout(Duration::from_secs(5), async {
            tokio::join!(
                resolve_put_file_auth_capability(&first_endpoint, || async move {
                    first_barrier.wait().await;
                    Ok(None)
                }),
                resolve_put_file_auth_capability(&second_endpoint, || async move {
                    second_barrier.wait().await;
                    Ok(None)
                })
            )
        })
        .await
        .expect("different endpoints should not serialize");
        assert!(results.0.expect("first result").is_none());
        assert!(results.1.expect("second result").is_none());
    }

    #[tokio::test]
    async fn stale_put_file_capability_flight_cannot_overwrite_newer_state() {
        let endpoint = format!("http://stale-flight-{}.invalid", Uuid::new_v4());
        let entry = put_file_capability_cache_entry(&endpoint);
        let probe_started = Arc::new(Notify::new());
        let release = Arc::new(Notify::new());
        let stale_epoch = Uuid::new_v4();
        let newer_epoch = Uuid::new_v4();

        let task = {
            let endpoint = endpoint.clone();
            let probe_started = Arc::clone(&probe_started);
            let release = Arc::clone(&release);
            tokio::spawn(async move {
                resolve_put_file_auth_capability(&endpoint, || async move {
                    probe_started.notify_one();
                    release.notified().await;
                    Ok(Some(stale_epoch))
                })
                .await
            })
        };
        probe_started.notified().await;
        {
            let mut state = entry.write();
            state.generation = state.generation.checked_add(1).expect("test generation should advance");
            state.cached = Some(PutFileCapabilityState::V1 {
                server_epoch: newer_epoch,
                revalidate_after: Instant::now() + PUT_FILE_V1_CAPABILITY_TTL,
            });
            state.in_flight = None;
        }
        release.notify_one();
        assert_eq!(
            task.await.expect("stale task should finish").expect("stale probe result"),
            Some(stale_epoch)
        );
        assert_eq!(fresh_put_file_capability(entry.read().cached, Instant::now()), Some(Some(newer_epoch)));
    }

    #[test]
    fn put_file_capability_response_fails_closed_on_malformed_or_unbound_data() {
        let _ = rustfs_credentials::set_global_rpc_secret("put-file-capability-response-test-secret".to_string());
        let challenge = Uuid::parse_str("11111111-2222-4333-8444-555555555555").expect("challenge");
        let server_epoch = Uuid::parse_str("aaaaaaaa-bbbb-4ccc-8ddd-eeeeeeeeeeee").expect("server epoch");
        let proof = crate::cluster::rpc::sign_put_file_capability(challenge, server_epoch, PUT_FILE_CAPABILITY_VERSION)
            .expect("proof should build");
        let response = PutFileCapabilityResponse {
            version: PUT_FILE_CAPABILITY_VERSION,
            server_epoch,
            proof,
        };
        let body = rmp_serde::to_vec_named(&response).expect("response should encode");

        assert_eq!(
            verify_put_file_capability_response(challenge, &body).expect("response should verify"),
            server_epoch
        );
        assert!(verify_put_file_capability_response(Uuid::new_v4(), &body).is_err());
        assert!(verify_put_file_capability_response(challenge, &body[..body.len() - 1]).is_err());
        assert!(verify_put_file_capability_response(challenge, &[]).is_err());
        assert!(verify_put_file_capability_response(challenge, &vec![0_u8; PUT_FILE_MAX_CAPABILITY_RESPONSE_SIZE + 1]).is_err());
    }

    #[tokio::test]
    async fn put_file_auth_writer_appends_trailer_on_shutdown() {
        use tokio::io::AsyncWriteExt;

        let _ = rustfs_credentials::set_global_rpc_secret("put-file-auth-writer-test-secret".to_string());
        let nonce = Uuid::parse_str("11111111-2222-4333-8444-555555555555").expect("nonce");
        let server_epoch = Uuid::parse_str("aaaaaaaa-bbbb-4ccc-8ddd-eeeeeeeeeeee").expect("server epoch");
        let endpoint = "http://node1:9000".to_string();
        let url = concat!(
            "http://node1:9000/rustfs/rpc/put_file_stream?disk=disk-a&volume=bucket&path=object%2Fpart.1",
            "&append=false&size=11&put_file_auth=digest-trailer-v1&put_file_nonce=11111111-2222-4333-8444-555555555555"
        )
        .to_string();
        let mut sink = Vec::new();

        {
            let mut writer = PutFileAuthWriter::new(&mut sink, url.clone(), nonce, endpoint, server_epoch);
            writer.write_all(b"hello world").await.expect("body write should succeed");
            writer.shutdown().await.expect("shutdown should append auth trailer");
            let err = writer
                .write_all(b"!")
                .await
                .expect_err("post-trailer writes must be rejected");
            assert_eq!(err.kind(), std::io::ErrorKind::BrokenPipe);
        }

        assert_eq!(&sink[..11], b"hello world");
        let trailer = &sink[11..];
        let expected_digest = hex_simd::encode_to_string(Sha256::digest(b"hello world"), hex_simd::AsciiCase::Lower);
        let verified = crate::cluster::rpc::verify_put_file_auth_trailer(&url, &Method::PUT, nonce, trailer)
            .expect("emitted trailer should verify");
        assert_eq!(verified, expected_digest);
    }

    #[tokio::test]
    async fn put_file_auth_writer_reprobes_after_server_epoch_conflict() {
        use tokio::io::AsyncWriteExt;

        let _ = rustfs_credentials::set_global_rpc_secret("put-file-epoch-conflict-test-secret".to_string());
        for status in [reqwest::StatusCode::CONFLICT, reqwest::StatusCode::BAD_REQUEST] {
            for (phase, trailer_write) in [
                (PutFileFailurePhase::Write, false),
                (PutFileFailurePhase::Write, true),
                (PutFileFailurePhase::Flush, false),
                (PutFileFailurePhase::Shutdown, false),
            ] {
                let endpoint = format!("http://epoch-conflict-{}.invalid", Uuid::new_v4());
                let stale_epoch = Uuid::new_v4();
                let replacement_epoch = Uuid::new_v4();
                resolve_put_file_auth_capability(&endpoint, || async { Ok(Some(stale_epoch)) })
                    .await
                    .expect("initial capability should resolve");
                let mut writer = PutFileAuthWriter::new(
                    PutFileFailureWriter { phase, status },
                    format!("{endpoint}{PUT_FILE_AUTH_STREAM_PATH}"),
                    Uuid::new_v4(),
                    endpoint.clone(),
                    stale_epoch,
                );
                let error = match (phase, trailer_write) {
                    (PutFileFailurePhase::Write, false) => writer.write_all(b"body").await,
                    (PutFileFailurePhase::Flush, _) => writer.flush().await,
                    _ => writer.shutdown().await,
                }
                .expect_err("injected writer error must reach the caller");
                let conflict = status == reqwest::StatusCode::CONFLICT;
                assert_eq!(io_error_has_put_file_epoch_conflict(&error), conflict);

                let probe_called = AtomicBool::new(false);
                let resolved = resolve_put_file_auth_capability(&endpoint, || async {
                    probe_called.store(true, Ordering::SeqCst);
                    Ok(Some(replacement_epoch))
                })
                .await
                .expect("capability should remain usable or be reprobed");
                assert_eq!(probe_called.load(Ordering::SeqCst), conflict, "phase={phase:?}, trailer={trailer_write}");
                assert_eq!(resolved, Some(if conflict { replacement_epoch } else { stale_epoch }));
            }
        }
    }

    #[tokio::test]
    async fn late_put_file_epoch_rejection_preserves_current_rejection() {
        let endpoint = format!("http://late-epoch-conflict-{}.invalid", Uuid::new_v4());
        let old_epoch = Uuid::new_v4();
        let current_epoch = Uuid::new_v4();
        let replacement_epoch = Uuid::new_v4();
        assert_eq!(
            resolve_put_file_auth_capability(&endpoint, || async { Ok(Some(old_epoch)) })
                .await
                .expect("initial epoch should be cached"),
            Some(old_epoch)
        );
        reject_put_file_server_epoch(&endpoint, old_epoch);
        assert_eq!(
            resolve_put_file_auth_capability(&endpoint, || async { Ok(Some(current_epoch)) })
                .await
                .expect("first restart should install a new epoch"),
            Some(current_epoch)
        );

        reject_put_file_server_epoch(&endpoint, current_epoch);
        // A writer opened before the first restart can report its 409 after
        // a newer writer has already rejected the second server incarnation.
        reject_put_file_server_epoch(&endpoint, old_epoch);
        let probe_called = AtomicBool::new(false);
        let resolved = resolve_put_file_auth_capability(&endpoint, || async {
            probe_called.store(true, Ordering::SeqCst);
            Ok(Some(replacement_epoch))
        })
        .await
        .expect("late old-epoch rejection must preserve the current rejection");

        assert!(probe_called.load(Ordering::SeqCst), "known-rejected current epoch must be reprobed");
        assert_eq!(resolved, Some(replacement_epoch));
    }

    #[tokio::test]
    async fn put_file_epoch_rejection_is_endpoint_and_epoch_scoped() {
        let endpoint = format!("http://scoped-epoch-{}.invalid", Uuid::new_v4());
        let other_endpoint = format!("http://other-epoch-{}.invalid", Uuid::new_v4());
        let current_epoch = Uuid::new_v4();
        for endpoint in [&endpoint, &other_endpoint] {
            resolve_put_file_auth_capability(endpoint, || async { Ok(Some(current_epoch)) })
                .await
                .expect("initial epoch should resolve");
        }
        reject_put_file_server_epoch(&endpoint, Uuid::new_v4());
        assert_eq!(
            resolve_put_file_auth_capability(&endpoint, || async { panic!("old writer must not invalidate a new epoch") })
                .await
                .expect("new epoch must remain cached"),
            Some(current_epoch)
        );
        reject_put_file_server_epoch(&endpoint, current_epoch);
        assert_eq!(
            resolve_put_file_auth_capability(&other_endpoint, || async { panic!("another endpoint must stay cached") })
                .await
                .expect("other endpoint must remain cached"),
            Some(current_epoch)
        );
    }

    #[tokio::test]
    async fn put_file_rejected_epoch_survives_failed_stale_and_downgrade_probes() {
        let endpoint = format!("http://rejected-probe-{}.invalid", Uuid::new_v4());
        let rejected_epoch = Uuid::new_v4();
        let replacement_epoch = Uuid::new_v4();
        resolve_put_file_auth_capability(&endpoint, || async { Ok(Some(rejected_epoch)) })
            .await
            .expect("initial epoch should resolve");
        reject_put_file_server_epoch(&endpoint, rejected_epoch);
        let failure = resolve_put_file_auth_capability(&endpoint, || async { Err(Error::other("injected probe failure")) })
            .await
            .expect_err("probe failure must be returned");
        assert!(failure.to_string().contains("injected probe failure"));
        let downgrade = resolve_put_file_auth_capability(&endpoint, || async { Ok(None) })
            .await
            .expect_err("rejection must not unpin authenticated v1");
        assert!(downgrade.to_string().contains("downgrade rejected"));
        resolve_put_file_auth_capability(&endpoint, || async { Ok(Some(rejected_epoch)) })
            .await
            .expect("a probe racing a restart can still return the old epoch");
        assert_eq!(
            resolve_put_file_auth_capability(&endpoint, || async { Ok(Some(replacement_epoch)) })
                .await
                .expect("same-epoch probe must not clear known rejection"),
            Some(replacement_epoch)
        );
    }

    #[test]
    fn walk_dir_url_encodes_disk_ref() {
        let url = build_walk_dir_url(&WalkDirStreamRequest {
            endpoint: "http://node1:9000".to_string(),
            disk: "http://node1:9000/data/rustfs0".to_string(),
            body: Vec::new(),
            stall_timeout: None,
        });

        assert_eq!(
            url,
            concat!(
                "http://node1:9000/rustfs/rpc/walk_dir?disk=http%3A%2F%2Fnode1%3A9000%2Fdata%2Frustfs0",
                "&walk_dir_stream_completion=error-v1",
                "&walk_dir_body_sha256=e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
            )
        );
    }

    #[test]
    fn ns_scanner_url_binds_body_and_encodes_disk_ref() {
        let request_id = Uuid::parse_str("11111111-2222-4333-8444-555555555555").expect("request ID");
        let server_epoch = Uuid::parse_str("aaaaaaaa-bbbb-4ccc-8ddd-eeeeeeeeeeee").expect("server epoch");
        let session_id = Uuid::parse_str("99999999-8888-4777-8666-555555555555").expect("session ID");
        let url = build_ns_scanner_url(&NsScannerStreamRequest {
            endpoint: "http://node1:9000".to_string(),
            disk: "http://node1:9000/data/rustfs0".to_string(),
            request_id,
            server_epoch,
            session_id,
            session_sequence: 3,
            next_cycle: 7,
            leader_epoch: 9,
            body: b"scanner-request".to_vec(),
            stall_timeout: None,
        });

        assert_eq!(
            url,
            concat!(
                "http://node1:9000/rustfs/rpc/ns_scanner?disk=http%3A%2F%2Fnode1%3A9000%2Fdata%2Frustfs0",
                "&ns_scanner_request_id=11111111-2222-4333-8444-555555555555",
                "&ns_scanner_server_epoch=aaaaaaaa-bbbb-4ccc-8ddd-eeeeeeeeeeee",
                "&ns_scanner_session_id=99999999-8888-4777-8666-555555555555",
                "&ns_scanner_session_sequence=3",
                "&ns_scanner_cycle=7",
                "&ns_scanner_leader_epoch=9",
                "&ns_scanner_body_sha256=c958f15ca28422275c1245399f4c44eaba628ca453fcd77d6b3d4484573e4387"
            )
        );
    }

    #[test]
    fn ns_scanner_capability_url_binds_version_and_challenge() {
        let challenge = Uuid::parse_str("12345678-1234-4234-8234-123456789abc").expect("challenge");
        let url = build_ns_scanner_capability_url(
            &NsScannerCapabilityRequest {
                endpoint: "http://node1:9000".to_string(),
                supports_tier_registry_generation: false,
            },
            challenge,
        );

        assert_eq!(
            url,
            format!(
                "http://node1:9000/rustfs/rpc/ns_scanner?ns_scanner_protocol={NS_SCANNER_PROTOCOL_VERSION}&ns_scanner_challenge={challenge}"
            )
        );
    }

    #[test]
    fn ns_scanner_capability_url_marks_generation_support_only_when_requested() {
        let challenge = Uuid::new_v4();
        let url = build_ns_scanner_capability_url(
            &NsScannerCapabilityRequest {
                endpoint: "http://node1:9000".to_string(),
                supports_tier_registry_generation: true,
            },
            challenge,
        );

        assert!(url.contains(&format!("&{}=true", NS_SCANNER_TIER_REGISTRY_GENERATION_QUERY)));
    }

    #[test]
    fn ns_scanner_capability_legacy_fallback_requires_explicit_compatibility_status() {
        for status in [400, 404, 405, 426] {
            let error = Error::from(rustfs_rio::new_test_internode_http_io_error(
                rustfs_rio::InternodeHttpErrorKind::HttpStatus(http::StatusCode::from_u16(status).expect("test status")),
            ));
            assert!(
                ns_scanner_capability_error_allows_legacy(&error),
                "status {status} should permit legacy retry"
            );
        }

        let marked_server_error = Error::from(rustfs_rio::new_test_internode_http_io_error(
            rustfs_rio::InternodeHttpErrorKind::HttpStatus(http::StatusCode::INTERNAL_SERVER_ERROR),
        ));
        let network_error = Error::from(rustfs_rio::new_test_internode_http_io_error(
            rustfs_rio::InternodeHttpErrorKind::ConnectionRefused,
        ));
        let authentication_error = Error::other("remote namespace scanner capability authentication failed");
        assert!(!ns_scanner_capability_error_allows_legacy(&marked_server_error));
        assert!(!ns_scanner_capability_error_allows_legacy(&network_error));
        assert!(!ns_scanner_capability_error_allows_legacy(&authentication_error));
    }

    #[test]
    fn authenticated_ns_scanner_capability_ignores_unprotected_response_bit() {
        let mut response = NsScannerCapabilityResponse {
            version: NS_SCANNER_PROTOCOL_VERSION,
            server_epoch: Uuid::new_v4(),
            proof: Vec::new(),
            supports_tier_registry_generation: None,
        };

        normalize_ns_scanner_capability_response(&mut response, true);
        assert_eq!(response.supports_tier_registry_generation, Some(true));

        response.supports_tier_registry_generation = Some(false);
        normalize_ns_scanner_capability_response(&mut response, false);
        assert_eq!(response.supports_tier_registry_generation, None);
    }

    #[test]
    fn ns_scanner_capability_accepts_only_authenticated_legacy_scope_after_marker_mismatch() {
        crate::runtime::sources::ensure_test_rpc_secret();
        let challenge = Uuid::new_v4();
        let response = NsScannerCapabilityResponse {
            version: NS_SCANNER_PROTOCOL_VERSION,
            server_epoch: Uuid::new_v4(),
            proof: crate::cluster::rpc::sign_ns_scanner_capability(challenge, Uuid::new_v4())
                .expect("placeholder proof should be generated"),
            supports_tier_registry_generation: None,
        };
        // A proof bound to a different challenge cannot authorize the legacy
        // fallback, even though the response has the expected shape.
        assert!(!ns_scanner_capability_legacy_proof_is_valid(challenge, &response));

        let server_epoch = response.server_epoch;
        let valid_response = NsScannerCapabilityResponse {
            proof: crate::cluster::rpc::sign_ns_scanner_capability(challenge, server_epoch)
                .expect("legacy proof should be generated"),
            ..response
        };
        assert!(ns_scanner_capability_legacy_proof_is_valid(challenge, &valid_response));
    }

    #[test]
    fn transport_config_defaults_to_tcp_http() {
        let transport = build_internode_data_transport(None).unwrap();

        assert_eq!(transport.name(), DEFAULT_INTERNODE_DATA_TRANSPORT);
    }

    #[test]
    fn transport_config_blank_value_falls_back_to_default() {
        let transport = build_internode_data_transport(Some("   ")).unwrap();

        assert_eq!(transport.name(), DEFAULT_INTERNODE_DATA_TRANSPORT);
    }

    #[test]
    fn transport_config_accepts_tcp_aliases() {
        for configured in [
            DEFAULT_INTERNODE_DATA_TRANSPORT,
            INTERNODE_DATA_TRANSPORT_TCP,
            "TCP-HTTP",
            "TCP",
        ] {
            let transport = build_internode_data_transport(Some(configured)).unwrap();

            assert_eq!(transport.name(), DEFAULT_INTERNODE_DATA_TRANSPORT);
        }
    }

    #[test]
    fn transport_config_known_backends_are_current_oss_values() {
        assert_eq!(
            KNOWN_INTERNODE_DATA_TRANSPORT_BACKENDS,
            &[DEFAULT_INTERNODE_DATA_TRANSPORT, INTERNODE_DATA_TRANSPORT_TCP]
        );

        for configured in KNOWN_INTERNODE_DATA_TRANSPORT_BACKENDS {
            let transport = build_internode_data_transport(Some(configured)).unwrap();

            assert_eq!(transport.name(), DEFAULT_INTERNODE_DATA_TRANSPORT);
        }
    }

    #[test]
    fn transport_config_rejects_unknown_backend() {
        let err = build_internode_data_transport(Some("unsupported-backend")).expect_err("unknown backend should fail closed");

        assert!(err.to_string().contains(ENV_RUSTFS_INTERNODE_DATA_TRANSPORT));
        assert!(err.to_string().contains("unsupported-backend"));
        assert!(err.to_string().contains("supported values: tcp-http, tcp"));
    }

    #[test]
    fn cached_transport_config_error_uses_raw_message() {
        let err =
            build_internode_data_transport_result(Some("unsupported-backend")).expect_err("unknown backend should fail closed");

        assert!(!err.starts_with("io error "));
        assert!(err.contains(ENV_RUSTFS_INTERNODE_DATA_TRANSPORT));
        assert!(err.contains("unsupported-backend"));
    }
}