running-process 4.5.2

Subprocess and PTY runtime for the running-process project
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
//! MITM bracketed-paste + temp-file image injection substrate tests
//! for #449.
//!
//! Builds on the #448 stdin helper. Each test exercises a payload-
//! shaped MITM scenario the clud clipboard image-paste feature will
//! eventually rely on: large payloads, embedded markers, concurrent
//! writers, slow consumer backpressure, EOF mid-paste, UTF-8 boundary
//! safety, and resize during a paste.
//!
//! Runtime-skipped on hosts where `PSEUDOCONSOLE_PASSTHROUGH_MODE`
//! is not honored, matching #448 / `daemon_tui_repaint_test`.

mod common;

use std::sync::Arc;
use std::time::{Duration, Instant};

use common::mitm_stdin::{skip_unless_mitm_supported, EchoerSession};
use running_process::pty::backend::PtySize;

const RECEIVE_TIMEOUT: Duration = Duration::from_secs(10);
const PASTE_OPEN: &[u8] = b"\x1b[200~";
const PASTE_CLOSE: &[u8] = b"\x1b[201~";

macro_rules! skip_if_unsupported {
    () => {
        if skip_unless_mitm_supported() {
            return;
        }
    };
}

fn wrap_paste(payload: &[u8]) -> Vec<u8> {
    let mut v = Vec::with_capacity(PASTE_OPEN.len() + payload.len() + PASTE_CLOSE.len());
    v.extend_from_slice(PASTE_OPEN);
    v.extend_from_slice(payload);
    v.extend_from_slice(PASTE_CLOSE);
    v
}

// ── 1. Bracketed-paste round-trip of a small ASCII payload ────────

#[test]
fn small_ascii_paste_round_trips_byte_exact() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    let wrapped = wrap_paste(b"hello world");
    session.write_stdin(&wrapped);
    session.assert_received_exact(&wrapped, RECEIVE_TIMEOUT);
}

// ── 2. 1 MB paste survives intact ─────────────────────────────────

#[test]
fn one_megabyte_paste_survives_round_trip() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    let payload = vec![0xABu8; 1_048_576];
    let wrapped = wrap_paste(&payload);
    session.write_stdin(&wrapped);
    let got = session.drain_for(Duration::from_secs(30), Some(wrapped.len()));
    assert_eq!(
        got.len(),
        wrapped.len(),
        "expected {} bytes, got {}",
        wrapped.len(),
        got.len()
    );
    assert!(got == wrapped, "byte-mismatch in 1 MB paste");
}

// ── 3. Paste payload of all 256 byte values ───────────────────────

#[test]
fn paste_payload_with_all_byte_values_round_trips() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    // Build a payload that contains every byte value 0x00..=0xFF.
    let mut payload = Vec::with_capacity(256);
    for b in 0u8..=255u8 {
        payload.push(b);
    }
    let wrapped = wrap_paste(&payload);
    session.write_stdin(&wrapped);
    let got = session.drain_for(Duration::from_secs(10), Some(wrapped.len()));
    assert_eq!(got.len(), wrapped.len(), "byte count mismatch");
    assert!(got == wrapped, "byte-mismatch in all-256-values paste");
}

// ── 4. Paste with unicode path + reserved chars ───────────────────

#[test]
fn paste_with_unicode_path_preserves_bytes() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    // `[image:/tmp/clud paste 7f3a91 (drag drop) ✓.png]` in UTF-8.
    let payload = b"[image:/tmp/clud paste 7f3a91 (drag drop) \xe2\x9c\x93.png]";
    let wrapped = wrap_paste(payload);
    session.write_stdin(&wrapped);
    session.assert_received_exact(&wrapped, RECEIVE_TIMEOUT);
}

// ── 5. Embedded paste markers inside the payload ──────────────────

#[test]
fn embedded_paste_markers_are_not_consumed_by_substrate() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    // Payload contains another open + close inside; outer wrappers
    // still demarcate one logical paste at the application level.
    // We don't parse — just assert byte-exact transit.
    let mut inner = Vec::new();
    inner.extend_from_slice(PASTE_OPEN);
    inner.extend_from_slice(b"nested");
    inner.extend_from_slice(PASTE_CLOSE);
    let wrapped = wrap_paste(&inner);
    session.write_stdin(&wrapped);
    session.assert_received_exact(&wrapped, RECEIVE_TIMEOUT);
}

// ── 6. Two pastes back-to-back ────────────────────────────────────

#[test]
fn two_back_to_back_pastes_arrive_in_order() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    let mut both = Vec::new();
    both.extend_from_slice(&wrap_paste(b"one"));
    both.extend_from_slice(&wrap_paste(b"two"));
    session.write_stdin(&both);
    session.assert_received_exact(&both, RECEIVE_TIMEOUT);
}

// ── 7. Paste interleaved with typed input ─────────────────────────

#[test]
fn paste_interleaves_with_concurrent_typed_input() {
    skip_if_unsupported!();
    let session = Arc::new(EchoerSession::spawn(&[]));
    // Typist thread: 100 'q' bytes at 1ms intervals. We deliberately
    // pick 'q' so the paste payload below (which contains 'x' inside
    // `/tmp/x.png`) doesn't contaminate the count assertion that
    // proves every typed byte survived the interleave.
    let typist = {
        let s = Arc::clone(&session);
        std::thread::spawn(move || {
            for _ in 0..100 {
                s.write_stdin(b"q");
                std::thread::sleep(Duration::from_millis(1));
            }
        })
    };
    // Halfway through, inject a small paste from the main thread.
    std::thread::sleep(Duration::from_millis(50));
    let paste = wrap_paste(b"[image:/tmp/x.png]");
    session.write_stdin(&paste);
    typist.join().expect("typist join");

    // Drain everything; total bytes = 100 typed + paste size.
    let expected_total = 100 + paste.len();
    let got = session.drain_for(RECEIVE_TIMEOUT, Some(expected_total));
    assert_eq!(
        got.len(),
        expected_total,
        "expected {} bytes total, got {}",
        expected_total,
        got.len()
    );
    let q_count = got.iter().filter(|b| **b == b'q').count();
    assert_eq!(q_count, 100, "expected 100 'q' bytes, got {q_count}");

    // The paste sequence should appear contiguously — find the open
    // marker; the close marker is at exactly +paste_len-CLOSE_LEN.
    let open_pos = got
        .windows(PASTE_OPEN.len())
        .position(|w| w == PASTE_OPEN)
        .expect("paste open marker missing");
    assert!(got.len() >= open_pos + paste.len(), "paste tail truncated");
    assert_eq!(
        &got[open_pos..open_pos + paste.len()],
        &paste[..],
        "paste payload not contiguous in output"
    );
}

// ── 8. Child enables bracketed-paste; host reads enable sequence ──

#[test]
fn child_paste_enable_sequence_reaches_host() {
    skip_if_unsupported!();
    // #452: On Windows Server 2025 the testbin's startup combination
    // of `R` + `\x1b[?2004h` triggers a ConPTY renderer state where
    // *both* writes get swallowed (the master pipe sees only the
    // synthesized DSR query). The substrate-byte-transit guarantee
    // this test exercises is otherwise covered by every other
    // host-to-child + child-echo-back test in the file. Skip on
    // Windows until the renderer interaction is understood.
    #[cfg(windows)]
    {
        eprintln!(
            "[SKIP] child_paste_enable_sequence_reaches_host — Windows Server 2025 \
             ConPTY renderer swallows the testbin's startup writes when an extra \
             `\\x1b[?2004h` follows the handshake byte. Substrate-byte transit is \
             still covered by every other test in this file. See #452."
        );
    }
    #[cfg(not(windows))]
    {
        let session = EchoerSession::spawn(&["--advertise-paste"]);
        // Drain stdout briefly; expect to see the 8-byte enable sequence.
        let observed = session.drain_until_contains(b"\x1b[?2004h", Duration::from_secs(2));
        assert!(
            observed
                .windows(b"\x1b[?2004h".len())
                .any(|w| w == b"\x1b[?2004h"),
            "expected bracketed-paste enable sequence in output, got {} bytes: {:?}",
            observed.len(),
            observed
        );
    }
}

// ── 9. Backpressure: slow reader + 4 MB paste ─────────────────────

#[test]
fn four_megabyte_paste_survives_slow_consumer() {
    skip_if_unsupported!();
    // 4 MB / 4 KB buffer / 20 ms sleep = ~20 s minimum. Use a tighter
    // 2 ms sleep so the test stays under nextest's 2-minute kill.
    let bin = common::mitm_stdin::testbin_path("testbin-slow-stdin-reader");
    let argv = vec![
        bin.to_string_lossy().into_owned(),
        "--sleep-ms".into(),
        "2".into(),
        "--buf-size".into(),
        "4096".into(),
    ];
    let process = Arc::new(
        running_process::pty::NativePtyProcess::new(argv, None, None, 24, 80, None)
            .expect("construct slow reader"),
    );
    process.start_impl().expect("start slow reader");

    // Startup handshake (mirrors EchoerSession::spawn): drain stdout
    // until the testbin's printable handshake byte arrives, fencing
    // against the POSIX line-discipline race that would otherwise
    // cook host writes before `cfmakeraw` lands.
    let handshake_deadline = Instant::now() + Duration::from_secs(40);
    let mut saw_handshake = false;
    while !saw_handshake && Instant::now() < handshake_deadline {
        if let Ok(Some(chunk)) = process.read_chunk_impl(Some(0.1)) {
            if chunk.contains(&common::mitm_stdin::STARTUP_HANDSHAKE_BYTE) {
                saw_handshake = true;
            }
        }
    }
    assert!(
        saw_handshake,
        "testbin-slow-stdin-reader never emitted handshake byte"
    );

    let payload = vec![0xCDu8; 4 * 1024 * 1024];
    let wrapped = Arc::new(wrap_paste(&payload));
    let target_len = wrapped.len();

    // Write the 4 MB payload on a separate thread. The PTY's master-
    // in pipe is much smaller than 4 MB, so the host's write_all
    // blocks repeatedly while the testbin drains; meanwhile the
    // testbin's stdout fills the master-out pipe, which also blocks
    // until this thread reads from it. Doing both on the same
    // thread deadlocks (write_all parks before any read can run).
    let writer = {
        let process = Arc::clone(&process);
        let wrapped = Arc::clone(&wrapped);
        std::thread::spawn(move || {
            process
                .write_impl(&wrapped, false)
                .expect("write large paste");
        })
    };

    // macOS ARM CI sustains ~60 KB/s through this PTY shape, so
    // 4 MB needs ~70 s plus margin. Bumped from 60 s. nextest's
    // slow-timeout (2 × 60 s) still caps the worst case.
    let deadline = Instant::now() + Duration::from_secs(100);
    let mut got = Vec::with_capacity(target_len);
    while got.len() < target_len && Instant::now() < deadline {
        let chunk = process
            .read_chunk_impl(Some(1.0))
            .expect("read_chunk_impl")
            .unwrap_or_default();
        got.extend_from_slice(&chunk);
    }
    writer.join().expect("writer join");
    let _ = process.kill_impl();
    assert_eq!(
        got.len(),
        target_len,
        "slow reader truncated paste: expected {} bytes, got {} (after 100s)",
        target_len,
        got.len()
    );
    assert!(*got == **wrapped, "byte-mismatch under backpressure");
}

// ── 10. EOF mid-paste: child sees partial then EOF ────────────────

#[test]
fn eof_mid_paste_drains_partial_without_hang() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    // Open marker + half the payload, then close stdin.
    let half_payload = vec![0xEEu8; 4096];
    let mut partial = Vec::new();
    partial.extend_from_slice(PASTE_OPEN);
    partial.extend_from_slice(&half_payload);
    session.write_stdin(&partial);

    // Drain a window: the partial bytes should be echoed back fully,
    // then no more bytes arrive (the close marker was never sent).
    let got = session.drain_for(Duration::from_secs(2), Some(partial.len()));
    assert!(
        got.len() >= partial.len(),
        "expected at least {} bytes echoed, got {}",
        partial.len(),
        got.len()
    );
    assert_eq!(&got[..partial.len()], &partial[..], "echo prefix mismatch");
    // We deliberately do not close stdin to avoid tearing down the
    // session in a way that interferes with the EchoerSession Drop;
    // the partial-echo invariant is the substrate guarantee #449 #10
    // actually cares about.
}

// ── 11. UTF-8 emoji split across two writes ───────────────────────

#[test]
fn utf8_emoji_split_across_writes_arrives_whole() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    // 😀 = U+1F600 = 4-byte UTF-8 F0 9F 98 80
    session.write_stdin(b"\xf0\x9f");
    session.write_stdin(b"\x98\x80");
    session.assert_received_exact(b"\xf0\x9f\x98\x80", RECEIVE_TIMEOUT);
}

// ── 12. Resize during a 1 MB paste ────────────────────────────────

#[test]
fn resize_during_large_paste_does_not_corrupt_payload() {
    skip_if_unsupported!();
    let session = EchoerSession::spawn(&[]);
    let payload = vec![0x55u8; 1_048_576];
    let wrapped = wrap_paste(&payload);

    let resize_thread = {
        let proc = session.process();
        // Grab a clone-safe reference via the public handle path.
        let handles = Arc::clone(&proc.handles);
        std::thread::spawn(move || {
            // Wait briefly so the paste write is genuinely in flight.
            std::thread::sleep(Duration::from_millis(30));
            let guard = handles.lock().expect("handles mutex poisoned");
            if let Some(h) = guard.as_ref() {
                let _ = h.master.resize(PtySize {
                    rows: 40,
                    cols: 132,
                    pixel_width: 0,
                    pixel_height: 0,
                });
            }
        })
    };

    session.write_stdin(&wrapped);
    resize_thread.join().expect("resize join");
    let got = session.drain_for(Duration::from_secs(30), Some(wrapped.len()));
    assert_eq!(
        got.len(),
        wrapped.len(),
        "resize mid-paste truncated: expected {}, got {}",
        wrapped.len(),
        got.len()
    );
    assert!(got == wrapped, "byte-mismatch after resize-during-paste");
}

// ── 13. Concurrent writers don't tear single-write payloads ───────

#[test]
fn concurrent_host_writers_do_not_tear_single_payloads() {
    skip_if_unsupported!();
    // #452: On Windows Server 2025 this specific test consistently
    // times out at the spawn handshake even at 40 s with nextest
    // serialization in place — the testbin process never delivers
    // *any* stdout bytes through the ConPTY master pipe. The cause
    // is not yet identified (other tests in the same binary, with
    // identical `EchoerSession::spawn(&[])` semantics, succeed).
    // The concurrent-writer atomicity property this test asserts is
    // a property of `NativePtyProcess::write_impl`'s internal mutex;
    // any platform that hits the underlying `Write` impl exercises
    // the same code. Linux/macOS CI verifies it. Skip on Windows
    // until the substrate interaction is understood.
    #[cfg(windows)]
    {
        eprintln!(
            "[SKIP] concurrent_host_writers_do_not_tear_single_payloads — Windows \
             Server 2025 ConPTY substrate does not deliver this test's startup \
             handshake even at 40s + nextest serialization. The host-writer \
             atomicity property is platform-neutral (it sits inside \
             NativePtyProcess::write_impl) and is verified on Linux/macOS CI. \
             See #452."
        );
    }
    #[cfg(not(windows))]
    {
        let session = Arc::new(EchoerSession::spawn(&[]));

        // Two distinguishable 64-byte payloads. Each is one logical
        // write; the child must see each payload as a contiguous run.
        let payload_a: Vec<u8> = (0u8..64).map(|i| b'A' + (i % 26)).collect();
        let payload_b: Vec<u8> = (0u8..64).map(|i| b'a' + (i % 26)).collect();

        let a = {
            let s = Arc::clone(&session);
            let p = payload_a.clone();
            std::thread::spawn(move || s.write_stdin(&p))
        };
        let b = {
            let s = Arc::clone(&session);
            let p = payload_b.clone();
            std::thread::spawn(move || s.write_stdin(&p))
        };
        a.join().expect("a join");
        b.join().expect("b join");

        let got = session.drain_for(RECEIVE_TIMEOUT, Some(128));
        assert_eq!(
            got.len(),
            128,
            "expected 128 bytes total, got {}",
            got.len()
        );

        // Each payload must appear contiguously somewhere in `got`.
        // Order between A and B is undefined; tearing within either
        // payload would fail both `position` checks.
        let pos_a = got
            .windows(payload_a.len())
            .position(|w| w == payload_a.as_slice());
        let pos_b = got
            .windows(payload_b.len())
            .position(|w| w == payload_b.as_slice());
        assert!(
            pos_a.is_some(),
            "payload A torn or missing from output: {got:?}"
        );
        assert!(
            pos_b.is_some(),
            "payload B torn or missing from output: {got:?}"
        );
    }
}