1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
//! Handler for the `check` command.
use colored::*;
use rumdl_lib::config as rumdl_config;
use rumdl_lib::exit_codes::exit;
use crate::cli_utils::{apply_cli_overrides, load_config_with_cli_error_handling_with_dir};
use crate::{CheckArgs, FailOn, FixMode};
/// Run the check/lint/fmt command.
pub fn run_check(args: &CheckArgs, global_config_path: Option<&str>, isolated: bool, inline_overrides: &[toml::Table]) {
let quiet = args.quiet;
let silent = args.silent;
// `--list-rules` / `-l` was removed: rule listing lives in dedicated commands.
// Rather than a bare "unexpected argument" error, point users (especially those
// migrating from other linters who reach for `-l`) at the right commands, and
// exit non-zero so a script relying on it fails loudly instead of silently
// skipping the lint.
if args.list_rules {
eprintln!("{}: `--list-rules` has been removed", "Error".red().bold());
eprintln!(" To list all rules: rumdl rule");
eprintln!(" Rules active for your config: rumdl check --verbose");
eprintln!(" Inspect your effective config: rumdl config");
exit::tool_error();
}
// Validate mutually exclusive options
if args.diff && args.fix {
eprintln!("{}: --diff and --fix cannot be used together", "Error".red().bold());
eprintln!("Use --diff to preview changes, or --fix to apply them");
exit::tool_error();
}
if args.check && args.fix {
eprintln!("{}: --check and --fix cannot be used together", "Error".red().bold());
eprintln!("Use --check to verify formatting without changes, or --fix to apply them");
exit::tool_error();
}
// Warn about deprecated --force-exclude flag
if args.force_exclude {
eprintln!(
"{}: --force-exclude is deprecated and has no effect",
"warning".yellow().bold()
);
eprintln!("Exclude patterns are now always respected by default (as of v0.0.156)");
eprintln!("Use --no-exclude if you want to disable exclusions");
}
// Check for watch mode
if args.watch {
crate::watch::run_watch_mode(args, global_config_path, isolated, quiet, inline_overrides);
return;
}
// 1. Determine the directory for config discovery.
//
// A single path discovers config next to that path (if it's a directory) or
// next to its parent. This keeps file-scoped runs (and pre-commit passing one
// relative file) finding the right nearest config.
//
// Multiple paths may span several config scopes (e.g. a repo-root config plus
// nested `.rumdl.toml` files that `extend-disable` a rule). The *global*
// config is the baseline for every file whose nearest config is the project
// root, so it must reflect the shared scope of the files being checked, not
// any single path's own directory. Anchoring at the first path's directory
// would let that directory's nested config become the baseline for files in
// sibling directories (silently suppressing a rule there); anchoring at the
// current working directory would leak an unrelated cwd config onto files
// elsewhere. So we anchor discovery at the nearest common ancestor of all
// target paths and let discovery walk up from there to the project root.
// Per-file grouping still layers each file's own nearest config on top.
//
// Zero paths (lint the cwd recursively) keeps the cwd-based discovery.
let multi_path_root = if args.paths.len() > 1 {
common_ancestor_dir(&args.paths)
} else {
None
};
let discovery_dir = if args.paths.len() == 1 {
let first_path = std::path::Path::new(&args.paths[0]);
if first_path.is_dir() {
Some(first_path)
} else {
first_path.parent().filter(|&parent| parent.is_dir())
}
} else {
multi_path_root.as_deref()
};
// 2. Load sourced config (for provenance and validation)
let mut sourced = load_config_with_cli_error_handling_with_dir(global_config_path, isolated, discovery_dir);
// 2b. Apply inline `--config 'RULE.key=value'` overrides at CLI precedence
// (highest), so they win over both file-loaded values and any later CLI
// arg overrides that touch top-level globals.
crate::cli_config_override::apply_inline_overrides(&mut sourced, inline_overrides);
// 2c. Surface config-discovery warnings (e.g. a `rumdl.toml` shadowed by a
// sibling `.rumdl.toml`). Resolution is unchanged; this only tells the user
// which file is winning. Suppressed by --silent, like other config warnings.
if !sourced.discovery_warnings.is_empty() && !args.silent {
for warning in &sourced.discovery_warnings {
eprintln!("\x1b[33m[config warning]\x1b[0m {warning}");
}
}
// 3. Validate configuration
let registry = rumdl_config::default_registry();
let validation_warnings = rumdl_config::validate_config_sourced(&sourced, registry);
if !validation_warnings.is_empty() && !args.silent {
for warn in &validation_warnings {
eprintln!("\x1b[33m[config warning]\x1b[0m {}", warn.message);
}
// Do NOT exit; continue with valid config
}
// 3b. Validate CLI rule names
let cli_warnings = rumdl_config::validate_cli_rule_names(
args.enable.as_deref(),
args.disable.as_deref(),
args.extend_enable.as_deref(),
args.extend_disable.as_deref(),
args.fixable.as_deref(),
args.unfixable.as_deref(),
);
if !cli_warnings.is_empty() && !args.silent {
for warn in &cli_warnings {
eprintln!("\x1b[33m[cli warning]\x1b[0m {}", warn.message);
}
}
// Whether any configuration problem outside per-file inline comments was
// seen (a shadowed config, an unknown rule/option in a config file, or an
// unknown rule in a CLI flag). Combined with the inline-comment class from
// the run below to decide the --deny-config-warnings exit. Computed before
// `sourced` is consumed, since `discovery_warnings` lives on it.
let external_config_warning =
!sourced.discovery_warnings.is_empty() || !validation_warnings.is_empty() || !cli_warnings.is_empty();
// 3c. Apply CLI argument overrides (e.g., --flavor)
apply_cli_overrides(&mut sourced, args);
// 4. Extract cache_dir and project_root before converting sourced
let cache_dir_from_config = sourced.global.cache_dir.as_ref().map(|sv| sv.value.clone());
let project_root = sourced.project_root.clone();
// Grouping root: the upper bound for per-directory config grouping. It is the
// discovered `project_root` when there is one; otherwise, for a multi-path run,
// it falls back to the common-ancestor anchor so standalone subdirectory
// configs are still grouped. Unlike `project_root` it does not base the cache
// dir, per-file globs or displayed paths, so those stay cwd-relative when no
// project config was found. `discover_config_for_dir` keeps the home boundary,
// so a grouping root above home never promotes `~/.rumdl.toml`. Isolated and
// explicit-config runs are unaffected: `resolve_config_groups` fast-paths on
// those regardless of the grouping root.
let grouping_root = project_root.clone().or(multi_path_root);
// 5. Convert to Config for the rest of the linter
// Validation warnings are already printed above, so we use into_validated_unchecked
// The sourced form is kept alongside it: `.editorconfig` layers into that one,
// where a setting's provenance still says whether a rumdl config set it.
let sourced = sourced.into_validated_unchecked();
let config: rumdl_config::Config = sourced.clone().into();
// 6. Initialize cache if enabled
// CLI --no-cache flag takes precedence over config
let cache_enabled = !args.no_cache && config.global.cache;
let cache_dir = crate::cache::resolve_cache_dir(
args.cache_dir.as_deref(),
cache_dir_from_config.as_deref(),
project_root.as_deref(),
);
let cache = if cache_enabled {
let cache_instance = crate::cache::LintCache::new(cache_dir.clone(), cache_enabled);
// Initialize cache directory structure
if let Err(e) = cache_instance.init() {
if !silent {
eprintln!("Warning: Failed to initialize cache: {e}");
}
// Continue without cache
None
} else {
// Wrap in Arc for thread-safe sharing across parallel workers.
Some(std::sync::Arc::new(cache_instance))
}
} else {
None
};
// Use the same cache directory for workspace index cache (when cache is enabled)
let workspace_cache_dir = if cache_enabled { Some(cache_dir.as_path()) } else { None };
let ctx = crate::check_runner::CheckRunContext {
args,
config: &config,
sourced: &sourced,
quiet,
cache,
workspace_cache_dir,
project_root: project_root.as_deref(),
grouping_root: grouping_root.as_deref(),
inline_overrides,
explicit_config: global_config_path.is_some(),
isolated,
external_config_warning,
};
let outcome = crate::check_runner::perform_check_run(&ctx);
// A file that could not be read is a tool error (exit code 2). It takes
// precedence over lint findings: the run was incomplete, so reporting it as
// "clean" or "violations found" would be misleading in CI.
if outcome.had_tool_error {
exit::tool_error();
}
// A configuration problem is a tooling error (exit code 2), reported after
// the best-effort lint pass so every warning is still printed. It takes
// precedence over Markdown violations (exit code 1), and stays orthogonal
// to --fail-on (which governs violation severity). Covers the three classes
// visible here plus the inline-comment class bubbled up from the run.
if args.deny_config_warnings && (external_config_warning || outcome.config_warning) {
exit::tool_error();
}
// In --check mode (for fmt), exit with code 1 if any formatting changes would be made
if args.check && outcome.total_issues_fixed > 0 {
exit::violations_found();
}
// Determine if we should fail based on --fail-on setting
let should_fail = match args.fail_on_mode {
FailOn::Never => false,
FailOn::Error => outcome.has_errors,
FailOn::Warning => outcome.has_warnings,
FailOn::Any => outcome.has_issues,
};
if should_fail && args.fix_mode != FixMode::Format {
exit::violations_found();
}
}
/// The nearest common-ancestor directory of every target path, resolved against
/// the current working directory.
///
/// Used to anchor multi-path config discovery so the global baseline reflects the
/// shared scope of the targets rather than any single path's (possibly
/// nested-config) directory. Each path is reduced to its containing directory (the
/// path itself when it is a directory, otherwise its parent); the result is the
/// longest shared component prefix of those directories. Returns `None` when the
/// paths share no common ancestor (e.g. different Windows drives) or the working
/// directory cannot be resolved for a relative path, in which case the caller
/// falls back to cwd-based discovery.
fn common_ancestor_dir(paths: &[String]) -> Option<std::path::PathBuf> {
use std::ffi::OsString;
use std::path::{Path, PathBuf};
let cwd = std::env::current_dir().ok();
let to_dir = |p: &str| -> Option<PathBuf> {
let path = Path::new(p);
let abs = if path.is_absolute() {
path.to_path_buf()
} else {
cwd.as_ref()?.join(path)
};
let dir = if abs.is_dir() {
abs
} else {
abs.parent().map(Path::to_path_buf).unwrap_or(abs)
};
// Canonicalize so `..`/`.` components are resolved before the prefix is
// computed; a literal `../sibling` would otherwise share the first path's
// directory as a false common prefix. Falls back to the raw directory when
// the path does not exist (it will be reported later as a missing file).
Some(std::fs::canonicalize(&dir).unwrap_or(dir))
};
let components = |dir: &Path| -> Vec<OsString> { dir.components().map(|c| c.as_os_str().to_owned()).collect() };
let mut dirs = paths.iter().filter_map(|p| to_dir(p));
let mut common = components(&dirs.next()?);
for dir in dirs {
let comps = components(&dir);
let shared = common.iter().zip(&comps).take_while(|(a, b)| a == b).count();
common.truncate(shared);
if common.is_empty() {
return None;
}
}
let mut result = PathBuf::new();
for component in common {
result.push(component);
}
Some(result)
}