1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
//! Document linting, diagnostics, code actions, and auto-fix
//!
//! Handles the core linting workflow: running rules against documents,
//! converting warnings to LSP diagnostics, generating code actions,
//! and applying automatic fixes.
use anyhow::Result;
use tower_lsp::lsp_types::*;
use crate::code_block_tools::CodeBlockToolProcessor;
use crate::embedded_lint::{check_embedded_markdown_blocks, should_lint_embedded_markdown};
use crate::lint;
use crate::rule::FixCapability;
use crate::rules;
use super::server::RumdlLanguageServer;
use super::types::{IndexState, warning_to_code_actions_with_md013_config, warning_to_diagnostic};
use crate::rules::md013_line_length::MD013Config;
impl RumdlLanguageServer {
/// Check if a file URI should be excluded based on exclude patterns
pub(super) async fn should_exclude_uri(&self, uri: &Url) -> bool {
// Try to convert URI to file path
let file_path = match uri.to_file_path() {
Ok(path) => path,
Err(_) => return false, // If we can't get a path, don't exclude
};
// Resolve configuration for this specific file to get its exclude patterns
let rumdl_config = self.resolve_config_for_file(&file_path).await;
let exclude_patterns = &rumdl_config.global.exclude;
// If no exclude patterns, don't exclude
if exclude_patterns.is_empty() {
return false;
}
// Convert path to relative path for pattern matching
// This matches the CLI behavior in find_markdown_files
let path_to_check = if file_path.is_absolute() {
// Try to make it relative to the current directory
if let Ok(cwd) = std::env::current_dir() {
// Canonicalize both paths to handle symlinks
if let (Ok(canonical_cwd), Ok(canonical_path)) = (cwd.canonicalize(), file_path.canonicalize()) {
if let Ok(relative) = canonical_path.strip_prefix(&canonical_cwd) {
relative.to_string_lossy().to_string()
} else {
// Path is absolute but not under cwd
file_path.to_string_lossy().to_string()
}
} else {
// Canonicalization failed
file_path.to_string_lossy().to_string()
}
} else {
file_path.to_string_lossy().to_string()
}
} else {
// Already relative
file_path.to_string_lossy().to_string()
};
// Check if path matches any exclude pattern
for pattern in exclude_patterns {
if let Ok(glob) = globset::Glob::new(pattern) {
let matcher = glob.compile_matcher();
if matcher.is_match(&path_to_check) {
log::debug!("Excluding file from LSP linting: {path_to_check}");
return true;
}
}
}
false
}
/// Lint a document and return diagnostics.
///
/// When `run_external_tools` is false, external code-block-tools (which spawn
/// processes) are skipped. Use false for high-frequency events like `did_change`
/// to avoid spawning processes on every keystroke.
pub(crate) async fn lint_document(
&self,
uri: &Url,
text: &str,
run_external_tools: bool,
) -> Result<Vec<Diagnostic>> {
let config_guard = self.config.read().await;
// Skip linting if disabled
if !config_guard.enable_linting {
return Ok(Vec::new());
}
let lsp_config = config_guard.clone();
drop(config_guard); // Release config lock early
// Check if file should be excluded based on exclude patterns
if self.should_exclude_uri(uri).await {
return Ok(Vec::new());
}
// Resolve configuration for this specific file
let file_path = uri.to_file_path().ok();
let file_config = if let Some(ref path) = file_path {
self.resolve_config_for_file(path).await
} else {
// Fallback to global config for non-file URIs
(*self.rumdl_config.read().await).clone()
};
// Merge LSP settings with file config based on configuration_preference
let rumdl_config = self.merge_lsp_settings(file_config, &lsp_config);
let all_rules = rules::all_rules(&rumdl_config);
let flavor = if let Some(ref path) = file_path {
rumdl_config.get_flavor_for_file(path)
} else {
rumdl_config.markdown_flavor()
};
// Use the standard filter_rules function which respects config's disabled rules
let mut filtered_rules = rules::filter_rules(&all_rules, &rumdl_config.global);
// Apply LSP config overrides (select_rules, ignore_rules from VSCode settings)
filtered_rules = self.apply_lsp_config_overrides(filtered_rules, &lsp_config);
// Apply per-file-ignores filtering
if let Some(ref path) = file_path {
let ignored = rumdl_config.get_ignored_rules_for_file(path);
if !ignored.is_empty() {
filtered_rules.retain(|rule| !ignored.contains(rule.name()));
}
}
// Run rumdl linting with the configured flavor
let mut all_warnings = match crate::lint(
text,
&filtered_rules,
false,
flavor,
file_path.clone(),
Some(&rumdl_config),
) {
Ok(warnings) => warnings,
Err(e) => {
log::error!("Failed to lint document {uri}: {e}");
return Ok(Vec::new());
}
};
// Run cross-file checks if workspace index is ready
if let Some(ref path) = file_path {
let index_state = self.index_state.read().await.clone();
if matches!(index_state, IndexState::Ready) {
let workspace_index = self.workspace_index.read().await;
if let Some(file_index) = workspace_index.get_file(path) {
match crate::run_cross_file_checks(
path,
file_index,
&filtered_rules,
&workspace_index,
Some(&rumdl_config),
) {
Ok(cross_file_warnings) => {
all_warnings.extend(cross_file_warnings);
}
Err(e) => {
log::warn!("Failed to run cross-file checks for {uri}: {e}");
}
}
}
}
}
// Check embedded markdown blocks if configured in code-block-tools
if should_lint_embedded_markdown(&rumdl_config.code_block_tools) {
let embedded_warnings = check_embedded_markdown_blocks(text, &filtered_rules, &rumdl_config);
all_warnings.extend(embedded_warnings);
}
// Run external code-block-tools only when requested (skip on keystroke events)
if run_external_tools && rumdl_config.code_block_tools.enabled {
let processor = CodeBlockToolProcessor::new(&rumdl_config.code_block_tools, flavor);
match processor.lint(text) {
Ok(diagnostics) => {
let tool_warnings: Vec<_> = diagnostics.iter().map(|d| d.to_lint_warning()).collect();
all_warnings.extend(tool_warnings);
}
Err(e) => {
log::warn!("Code block tools linting failed: {e}");
all_warnings.push(crate::rule::LintWarning {
message: e.to_string(),
line: 1,
column: 1,
end_line: 1,
end_column: 1,
severity: crate::rule::Severity::Error,
fix: None,
rule_name: Some("code-block-tools".to_string()),
});
}
}
}
let diagnostics = all_warnings.iter().map(warning_to_diagnostic).collect();
Ok(diagnostics)
}
/// Update diagnostics for a document
///
/// This method pushes diagnostics to the client via publishDiagnostics.
/// When the client supports pull diagnostics (textDocument/diagnostic),
/// we skip pushing to avoid duplicate diagnostics.
pub(super) async fn update_diagnostics(&self, uri: Url, text: String, run_external_tools: bool) {
// When client supports pull diagnostics, publish empty diagnostics to
// invalidate the client cache so it refetches via the pull model
if *self.client_supports_pull_diagnostics.read().await {
log::debug!("Invalidating diagnostics for {uri} - client supports pull model");
self.client.publish_diagnostics(uri, Vec::new(), None).await;
return;
}
// Get the document version if available
let version = {
let docs = self.documents.read().await;
docs.get(&uri).and_then(|entry| entry.version)
};
match self.lint_document(&uri, &text, run_external_tools).await {
Ok(diagnostics) => {
self.client.publish_diagnostics(uri, diagnostics, version).await;
}
Err(e) => {
log::error!("Failed to update diagnostics: {e}");
}
}
}
/// Apply all available fixes to a document
pub(super) async fn apply_all_fixes(&self, uri: &Url, text: &str) -> Result<Option<String>> {
// Check if file should be excluded based on exclude patterns
if self.should_exclude_uri(uri).await {
return Ok(None);
}
let config_guard = self.config.read().await;
let lsp_config = config_guard.clone();
drop(config_guard);
// Resolve configuration for this specific file
let file_path = uri.to_file_path().ok();
let file_config = if let Some(ref path) = file_path {
self.resolve_config_for_file(path).await
} else {
// Fallback to global config for non-file URIs
(*self.rumdl_config.read().await).clone()
};
// Merge LSP settings with file config based on configuration_preference
let rumdl_config = self.merge_lsp_settings(file_config, &lsp_config);
let all_rules = rules::all_rules(&rumdl_config);
let flavor = if let Some(ref path) = file_path {
rumdl_config.get_flavor_for_file(path)
} else {
rumdl_config.markdown_flavor()
};
// Use the standard filter_rules function which respects config's disabled rules
let mut filtered_rules = rules::filter_rules(&all_rules, &rumdl_config.global);
// Apply LSP config overrides (select_rules, ignore_rules from VSCode settings)
filtered_rules = self.apply_lsp_config_overrides(filtered_rules, &lsp_config);
// Apply per-file-ignores filtering
if let Some(ref path) = file_path {
let ignored = rumdl_config.get_ignored_rules_for_file(path);
if !ignored.is_empty() {
filtered_rules.retain(|rule| !ignored.contains(rule.name()));
}
}
// First, run lint to get active warnings (respecting ignore comments)
// This tells us which rules actually have unfixed issues
let mut rules_with_warnings = std::collections::HashSet::new();
let mut fixed_text = text.to_string();
match lint(
&fixed_text,
&filtered_rules,
false,
flavor,
file_path.clone(),
Some(&rumdl_config),
) {
Ok(warnings) => {
for warning in warnings {
if let Some(rule_name) = &warning.rule_name {
rules_with_warnings.insert(rule_name.clone());
}
}
}
Err(e) => {
log::warn!("Failed to lint document for auto-fix: {e}");
return Ok(None);
}
}
// Early return if no warnings to fix
if rules_with_warnings.is_empty() {
return Ok(None);
}
// Only apply fixes for rules that have active warnings
let mut any_changes = false;
for rule in &filtered_rules {
// Skip rules that don't have any active warnings
if !rules_with_warnings.contains(rule.name()) {
continue;
}
let ctx = crate::lint_context::LintContext::new(&fixed_text, flavor, file_path.clone());
match rule.fix(&ctx) {
Ok(new_text) => {
if new_text != fixed_text {
fixed_text = new_text;
any_changes = true;
}
}
Err(e) => {
// Only log if it's an actual error, not just "rule doesn't support auto-fix"
let msg = e.to_string();
if !msg.contains("does not support automatic fixing") {
log::warn!("Failed to apply fix for rule {}: {}", rule.name(), e);
}
}
}
}
if any_changes { Ok(Some(fixed_text)) } else { Ok(None) }
}
/// Get the end position of a document
pub(super) fn get_end_position(&self, text: &str) -> Position {
let mut line = 0u32;
let mut character = 0u32;
for ch in text.chars() {
if ch == '\n' {
line += 1;
character = 0;
} else {
character += 1;
}
}
Position { line, character }
}
/// Apply LSP FormattingOptions to content
///
/// This implements the standard LSP formatting options that editors send:
/// - `trim_trailing_whitespace`: Remove trailing whitespace from each line
/// - `insert_final_newline`: Ensure file ends with a newline
/// - `trim_final_newlines`: Remove extra blank lines at end of file
///
/// This is applied AFTER lint fixes to ensure we respect editor preferences
/// even when the editor's buffer content differs from the file on disk
/// (e.g., nvim may strip trailing newlines from its buffer representation).
pub(super) fn apply_formatting_options(content: String, options: &FormattingOptions) -> String {
// If the original content is empty, keep it empty regardless of options
// This prevents marking empty documents as needing formatting
if content.is_empty() {
return content;
}
let mut result = content.clone();
let original_ended_with_newline = content.ends_with('\n');
// 1. Trim trailing whitespace from each line (if requested)
if options.trim_trailing_whitespace.unwrap_or(false) {
result = result
.lines()
.map(|line| line.trim_end())
.collect::<Vec<_>>()
.join("\n");
// Preserve final newline status for next steps
if original_ended_with_newline && !result.ends_with('\n') {
result.push('\n');
}
}
// 2. Trim final newlines (remove extra blank lines at EOF)
// This runs BEFORE insert_final_newline to handle the case where
// we have multiple trailing newlines and want exactly one
if options.trim_final_newlines.unwrap_or(false) {
// Remove all trailing newlines
while result.ends_with('\n') {
result.pop();
}
// We'll add back exactly one in the next step if insert_final_newline is true
}
// 3. Insert final newline (ensure file ends with exactly one newline)
if options.insert_final_newline.unwrap_or(false) && !result.ends_with('\n') {
result.push('\n');
}
result
}
/// Get code actions for diagnostics at a position
pub(super) async fn get_code_actions(&self, uri: &Url, text: &str, range: Range) -> Result<Vec<CodeAction>> {
let config_guard = self.config.read().await;
let lsp_config = config_guard.clone();
drop(config_guard);
// Resolve configuration for this specific file
let file_path = uri.to_file_path().ok();
let file_config = if let Some(ref path) = file_path {
self.resolve_config_for_file(path).await
} else {
// Fallback to global config for non-file URIs
(*self.rumdl_config.read().await).clone()
};
// Merge LSP settings with file config based on configuration_preference
let rumdl_config = self.merge_lsp_settings(file_config, &lsp_config);
let all_rules = rules::all_rules(&rumdl_config);
let flavor = if let Some(ref path) = file_path {
rumdl_config.get_flavor_for_file(path)
} else {
rumdl_config.markdown_flavor()
};
// Use the standard filter_rules function which respects config's disabled rules
let mut filtered_rules = rules::filter_rules(&all_rules, &rumdl_config.global);
// Apply LSP config overrides (select_rules, ignore_rules from VSCode settings)
filtered_rules = self.apply_lsp_config_overrides(filtered_rules, &lsp_config);
// Apply per-file-ignores filtering
if let Some(ref path) = file_path {
let ignored = rumdl_config.get_ignored_rules_for_file(path);
if !ignored.is_empty() {
filtered_rules.retain(|rule| !ignored.contains(rule.name()));
}
}
// Extract MD013 config once so the "Reflow paragraph" action respects user settings.
let mut md013_config = crate::rule_config_serde::load_rule_config::<MD013Config>(&rumdl_config);
if md013_config.line_length.get() == 80 {
md013_config.line_length = rumdl_config.global.line_length;
}
match crate::lint(
text,
&filtered_rules,
false,
flavor,
file_path.clone(),
Some(&rumdl_config),
) {
Ok(warnings) => {
let mut actions = Vec::new();
for warning in &warnings {
// Check if warning is within the requested range
let warning_line = (warning.line.saturating_sub(1)) as u32;
if warning_line >= range.start.line && warning_line <= range.end.line {
// Get all code actions for this warning (fix + ignore actions)
let mut warning_actions =
warning_to_code_actions_with_md013_config(warning, uri, text, Some(&md013_config));
actions.append(&mut warning_actions);
}
}
// Count fixable warnings across the entire document for the fixAll gate.
// source.fixAll.rumdl applies to the whole file, not just the requested range.
let fixable_count = warnings.iter().filter(|w| w.fix.is_some()).count();
if fixable_count > 0 {
// Only apply fixes from fixable rules during "Fix all"
// Unfixable rules provide warning-level fixes for individual Quick Fix actions
let fixable_warnings: Vec<_> = warnings
.iter()
.filter(|w| {
if let Some(rule_name) = &w.rule_name {
filtered_rules
.iter()
.find(|r| r.name() == rule_name)
.map(|r| r.fix_capability() != FixCapability::Unfixable)
.unwrap_or(false)
} else {
false
}
})
.cloned()
.collect();
// Count total fixable issues (excluding Unfixable rules)
let total_fixable = fixable_warnings.len();
if let Ok(fixed_content) = crate::utils::fix_utils::apply_warning_fixes(text, &fixable_warnings)
&& fixed_content != text
{
// Calculate proper end position
let mut line = 0u32;
let mut character = 0u32;
for ch in text.chars() {
if ch == '\n' {
line += 1;
character = 0;
} else {
character += 1;
}
}
let fix_all_action = CodeAction {
title: format!("Fix all rumdl issues ({total_fixable} fixable)"),
kind: Some(CodeActionKind::new("source.fixAll.rumdl")),
diagnostics: Some(Vec::new()),
edit: Some(WorkspaceEdit {
changes: Some(
[(
uri.clone(),
vec![TextEdit {
range: Range {
start: Position { line: 0, character: 0 },
end: Position { line, character },
},
new_text: fixed_content,
}],
)]
.into_iter()
.collect(),
),
..Default::default()
}),
command: None,
is_preferred: Some(true),
disabled: None,
data: None,
};
// Insert at the beginning to make it prominent
actions.insert(0, fix_all_action);
}
}
Ok(actions)
}
Err(e) => {
log::error!("Failed to get code actions: {e}");
Ok(Vec::new())
}
}
}
}