rumba-core 1.0.0

Core library for MBA (Mixed Boolean-Arithmetic) expression simplification
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
//! A minimal, extensible pattern matching engine.
//!
//! Patterns fire in the non-polynomial stage of simplification, on an
//! already-canonicalized (reduced) expression, before it is turned into a
//! polynomial. Each pattern is a hand-written matcher; the driver walks the
//! expression bottom-up and, at every node, tries only the patterns that
//! attach to that node's variant (see [`Tag`]).
//!
//! On a hit a pattern returns an already-canonical replacement (e.g.
//! [`Expr::zero`]); the driver does *not* re-reduce. Any resulting stray
//! constants are absorbed by the leading `reduce` of the next simplification
//! iteration.

use std::collections::BTreeMap;

use crate::expr::Expr;

/// A lightweight, `const`-constructible discriminant used to index patterns by
/// the expression variant they care about.
#[derive(Clone, Copy, PartialEq, Eq)]
pub enum Tag {
    And,
    Or,
    Xor,
    Add,
    Mul,
    Not,
    Scale,
    Var,
    Const,
}

impl Expr {
    /// The variant tag of this expression.
    fn tag(&self) -> Tag {
        match self {
            Expr::And(_) => Tag::And,
            Expr::Or(_) => Tag::Or,
            Expr::Xor(_) => Tag::Xor,
            Expr::Add(_) => Tag::Add,
            Expr::Mul(_) => Tag::Mul,
            Expr::Not(_) => Tag::Not,
            Expr::Scale(_, _) => Tag::Scale,
            Expr::Var(_) => Tag::Var,
            Expr::Const(_) => Tag::Const,
        }
    }
}

/// A single rewrite rule.
pub trait Pattern: Sync {
    /// The expression variants this pattern attaches to.
    fn tags(&self) -> &'static [Tag];

    /// Attempt to rewrite `e` (which is already reduced). Returns the canonical
    /// replacement on a hit, or `None` when the pattern does not apply.
    fn apply(&self, e: &Expr, mask: u64) -> Option<Expr>;
}

/// Splits a (reduced) term into `(factor, core)` such that `term == factor·core`
/// (mod 2ⁿ), seeing through `reduce`'s distribution of a scalar over a sum.
///
/// For `Scale(c, X)` this is `(c, X)`. For a uniformly-scaled sum such as
/// `2·x + 2·y` (the reduced form of `2·(x + y)`) it is `(2, x + y)`; the factor
/// comes from [`Expr::get_factor`] and the core is the term with that factor
/// divided out. A bare expression is `(1, itself)`. `reduce` guarantees no
/// nested `Scale(Scale(..))`, so a single strip is enough.
fn split(e: &Expr, mask: u64) -> (u64, Expr) {
    let f = e.get_factor(mask);
    if f == 1 {
        return (1, e.clone());
    }
    let strip = |t: &Expr| match t {
        Expr::Scale(_, inner) => (**inner).clone(),
        other => other.clone(),
    };
    let core = match e {
        Expr::Add(terms) => Expr::Add(terms.iter().map(strip).collect()),
        other => strip(other),
    };
    (f, core)
}

/// `coefficient * e`, reduced into the same canonical form seen by patterns.
fn scaled(e: &Expr, coefficient: u64, mask: u64) -> Expr {
    Expr::scale(coefficient, e.clone()).reduce_masked(mask)
}

/// The canonical arithmetic negation of `e`.
fn negated(e: &Expr, mask: u64) -> Expr {
    scaled(e, mask, mask)
}

/// Converts a reduced expression into its top-level additive coefficient map.
/// This lets us compare distributed forms such as `2*x - 2*y` and `x - y`.
fn additive_coefficients(e: &Expr, mask: u64) -> BTreeMap<Expr, u64> {
    let mut result = BTreeMap::new();
    let terms: &[Expr] = match e {
        Expr::Add(terms) => terms,
        _ => std::slice::from_ref(e),
    };
    for term in terms {
        let (coefficient, core) = match term {
            Expr::Scale(c, core) => (c & mask, core.as_ref().clone()),
            Expr::Const(c) => (c & mask, Expr::make_const(1)),
            _ => (1, term.clone()),
        };
        let entry = result.entry(core).or_insert(0u64);
        *entry = entry.wrapping_add(coefficient) & mask;
    }
    result.retain(|_, coefficient| *coefficient != 0);
    result
}

/// If `candidate == coefficient * base` modulo the current bit width, returns
/// that coefficient. At least one coefficient of `base` must be odd; the old
/// factor/core matcher remains as a fallback for uniformly even expressions.
fn scale_relation(candidate: &Expr, base: &Expr, mask: u64) -> Option<u64> {
    let arithmetic = |e: &Expr| match e {
        Expr::Not(inner) => (-inner.as_ref().clone() - Expr::make_const(1)).reduce_masked(mask),
        _ => e.clone(),
    };
    let candidate = additive_coefficients(&arithmetic(candidate), mask);
    let base = additive_coefficients(&arithmetic(base), mask);
    if candidate.keys().ne(base.keys()) {
        return None;
    }
    let (first, &pivot) = base
        .iter()
        .find(|(_, coefficient)| **coefficient & 1 == 1)?;

    // Newton iteration computes the inverse of an odd integer modulo 2^64;
    // masking below adapts it to the active bit width.
    let mut inverse = pivot;
    for _ in 0..6 {
        inverse = inverse.wrapping_mul(2u64.wrapping_sub(pivot.wrapping_mul(inverse)));
    }
    let coefficient = candidate[first].wrapping_mul(inverse) & mask;
    base.iter()
        .all(|(core, value)| candidate[core] == value.wrapping_mul(coefficient) & mask)
        .then_some(coefficient)
}

fn are_negations(a: &Expr, b: &Expr, mask: u64) -> bool {
    let arithmetic = |e: &Expr| match e {
        Expr::Not(inner) => (-inner.as_ref().clone() - Expr::make_const(1)).reduce_masked(mask),
        _ => e.clone(),
    };
    let a = arithmetic(a);
    let b = arithmetic(b);
    negated(&a, mask) == b
        || negated(&b, mask) == a
        || scale_relation(&a, &b, mask) == Some(mask)
        || scale_relation(&b, &a, mask) == Some(mask)
}

/// Returns the non-constant part of a reduced `m*X - 1` mask.
fn low_bit_mask_multiple(e: &Expr, mask: u64) -> Option<Expr> {
    let Expr::Add(terms) = e else {
        return None;
    };
    let mut neg_one = false;
    let mut rest = Vec::new();
    for term in terms {
        match term {
            Expr::Const(c) if (c & mask) == mask => neg_one = true,
            _ => rest.push(term.clone()),
        }
    }
    if !neg_one || rest.is_empty() {
        return None;
    }
    Some(if rest.len() == 1 {
        rest.remove(0)
    } else {
        Expr::Add(rest)
    })
}

mod low_bit_annihilator;
mod low_bit_mask_split;
mod masked_group_collapse;

use low_bit_annihilator::LowBitAnnihilator;
use low_bit_mask_split::LowBitMaskSplit;
use masked_group_collapse::MaskedGroupCollapse;

/// The registered patterns, tried in order at each node.
static PATTERNS: &[&dyn Pattern] = &[&LowBitAnnihilator, &LowBitMaskSplit, &MaskedGroupCollapse];

/// Applies the registered patterns to `e`, walking bottom-up.
pub fn apply_patterns(e: Expr, mask: u64) -> Expr {
    // Rewrite children first so parents see canonicalized subterms.
    let e = e.map(|child| apply_patterns(child, mask));

    let tag = e.tag();
    for pattern in PATTERNS {
        if pattern.tags().contains(&tag)
            && let Some(replacement) = pattern.apply(&e, mask)
        {
            return replacement;
        }
    }

    e
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::expr::{Expr, VarId};
    use crate::varint::make_mask;

    const N: u8 = 64;

    fn var(i: usize) -> Expr {
        Expr::Var(VarId(i))
    }

    /// `X & -X & (m·X)` reduced, then run through the pattern pass.
    fn annihilate(x: Expr, m: u64) -> Expr {
        let mask = make_mask(N);
        let e = (x.clone() & (-x.clone()) & (m * x)).reduce_masked(mask);
        apply_patterns(e, mask)
    }

    #[test]
    fn fires_on_power_of_two() {
        for k in 1..8 {
            let e = annihilate(var(0), 1 << k);
            assert_eq!(e, Expr::zero(), "k={k}");
        }
    }

    #[test]
    fn fires_on_even_non_power_of_two() {
        // 6 is even but not a power of two -> still valid.
        assert_eq!(annihilate(var(0), 6), Expr::zero());
        assert_eq!(annihilate(var(0), 10), Expr::zero());
    }

    #[test]
    fn fires_on_complex_core() {
        let x = var(0) | var(1);
        assert_eq!(annihilate(x, 2), Expr::zero());

        let x = var(0) & var(1);
        assert_eq!(annihilate(x, 4), Expr::zero());
    }

    #[test]
    fn annihilator_fires_on_affine_core() {
        let x = var(0) - var(1);
        for m in [2u64, 4, 6, 10] {
            assert_eq!(annihilate(x.clone(), m), Expr::zero(), "m={m}");
        }
    }

    #[test]
    fn fires_on_scaled_core() {
        // X = 2·y (X itself carries a coefficient).
        let x = 2u64 * var(0);
        assert_eq!(annihilate(x, 2), Expr::zero());
    }

    #[test]
    fn fires_within_larger_and() {
        let mask = make_mask(N);
        let x = var(0);
        let e = (var(1) & x.clone() & (-x.clone()) & (2u64 * x) & var(2)).reduce_masked(mask);
        assert_eq!(apply_patterns(e, mask), Expr::zero());
    }

    #[test]
    fn ignores_odd_multiple() {
        // 3·X is an odd multiple: the identity does NOT hold.
        let mask = make_mask(N);
        let x = var(0);
        let e = (x.clone() & (-x.clone()) & (3u64 * x)).reduce_masked(mask);
        assert_ne!(apply_patterns(e.clone(), mask), Expr::zero());
    }

    #[test]
    fn ignores_missing_negation() {
        let mask = make_mask(N);
        let x = var(0);
        let e = (x.clone() & (2u64 * x)).reduce_masked(mask);
        assert_ne!(apply_patterns(e.clone(), mask), Expr::zero());
    }

    #[test]
    fn ignores_unrelated_and() {
        let mask = make_mask(N);
        let e = (var(0) & var(1) & (2u64 * var(2))).reduce_masked(mask);
        let out = apply_patterns(e.clone(), mask);
        assert_eq!(out, e);
    }

    #[test]
    fn original_is_semantically_zero() {
        // Sanity: the pre-rewrite expression really is 0.
        let mask = make_mask(N);
        for m in [2u64, 4, 6, 8, 10, 1 << 20] {
            let x = var(0);
            let e = (x.clone() & (-x.clone()) & (m * x)).reduce_masked(mask);
            assert!(
                e.sem_equal_masked(&Expr::zero(), mask, 500).is_ok(),
                "m={m} not semantically zero"
            );
        }
    }

    /// `a·(X & M) + a·((-X) & M)` with `M = m·X - 1`, reduced and rewritten.
    fn mask_split(x: Expr, a: u64, m: u64) -> Expr {
        let mask = make_mask(N);
        let mm = m * x.clone() - Expr::make_const(1);
        let e = (a * (x.clone() & mm.clone()) + a * ((-x) & mm)).reduce_masked(mask);
        apply_patterns(e, mask)
    }

    #[test]
    fn split_collapses_to_multiple() {
        let mask = make_mask(N);
        for a in [1u64, 3, 5] {
            for m in [2u64, 4, 6, 8, 10] {
                let expected = (a * (m * var(0))).reduce_masked(mask);
                assert_eq!(mask_split(var(0), a, m), expected, "a={a} m={m}");
            }
        }
    }

    #[test]
    fn split_at_even_multiple_collapses_to_multiple() {
        let mask = make_mask(N);
        for x in [var(0), var(0) - var(1), var(0) + Expr::make_const(1)] {
            for multiple in [2u64, 4, 6, 10] {
                let boundary = (multiple * x.clone()).reduce_masked(mask);
                let before = ((x.clone() & boundary.clone()) + ((-x.clone()) & boundary.clone()))
                    .reduce_masked(mask);
                assert_eq!(apply_patterns(before, mask), boundary);
            }
        }
    }

    #[test]
    fn split_is_semantically_equivalent() {
        let mask = make_mask(N);
        for a in [1u64, 3, 7] {
            for m in [2u64, 4, 6, 12, 1 << 10] {
                let x = var(0);
                let mm = m * x.clone() - Expr::make_const(1);
                let before = (a * (x.clone() & mm.clone()) + a * ((-x) & mm)).reduce_masked(mask);
                let after = apply_patterns(before.clone(), mask);
                assert!(
                    before.sem_equal_masked(&after, mask, 500).is_ok(),
                    "a={a} m={m} rewrite changed semantics"
                );
            }
        }
    }

    #[test]
    fn split_fires_on_scaled_core() {
        // X = 2·y carries its own coefficient.
        let mask = make_mask(N);
        let x = 2u64 * var(0);
        let expected = (3u64 * (6u64 * x.clone())).reduce_masked(mask);
        assert_eq!(mask_split(x, 3, 6), expected);
    }

    #[test]
    fn split_fires_on_affine_core() {
        let mask = make_mask(N);
        let x = var(0) - var(1);
        let expected = (3u64 * (6u64 * x.clone())).reduce_masked(mask);
        assert_eq!(mask_split(x, 3, 6), expected);
    }

    #[test]
    fn split_fires_within_larger_add() {
        let mask = make_mask(N);
        let x = var(0);
        let mm = 6u64 * x.clone() - Expr::make_const(1);
        let e = (var(1) + 3u64 * (x.clone() & mm.clone()) + 3u64 * ((-x.clone()) & mm))
            .reduce_masked(mask);
        let expected = (var(1) + 3u64 * (6u64 * x)).reduce_masked(mask);
        assert_eq!(apply_patterns(e, mask), expected);
    }

    #[test]
    fn split_ignores_odd_multiple() {
        // `3·X - 1` is an odd multiple: the identity does not hold.
        let mask = make_mask(N);
        let x = var(0);
        let mm = 3u64 * x.clone() - Expr::make_const(1);
        let e = (3u64 * (x.clone() & mm.clone()) + 3u64 * ((-x) & mm)).reduce_masked(mask);
        let out = apply_patterns(e.clone(), mask);
        assert_eq!(out, e);
    }

    /// The residue left on `loki_tiny.csv:8584`: `(v1 & M) - ((v0 & v1) & M)`
    /// with `M = 2·C & -C` and `C = v1 & ~v0`. It vanishes because the two
    /// terms differ exactly on `C`, which `M` annihilates.
    #[test]
    fn masked_group_collapses_difference_on_annihilated_atom() {
        let mask = make_mask(N);
        let c = (var(1) - (var(0) & var(1))).reduce_masked(mask);
        let m = |t: Expr| t & (2u64 * c.clone()) & (-c.clone());
        let before = (m(var(1)) - m(var(0) & var(1))).reduce_masked(mask);
        assert!(
            before.sem_equal_masked(&Expr::zero(), mask, 500).is_ok(),
            "residue is not semantically zero"
        );
        assert_eq!(apply_patterns(before, mask), Expr::zero());
    }

    /// The residue left on `loki_tiny.csv:4220`: `((v0 & v1) & M) - (v0 & M)`
    /// with `M = -2·D & -D` and `D = v0 | v1`. Here the differing atom is
    /// `v0 & ~v1`, which `M` annihilates only via its containment in `D`.
    #[test]
    fn masked_group_collapses_via_submask_containment() {
        let mask = make_mask(N);
        let d = (var(0) + var(1) - (var(0) & var(1))).reduce_masked(mask);
        let m = |t: Expr| t & ((-2i64 as u64) * d.clone()) & (-d.clone());
        let before = (m(var(0) & var(1)) - m(var(0))).reduce_masked(mask);
        assert!(
            before.sem_equal_masked(&Expr::zero(), mask, 500).is_ok(),
            "residue is not semantically zero"
        );
        assert_eq!(apply_patterns(before, mask), Expr::zero());
    }

    /// The complement reading of the annihilator, as left on
    /// `loki_tiny.csv:23488`: `(S - 1) & ~S` is everything strictly below `S`'s
    /// lowest set bit, which *any* multiple of `S` clears — unlike the `-S`
    /// reading, this one does not need the multiple to be even.
    #[test]
    fn masked_group_collapses_on_complement_of_successor() {
        let mask = make_mask(N);
        // The last core is `v0 ^ v1` spelled arithmetically, as `reduce` leaves
        // it in the corpus; an `Xor` node would be distributed into instead.
        let cores = [
            var(0),
            var(0) & var(1),
            (var(0) + var(1) - 2u64 * (var(0) & var(1))).reduce_masked(mask),
        ];
        for core in cores {
            let s = (core.clone() + Expr::make_const(1)).reduce_masked(mask);
            for m in [2u64, 3, 4, mask - 1] {
                let boundary = ((m * s.clone()) & !s.clone()).reduce_masked(mask);
                let before = ((core.clone() & boundary.clone())
                    - (core.clone() & var(1) & boundary))
                    .reduce_masked(mask);
                assert!(
                    before.sem_equal_masked(&Expr::zero(), mask, 500).is_ok(),
                    "m={m} residue is not semantically zero"
                );
                assert_eq!(apply_patterns(before, mask), Expr::zero(), "m={m}");
            }
        }
    }

    /// `reduce` leaves `-1 · ~x` alone, so the complement reading only works if
    /// the conjunct is spelled out arithmetically first. Guards that step.
    #[test]
    fn masked_group_sees_through_unreduced_complement() {
        let mask = make_mask(N);
        let s =
            (var(0) + var(1) + Expr::make_const(1) - 2u64 * (var(0) & var(1))).reduce_masked(mask);
        let conjuncts = vec![
            ((-2i64 as u64) * s.clone()).reduce_masked(mask),
            var(0),
            !var(1),
            !s,
        ];
        let before = (Expr::And(conjuncts.clone()) - Expr::And(conjuncts)).reduce_masked(mask);
        assert_eq!(apply_patterns(before, mask), Expr::zero());
    }

    /// The same shape with an *odd* multiple: the annihilator does not hold and
    /// the group must survive untouched.
    #[test]
    fn masked_group_keeps_odd_multiple() {
        let mask = make_mask(N);
        let c = (var(1) - (var(0) & var(1))).reduce_masked(mask);
        let m = |t: Expr| t & (3u64 * c.clone()) & (-c.clone());
        let before = (m(var(1)) - m(var(0) & var(1))).reduce_masked(mask);
        assert_eq!(apply_patterns(before.clone(), mask), before);
    }

    #[test]
    fn split_ignores_mismatched_scale() {
        // Different outer scales `a` on the two summands: no collapse.
        let mask = make_mask(N);
        let x = var(0);
        let mm = 6u64 * x.clone() - Expr::make_const(1);
        let e = (3u64 * (x.clone() & mm.clone()) + 5u64 * ((-x) & mm)).reduce_masked(mask);
        let out = apply_patterns(e.clone(), mask);
        assert_eq!(out, e);
    }
}