ruff_linter 0.16.3

This is an internal component crate of Ruff
Documentation
use std::fmt::{Debug, Display, Formatter};

use ruff_macros::CacheKey;
use rustc_hash::FxHashMap;

use crate::preview::is_warn_on_unknown_selectors_enabled;
use crate::rule_selector::RuleResolutionError;
use crate::{Applicability, UnresolvedRuleSelector};
use crate::{
    display_settings,
    registry::{Rule, RuleSet},
    rule_selector::{PreviewOptions, Specificity},
};

/// A table to keep track of which rules fixes should have
/// their safety overridden.
#[derive(Debug, Clone, CacheKey, Default)]
pub struct FixSafetyTable {
    forced_safe: RuleSet,
    forced_unsafe: RuleSet,
}

impl FixSafetyTable {
    pub(crate) const fn resolve_applicability(
        &self,
        rule: Rule,
        applicability: Applicability,
    ) -> Applicability {
        match applicability {
            // If applicability is display-only we don't change it
            Applicability::DisplayOnly => applicability,
            Applicability::Safe | Applicability::Unsafe => {
                if self.forced_unsafe.contains(rule) {
                    Applicability::Unsafe
                } else if self.forced_safe.contains(rule) {
                    Applicability::Safe
                } else {
                    applicability
                }
            }
        }
    }

    pub fn from_rule_selectors(
        extend_safe_fixes: &[UnresolvedRuleSelector],
        extend_unsafe_fixes: &[UnresolvedRuleSelector],
        preview_options: &PreviewOptions,
    ) -> Result<Self, RuleResolutionError> {
        #[derive(Copy, Clone)]
        enum Override {
            Safe,
            Unsafe,
        }

        let mut safety_override_map: FxHashMap<Rule, (Specificity, Override)> =
            FxHashMap::default();
        let selectors = extend_safe_fixes
            .iter()
            .map(|selector| ("extend-safe-fixes", selector, Override::Safe))
            .chain(
                extend_unsafe_fixes
                    .iter()
                    .map(|selector| ("extend-unsafe-fixes", selector, Override::Unsafe)),
            );

        for (setting, selector, safety_override) in selectors {
            let selector = match selector.resolve(preview_options.mode) {
                Ok(selector) => selector,
                Err(mut err) => {
                    err = err.with_setting(setting);
                    if is_warn_on_unknown_selectors_enabled(preview_options.mode) {
                        err.log_warning();
                        continue;
                    }
                    return Err(err);
                }
            };
            let specificity = selector.specificity();

            for rule in selector.rules(preview_options) {
                safety_override_map
                    .entry(rule)
                    .and_modify(|existing| {
                        if specificity >= existing.0 {
                            *existing = (specificity, safety_override);
                        }
                    })
                    .or_insert((specificity, safety_override));
            }
        }

        Ok(FixSafetyTable {
            forced_safe: safety_override_map
                .iter()
                .filter_map(|(rule, (_, o))| match o {
                    Override::Safe => Some(*rule),
                    Override::Unsafe => None,
                })
                .collect(),
            forced_unsafe: safety_override_map
                .iter()
                .filter_map(|(rule, (_, o))| match o {
                    Override::Unsafe => Some(*rule),
                    Override::Safe => None,
                })
                .collect(),
        })
    }
}

impl Display for FixSafetyTable {
    fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
        display_settings! {
            formatter = f,
            namespace = "linter.safety_table",
            fields = [
                self.forced_safe,
                self.forced_unsafe
            ]
        }
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_resolve_applicability() {
        let table = FixSafetyTable {
            forced_safe: RuleSet::from_iter([Rule::RedefinedWhileUnused]),
            forced_unsafe: RuleSet::from_iter([Rule::UnusedImport]),
        };

        for applicability in &[Applicability::Safe, Applicability::Unsafe] {
            assert_eq!(
                table.resolve_applicability(Rule::RedefinedWhileUnused, *applicability),
                Applicability::Safe // It is forced to Safe
            );
        }
        for applicability in &[Applicability::Safe, Applicability::Unsafe] {
            assert_eq!(
                table.resolve_applicability(Rule::UnusedImport, *applicability),
                Applicability::Unsafe // It is forced to Unsafe
            );
        }
        for applicability in &[Applicability::Safe, Applicability::Unsafe] {
            assert_eq!(
                table.resolve_applicability(Rule::UndefinedName, *applicability),
                *applicability // Remains unchanged
            );
        }

        for rule in &[
            Rule::RedefinedWhileUnused,
            Rule::UnusedImport,
            Rule::UndefinedName,
        ] {
            assert_eq!(
                table.resolve_applicability(*rule, Applicability::DisplayOnly),
                Applicability::DisplayOnly // Display is never changed
            );
        }
    }

    fn mk_table(safe_fixes: &[&str], unsafe_fixes: &[&str]) -> FixSafetyTable {
        FixSafetyTable::from_rule_selectors(
            &safe_fixes
                .iter()
                .map(|s| UnresolvedRuleSelector::cli(*s))
                .collect::<Vec<_>>(),
            &unsafe_fixes
                .iter()
                .map(|s| UnresolvedRuleSelector::cli(*s))
                .collect::<Vec<_>>(),
            &PreviewOptions::default(),
        )
        .expect("Expected valid rule selectors")
    }

    fn assert_rules_safety(
        table: &FixSafetyTable,
        assertions: &[(&str, Applicability, Applicability)],
    ) {
        for (code, applicability, expected) in assertions {
            assert_eq!(
                table.resolve_applicability(Rule::from_code(code).unwrap(), *applicability),
                *expected
            );
        }
    }

    #[test]
    fn test_from_rule_selectors_specificity() {
        use Applicability::{Safe, Unsafe};
        let table = mk_table(&["UP"], &["ALL", "UP001"]);

        assert_rules_safety(
            &table,
            &[
                ("E101", Safe, Unsafe),
                ("UP001", Safe, Unsafe),
                ("UP003", Unsafe, Safe),
            ],
        );
    }

    #[test]
    fn test_from_rule_selectors_unsafe_over_safe() {
        use Applicability::{Safe, Unsafe};
        let table = mk_table(&["UP"], &["UP"]);

        assert_rules_safety(&table, &[("E101", Safe, Safe), ("UP001", Safe, Unsafe)]);
    }
}