ruda-model 0.21.51

Ruda model configuration, module parameters, records and data loading.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
use ruda_dataset::Dataset;
use ruda_dataset::transform::PartialDataset;
use ruda_tensor::api::backend::Backend;
use rand::distr::{Distribution, StandardUniform};
use rand::rngs::StdRng;
use rand::{Rng, SeedableRng};

use super::batcher::Batcher;
use super::{BatchDataLoader, BatchStrategy, DataLoader, DataLoaderIterator, Progress};
use std::sync::{
    Arc, Mutex, OnceLock,
    atomic::{AtomicBool, Ordering},
    mpsc,
};
use std::thread;

const MAX_QUEUED_ITEMS: usize = 100;

type RngSeed = <StdRng as SeedableRng>::Seed;

/// A multi-threaded data loader that can be used to iterate over a dataset.
///
/// Dropping an iterator stops prefetching and waits for any dataset read or batch
/// construction already in progress to return. Workers are joined unless reuse
/// is explicitly enabled with [`Self::reuse_workers`].
pub struct MultiThreadDataLoader<B: Backend, I, O> {
    // Configuration parameters needed for initialization
    strategy: Box<dyn BatchStrategy<I>>,
    dataset: Arc<dyn Dataset<I>>,
    batcher: Arc<dyn Batcher<B, I, O>>,
    device: B::Device,
    seed: Option<RngSeed>,
    num_threads: usize,
    reuse_workers: bool,
    batch_reading: bool,

    // The lazily initialized data loaders
    dataloaders: OnceLock<Vec<BatchDataLoader<B, I, O>>>,
    worker_pool: OnceLock<Arc<Mutex<WorkerPoolState<O>>>>,
}

/// A message that can be sent between threads.
#[derive(Debug, crate::record::Record)]
pub enum Message<O> {
    /// A batch of items.
    Batch(usize, O, Progress),

    /// The thread is done.
    Done,
}

struct MultiThreadsDataloaderIterator<O> {
    num_done: usize,
    num_workers: usize,
    workers: Vec<thread::JoinHandle<()>>,
    reused_workers: Option<WorkerEpoch<O>>,
    receiver: Option<mpsc::Receiver<Message<O>>>,
    progresses: Vec<Progress>,
    items_total: usize,
    items_processed: usize,
    cancelled: Arc<AtomicBool>,
}

enum WorkerPoolState<O> {
    Uninitialized,
    Idle(WorkerPool<O>),
    InUse,
}

struct WorkerJob<O> {
    sender: mpsc::SyncSender<Message<O>>,
    cancelled: Arc<AtomicBool>,
    finished: mpsc::Sender<bool>,
    load: Box<dyn FnOnce(&mpsc::SyncSender<Message<O>>, &AtomicBool) + Send>,
}

struct WorkerCompletion(mpsc::Sender<bool>);

impl Drop for WorkerCompletion {
    fn drop(&mut self) {
        // Preserve the original panic in the JoinHandle rather than catching it
        // and continuing to use the failed worker's device/thread-local state.
        let _ = self.0.send(thread::panicking());
    }
}

struct WorkerPool<O> {
    senders: Vec<mpsc::Sender<WorkerJob<O>>>,
    workers: Vec<thread::JoinHandle<()>>,
}

impl<O> WorkerPool<O> {
    fn shutdown(&mut self) -> thread::Result<()> {
        self.senders.clear();
        let mut result = Ok(());
        for worker in self.workers.drain(..) {
            if let Err(payload) = worker.join() {
                if result.is_ok() {
                    result = Err(payload);
                }
            }
        }
        result
    }
}

impl<O> Drop for WorkerPool<O> {
    fn drop(&mut self) {
        let _ = self.shutdown();
    }
}

struct WorkerLease<O> {
    pool: Option<WorkerPool<O>>,
    cache: Option<Arc<Mutex<WorkerPoolState<O>>>>,
}

impl<O> WorkerLease<O> {
    fn release(mut self) {
        let pool = self.pool.take().expect("leased worker pool");
        let cache = self.cache.take().expect("worker pool cache");
        *cache.lock().unwrap_or_else(|error| error.into_inner()) = WorkerPoolState::Idle(pool);
    }
}

impl<O> Drop for WorkerLease<O> {
    fn drop(&mut self) {
        if let Some(cache) = self.cache.take() {
            // This also handles partial initialization/dispatch. Close and join
            // outside the cache lock before allowing a new pool to be created.
            drop(self.pool.take());
            *cache.lock().unwrap_or_else(|error| error.into_inner()) =
                WorkerPoolState::Uninitialized;
        }
    }
}

struct WorkerEpoch<O> {
    lease: WorkerLease<O>,
    finished: mpsc::Receiver<bool>,
    dispatched: usize,
    failed: bool,
}

impl<O> WorkerEpoch<O> {
    fn finish(mut self) -> thread::Result<()> {
        for _ in 0..self.dispatched {
            match self.finished.recv() {
                Ok(panicked) => self.failed |= panicked,
                Err(_) => {
                    self.failed = true;
                    break;
                }
            }
        }
        if self.failed {
            let result = self
                .lease
                .pool
                .as_mut()
                .expect("leased worker pool")
                .shutdown();
            return match result {
                Err(payload) => Err(payload),
                Ok(()) => Err(Box::new(String::from("data loader worker failed to complete"))),
            };
        }
        self.lease.release();
        Ok(())
    }
}

fn run_worker<B: Backend, I, O>(
    dataloader: &BatchDataLoader<B, I, O>,
    index: usize,
    sender: &mpsc::SyncSender<Message<O>>,
    cancelled: &AtomicBool,
) where
    I: Send + Sync + Clone + 'static,
    O: Send + 'static,
{
    if cancelled.load(Ordering::Relaxed) {
        return;
    }
    let mut iterator = dataloader.iter();
    while !cancelled.load(Ordering::Relaxed) {
        let Some(item) = iterator.next() else {
            break;
        };
        let progress = iterator.progress();
        if sender.send(Message::Batch(index, item, progress)).is_err() {
            return;
        }
    }
    sender.send(Message::Done).ok();
}

impl<B: Backend, I, O> MultiThreadDataLoader<B, I, O>
where
    I: Send + Sync + Clone + 'static,
    O: Send + 'static,
{
    /// Creates a new multi-threaded batch data loader.
    ///
    /// # Arguments
    ///
    /// * `strategy` - The batch strategy.
    /// * `dataset` - The dataset.
    /// * `batcher` - The batcher.
    /// * `num_threads` - The number of threads.
    /// * `device`  - The device to use when loading a batch.
    /// * `rng`     - The rng determining if the dataset is shuffled each time a dataloader
    ///   iterator is created.
    ///
    /// # Returns
    ///
    /// The multi-threaded batch data loader.
    pub fn new(
        strategy: Box<dyn BatchStrategy<I>>,
        dataset: Arc<dyn Dataset<I>>,
        batcher: Arc<dyn Batcher<B, I, O>>,
        num_threads: usize,
        device: B::Device,
        rng: Option<rand::rngs::StdRng>,
    ) -> Self {
        let mut seed = None;
        if let Some(mut rng) = rng {
            // RNG stream splitting (not state cloning): derive a new seed from the RNG's output.
            // This is exactly what `rng.fork()` does.
            let mut s = RngSeed::default();
            rng.fill_bytes(&mut s);

            seed = Some(s);
        }
        Self::from_seed(strategy, dataset, batcher, num_threads, device, seed)
    }

    fn from_seed(
        strategy: Box<dyn BatchStrategy<I>>,
        dataset: Arc<dyn Dataset<I>>,
        batcher: Arc<dyn Batcher<B, I, O>>,
        num_threads: usize,
        device: B::Device,
        seed: Option<RngSeed>,
    ) -> Self {
        Self {
            strategy,
            dataset,
            batcher,
            num_threads,
            device,
            seed,
            dataloaders: OnceLock::new(),
            reuse_workers: false,
            batch_reading: false,
            worker_pool: OnceLock::new(),
        }
    }

    /// Enables reuse of idle workers across iterations (disabled by default).
    ///
    /// Finishing or dropping an iterator still waits for its in-flight reads and
    /// batch construction. Concurrent iterators use separate transient workers
    /// when the reusable pool is busy, rather than waiting behind another epoch.
    /// A panicked worker is joined; failed batches are never automatically replayed.
    pub fn reuse_workers(mut self, enabled: bool) -> Self {
        self.reuse_workers = enabled;
        if !enabled {
            drop(self.worker_pool.take());
        }
        self
    }

    /// Enables batch dataset reads for every worker (default: false).
    ///
    /// Missing items or a mismatched result length panic without rereading; the
    /// iterator propagates worker failures using its existing shutdown behavior.
    pub fn batch_reading(mut self, enabled: bool) -> Self {
        self.batch_reading = enabled;
        if let Some(dataloaders) = self.dataloaders.get_mut() {
            for dataloader in dataloaders {
                dataloader.set_batch_reading(enabled);
            }
        }
        self
    }

    fn lease_workers(&self, num_workers: usize) -> Option<WorkerLease<O>> {
        if !self.reuse_workers {
            return None;
        }
        let worker_pool = self
            .worker_pool
            .get_or_init(|| Arc::new(Mutex::new(WorkerPoolState::Uninitialized)));
        let pool = {
            let mut cache = worker_pool
                .lock()
                .unwrap_or_else(|error| error.into_inner());
            if matches!(*cache, WorkerPoolState::InUse) {
                return None;
            }
            match std::mem::replace(&mut *cache, WorkerPoolState::InUse) {
                WorkerPoolState::Idle(pool) => Some(pool),
                WorkerPoolState::Uninitialized => None,
                WorkerPoolState::InUse => unreachable!(),
            }
        };
        let mut lease = WorkerLease {
            pool,
            cache: Some(worker_pool.clone()),
        };
        if lease.pool.is_none() {
            let mut pool = WorkerPool {
                senders: Vec::with_capacity(num_workers),
                workers: Vec::with_capacity(num_workers),
            };
            for index in 0..num_workers {
                let (sender, receiver) = mpsc::channel::<WorkerJob<O>>();
                let worker = thread::Builder::new()
                    .name(std::format!("dataloader-{index}"))
                    .spawn(move || {
                        while let Ok(job) = receiver.recv() {
                            let completion = WorkerCompletion(job.finished);
                            (job.load)(&job.sender, &job.cancelled);
                            drop(job.sender);
                            drop(job.cancelled);
                            drop(completion);
                        }
                    })
                    .expect("failed to spawn reusable data loader worker");
                pool.senders.push(sender);
                pool.workers.push(worker);
            }
            lease.pool = Some(pool);
        }
        Some(lease)
    }

    /// Force initialization if needed.
    fn initialize(&self) -> &[BatchDataLoader<B, I, O>] {
        self.dataloaders
            .get_or_init(|| {
                let mut dataset = self.dataset.clone();
                if let Some(seed) = self.seed.as_ref() {
                    // Pre-shuffle the dataset before split if shuffle is enabled.
                    // This ensures that each thread gets a uniform random sample of the dataset.
                    let mut rng = StdRng::from_seed(*seed);
                    dataset = Arc::new(ruda_dataset::transform::ShuffledDataset::new(
                        dataset, &mut rng,
                    ));
                }

                let datasets = match self.strategy.batch_size() {
                    Some(batch_size) => {
                        let split_size = if self.batch_reading { batch_size.max(1) } else { batch_size };
                        PartialDataset::split_chunks(dataset, self.num_threads, split_size)
                    }
                    None => PartialDataset::split(dataset, self.num_threads),
                };

                // Create more rngs from the first one, one for each new dataloader.
                let mut rng = self.seed.map(StdRng::from_seed);
                let rngs = (0..self.num_threads).map(|_| {
                    rng.as_mut().map(|rng| {
                        StdRng::seed_from_u64(Distribution::sample(&StandardUniform, rng))
                    })
                });

                datasets
                    .into_iter()
                    .zip(rngs)
                    .map(|(dataset, rng)| {
                        let strategy = self.strategy.clone_dyn();
                        BatchDataLoader::new(
                            strategy,
                            Arc::new(dataset),
                            self.batcher.clone(),
                            self.device.clone(),
                            rng,
                        )
                        .batch_reading(self.batch_reading)
                    })
                    .collect()
            })
            .as_ref()
    }
}

impl<B: Backend, I, O> DataLoader<B, O> for MultiThreadDataLoader<B, I, O>
where
    I: Send + Sync + Clone + 'static,
    O: Send + 'static + std::fmt::Debug,
{
    fn iter<'a>(&'a self) -> Box<dyn DataLoaderIterator<O> + 'a> {
        // This will initialize the loader if it hasn't been initialized yet
        let dataloaders = self.initialize();

        let (sender, receiver) = mpsc::sync_channel::<Message<O>>(MAX_QUEUED_ITEMS);

        let progresses = dataloaders
            .iter()
            .map(|dataloader| Progress::new(0, dataloader.num_items()))
            .collect();
        let mut iterator = MultiThreadsDataloaderIterator::new(
            receiver,
            Vec::with_capacity(dataloaders.len()),
            progresses,
        );

        if let Some(lease) = self.lease_workers(dataloaders.len()) {
            let (finished, receiver) = mpsc::channel();
            iterator.reused_workers = Some(WorkerEpoch {
                lease,
                finished: receiver,
                dispatched: 0,
                failed: true,
            });
            let epoch = iterator.reused_workers.as_mut().expect("worker epoch");
            for (index, (worker, dataloader)) in epoch
                .lease
                .pool
                .as_ref()
                .expect("leased worker pool")
                .senders
                .iter()
                .zip(dataloaders)
                .enumerate()
            {
                let dataloader = dataloader.clone();
                worker
                    .send(WorkerJob {
                        sender: sender.clone(),
                        cancelled: iterator.cancelled.clone(),
                        finished: finished.clone(),
                        load: Box::new(move |sender, cancelled| {
                            run_worker(&dataloader, index, sender, cancelled);
                        }),
                    })
                    .unwrap_or_else(|_| panic!("reusable data loader worker disconnected"));
                epoch.dispatched += 1;
            }
            epoch.failed = false;
            drop(finished);
        } else {
            for (index, dataloader) in dataloaders.iter().enumerate() {
                let dataloader_cloned = dataloader.clone();
                let sender_cloned = sender.clone();
                let cancelled = iterator.cancelled.clone();
                let worker = std::thread::Builder::new()
                    .name(std::format!("dataloader-{index}"))
                    .spawn(move || {
                        run_worker(&dataloader_cloned, index, &sender_cloned, &cancelled);
                    })
                    .expect("failed to spawn data loader worker");
                iterator.workers.push(worker);
            }
        }
        drop(sender);

        Box::new(iterator)
    }

    fn num_items(&self) -> usize {
        // For num_items, we can directly use the dataset size without
        // necessarily initializing the full loader
        self.dataset.len()
    }

    fn to_device(&self, device: &B::Device) -> Arc<dyn DataLoader<B, O>> {
        Arc::new(
            Self::from_seed(
                self.strategy.clone_dyn(),
                self.dataset.clone(),
                self.batcher.clone(),
                self.num_threads,
                device.clone(),
                self.seed,
            )
            .reuse_workers(self.reuse_workers)
            .batch_reading(self.batch_reading),
        )
    }

    fn slice(&self, start: usize, end: usize) -> Arc<dyn DataLoader<B, O>> {
        let dataloader = Self::from_seed(
            self.strategy.clone_dyn(),
            Arc::new(PartialDataset::new(self.dataset.clone(), start, end)),
            self.batcher.clone(),
            self.num_threads,
            self.device.clone(),
            self.seed,
        )
        .reuse_workers(self.reuse_workers)
        .batch_reading(self.batch_reading);
        Arc::new(dataloader)
    }
}

impl<O> MultiThreadsDataloaderIterator<O> {
    pub fn new(
        receiver: mpsc::Receiver<Message<O>>,
        workers: Vec<thread::JoinHandle<()>>,
        progresses: Vec<Progress>,
    ) -> Self {
        MultiThreadsDataloaderIterator {
            num_done: 0,
            num_workers: progresses.len(),
            workers,
            reused_workers: None,
            receiver: Some(receiver),
            items_total: progresses.iter().map(|progress| progress.items_total).sum(),
            items_processed: progresses.iter().map(|progress| progress.items_processed).sum(),
            progresses,
            cancelled: Arc::new(AtomicBool::new(false)),
        }
    }

    fn shutdown(&mut self) -> thread::Result<()> {
        self.cancelled.store(true, Ordering::Relaxed);
        // Disconnect before joining so workers blocked on a full queue can exit.
        drop(self.receiver.take());
        let mut result = match self.reused_workers.take() {
            Some(epoch) => epoch.finish(),
            None => Ok(()),
        };
        for worker in self.workers.drain(..) {
            if let Err(payload) = worker.join() {
                if result.is_ok() {
                    result = Err(payload);
                }
            }
        }
        result
    }
}

impl<O> Drop for MultiThreadsDataloaderIterator<O> {
    fn drop(&mut self) {
        // Worker panics are propagated by next(), not during unwinding in Drop.
        let _ = self.shutdown();
    }
}
impl<O: std::fmt::Debug> DataLoaderIterator<O> for MultiThreadsDataloaderIterator<O> {
    fn progress(&self) -> Progress {
        Progress::new(self.items_processed, self.items_total)
    }
}

impl<O: std::fmt::Debug> Iterator for MultiThreadsDataloaderIterator<O> {
    type Item = O;

    fn next(&mut self) -> Option<O> {
        if self.receiver.is_none() || self.num_workers == 0 {
            return None;
        }

        loop {
            let item = match self.receiver.as_ref()?.recv() {
                Ok(item) => item,
                Err(_) => {
                    if let Err(payload) = self.shutdown() {
                        std::panic::resume_unwind(payload);
                    }
                    panic!("data loader workers disconnected before reporting completion");
                }
            };

            match item {
                Message::Batch(index, item, progress) => {
                    if let Some(current) = self.progresses.get_mut(index) {
                        self.items_processed =
                            self.items_processed - current.items_processed + progress.items_processed;
                        self.items_total =
                            self.items_total - current.items_total + progress.items_total;
                        *current = progress;
                    }
                    return Some(item);
                }
                Message::Done => {
                    self.num_done += 1;
                }
            };

            if self.num_done == self.num_workers {
                if let Err(payload) = self.shutdown() {
                    std::panic::resume_unwind(payload);
                }
                return None;
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::data::dataloader::FixBatchStrategy;
    use crate::data::dataloader::batcher::TestBatcher;
    use crate::data::dataset::FakeDataset;
    use ruda_dataset::InMemDataset;
    use std::collections::HashSet;

    #[test]
    fn test_multi_thread_batch_dataloader() {
        let batcher = Arc::new(TestBatcher::new());
        let dataset = Arc::new(FakeDataset::<String>::new(27));
        let dataloader_single_thread = BatchDataLoader::new(
            Box::new(FixBatchStrategy::new(5)),
            dataset.clone(),
            batcher.clone(),
            Default::default(),
            None,
        );
        let dataloader_multi_thread = MultiThreadDataLoader::new(
            Box::new(FixBatchStrategy::new(5)),
            dataset,
            batcher,
            4,
            Default::default(),
            None,
        );

        let mut items_single_thread = HashSet::new();
        let mut items_multi_thread = HashSet::new();

        for items in dataloader_single_thread.iter() {
            for item in items {
                items_single_thread.insert(item);
            }
        }

        for items in dataloader_multi_thread.iter() {
            for item in items {
                items_multi_thread.insert(item);
            }
        }

        assert_eq!(items_single_thread, items_multi_thread);
    }

    #[test]
    fn test_multi_thread_batch_dataloader_shuffle() {
        let num_classes = 2;
        let class_size = 100;
        let batch_size = 10;

        // Items is a deliberately ordered dataset.
        let mut items = Vec::new();
        for class in 0..num_classes {
            items.extend(vec![class; class_size]);
        }

        {
            // Unshuffled multithreaded loader
            let dataset = Arc::new(InMemDataset::new(items.clone()));
            let batcher = Arc::new(TestBatcher::new());

            let loader = MultiThreadDataLoader::new(
                Box::new(FixBatchStrategy::new(batch_size)),
                dataset,
                batcher,
                num_classes,
                Default::default(),
                // No rng means no shuffling.
                None,
            );

            for batch in loader.iter() {
                let mut batch_items = HashSet::new();
                for item in batch {
                    batch_items.insert(item);
                }

                // Since the dataset is not shuffled, we expect each batch to contain the same item.
                assert_eq!(batch_items.len(), 1);
            }
        }

        {
            // Shuffled multithreaded loader
            let dataset = Arc::new(InMemDataset::new(items.clone()));
            let batcher = Arc::new(TestBatcher::new());

            let loader = MultiThreadDataLoader::new(
                Box::new(FixBatchStrategy::new(batch_size)),
                dataset.clone(),
                batcher.clone(),
                num_classes,
                Default::default(),
                // The rng enables shuffling.
                Some(StdRng::seed_from_u64(42)),
            );

            for batch in loader.iter() {
                let mut batch_items = HashSet::new();
                for item in batch {
                    batch_items.insert(item);
                }

                // Since the dataset is shuffled, we expect to see all items.
                assert_eq!(batch_items.len(), num_classes);
            }
        }
    }

    #[test]
    fn test_multi_thread_batch_dataloader_incomplete_batches() {
        let batcher = Arc::new(TestBatcher::new());
        let dataset = Arc::new(FakeDataset::<String>::new(27));
        let dataloader_single_thread = BatchDataLoader::new(
            Box::new(FixBatchStrategy::new(5)),
            dataset.clone(),
            batcher.clone(),
            Default::default(),
            None,
        );
        let dataloader_multi_thread = MultiThreadDataLoader::new(
            Box::new(FixBatchStrategy::new(5)),
            dataset,
            batcher,
            4,
            Default::default(),
            None,
        );

        let mut items_single_thread = HashSet::new();
        let mut items_multi_thread = HashSet::new();

        let mut single_thread_cnt = 0;
        let mut multi_thread_cnt = 0;
        for items in dataloader_single_thread.iter() {
            items_single_thread.insert(items);
            single_thread_cnt += 1;
        }

        for items in dataloader_multi_thread.iter() {
            items_multi_thread.insert(items);
            multi_thread_cnt += 1;
        }

        assert_eq!(single_thread_cnt, multi_thread_cnt);
        assert_eq!(items_single_thread, items_multi_thread);
    }
}