ruchy 4.2.0

//! Loop expression parsing
//!
//! Handles parsing of all loop constructs:
//! - `for` loops with pattern destructuring
//! - `while` loops and `while let` loops
//! - Infinite `loop` expressions
//! - Loop labels for break/continue targeting
//!
//! # Examples
//! ```ruchy
//! // For loop with simple pattern
//! for i in 0..10 {
//!     print(i)
//! }
//!
//! // For loop with tuple destructuring
//! for key, value in map {
//!     print(f"{key}: {value}")
//! }
//!
//! // While loop
//! while x < 10 {
//!     x = x + 1
//! }
//!
//! // While-let loop
//! while let Some(value) = optional {
//!     process(value)
//! }
//!
//! // Labeled loop
//! 'outer: for i in 0..10 {
//!     for j in 0..10 {
//!         if should_exit {
//!             break 'outer
//!         }
//!     }
//! }
//!
//! // Infinite loop
//! loop {
//!     if done { break }
//! }
//! ```
//!
//! Extracted from expressions.rs to improve maintainability (TDG Structural improvement).

use crate::frontend::ast::{Expr, ExprKind, Pattern};
use crate::frontend::lexer::Token;
use crate::frontend::parser::{bail, parse_expr_recursive, ParserState, Result};

// Import pattern parsing functions from parent expressions module
use super::super::{parse_list_pattern, parse_match_pattern, parse_tuple_pattern};

/// Parse loop label dispatch
///
/// Handles labeled loop constructs: `'label: for/while/loop`
pub(in crate::frontend::parser) fn parse_loop_label(
    state: &mut ParserState,
    label_name: String,
) -> Result<Expr> {
    // Note: Caller has already consumed the Lifetime token, so current token is Colon
    state.tokens.expect(&Token::Colon)?;
    match state.tokens.peek() {
        Some((Token::For, _)) => parse_labeled_for_loop(state, Some(label_name)),
        Some((Token::While, _)) => parse_labeled_while_loop(state, Some(label_name)),
        Some((Token::Loop, _)) => parse_labeled_loop(state, Some(label_name)),
        _ => bail!("Expected loop keyword after label"),
    }
}

/// Parse while loop without label
pub(in crate::frontend::parser) fn parse_while_loop(state: &mut ParserState) -> Result<Expr> {
    parse_labeled_while_loop(state, None)
}

/// Parse while loop with optional label
///
/// Supports both regular `while` and `while let` syntax.
fn parse_labeled_while_loop(state: &mut ParserState, label: Option<String>) -> Result<Expr> {
    let start_span = state.tokens.expect(&Token::While)?;
    // Check for while-let syntax
    if matches!(state.tokens.peek(), Some((Token::Let, _))) {
        state.tokens.advance(); // consume 'let'
                                // Parse the pattern
        let pattern = parse_match_pattern(state)
            .map_err(|e| anyhow::anyhow!("Expected pattern after 'while let': {e}"))?;
        // Expect '='
        state
            .tokens
            .expect(&Token::Equal)
            .map_err(|e| anyhow::anyhow!("Expected '=' after pattern in while-let: {e}"))?;
        // Parse the expression to match against
        let expr = Box::new(
            parse_expr_recursive(state)
                .map_err(|e| anyhow::anyhow!("Expected expression after '=' in while-let: {e}"))?,
        );
        // Parse body (expect block)
        let body = Box::new(
            parse_expr_recursive(state)
                .map_err(|e| anyhow::anyhow!("Expected body after while-let condition: {e}"))?,
        );
        Ok(Expr::new(
            ExprKind::WhileLet {
                label,
                pattern,
                expr,
                body,
            },
            start_span,
        ))
    } else {
        // Regular while loop
        // Parse condition
        let condition = Box::new(
            parse_expr_recursive(state)
                .map_err(|e| anyhow::anyhow!("Expected condition after 'while': {e}"))?,
        );
        // Parse body (expect block)
        let body = Box::new(
            parse_expr_recursive(state)
                .map_err(|e| anyhow::anyhow!("Expected body after while condition: {e}"))?,
        );
        Ok(Expr::new(
            ExprKind::While {
                label,
                condition,
                body,
            },
            start_span,
        ))
    }
}

/// Parse for loop without label
///
/// Supports pattern destructuring in the loop variable.
pub(in crate::frontend::parser) fn parse_for_loop(state: &mut ParserState) -> Result<Expr> {
    parse_labeled_for_loop(state, None)
}

/// Parse for loop with optional label
///
/// Syntax: `['label:] for pattern in iterator { body }`
fn parse_labeled_for_loop(state: &mut ParserState, label: Option<String>) -> Result<Expr> {
    let start_span = state.tokens.expect(&Token::For)?;
    // Parse pattern (e.g., "i" in "for i in ...")
    let pattern = parse_for_pattern(state)?;
    // Expect 'in' keyword
    state
        .tokens
        .expect(&Token::In)
        .map_err(|_| anyhow::anyhow!("Expected 'in' after for pattern"))?;
    // Parse iterator expression
    let iterator = Box::new(
        parse_expr_recursive(state)
            .map_err(|e| anyhow::anyhow!("Expected iterator after 'in': {e}"))?,
    );
    // Parse body (expect block)
    let body = Box::new(
        parse_expr_recursive(state)
            .map_err(|e| anyhow::anyhow!("Expected body after for iterator: {e}"))?,
    );
    // Get the var name from the pattern for backward compatibility
    let var = pattern.primary_name();
    Ok(Expr::new(
        ExprKind::For {
            label,
            var,
            pattern: Some(pattern),
            iter: iterator,
            body,
        },
        start_span,
    ))
}

/// Parse for loop pattern
///
/// Supports:
/// - Simple identifier: `for i in ...`
/// - Wildcard: `for _ in ...`
/// - Tuple destructuring: `for (x, y) in ...` or `for x, y in ...`
/// - List destructuring: `for [x, y] in ...`
fn parse_for_pattern(state: &mut ParserState) -> Result<Pattern> {
    let Some((token, _)) = state.tokens.peek() else {
        bail!("Expected pattern in for loop");
    };
    match token {
        Token::Identifier(name) => {
            let name = name.clone();
            state.tokens.advance();
            // Check if this is a bare tuple pattern: key, value (without parens)
            if matches!(state.tokens.peek(), Some((Token::Comma, _))) {
                // Parse as bare tuple: key, value, ...
                let mut patterns = vec![Pattern::Identifier(name)];
                while matches!(state.tokens.peek(), Some((Token::Comma, _))) {
                    state.tokens.advance(); // consume comma
                                            // Parse next pattern element
                    if let Some((Token::Identifier(next_name), _)) = state.tokens.peek() {
                        let next_name = next_name.clone();
                        state.tokens.advance();
                        patterns.push(Pattern::Identifier(next_name));
                    } else {
                        bail!("Expected identifier after comma in tuple pattern");
                    }
                }
                Ok(Pattern::Tuple(patterns))
            } else {
                Ok(Pattern::Identifier(name))
            }
        }
        Token::Underscore => {
            state.tokens.advance();
            Ok(Pattern::Wildcard)
        }
        Token::LeftParen => {
            // Parse tuple pattern with parens: (x, y)
            parse_tuple_pattern(state)
        }
        Token::LeftBracket => {
            // Parse list pattern: [x, y]
            parse_list_pattern(state)
        }
        _ => bail!("Expected identifier, underscore, or destructuring pattern in for loop"),
    }
}

/// Parse infinite loop without label
pub(in crate::frontend::parser) fn parse_loop(state: &mut ParserState) -> Result<Expr> {
    parse_labeled_loop(state, None)
}

/// Parse infinite loop with optional label
///
/// Syntax: `['label:] loop { body }`
fn parse_labeled_loop(state: &mut ParserState, label: Option<String>) -> Result<Expr> {
    let start_span = state.tokens.expect(&Token::Loop)?;
    let body = Box::new(parse_expr_recursive(state)?);

    Ok(Expr::new(ExprKind::Loop { label, body }, start_span))
}

#[cfg(test)]
mod tests {

    use crate::frontend::ast::ExprKind;
    use crate::frontend::parser::Parser;

    #[test]
    fn test_for_loop_simple() {
        let code = "for i in 0..10 { print(i) }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Simple for loop should parse");
    }

    #[test]
    fn test_for_loop_tuple_destructuring() {
        let code = "for key, value in map { print(key) }";
        let result = Parser::new(code).parse();
        assert!(
            result.is_ok(),
            "For loop with tuple destructuring should parse"
        );
    }

    #[test]
    fn test_for_loop_tuple_with_parens() {
        let code = "for (x, y) in pairs { print(x) }";
        let result = Parser::new(code).parse();
        assert!(
            result.is_ok(),
            "For loop with tuple pattern (parens) should parse"
        );
    }

    #[test]
    fn test_for_loop_wildcard() {
        let code = "for _ in 0..10 { side_effect() }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop with wildcard should parse");
    }

    #[test]
    fn test_while_loop() {
        let code = "while x < 10 { x = x + 1 }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While loop should parse");
    }

    #[test]
    fn test_while_let_loop() {
        let code = "while let Some(value) = optional { process(value) }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While-let loop should parse");
    }

    #[test]
    fn test_infinite_loop() {
        let code = "loop { if done { break } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Infinite loop should parse");
    }

    // PARSER-079: Fixed - Labeled loops now work correctly
    #[test]
    fn test_labeled_for_loop() {
        let code = "'outer: for i in 0..10 { break 'outer }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Labeled for loop should parse");
    }

    #[test]
    fn test_labeled_while_loop() {
        let code = "'outer: while true { break 'outer }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Labeled while loop should parse");
    }

    #[test]
    fn test_labeled_infinite_loop() {
        let code = "'outer: loop { break 'outer }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Labeled infinite loop should parse");
    }

    // Additional tests for coverage
    #[test]
    fn test_for_loop_over_array() {
        let code = "for item in [1, 2, 3] { print(item) }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop over array should parse");
    }

    #[test]
    fn test_for_loop_over_function_call() {
        let code = "for x in get_items() { print(x) }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop over function call should parse");
    }

    #[test]
    fn test_for_loop_with_empty_body() {
        let code = "for i in 0..10 { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop with empty body should parse");
    }

    #[test]
    fn test_while_loop_with_true() {
        let code = "while true { break }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While true loop should parse");
    }

    #[test]
    fn test_while_loop_with_false() {
        let code = "while false { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While false loop should parse");
    }

    #[test]
    fn test_while_loop_compound_condition() {
        let code = "while x > 0 && y < 100 { x = x - 1 }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While with compound condition should parse");
    }

    #[test]
    fn test_while_let_with_tuple() {
        let code = "while let (a, b) = get_pair() { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While let with tuple should parse");
    }

    #[test]
    fn test_while_let_with_none() {
        let code = "while let None = maybe { break }";
        let result = Parser::new(code).parse();
        // Some grammars may not support None pattern
        assert!(result.is_ok() || result.is_err());
    }

    #[test]
    fn test_loop_with_empty_body() {
        let code = "loop { break }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Loop with break should parse");
    }

    #[test]
    fn test_for_loop_over_range_inclusive() {
        let code = "for i in 0..=10 { print(i) }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop over inclusive range should parse");
    }

    #[test]
    fn test_for_loop_three_element_tuple() {
        let code = "for a, b, c in triples { print(a) }";
        let result = Parser::new(code).parse();
        assert!(
            result.is_ok(),
            "For loop with three element tuple should parse"
        );
    }

    #[test]
    fn test_nested_for_loops() {
        let code = "for i in 0..10 { for j in 0..10 { } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Nested for loops should parse");
    }

    #[test]
    fn test_for_inside_while() {
        let code = "while running { for x in items { } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For inside while should parse");
    }

    #[test]
    fn test_while_inside_for() {
        let code = "for x in items { while processing { } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While inside for should parse");
    }

    #[test]
    fn test_loop_inside_loop() {
        let code = "loop { loop { break } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Nested loop should parse");
    }

    #[test]
    fn test_for_loop_over_method_call() {
        let code = "for x in items.iter() { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop over method call should parse");
    }

    #[test]
    fn test_for_loop_list_destructuring() {
        let code = "for [a, b] in pairs { print(a) }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop with list pattern should parse");
    }

    #[test]
    fn test_while_loop_with_parenthesized_condition() {
        let code = "while (x > 0) { }";
        let result = Parser::new(code).parse();
        assert!(
            result.is_ok(),
            "While with parenthesized condition should parse"
        );
    }

    #[test]
    fn test_for_loop_with_underscore_var() {
        let code = "for _unused in 0..10 { }";
        let result = Parser::new(code).parse();
        assert!(
            result.is_ok(),
            "For loop with underscore prefix should parse"
        );
    }

    // ===== Additional coverage tests (Round 102) =====

    // Test 30: For loop with enumerate
    #[test]
    fn test_for_loop_enumerate() {
        let code = "for i, item in items.enumerate() { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop with enumerate should parse");
    }

    // Test 31: While loop with complex condition
    #[test]
    fn test_while_complex_condition() {
        let code = "while x > 0 && y < 100 { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While with complex condition should parse");
    }

    // Test 32: Loop with return
    #[test]
    fn test_loop_with_return() {
        let code = "fun f() { loop { return 42 } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Loop with return should parse");
    }

    // Test 33: For loop with filter chain
    #[test]
    fn test_for_loop_filter_chain() {
        let code = "for x in items.filter(|x| x > 0) { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop with filter should parse");
    }

    // Test 34: While let with tuple pattern
    #[test]
    fn test_while_let_tuple() {
        let code = "while let (a, b) = get_pair() { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While let with tuple should parse");
    }

    // Test 35: For loop in function body
    #[test]
    fn test_for_in_function() {
        let code = "fun process(items) { for x in items { print(x) } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop in function should parse");
    }

    // Test 36: While with method call condition
    #[test]
    fn test_while_method_condition() {
        let code = "while queue.is_not_empty() { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While with method condition should parse");
    }

    // Test 37: Nested while loops
    #[test]
    fn test_nested_while_loops() {
        let code = "while a { while b { } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Nested while loops should parse");
    }

    // Test 38: For loop with map chain
    #[test]
    fn test_for_loop_map_chain() {
        let code = "for x in items.map(|x| x * 2) { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop with map should parse");
    }

    // Test 39: Loop with labeled break
    #[test]
    fn test_loop_labeled_break() {
        let code = "'outer: loop { loop { break 'outer } }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Loop with labeled break should parse");
    }

    // Test 39b: PARSER-079 - Verify label is actually set in the AST
    #[test]
    fn test_labeled_for_loop_label_is_set() {
        let code = "'outer: for i in [1, 2] { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "Labeled for loop should parse");

        let expr = result.unwrap();
        // Navigate to the For expression - it should be inside a Block
        let for_expr = match &expr.kind {
            ExprKind::Block(exprs) if !exprs.is_empty() => &exprs[0],
            _ => &expr,
        };

        match &for_expr.kind {
            ExprKind::For { label, var, .. } => {
                assert!(
                    label.is_some(),
                    "For loop label should be Some, got None. var={:?}",
                    var
                );
                // The label should be stripped of the leading quote
                // 'outer becomes "outer"
                let label_val = label.as_ref().unwrap();
                assert!(
                    !label_val.starts_with('\''),
                    "Label should not start with quote, got: {:?}",
                    label_val
                );
            }
            other => panic!("Expected For expression, got: {:?}", other),
        }
    }

    // Test 40: For loop over array literal
    #[test]
    fn test_for_loop_array_literal() {
        let code = "for x in [1, 2, 3] { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop over array literal should parse");
    }

    // Test 41: While with assignment in block
    #[test]
    fn test_while_assignment_block() {
        let code = "while true { let x = 1 }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "While with assignment should parse");
    }

    // Test 42: For loop with index pattern
    #[test]
    fn test_for_loop_indexed() {
        let code = "for (i, v) in items.enumerate() { }";
        let result = Parser::new(code).parse();
        assert!(result.is_ok(), "For loop with tuple pattern should parse");
    }

    // Property tests for loops
    #[cfg(test)]
    mod property_tests {
        use super::*;
        use proptest::prelude::*;

        proptest! {
            #[test]
            #[ignore = "Property tests run with --ignored flag"] // Run with: cargo test property_tests -- --ignored
            fn prop_for_loops_never_panic(var in "[a-z]+", n in 0u32..100) {
                let code = format!("for {var} in 0..{n} {{ }}");
                let _ = Parser::new(&code).parse(); // Should not panic
            }

            #[test]
            #[ignore = "Property tests run with --ignored flag"]
            fn prop_while_loops_never_panic(var in "[a-z]+", n in 0i32..100) {
                let code = format!("while {var} < {n} {{ }}");
                let _ = Parser::new(&code).parse(); // Should not panic
            }

            #[test]
            #[ignore = "Property tests run with --ignored flag"]
            fn prop_infinite_loops_always_parse(_seed in any::<u32>()) {
                let code = "loop { break }";
                let result = Parser::new(code).parse();
                prop_assert!(result.is_ok());
            }

            #[test]
            #[ignore = "Property tests run with --ignored flag"]
            fn prop_labeled_loops_parse(label in "[a-z]+") {
                let code = format!("'{label}: loop {{ break '{label}  }}");
                let result = Parser::new(&code).parse();
                prop_assert!(result.is_ok());
            }

            #[test]
            #[ignore = "Property tests run with --ignored flag"]
            fn prop_for_tuple_destructuring(var1 in "[a-z]+", var2 in "[a-z]+") {
                let code = format!("for {var1}, {var2} in pairs {{ }}");
                let result = Parser::new(&code).parse();
                prop_assert!(result.is_ok());
            }

            #[test]
            #[ignore = "Property tests run with --ignored flag"]
            fn prop_while_let_always_has_pattern(var in "[a-z]+") {
                let code = format!("while let Some({var}) = opt {{ }}");
                let result = Parser::new(&code).parse();
                prop_assert!(result.is_ok());
            }

            #[test]
            #[ignore = "Property tests run with --ignored flag"]
            fn prop_nested_loops_parse(depth in 1usize..5) {
                let mut code = String::new();
                for i in 0..depth {
                    code.push_str(&format!("for x{i} in 0..10 {{ "));
                }
                code.push_str("()");
                for _ in 0..depth {
                    code.push_str(" }");
                }
                let result = Parser::new(&code).parse();
                prop_assert!(result.is_ok());
            }
        }
    }
}