rucc_codegen/coverage.rs
1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72 // The convention. What a call's operands are is whatever the signature made them, and which
73 // register each one arrives in depends on the classification of every argument before it.
74 (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75 (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76 // The frame, which is not known until the allocator has finished running out of registers.
77 (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78 // A relocation, which is right because of what the linker does rather than because of what
79 // any bitvector equals.
80 (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
81 // No instruction at all. The IR keeps the width the same and the machine has one register
82 // file for both, so the value is already where it needs to be.
83 (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
84 (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
85 // Memory SSA, which is built at -O2, read by the passes that need it, and taken back off
86 // before selection. Nothing in the back end has ever seen a value of type `mem`.
87 (Opcode::MemEntry, "nothing at all, since memory SSA comes off before the back end runs"),
88 // The edges and the two ways of writing down that control does not arrive.
89 (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
90 (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
91 (Opcode::UnreachableHint, "nothing at all, for the same reason"),
92 // Rewritten into the opcodes above before selection ever sees them.
93 (Opcode::Switch, "`crate::expand`, into the compare and branch chain it is"),
94 (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
95 (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
96 (Opcode::UIToFP, "`crate::expand`, into a widening and a signed conversion"),
97 (Opcode::FPToUI, "`crate::expand`, into a signed conversion and a narrowing"),
98 (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
99 (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
100 (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
101 (Opcode::Bswap, "`crate::expand`, into the shifts and masks that reverse the bytes"),
102 (Opcode::Ctpop, "`crate::expand`, into the halving sum that counts the set bits"),
103 (Opcode::Ctlz, "`crate::expand`, into a smear and a set bit count"),
104 (Opcode::Cttz, "`crate::expand`, into a mask of the low zeroes and a set bit count"),
105 // The variable argument list, which is four opcodes reading a structure the ABI describes.
106 (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
107 (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
108 (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
109 (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
110 (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
111 // Memory safety. A check is a call to the runtime, and the rewrite happens after the optimizer
112 // has run so that the descriptor table only has rows for checks that survived it.
113 (Opcode::CheckBounds, "`rucc_safety::lower`, into a call carrying the row that describes it"),
114 (Opcode::CheckLive, "`rucc_safety::lower`, the same call over the lifetime plane"),
115 (Opcode::CheckDeriv, "`rucc_safety::lower`, the same call where the pointer is computed"),
116 // The capability the checks were reading, which the same pass takes out once they are calls,
117 // because a call to the runtime is handed an address and finds the rest for itself.
118 (Opcode::CapOf, "`rucc_safety::lower`, which removes it, since nothing reads it any more"),
119];
120
121/// An opcode nothing lowers, why it is here, and the issue that closes it.
122///
123/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
124/// spec says it should be, which is the honest reading of where the back end is: every one of
125/// these is a feature nobody has written, and all but three of them are opcodes the front end
126/// cannot produce either, so a program that reaches one of these is a program that reaches an
127/// unimplemented builtin first.
128pub static GAPS: &[(Opcode, &str, &str)] = &[
129 (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
130 (
131 Opcode::TargetIntrinsic,
132 "the same, since what needs one is a vector builtin",
133 "tamnd/rucc#200",
134 ),
135 (Opcode::BlockAddr, "the address of a label", "tamnd/rucc#353"),
136 (Opcode::IndirectBr, "the branch a computed goto turns into", "tamnd/rucc#353"),
137 (
138 Opcode::FRem,
139 "a call to `fmod`, so a link line question as much as a lowering one",
140 "tamnd/rucc#226",
141 ),
142 (
143 Opcode::Fma,
144 "a call or one instruction, depending on what the machine is told it has",
145 "tamnd/rucc#226",
146 ),
147 (Opcode::AtomicLoad, "an ordering, which the IR cannot say yet", "tamnd/rucc#311"),
148 (Opcode::AtomicStore, "the same", "tamnd/rucc#311"),
149 (Opcode::AtomicRmw, "the same, and a `lock` prefix per operation", "tamnd/rucc#311"),
150 (Opcode::Cmpxchg, "the same, and a result that is a pair", "tamnd/rucc#311"),
151 (
152 Opcode::Fence,
153 "the same, and nothing at all on this machine for most orderings",
154 "tamnd/rucc#311",
155 ),
156 (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
157 (
158 Opcode::SAddOverflow,
159 "a result and a flag together, which no rule can write",
160 "tamnd/rucc#309",
161 ),
162 (Opcode::UAddOverflow, "the same", "tamnd/rucc#309"),
163 (Opcode::SSubOverflow, "the same", "tamnd/rucc#309"),
164 (Opcode::USubOverflow, "the same", "tamnd/rucc#309"),
165 (Opcode::SMulOverflow, "the same", "tamnd/rucc#309"),
166 (Opcode::UMulOverflow, "the same", "tamnd/rucc#309"),
167 (Opcode::Expect, "a branch weight nothing reads yet", "tamnd/rucc#364"),
168 (Opcode::Prefetch, "one instruction, once the hints have somewhere to go", "tamnd/rucc#313"),
169 (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
170 (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
171 (
172 Opcode::StackSave,
173 "a frame that can grow, as a variable length array needs",
174 "tamnd/rucc#291",
175 ),
176 (Opcode::StackRestore, "the same", "tamnd/rucc#291"),
177 (
178 Opcode::SetjmpMarker,
179 "a call that returns twice, which the allocator has to be told about",
180 "tamnd/rucc#223",
181 ),
182 (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
183 (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
184 (
185 Opcode::InlineAsm,
186 "a template, its constraints, and sixty eight torture programs",
187 "tamnd/rucc#349",
188 ),
189 // Memory safety. These are a gap in a different sense from the rest: nothing emits one yet
190 // either, since the passes that would are milestones S2 and after, so there is no program the
191 // back end can be handed that reaches one. The four the S1 pass does emit are on `ELSEWHERE`.
192 (
193 Opcode::CapLoad,
194 "a capability, whose runtime shape `spec/safe-memory/05-representation.md` decides",
195 "tamnd/rucc#428",
196 ),
197 (Opcode::CapStore, "the same, and a store into the slot beside a pointer", "tamnd/rucc#428"),
198 (
199 Opcode::CapNull,
200 "the same, and it is whatever the representation says nothing is",
201 "tamnd/rucc#428",
202 ),
203 (Opcode::CapNarrow, "the same, and arithmetic on the bounds it holds", "tamnd/rucc#428"),
204 (Opcode::CapRecover, "the same, and a read of the shadow planes", "tamnd/rucc#428"),
205 (Opcode::CheckType, "a read of the type plane, which is S5's", "tamnd/rucc#431"),
206 (Opcode::CheckInit, "the same, over the init plane, which is S5's too", "tamnd/rucc#431"),
207 (Opcode::CheckRace, "the same, over the epoch plane, which is S5's as well", "tamnd/rucc#431"),
208 // The plane writes, which the runtime does for itself today because the only ranges anything
209 // asks about are the ones its own allocator handed out. A stack object needs these.
210 (Opcode::MetaBegin, "a write over a range of the lifetime plane", "tamnd/rucc#428"),
211 (
212 Opcode::MetaEnd,
213 "the same write, with the version bumped past every capability",
214 "tamnd/rucc#428",
215 ),
216 (Opcode::MetaType, "the same over the type plane, which is S5's", "tamnd/rucc#431"),
217 (Opcode::MetaInit, "the same over the init plane, which is S5's", "tamnd/rucc#431"),
218 (
219 Opcode::MetaTransfer,
220 "the same, and the state a range is in while a device owns it, which is S2's",
221 "tamnd/rucc#428",
222 ),
223 (
224 Opcode::SafeRegionBegin,
225 "nothing at all, once the count document 10 section 10.2 asks for has been taken",
226 "tamnd/rucc#428",
227 ),
228 (Opcode::SafeRegionEnd, "the same, which is to say nothing", "tamnd/rucc#428"),
229];
230
231/// A width no rule is written at, why, and the issue that closes it.
232///
233/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
234/// every name it has is a name a rule is written at, and a width with no name has no names to
235/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
236/// language cannot spell. So the widths are written down here for the same reason the opcodes are
237/// written down above.
238pub static WIDTHS: &[(&str, &str, &str)] = &[
239 (
240 "one bit",
241 "everything but and, or, xor, a constant, and the widening out of one",
242 "tamnd/rucc#352",
243 ),
244 (
245 "a hundred and twenty eight bits",
246 "no register pair, so nothing at that width has a name",
247 "tamnd/rucc#351",
248 ),
249 (
250 "eighty bits",
251 "a long double is on the x87 stack and no rule is about that stack",
252 "tamnd/rucc#326",
253 ),
254 (
255 "a vector of any lane count",
256 "a rule at a width says nothing about how many lanes",
257 "tamnd/rucc#200",
258 ),
259];
260
261/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
262/// back.
263///
264/// The third list, and the one that is about a name rather than about an opcode or a width. An
265/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
266/// and neither of those can say that `add` is lowered at four widths and left alone at two.
267///
268/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
269/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
270/// two sign extended chars and there is no C program that asks the back end to add two bytes.
271/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
272/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
273/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
274/// it writes a byte add out of the truncation the assignment back to a `char` already was.
275///
276/// What is left is what the pass will not narrow. A divide is not narrowed because the most
277/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
278/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen. A
279/// truth value widened to a byte is not narrowed because it is a truncation of an extension that
280/// started narrower than the truncation ends, which is a third shape the pass does not have.
281///
282/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
283/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
284/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
285/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
286pub static NAMES: &[(&str, &str, &str)] = &[
287 ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
288 ("sdiv.i16", "the same", NARROW),
289 ("udiv.i8", "the same", NARROW),
290 ("udiv.i16", "the same", NARROW),
291 ("srem.i8", "the same", NARROW),
292 ("srem.i16", "the same", NARROW),
293 ("urem.i8", "the same", NARROW),
294 ("urem.i16", "the same", NARROW),
295 ("zext.i1.i8", "a truth value widened to a byte, which nothing asks for at that width", NARROW),
296 ("zext.i1.i16", "the same", NARROW),
297];
298
299/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
300const NARROW: &str = "tamnd/rucc#375";
301
302/// What a target's rules cover, and what they do not.
303#[derive(Debug)]
304pub struct Report {
305 /// The rule file this is about, so that anything said about it names a file to open.
306 pub source: &'static str,
307 /// How many opcodes the IR has.
308 pub opcodes: usize,
309 /// The opcodes every name of which a rule is written at.
310 pub by_rule: Vec<Opcode>,
311 /// How many names those are, which is one per opcode and width.
312 pub names: usize,
313 /// A name a rule could be written at and none is, which is what a missing rule looks like.
314 pub uncovered: Vec<(Opcode, &'static str)>,
315 /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
316 pub deferred: Vec<(Opcode, &'static str)>,
317 /// A name a rule is written at that nothing can ever be called, which is a dead rule.
318 pub unreachable: Vec<&'static str>,
319 /// The opcodes lowered somewhere a rule cannot reach.
320 pub elsewhere: Vec<Opcode>,
321 /// The opcodes nothing lowers.
322 pub gaps: Vec<Opcode>,
323 /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
324 /// where it goes.
325 pub unaccounted: Vec<Opcode>,
326}
327
328impl fmt::Display for Report {
329 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
330 write!(
331 f,
332 "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
333 where no rule reaches, {} have no lowering yet and {} names are left for later",
334 self.source,
335 self.by_rule.len(),
336 self.opcodes,
337 self.names,
338 self.elsewhere.len(),
339 self.gaps.len(),
340 self.deferred.len()
341 )
342 }
343}
344
345/// What a table covers.
346///
347/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
348/// both data, and the answer is a comparison of two lists.
349#[must_use]
350pub fn report(table: &Table) -> Report {
351 let named = term::heads();
352 let patterns = pattern_heads(table);
353
354 let mut by_rule = Vec::new();
355 let mut uncovered = Vec::new();
356 let mut deferred = Vec::new();
357 for &(opcode, name) in &named {
358 if patterns.contains(&name) {
359 by_rule.push(opcode);
360 } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
361 deferred.push((opcode, name));
362 } else {
363 uncovered.push((opcode, name));
364 }
365 }
366 // An opcode is covered when every name it has is covered, so one missing width takes the
367 // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
368 // not take it off, because the opcode is lowered and the entry says which widths were left for
369 // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
370 // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
371 // four widths.
372 for &(opcode, _) in &uncovered {
373 by_rule.retain(|&covered| covered != opcode);
374 }
375 by_rule.sort_unstable();
376 by_rule.dedup();
377
378 let names = named.len() - uncovered.len() - deferred.len();
379 let unreachable: Vec<&'static str> = patterns
380 .iter()
381 .filter(|head| !named.iter().any(|(_, name)| name == *head))
382 .copied()
383 .collect();
384
385 let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
386 let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
387 let unaccounted: Vec<Opcode> = Opcode::all()
388 .filter(|opcode| {
389 !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
390 })
391 .collect();
392
393 Report {
394 source: table.source,
395 opcodes: Opcode::all().count(),
396 by_rule,
397 names,
398 uncovered,
399 deferred,
400 unreachable,
401 elsewhere,
402 gaps,
403 unaccounted,
404 }
405}
406
407/// Every name a rule in a table is written about, which is the first test the trie makes.
408///
409/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
410/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
411/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
412/// one that would be an error to write, since a lowering has to know what it is lowering.
413fn pattern_heads(table: &Table) -> Vec<&'static str> {
414 let Some(root) = table.nodes.first() else { return Vec::new() };
415 let mut found: Vec<&'static str> = root
416 .tests
417 .iter()
418 .filter_map(|(test, _)| match test {
419 Test::App { head, .. } => Some(*head),
420 // Neither can be at the root. A pattern is a term with a head, so the first step of
421 // every one of them is a head, and there is nothing bound yet to be the same as.
422 Test::Int(_) | Test::Same(_) => None,
423 })
424 .collect();
425 found.sort_unstable();
426 found.dedup();
427 found
428}
429
430/// The rules a target lowers by, or `None` where no back end in this crate covers it.
431///
432/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
433/// and it is here as well because a caller that wants to write down what a run covered has a
434/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
435/// time, and until then it has no rules to report coverage of rather than an empty set of them.
436#[must_use]
437pub fn table(arch: Arch) -> Option<&'static Table> {
438 match arch {
439 Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
440 Arch::Aarch64 | Arch::Riscv64 => None,
441 }
442}
443
444/// Which rules fired, over one function or over a whole compilation.
445///
446/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
447/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
448/// thing that answers the question is a flag per rule set once.
449///
450/// The index of a rule is how this is kept and not how it is written down. An index moves the
451/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
452/// a line is a place somebody can open, and a report written by one build can still be read against
453/// a rule file that has grown since.
454#[derive(Debug, Clone, Default, PartialEq, Eq)]
455pub struct Fired {
456 /// One entry per rule, true once that rule has fired. It grows to fit the highest index
457 /// marked rather than being sized from a table, so nothing here has to be told which target
458 /// is being compiled for.
459 seen: Vec<bool>,
460}
461
462impl Fired {
463 /// Nothing has fired yet.
464 #[must_use]
465 pub const fn new() -> Fired {
466 Fired { seen: Vec::new() }
467 }
468
469 /// Records that the rule at this index fired.
470 pub fn mark(&mut self, rule: usize) {
471 if self.seen.len() <= rule {
472 self.seen.resize(rule + 1, false);
473 }
474 self.seen[rule] = true;
475 }
476
477 /// Whether the rule at this index fired.
478 #[must_use]
479 pub fn has(&self, rule: usize) -> bool {
480 self.seen.get(rule).copied().unwrap_or(false)
481 }
482
483 /// How many rules fired.
484 #[must_use]
485 pub fn count(&self) -> usize {
486 self.seen.iter().filter(|fired| **fired).count()
487 }
488
489 /// Takes in everything another one recorded.
490 ///
491 /// One compilation is many functions and one command line is many files, and the question is
492 /// about all of them together. Merging rather than writing a file per function is also what
493 /// keeps the answer the same however the work was scheduled.
494 pub fn merge(&mut self, other: &Fired) {
495 if self.seen.len() < other.seen.len() {
496 self.seen.resize(other.seen.len(), false);
497 }
498 for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
499 *mine |= *theirs;
500 }
501 }
502
503 /// What `-Zrule-coverage=FILE` writes.
504 ///
505 /// One line per rule in the table, in the order the rule file writes them, each saying whether
506 /// the rule fired and naming the file and line it is written at. Every rule is listed rather
507 /// than only the ones that fired, so that one of these files says what the whole rule set was
508 /// as well as what this compilation reached: a reader unioning them over a corpus needs both
509 /// and would otherwise have to parse the rule file to get the second.
510 ///
511 /// The first line is a comment holding the count, which is the number a person wants and the
512 /// one thing here that is not worth making them add up.
513 #[must_use]
514 pub fn listing(&self, table: &Table) -> String {
515 let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
516 let mut out = format!(
517 "# rucc rule coverage: {fired} of {} rules in {} fired\n",
518 table.rules.len(),
519 table.source
520 );
521 for (index, rule) in table.rules.iter().enumerate() {
522 let word = if self.has(index) { "fired" } else { "unused" };
523 let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
524 }
525 out
526 }
527}
528
529#[cfg(test)]
530mod tests {
531 use super::*;
532 use crate::select::x86_64::TABLE;
533
534 /// The claim the whole module is for, in the direction that matters: a name an instruction
535 /// can be called by is a name a rule is written at. This is the width check as much as the
536 /// opcode check, since a name is an opcode and a width together.
537 #[test]
538 fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
539 let report = report(&TABLE);
540 assert!(
541 report.uncovered.is_empty(),
542 "nothing in {} lowers these, and each is an opcode at a width the rule language can \
543 spell: {:?}",
544 report.source,
545 report.uncovered
546 );
547 }
548
549 /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
550 /// A pattern head no instruction is ever called by is a rule written against a name that was
551 /// renamed or misspelled, and it would sit there proved and unreachable.
552 #[test]
553 fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
554 let report = report(&TABLE);
555 assert!(
556 report.unreachable.is_empty(),
557 "{} has rules for these and no instruction is ever called one: {:?}",
558 report.source,
559 report.unreachable
560 );
561 }
562
563 /// Every opcode is one of the three things, so a new opcode in the IR fails this until
564 /// somebody says where it goes. That is the whole point: the answer for a new opcode should
565 /// be written down when it is added rather than discovered by a user compiling a program.
566 #[test]
567 fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
568 let report = report(&TABLE);
569 assert!(
570 report.unaccounted.is_empty(),
571 "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
572 does not say why they are not: {:?}",
573 report.unaccounted
574 );
575 assert_eq!(
576 report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
577 report.opcodes,
578 "the three lists overlap, so an opcode is counted twice"
579 );
580 }
581
582 /// An entry that starts being covered fails, which is the rule every list in this project is
583 /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
584 /// that keeps claiming otherwise is a list nobody can read.
585 #[test]
586 fn an_entry_a_rule_now_covers_is_a_stale_entry() {
587 let report = report(&TABLE);
588 for &(opcode, where_) in ELSEWHERE {
589 assert!(
590 !report.by_rule.contains(&opcode),
591 "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
592 {where_} is stale",
593 opcode.name()
594 );
595 }
596 for &(opcode, why, issue) in GAPS {
597 assert!(
598 !report.by_rule.contains(&opcode),
599 "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
600 and {issue} may be closed",
601 opcode.name()
602 );
603 assert!(
604 !report.elsewhere.contains(&opcode),
605 "`{}` is on both lists, so it is both lowered and not lowered",
606 opcode.name()
607 );
608 }
609 }
610
611 /// The same staleness rule one list down. A name a rule is written at is a name that is not
612 /// left for later, and an entry claiming otherwise is one that should have gone when the rule
613 /// arrived. The other direction is checked too: a name no instruction can ever have is a
614 /// misspelling, and it would sit here excusing nothing.
615 #[test]
616 fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
617 let heads = pattern_heads(&TABLE);
618 let named = term::heads();
619 for &(name, why, issue) in NAMES {
620 assert!(
621 !heads.contains(&name),
622 "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
623 stale and {issue} may be closer than it says"
624 );
625 assert!(
626 named.iter().any(|&(_, head)| head == name),
627 "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
628 nothing"
629 );
630 }
631 let report = report(&TABLE);
632 assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
633 }
634
635 /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
636 /// anything about, which is the thing this module exists to stop.
637 #[test]
638 fn every_gap_names_the_issue_that_closes_it() {
639 let issues = GAPS
640 .iter()
641 .map(|&(_, _, issue)| issue)
642 .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
643 .chain(NAMES.iter().map(|&(_, _, issue)| issue));
644 for issue in issues {
645 let number = issue
646 .strip_prefix("tamnd/rucc#")
647 .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
648 assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
649 }
650 }
651
652 /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
653 /// this test with the output shown, so the number lands in a log next to the rule proof
654 /// rather than in a file somebody has to go and read.
655 #[test]
656 fn the_count_is_reported() {
657 let report = report(&TABLE);
658 println!("{report}");
659 for &(opcode, why, issue) in GAPS {
660 println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
661 }
662 for &(width, why, issue) in WIDTHS {
663 println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
664 }
665 for &(name, why, issue) in NAMES {
666 println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
667 }
668 assert_eq!(report.gaps.len(), GAPS.len());
669 }
670
671 /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
672 /// rule compiler ever built the trie some other way this would say so, rather than the
673 /// coverage numbers quietly becoming a report about an empty list.
674 #[test]
675 fn the_root_of_the_trie_is_the_head_of_every_pattern() {
676 let heads = pattern_heads(&TABLE);
677 assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
678 for rule in TABLE.rules {
679 let head = rule
680 .pattern
681 .strip_prefix('(')
682 .and_then(|rest| rest.split([' ', ')']).next())
683 .expect("a pattern is an application");
684 assert!(
685 heads.contains(&head),
686 "line {}: {} is a pattern whose head the root of the trie does not test",
687 rule.line,
688 rule.pattern
689 );
690 }
691 }
692
693 /// The one target with a rule file, and the two that get one at M6. A machine that can be
694 /// compiled for has rules to report the coverage of, and one that cannot has none rather than
695 /// an empty set of them, which are different answers and would read the same as a number.
696 #[test]
697 fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
698 let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
699 assert_eq!(x86.source, TABLE.source);
700 assert!(!x86.rules.is_empty());
701 assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
702 assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
703 }
704
705 /// What a rule is called outside this process. The index is not it: a rule added at the top of
706 /// the file moves every index below it, and a report from last week would then be a report
707 /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
708 #[test]
709 fn a_rule_is_written_down_as_the_place_it_is_written_at() {
710 let mut fired = Fired::new();
711 fired.mark(0);
712 let listing = fired.listing(&TABLE);
713 let first =
714 format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
715 assert!(listing.contains(&first), "{listing}");
716 assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
717 }
718
719 /// Every rule is listed and not only the ones that fired, which is what lets one of these files
720 /// be read on its own. A reader that only got the rules that fired would have to parse the rule
721 /// file to find out what the rest of them were.
722 #[test]
723 fn one_file_says_what_the_whole_rule_set_is() {
724 let listing = Fired::new().listing(&TABLE);
725 let lines: Vec<&str> = listing.lines().collect();
726 assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
727 assert_eq!(
728 lines.iter().filter(|line| line.starts_with("unused ")).count(),
729 TABLE.rules.len()
730 );
731 assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
732 }
733
734 /// A compilation is many functions and a command line is many files, and the question is about
735 /// all of them at once. Merging is also what keeps the answer the same however the work was
736 /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
737 #[test]
738 fn what_two_runs_reached_is_what_either_of_them_reached() {
739 let mut one = Fired::new();
740 one.mark(3);
741 one.mark(3);
742 assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
743 let mut two = Fired::new();
744 two.mark(0);
745 two.mark(9);
746 one.merge(&two);
747 assert_eq!(one.count(), 3);
748 assert!(one.has(0) && one.has(3) && one.has(9));
749 assert!(!one.has(1));
750
751 // The merge is symmetric, since neither order of two files is the right one.
752 let mut back = Fired::new();
753 back.mark(0);
754 back.mark(9);
755 let mut three = Fired::new();
756 three.mark(3);
757 back.merge(&three);
758 assert_eq!(back, one);
759 }
760}