Skip to main content

rucc_codegen/
pipeline.rs

1//! One IR function to one machine function, which is every pass in this crate in order.
2//!
3//! Design: `spec/10-backend.md` section 10.1, which is where the order comes from.
4//!
5//! Each pass here is written and tested on its own and each is useful on its own, but there is
6//! exactly one order they run in and until now that order lived in the tests. A caller outside
7//! this crate would have had to know that splitting critical edges comes after lowering and
8//! before allocation, that the frame is worked out after allocation because the spill slots are
9//! the largest thing in it, and that the prologue is written after the frame. None of that is a
10//! decision a driver should be making, so it is written down once, here.
11//!
12//! # What comes out
13//!
14//! A function whose every register is physical, whose every offset into the frame is a constant,
15//! and whose blocks are in the order they run in with the jumps that order needs. That is the
16//! point at which a function is one an encoder could read, and there is nothing left in it that
17//! is not an instruction of the machine it was compiled for.
18//!
19//! # What is still missing from the middle
20//!
21//! The optimizing path, all of it. What runs here is `spec/10-backend.md` section 10.3's fast
22//! path: one rule per term, a linear scan, and a block order from the shape of the CFG rather
23//! than from block frequency. No scheduling, and the redundant moves a coalescer would take out
24//! are still in the output.
25
26use rucc_base::Interner;
27use rucc_ir as ir;
28use rucc_mir as mir;
29use rucc_regalloc::assign::Env;
30use rucc_target::{
31    BitInsts, BranchInsts, CallRegs, FlagInsts, FrameInsts, MachineInsts, PhysReg, RegFile,
32    TargetInfo, TimingInsts, x86_64,
33};
34use rucc_tuple::Arch;
35
36use crate::bits;
37use crate::combine;
38use crate::compare;
39use crate::copies;
40use crate::coverage::Fired;
41use crate::elsewhere::Elsewhere;
42use crate::finish::{Convention, Padding, Probing, Protect, Tracing, finish};
43use crate::fold;
44use crate::frame::{self, Frame, Layout};
45use crate::layout;
46use crate::lower::{self, Unsupported};
47use crate::lowering::{self, Lowerings};
48use crate::pressure::{Cost, Pressure};
49use crate::schedule;
50use crate::slots::{self, Slots};
51use crate::split;
52use crate::weights;
53
54/// Everything about a machine that compiling a function for it needs.
55///
56/// The fields are different kinds of fact and they come from different places: where the
57/// convention puts things, what registers the machine has, which instructions build a frame,
58/// which instructions a branch becomes, and which registers the allocator may hand out. The last
59/// one is not a target fact on its own, because holding a register back as scratch is a decision
60/// about the allocator rather than about the machine, which is why it is built here rather than
61/// in [`rucc_target`].
62#[derive(Debug)]
63pub struct Machine {
64    /// Where the convention this function is compiled for puts things.
65    pub conv: &'static CallRegs,
66    /// The registers the machine has, which is what says how wide a spill slot of a class is.
67    pub file: RegFile,
68    /// The instructions that take a frame and give it back.
69    pub insts: &'static FrameInsts,
70    /// The instructions a branch becomes once the blocks are in an order.
71    pub branch: &'static BranchInsts,
72    /// How much of a register each of the machine's instructions reads and writes.
73    pub bits: &'static BitInsts,
74    /// What each of the machine's instructions leaves in the condition state.
75    pub flags: &'static FlagInsts,
76    /// What shape each of the machine's instructions is, which is what a pass proposing a new one
77    /// has its proposal held against.
78    pub shapes: &'static MachineInsts,
79    /// How long each of the machine's instructions takes, and what it takes it on.
80    pub timing: &'static TimingInsts,
81    /// What the allocator may hand out, and what it holds back.
82    pub env: Env,
83}
84
85/// The scratch registers held back from the allocator on x86-64.
86///
87/// Two, because a move on an edge may have to break a cycle and a spilled value has to be read
88/// into something, and those can want a register at the same instruction. Two is also what nearly
89/// every instruction wants, including the one that looks larger: an instruction that reads two
90/// spilled values and writes a third sends the answer back into a register an operand arrived in
91/// rather than asking for one of its own, and `rewrite` says why that is allowed.
92///
93/// It is not two because two was enough to start with and nobody looked again. There is no third
94/// to hold back. A scratch register has to be one the convention passes nothing in, since the
95/// rewriter puts moves in wherever it likes, and one the callee does not owe back, since the
96/// rewriter runs after the prologue has been decided and cannot ask for a register to be saved. On
97/// SysV that is `r10`, `r11` and `rax`, and `rax` is not one to take: it is the return value, so
98/// holding it back costs a move at every return in the program, which is a price paid everywhere
99/// for a shape that turns up almost nowhere.
100///
101/// An instruction that wants a third is the indexed store with its base, its index and its value
102/// all on the stack, which is tamnd/rucc#913. `rewrite` answers that one by borrowing a register
103/// and putting back what was in it, which costs two memory accesses at the instruction that wanted
104/// it and nothing anywhere else.
105const SCRATCH: [PhysReg; 2] = [x86_64::R10, x86_64::R11];
106
107/// How many of each class are held back.
108const SCRATCH_COUNT: usize = SCRATCH.len();
109
110impl Machine {
111    /// The x86-64 machine under that convention.
112    ///
113    /// Both files are offered. A value the selector produces is in one or the other, which is
114    /// decided by its type: an integer and an address are general purpose and a `float` or a
115    /// `double` is in a vector register, and the allocator is given each file separately because
116    /// no move goes between them.
117    #[must_use]
118    pub fn x86_64(conv: &'static CallRegs) -> Self {
119        let order: Vec<PhysReg> =
120            conv.int_order.iter().copied().filter(|reg| !SCRATCH.contains(reg)).collect();
121        // The vector file wants its own two, for the same two jobs, and they have to be two the
122        // convention does not preserve: a scratch register is written by a move the rewriter puts
123        // in, which is after the prologue has already been decided, so one the callee owes back
124        // would be one nothing saved. That rules out the upper ten on Windows and nothing at all
125        // on SysV, and taking the last two that are left lands on `xmm14` and `xmm15` there and on
126        // `xmm4` and `xmm5` on Windows, neither of which any argument travels in.
127        let free: Vec<PhysReg> =
128            conv.sse_order.iter().copied().filter(|&reg| !conv.preserves_sse(reg)).collect();
129        let at = free.len().saturating_sub(SCRATCH_COUNT);
130        let sse_scratch: Vec<PhysReg> = free[at..].to_vec();
131        let sse_order: Vec<PhysReg> =
132            conv.sse_order.iter().copied().filter(|reg| !sse_scratch.contains(reg)).collect();
133        Self {
134            conv,
135            file: x86_64::REGS,
136            insts: &x86_64::FRAME,
137            branch: &x86_64::BRANCH,
138            bits: &x86_64::BITS,
139            flags: &x86_64::FLAGS,
140            shapes: &x86_64::MACHINE,
141            timing: &x86_64::TIMING,
142            env: Env::new().with(x86_64::GPR, &order, &SCRATCH).with(
143                x86_64::XMM,
144                &sse_order,
145                &sse_scratch,
146            ),
147        }
148    }
149
150    /// The machine a target describes, or `None` when no backend in this crate covers it.
151    ///
152    /// [`TargetInfo`] already carries the convention, because the front end needs it to lay a
153    /// `va_list` out, so the only thing this decides is which architecture's frame instructions
154    /// and register file go with it. AArch64 and RISC-V are `None` until M6 fills them in, and a
155    /// caller that gets one reports a target it cannot compile for rather than compiling wrongly.
156    #[must_use]
157    pub fn for_target(target: &TargetInfo) -> Option<Self> {
158        let conv = target.call_regs?;
159        match target.tuple.arch() {
160            Arch::X86_64 => Some(Self::x86_64(conv)),
161            _ => None,
162        }
163    }
164}
165
166/// Whether every function calls a profiler on the way in, and where that call goes.
167///
168/// What `-pg` asks for, with `-mfentry` and `-mno-fentry` choosing between the last two. The choice
169/// has already been made against the target by the time this is built, which is why there is no
170/// answer here for a command line that named neither.
171#[derive(Debug, Clone, Copy, Default, PartialEq, Eq)]
172pub enum Profile {
173    /// It does not, which is what nearly every command line asks for.
174    #[default]
175    No,
176    /// In front of the prologue, which is the hook a tracer can replace while the program runs.
177    Early,
178    /// Once the frame is taken, which is the hook that reads the frame pointer.
179    Late,
180}
181
182/// How much room every function opens with for something to be written over it later.
183///
184/// What `-fpatchable-function-entry=` asks for, as the two halves a prologue deals in rather than
185/// as the total and the part the flag is written in. The room can be on either side of the
186/// function's own label and the two sides are not the same thing: what is after the label is inside
187/// the function, which is what a patcher redirecting a call into it wants, and what is in front of
188/// it is outside, which is where a patcher that needs a whole instruction it can reach from the
189/// first one puts it.
190#[derive(Debug, Clone, Copy, Default, PartialEq, Eq)]
191pub struct Room {
192    /// How many bytes go after the function's own label.
193    pub after: u32,
194    /// How many go in front of it.
195    pub before: u32,
196}
197
198impl Room {
199    /// Whether any room at all was asked for, which is what decides whether a function gets one.
200    ///
201    /// `=0` is a command line that asked for none, and gcc takes it and writes nothing, so the
202    /// question is about the numbers rather than about whether the flag was written.
203    #[must_use]
204    pub const fn any(self) -> bool {
205        self.after > 0 || self.before > 0
206    }
207}
208
209/// What the command line says about a frame, as opposed to what the machine says.
210#[derive(Debug, Clone, Copy, PartialEq, Eq)]
211pub struct Flags {
212    /// Whether every function keeps a frame pointer, which `-fno-omit-frame-pointer` asks for.
213    pub frame_pointer: bool,
214    /// Whether the red zone may be used, which `-mno-red-zone` and every kernel turns off.
215    pub red_zone: bool,
216    /// Whether a frame is taken a page at a time, which `-fstack-clash-protection` asks for.
217    pub stack_clash: bool,
218    /// Whether every address an indirect branch may arrive at opens with a landing pad, which
219    /// `-fcf-protection=branch` asks for. That is every function, and every label of a function
220    /// whose address the program took.
221    pub landing: bool,
222    /// Whether every function calls a profiler on the way in, which `-pg` asks for.
223    pub profile: Profile,
224    /// How much room every function opens with for a patcher, which
225    /// `-fpatchable-function-entry=` asks for. See [`Room`].
226    pub patch: Room,
227    /// Whether the blocks are put in the order the weights say rather than in the order the
228    /// shape of the graph says, which `-freorder-blocks` asks for and every level above `-O0`
229    /// turns on. See [`crate::layout`].
230    pub reorder: bool,
231    /// Whether two things in the frame that are never both wanted may be the same bytes, which
232    /// `-fstack-reuse=none` turns off. See [`crate::slots`].
233    pub reuse: bool,
234    /// Whether the instructions of a block are put in the order the machine finishes soonest,
235    /// which `-fschedule-insns2` asks for and every level from `-O2` turns on. See
236    /// [`crate::schedule`].
237    pub schedule: bool,
238    /// Whether the target's timing model is believed about the machine's units as well as about
239    /// its latencies, which `-Zcycle-accurate-model=` says and the model itself answers otherwise.
240    ///
241    /// `None` is a command line that did not say, which is nearly every one, and then the model's
242    /// own answer decides. It is here rather than only on the model because section 38.1 asks for
243    /// a way to say the model is better or worse than it claims without editing the model, and
244    /// because the measurement section 38.8 owes is the same corpus compiled both ways.
245    pub accurate: Option<bool>,
246}
247
248impl Default for Flags {
249    /// No frame pointer, the red zone allowed, the frame taken in one subtraction, no landing pad,
250    /// no profiling, no room for a patcher, the blocks in the order the graph's shape gives,
251    /// nothing in the frame sharing with anything and no scheduling, which is what a convention
252    /// that has a red zone says at `-O0` when nobody on the command line has said otherwise.
253    fn default() -> Self {
254        Self {
255            frame_pointer: false,
256            red_zone: true,
257            stack_clash: false,
258            landing: false,
259            profile: Profile::No,
260            patch: Room::default(),
261            reorder: false,
262            reuse: false,
263            schedule: false,
264            accurate: None,
265        }
266    }
267}
268
269/// Compiles one function, from the IR the middle end produced to machine instructions.
270///
271/// The function is taken by reference that can be written through, because the first pass is an
272/// IR to IR rewrite: a construct whose lowering is a new shape of control flow cannot be a rule,
273/// since a rule replaces a term with a term and has nowhere to put a block. So the IR that reaches
274/// selection is not quite the IR the middle end produced, and this is the only place that is true.
275/// `--emit=ir` prints before any of this runs.
276///
277/// `elsewhere` is the one thing here that is a fact about the module rather than about the
278/// function, and it is passed in rather than looked up because this only ever sees the one
279/// function. What it decides is how the address of a name is come by, which is the difference
280/// between an address this file can measure to and one only the linker knows.
281///
282/// # Errors
283///
284/// The first thing in it this cannot lower, which is what [`lower::func`] reports, and one thing
285/// after it that is about the shape of the function rather than about an instruction, which is a
286/// frame that grows while it runs in a function whose flags say no frame may. Everything else after
287/// lowering works on machine instructions that exist, so it either runs or it is a bug in this
288/// crate.
289pub fn compile(
290    source: &mut ir::Func,
291    names: &mut Interner,
292    machine: &Machine,
293    elsewhere: &Elsewhere,
294    flags: Flags,
295) -> Result<mir::Func, Unsupported> {
296    let (mut fired, mut pressure, mut lowerings) =
297        (Fired::new(), Pressure::new(), Lowerings::new());
298    compile_recording(
299        source,
300        names,
301        machine,
302        elsewhere,
303        flags,
304        &mut Recording { fired: &mut fired, pressure: &mut pressure, lowerings: &mut lowerings },
305    )
306}
307
308/// Somewhere to put what a compilation did along the way, for the flags that ask.
309///
310/// One of these rather than three parameters, because they are one thing: a caller either wants
311/// the measurements or does not, and a caller that does wants the same three to cover every
312/// function of every file on the command line.
313#[derive(Debug)]
314pub struct Recording<'a> {
315    /// Which lowering rules fired, for `-Zrule-coverage`.
316    pub fired: &'a mut Fired,
317    /// What the allocator had to put on the stack, for `-Zregister-pressure`.
318    pub pressure: &'a mut Pressure,
319    /// What the pre-selection lowering group did, for `-Zlowering`.
320    pub lowerings: &'a mut Lowerings,
321}
322
323/// The same compilation, with what it did along the way recorded.
324///
325/// Two functions rather than one that takes options, because a caller that does not want the
326/// numbers should not have to say so. What each field of the [`Recording`] is for is on the field,
327/// and all of them are added to rather than replaced, so a caller passes the same one for every
328/// function of a module and every module of a command line and gets the answer for all of them.
329///
330/// # Errors
331///
332/// The same as [`compile`]. A function that was refused contributes nothing to any of them, since
333/// a function that did not compile is not evidence about what a rule set or a frame would have
334/// done.
335pub fn compile_recording(
336    source: &mut ir::Func,
337    names: &mut Interner,
338    machine: &Machine,
339    elsewhere: &Elsewhere,
340    flags: Flags,
341    recording: &mut Recording<'_>,
342) -> Result<mir::Func, Unsupported> {
343    // Everything the machine has no rule for, rewritten into things it has, as one group rather
344    // than as a dozen lines here. What is in the group and what the order between its members is
345    // for are both in `crate::lowering`, which is where a new lowering is added.
346    let counting = recording.lowerings.wanted();
347    let ran = lowering::group(source, names, machine.conv, counting);
348    if counting {
349        let called = names.resolve(source.name).to_owned();
350        recording.lowerings.record(&called, ran);
351    }
352    let lowered = lower::func(source, names, machine.conv, elsewhere)?;
353    recording.fired.merge(&lowered.fired);
354    let lower::Lowered { mut func, mut stack, blocks, .. } = lowered;
355    // Straight after selection, because this is the last moment the machine blocks and the IR
356    // blocks still stand one for one, and the pass that reads the numbers is the very last one
357    // there is. See `crate::weights`.
358    if flags.reorder {
359        weights::carry(source, &blocks, &mut func);
360    }
361    // Two things a frame that grows while it runs cannot be asked for at the same time, both of
362    // them refusals rather than wrong code.
363    if let Some(inst) = stack.grown_at {
364        // What `-fstack-clash-protection` buys is that no frame ever steps over a guard page
365        // without touching it, and a frame that grows while it runs steps by however much the
366        // declaration asked for. The prologue's own pages are touched below, and the ones a
367        // variable length array takes are not, so a function with both is refused rather than
368        // compiled to something that keeps the flag's name and not its promise.
369        if flags.stack_clash {
370            return Err(Unsupported::Dynamic { inst, growing: lower::Growing::Probed });
371        }
372        // The lowering refuses a variable length array that asks for more alignment than a call
373        // leaves the stack pointer on. A fixed local asking for it in the same function is the same
374        // refusal arrived at from the other side: the prologue would force the alignment, and
375        // forcing it and moving the stack pointer afterwards are two frames that each want the one
376        // register that still reaches the rest of the frame. See `Growing` in [`crate::frame`].
377        if stack.locals.iter().any(|local| local.align > machine.conv.stack_align) {
378            return Err(Unsupported::Dynamic { inst, growing: lower::Growing::Aligned });
379        }
380    }
381
382    // Before the fold below, which is the order section 37.6 puts the two in. A widening this takes
383    // out is one whose readers are sent to its source, and one of those readers may be an address
384    // computation, so asking which bits are read first means the fold sees the addresses as they
385    // will be rather than as they were.
386    bits::dead(&mut func, machine.bits, machine.shapes, names);
387
388    // After selection, because the address instruction and the one that reads it are both machine
389    // instructions only once selection has written them, and before allocation, because what makes
390    // the pair safe to put together is that a virtual register is written once. The addresses into
391    // the frame and into the caller's argument area go through it like anything else, and the two
392    // lists `finish` reads are rewritten as they do, so an address that ends up inside its reader
393    // is still an address the frame layout knows to write an offset into.
394    let mut pending = fold::Pending {
395        addresses: &mut stack.addresses,
396        arguments: &mut stack.arguments,
397        dynamic: &mut stack.dynamic,
398    };
399    fold::addresses(&mut func, machine.insts, machine.shapes, names, &mut pending);
400
401    // After that fold rather than before it, because what this puts inside an arithmetic
402    // instruction is a load's addressing mode and a load whose address is still a `lea` in front of
403    // it has nothing in its own mode worth carrying. Before allocation for the reason the fold is:
404    // a virtual register is written once, which is the whole of why the value the load produced
405    // cannot have changed between the two instructions this joins.
406    combine::loads(&mut func, machine.shapes, names, &mut pending);
407
408    // Whether this function carries a canary is the front end's answer, because what
409    // `-fstack-protector` asks about is the kind of local a function has and the types are gone by
410    // here. What the machine does about it is this crate's answer, and a target with nowhere to
411    // keep the word a canary is copied from does nothing, which is what the driver refuses a
412    // command line over before any of this runs.
413    let protect = source.attrs.set.contains(ir::AttrSet::STACK_PROTECT);
414    let guard = protect.then_some(machine.conv.guard.as_ref()).flatten();
415    // Nothing at all on a target with no hook to call, which is the same answer the protector gives
416    // on a target with nowhere to keep its word, and the driver refuses the command line over it
417    // before any of this runs.
418    let profile = match machine.conv.trace {
419        Some(_) => flags.profile,
420        None => Profile::No,
421    };
422    let base = stack.layout(Layout::new(machine.conv, machine.file));
423    let layout = Layout {
424        // The later hook reads the frame pointer to find out who called this function, so a
425        // function that calls it is given one whether or not anything else asked. A function that
426        // asked where its own frame is has the same claim on one, and for a plainer reason: the
427        // register is the answer.
428        frame_pointer: flags.frame_pointer || profile == Profile::Late || stack.walks_frames,
429        red_zone: flags.red_zone,
430        protect: guard.is_some(),
431        // A protected function calls the one that does not come back, on the arm where the check
432        // failed, so it is not a leaf however few calls the program wrote in it. That is what
433        // takes the red zone away from it and what makes its frame leave the stack pointer where
434        // a call needs it. The later hook is a call in the same position and costs the same.
435        //
436        // The earlier one is not, and this is the one place the difference shows. It runs before
437        // the prologue has written anything, so the bytes below the stack pointer it uses are ones
438        // this function has not put anything in yet, and a leaf that keeps its locals down there
439        // stays a leaf. gcc leaves it alone too.
440        leaf: base.leaf && guard.is_none() && profile != Profile::Late,
441        ..base
442    };
443
444    // Before allocation as well, and asked here rather than where it is used because what it asks
445    // is whether anything but the branch reads the byte a comparison wrote. A virtual register is
446    // written once and a physical one is not, so after allocation that question no longer has an
447    // answer.
448    let fusable = layout::fusable(&func, machine.branch, names);
449
450    // In front of the splitting below, because what it does is take the values off the edges out of
451    // a computed `goto` and the splitting has no answer for one of those: the block they leave ends
452    // in a jump already, so neither end of the edge is somewhere a move can go.
453    split::indirect(&mut func, machine.branch, machine.insts, names);
454
455    // And after it, because what it puts a pad at is the block an address names and the pass above
456    // is what settles which block that is. The pad the prologue opens with is written much later,
457    // with the rest of the prologue, since the address it answers for is the function's own.
458    //
459    // Nothing at all on a target with nothing that marks an address as one an indirect branch may
460    // arrive at, which is the same answer the stack protector gives on a target with nowhere to
461    // keep its word, and the driver refuses the command line over it before any of this runs.
462    let landing = flags.landing.then_some(machine.insts.landing).flatten();
463    split::pads(&mut func, machine.insts, landing, names);
464
465    // Before allocation, because an edge that carries values into a block arrived at more than
466    // one way, out of a block that leaves more than one way, has nowhere to put the moves those
467    // values turn into, and the allocator asserts rather than guessing.
468    split::critical(&mut func);
469
470    // Before allocation, because how far the address of a local gets is a question about values and
471    // a value is written once only until the allocator's rewrite has been through. What is done
472    // with the answer waits until afterwards, since the liveness it is read against is the
473    // allocator's. See [`crate::slots`].
474    let reach = flags
475        .reuse
476        .then(|| slots::reach(&func, &stack.addresses, stack.locals.len(), machine.insts, names));
477
478    let called = names.resolve(func.name).to_owned();
479    let allocation = rucc_regalloc::run(&mut func, &machine.env, &called);
480    recording.pressure.record(&called, Cost::of(&allocation));
481
482    // After allocation, because the largest area in most frames is the spill slots and nothing
483    // knows how many of those there are until the allocator has finished running out of registers,
484    // and because a spill slot cannot be shared with a local until it is known there is one.
485    let share = reach.map(|reach| {
486        let widths = frame::widths(&layout, &allocation);
487        Slots::share(&func, &reach, &allocation, &stack.locals, &widths)
488    });
489    let layout = Layout { share: share.as_ref(), ..layout };
490    let frame = Frame::of(&func, &allocation, &layout);
491    let scratch = machine.env.scratch(machine.conv.int_class);
492    let protect = guard.map(|guard| Protect {
493        guard,
494        branch: machine.branch,
495        scratch: [scratch[0], scratch[1]],
496    });
497    // A target with no instruction that touches a page without changing it does nothing about the
498    // flag, which is the same answer the protector gives on a target with nowhere to keep its word.
499    // Every target this crate has a back end for has one.
500    let probe = flags
501        .stack_clash
502        .then_some(machine.insts.probe.as_ref())
503        .flatten()
504        .map(|probe| Probing { probe, branch: machine.branch, scratch: [scratch[0], scratch[1]] });
505    let trace = machine.conv.trace.and_then(|trace| match profile {
506        Profile::No => None,
507        Profile::Early => Some(Tracing { name: trace.early, early: true }),
508        Profile::Late => Some(Tracing { name: trace.late, early: false }),
509    });
510    // And once more for the room a patcher was promised, which is a run of the shortest
511    // instruction that does nothing and so needs the target to have one. Nothing is written on a
512    // target that does not, rather than a run of something longer: the flag counts bytes, and a
513    // patcher writing over the room starts at its front and wants every byte in it to be a place
514    // it could have started at.
515    let pad = flags.patch.any().then_some(machine.insts.pad).flatten().map(|name| Padding {
516        name,
517        before: flags.patch.before,
518        after: flags.patch.after,
519    });
520    let convention = Convention {
521        protect,
522        probe,
523        landing,
524        trace,
525        pad,
526        ..Convention::new(machine.conv, machine.insts)
527    };
528    let moves = finish(&mut func, &allocation, &frame, &stack, convention, names);
529
530    // After the moves are written, because a spill and the reload of it are written by different
531    // decisions of the allocator and what stands between the two is settled by the function they
532    // both went into. Before the layout, because the layout is where the instruction sequence
533    // stops being something a pass may edit.
534    copies::clean(&mut func, &moves, machine.shapes, machine.insts, machine.conv, names);
535
536    // After the allocator's moves have been cleaned up, because a schedule chosen around a move
537    // that is about to be taken out is a schedule built around an instruction that is not in the
538    // output. Before the layout, because the layout is the freeze: it writes the jumps the block
539    // order needs and it puts a comparison and the branch that reads it together, and neither
540    // survives an instruction being moved in afterwards. That is section 38.6's placement, and the
541    // reason it is after allocation rather than before is in [`crate::schedule`].
542    if flags.schedule {
543        schedule::insts(
544            &mut func,
545            machine.timing,
546            machine.shapes,
547            machine.flags,
548            names,
549            flags.accurate.unwrap_or(machine.timing.accurate),
550            &fusable,
551        );
552    }
553
554    // Last, because everything before this finds the blocks a function returns from by looking
555    // for the ones that go nowhere, and after this a block that falls through goes nowhere too.
556    layout::blocks(&mut func, machine.branch, names, &fusable, flags.reorder);
557
558    // After the layout rather than before it, which is the whole of what makes it safe. What a
559    // comparison leaves for the instruction behind it to read is not a register and nothing may
560    // come between the two, and the layout is the other pass that writes such a pair. Running
561    // here means there is nothing left that could put an instruction in the middle of one.
562    compare::redundant(&mut func, machine.flags, machine.shapes, names);
563    Ok(func)
564}
565
566#[cfg(test)]
567mod tests {
568    use rucc_ir::{Builder, Flags as IrFlags, Func, Opcode, Restrict, Signature, Type};
569    use rucc_target::x86_64::{REGS, SYSV, WIN64};
570
571    use super::*;
572
573    /// A function of two integers, and the block to fill.
574    fn blank(params: &[Type]) -> (Interner, Func, ir::Block, Vec<ir::Value>) {
575        let mut names = Interner::new();
576        let mut func = Func::new(names.intern("f"), Signature::new());
577        let block = func.create_block();
578        let values = params.iter().map(|&ty| func.append_param(block, ty)).collect();
579        (names, func, block, values)
580    }
581
582    #[test]
583    fn a_function_comes_out_with_no_virtual_register_left_in_it() {
584        let i32 = Type::int(32);
585        let (mut names, mut source, block, args) = blank(&[i32, i32]);
586        let mut build = Builder::new(&mut source, block);
587        let sum = build.binary(Opcode::Add, args[0], args[1], IrFlags::default());
588        build.ret(&[sum]);
589
590        let machine = Machine::x86_64(&SYSV);
591        let out =
592            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
593                .expect("every instruction has a rule");
594
595        // `int f(int a, int b) { return a + b; }` end to end. A leaf that spills nothing needs no
596        // frame at all, so there is no prologue to see. The one move left is the one the machine's
597        // addition needs, since the sum is written into the register the left operand was read
598        // from and the return wants it in `rax`.
599        assert_eq!(
600            mir::print_func(&out, &names, &REGS),
601            "mfunc @f {\n\
602             block0:\n    \
603             $rdi($rdi) = x64.arg_val_32\n    \
604             $rsi($rsi) = x64.arg_val_32\n    \
605             $rdi(reuse 1) = x64.add_rr_32 $rdi, $rsi\n    \
606             $rax = x64.mov_rr_64 $rdi\n    \
607             x64.ret_val_32 $rax($rax)\n    \
608             x64.ret\n\
609             }\n"
610        );
611    }
612
613    /// What `-Zlowering` is built out of, and the reason it is worth a test here rather than only
614    /// in `crate::lowering`: the group has to be the thing this pipeline runs. A lowering added to
615    /// a line of this function instead of to `Step::GROUP` would still work and would still be
616    /// untested, and the record coming back with one entry per member is what catches it.
617    #[test]
618    fn every_member_of_the_lowering_group_is_run_by_the_compilation_and_says_what_it_did() {
619        let i32 = Type::int(32);
620        let (mut names, mut source, block, args) = blank(&[i32]);
621        let mut build = Builder::new(&mut source, block);
622        let swapped = build.unary(Opcode::Bswap, args[0], i32);
623        build.ret(&[swapped]);
624
625        let mut lowerings = Lowerings::asked(true);
626        compile_recording(
627            &mut source,
628            &mut names,
629            &Machine::x86_64(&SYSV),
630            &Elsewhere::default(),
631            Flags::default(),
632            &mut Recording {
633                fired: &mut Fired::new(),
634                pressure: &mut Pressure::new(),
635                lowerings: &mut lowerings,
636            },
637        )
638        .expect("every instruction has a rule");
639
640        assert_eq!(lowerings.functions(), 1);
641        let listing = lowerings.listing();
642        assert!(listing.contains("lowering f\n"), "{listing}");
643        for step in lowering::Step::GROUP {
644            assert!(listing.contains(step.name()), "{} did not run: {listing}", step.name());
645        }
646        // The byte reversal went through the group rather than reaching the selector, which has no
647        // rule for one.
648        assert!(listing.contains("bytes"), "{listing}");
649        assert!(!listing.contains("left 1"), "something the group answers for survived: {listing}");
650    }
651
652    /// What `-Zrule-coverage` is built out of: the rules a compilation fired, recorded as it went.
653    /// The second function adds to the first rather than replacing it, which is what makes one of
654    /// these files the answer for a whole command line rather than for whichever function was last.
655    #[test]
656    fn which_rules_lowered_a_function_is_something_the_compilation_can_be_asked_for() {
657        let i32 = Type::int(32);
658        let (mut names, mut source, block, args) = blank(&[i32, i32]);
659        let mut build = Builder::new(&mut source, block);
660        let sum = build.binary(Opcode::Add, args[0], args[1], IrFlags::default());
661        build.ret(&[sum]);
662
663        let machine = Machine::x86_64(&SYSV);
664        let mut fired = Fired::new();
665        compile_recording(
666            &mut source,
667            &mut names,
668            &machine,
669            &Elsewhere::default(),
670            Flags::default(),
671            &mut Recording {
672                fired: &mut fired,
673                pressure: &mut Pressure::new(),
674                lowerings: &mut Lowerings::asked(true),
675            },
676        )
677        .expect("every instruction has a rule");
678        let one = fired.count();
679        assert!(one > 0, "an add and a return went through the table and nothing was recorded");
680
681        let listing = fired.listing(&crate::select::x86_64::TABLE);
682        assert_eq!(listing.lines().filter(|line| line.starts_with("fired ")).count(), one);
683        assert!(
684            listing.contains(&format!("{one} of ")),
685            "{}",
686            listing.lines().next().unwrap_or("")
687        );
688
689        // The same rules again plus the ones a subtraction needs, into the same record.
690        let (mut names, mut source, block, args) = blank(&[i32, i32]);
691        let mut build = Builder::new(&mut source, block);
692        let difference = build.binary(Opcode::Sub, args[0], args[1], IrFlags::default());
693        build.ret(&[difference]);
694        compile_recording(
695            &mut source,
696            &mut names,
697            &machine,
698            &Elsewhere::default(),
699            Flags::default(),
700            &mut Recording {
701                fired: &mut fired,
702                pressure: &mut Pressure::new(),
703                lowerings: &mut Lowerings::asked(true),
704            },
705        )
706        .expect("every instruction has a rule");
707        assert!(fired.count() > one, "a subtraction is not an addition");
708    }
709
710    #[test]
711    fn a_function_that_calls_takes_a_frame_and_gives_it_back() {
712        let i32 = Type::int(32);
713        let (mut names, mut source, block, args) = blank(&[i32]);
714        let sig = source.add_signature(Signature::new().with_params(&[i32]).with_returns(&[i32]));
715        let callee = names.intern("g");
716        let call = Builder::new(&mut source, block).call(callee, sig, &[args[0]]);
717        let got = source[call].first_result.expect("an integer comes back");
718        let mut build = Builder::new(&mut source, block);
719        let sum = build.binary(Opcode::Add, got, args[0], IrFlags::default());
720        build.ret(&[sum]);
721
722        let machine = Machine::x86_64(&SYSV);
723        let out =
724            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
725                .expect("every instruction has a rule");
726
727        // `int f(int a) { return g(a) + a; }`. Not a leaf, so the stack pointer moves and the
728        // register the value that outlives the call went to is one the prologue saves.
729        let text = mir::print_func(&out, &names, &REGS);
730        assert!(text.contains("x64.push_64 $rbx"), "{text}");
731        assert!(text.contains("$rbx = x64.pop_64"), "{text}");
732        assert!(text.contains("x64.call $rdi($rdi), @g"), "{text}");
733        assert!(!text.contains('%'), "{text}");
734    }
735
736    #[test]
737    fn the_other_convention_is_the_same_function_somewhere_else() {
738        let i32 = Type::int(32);
739        let (mut names, mut source, block, args) = blank(&[i32, i32]);
740        let mut build = Builder::new(&mut source, block);
741        let sum = build.binary(Opcode::Add, args[0], args[1], IrFlags::default());
742        build.ret(&[sum]);
743
744        let machine = Machine::x86_64(&WIN64);
745        let out =
746            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
747                .expect("every instruction has a rule");
748
749        // The arguments arrive in `rcx` and `rdx` here rather than in `rdi` and `rsi`, which is
750        // the whole of what changed, and it changed because the convention was asked.
751        let text = mir::print_func(&out, &names, &REGS);
752        assert!(text.contains("$rcx($rcx) = x64.arg_val_32"), "{text}");
753        assert!(text.contains("$rdx($rdx) = x64.arg_val_32"), "{text}");
754        assert!(!text.contains("$rdi"), "{text}");
755    }
756
757    #[test]
758    fn a_function_with_a_branch_in_it_goes_through_every_pass() {
759        let i32 = Type::int(32);
760        let (mut names, mut source, entry, args) = blank(&[i32, i32]);
761        let then = source.create_block();
762        let join = source.create_block();
763        let got = source.append_param(join, i32);
764        let mut build = Builder::new(&mut source, entry);
765        let cond = build.icmp(rucc_ir::IntPred::Slt, args[0], args[1]);
766        build.br_if(cond, then, &[], join, &[args[1]]);
767        Builder::new(&mut source, then).jump(join, &[args[0]]);
768        Builder::new(&mut source, join).ret(&[got]);
769
770        let machine = Machine::x86_64(&SYSV);
771        let out =
772            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
773                .expect("every instruction has a rule");
774
775        // The else arm is a critical edge carrying a value, so a block that nothing lowered is in
776        // there, which is the pass between lowering and allocation doing its job. Without it the
777        // allocator would have asserted rather than compiled this.
778        assert_eq!(out.block_count(), 4);
779
780        // `int f(int a, int b) { return a < b ? a : b; }` end to end, and the last pass is what
781        // this pins. The branch became a test and one jump, and it is the jump taken when the
782        // condition failed, because the arm the condition is true for is the block laid out next
783        // and a block falls into the block laid out next. The other arm is the empty block the
784        // edge splitting left, which is where the move the edge carries ended up, and it falls
785        // into the join as well. What is left is one jump in the whole function. Both arms write
786        // the join's parameter straight into `rax`, because the return at the bottom insists on
787        // that register and the moves the edges carry are free to name it.
788        let text = mir::print_func(&out, &names, &REGS);
789        assert_eq!(
790            text,
791            "mfunc @f {\n\
792             block0:\n    \
793             $rdi($rdi) = x64.arg_val_32\n    \
794             $rsi($rsi) = x64.arg_val_32\n    \
795             x64.cmp_rr_32 $rdi, $rsi\n    \
796             x64.jcc_ge block2, block1\n\
797             \nblock1:\n    \
798             $rax = x64.mov_rr_64 $rdi\n    \
799             x64.jmp block3\n\
800             \nblock2:\n    \
801             $rax = x64.mov_rr_64 $rsi, block3\n\
802             \nblock3:\n    \
803             x64.ret_val_32 $rax($rax)\n    \
804             x64.ret\n\
805             }\n"
806        );
807    }
808
809    /// A loop that swaps its two values round every time it goes, which is `gcd`, and which is
810    /// the smallest program that caught two ways of losing a value. Both were found by running
811    /// what came out rather than by reading it, and both are pinned here rather than only where
812    /// they were fixed, because what is wrong with either of them is only visible in the whole
813    /// function.
814    #[test]
815    fn a_loop_that_carries_its_values_round_keeps_all_of_them() {
816        let i32 = Type::int(32);
817        let (mut names, mut source, entry, args) = blank(&[i32, i32]);
818        let head = source.create_block();
819        let body = source.create_block();
820        let exit = source.create_block();
821        let left = source.append_param(head, i32);
822        let right = source.append_param(head, i32);
823        Builder::new(&mut source, entry).jump(head, &[args[0], args[1]]);
824        let mut build = Builder::new(&mut source, head);
825        let zero = build.iconst(i32, 0);
826        let more = build.icmp(rucc_ir::IntPred::Ne, right, zero);
827        build.br_if(more, body, &[], exit, &[left]);
828        let mut build = Builder::new(&mut source, body);
829        let rest = build.binary(Opcode::SRem, left, right, IrFlags::default());
830        build.jump(head, &[right, rest]);
831        let result = source.append_param(exit, i32);
832        Builder::new(&mut source, exit).ret(&[result]);
833
834        let machine = Machine::x86_64(&SYSV);
835        let out =
836            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
837                .expect("every instruction has a rule");
838
839        // `int gcd(int a, int b) { while (b) { int t = a % b; a = b; b = t; } return a; }`. Two
840        // things in here were wrong and each of them returned three from a program that gcc
841        // returns forty two from.
842        //
843        // The first is in the entry block. The move the edge into the loop asks for writes `rsi`,
844        // and the second argument has to be taken out of `rsi` before it does. An edit at the end
845        // of a block used to go in front of the last instruction, on the reasoning that the last
846        // instruction is the branch, and the block's jump is not an instruction until the layout
847        // has run, so it went in front of the `arg_val` whose own move had not been made yet.
848        //
849        // The second is in the loop body. A division writes both a quotient and a remainder, and
850        // only the remainder is wanted here, so the quotient is a value nothing reads. It used to
851        // be given the same register as the remainder, because a value written early was live at
852        // one point and that point is in front of where the remainder is written. The copy that
853        // takes the quotient nowhere then landed on top of the remainder.
854        assert_eq!(
855            mir::print_func(&out, &names, &REGS),
856            "mfunc @f {\n\
857             block0:\n    \
858             $rdi($rdi) = x64.arg_val_32\n    \
859             $rsi($rsi) = x64.arg_val_32\n    \
860             $rcx = x64.mov_rr_64 $rdi, block1\n\
861             \nblock1:\n    \
862             x64.cmp_ri_32 $rsi, 0\n    \
863             x64.jcc_e block3, block2\n\
864             \nblock2:\n    \
865             $rax = x64.mov_rr_64 $rcx\n    \
866             $rdx($rdx), early $rax($rax) = x64.idiv_rem_32 $rax($rax), $rsi\n    \
867             $rdi = x64.mov_rr_64 $rax\n    \
868             $rcx = x64.mov_rr_64 $rsi\n    \
869             $rsi = x64.mov_rr_64 $rdx\n    \
870             x64.jmp block1\n\
871             \nblock3:\n    \
872             $rax = x64.mov_rr_64 $rcx\n    \
873             x64.ret_val_32 $rax($rax)\n    \
874             x64.ret\n\
875             }\n"
876        );
877    }
878
879    /// `spec/10-backend.md` section 10.1 says `--emit=mir-final` round-trips, and a function with
880    /// a branch in it is the one where that is worth checking: after the layout has run, where a
881    /// jump goes is nowhere in the instruction, so the text has to carry it on the block and the
882    /// parser has to put it back on the block it came off.
883    #[test]
884    fn a_function_that_has_been_laid_out_reads_back_as_the_same_function() {
885        let i32 = Type::int(32);
886        let (mut names, mut source, entry, args) = blank(&[i32, i32]);
887        let then = source.create_block();
888        let join = source.create_block();
889        let got = source.append_param(join, i32);
890        let mut build = Builder::new(&mut source, entry);
891        let cond = build.icmp(rucc_ir::IntPred::Slt, args[0], args[1]);
892        build.br_if(cond, then, &[], join, &[args[1]]);
893        Builder::new(&mut source, then).jump(join, &[args[0]]);
894        Builder::new(&mut source, join).ret(&[got]);
895
896        let machine = Machine::x86_64(&SYSV);
897        let out =
898            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
899                .expect("every instruction has a rule");
900
901        let text = mir::print_func(&out, &names, &REGS);
902        let read = rucc_mir::parse(&text, &mut names, &REGS).expect("what the printer wrote");
903        assert_eq!(mir::print(&read, &names, &REGS), text);
904    }
905
906    #[test]
907    fn a_function_this_cannot_lower_is_reported_rather_than_compiled() {
908        let f80 = Type::float(rucc_ir::Float::F80);
909        let (mut names, mut source, block, args) = blank(&[f80, Type::int(64)]);
910        Builder::new(&mut source, block).ret(&args);
911
912        // One of these comes back on the x87 stack and a pair comes back in a pair of registers,
913        // and there is no pair with that stack in it. So this is refused rather than lowered, and
914        // it is the convention that refuses it rather than anything about the instructions.
915        let machine = Machine::x86_64(&SYSV);
916        let failed =
917            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
918                .expect_err("a long double cannot come back beside another value");
919        assert_eq!(failed.to_string(), "what this function gives back is on the x87 stack");
920    }
921
922    /// A `long double` in and a `long double` out, which is the whole of what the convention says
923    /// about the type and is two different answers rather than one.
924    ///
925    /// It arrives in the caller's argument area, so what the parameter is is the address of the
926    /// bytes and the function reads them where they are. It goes back on the x87 stack, so the
927    /// return is an `fld` and nothing else, and the value is still on that stack when the function
928    /// returns, which is the one time anything here leaves it that way.
929    ///
930    /// The addresses are gone from the instruction listing, which is [`crate::fold`]: an argument's
931    /// address is a `lea` off the stack pointer and the `fld` that reads it has room for that
932    /// address itself, so the offset the frame layout works out is written into the `fld`.
933    #[test]
934    fn a_long_double_arrives_in_memory_and_goes_back_on_the_x87_stack() {
935        let f80 = Type::float(rucc_ir::Float::F80);
936        let (mut names, mut source, block, args) = blank(&[f80, f80]);
937        let mut build = Builder::new(&mut source, block);
938        let sum = build.binary(Opcode::FAdd, args[0], args[1], IrFlags::default());
939        build.ret(&[sum]);
940
941        let machine = Machine::x86_64(&SYSV);
942        let out =
943            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
944                .expect("every instruction has a rule");
945
946        let text = mir::print_func(&out, &names, &REGS);
947        // The two parameters, sixteen bytes apart, read out of the caller's frame rather than out
948        // of a register, and the answer left on the stack by the last instruction in the function.
949        assert!(text.contains("x64.fld_t [$rsp + 32]"), "{text}");
950        assert!(text.contains("x64.fld_t [$rsp + 48]"), "{text}");
951        assert!(!text.contains("x64.lea_64"), "an address every reader took is gone: {text}");
952        assert!(!text.contains("x64.ret_val"), "nothing comes back in a register: {text}");
953        // What comes after the `fld` is the epilogue, which gives the frame back and touches
954        // nothing in the unit, so the value is where the caller looks for it when the `ret` runs.
955        let end: Vec<&str> = text.lines().rev().skip(1).take(3).map(str::trim).collect();
956        assert_eq!(end, ["x64.ret", "$rsp = x64.add_ri_64 $rsp, 24", "x64.fld_t [$rsp]"], "{text}");
957    }
958
959    /// The whole of the second register class, end to end: two floats arrive in vector registers,
960    /// the arithmetic happens in one, and the answer goes back in the register the convention
961    /// names. Nothing here touches the general purpose file, which is the point.
962    #[test]
963    fn a_float_is_added_in_the_register_file_it_arrives_in() {
964        let f32 = Type::float(rucc_ir::Float::F32);
965        let (mut names, mut source, block, args) = blank(&[f32, f32]);
966        let mut build = Builder::new(&mut source, block);
967        let sum = build.binary(Opcode::FAdd, args[0], args[1], ir::Flags::default());
968        build.ret(&[sum]);
969
970        let machine = Machine::x86_64(&SYSV);
971        let out =
972            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
973                .expect("every instruction has a rule");
974
975        let text = mir::print_func(&out, &names, &REGS);
976        assert!(text.contains("x64.addss_rr"), "{text}");
977        assert!(text.contains("$xmm0"), "{text}");
978        assert!(!text.contains("$rax"), "{text}");
979    }
980
981    /// A float moved between a register and memory, which is the instruction that decides which
982    /// file the value is in and is a different one from the `mov` that moves the same four bytes.
983    #[test]
984    fn a_float_read_from_memory_and_written_back_uses_the_scalar_moves() {
985        let f64 = Type::float(rucc_ir::Float::F64);
986        let (mut names, mut source, block, args) = blank(&[Type::PTR, f64]);
987        let mut build = Builder::new(&mut source, block);
988        let info = rucc_ir::MemInfo {
989            size: 8,
990            align: 8,
991            order: rucc_ir::MemOrder::NotAtomic,
992            tbaa: None,
993            owns: 0,
994            restrict: Restrict::NONE,
995        };
996        let read = build.load(f64, args[0], info, ir::Flags::default());
997        let sum = build.binary(Opcode::FAdd, read, args[1], ir::Flags::default());
998        build.store(sum, args[0], info, ir::Flags::default());
999        build.ret(&[sum]);
1000
1001        let machine = Machine::x86_64(&SYSV);
1002        let out =
1003            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1004                .expect("every instruction has a rule");
1005
1006        let text = mir::print_func(&out, &names, &REGS);
1007        assert!(text.contains("x64.movsd_rm"), "{text}");
1008        assert!(text.contains("x64.movsd_mr"), "{text}");
1009        // Not the aligned whole register move, which is what a spill uses and is the one
1010        // instruction here that would read and write more than the program asked for.
1011        assert!(!text.contains("x64.movaps_rm"), "{text}");
1012        assert!(!text.contains("x64.movaps_mr"), "{text}");
1013    }
1014
1015    /// The same journey at the format the machine only moves, which is the whole of what it can do
1016    /// with one: in from memory, back out to memory, in and out of a register, and back to the
1017    /// caller.
1018    ///
1019    /// No arithmetic, because there is no instruction for any and every one of them is a call to
1020    /// the runtime. What this says is that the value gets where a call would need it to be.
1021    #[test]
1022    fn a_quad_float_read_from_memory_and_written_back_uses_the_whole_register_move() {
1023        let quad = Type::float(rucc_ir::Float::F128);
1024        let (mut names, mut source, block, args) = blank(&[Type::PTR, quad]);
1025        let mut build = Builder::new(&mut source, block);
1026        let info = rucc_ir::MemInfo {
1027            size: 16,
1028            align: 16,
1029            order: rucc_ir::MemOrder::NotAtomic,
1030            tbaa: None,
1031            owns: 0,
1032            restrict: Restrict::NONE,
1033        };
1034        let read = build.load(quad, args[0], info, ir::Flags::default());
1035        build.store(args[1], args[0], info, ir::Flags::default());
1036        build.ret(&[read]);
1037
1038        let machine = Machine::x86_64(&SYSV);
1039        let out =
1040            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1041                .expect("every instruction has a rule");
1042
1043        let text = mir::print_func(&out, &names, &REGS);
1044        assert!(text.contains("x64.movaps_rm"), "{text}");
1045        assert!(text.contains("x64.movaps_mr"), "{text}");
1046        assert!(text.contains("x64.arg_val_f128"), "{text}");
1047        assert!(text.contains("x64.ret_val_f128"), "{text}");
1048        // In the vector file and not the general purpose one, which is where the two eightbytes
1049        // of this value would have gone if it had been classified as a pair of integers.
1050        assert!(text.contains("$xmm0"), "{text}");
1051        assert!(!text.contains("gpr($rax)"), "{text}");
1052    }
1053
1054    /// Both conversions between an unsigned word and a `long double`, all the way to instructions.
1055    ///
1056    /// What the rewrite writes and what the x87 group in [`crate::lower`] has are two lists put
1057    /// together in two different files, and this is where they meet. The rewrite is free to write
1058    /// any instruction it likes at any width, and at this width almost none of them can be
1059    /// lowered, so a correction written the way the narrower ones are written would pass its own
1060    /// tests next door and fail here.
1061    #[test]
1062    fn an_unsigned_word_and_a_long_double_convert_into_each_other() {
1063        let f80 = Type::float(rucc_ir::Float::F80);
1064        let (mut names, mut source, block, args) = blank(&[Type::PTR, Type::int(64)]);
1065        let mut build = Builder::new(&mut source, block);
1066        let info = rucc_ir::MemInfo {
1067            size: 16,
1068            align: 16,
1069            order: rucc_ir::MemOrder::NotAtomic,
1070            tbaa: None,
1071            owns: 0,
1072            restrict: Restrict::NONE,
1073        };
1074        let wide = build.unary(Opcode::UIToFP, args[1], f80);
1075        build.store(wide, args[0], info, ir::Flags::default());
1076        let read = build.load(f80, args[0], info, ir::Flags::default());
1077        let back = build.unary(Opcode::FPToUI, read, Type::int(64));
1078        build.ret(&[back]);
1079
1080        let machine = Machine::x86_64(&SYSV);
1081        let out =
1082            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1083                .expect("every instruction has a rule");
1084
1085        let text = mir::print_func(&out, &names, &REGS);
1086        // The signed conversions in both directions, the constants that correct them, and the
1087        // multiply that takes a correction or leaves it. Nothing here reaches a wide register.
1088        assert!(text.contains("x64.fild_ll"), "the integer goes in as a signed one: {text}");
1089        assert!(text.contains("x64.fistp_ll"), "and comes back out as one: {text}");
1090        assert!(text.contains("x64.fmul_p"), "the correction is taken or not: {text}");
1091        assert!(text.contains("x64.fadd_p"), "and applied one way: {text}");
1092        assert!(text.contains("x64.fsubr_p"), "and the other: {text}");
1093        assert!(!text.contains("xmm"), "no part of this is in a vector register: {text}");
1094    }
1095
1096    /// A value carried from one register file to the other, which is what a conversion is. The
1097    /// instruction reads one file and writes the other, and the allocator has to know that: a
1098    /// conversion whose operands were both said to be in one file would put the answer in a
1099    /// register the next instruction cannot reach.
1100    #[test]
1101    fn a_conversion_carries_the_value_into_the_other_register_file() {
1102        let f64 = Type::float(rucc_ir::Float::F64);
1103        let (mut names, mut source, block, args) = blank(&[f64]);
1104        let mut build = Builder::new(&mut source, block);
1105        let whole = build.unary(Opcode::FPToSI, args[0], Type::int(32));
1106        let back = build.unary(Opcode::SIToFP, whole, f64);
1107        build.ret(&[back]);
1108
1109        let machine = Machine::x86_64(&SYSV);
1110        let out =
1111            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1112                .expect("every instruction has a rule");
1113
1114        // The conversion that cuts towards zero rather than the one that rounds, which is what C
1115        // means by the cast, and the argument and the answer in the register the convention names.
1116        let text = mir::print_func(&out, &names, &REGS);
1117        assert!(text.contains("x64.cvttsd2si_32"), "{text}");
1118        assert!(text.contains("x64.cvtsi2sd_32"), "{text}");
1119        assert!(text.contains("$xmm0"), "{text}");
1120    }
1121
1122    /// The other way of putting a float and a number together, which keeps every bit rather than
1123    /// the value and is what a program reading the bits of a `double` asks for.
1124    #[test]
1125    fn a_bitcast_between_the_files_is_the_move_that_changes_no_bit() {
1126        let f64 = Type::float(rucc_ir::Float::F64);
1127        let (mut names, mut source, block, args) = blank(&[f64]);
1128        let mut build = Builder::new(&mut source, block);
1129        let bits = build.unary(Opcode::Bitcast, args[0], Type::int(64));
1130        build.ret(&[bits]);
1131
1132        let machine = Machine::x86_64(&SYSV);
1133        let out =
1134            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1135                .expect("every instruction has a rule");
1136
1137        let text = mir::print_func(&out, &names, &REGS);
1138        assert!(text.contains("x64.movq_from_xmm"), "{text}");
1139        assert!(!text.contains("cvt"), "{text}");
1140    }
1141
1142    /// A comparison whose answer the machine has a condition for, which is most of them.
1143    #[test]
1144    fn a_float_comparison_is_the_compare_and_the_byte_a_condition_sets() {
1145        let f64 = Type::float(rucc_ir::Float::F64);
1146        let (mut names, mut source, block, args) = blank(&[f64, f64]);
1147        let mut build = Builder::new(&mut source, block);
1148        let less = build.fcmp(rucc_ir::FloatPred::Olt, args[0], args[1], ir::Flags::default());
1149        let wide = build.unary(Opcode::ZExt, less, Type::int(32));
1150        build.ret(&[wide]);
1151
1152        let machine = Machine::x86_64(&SYSV);
1153        let out =
1154            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1155                .expect("every instruction has a rule");
1156
1157        // Less than is greater than with the operands the other way round, and the machine has no
1158        // condition for the first, so the rule that fires is the one that swaps them.
1159        let text = mir::print_func(&out, &names, &REGS);
1160        assert!(text.contains("x64.ucomisd_set_a"), "{text}");
1161    }
1162
1163    /// The two comparisons that are not one condition. An ordered equality is the flag that means
1164    /// equal or unordered and the flag that says it was ordered, so the instruction writes a
1165    /// second byte and reads it back, and what this is about is that the second byte gets a
1166    /// register of its own rather than the one the answer is in.
1167    #[test]
1168    fn an_equality_between_floats_gets_a_register_for_the_byte_it_needs_twice() {
1169        let f64 = Type::float(rucc_ir::Float::F64);
1170        let (mut names, mut source, block, args) = blank(&[f64, f64]);
1171        let mut build = Builder::new(&mut source, block);
1172        let same = build.fcmp(rucc_ir::FloatPred::Oeq, args[0], args[1], ir::Flags::default());
1173        let wide = build.unary(Opcode::ZExt, same, Type::int(32));
1174        build.ret(&[wide]);
1175
1176        let machine = Machine::x86_64(&SYSV);
1177        let out =
1178            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1179                .expect("every instruction has a rule");
1180
1181        let text = mir::print_func(&out, &names, &REGS);
1182        let line = text
1183            .lines()
1184            .find(|line| line.contains("x64.ucomisd_set_e_and_np"))
1185            .expect("the rule for an ordered equality fired");
1186        let written: Vec<&str> = line
1187            .split_once('=')
1188            .expect("the instruction writes something")
1189            .0
1190            .split(',')
1191            .map(str::trim)
1192            .collect();
1193        assert_eq!(written.len(), 2, "{line}");
1194        assert_ne!(written[0], written[1], "{line}");
1195    }
1196
1197    /// A float literal, which is the last float thing a C program writes that had no lowering.
1198    /// The rewrite that puts it in reach is in `expand`, and what this is about is that the two
1199    /// halves meet: the constant is spelled in a general purpose register and moved across.
1200    #[test]
1201    fn a_float_constant_is_the_bits_in_a_register_and_the_move_that_carries_them_over() {
1202        let f64 = Type::float(rucc_ir::Float::F64);
1203        let (mut names, mut source, block, _) = blank(&[]);
1204        let mut build = Builder::new(&mut source, block);
1205        let half = build.fconst(f64, 0x3fe0_0000_0000_0000);
1206        build.ret(&[half]);
1207
1208        let machine = Machine::x86_64(&SYSV);
1209        let out =
1210            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1211                .expect("every instruction has a rule");
1212
1213        let text = mir::print_func(&out, &names, &REGS);
1214        assert!(text.contains("x64.mov_ri_64"), "{text}");
1215        assert!(text.contains("x64.movq_to_xmm"), "{text}");
1216    }
1217
1218    /// A negation, which is the sign bit flipped and nothing else touched, so what the machine
1219    /// does is an exclusive or in a general purpose register rather than any float instruction.
1220    #[test]
1221    fn a_negation_is_the_sign_bit_flipped_and_no_float_instruction_at_all() {
1222        let f64 = Type::float(rucc_ir::Float::F64);
1223        let (mut names, mut source, block, args) = blank(&[f64]);
1224        let mut build = Builder::new(&mut source, block);
1225        let less = build.unary(Opcode::FNeg, args[0], f64);
1226        build.ret(&[less]);
1227
1228        let machine = Machine::x86_64(&SYSV);
1229        let out =
1230            compile(&mut source, &mut names, &machine, &Elsewhere::default(), Flags::default())
1231                .expect("every instruction has a rule");
1232
1233        let text = mir::print_func(&out, &names, &REGS);
1234        assert!(text.contains("x64.xor_rr_64"), "{text}");
1235        assert!(!text.contains("sub"), "a negation is not a subtraction: {text}");
1236    }
1237
1238    #[test]
1239    fn the_flags_reach_the_frame() {
1240        let i32 = Type::int(32);
1241        let (mut names, mut source, block, args) = blank(&[i32]);
1242        Builder::new(&mut source, block).ret(&[args[0]]);
1243
1244        let machine = Machine::x86_64(&SYSV);
1245        let flags = Flags { frame_pointer: true, profile: Profile::No, ..Flags::default() };
1246        let out = compile(&mut source, &mut names, &machine, &Elsewhere::default(), flags)
1247            .expect("every instruction has a rule");
1248
1249        // A function that keeps a frame pointer keeps it whether it needed one or not, which is
1250        // what `-fno-omit-frame-pointer` is for and is the only thing this test is about.
1251        let text = mir::print_func(&out, &names, &REGS);
1252        assert!(text.contains("x64.push_64 $rbp"), "{text}");
1253        assert!(text.contains("$rbp = x64.mov_rr_64 $rsp"), "{text}");
1254    }
1255
1256    #[test]
1257    fn a_target_says_which_machine_it_is_and_which_convention_it_uses() {
1258        let triple = |text: &str| text.parse::<rucc_target::Triple>().expect("a triple");
1259        let info = TargetInfo::new(triple("x86_64-unknown-linux-gnu"));
1260        let machine = Machine::for_target(&info).expect("x86-64 is the target this crate covers");
1261        assert!(std::ptr::eq(machine.conv, &SYSV));
1262
1263        let info = TargetInfo::new(triple("x86_64-pc-windows-msvc"));
1264        let machine = Machine::for_target(&info).expect("x86-64 is the target this crate covers");
1265        assert!(std::ptr::eq(machine.conv, &WIN64));
1266
1267        // Not a target this crate has a backend for, and saying so is the whole point: a caller
1268        // that got a machine here would compile x86-64 instructions for an AArch64 program.
1269        let info = TargetInfo::new(triple("aarch64-unknown-linux-gnu"));
1270        assert!(Machine::for_target(&info).is_none());
1271    }
1272}