rucc_codegen/coverage.rs
1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72 // The convention. What a call's operands are is whatever the signature made them, and which
73 // register each one arrives in depends on the classification of every argument before it.
74 (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75 (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76 // The frame, which is not known until the allocator has finished running out of registers.
77 (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78 // The stack pointer, which is not a value the program computed and so is not a value a rule
79 // could bind. A scope holding a variable length array reads it as it opens and writes it back
80 // as it closes, which is how the bytes are given back.
81 (Opcode::StackSave, "`crate::lower`, as a move out of the stack pointer"),
82 (Opcode::StackRestore, "`crate::lower`, the same move the other way round"),
83 // A relocation, which is right because of what the linker does rather than because of what
84 // any bitvector equals.
85 (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
86 // The same instruction against a place in this function rather than a name outside it. What
87 // it addresses is a block, and a block is not a value a pattern can bind.
88 (Opcode::BlockAddr, "`crate::lower`, the same `lea` against a label of this function"),
89 // The one thing on this machine that no ordinary instruction can work out, which is why it
90 // is built here rather than matched: `%fs` is not a register a rule could name.
91 (Opcode::ThreadPointer, "`crate::lower`, as the load through `%fs` at zero that reads it"),
92 // A hint, which is built here for a reason of the same shape and one step stronger: which of
93 // the four instructions it is comes out of a number in the builtin's arguments, and a pattern
94 // matches on an opcode and a type and could not see it.
95 (Opcode::Prefetch, "`crate::lower`, as one of the four `prefetch` instructions"),
96 // Stopping, which is built here because it computes nothing for a rule to have a pattern for
97 // and because what makes it right is the operating system rather than any bitvector.
98 (Opcode::Trap, "`crate::lower`, as the `ud2` the program stops on"),
99 // No instruction at all. The IR keeps the width the same and the machine has one register
100 // file for both, so the value is already where it needs to be.
101 (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
102 (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
103 // Memory SSA, which is built at -O2, read by the passes that need it, and taken back off
104 // before selection. Nothing in the back end has ever seen a value of type `mem`.
105 (Opcode::MemEntry, "nothing at all, since memory SSA comes off before the back end runs"),
106 // The edges and the two ways of writing down that control does not arrive.
107 (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
108 // The one terminator selection does write, because what it reads is a value. How many arms it
109 // has is not fixed, and a rule says what an instruction reads rather than where a block goes.
110 (Opcode::IndirectBr, "`crate::lower`, as the jump through the register that holds the address"),
111 (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
112 (Opcode::UnreachableHint, "nothing at all, for the same reason"),
113 // Rewritten into the opcodes above before selection ever sees them.
114 (Opcode::Switch, "`crate::switch`, into the tests its clusters need"),
115 (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
116 (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
117 (Opcode::UIToFP, "`crate::expand`, into a signed conversion with a widening or a halving"),
118 (Opcode::FPToUI, "`crate::expand`, into a signed conversion with a narrowing or a correction"),
119 (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
120 (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
121 (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
122 (Opcode::Bswap, "`crate::expand`, into the shifts and masks that reverse the bytes"),
123 // The ordered accesses, which this machine already makes ordered. `crate::expand` says what
124 // total store order gives for nothing and what the one ordering it does not give costs.
125 (Opcode::AtomicLoad, "`crate::expand`, into the plain load that is already an acquire"),
126 (Opcode::AtomicStore, "`crate::expand`, into the plain store, and a barrier at the strongest"),
127 // The barrier itself, which is one instruction or none and neither is a rewrite of anything.
128 // The template, which is a string and not a term. A rule set cannot be written over a string,
129 // so the instructions a template names are looked up in the machine description rather than
130 // matched, which is `rucc_target::x86_64::read`.
131 (
132 Opcode::InlineAsm,
133 "`crate::lower`, as the places its operands share and the instructions its template names",
134 ),
135 (
136 Opcode::Fence,
137 "`crate::lower`, as an `mfence` at the strongest ordering and nothing below it",
138 ),
139 // The compare and exchange, which is one instruction and produces two values, and a rule
140 // replaces a term with an instruction producing one.
141 (
142 Opcode::Cmpxchg,
143 "`crate::lower`, as a locked compare and exchange and the byte that reads its answer",
144 ),
145 // The read modify write, which produces one value a rule could have named and whose operation
146 // is carried beside it rather than in the head a rule matches on, so one pattern would be all
147 // thirteen of them.
148 (
149 Opcode::AtomicRmw,
150 "`crate::lower`, as an exchange or a locked add, and `crate::retry` for the eight with no \
151 instruction, with the two on floating values refused",
152 ),
153 (Opcode::Ctpop, "`crate::expand`, into the halving sum that counts the set bits"),
154 (Opcode::Ctlz, "`crate::expand`, into a smear and a set bit count"),
155 (Opcode::Cttz, "`crate::expand`, into a mask of the low zeroes and a set bit count"),
156 (Opcode::UAddOverflow, "`crate::expand`, into an add and a comparison against an operand"),
157 (Opcode::SAddOverflow, "`crate::expand`, into an add and the sign bit of the operands"),
158 (Opcode::USubOverflow, "`crate::expand`, into a subtract and a comparison of the operands"),
159 (Opcode::SSubOverflow, "`crate::expand`, into a subtract and the sign bit of the operands"),
160 (Opcode::UMulOverflow, "`crate::expand`, into a multiply and the high half of the product"),
161 (Opcode::SMulOverflow, "`crate::expand`, into the same, with the high half corrected for sign"),
162 // The variable argument list, which is four opcodes reading a structure the ABI describes.
163 (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
164 (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
165 (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
166 (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
167 (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
168 // Memory safety. A check is a call to the runtime, and the rewrite happens after the optimizer
169 // has run so that the descriptor table only has rows for checks that survived it.
170 (Opcode::CheckBounds, "`rucc_safety::lower`, into a call carrying the row that describes it"),
171 (Opcode::CheckLive, "`rucc_safety::lower`, the same call over the lifetime plane"),
172 (Opcode::CheckDeriv, "`rucc_safety::lower`, the same call where the pointer is computed"),
173 (Opcode::CheckType, "`rucc_safety::lower`, the same call, carrying the type asked about"),
174 (
175 Opcode::CheckInit,
176 "`rucc_safety::lower`, the same call over the init plane, carrying no type",
177 ),
178 (Opcode::CheckRace, "`rucc_safety::lower`, the same call over the epoch plane"),
179 // The five plane writes the same pass emits, which become calls the same way. A judgement
180 // decides nothing, so none of the calls carries a descriptor row, and neither do the two
181 // edges below them.
182 (Opcode::MetaType, "`rucc_safety::lower`, into the call that records what a store stored"),
183 (Opcode::MetaTypeCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
184 (Opcode::MetaInit, "`rucc_safety::lower`, into the call that says a store wrote a range"),
185 (Opcode::MetaInitCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
186 (Opcode::MetaEpoch, "`rucc_safety::lower`, into the call that says which thread stored"),
187 // The two halves of a synchronization edge, which are the same shape of call and are not a
188 // plane write at all: what they move is a thread's own clock, which lives beside the thread.
189 (
190 Opcode::MetaRelease,
191 "`rucc_safety::lower`, into the call that publishes this thread's clock at an atomic",
192 ),
193 (Opcode::MetaAcquire, "`rucc_safety::lower`, into the call that takes the other end of it"),
194 // The same pair for a fence, which are the same calls with no key, since a fence orders
195 // against every thread rather than against an object.
196 (
197 Opcode::MetaFenceRelease,
198 "`rucc_safety::lower`, into the call that publishes this thread's clock to everyone",
199 ),
200 (
201 Opcode::MetaFenceAcquire,
202 "`rucc_safety::lower`, into the call that takes what any release fence published",
203 ),
204 // The `restrict` contract, which is judgement J8 and is the one check that records as well as
205 // asks. What it records goes in a slot the block owns, and the two markers are what open and
206 // close that slot, so all four are calls to the runtime the same way.
207 (
208 Opcode::CheckRestrictRead,
209 "`rucc_safety::lower`, into the call that asks what the block has already reached",
210 ),
211 (Opcode::CheckRestrictWrite, "`rucc_safety::lower`, the same call, saying it wrote"),
212 (Opcode::RestrictEnter, "`rucc_safety::lower`, into the call that opens the block's record"),
213 (Opcode::RestrictLeave, "`rucc_safety::lower`, into the call that closes it again"),
214 (Opcode::CapExtent, "`rucc_safety::lower`, into a call that asks rather than one that judges"),
215 (Opcode::CapExtentBack, "`rucc_safety::lower`, the same call about the bytes below an address"),
216 // The capability the checks were reading, which the same pass takes out once they are calls,
217 // because a call to the runtime is handed an address and finds the rest for itself. One that
218 // something does read is a slot, and the only one of those the pass can fill so far is a
219 // capability for a pointer an allocator just returned, which is a load out of that instance's
220 // own header rather than anything worked out from the address.
221 (Opcode::CapOf, "`rucc_safety::slot`, into a call for a fresh allocation and gone otherwise"),
222 // The two ends of a capability that something does read. A capability is four words of frame
223 // and the value that stands for one is the slot's address, so the pair below is an `alloca`
224 // with four zero words written into it and a call handed the addresses of two slots.
225 (Opcode::CapNull, "`rucc_safety::slot`, into a frame slot with the bottom capability in it"),
226 (Opcode::CapStore, "`rucc_safety::slot`, into the call that writes one into the aux plane"),
227 // The other end of that write, which is the one capability nothing has to work out, because the
228 // store that put it beside the pointer already did. So this is a call too, and it is the only
229 // instruction the pass rewrites that reads a slot and fills one.
230 (Opcode::CapLoad, "`rucc_safety::slot`, into the call that reads one back out again"),
231 // The sub-object tier's whole mechanism, which is arithmetic on the range a capability holds
232 // and is a call for the same reason the rest are: where the four words sit is the runtime's to
233 // know, and a second place that agreed about it would be a second place that could stop.
234 (Opcode::CapNarrow, "`rucc_safety::slot`, into the call that moves the range in"),
235 // The expensive producer and the only one that always has an answer, which is why it is what a
236 // pointer from outside the instrumented world falls back to. Same two arguments as the fresh
237 // allocation above, since the runtime declares the pair as one shape.
238 (Opcode::CapRecover, "`rucc_safety::slot`, into the call that walks the planes for one"),
239 // The two ends of a call, which is where a capability stops being this function's business.
240 // Neither of them is a capability instruction in the sense the five above are: one copies a
241 // call's worth of them into a frame in thread local storage and publishes it, and the other
242 // says there is no frame at all, which is what a callee nobody can vouch for gets.
243 (Opcode::CapPublish, "`rucc_safety::frame`, into the frame a call hands its callee"),
244 (Opcode::CapClear, "`rucc_safety::frame`, into the call that says there is no frame"),
245 // And the reading end of the first of those two, which is the one of the three that does make a
246 // capability. It is in the callee rather than in the caller and it answers whether or not there
247 // was a frame, because a pointer nobody described is one to be recovered from the planes.
248 (Opcode::CapArg, "`rucc_safety::frame`, into the read of the frame the caller published"),
249 // What `__builtin_expect` said, which the pass writes onto the arms of the branch it was said
250 // about before taking the instruction out, so that a hint and a profile are the same thing to
251 // everything downstream of the optimizer.
252 (Opcode::Expect, "`rucc_opt::expect`, which moves the hint onto the branch and removes it"),
253];
254
255/// An opcode nothing lowers, why it is here, and the issue that closes it.
256///
257/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
258/// spec says it should be, which is the honest reading of where the back end is: every one of
259/// these is a feature nobody has written, and all of them but one are opcodes the front end
260/// cannot produce either, so a program that reaches one of these is a program that reaches an
261/// unimplemented builtin first. The one is the remainder of two floats, which a program writes
262/// with an operator and which is a call to the maths library rather than an instruction.
263pub static GAPS: &[(Opcode, &str, &str)] = &[
264 (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
265 (
266 Opcode::TargetIntrinsic,
267 "the same, since what needs one is a vector builtin",
268 "tamnd/rucc#200",
269 ),
270 (
271 Opcode::FRem,
272 "a call to `fmod`, so a link line question as much as a lowering one",
273 "tamnd/rucc#226",
274 ),
275 (
276 Opcode::Fma,
277 "a call or one instruction, depending on what the machine is told it has",
278 "tamnd/rucc#226",
279 ),
280 (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
281 (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
282 (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
283 (
284 Opcode::SetjmpMarker,
285 "a call that returns twice, which the allocator has to be told about",
286 "tamnd/rucc#223",
287 ),
288 (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
289 (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
290 // Memory safety. These are a gap in a different sense from the rest: nothing emits one yet
291 // either, since the passes that would are milestones S5 and after, so there is no program the
292 // back end can be handed that reaches one. The ones the safety pass lowers are on `ELSEWHERE`,
293 // and the five that make a capability all left this list without anything emitting them, which
294 // is the whole of tamnd/rucc#1085's lowering half: each has a lowering waiting for the pass that
295 // will write one, because a capability had to be a value the back end could hold before any of
296 // them could be written down at all.
297 // The plane writes, which the runtime does for itself today because the only ranges anything
298 // asks about are the ones its own allocator handed out. A stack object needs these.
299 (Opcode::MetaBegin, "a write over a range of the lifetime plane", "tamnd/rucc#856"),
300 (
301 Opcode::MetaEnd,
302 "the same write, with the version bumped past every capability",
303 "tamnd/rucc#856",
304 ),
305 (
306 Opcode::MetaTransfer,
307 "the same, and the state a range is in while a device owns it, which is S2's",
308 "tamnd/rucc#856",
309 ),
310 (
311 Opcode::SafeRegionBegin,
312 "nothing at all, once the count document 10 section 10.2 asks for has been taken",
313 "tamnd/rucc#856",
314 ),
315 (Opcode::SafeRegionEnd, "the same, which is to say nothing", "tamnd/rucc#856"),
316];
317
318/// A width no rule is written at, why, and the issue that closes it.
319///
320/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
321/// every name it has is a name a rule is written at, and a width with no name has no names to
322/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
323/// language cannot spell. So the widths are written down here for the same reason the opcodes are
324/// written down above.
325pub static WIDTHS: &[(&str, &str, &str)] = &[
326 (
327 "one bit",
328 "everything but and, or, xor, a constant, and the widening out of one",
329 "tamnd/rucc#352",
330 ),
331 (
332 "a hundred and twenty eight bits",
333 "split into two halves before selection, except a division",
334 "tamnd/rucc#351",
335 ),
336 (
337 "eighty bits",
338 "a long double is on the x87 stack and no rule is about that stack",
339 "tamnd/rucc#326",
340 ),
341 (
342 "a hundred and twenty eight bits of float",
343 "turned into a call before selection, except a conditional move and the conversions \
344 against an integer that wide",
345 "tamnd/rucc#1064",
346 ),
347 (
348 "a vector of any lane count",
349 "a rule at a width says nothing about how many lanes",
350 "tamnd/rucc#200",
351 ),
352];
353
354/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
355/// back.
356///
357/// The third list, and the one that is about a name rather than about an opcode or a width. An
358/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
359/// and neither of those can say that `add` is lowered at four widths and left alone at two.
360///
361/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
362/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
363/// two sign extended chars and there is no C program that asks the back end to add two bytes.
364/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
365/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
366/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
367/// it writes a byte add out of the truncation the assignment back to a `char` already was.
368///
369/// What is left is what the pass will not narrow. A divide is not narrowed because the most
370/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
371/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen.
372///
373/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
374/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
375/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
376/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
377pub static NAMES: &[(&str, &str, &str)] = &[
378 ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
379 ("sdiv.i16", "the same", NARROW),
380 ("udiv.i8", "the same", NARROW),
381 ("udiv.i16", "the same", NARROW),
382 ("srem.i8", "the same", NARROW),
383 ("srem.i16", "the same", NARROW),
384 ("urem.i8", "the same", NARROW),
385 ("urem.i16", "the same", NARROW),
386];
387
388/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
389const NARROW: &str = "tamnd/rucc#375";
390
391/// What a target's rules cover, and what they do not.
392#[derive(Debug)]
393pub struct Report {
394 /// The rule file this is about, so that anything said about it names a file to open.
395 pub source: &'static str,
396 /// How many opcodes the IR has.
397 pub opcodes: usize,
398 /// The opcodes every name of which a rule is written at.
399 pub by_rule: Vec<Opcode>,
400 /// How many names those are, which is one per opcode and width.
401 pub names: usize,
402 /// A name a rule could be written at and none is, which is what a missing rule looks like.
403 pub uncovered: Vec<(Opcode, &'static str)>,
404 /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
405 pub deferred: Vec<(Opcode, &'static str)>,
406 /// A name a rule is written at that nothing can ever be called, which is a dead rule.
407 pub unreachable: Vec<&'static str>,
408 /// The opcodes lowered somewhere a rule cannot reach.
409 pub elsewhere: Vec<Opcode>,
410 /// The opcodes nothing lowers.
411 pub gaps: Vec<Opcode>,
412 /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
413 /// where it goes.
414 pub unaccounted: Vec<Opcode>,
415}
416
417impl fmt::Display for Report {
418 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
419 write!(
420 f,
421 "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
422 where no rule reaches, {} have no lowering yet and {} names are left for later",
423 self.source,
424 self.by_rule.len(),
425 self.opcodes,
426 self.names,
427 self.elsewhere.len(),
428 self.gaps.len(),
429 self.deferred.len()
430 )
431 }
432}
433
434/// What a table covers.
435///
436/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
437/// both data, and the answer is a comparison of two lists.
438#[must_use]
439pub fn report(table: &Table) -> Report {
440 let named = term::heads();
441 let patterns = pattern_heads(table);
442
443 let mut by_rule = Vec::new();
444 let mut uncovered = Vec::new();
445 let mut deferred = Vec::new();
446 for &(opcode, name) in &named {
447 if patterns.contains(&name) {
448 by_rule.push(opcode);
449 } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
450 deferred.push((opcode, name));
451 } else {
452 uncovered.push((opcode, name));
453 }
454 }
455 // An opcode is covered when every name it has is covered, so one missing width takes the
456 // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
457 // not take it off, because the opcode is lowered and the entry says which widths were left for
458 // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
459 // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
460 // four widths.
461 for &(opcode, _) in &uncovered {
462 by_rule.retain(|&covered| covered != opcode);
463 }
464 by_rule.sort_unstable();
465 by_rule.dedup();
466
467 let names = named.len() - uncovered.len() - deferred.len();
468 let unreachable: Vec<&'static str> = patterns
469 .iter()
470 .filter(|head| !named.iter().any(|(_, name)| name == *head))
471 .copied()
472 .collect();
473
474 let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
475 let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
476 let unaccounted: Vec<Opcode> = Opcode::all()
477 .filter(|opcode| {
478 !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
479 })
480 .collect();
481
482 Report {
483 source: table.source,
484 opcodes: Opcode::all().count(),
485 by_rule,
486 names,
487 uncovered,
488 deferred,
489 unreachable,
490 elsewhere,
491 gaps,
492 unaccounted,
493 }
494}
495
496/// Every name a rule in a table is written about, which is the first test the trie makes.
497///
498/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
499/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
500/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
501/// one that would be an error to write, since a lowering has to know what it is lowering.
502fn pattern_heads(table: &Table) -> Vec<&'static str> {
503 let Some(root) = table.nodes.first() else { return Vec::new() };
504 let mut found: Vec<&'static str> = root
505 .tests
506 .iter()
507 .filter_map(|(test, _)| match test {
508 Test::App { head, .. } => Some(*head),
509 // Neither can be at the root. A pattern is a term with a head, so the first step of
510 // every one of them is a head, and there is nothing bound yet to be the same as.
511 Test::Int(_) | Test::Same(_) => None,
512 })
513 .collect();
514 found.sort_unstable();
515 found.dedup();
516 found
517}
518
519/// The rules a target lowers by, or `None` where no back end in this crate covers it.
520///
521/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
522/// and it is here as well because a caller that wants to write down what a run covered has a
523/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
524/// time, and until then it has no rules to report coverage of rather than an empty set of them.
525#[must_use]
526pub fn table(arch: Arch) -> Option<&'static Table> {
527 match arch {
528 Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
529 Arch::Aarch64 | Arch::Riscv64 => None,
530 }
531}
532
533/// Which rules fired, over one function or over a whole compilation.
534///
535/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
536/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
537/// thing that answers the question is a flag per rule set once.
538///
539/// The index of a rule is how this is kept and not how it is written down. An index moves the
540/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
541/// a line is a place somebody can open, and a report written by one build can still be read against
542/// a rule file that has grown since.
543#[derive(Debug, Clone, Default, PartialEq, Eq)]
544pub struct Fired {
545 /// One entry per rule, true once that rule has fired. It grows to fit the highest index
546 /// marked rather than being sized from a table, so nothing here has to be told which target
547 /// is being compiled for.
548 seen: Vec<bool>,
549}
550
551impl Fired {
552 /// Nothing has fired yet.
553 #[must_use]
554 pub const fn new() -> Fired {
555 Fired { seen: Vec::new() }
556 }
557
558 /// Records that the rule at this index fired.
559 pub fn mark(&mut self, rule: usize) {
560 if self.seen.len() <= rule {
561 self.seen.resize(rule + 1, false);
562 }
563 self.seen[rule] = true;
564 }
565
566 /// Whether the rule at this index fired.
567 #[must_use]
568 pub fn has(&self, rule: usize) -> bool {
569 self.seen.get(rule).copied().unwrap_or(false)
570 }
571
572 /// How many rules fired.
573 #[must_use]
574 pub fn count(&self) -> usize {
575 self.seen.iter().filter(|fired| **fired).count()
576 }
577
578 /// Takes in everything another one recorded.
579 ///
580 /// One compilation is many functions and one command line is many files, and the question is
581 /// about all of them together. Merging rather than writing a file per function is also what
582 /// keeps the answer the same however the work was scheduled.
583 pub fn merge(&mut self, other: &Fired) {
584 if self.seen.len() < other.seen.len() {
585 self.seen.resize(other.seen.len(), false);
586 }
587 for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
588 *mine |= *theirs;
589 }
590 }
591
592 /// What `-Zrule-coverage=FILE` writes.
593 ///
594 /// One line per rule in the table, in the order the rule file writes them, each saying whether
595 /// the rule fired and naming the file and line it is written at. Every rule is listed rather
596 /// than only the ones that fired, so that one of these files says what the whole rule set was
597 /// as well as what this compilation reached: a reader unioning them over a corpus needs both
598 /// and would otherwise have to parse the rule file to get the second.
599 ///
600 /// The first line is a comment holding the count, which is the number a person wants and the
601 /// one thing here that is not worth making them add up.
602 #[must_use]
603 pub fn listing(&self, table: &Table) -> String {
604 let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
605 let mut out = format!(
606 "# rucc rule coverage: {fired} of {} rules in {} fired\n",
607 table.rules.len(),
608 table.source
609 );
610 for (index, rule) in table.rules.iter().enumerate() {
611 let word = if self.has(index) { "fired" } else { "unused" };
612 let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
613 }
614 out
615 }
616}
617
618#[cfg(test)]
619mod tests {
620 use super::*;
621 use crate::select::x86_64::TABLE;
622
623 /// The claim the whole module is for, in the direction that matters: a name an instruction
624 /// can be called by is a name a rule is written at. This is the width check as much as the
625 /// opcode check, since a name is an opcode and a width together.
626 #[test]
627 fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
628 let report = report(&TABLE);
629 assert!(
630 report.uncovered.is_empty(),
631 "nothing in {} lowers these, and each is an opcode at a width the rule language can \
632 spell: {:?}",
633 report.source,
634 report.uncovered
635 );
636 }
637
638 /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
639 /// A pattern head no instruction is ever called by is a rule written against a name that was
640 /// renamed or misspelled, and it would sit there proved and unreachable.
641 #[test]
642 fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
643 let report = report(&TABLE);
644 assert!(
645 report.unreachable.is_empty(),
646 "{} has rules for these and no instruction is ever called one: {:?}",
647 report.source,
648 report.unreachable
649 );
650 }
651
652 /// Every opcode is one of the three things, so a new opcode in the IR fails this until
653 /// somebody says where it goes. That is the whole point: the answer for a new opcode should
654 /// be written down when it is added rather than discovered by a user compiling a program.
655 #[test]
656 fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
657 let report = report(&TABLE);
658 assert!(
659 report.unaccounted.is_empty(),
660 "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
661 does not say why they are not: {:?}",
662 report.unaccounted
663 );
664 assert_eq!(
665 report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
666 report.opcodes,
667 "the three lists overlap, so an opcode is counted twice"
668 );
669 }
670
671 /// An entry that starts being covered fails, which is the rule every list in this project is
672 /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
673 /// that keeps claiming otherwise is a list nobody can read.
674 #[test]
675 fn an_entry_a_rule_now_covers_is_a_stale_entry() {
676 let report = report(&TABLE);
677 for &(opcode, where_) in ELSEWHERE {
678 assert!(
679 !report.by_rule.contains(&opcode),
680 "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
681 {where_} is stale",
682 opcode.name()
683 );
684 }
685 for &(opcode, why, issue) in GAPS {
686 assert!(
687 !report.by_rule.contains(&opcode),
688 "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
689 and {issue} may be closed",
690 opcode.name()
691 );
692 assert!(
693 !report.elsewhere.contains(&opcode),
694 "`{}` is on both lists, so it is both lowered and not lowered",
695 opcode.name()
696 );
697 }
698 }
699
700 /// The same staleness rule one list down. A name a rule is written at is a name that is not
701 /// left for later, and an entry claiming otherwise is one that should have gone when the rule
702 /// arrived. The other direction is checked too: a name no instruction can ever have is a
703 /// misspelling, and it would sit here excusing nothing.
704 #[test]
705 fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
706 let heads = pattern_heads(&TABLE);
707 let named = term::heads();
708 for &(name, why, issue) in NAMES {
709 assert!(
710 !heads.contains(&name),
711 "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
712 stale and {issue} may be closer than it says"
713 );
714 assert!(
715 named.iter().any(|&(_, head)| head == name),
716 "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
717 nothing"
718 );
719 }
720 let report = report(&TABLE);
721 assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
722 }
723
724 /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
725 /// anything about, which is the thing this module exists to stop.
726 #[test]
727 fn every_gap_names_the_issue_that_closes_it() {
728 let issues = GAPS
729 .iter()
730 .map(|&(_, _, issue)| issue)
731 .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
732 .chain(NAMES.iter().map(|&(_, _, issue)| issue));
733 for issue in issues {
734 let number = issue
735 .strip_prefix("tamnd/rucc#")
736 .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
737 assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
738 }
739 }
740
741 /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
742 /// this test with the output shown, so the number lands in a log next to the rule proof
743 /// rather than in a file somebody has to go and read.
744 #[test]
745 fn the_count_is_reported() {
746 let report = report(&TABLE);
747 println!("{report}");
748 for &(opcode, why, issue) in GAPS {
749 println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
750 }
751 for &(width, why, issue) in WIDTHS {
752 println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
753 }
754 for &(name, why, issue) in NAMES {
755 println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
756 }
757 assert_eq!(report.gaps.len(), GAPS.len());
758 }
759
760 /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
761 /// rule compiler ever built the trie some other way this would say so, rather than the
762 /// coverage numbers quietly becoming a report about an empty list.
763 #[test]
764 fn the_root_of_the_trie_is_the_head_of_every_pattern() {
765 let heads = pattern_heads(&TABLE);
766 assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
767 for rule in TABLE.rules {
768 let head = rule
769 .pattern
770 .strip_prefix('(')
771 .and_then(|rest| rest.split([' ', ')']).next())
772 .expect("a pattern is an application");
773 assert!(
774 heads.contains(&head),
775 "line {}: {} is a pattern whose head the root of the trie does not test",
776 rule.line,
777 rule.pattern
778 );
779 }
780 }
781
782 /// The one target with a rule file, and the two that get one at M6. A machine that can be
783 /// compiled for has rules to report the coverage of, and one that cannot has none rather than
784 /// an empty set of them, which are different answers and would read the same as a number.
785 #[test]
786 fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
787 let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
788 assert_eq!(x86.source, TABLE.source);
789 assert!(!x86.rules.is_empty());
790 assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
791 assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
792 }
793
794 /// What a rule is called outside this process. The index is not it: a rule added at the top of
795 /// the file moves every index below it, and a report from last week would then be a report
796 /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
797 #[test]
798 fn a_rule_is_written_down_as_the_place_it_is_written_at() {
799 let mut fired = Fired::new();
800 fired.mark(0);
801 let listing = fired.listing(&TABLE);
802 let first =
803 format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
804 assert!(listing.contains(&first), "{listing}");
805 assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
806 }
807
808 /// Every rule is listed and not only the ones that fired, which is what lets one of these files
809 /// be read on its own. A reader that only got the rules that fired would have to parse the rule
810 /// file to find out what the rest of them were.
811 #[test]
812 fn one_file_says_what_the_whole_rule_set_is() {
813 let listing = Fired::new().listing(&TABLE);
814 let lines: Vec<&str> = listing.lines().collect();
815 assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
816 assert_eq!(
817 lines.iter().filter(|line| line.starts_with("unused ")).count(),
818 TABLE.rules.len()
819 );
820 assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
821 }
822
823 /// A compilation is many functions and a command line is many files, and the question is about
824 /// all of them at once. Merging is also what keeps the answer the same however the work was
825 /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
826 #[test]
827 fn what_two_runs_reached_is_what_either_of_them_reached() {
828 let mut one = Fired::new();
829 one.mark(3);
830 one.mark(3);
831 assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
832 let mut two = Fired::new();
833 two.mark(0);
834 two.mark(9);
835 one.merge(&two);
836 assert_eq!(one.count(), 3);
837 assert!(one.has(0) && one.has(3) && one.has(9));
838 assert!(!one.has(1));
839
840 // The merge is symmetric, since neither order of two files is the right one.
841 let mut back = Fired::new();
842 back.mark(0);
843 back.mark(9);
844 let mut three = Fired::new();
845 three.mark(3);
846 back.merge(&three);
847 assert_eq!(back, one);
848 }
849}