rucc_codegen/coverage.rs
1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72 // The convention. What a call's operands are is whatever the signature made them, and which
73 // register each one arrives in depends on the classification of every argument before it.
74 (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75 (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76 // The frame, which is not known until the allocator has finished running out of registers.
77 (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78 // The stack pointer, which is not a value the program computed and so is not a value a rule
79 // could bind. A scope holding a variable length array reads it as it opens and writes it back
80 // as it closes, which is how the bytes are given back.
81 (Opcode::StackSave, "`crate::lower`, as a move out of the stack pointer"),
82 (Opcode::StackRestore, "`crate::lower`, the same move the other way round"),
83 // A relocation, which is right because of what the linker does rather than because of what
84 // any bitvector equals.
85 (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
86 // The one thing on this machine that no ordinary instruction can work out, which is why it
87 // is built here rather than matched: `%fs` is not a register a rule could name.
88 (Opcode::ThreadPointer, "`crate::lower`, as the load through `%fs` at zero that reads it"),
89 // A hint, which is built here for a reason of the same shape and one step stronger: which of
90 // the four instructions it is comes out of a number in the builtin's arguments, and a pattern
91 // matches on an opcode and a type and could not see it.
92 (Opcode::Prefetch, "`crate::lower`, as one of the four `prefetch` instructions"),
93 // No instruction at all. The IR keeps the width the same and the machine has one register
94 // file for both, so the value is already where it needs to be.
95 (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
96 (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
97 // Memory SSA, which is built at -O2, read by the passes that need it, and taken back off
98 // before selection. Nothing in the back end has ever seen a value of type `mem`.
99 (Opcode::MemEntry, "nothing at all, since memory SSA comes off before the back end runs"),
100 // The edges and the two ways of writing down that control does not arrive.
101 (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
102 (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
103 (Opcode::UnreachableHint, "nothing at all, for the same reason"),
104 // Rewritten into the opcodes above before selection ever sees them.
105 (Opcode::Switch, "`crate::switch`, into the tests its clusters need"),
106 (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
107 (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
108 (Opcode::UIToFP, "`crate::expand`, into a signed conversion with a widening or a halving"),
109 (Opcode::FPToUI, "`crate::expand`, into a signed conversion with a narrowing or a correction"),
110 (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
111 (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
112 (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
113 (Opcode::Bswap, "`crate::expand`, into the shifts and masks that reverse the bytes"),
114 // The ordered accesses, which this machine already makes ordered. `crate::expand` says what
115 // total store order gives for nothing and what the one ordering it does not give costs.
116 (Opcode::AtomicLoad, "`crate::expand`, into the plain load that is already an acquire"),
117 (Opcode::AtomicStore, "`crate::expand`, into the plain store, and a barrier at the strongest"),
118 // The barrier itself, which is one instruction or none and neither is a rewrite of anything.
119 // The template, which is a string and not a term. What an empty one stands for is no
120 // instructions and the places its operands share, and what a template with instructions in it
121 // stands for needs an assembler, which is `tamnd/rucc#349`.
122 (
123 Opcode::InlineAsm,
124 "`crate::lower`, as the places its operands share, while its template is empty",
125 ),
126 (
127 Opcode::Fence,
128 "`crate::lower`, as an `mfence` at the strongest ordering and nothing below it",
129 ),
130 // The compare and exchange, which is one instruction and produces two values, and a rule
131 // replaces a term with an instruction producing one.
132 (
133 Opcode::Cmpxchg,
134 "`crate::lower`, as a locked compare and exchange and the byte that reads its answer",
135 ),
136 // The read modify write, which produces one value a rule could have named and whose operation
137 // is carried beside it rather than in the head a rule matches on, so one pattern would be all
138 // thirteen of them.
139 (
140 Opcode::AtomicRmw,
141 "`crate::lower`, as an exchange or a locked add, and `crate::retry` for the eight with no \
142 instruction, with the two on floating values refused",
143 ),
144 (Opcode::Ctpop, "`crate::expand`, into the halving sum that counts the set bits"),
145 (Opcode::Ctlz, "`crate::expand`, into a smear and a set bit count"),
146 (Opcode::Cttz, "`crate::expand`, into a mask of the low zeroes and a set bit count"),
147 (Opcode::UAddOverflow, "`crate::expand`, into an add and a comparison against an operand"),
148 (Opcode::SAddOverflow, "`crate::expand`, into an add and the sign bit of the operands"),
149 (Opcode::USubOverflow, "`crate::expand`, into a subtract and a comparison of the operands"),
150 (Opcode::SSubOverflow, "`crate::expand`, into a subtract and the sign bit of the operands"),
151 (Opcode::UMulOverflow, "`crate::expand`, into a multiply and the high half of the product"),
152 (Opcode::SMulOverflow, "`crate::expand`, into the same, with the high half corrected for sign"),
153 // The variable argument list, which is four opcodes reading a structure the ABI describes.
154 (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
155 (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
156 (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
157 (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
158 (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
159 // Memory safety. A check is a call to the runtime, and the rewrite happens after the optimizer
160 // has run so that the descriptor table only has rows for checks that survived it.
161 (Opcode::CheckBounds, "`rucc_safety::lower`, into a call carrying the row that describes it"),
162 (Opcode::CheckLive, "`rucc_safety::lower`, the same call over the lifetime plane"),
163 (Opcode::CheckDeriv, "`rucc_safety::lower`, the same call where the pointer is computed"),
164 (Opcode::CheckType, "`rucc_safety::lower`, the same call, carrying the type asked about"),
165 (
166 Opcode::CheckInit,
167 "`rucc_safety::lower`, the same call over the init plane, carrying no type",
168 ),
169 (Opcode::CheckRace, "`rucc_safety::lower`, the same call over the epoch plane"),
170 // The five plane writes the same pass emits, which become calls the same way. A judgement
171 // decides nothing, so none of the calls carries a descriptor row, and neither do the two
172 // edges below them.
173 (Opcode::MetaType, "`rucc_safety::lower`, into the call that records what a store stored"),
174 (Opcode::MetaTypeCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
175 (Opcode::MetaInit, "`rucc_safety::lower`, into the call that says a store wrote a range"),
176 (Opcode::MetaInitCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
177 (Opcode::MetaEpoch, "`rucc_safety::lower`, into the call that says which thread stored"),
178 // The two halves of a synchronization edge, which are the same shape of call and are not a
179 // plane write at all: what they move is a thread's own clock, which lives beside the thread.
180 (
181 Opcode::MetaRelease,
182 "`rucc_safety::lower`, into the call that publishes this thread's clock at an atomic",
183 ),
184 (Opcode::MetaAcquire, "`rucc_safety::lower`, into the call that takes the other end of it"),
185 // The same pair for a fence, which are the same calls with no key, since a fence orders
186 // against every thread rather than against an object.
187 (
188 Opcode::MetaFenceRelease,
189 "`rucc_safety::lower`, into the call that publishes this thread's clock to everyone",
190 ),
191 (
192 Opcode::MetaFenceAcquire,
193 "`rucc_safety::lower`, into the call that takes what any release fence published",
194 ),
195 // The `restrict` contract, which is judgement J8 and is the one check that records as well as
196 // asks. What it records goes in a slot the block owns, and the two markers are what open and
197 // close that slot, so all four are calls to the runtime the same way.
198 (
199 Opcode::CheckRestrictRead,
200 "`rucc_safety::lower`, into the call that asks what the block has already reached",
201 ),
202 (Opcode::CheckRestrictWrite, "`rucc_safety::lower`, the same call, saying it wrote"),
203 (Opcode::RestrictEnter, "`rucc_safety::lower`, into the call that opens the block's record"),
204 (Opcode::RestrictLeave, "`rucc_safety::lower`, into the call that closes it again"),
205 (Opcode::CapExtent, "`rucc_safety::lower`, into a call that asks rather than one that judges"),
206 (Opcode::CapExtentBack, "`rucc_safety::lower`, the same call about the bytes below an address"),
207 // The capability the checks were reading, which the same pass takes out once they are calls,
208 // because a call to the runtime is handed an address and finds the rest for itself.
209 (Opcode::CapOf, "`rucc_safety::lower`, which removes it, since nothing reads it any more"),
210 // What `__builtin_expect` said, which the pass writes onto the arms of the branch it was said
211 // about before taking the instruction out, so that a hint and a profile are the same thing to
212 // everything downstream of the optimizer.
213 (Opcode::Expect, "`rucc_opt::expect`, which moves the hint onto the branch and removes it"),
214];
215
216/// An opcode nothing lowers, why it is here, and the issue that closes it.
217///
218/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
219/// spec says it should be, which is the honest reading of where the back end is: every one of
220/// these is a feature nobody has written, and all but three of them are opcodes the front end
221/// cannot produce either, so a program that reaches one of these is a program that reaches an
222/// unimplemented builtin first.
223pub static GAPS: &[(Opcode, &str, &str)] = &[
224 (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
225 (
226 Opcode::TargetIntrinsic,
227 "the same, since what needs one is a vector builtin",
228 "tamnd/rucc#200",
229 ),
230 (Opcode::BlockAddr, "the address of a label", "tamnd/rucc#353"),
231 (Opcode::IndirectBr, "the branch a computed goto turns into", "tamnd/rucc#353"),
232 (
233 Opcode::FRem,
234 "a call to `fmod`, so a link line question as much as a lowering one",
235 "tamnd/rucc#226",
236 ),
237 (
238 Opcode::Fma,
239 "a call or one instruction, depending on what the machine is told it has",
240 "tamnd/rucc#226",
241 ),
242 (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
243 (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
244 (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
245 (
246 Opcode::SetjmpMarker,
247 "a call that returns twice, which the allocator has to be told about",
248 "tamnd/rucc#223",
249 ),
250 (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
251 (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
252 // Memory safety. These are a gap in a different sense from the rest: nothing emits one yet
253 // either, since the passes that would are milestones S5 and after, so there is no program the
254 // back end can be handed that reaches one. The eighteen the safety pass does emit are on
255 // `ELSEWHERE`.
256 (
257 Opcode::CapLoad,
258 "a capability, whose runtime shape `spec/safe-memory/05-representation.md` decides",
259 "tamnd/rucc#856",
260 ),
261 (Opcode::CapStore, "the same, and a store into the slot beside a pointer", "tamnd/rucc#856"),
262 (
263 Opcode::CapNull,
264 "the same, and it is whatever the representation says nothing is",
265 "tamnd/rucc#856",
266 ),
267 (Opcode::CapNarrow, "the same, and arithmetic on the bounds it holds", "tamnd/rucc#856"),
268 (Opcode::CapRecover, "the same, and a read of the shadow planes", "tamnd/rucc#856"),
269 // The plane writes, which the runtime does for itself today because the only ranges anything
270 // asks about are the ones its own allocator handed out. A stack object needs these.
271 (Opcode::MetaBegin, "a write over a range of the lifetime plane", "tamnd/rucc#856"),
272 (
273 Opcode::MetaEnd,
274 "the same write, with the version bumped past every capability",
275 "tamnd/rucc#856",
276 ),
277 (
278 Opcode::MetaTransfer,
279 "the same, and the state a range is in while a device owns it, which is S2's",
280 "tamnd/rucc#856",
281 ),
282 (
283 Opcode::SafeRegionBegin,
284 "nothing at all, once the count document 10 section 10.2 asks for has been taken",
285 "tamnd/rucc#856",
286 ),
287 (Opcode::SafeRegionEnd, "the same, which is to say nothing", "tamnd/rucc#856"),
288];
289
290/// A width no rule is written at, why, and the issue that closes it.
291///
292/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
293/// every name it has is a name a rule is written at, and a width with no name has no names to
294/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
295/// language cannot spell. So the widths are written down here for the same reason the opcodes are
296/// written down above.
297pub static WIDTHS: &[(&str, &str, &str)] = &[
298 (
299 "one bit",
300 "everything but and, or, xor, a constant, and the widening out of one",
301 "tamnd/rucc#352",
302 ),
303 (
304 "a hundred and twenty eight bits",
305 "split into two halves before selection, except a division",
306 "tamnd/rucc#351",
307 ),
308 (
309 "eighty bits",
310 "a long double is on the x87 stack and no rule is about that stack",
311 "tamnd/rucc#326",
312 ),
313 (
314 "a vector of any lane count",
315 "a rule at a width says nothing about how many lanes",
316 "tamnd/rucc#200",
317 ),
318];
319
320/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
321/// back.
322///
323/// The third list, and the one that is about a name rather than about an opcode or a width. An
324/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
325/// and neither of those can say that `add` is lowered at four widths and left alone at two.
326///
327/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
328/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
329/// two sign extended chars and there is no C program that asks the back end to add two bytes.
330/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
331/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
332/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
333/// it writes a byte add out of the truncation the assignment back to a `char` already was.
334///
335/// What is left is what the pass will not narrow. A divide is not narrowed because the most
336/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
337/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen.
338///
339/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
340/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
341/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
342/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
343pub static NAMES: &[(&str, &str, &str)] = &[
344 ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
345 ("sdiv.i16", "the same", NARROW),
346 ("udiv.i8", "the same", NARROW),
347 ("udiv.i16", "the same", NARROW),
348 ("srem.i8", "the same", NARROW),
349 ("srem.i16", "the same", NARROW),
350 ("urem.i8", "the same", NARROW),
351 ("urem.i16", "the same", NARROW),
352];
353
354/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
355const NARROW: &str = "tamnd/rucc#375";
356
357/// What a target's rules cover, and what they do not.
358#[derive(Debug)]
359pub struct Report {
360 /// The rule file this is about, so that anything said about it names a file to open.
361 pub source: &'static str,
362 /// How many opcodes the IR has.
363 pub opcodes: usize,
364 /// The opcodes every name of which a rule is written at.
365 pub by_rule: Vec<Opcode>,
366 /// How many names those are, which is one per opcode and width.
367 pub names: usize,
368 /// A name a rule could be written at and none is, which is what a missing rule looks like.
369 pub uncovered: Vec<(Opcode, &'static str)>,
370 /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
371 pub deferred: Vec<(Opcode, &'static str)>,
372 /// A name a rule is written at that nothing can ever be called, which is a dead rule.
373 pub unreachable: Vec<&'static str>,
374 /// The opcodes lowered somewhere a rule cannot reach.
375 pub elsewhere: Vec<Opcode>,
376 /// The opcodes nothing lowers.
377 pub gaps: Vec<Opcode>,
378 /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
379 /// where it goes.
380 pub unaccounted: Vec<Opcode>,
381}
382
383impl fmt::Display for Report {
384 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
385 write!(
386 f,
387 "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
388 where no rule reaches, {} have no lowering yet and {} names are left for later",
389 self.source,
390 self.by_rule.len(),
391 self.opcodes,
392 self.names,
393 self.elsewhere.len(),
394 self.gaps.len(),
395 self.deferred.len()
396 )
397 }
398}
399
400/// What a table covers.
401///
402/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
403/// both data, and the answer is a comparison of two lists.
404#[must_use]
405pub fn report(table: &Table) -> Report {
406 let named = term::heads();
407 let patterns = pattern_heads(table);
408
409 let mut by_rule = Vec::new();
410 let mut uncovered = Vec::new();
411 let mut deferred = Vec::new();
412 for &(opcode, name) in &named {
413 if patterns.contains(&name) {
414 by_rule.push(opcode);
415 } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
416 deferred.push((opcode, name));
417 } else {
418 uncovered.push((opcode, name));
419 }
420 }
421 // An opcode is covered when every name it has is covered, so one missing width takes the
422 // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
423 // not take it off, because the opcode is lowered and the entry says which widths were left for
424 // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
425 // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
426 // four widths.
427 for &(opcode, _) in &uncovered {
428 by_rule.retain(|&covered| covered != opcode);
429 }
430 by_rule.sort_unstable();
431 by_rule.dedup();
432
433 let names = named.len() - uncovered.len() - deferred.len();
434 let unreachable: Vec<&'static str> = patterns
435 .iter()
436 .filter(|head| !named.iter().any(|(_, name)| name == *head))
437 .copied()
438 .collect();
439
440 let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
441 let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
442 let unaccounted: Vec<Opcode> = Opcode::all()
443 .filter(|opcode| {
444 !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
445 })
446 .collect();
447
448 Report {
449 source: table.source,
450 opcodes: Opcode::all().count(),
451 by_rule,
452 names,
453 uncovered,
454 deferred,
455 unreachable,
456 elsewhere,
457 gaps,
458 unaccounted,
459 }
460}
461
462/// Every name a rule in a table is written about, which is the first test the trie makes.
463///
464/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
465/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
466/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
467/// one that would be an error to write, since a lowering has to know what it is lowering.
468fn pattern_heads(table: &Table) -> Vec<&'static str> {
469 let Some(root) = table.nodes.first() else { return Vec::new() };
470 let mut found: Vec<&'static str> = root
471 .tests
472 .iter()
473 .filter_map(|(test, _)| match test {
474 Test::App { head, .. } => Some(*head),
475 // Neither can be at the root. A pattern is a term with a head, so the first step of
476 // every one of them is a head, and there is nothing bound yet to be the same as.
477 Test::Int(_) | Test::Same(_) => None,
478 })
479 .collect();
480 found.sort_unstable();
481 found.dedup();
482 found
483}
484
485/// The rules a target lowers by, or `None` where no back end in this crate covers it.
486///
487/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
488/// and it is here as well because a caller that wants to write down what a run covered has a
489/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
490/// time, and until then it has no rules to report coverage of rather than an empty set of them.
491#[must_use]
492pub fn table(arch: Arch) -> Option<&'static Table> {
493 match arch {
494 Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
495 Arch::Aarch64 | Arch::Riscv64 => None,
496 }
497}
498
499/// Which rules fired, over one function or over a whole compilation.
500///
501/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
502/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
503/// thing that answers the question is a flag per rule set once.
504///
505/// The index of a rule is how this is kept and not how it is written down. An index moves the
506/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
507/// a line is a place somebody can open, and a report written by one build can still be read against
508/// a rule file that has grown since.
509#[derive(Debug, Clone, Default, PartialEq, Eq)]
510pub struct Fired {
511 /// One entry per rule, true once that rule has fired. It grows to fit the highest index
512 /// marked rather than being sized from a table, so nothing here has to be told which target
513 /// is being compiled for.
514 seen: Vec<bool>,
515}
516
517impl Fired {
518 /// Nothing has fired yet.
519 #[must_use]
520 pub const fn new() -> Fired {
521 Fired { seen: Vec::new() }
522 }
523
524 /// Records that the rule at this index fired.
525 pub fn mark(&mut self, rule: usize) {
526 if self.seen.len() <= rule {
527 self.seen.resize(rule + 1, false);
528 }
529 self.seen[rule] = true;
530 }
531
532 /// Whether the rule at this index fired.
533 #[must_use]
534 pub fn has(&self, rule: usize) -> bool {
535 self.seen.get(rule).copied().unwrap_or(false)
536 }
537
538 /// How many rules fired.
539 #[must_use]
540 pub fn count(&self) -> usize {
541 self.seen.iter().filter(|fired| **fired).count()
542 }
543
544 /// Takes in everything another one recorded.
545 ///
546 /// One compilation is many functions and one command line is many files, and the question is
547 /// about all of them together. Merging rather than writing a file per function is also what
548 /// keeps the answer the same however the work was scheduled.
549 pub fn merge(&mut self, other: &Fired) {
550 if self.seen.len() < other.seen.len() {
551 self.seen.resize(other.seen.len(), false);
552 }
553 for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
554 *mine |= *theirs;
555 }
556 }
557
558 /// What `-Zrule-coverage=FILE` writes.
559 ///
560 /// One line per rule in the table, in the order the rule file writes them, each saying whether
561 /// the rule fired and naming the file and line it is written at. Every rule is listed rather
562 /// than only the ones that fired, so that one of these files says what the whole rule set was
563 /// as well as what this compilation reached: a reader unioning them over a corpus needs both
564 /// and would otherwise have to parse the rule file to get the second.
565 ///
566 /// The first line is a comment holding the count, which is the number a person wants and the
567 /// one thing here that is not worth making them add up.
568 #[must_use]
569 pub fn listing(&self, table: &Table) -> String {
570 let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
571 let mut out = format!(
572 "# rucc rule coverage: {fired} of {} rules in {} fired\n",
573 table.rules.len(),
574 table.source
575 );
576 for (index, rule) in table.rules.iter().enumerate() {
577 let word = if self.has(index) { "fired" } else { "unused" };
578 let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
579 }
580 out
581 }
582}
583
584#[cfg(test)]
585mod tests {
586 use super::*;
587 use crate::select::x86_64::TABLE;
588
589 /// The claim the whole module is for, in the direction that matters: a name an instruction
590 /// can be called by is a name a rule is written at. This is the width check as much as the
591 /// opcode check, since a name is an opcode and a width together.
592 #[test]
593 fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
594 let report = report(&TABLE);
595 assert!(
596 report.uncovered.is_empty(),
597 "nothing in {} lowers these, and each is an opcode at a width the rule language can \
598 spell: {:?}",
599 report.source,
600 report.uncovered
601 );
602 }
603
604 /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
605 /// A pattern head no instruction is ever called by is a rule written against a name that was
606 /// renamed or misspelled, and it would sit there proved and unreachable.
607 #[test]
608 fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
609 let report = report(&TABLE);
610 assert!(
611 report.unreachable.is_empty(),
612 "{} has rules for these and no instruction is ever called one: {:?}",
613 report.source,
614 report.unreachable
615 );
616 }
617
618 /// Every opcode is one of the three things, so a new opcode in the IR fails this until
619 /// somebody says where it goes. That is the whole point: the answer for a new opcode should
620 /// be written down when it is added rather than discovered by a user compiling a program.
621 #[test]
622 fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
623 let report = report(&TABLE);
624 assert!(
625 report.unaccounted.is_empty(),
626 "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
627 does not say why they are not: {:?}",
628 report.unaccounted
629 );
630 assert_eq!(
631 report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
632 report.opcodes,
633 "the three lists overlap, so an opcode is counted twice"
634 );
635 }
636
637 /// An entry that starts being covered fails, which is the rule every list in this project is
638 /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
639 /// that keeps claiming otherwise is a list nobody can read.
640 #[test]
641 fn an_entry_a_rule_now_covers_is_a_stale_entry() {
642 let report = report(&TABLE);
643 for &(opcode, where_) in ELSEWHERE {
644 assert!(
645 !report.by_rule.contains(&opcode),
646 "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
647 {where_} is stale",
648 opcode.name()
649 );
650 }
651 for &(opcode, why, issue) in GAPS {
652 assert!(
653 !report.by_rule.contains(&opcode),
654 "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
655 and {issue} may be closed",
656 opcode.name()
657 );
658 assert!(
659 !report.elsewhere.contains(&opcode),
660 "`{}` is on both lists, so it is both lowered and not lowered",
661 opcode.name()
662 );
663 }
664 }
665
666 /// The same staleness rule one list down. A name a rule is written at is a name that is not
667 /// left for later, and an entry claiming otherwise is one that should have gone when the rule
668 /// arrived. The other direction is checked too: a name no instruction can ever have is a
669 /// misspelling, and it would sit here excusing nothing.
670 #[test]
671 fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
672 let heads = pattern_heads(&TABLE);
673 let named = term::heads();
674 for &(name, why, issue) in NAMES {
675 assert!(
676 !heads.contains(&name),
677 "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
678 stale and {issue} may be closer than it says"
679 );
680 assert!(
681 named.iter().any(|&(_, head)| head == name),
682 "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
683 nothing"
684 );
685 }
686 let report = report(&TABLE);
687 assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
688 }
689
690 /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
691 /// anything about, which is the thing this module exists to stop.
692 #[test]
693 fn every_gap_names_the_issue_that_closes_it() {
694 let issues = GAPS
695 .iter()
696 .map(|&(_, _, issue)| issue)
697 .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
698 .chain(NAMES.iter().map(|&(_, _, issue)| issue));
699 for issue in issues {
700 let number = issue
701 .strip_prefix("tamnd/rucc#")
702 .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
703 assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
704 }
705 }
706
707 /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
708 /// this test with the output shown, so the number lands in a log next to the rule proof
709 /// rather than in a file somebody has to go and read.
710 #[test]
711 fn the_count_is_reported() {
712 let report = report(&TABLE);
713 println!("{report}");
714 for &(opcode, why, issue) in GAPS {
715 println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
716 }
717 for &(width, why, issue) in WIDTHS {
718 println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
719 }
720 for &(name, why, issue) in NAMES {
721 println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
722 }
723 assert_eq!(report.gaps.len(), GAPS.len());
724 }
725
726 /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
727 /// rule compiler ever built the trie some other way this would say so, rather than the
728 /// coverage numbers quietly becoming a report about an empty list.
729 #[test]
730 fn the_root_of_the_trie_is_the_head_of_every_pattern() {
731 let heads = pattern_heads(&TABLE);
732 assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
733 for rule in TABLE.rules {
734 let head = rule
735 .pattern
736 .strip_prefix('(')
737 .and_then(|rest| rest.split([' ', ')']).next())
738 .expect("a pattern is an application");
739 assert!(
740 heads.contains(&head),
741 "line {}: {} is a pattern whose head the root of the trie does not test",
742 rule.line,
743 rule.pattern
744 );
745 }
746 }
747
748 /// The one target with a rule file, and the two that get one at M6. A machine that can be
749 /// compiled for has rules to report the coverage of, and one that cannot has none rather than
750 /// an empty set of them, which are different answers and would read the same as a number.
751 #[test]
752 fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
753 let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
754 assert_eq!(x86.source, TABLE.source);
755 assert!(!x86.rules.is_empty());
756 assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
757 assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
758 }
759
760 /// What a rule is called outside this process. The index is not it: a rule added at the top of
761 /// the file moves every index below it, and a report from last week would then be a report
762 /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
763 #[test]
764 fn a_rule_is_written_down_as_the_place_it_is_written_at() {
765 let mut fired = Fired::new();
766 fired.mark(0);
767 let listing = fired.listing(&TABLE);
768 let first =
769 format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
770 assert!(listing.contains(&first), "{listing}");
771 assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
772 }
773
774 /// Every rule is listed and not only the ones that fired, which is what lets one of these files
775 /// be read on its own. A reader that only got the rules that fired would have to parse the rule
776 /// file to find out what the rest of them were.
777 #[test]
778 fn one_file_says_what_the_whole_rule_set_is() {
779 let listing = Fired::new().listing(&TABLE);
780 let lines: Vec<&str> = listing.lines().collect();
781 assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
782 assert_eq!(
783 lines.iter().filter(|line| line.starts_with("unused ")).count(),
784 TABLE.rules.len()
785 );
786 assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
787 }
788
789 /// A compilation is many functions and a command line is many files, and the question is about
790 /// all of them at once. Merging is also what keeps the answer the same however the work was
791 /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
792 #[test]
793 fn what_two_runs_reached_is_what_either_of_them_reached() {
794 let mut one = Fired::new();
795 one.mark(3);
796 one.mark(3);
797 assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
798 let mut two = Fired::new();
799 two.mark(0);
800 two.mark(9);
801 one.merge(&two);
802 assert_eq!(one.count(), 3);
803 assert!(one.has(0) && one.has(3) && one.has(9));
804 assert!(!one.has(1));
805
806 // The merge is symmetric, since neither order of two files is the right one.
807 let mut back = Fired::new();
808 back.mark(0);
809 back.mark(9);
810 let mut three = Fired::new();
811 three.mark(3);
812 back.merge(&three);
813 assert_eq!(back, one);
814 }
815}