rucc_codegen/coverage.rs
1//! Which IR opcodes have somewhere to go, and which do not.
2//!
3//! Design: `spec/10-backend.md` section 10.2, under **Coverage**.
4//!
5//! Every opcode has to be lowered by something or be a hole somebody wrote down. Without this the
6//! way a hole is found is that somebody compiles a program containing one and the selector reports
7//! that it cannot lower an instruction, which is a fine diagnostic and a bad discovery mechanism:
8//! it turns a gap in the rule set into a user's problem rather than a failing build.
9//!
10//! # The three answers
11//!
12//! An opcode is lowered by a rule, or somewhere a rule cannot reach, or nowhere.
13//!
14//! The first is the ordinary answer and the one this can check by itself. [`crate::term`] says
15//! every name a rule could be written at, the table says every name one is written at, and an
16//! opcode is covered when each of its names is in both. That is what makes this a check about
17//! widths rather than about opcodes: an `add` with a rule at four widths and no rule at the fifth
18//! is not covered, and would be reported here as the missing name rather than as a covered opcode.
19//!
20//! The second is [`ELSEWHERE`], which is not a gap. `spec/10-backend.md` names five of them and
21//! there are more now, and they are all the same kind of thing: an opcode whose lowering depends on
22//! something no pattern can see. Where a call's arguments go depends on the signature, where a
23//! local lives depends on the frame, an unconditional jump is an edge and edges live on the block,
24//! and a `memcpy` is a run of moves whose length is a constant the pattern would have to count. A
25//! rule matches one term and can say none of that.
26//!
27//! The third is [`GAPS`], which is the number `spec/15-testing.md` section 15.8 says we keep. Each
28//! entry names why it is there and the issue that closes it, so that an opcode nobody has written a
29//! rule for is a decision somebody wrote down rather than a surprise.
30//!
31//! [`WIDTHS`] and [`NAMES`] are the same third answer said about something smaller than an opcode.
32//! A width on [`WIDTHS`] has no names at all, so no opcode is missing a rule at it, and a name on
33//! [`NAMES`] is one width of an opcode that lowers at its other widths. Both carry the issue that
34//! closes them for the same reason [`GAPS`] does.
35//!
36//! # What makes the lists honest
37//!
38//! An entry that stops being true fails. An opcode on either list that a rule starts covering is a
39//! stale entry and the tests below say so by name, which is the same rule the exclusion lists in
40//! the compatibility harness are kept under: a list nothing checks is a list that only grows.
41//!
42//! The direction this cannot check is an opcode moving from [`GAPS`] to [`ELSEWHERE`] without the
43//! list following it, because where an opcode is lowered by name is a `match` arm and there is
44//! nothing to ask about a `match` arm from here. What that costs is one line of a list going out of
45//! date; what it does not cost is a gap going unnoticed, since the opcode is still on a list and
46//! still counted.
47//!
48//! # The other question
49//!
50//! All of the above is about the rule set as it is written. [`Fired`] is about the rule set as it
51//! is used: which rules a compilation actually reached. A rule nothing reaches is proved and dead
52//! weight, or it is a construct the corpus does not contain and somebody should know which. The
53//! selector marks a rule as it fires it, the driver writes the marks out under
54//! `-Zrule-coverage=FILE`, and the harness in `tamnd/rucc-compat` unions those files over a corpus,
55//! which is what turns coverage of the rule set into a number. `spec/20-execution-testing.md`
56//! section 20.9 is the design and `tamnd/rucc#261` is the work.
57
58use core::fmt;
59use core::fmt::Write as _;
60
61use rucc_ir::Opcode;
62use rucc_target::Arch;
63
64use crate::select::{Table, Test};
65use crate::term;
66
67/// An opcode no rule is written about, and the place that lowers it instead.
68///
69/// Not one of these is a gap. Each is an opcode whose lowering depends on something a pattern
70/// cannot see, so the answer lives where that something is known.
71pub static ELSEWHERE: &[(Opcode, &str)] = &[
72 // The convention. What a call's operands are is whatever the signature made them, and which
73 // register each one arrives in depends on the classification of every argument before it.
74 (Opcode::Call, "`crate::abi`, which builds a call out of the convention"),
75 (Opcode::CallIndirect, "`crate::abi`, the same instruction with the callee in a register"),
76 // The frame, which is not known until the allocator has finished running out of registers.
77 (Opcode::Alloca, "`crate::lower`, as an address into a frame `crate::frame` lays out later"),
78 // The stack pointer, which is not a value the program computed and so is not a value a rule
79 // could bind. A scope holding a variable length array reads it as it opens and writes it back
80 // as it closes, which is how the bytes are given back.
81 (Opcode::StackSave, "`crate::lower`, as a move out of the stack pointer"),
82 (Opcode::StackRestore, "`crate::lower`, the same move the other way round"),
83 // A relocation, which is right because of what the linker does rather than because of what
84 // any bitvector equals.
85 (Opcode::GlobalAddr, "`crate::lower`, a `lea` off the instruction pointer with a name on it"),
86 // No instruction at all. The IR keeps the width the same and the machine has one register
87 // file for both, so the value is already where it needs to be.
88 (Opcode::PtrToInt, "`crate::lower`, which renames the value rather than computing anything"),
89 (Opcode::IntToPtr, "`crate::lower`, the same rename the other way round"),
90 // Memory SSA, which is built at -O2, read by the passes that need it, and taken back off
91 // before selection. Nothing in the back end has ever seen a value of type `mem`.
92 (Opcode::MemEntry, "nothing at all, since memory SSA comes off before the back end runs"),
93 // The edges and the two ways of writing down that control does not arrive.
94 (Opcode::Jump, "`crate::layout`, since an edge is on the block and not in the block"),
95 (Opcode::Unreachable, "nothing at all, which is the answer for a place control does not reach"),
96 (Opcode::UnreachableHint, "nothing at all, for the same reason"),
97 // Rewritten into the opcodes above before selection ever sees them.
98 (Opcode::Switch, "`crate::switch`, into the tests its clusters need"),
99 (Opcode::FConst, "`crate::expand`, into a constant in memory and a load of it"),
100 (Opcode::FNeg, "`crate::expand`, into the sign bit flip it is"),
101 (Opcode::UIToFP, "`crate::expand`, into a signed conversion with a widening or a halving"),
102 (Opcode::FPToUI, "`crate::expand`, into a signed conversion with a narrowing or a correction"),
103 (Opcode::Memcpy, "`crate::expand`, into the moves it stands for"),
104 (Opcode::Memset, "`crate::expand`, into the fills it stands for"),
105 (Opcode::Memmove, "`crate::expand`, into a call, since the two regions may overlap"),
106 (Opcode::Bswap, "`crate::expand`, into the shifts and masks that reverse the bytes"),
107 // The ordered accesses, which this machine already makes ordered. `crate::expand` says what
108 // total store order gives for nothing and what the one ordering it does not give costs.
109 (Opcode::AtomicLoad, "`crate::expand`, into the plain load that is already an acquire"),
110 (Opcode::AtomicStore, "`crate::expand`, into the plain store, and a barrier at the strongest"),
111 // The barrier itself, which is one instruction or none and neither is a rewrite of anything.
112 // The template, which is a string and not a term. What an empty one stands for is no
113 // instructions and the places its operands share, and what a template with instructions in it
114 // stands for needs an assembler, which is `tamnd/rucc#349`.
115 (
116 Opcode::InlineAsm,
117 "`crate::lower`, as the places its operands share, while its template is empty",
118 ),
119 (
120 Opcode::Fence,
121 "`crate::lower`, as an `mfence` at the strongest ordering and nothing below it",
122 ),
123 // The compare and exchange, which is one instruction and produces two values, and a rule
124 // replaces a term with an instruction producing one.
125 (
126 Opcode::Cmpxchg,
127 "`crate::lower`, as a locked compare and exchange and the byte that reads its answer",
128 ),
129 // The read modify write, which produces one value a rule could have named and whose operation
130 // is carried beside it rather than in the head a rule matches on, so one pattern would be all
131 // thirteen of them.
132 (
133 Opcode::AtomicRmw,
134 "`crate::lower`, as an exchange or a locked add, and `crate::retry` for the eight with no \
135 instruction, with the two on floating values refused",
136 ),
137 (Opcode::Ctpop, "`crate::expand`, into the halving sum that counts the set bits"),
138 (Opcode::Ctlz, "`crate::expand`, into a smear and a set bit count"),
139 (Opcode::Cttz, "`crate::expand`, into a mask of the low zeroes and a set bit count"),
140 (Opcode::UAddOverflow, "`crate::expand`, into an add and a comparison against an operand"),
141 (Opcode::SAddOverflow, "`crate::expand`, into an add and the sign bit of the operands"),
142 (Opcode::USubOverflow, "`crate::expand`, into a subtract and a comparison of the operands"),
143 (Opcode::SSubOverflow, "`crate::expand`, into a subtract and the sign bit of the operands"),
144 (Opcode::UMulOverflow, "`crate::expand`, into a multiply and the high half of the product"),
145 (Opcode::SMulOverflow, "`crate::expand`, into the same, with the high half corrected for sign"),
146 // The variable argument list, which is four opcodes reading a structure the ABI describes.
147 (Opcode::VaStart, "`crate::varargs`, which writes the register save area the ABI describes"),
148 (Opcode::VaArg, "`crate::varargs`, into the walk over that structure"),
149 (Opcode::VaObject, "`crate::varargs`, the same walk for something that arrived in memory"),
150 (Opcode::VaCopy, "`crate::varargs`, into a copy of the structure"),
151 (Opcode::VaEnd, "`crate::varargs`, which removes it, since there is nothing to undo"),
152 // Memory safety. A check is a call to the runtime, and the rewrite happens after the optimizer
153 // has run so that the descriptor table only has rows for checks that survived it.
154 (Opcode::CheckBounds, "`rucc_safety::lower`, into a call carrying the row that describes it"),
155 (Opcode::CheckLive, "`rucc_safety::lower`, the same call over the lifetime plane"),
156 (Opcode::CheckDeriv, "`rucc_safety::lower`, the same call where the pointer is computed"),
157 (Opcode::CheckType, "`rucc_safety::lower`, the same call, carrying the type asked about"),
158 (
159 Opcode::CheckInit,
160 "`rucc_safety::lower`, the same call over the init plane, carrying no type",
161 ),
162 (Opcode::CheckRace, "`rucc_safety::lower`, the same call over the epoch plane"),
163 // The five plane writes the same pass emits, which become calls the same way. A judgement
164 // decides nothing, so none of the calls carries a descriptor row, and neither do the two
165 // edges below them.
166 (Opcode::MetaType, "`rucc_safety::lower`, into the call that records what a store stored"),
167 (Opcode::MetaTypeCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
168 (Opcode::MetaInit, "`rucc_safety::lower`, into the call that says a store wrote a range"),
169 (Opcode::MetaInitCopy, "`rucc_safety::lower`, the same call over the range a copy read"),
170 (Opcode::MetaEpoch, "`rucc_safety::lower`, into the call that says which thread stored"),
171 // The two halves of a synchronization edge, which are the same shape of call and are not a
172 // plane write at all: what they move is a thread's own clock, which lives beside the thread.
173 (
174 Opcode::MetaRelease,
175 "`rucc_safety::lower`, into the call that publishes this thread's clock at an atomic",
176 ),
177 (Opcode::MetaAcquire, "`rucc_safety::lower`, into the call that takes the other end of it"),
178 // The same pair for a fence, which are the same calls with no key, since a fence orders
179 // against every thread rather than against an object.
180 (
181 Opcode::MetaFenceRelease,
182 "`rucc_safety::lower`, into the call that publishes this thread's clock to everyone",
183 ),
184 (
185 Opcode::MetaFenceAcquire,
186 "`rucc_safety::lower`, into the call that takes what any release fence published",
187 ),
188 // The `restrict` contract, which is judgement J8 and is the one check that records as well as
189 // asks. What it records goes in a slot the block owns, and the two markers are what open and
190 // close that slot, so all four are calls to the runtime the same way.
191 (
192 Opcode::CheckRestrictRead,
193 "`rucc_safety::lower`, into the call that asks what the block has already reached",
194 ),
195 (Opcode::CheckRestrictWrite, "`rucc_safety::lower`, the same call, saying it wrote"),
196 (Opcode::RestrictEnter, "`rucc_safety::lower`, into the call that opens the block's record"),
197 (Opcode::RestrictLeave, "`rucc_safety::lower`, into the call that closes it again"),
198 (Opcode::CapExtent, "`rucc_safety::lower`, into a call that asks rather than one that judges"),
199 (Opcode::CapExtentBack, "`rucc_safety::lower`, the same call about the bytes below an address"),
200 // The capability the checks were reading, which the same pass takes out once they are calls,
201 // because a call to the runtime is handed an address and finds the rest for itself.
202 (Opcode::CapOf, "`rucc_safety::lower`, which removes it, since nothing reads it any more"),
203];
204
205/// An opcode nothing lowers, why it is here, and the issue that closes it.
206///
207/// This is the count `spec/15-testing.md` section 15.8 asks for. It is not zero yet and the
208/// spec says it should be, which is the honest reading of where the back end is: every one of
209/// these is a feature nobody has written, and all but three of them are opcodes the front end
210/// cannot produce either, so a program that reaches one of these is a program that reaches an
211/// unimplemented builtin first.
212pub static GAPS: &[(Opcode, &str, &str)] = &[
213 (Opcode::Splat, "a vector, and no rule is written about a lane count", "tamnd/rucc#200"),
214 (
215 Opcode::TargetIntrinsic,
216 "the same, since what needs one is a vector builtin",
217 "tamnd/rucc#200",
218 ),
219 (Opcode::BlockAddr, "the address of a label", "tamnd/rucc#353"),
220 (Opcode::IndirectBr, "the branch a computed goto turns into", "tamnd/rucc#353"),
221 (
222 Opcode::FRem,
223 "a call to `fmod`, so a link line question as much as a lowering one",
224 "tamnd/rucc#226",
225 ),
226 (
227 Opcode::Fma,
228 "a call or one instruction, depending on what the machine is told it has",
229 "tamnd/rucc#226",
230 ),
231 (Opcode::Bitreverse, "a node nothing writes and nothing lowers", "tamnd/rucc#363"),
232 (Opcode::Expect, "a branch weight nothing reads yet", "tamnd/rucc#364"),
233 (Opcode::Prefetch, "one instruction, once the hints have somewhere to go", "tamnd/rucc#313"),
234 (Opcode::FrameAddress, "a walk up the frame pointers", "tamnd/rucc#312"),
235 (Opcode::ReturnAddress, "the same walk, one word further along", "tamnd/rucc#312"),
236 (
237 Opcode::SetjmpMarker,
238 "a call that returns twice, which the allocator has to be told about",
239 "tamnd/rucc#223",
240 ),
241 (Opcode::LongjmpMarker, "the same", "tamnd/rucc#223"),
242 (Opcode::TailCall, "a terminator nothing writes and nothing lowers", "tamnd/rucc#365"),
243 // Memory safety. These are a gap in a different sense from the rest: nothing emits one yet
244 // either, since the passes that would are milestones S5 and after, so there is no program the
245 // back end can be handed that reaches one. The eighteen the safety pass does emit are on
246 // `ELSEWHERE`.
247 (
248 Opcode::CapLoad,
249 "a capability, whose runtime shape `spec/safe-memory/05-representation.md` decides",
250 "tamnd/rucc#856",
251 ),
252 (Opcode::CapStore, "the same, and a store into the slot beside a pointer", "tamnd/rucc#856"),
253 (
254 Opcode::CapNull,
255 "the same, and it is whatever the representation says nothing is",
256 "tamnd/rucc#856",
257 ),
258 (Opcode::CapNarrow, "the same, and arithmetic on the bounds it holds", "tamnd/rucc#856"),
259 (Opcode::CapRecover, "the same, and a read of the shadow planes", "tamnd/rucc#856"),
260 // The plane writes, which the runtime does for itself today because the only ranges anything
261 // asks about are the ones its own allocator handed out. A stack object needs these.
262 (Opcode::MetaBegin, "a write over a range of the lifetime plane", "tamnd/rucc#856"),
263 (
264 Opcode::MetaEnd,
265 "the same write, with the version bumped past every capability",
266 "tamnd/rucc#856",
267 ),
268 (
269 Opcode::MetaTransfer,
270 "the same, and the state a range is in while a device owns it, which is S2's",
271 "tamnd/rucc#856",
272 ),
273 (
274 Opcode::SafeRegionBegin,
275 "nothing at all, once the count document 10 section 10.2 asks for has been taken",
276 "tamnd/rucc#856",
277 ),
278 (Opcode::SafeRegionEnd, "the same, which is to say nothing", "tamnd/rucc#856"),
279];
280
281/// A width no rule is written at, why, and the issue that closes it.
282///
283/// The other half of coverage, and the half an opcode list cannot say. An opcode is covered when
284/// every name it has is a name a rule is written at, and a width with no name has no names to
285/// check: an `add` of two `__int128`s is not a missing rule for `add`, it is a width the rule
286/// language cannot spell. So the widths are written down here for the same reason the opcodes are
287/// written down above.
288pub static WIDTHS: &[(&str, &str, &str)] = &[
289 (
290 "one bit",
291 "everything but and, or, xor, a constant, and the widening out of one",
292 "tamnd/rucc#352",
293 ),
294 (
295 "a hundred and twenty eight bits",
296 "split into two halves before selection, except a division",
297 "tamnd/rucc#351",
298 ),
299 (
300 "eighty bits",
301 "a long double is on the x87 stack and no rule is about that stack",
302 "tamnd/rucc#326",
303 ),
304 (
305 "a vector of any lane count",
306 "a rule at a width says nothing about how many lanes",
307 "tamnd/rucc#200",
308 ),
309];
310
311/// A name a rule could be written at and deliberately is not, why, and the issue that puts it
312/// back.
313///
314/// The third list, and the one that is about a name rather than about an opcode or a width. An
315/// opcode on [`GAPS`] has no lowering at any width and a width on [`WIDTHS`] has no names at all,
316/// and neither of those can say that `add` is lowered at four widths and left alone at two.
317///
318/// This list used to be all of the narrow arithmetic. C promotes the operands of an arithmetic
319/// operator to `int` before the operator is applied, so `char a, b; a + b` is an `int` addition of
320/// two sign extended chars and there is no C program that asks the back end to add two bytes.
321/// Rules were written at those names anyway, ahead of the pass that would reach them, and they sat
322/// proved and never selected: `tamnd/rucc#261` measured that and `tamnd/rucc#368` took them out.
323/// Most of them are back, because the width narrowing pass in `tamnd/rucc#375` is that caller and
324/// it writes a byte add out of the truncation the assignment back to a `char` already was.
325///
326/// What is left is what the pass will not narrow. A divide is not narrowed because the most
327/// negative byte over minus one is a defined hundred and twenty eight at four bytes and is the
328/// overflow that raises at one, so it wants a range analysis saying that pair cannot happen.
329///
330/// Not every narrow name was ever here, because promotion is not the only way a narrow operation
331/// is born. Reading a bitfield is a shift and a mask by constants at the width of the storage
332/// unit, writing one is a mask, a shift and an `or` of two values, and a truth test on a narrow
333/// scalar is an `icmp_ne` at that scalar's width. Those fire, so those always had rules.
334pub static NAMES: &[(&str, &str, &str)] = &[
335 ("sdiv.i8", "a narrow divide, which wants a range analysis before it can be narrowed", NARROW),
336 ("sdiv.i16", "the same", NARROW),
337 ("udiv.i8", "the same", NARROW),
338 ("udiv.i16", "the same", NARROW),
339 ("srem.i8", "the same", NARROW),
340 ("srem.i16", "the same", NARROW),
341 ("urem.i8", "the same", NARROW),
342 ("urem.i16", "the same", NARROW),
343];
344
345/// The issue every entry of [`NAMES`] waits on, since they all wait on the same one.
346const NARROW: &str = "tamnd/rucc#375";
347
348/// What a target's rules cover, and what they do not.
349#[derive(Debug)]
350pub struct Report {
351 /// The rule file this is about, so that anything said about it names a file to open.
352 pub source: &'static str,
353 /// How many opcodes the IR has.
354 pub opcodes: usize,
355 /// The opcodes every name of which a rule is written at.
356 pub by_rule: Vec<Opcode>,
357 /// How many names those are, which is one per opcode and width.
358 pub names: usize,
359 /// A name a rule could be written at and none is, which is what a missing rule looks like.
360 pub uncovered: Vec<(Opcode, &'static str)>,
361 /// A name on [`NAMES`], which is a missing rule somebody decided to be missing.
362 pub deferred: Vec<(Opcode, &'static str)>,
363 /// A name a rule is written at that nothing can ever be called, which is a dead rule.
364 pub unreachable: Vec<&'static str>,
365 /// The opcodes lowered somewhere a rule cannot reach.
366 pub elsewhere: Vec<Opcode>,
367 /// The opcodes nothing lowers.
368 pub gaps: Vec<Opcode>,
369 /// The opcodes on none of the three lists, which is what a new opcode is until somebody says
370 /// where it goes.
371 pub unaccounted: Vec<Opcode>,
372}
373
374impl fmt::Display for Report {
375 fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
376 write!(
377 f,
378 "rucc-codegen: {} lowers {} of the {} IR opcodes by rule at {} names, {} are lowered \
379 where no rule reaches, {} have no lowering yet and {} names are left for later",
380 self.source,
381 self.by_rule.len(),
382 self.opcodes,
383 self.names,
384 self.elsewhere.len(),
385 self.gaps.len(),
386 self.deferred.len()
387 )
388 }
389}
390
391/// What a table covers.
392///
393/// Nothing is executed and nothing is compiled. The rule set and the naming of instructions are
394/// both data, and the answer is a comparison of two lists.
395#[must_use]
396pub fn report(table: &Table) -> Report {
397 let named = term::heads();
398 let patterns = pattern_heads(table);
399
400 let mut by_rule = Vec::new();
401 let mut uncovered = Vec::new();
402 let mut deferred = Vec::new();
403 for &(opcode, name) in &named {
404 if patterns.contains(&name) {
405 by_rule.push(opcode);
406 } else if NAMES.iter().any(|&(deliberate, ..)| deliberate == name) {
407 deferred.push((opcode, name));
408 } else {
409 uncovered.push((opcode, name));
410 }
411 }
412 // An opcode is covered when every name it has is covered, so one missing width takes the
413 // whole opcode off the list however many of its other widths are there. A name on `NAMES` does
414 // not take it off, because the opcode is lowered and the entry says which widths were left for
415 // later and why: that is a narrower claim than the opcode having nowhere to go, and putting it
416 // on `GAPS` instead would say the wrong thing about an `add` that lowers perfectly well at
417 // four widths.
418 for &(opcode, _) in &uncovered {
419 by_rule.retain(|&covered| covered != opcode);
420 }
421 by_rule.sort_unstable();
422 by_rule.dedup();
423
424 let names = named.len() - uncovered.len() - deferred.len();
425 let unreachable: Vec<&'static str> = patterns
426 .iter()
427 .filter(|head| !named.iter().any(|(_, name)| name == *head))
428 .copied()
429 .collect();
430
431 let elsewhere: Vec<Opcode> = ELSEWHERE.iter().map(|&(opcode, _)| opcode).collect();
432 let gaps: Vec<Opcode> = GAPS.iter().map(|&(opcode, ..)| opcode).collect();
433 let unaccounted: Vec<Opcode> = Opcode::all()
434 .filter(|opcode| {
435 !by_rule.contains(opcode) && !elsewhere.contains(opcode) && !gaps.contains(opcode)
436 })
437 .collect();
438
439 Report {
440 source: table.source,
441 opcodes: Opcode::all().count(),
442 by_rule,
443 names,
444 uncovered,
445 deferred,
446 unreachable,
447 elsewhere,
448 gaps,
449 unaccounted,
450 }
451}
452
453/// Every name a rule in a table is written about, which is the first test the trie makes.
454///
455/// Node zero is the root of the trie over the patterns and the first thing any walk asks is what
456/// the term in hand is called, so its tests are exactly the set of pattern heads. There is no
457/// wildcard there to worry about: a rule matching any term at all is one nobody has written and
458/// one that would be an error to write, since a lowering has to know what it is lowering.
459fn pattern_heads(table: &Table) -> Vec<&'static str> {
460 let Some(root) = table.nodes.first() else { return Vec::new() };
461 let mut found: Vec<&'static str> = root
462 .tests
463 .iter()
464 .filter_map(|(test, _)| match test {
465 Test::App { head, .. } => Some(*head),
466 // Neither can be at the root. A pattern is a term with a head, so the first step of
467 // every one of them is a head, and there is nothing bound yet to be the same as.
468 Test::Int(_) | Test::Same(_) => None,
469 })
470 .collect();
471 found.sort_unstable();
472 found.dedup();
473 found
474}
475
476/// The rules a target lowers by, or `None` where no back end in this crate covers it.
477///
478/// The same question [`crate::pipeline::Machine::for_target`] answers about the rest of a machine,
479/// and it is here as well because a caller that wants to write down what a run covered has a
480/// target and no machine. An architecture that gets a rule file at M6 gets an arm here at the same
481/// time, and until then it has no rules to report coverage of rather than an empty set of them.
482#[must_use]
483pub fn table(arch: Arch) -> Option<&'static Table> {
484 match arch {
485 Arch::X86_64 => Some(&crate::select::x86_64::TABLE),
486 Arch::Aarch64 | Arch::Riscv64 => None,
487 }
488}
489
490/// Which rules fired, over one function or over a whole compilation.
491///
492/// A bit per rule and nothing else. This is on the path of every instruction selected, so what it
493/// costs is paid by every compilation whether or not anybody asked for the number, and the cheapest
494/// thing that answers the question is a flag per rule set once.
495///
496/// The index of a rule is how this is kept and not how it is written down. An index moves the
497/// moment a rule is added above it, so [`Fired::listing`] names the rule file and the line instead:
498/// a line is a place somebody can open, and a report written by one build can still be read against
499/// a rule file that has grown since.
500#[derive(Debug, Clone, Default, PartialEq, Eq)]
501pub struct Fired {
502 /// One entry per rule, true once that rule has fired. It grows to fit the highest index
503 /// marked rather than being sized from a table, so nothing here has to be told which target
504 /// is being compiled for.
505 seen: Vec<bool>,
506}
507
508impl Fired {
509 /// Nothing has fired yet.
510 #[must_use]
511 pub const fn new() -> Fired {
512 Fired { seen: Vec::new() }
513 }
514
515 /// Records that the rule at this index fired.
516 pub fn mark(&mut self, rule: usize) {
517 if self.seen.len() <= rule {
518 self.seen.resize(rule + 1, false);
519 }
520 self.seen[rule] = true;
521 }
522
523 /// Whether the rule at this index fired.
524 #[must_use]
525 pub fn has(&self, rule: usize) -> bool {
526 self.seen.get(rule).copied().unwrap_or(false)
527 }
528
529 /// How many rules fired.
530 #[must_use]
531 pub fn count(&self) -> usize {
532 self.seen.iter().filter(|fired| **fired).count()
533 }
534
535 /// Takes in everything another one recorded.
536 ///
537 /// One compilation is many functions and one command line is many files, and the question is
538 /// about all of them together. Merging rather than writing a file per function is also what
539 /// keeps the answer the same however the work was scheduled.
540 pub fn merge(&mut self, other: &Fired) {
541 if self.seen.len() < other.seen.len() {
542 self.seen.resize(other.seen.len(), false);
543 }
544 for (mine, theirs) in self.seen.iter_mut().zip(&other.seen) {
545 *mine |= *theirs;
546 }
547 }
548
549 /// What `-Zrule-coverage=FILE` writes.
550 ///
551 /// One line per rule in the table, in the order the rule file writes them, each saying whether
552 /// the rule fired and naming the file and line it is written at. Every rule is listed rather
553 /// than only the ones that fired, so that one of these files says what the whole rule set was
554 /// as well as what this compilation reached: a reader unioning them over a corpus needs both
555 /// and would otherwise have to parse the rule file to get the second.
556 ///
557 /// The first line is a comment holding the count, which is the number a person wants and the
558 /// one thing here that is not worth making them add up.
559 #[must_use]
560 pub fn listing(&self, table: &Table) -> String {
561 let fired = table.rules.iter().enumerate().filter(|(index, _)| self.has(*index)).count();
562 let mut out = format!(
563 "# rucc rule coverage: {fired} of {} rules in {} fired\n",
564 table.rules.len(),
565 table.source
566 );
567 for (index, rule) in table.rules.iter().enumerate() {
568 let word = if self.has(index) { "fired" } else { "unused" };
569 let _ = writeln!(out, "{word} {}:{} {}", table.source, rule.line, rule.pattern);
570 }
571 out
572 }
573}
574
575#[cfg(test)]
576mod tests {
577 use super::*;
578 use crate::select::x86_64::TABLE;
579
580 /// The claim the whole module is for, in the direction that matters: a name an instruction
581 /// can be called by is a name a rule is written at. This is the width check as much as the
582 /// opcode check, since a name is an opcode and a width together.
583 #[test]
584 fn every_name_an_instruction_can_have_is_one_a_rule_is_written_at() {
585 let report = report(&TABLE);
586 assert!(
587 report.uncovered.is_empty(),
588 "nothing in {} lowers these, and each is an opcode at a width the rule language can \
589 spell: {:?}",
590 report.source,
591 report.uncovered
592 );
593 }
594
595 /// And the other direction, which costs nothing to ask and finds a rule that can never fire.
596 /// A pattern head no instruction is ever called by is a rule written against a name that was
597 /// renamed or misspelled, and it would sit there proved and unreachable.
598 #[test]
599 fn every_name_a_rule_is_written_at_is_one_an_instruction_can_have() {
600 let report = report(&TABLE);
601 assert!(
602 report.unreachable.is_empty(),
603 "{} has rules for these and no instruction is ever called one: {:?}",
604 report.source,
605 report.unreachable
606 );
607 }
608
609 /// Every opcode is one of the three things, so a new opcode in the IR fails this until
610 /// somebody says where it goes. That is the whole point: the answer for a new opcode should
611 /// be written down when it is added rather than discovered by a user compiling a program.
612 #[test]
613 fn every_opcode_is_lowered_or_is_a_gap_somebody_wrote_down() {
614 let report = report(&TABLE);
615 assert!(
616 report.unaccounted.is_empty(),
617 "no rule lowers these, `ELSEWHERE` does not say where they are lowered and `GAPS` \
618 does not say why they are not: {:?}",
619 report.unaccounted
620 );
621 assert_eq!(
622 report.by_rule.len() + report.elsewhere.len() + report.gaps.len(),
623 report.opcodes,
624 "the three lists overlap, so an opcode is counted twice"
625 );
626 }
627
628 /// An entry that starts being covered fails, which is the rule every list in this project is
629 /// kept under. An opcode a rule now lowers is one that should be off both lists, and a list
630 /// that keeps claiming otherwise is a list nobody can read.
631 #[test]
632 fn an_entry_a_rule_now_covers_is_a_stale_entry() {
633 let report = report(&TABLE);
634 for &(opcode, where_) in ELSEWHERE {
635 assert!(
636 !report.by_rule.contains(&opcode),
637 "`{}` is lowered by a rule now, so the `ELSEWHERE` entry saying it is lowered by \
638 {where_} is stale",
639 opcode.name()
640 );
641 }
642 for &(opcode, why, issue) in GAPS {
643 assert!(
644 !report.by_rule.contains(&opcode),
645 "`{}` is lowered by a rule now, so the `GAPS` entry saying it is {why} is stale \
646 and {issue} may be closed",
647 opcode.name()
648 );
649 assert!(
650 !report.elsewhere.contains(&opcode),
651 "`{}` is on both lists, so it is both lowered and not lowered",
652 opcode.name()
653 );
654 }
655 }
656
657 /// The same staleness rule one list down. A name a rule is written at is a name that is not
658 /// left for later, and an entry claiming otherwise is one that should have gone when the rule
659 /// arrived. The other direction is checked too: a name no instruction can ever have is a
660 /// misspelling, and it would sit here excusing nothing.
661 #[test]
662 fn a_name_a_rule_is_written_at_is_not_a_name_left_for_later() {
663 let heads = pattern_heads(&TABLE);
664 let named = term::heads();
665 for &(name, why, issue) in NAMES {
666 assert!(
667 !heads.contains(&name),
668 "`{name}` is lowered by a rule now, so the `NAMES` entry saying it is {why} is \
669 stale and {issue} may be closer than it says"
670 );
671 assert!(
672 named.iter().any(|&(_, head)| head == name),
673 "`{name}` is not a name any instruction can have, so the `NAMES` entry excuses \
674 nothing"
675 );
676 }
677 let report = report(&TABLE);
678 assert_eq!(report.deferred.len(), NAMES.len(), "{:?}", report.deferred);
679 }
680
681 /// Every gap names an issue, since a gap with no issue behind it is a gap nobody has decided
682 /// anything about, which is the thing this module exists to stop.
683 #[test]
684 fn every_gap_names_the_issue_that_closes_it() {
685 let issues = GAPS
686 .iter()
687 .map(|&(_, _, issue)| issue)
688 .chain(WIDTHS.iter().map(|&(_, _, issue)| issue))
689 .chain(NAMES.iter().map(|&(_, _, issue)| issue));
690 for issue in issues {
691 let number = issue
692 .strip_prefix("tamnd/rucc#")
693 .unwrap_or_else(|| panic!("{issue} is not an issue in this project's tracker"));
694 assert!(number.parse::<u32>().is_ok(), "{issue} does not name an issue number");
695 }
696 }
697
698 /// The count, which `spec/15-testing.md` section 15.8 says we keep about ourselves. CI runs
699 /// this test with the output shown, so the number lands in a log next to the rule proof
700 /// rather than in a file somebody has to go and read.
701 #[test]
702 fn the_count_is_reported() {
703 let report = report(&TABLE);
704 println!("{report}");
705 for &(opcode, why, issue) in GAPS {
706 println!("rucc-codegen: no lowering for `{}`, which is {why}: {issue}", opcode.name());
707 }
708 for &(width, why, issue) in WIDTHS {
709 println!("rucc-codegen: no rule at {width}, which is {why}: {issue}");
710 }
711 for &(name, why, issue) in NAMES {
712 println!("rucc-codegen: no rule at `{name}`, which is {why}: {issue}");
713 }
714 assert_eq!(report.gaps.len(), GAPS.len());
715 }
716
717 /// What the root of the trie is, which is the assumption [`pattern_heads`] rests on. If the
718 /// rule compiler ever built the trie some other way this would say so, rather than the
719 /// coverage numbers quietly becoming a report about an empty list.
720 #[test]
721 fn the_root_of_the_trie_is_the_head_of_every_pattern() {
722 let heads = pattern_heads(&TABLE);
723 assert!(!heads.is_empty(), "the table has rules and the root of the trie tests nothing");
724 for rule in TABLE.rules {
725 let head = rule
726 .pattern
727 .strip_prefix('(')
728 .and_then(|rest| rest.split([' ', ')']).next())
729 .expect("a pattern is an application");
730 assert!(
731 heads.contains(&head),
732 "line {}: {} is a pattern whose head the root of the trie does not test",
733 rule.line,
734 rule.pattern
735 );
736 }
737 }
738
739 /// The one target with a rule file, and the two that get one at M6. A machine that can be
740 /// compiled for has rules to report the coverage of, and one that cannot has none rather than
741 /// an empty set of them, which are different answers and would read the same as a number.
742 #[test]
743 fn a_target_with_a_back_end_is_a_target_with_a_rule_set() {
744 let x86 = table(Arch::X86_64).expect("x86-64 is what this crate lowers for");
745 assert_eq!(x86.source, TABLE.source);
746 assert!(!x86.rules.is_empty());
747 assert!(table(Arch::Aarch64).is_none(), "there is no aarch64 rule file yet");
748 assert!(table(Arch::Riscv64).is_none(), "there is no riscv64 rule file yet");
749 }
750
751 /// What a rule is called outside this process. The index is not it: a rule added at the top of
752 /// the file moves every index below it, and a report from last week would then be a report
753 /// about the wrong rules. The file and the line do not move that way and are somewhere to look.
754 #[test]
755 fn a_rule_is_written_down_as_the_place_it_is_written_at() {
756 let mut fired = Fired::new();
757 fired.mark(0);
758 let listing = fired.listing(&TABLE);
759 let first =
760 format!("fired {}:{} {}", TABLE.source, TABLE.rules[0].line, TABLE.rules[0].pattern);
761 assert!(listing.contains(&first), "{listing}");
762 assert!(listing.lines().next().is_some_and(|line| line.starts_with('#')), "{listing}");
763 }
764
765 /// Every rule is listed and not only the ones that fired, which is what lets one of these files
766 /// be read on its own. A reader that only got the rules that fired would have to parse the rule
767 /// file to find out what the rest of them were.
768 #[test]
769 fn one_file_says_what_the_whole_rule_set_is() {
770 let listing = Fired::new().listing(&TABLE);
771 let lines: Vec<&str> = listing.lines().collect();
772 assert_eq!(lines.len(), TABLE.rules.len() + 1, "one line per rule and one for the count");
773 assert_eq!(
774 lines.iter().filter(|line| line.starts_with("unused ")).count(),
775 TABLE.rules.len()
776 );
777 assert!(lines[0].contains(&format!("0 of {} rules", TABLE.rules.len())), "{}", lines[0]);
778 }
779
780 /// A compilation is many functions and a command line is many files, and the question is about
781 /// all of them at once. Merging is also what keeps the answer the same however the work was
782 /// scheduled, which is the rule `spec/03-architecture.md` section 3.7 holds everything to.
783 #[test]
784 fn what_two_runs_reached_is_what_either_of_them_reached() {
785 let mut one = Fired::new();
786 one.mark(3);
787 one.mark(3);
788 assert_eq!(one.count(), 1, "a rule that fires twice is one rule");
789 let mut two = Fired::new();
790 two.mark(0);
791 two.mark(9);
792 one.merge(&two);
793 assert_eq!(one.count(), 3);
794 assert!(one.has(0) && one.has(3) && one.has(9));
795 assert!(!one.has(1));
796
797 // The merge is symmetric, since neither order of two files is the right one.
798 let mut back = Fired::new();
799 back.mark(0);
800 back.mark(9);
801 let mut three = Fired::new();
802 three.mark(3);
803 back.merge(&three);
804 assert_eq!(back, one);
805 }
806}