rubyfast 1.2.2

An ultra-fast Ruby performance linter rewritten in Rust — detects 19 common anti-patterns
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170

use std::process::Command;

fn cargo_bin() -> Command {
    let mut cmd = Command::new("cargo");
    cmd.args(["run", "--quiet", "--"]);
    cmd
}

#[test]
fn exit_code_0_on_clean_file() {
    let output = cargo_bin()
        .arg("tests/fixtures/clean.rb")
        .output()
        .expect("Failed to run");
    assert!(
        output.status.success(),
        "Expected exit 0, got {}. stderr: {}",
        output.status,
        String::from_utf8_lossy(&output.stderr)
    );
}

#[test]
fn exit_code_1_on_offense() {
    let output = cargo_bin()
        .arg("tests/fixtures/19_for_loop.rb")
        .output()
        .expect("Failed to run");
    assert_eq!(
        output.status.code(),
        Some(1),
        "Expected exit 1. stdout: {}",
        String::from_utf8_lossy(&output.stdout)
    );
}

#[test]
fn nonexistent_path_prints_error() {
    let output = cargo_bin()
        .arg("/nonexistent/path")
        .output()
        .expect("Failed to run");
    assert!(!output.status.success());
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(
        stderr.contains("No such file or directory"),
        "Expected 'No such file or directory' in stderr: {}",
        stderr
    );
}

#[test]
fn scans_directory_recursively() {
    let output = cargo_bin()
        .arg("tests/fixtures")
        .output()
        .expect("Failed to run");
    let stdout = String::from_utf8_lossy(&output.stdout);
    // Should find offenses across multiple files
    assert!(stdout.contains("offenses detected"), "stdout: {}", stdout);
    assert!(stdout.contains("files inspected"), "stdout: {}", stdout);
}

#[test]
fn statistics_line_present() {
    let output = cargo_bin()
        .arg("tests/fixtures/clean.rb")
        .output()
        .expect("Failed to run");
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(
        stdout.contains("1 file inspected"),
        "Expected '1 file inspected' in: {}",
        stdout
    );
    assert!(
        stdout.contains("0 offenses detected"),
        "Expected '0 offenses detected' in: {}",
        stdout
    );
}

#[test]
fn format_rule_output() {
    let output = cargo_bin()
        .args(["tests/fixtures/19_for_loop.rb", "--format", "rule"])
        .output()
        .expect("Failed to run");
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(
        stdout.contains("offense"),
        "Expected offense count in rule output: {}",
        stdout
    );
}

#[test]
fn format_plain_output() {
    let output = cargo_bin()
        .args(["tests/fixtures/19_for_loop.rb", "--format", "plain"])
        .output()
        .expect("Failed to run");
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(
        stdout.contains("19_for_loop.rb:"),
        "Expected path:line format in plain output: {}",
        stdout
    );
}

#[test]
fn fix_mode_modifies_file() {
    let dir = tempfile::TempDir::new().unwrap();
    let file = dir.path().join("fixable.rb");
    std::fs::write(&file, "for x in [1,2,3]; puts x; end\n").unwrap();
    let output = cargo_bin()
        .args([file.to_str().unwrap(), "--fix"])
        .output()
        .expect("Failed to run");
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(
        stdout.contains("fixed"),
        "Expected 'fixed' in fix output: {}",
        stdout
    );
    let content = std::fs::read_to_string(&file).unwrap();
    assert!(
        content.contains(".each do"),
        "Expected file to be fixed: {}",
        content
    );
}

#[test]
fn fix_mode_reports_unfixable() {
    let dir = tempfile::TempDir::new().unwrap();
    let file = dir.path().join("unfixable.rb");
    // sort with block is unfixable
    std::fs::write(&file, "arr.sort { |a, b| a <=> b }\n").unwrap();
    let output = cargo_bin()
        .args([file.to_str().unwrap(), "--fix"])
        .output()
        .expect("Failed to run");
    let stdout = String::from_utf8_lossy(&output.stdout);
    assert!(
        stdout.contains("cannot be auto-fixed") || stdout.contains("0 offenses fixed"),
        "Expected unfixable note in output: {}",
        stdout
    );
}

#[test]
fn config_disables_rule() {
    let dir = tempfile::TempDir::new().unwrap();
    std::fs::write(dir.path().join("test.rb"), "for x in [1]; end\n").unwrap();
    std::fs::write(
        dir.path().join(".rubyfast.yml"),
        "speedups:\n  for_loop_vs_each: false\n",
    )
    .unwrap();
    let output = cargo_bin()
        .arg(dir.path().to_str().unwrap())
        .output()
        .expect("Failed to run");
    assert!(
        output.status.success(),
        "Expected exit 0 when rule is disabled. stdout: {}",
        String::from_utf8_lossy(&output.stdout)
    );
}