rtp-engine 0.1.0

A pure Rust RTP media engine with codecs, SRTP, and audio device abstraction
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
//! Media session management.
//!
//! The `MediaSession` struct orchestrates the complete audio pipeline:
//! microphone capture → encoding → RTP transmission → reception → decoding → speaker playback.

use std::net::SocketAddr;
use std::sync::Arc;
use std::sync::atomic::{AtomicBool, Ordering};
use tokio::net::UdpSocket;

use crate::codec::{AudioDecoder, AudioEncoder, CodecType, create_decoder, create_encoder};
use crate::error::{Error, Result};
use crate::resample::{f32_to_i16, i16_to_f32, resample_linear};
use crate::rtp::{
    RtpCounters, RtpHeader, RtpStats, build_rtcp_rr, build_rtcp_sr, parse_rtp, parse_sequence,
    parse_timestamp,
};

#[cfg(feature = "srtp")]
use crate::srtp::SrtpContext;

#[cfg(feature = "device")]
use cpal::traits::{DeviceTrait, HostTrait, StreamTrait};

type SharedSrtp = Arc<std::sync::Mutex<SrtpContext>>;

/// A complete RTP media session with bidirectional audio.
///
/// Manages:
/// - Audio capture from microphone
/// - Encoding with the configured codec
/// - RTP packet transmission
/// - RTP packet reception
/// - Decoding and playback to speaker
/// - RTCP statistics reporting
pub struct MediaSession {
    muted: Arc<AtomicBool>,
    running: Arc<AtomicBool>,
    counters: RtpCounters,
    codec: CodecType,
    learned_remote: Arc<std::sync::Mutex<Option<SocketAddr>>>,
    rtp_socket: Arc<UdpSocket>,
    ssrc: u32,
    remote_addr: SocketAddr,
}

impl MediaSession {
    /// Start a media session with the specified codec.
    ///
    /// # Arguments
    /// * `local_rtp_port` - Local UDP port for RTP
    /// * `remote_addr` - Remote RTP endpoint address
    /// * `codec_type` - Audio codec to use
    pub async fn start(
        local_rtp_port: u16,
        remote_addr: SocketAddr,
        codec_type: CodecType,
    ) -> Result<Self> {
        Self::start_internal(local_rtp_port, remote_addr, codec_type, None).await
    }

    /// Start a media session with SRTP encryption.
    #[cfg(feature = "srtp")]
    pub async fn start_with_srtp(
        local_rtp_port: u16,
        remote_addr: SocketAddr,
        codec_type: CodecType,
        srtp_ctx: SrtpContext,
    ) -> Result<Self> {
        Self::start_internal(local_rtp_port, remote_addr, codec_type, Some(srtp_ctx)).await
    }

    async fn start_internal(
        local_rtp_port: u16,
        remote_addr: SocketAddr,
        codec_type: CodecType,
        #[allow(unused_variables)] srtp_ctx: Option<SrtpContext>,
    ) -> Result<Self> {
        let rtp_socket = UdpSocket::bind(format!("0.0.0.0:{}", local_rtp_port))
            .await
            .map_err(|e| Error::Network(e))?;

        let rtp_socket = Arc::new(rtp_socket);
        let muted = Arc::new(AtomicBool::new(false));
        let running = Arc::new(AtomicBool::new(true));
        let ssrc: u32 = rand::random();
        let counters = RtpCounters::new(codec_type.name());
        let learned_remote: Arc<std::sync::Mutex<Option<SocketAddr>>> =
            Arc::new(std::sync::Mutex::new(None));

        let encoder = create_encoder(codec_type)?;
        let decoder = create_decoder(codec_type)?;

        #[cfg(feature = "srtp")]
        let shared_srtp: Option<SharedSrtp> =
            srtp_ctx.map(|ctx| Arc::new(std::sync::Mutex::new(ctx)));
        #[cfg(not(feature = "srtp"))]
        let shared_srtp: Option<SharedSrtp> = None;

        // RTCP socket (RTP port + 1)
        let rtcp_port = local_rtp_port + 1;
        let rtcp_socket = UdpSocket::bind(format!("0.0.0.0:{}", rtcp_port))
            .await
            .map_err(|e| Error::Network(e))?;
        let rtcp_socket = Arc::new(rtcp_socket);
        let remote_rtcp_addr: SocketAddr =
            format!("{}:{}", remote_addr.ip(), remote_addr.port() + 1)
                .parse()
                .unwrap_or(remote_addr);

        // Start TX thread (microphone → RTP)
        #[cfg(feature = "device")]
        {
            let tx_socket = rtp_socket.clone();
            let tx_muted = muted.clone();
            let tx_running = running.clone();
            let tx_counters = counters.clone();
            let tx_learned = learned_remote.clone();
            let tx_srtp = shared_srtp.clone();

            std::thread::spawn(move || {
                if let Err(e) = run_audio_tx(
                    tx_socket,
                    remote_addr,
                    ssrc,
                    tx_muted,
                    tx_running,
                    encoder,
                    tx_counters,
                    tx_learned,
                    tx_srtp,
                ) {
                    log::error!("Audio TX error: {}", e);
                }
            });
        }

        // Start RX thread (RTP → speaker)
        #[cfg(feature = "device")]
        {
            let rx_socket = rtp_socket.clone();
            let rx_running = running.clone();
            let rx_counters = counters.clone();
            let rx_learned = learned_remote.clone();
            let rx_srtp = shared_srtp.clone();

            std::thread::spawn(move || {
                if let Err(e) = run_audio_rx(
                    rx_socket,
                    rx_running,
                    decoder,
                    rx_counters,
                    rx_learned,
                    rx_srtp,
                ) {
                    log::error!("Audio RX error: {}", e);
                }
            });
        }

        // Start RTCP task
        {
            let rtcp_running = running.clone();
            let rtcp_counters = counters.clone();
            let rtcp_srtp = shared_srtp;
            tokio::spawn(async move {
                run_rtcp(
                    rtcp_socket,
                    remote_rtcp_addr,
                    ssrc,
                    rtcp_running,
                    rtcp_counters,
                    rtcp_srtp,
                )
                .await;
            });
        }

        log::info!(
            "Media session started: local RTP :{}, remote {}, codec {:?}",
            local_rtp_port,
            remote_addr,
            codec_type,
        );

        Ok(Self {
            muted,
            running,
            counters,
            codec: codec_type,
            learned_remote,
            rtp_socket,
            ssrc,
            remote_addr,
        })
    }

    /// Send an RFC 2833 DTMF digit.
    pub fn send_dtmf(&self, digit: &str) {
        let event_code: u8 = match digit {
            "0" => 0,
            "1" => 1,
            "2" => 2,
            "3" => 3,
            "4" => 4,
            "5" => 5,
            "6" => 6,
            "7" => 7,
            "8" => 8,
            "9" => 9,
            "*" => 10,
            "#" => 11,
            _ => {
                log::warn!("Unknown DTMF digit: {}", digit);
                return;
            }
        };

        let socket = self.rtp_socket.clone();
        let ssrc = self.ssrc;
        let dest = self
            .learned_remote
            .lock()
            .ok()
            .and_then(|g| *g)
            .unwrap_or(self.remote_addr);
        let counters = self.counters.clone();

        tokio::spawn(async move {
            let base_ts: u32 = rand::random();
            let base_seq: u16 = rand::random();
            let volume: u8 = 10;
            let pt: u8 = 101;
            let durations = [160u16, 320, 480];

            for (i, &duration) in durations.iter().enumerate() {
                let is_end = i == durations.len() - 1;
                let seq = base_seq.wrapping_add(i as u16);

                let mut packet = Vec::with_capacity(16);
                packet.push(0x80);
                let marker = if i == 0 { 0x80 } else { 0x00 };
                packet.push(pt | marker);
                packet.extend_from_slice(&seq.to_be_bytes());
                packet.extend_from_slice(&base_ts.to_be_bytes());
                packet.extend_from_slice(&ssrc.to_be_bytes());

                let end_flag: u8 = if is_end { 0x80 } else { 0x00 };
                packet.push(event_code);
                packet.push(end_flag | (volume & 0x3F));
                packet.extend_from_slice(&duration.to_be_bytes());

                let _ = socket.send_to(&packet, dest).await;
                counters.record_sent(packet.len() as u64);

                if is_end {
                    for _ in 0..2 {
                        let repeat_seq = seq.wrapping_add(1);
                        packet[2..4].copy_from_slice(&repeat_seq.to_be_bytes());
                        let _ = socket.send_to(&packet, dest).await;
                    }
                }

                tokio::time::sleep(std::time::Duration::from_millis(20)).await;
            }
        });
    }

    /// Set mute state.
    pub fn set_mute(&self, mute: bool) {
        self.muted.store(mute, Ordering::Relaxed);
    }

    /// Check if muted.
    pub fn is_muted(&self) -> bool {
        self.muted.load(Ordering::Relaxed)
    }

    /// Get current statistics.
    pub fn stats(&self) -> RtpStats {
        self.counters.snapshot()
    }

    /// Get the codec in use.
    pub fn codec(&self) -> CodecType {
        self.codec
    }

    /// Get the SSRC.
    pub fn ssrc(&self) -> u32 {
        self.ssrc
    }

    /// Get the remote address.
    pub fn remote_addr(&self) -> SocketAddr {
        self.remote_addr
    }

    /// Get the learned remote address (for symmetric RTP/comedia).
    pub fn learned_remote(&self) -> Option<SocketAddr> {
        self.learned_remote.lock().ok().and_then(|g| *g)
    }

    /// Stop the media session.
    pub fn stop(&self) {
        self.running.store(false, Ordering::Relaxed);
        log::info!("Media session stopped");
    }
}

impl Drop for MediaSession {
    fn drop(&mut self) {
        self.stop();
    }
}

impl std::fmt::Debug for MediaSession {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("MediaSession")
            .field("codec", &self.codec)
            .field("ssrc", &self.ssrc)
            .field("remote_addr", &self.remote_addr)
            .field("muted", &self.muted.load(Ordering::Relaxed))
            .field("running", &self.running.load(Ordering::Relaxed))
            .finish()
    }
}

// --- Audio TX/RX implementation ---

#[cfg(feature = "device")]
fn run_audio_tx(
    socket: Arc<UdpSocket>,
    remote: SocketAddr,
    ssrc: u32,
    muted: Arc<AtomicBool>,
    running: Arc<AtomicBool>,
    encoder: Box<dyn AudioEncoder>,
    counters: RtpCounters,
    learned_remote: Arc<std::sync::Mutex<Option<SocketAddr>>>,
    _srtp: Option<SharedSrtp>,
) -> Result<()> {
    use std::sync::atomic::AtomicU16;

    let host = cpal::default_host();
    let device = host
        .default_input_device()
        .ok_or_else(|| Error::device("No input device"))?;

    let default_config = device
        .default_input_config()
        .map_err(|e| Error::device(format!("No input config: {}", e)))?;

    let native_rate = default_config.sample_rate();
    log::info!("Audio TX: native rate = {} Hz", native_rate);

    let config = cpal::StreamConfig {
        channels: 1,
        sample_rate: default_config.sample_rate(),
        buffer_size: cpal::BufferSize::Default,
    };

    let codec_rate = 8000u32;
    let resample_ratio = codec_rate as f64 / native_rate as f64;

    let rt = tokio::runtime::Handle::current();
    let seq = Arc::new(AtomicU16::new(0));
    let ts = Arc::new(std::sync::atomic::AtomicU32::new(0));
    let pt = encoder.payload_type();
    let encoder = Arc::new(std::sync::Mutex::new(encoder));
    let sample_buffer = Arc::new(std::sync::Mutex::new(Vec::<f32>::with_capacity(1024)));
    let samples_per_frame = 160usize;

    let cb_running = running.clone();
    let stream = device
        .build_input_stream(
            &config,
            move |data: &[f32], _: &cpal::InputCallbackInfo| {
                if !cb_running.load(Ordering::Relaxed) || muted.load(Ordering::Relaxed) {
                    return;
                }

                let mut buffer = match sample_buffer.lock() {
                    Ok(b) => b,
                    Err(_) => return,
                };
                buffer.extend_from_slice(data);

                let native_samples_per_frame =
                    ((samples_per_frame as f64) / resample_ratio).ceil() as usize;

                while buffer.len() >= native_samples_per_frame {
                    let chunk: Vec<f32> = buffer.drain(..native_samples_per_frame).collect();
                    let resampled = resample_linear(&chunk, native_rate, codec_rate);
                    let pcm = f32_to_i16(&resampled);

                    let current_seq = seq.fetch_add(1, Ordering::Relaxed);
                    let current_ts = ts.fetch_add(samples_per_frame as u32, Ordering::Relaxed);

                    let header = RtpHeader::new(pt, current_seq, current_ts, ssrc);
                    let mut packet = header.to_bytes();

                    if let Ok(mut enc) = encoder.lock() {
                        enc.encode(&pcm, &mut packet);
                    }

                    #[cfg(feature = "srtp")]
                    let send_packet = if let Some(ref srtp_ctx) = _srtp {
                        match srtp_ctx.lock() {
                            Ok(mut ctx) => match ctx.protect_rtp(&packet) {
                                Ok(encrypted) => encrypted,
                                Err(e) => {
                                    log::error!("SRTP protect failed: {}", e);
                                    continue;
                                }
                            },
                            Err(_) => packet,
                        }
                    } else {
                        packet
                    };

                    #[cfg(not(feature = "srtp"))]
                    let send_packet = packet;

                    counters.record_sent(send_packet.len() as u64);

                    let dest = learned_remote
                        .lock()
                        .ok()
                        .and_then(|g| *g)
                        .unwrap_or(remote);
                    let socket = socket.clone();
                    rt.spawn(async move {
                        let _ = socket.send_to(&send_packet, dest).await;
                    });
                }
            },
            |err| log::error!("Audio input error: {}", err),
            None,
        )
        .map_err(|e| Error::device(format!("Failed to build input stream: {}", e)))?;

    stream
        .play()
        .map_err(|e| Error::device(format!("Failed to start input: {}", e)))?;

    while running.load(Ordering::Relaxed) {
        std::thread::sleep(std::time::Duration::from_millis(50));
    }

    drop(stream);
    Ok(())
}

#[cfg(feature = "device")]
fn run_audio_rx(
    socket: Arc<UdpSocket>,
    running: Arc<AtomicBool>,
    mut decoder: Box<dyn AudioDecoder>,
    counters: RtpCounters,
    learned_remote: Arc<std::sync::Mutex<Option<SocketAddr>>>,
    _srtp: Option<SharedSrtp>,
) -> Result<()> {
    use std::collections::VecDeque;

    let host = cpal::default_host();
    let device = host
        .default_output_device()
        .ok_or_else(|| Error::device("No output device"))?;

    let default_config = device
        .default_output_config()
        .map_err(|e| Error::device(format!("No output config: {}", e)))?;

    let native_rate = default_config.sample_rate();
    log::info!("Audio RX: native rate = {} Hz", native_rate);

    let config = cpal::StreamConfig {
        channels: 1,
        sample_rate: default_config.sample_rate(),
        buffer_size: cpal::BufferSize::Default,
    };

    let codec_rate = 8000u32;

    let sample_buffer: Arc<std::sync::Mutex<VecDeque<f32>>> = Arc::new(std::sync::Mutex::new(
        VecDeque::with_capacity(native_rate as usize),
    ));
    let rx_buffer = sample_buffer.clone();

    let stream = device
        .build_output_stream(
            &config,
            move |data: &mut [f32], _: &cpal::OutputCallbackInfo| {
                if let Ok(mut buffer) = rx_buffer.lock() {
                    for out in data.iter_mut() {
                        *out = buffer.pop_front().unwrap_or(0.0);
                    }
                } else {
                    for out in data.iter_mut() {
                        *out = 0.0;
                    }
                }
            },
            |err| log::error!("Audio output error: {}", err),
            None,
        )
        .map_err(|e| Error::device(format!("Failed to build output stream: {}", e)))?;

    stream
        .play()
        .map_err(|e| Error::device(format!("Failed to start output: {}", e)))?;

    let rt = tokio::runtime::Builder::new_current_thread()
        .enable_all()
        .build()
        .map_err(|e| Error::device(format!("Failed to create runtime: {}", e)))?;

    rt.block_on(async {
        let mut buf = [0u8; 2048];
        let mut last_transit: Option<i64> = None;
        let mut first_seq: Option<u16> = None;

        while running.load(Ordering::Relaxed) {
            let recv = tokio::time::timeout(
                std::time::Duration::from_millis(100),
                socket.recv_from(&mut buf),
            )
            .await;

            match recv {
                Ok(Ok((len, from_addr))) => {
                    // Learn remote address for symmetric RTP
                    if let Ok(mut lr) = learned_remote.lock()
                        && lr.is_none()
                    {
                        log::info!("Comedia: learned remote RTP address {}", from_addr);
                        *lr = Some(from_addr);
                    }

                    #[cfg(feature = "srtp")]
                    let rtp_data: Vec<u8> = if let Some(ref srtp_ctx) = _srtp {
                        match srtp_ctx.lock() {
                            Ok(mut ctx) => match ctx.unprotect_rtp(&buf[..len]) {
                                Ok(decrypted) => decrypted,
                                Err(e) => {
                                    log::warn!("SRTP unprotect failed: {}", e);
                                    continue;
                                }
                            },
                            Err(_) => buf[..len].to_vec(),
                        }
                    } else {
                        buf[..len].to_vec()
                    };

                    #[cfg(not(feature = "srtp"))]
                    let rtp_data: Vec<u8> = buf[..len].to_vec();

                    // Track stats
                    if let Some(seq) = parse_sequence(&rtp_data) {
                        if first_seq.is_none() {
                            first_seq = Some(seq);
                        }
                        counters.record_received(len as u64, seq);
                    }

                    // Jitter calculation
                    if let Some(rtp_ts) = parse_timestamp(&rtp_data) {
                        let arrival = std::time::SystemTime::now()
                            .duration_since(std::time::UNIX_EPOCH)
                            .unwrap_or_default()
                            .as_micros() as i64;
                        let transit = arrival - (rtp_ts as i64 * 125);
                        if let Some(prev) = last_transit {
                            let d = (transit - prev).unsigned_abs();
                            counters.update_jitter(d);
                        }
                        last_transit = Some(transit);
                    }

                    // Decode and play
                    if let Some((_, payload)) = parse_rtp(&rtp_data) {
                        let mut pcm = Vec::with_capacity(payload.len());
                        decoder.decode(payload, &mut pcm);

                        let f32_samples = i16_to_f32(&pcm);
                        let resampled = resample_linear(&f32_samples, codec_rate, native_rate);

                        if let Ok(mut buffer) = sample_buffer.lock() {
                            for s in resampled {
                                buffer.push_back(s);
                            }
                            while buffer.len() > native_rate as usize {
                                buffer.pop_front();
                            }
                        }
                    }
                }
                Ok(Err(e)) => {
                    log::error!("RTP recv error: {}", e);
                }
                Err(_) => {} // Timeout
            }
        }
    });

    drop(stream);
    Ok(())
}

async fn run_rtcp(
    socket: Arc<UdpSocket>,
    remote_addr: SocketAddr,
    ssrc: u32,
    running: Arc<AtomicBool>,
    counters: RtpCounters,
    _srtp: Option<SharedSrtp>,
) {
    let mut remote_ssrc: u32 = 0;
    let mut buf = [0u8; 512];

    while running.load(Ordering::Relaxed) {
        tokio::time::sleep(std::time::Duration::from_secs(5)).await;
        if !running.load(Ordering::Relaxed) {
            break;
        }

        // Send Sender Report
        let stats = counters.snapshot();
        let sr = build_rtcp_sr(ssrc, stats.packets_sent as u32, stats.bytes_sent as u32);

        #[cfg(feature = "srtp")]
        let sr_to_send = if let Some(ref srtp_ctx) = _srtp {
            match srtp_ctx.lock() {
                Ok(mut ctx) => ctx.protect_rtcp(&sr).unwrap_or(sr),
                Err(_) => sr,
            }
        } else {
            sr
        };

        #[cfg(not(feature = "srtp"))]
        let sr_to_send = sr;

        let _ = socket.send_to(&sr_to_send, remote_addr).await;

        // Send Receiver Report if we know remote SSRC
        if remote_ssrc != 0 {
            let received = stats.packets_received;
            let expected = counters.expected_packets.load(Ordering::Relaxed);
            let lost = expected.saturating_sub(received);
            let loss_fraction = if expected > 0 {
                ((lost * 256) / expected) as u8
            } else {
                0
            };
            let rr = build_rtcp_rr(
                ssrc,
                remote_ssrc,
                loss_fraction,
                lost as u32,
                counters.highest_seq.load(Ordering::Relaxed),
                (counters.jitter_us.load(Ordering::Relaxed) / 125) as u32,
            );

            #[cfg(feature = "srtp")]
            let rr_to_send = if let Some(ref srtp_ctx) = _srtp {
                match srtp_ctx.lock() {
                    Ok(mut ctx) => ctx.protect_rtcp(&rr).unwrap_or(rr),
                    Err(_) => rr,
                }
            } else {
                rr
            };

            #[cfg(not(feature = "srtp"))]
            let rr_to_send = rr;

            let _ = socket.send_to(&rr_to_send, remote_addr).await;
        }

        // Receive RTCP
        if let Ok(Ok((len, _))) = tokio::time::timeout(
            std::time::Duration::from_millis(50),
            socket.recv_from(&mut buf),
        )
        .await
        {
            #[cfg(feature = "srtp")]
            let rtcp_data: Vec<u8> = if let Some(ref srtp_ctx) = _srtp {
                match srtp_ctx.lock() {
                    Ok(mut ctx) => ctx
                        .unprotect_rtcp(&buf[..len])
                        .unwrap_or_else(|_| buf[..len].to_vec()),
                    Err(_) => buf[..len].to_vec(),
                }
            } else {
                buf[..len].to_vec()
            };

            #[cfg(not(feature = "srtp"))]
            let rtcp_data: Vec<u8> = buf[..len].to_vec();

            if rtcp_data.len() >= 8 && (rtcp_data[1] == 200 || rtcp_data[1] == 201) {
                remote_ssrc =
                    u32::from_be_bytes([rtcp_data[4], rtcp_data[5], rtcp_data[6], rtcp_data[7]]);
            }
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::net::{IpAddr, Ipv4Addr};

    #[test]
    fn test_codec_type_properties() {
        // Test that codec type constants are correct
        assert_eq!(CodecType::Pcmu.payload_type(), 0);
        assert_eq!(CodecType::Pcma.payload_type(), 8);
        assert_eq!(CodecType::Pcmu.clock_rate(), 8000);
        assert_eq!(CodecType::Pcmu.samples_per_frame(), 160);
    }

    #[tokio::test]
    async fn test_media_session_start_invalid_port() {
        // Try to bind to a privileged port (requires root)
        let remote = SocketAddr::new(IpAddr::V4(Ipv4Addr::LOCALHOST), 5000);
        let result = MediaSession::start(80, remote, CodecType::Pcmu).await;

        // Should fail on non-root systems
        // This tests error handling path
        if result.is_err() {
            assert!(matches!(result, Err(Error::Network(_))));
        }
    }

    #[tokio::test]
    async fn test_media_session_basic_creation() {
        // Use a random high port to avoid conflicts
        let port = 50000 + (rand::random::<u16>() % 10000);
        let remote = SocketAddr::new(IpAddr::V4(Ipv4Addr::LOCALHOST), 5000);

        // This will fail in CI without audio devices, but tests the creation path
        let result = MediaSession::start(port, remote, CodecType::Pcmu).await;

        // In environments without audio, this fails at device setup
        // In environments with audio, it succeeds
        // Either way, we're testing the code path
        match result {
            Ok(session) => {
                // Session created successfully
                assert!(!session.is_muted());
                session.stop();
            }
            Err(e) => {
                // Expected on CI without audio devices
                assert!(
                    matches!(e, Error::Device(_)) || matches!(e, Error::Network(_)),
                    "Unexpected error type: {:?}",
                    e
                );
            }
        }
    }

    #[test]
    fn test_rtp_counters_initialization() {
        let counters = RtpCounters::new("PCMU");
        let stats = counters.snapshot();

        assert_eq!(stats.packets_sent, 0);
        assert_eq!(stats.bytes_sent, 0);
        assert_eq!(stats.packets_received, 0);
        assert_eq!(stats.packets_lost, 0);
    }

    #[test]
    fn test_socket_addr_creation() {
        let addr = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(192, 168, 1, 100)), 5060);
        assert_eq!(addr.port(), 5060);
        assert_eq!(addr.ip(), IpAddr::V4(Ipv4Addr::new(192, 168, 1, 100)));
    }

    #[test]
    fn test_create_encoder_decoder() {
        // Test encoder creation
        let encoder = create_encoder(CodecType::Pcmu);
        assert!(encoder.is_ok());

        let encoder = create_encoder(CodecType::Pcma);
        assert!(encoder.is_ok());

        // Test decoder creation
        let decoder = create_decoder(CodecType::Pcmu);
        assert!(decoder.is_ok());

        let decoder = create_decoder(CodecType::Pcma);
        assert!(decoder.is_ok());
    }

    #[cfg(feature = "srtp")]
    #[test]
    fn test_srtp_context_for_session() {
        use crate::srtp::SrtpContext;

        let (_ctx, key) = SrtpContext::generate().unwrap();
        assert!(!key.is_empty());

        // Context should be able to protect/unprotect
        let mut test_rtp = vec![
            0x80, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0xA0, 0x12, 0x34, 0x56, 0x78,
        ];
        test_rtp.extend_from_slice(&[0xDE, 0xAD, 0xBE, 0xEF]);

        let mut ctx_clone = SrtpContext::from_base64(&key).unwrap();
        let protected = ctx_clone.protect_rtp(&test_rtp);
        assert!(protected.is_ok());
    }
}