rsomics-fastq-correct 0.1.0

FASTQ k-mer-spectrum substitution-error correction. Independent Rust port of BFC (lh3): trusted-k-mer threshold + best-first correction walk. SE and PE.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
//! BFC read-correction core — port of `correct.c` (lh3/bfc, MIT).

use crate::CorrectConfig;
use crate::count::CountTable;
use rsomics_seqio::OwnedRecord;

use crate::kmer::BfcKmer;

const EC_HIST: usize = 5;
const EC_HIST_HIGH: usize = 2;
const MAX_PATHS: usize = 4;

/// fastp/BFC base codes: 0..=3 = A,C,G,T; 4 = ambiguous (N).
pub(crate) const SEQ_NT4: [u8; 256] = build_nt4();

const fn build_nt4() -> [u8; 256] {
    let mut t = [4u8; 256];
    t[b'A' as usize] = 0;
    t[b'a' as usize] = 0;
    t[b'C' as usize] = 1;
    t[b'c' as usize] = 1;
    t[b'G' as usize] = 2;
    t[b'g' as usize] = 2;
    t[b'T' as usize] = 3;
    t[b't' as usize] = 3;
    t
}

const W_EC: i32 = 1;
const W_EC_HIGH: i32 = 7;
const W_ABSENT: i32 = 3;
const W_ABSENT_HIGH: i32 = 1;

/// One base in the ec working sequence — BFC `ecbase_t` (`b`/`ob` current
/// & original base, `q`/`oq` quality bit, `lcov`/`hcov` solid coverage,
/// the solid/high end flags).
#[derive(Clone, Copy, Default)]
pub(crate) struct EcBase {
    pub(crate) b: u8,
    pub(crate) ob: u8,
    pub(crate) q: u8,
    pub(crate) oq: u8,
    pub(crate) lcov: i32,
    pub(crate) hcov: i32,
    pub(crate) solid_end: bool,
    pub(crate) high_end: bool,
}

pub(crate) fn seq_conv(seq: &[u8], qual: &[u8], qthres: u8) -> Vec<EcBase> {
    seq.iter()
        .enumerate()
        .map(|(i, &s)| {
            let b = SEQ_NT4[s as usize];
            let mut q = u8::from(qual.is_empty() || qual[i].saturating_sub(33) >= qthres);
            if b > 3 {
                q = 0;
            }
            EcBase {
                b,
                ob: b,
                q,
                oq: q,
                ..EcBase::default()
            }
        })
        .collect()
}

#[inline]
fn comp_base(b: u8) -> u8 {
    if b < 4 { 3 - b } else { 4 }
}

fn revcomp(s: &mut [EcBase]) {
    s.reverse();
    for c in s.iter_mut() {
        c.b = comp_base(c.b);
        c.ob = comp_base(c.ob);
    }
}

/// BFC `bfc_ec_kcov`: mark each base's solid/high-end flags and accumulate
/// `lcov`/`hcov` over the k-mers covering it.
fn ec_kcov(k: usize, min_occ: i32, s: &mut [EcBase], ch: &CountTable) {
    let mut x = BfcKmer::NULL;
    let mut l = 0usize;
    for i in 0..s.len() {
        s[i].high_end = false;
        s[i].solid_end = false;
        s[i].lcov = 0;
        s[i].hcov = 0;
        if s[i].b < 4 {
            x.append(k, u64::from(s[i].b));
            l += 1;
            if l >= k {
                let r = ch.occ(&x);
                if i32::from(r.hi) > min_occ {
                    s[i].high_end = true;
                }
                if i32::from(r.cov) >= min_occ {
                    s[i].solid_end = true;
                    let he = i32::from(s[i].high_end);
                    for j in (i + 1 - k)..=i {
                        s[j].lcov += 1;
                        s[j].hcov += he;
                    }
                }
            }
        } else {
            l = 0;
            x = BfcKmer::NULL;
        }
    }
}

/// BFC `bfc_ec_best_island`: longest run of `solid_end` k-mers. Returns
/// `Some((start, end))` (the C `max_i-max-k+1 .. max_i` half-open) or
/// `None` for no solid k-mer. Call after [`ec_kcov`].
pub(crate) fn best_island(k: usize, s: &[EcBase]) -> Option<(usize, usize)> {
    let (mut max, mut l) = (0i64, 0i64);
    let mut max_i: i64 = -1;
    let n = s.len();
    for i in (k - 1)..n {
        if s[i].solid_end {
            l += 1;
        } else {
            if l > max {
                max = l;
                max_i = i as i64;
            }
            l = 0;
        }
    }
    if l > max {
        max = l;
        max_i = n as i64;
    }
    if max == 0 {
        return None;
    }
    // BFC `bfc_ec_best_island`: start = first base the solid run covers =
    // (first solid k-mer index) - k + 1. Signed like the C int math; the
    // solid-end ⟹ index ≥ k-1 invariant makes this ≥ 0.
    let start = max_i - max - k as i64 + 1;
    debug_assert!(
        start >= 0,
        "best_island start<0: start={start} max_i={max_i} max={max} k={k} n={n}"
    );
    Some((start.max(0) as usize, max_i as usize))
}

/// BFC `bfc_ec_first_kmer`: scan from `start` for the first window of `k`
/// consecutive non-N bases. Returns `(i, x)` where `i` is the index of the
/// k-th base (the k-mer's 3' end), or `s.len()` if no such window exists.
fn ec_first_kmer(k: usize, s: &[EcBase], start: usize) -> (usize, BfcKmer) {
    let mut x = BfcKmer::NULL;
    let mut l = 0usize;
    let mut i = start;
    while i < s.len() {
        if s[i].b < 4 {
            x.append(k, u64::from(s[i].b));
            l += 1;
            if l == k {
                break;
            }
        } else {
            l = 0;
            x = BfcKmer::NULL;
        }
        i += 1;
    }
    (i, x)
}

/// BFC `bfc_ec_greedy_k`: try every single-base substitution of `x`; if
/// exactly one alternative k-mer is strongly supported (best coverage
/// `> mode/3` and second-best `< 3`), return `pos<<2 | base` (pos counted
/// from the 3' end), else `-1`. Rescues reads with no solid island but one
/// confident single error in the first clean k-mer window.
pub(crate) fn bfc_ec_greedy_k(k: usize, mode: i32, x: &BfcKmer, ch: &CountTable) -> i32 {
    let (mut max, mut max2, mut max_ec) = (0i32, 0i32, -1i32);
    for i in 0..k {
        let c = (x.x[1] >> i & 1) << 1 | (x.x[0] >> i & 1);
        for j in 0u64..4 {
            if j == c {
                continue;
            }
            let mut y = *x;
            y.change(k, i, j);
            let ret = i32::from(ch.occ(&y).cov);
            if ret == 0 {
                continue;
            }
            if max < ret {
                max2 = max;
                max = ret;
                max_ec = (i << 2 | j as usize) as i32;
            } else if max2 < ret {
                max2 = ret;
            }
        }
    }
    if max * 3 > mode && max2 < 3 {
        max_ec
    } else {
        -1
    }
}

// BFC `bfc_penalty_t` — four 1-bit penalty kinds + the chosen base; the
// bool count mirrors the C bitfield, it is not a config struct.
#[allow(clippy::struct_excessive_bools)]
#[derive(Clone, Copy, Default)]
struct Penalty {
    ec: bool,
    ec_high: bool,
    absent: bool,
    absent_high: bool,
    b: u8,
}

#[inline]
fn weighted_penalty(p: Penalty) -> i32 {
    W_EC * i32::from(p.ec)
        + W_EC_HIGH * i32::from(p.ec_high)
        + W_ABSENT * i32::from(p.absent)
        + W_ABSENT_HIGH * i32::from(p.absent_high)
}

#[derive(Clone)]
struct HeapNode {
    tot_pen: i32,
    i: usize,
    k: i64,
    ecpos_high: [i64; EC_HIST_HIGH],
    ecpos: [i64; EC_HIST],
    x: BfcKmer,
}

struct StackNode {
    parent: i64,
    i: usize,
    tot_pen: i32,
    b: u8,
    pen: Penalty,
}

/// BFC `bfc_ec1dir`: best-first correction from a solid anchor. A binary
/// min-heap on `tot_pen` (BFC's `heap_lt` is `>`, i.e. lowest penalty
/// pops first) drives an exhaustive bounded search; the lowest-penalty
/// terminating path is back-tracked into `ec`. Returns `n_absent` (≥0) or
/// a negative BFC code (`-2` uncorrectable N, `-3` too many failures).
#[allow(clippy::too_many_lines)]
fn ec1dir(
    cfg: &CorrectConfig,
    ch: &CountTable,
    seq: &[EcBase],
    ec: &mut Vec<EcBase>,
    start: usize,
    end: usize,
) -> i32 {
    let k = cfg.k;
    let n = seq.len();
    let mut heap: Vec<HeapNode> = Vec::new();
    let mut stack: Vec<StackNode> = Vec::new();
    let mut z = HeapNode {
        tot_pen: 0,
        i: 0,
        k: -1,
        ecpos_high: [-1; EC_HIST_HIGH],
        ecpos: [-1; EC_HIST],
        x: BfcKmer::NULL,
    };
    ec.clear();
    ec.extend_from_slice(seq);

    let mut l = 0usize;
    z.i = start;
    while z.i < end {
        let c = seq[z.i].b;
        if c < 4 {
            l += 1;
            if l == k {
                break;
            }
            z.x.append(k, u64::from(c));
        } else {
            l = 0;
            z.x = BfcKmer::NULL;
        }
        z.i += 1;
    }
    debug_assert!(z.i < end);
    heap.push(z);

    let mut path = [0i64; MAX_PATHS];
    let mut n_paths = 0usize;
    let mut min_path: i64 = -1;
    let mut min_path_pen = i32::MAX;
    let mut n_failures = 0i32;
    let mut rv: i32 = -1;

    while !heap.is_empty() {
        let z = heap_pop(&mut heap);
        if min_path >= 0 && z.tot_pen > min_path_pen + cfg.max_path_diff {
            break;
        }
        let mut stop = z.i as i64 - end as i64 > i64::from(cfg.max_end_ext);
        if !stop {
            let c = if z.i < n { Some(seq[z.i]) } else { None };
            let mut os: i32 = -1;
            let mut fixed = z.i > end;
            let mut other_ext = 0;
            // ≤ 4 by construction (`for b in 0u8..4`, ≤ 1 push/iter): a
            // fixed array kills a per-heap-pop heap allocation.
            let mut added: [(Penalty, i32); 4] = [(Penalty::default(), 0); 4];
            let mut n_added = 0usize;

            if let Some(cb) = c
                && cb.b < 4
            {
                let mut x = z.x;
                x.append(k, u64::from(cb.b));
                let o = ch.occ(&x);
                os = i32::from(o.cov) | (i32::from(o.hi) << 8);
                if (cb.q != 0 && i32::from(o.cov) > cfg.min_cov && cb.lcov > cfg.min_cov)
                    || f64::from(cb.hcov) > k as f64 * 0.75
                {
                    fixed = true;
                }
            }

            for b in 0u8..4 {
                if fixed
                    && let Some(cb) = c
                    && b != cb.b
                {
                    continue;
                }
                if c.is_none() || b != c.unwrap().b {
                    let mut x = z.x;
                    if let Some(cb) = c {
                        if cb.q != 0
                            && z.ecpos_high[EC_HIST_HIGH - 1] >= 0
                            && z.i as i64 - z.ecpos_high[EC_HIST_HIGH - 1]
                                < i64::from(cfg.win_multi_ec)
                        {
                            continue;
                        }
                        if z.ecpos[EC_HIST - 1] >= 0
                            && z.i as i64 - z.ecpos[EC_HIST - 1] < i64::from(cfg.win_multi_ec)
                        {
                            continue;
                        }
                    }
                    x.append(k, u64::from(b));
                    let o = ch.occ(&x);
                    let s = i32::from(o.cov) | (i32::from(o.hi) << 8);
                    if i32::from(o.cov) < cfg.min_cov {
                        continue;
                    }
                    let ec_flag = c.is_some_and(|cb| cb.b < 4);
                    let pen = Penalty {
                        ec: ec_flag,
                        ec_high: ec_flag && c.unwrap().oq != 0,
                        absent: false,
                        absent_high: (s >> 8 & 0xff) < cfg.min_cov,
                        b,
                    };
                    added[n_added] = (pen, s);
                    n_added += 1;
                    other_ext += 1;
                } else {
                    let pen = Penalty {
                        ec: false,
                        ec_high: false,
                        absent: os < 0 || (os & 0xff) < cfg.min_cov,
                        absent_high: os < 0 || (os >> 8 & 0xff) < cfg.min_cov,
                        b,
                    };
                    added[n_added] = (pen, os);
                    n_added += 1;
                }
            }

            if !fixed && other_ext == 0 {
                n_failures += 1;
            }
            if n_failures > n as i32 * 2 {
                rv = -3;
                break;
            }

            if c.is_some() || n_added == 1 {
                if n_added > 1 && heap.len() > cfg.max_heap {
                    let best = added[..n_added]
                        .iter()
                        .min_by_key(|(p, _)| weighted_penalty(*p))
                        .copied()
                        .unwrap();
                    buf_update(cfg, &mut heap, &mut stack, &z, best.0);
                } else {
                    for (pen, _) in &added[..n_added] {
                        buf_update(cfg, &mut heap, &mut stack, &z, *pen);
                    }
                }
            } else {
                if n_added == 0 && z.k >= 0 {
                    let zk = z.k as usize;
                    stack[zk].tot_pen +=
                        W_ABSENT * (cfg.max_end_ext - (z.i as i64 - end as i64) as i32);
                }
                stop = true;
            }
        }
        // Only a node with a real stack index is a valid terminating path;
        // BFC's path[] never holds the seed's -1 (the seed always extends
        // before any stop), so a degenerate z.k<0 stop is not a path.
        if stop && z.k >= 0 {
            let tp = stack[z.k as usize].tot_pen;
            if tp < min_path_pen {
                min_path_pen = tp;
                min_path = n_paths as i64;
            }
            path[n_paths] = z.k;
            n_paths += 1;
            if n_paths == MAX_PATHS {
                break;
            }
        }
    }

    if n_paths == 0 {
        return rv;
    }
    let chosen = path[min_path as usize];
    let n_absent = backtrack(&stack, chosen, seq, ec);
    for (i, b) in ec.iter_mut().enumerate() {
        if i < start + k || i >= end {
            b.b = 4;
        }
    }
    n_absent
}

fn buf_update(
    cfg: &CorrectConfig,
    heap: &mut Vec<HeapNode>,
    stack: &mut Vec<StackNode>,
    prev: &HeapNode,
    pen: Penalty,
) {
    let tot_pen = prev.tot_pen + weighted_penalty(pen);
    stack.push(StackNode {
        parent: prev.k,
        i: prev.i,
        tot_pen,
        b: pen.b,
        pen,
    });
    let mut r = HeapNode {
        tot_pen,
        i: prev.i + 1,
        k: (stack.len() - 1) as i64,
        ecpos_high: prev.ecpos_high,
        ecpos: prev.ecpos,
        x: prev.x,
    };
    if pen.ec_high {
        r.ecpos_high.copy_within(0..EC_HIST_HIGH - 1, 1);
        r.ecpos_high[0] = prev.i as i64;
    }
    if pen.ec {
        r.ecpos.copy_within(0..EC_HIST - 1, 1);
        r.ecpos[0] = prev.i as i64;
    }
    r.x.append(cfg.k, u64::from(pen.b));
    heap.push(r);
    let last = heap.len() - 1;
    heap_up(heap, last);
}

/// BFC backtrack: walk the stack parent chain, writing the chosen base and
/// ec/absent flags at each corrected position. Returns `n_absent`.
fn backtrack(stack: &[StackNode], mut end: i64, seq: &[EcBase], path: &mut Vec<EcBase>) -> i32 {
    path.clear();
    path.extend_from_slice(seq);
    let mut n_absent = 0;
    while end >= 0 {
        let s = &stack[end as usize];
        if s.i < seq.len() {
            path[s.i].b = s.b;
            if s.pen.absent {
                n_absent += 1;
            }
        }
        end = s.parent;
    }
    n_absent
}

// BFC's heap is a min-heap on tot_pen (`heap_lt(a,b) = a.tot_pen > b.tot_pen`).
#[inline]
fn heap_lt(a: &HeapNode, b: &HeapNode) -> bool {
    a.tot_pen < b.tot_pen
}

fn heap_up(h: &mut [HeapNode], mut i: usize) {
    while i > 0 {
        let p = (i - 1) / 2;
        if heap_lt(&h[i], &h[p]) {
            h.swap(i, p);
            i = p;
        } else {
            break;
        }
    }
}

fn heap_pop(h: &mut Vec<HeapNode>) -> HeapNode {
    let n = h.len();
    h.swap(0, n - 1);
    let top = h.pop().unwrap();
    let len = h.len();
    let mut i = 0;
    loop {
        let (l, r) = (2 * i + 1, 2 * i + 2);
        let mut m = i;
        if l < len && heap_lt(&h[l], &h[m]) {
            m = l;
        }
        if r < len && heap_lt(&h[r], &h[m]) {
            m = r;
        }
        if m == i {
            break;
        }
        h.swap(i, m);
        i = m;
    }
    top
}

/// BFC `bfc_ec1`: correct one read. N-fraction guard (>5% → drop), solid
/// island, forward `ec1dir` over the full read, reverse-complement, second
/// `ec1dir`, then the two directional results are merged by BFC's
/// agreement rule and the corrected sequence + ec-encoded quality emitted.
/// Returns `None` when the read is uncorrectable / over the N threshold.
/// `mode` is the count-histogram peak (BFC `bfc_ch_hist`). BFC computes it
/// once in `bfc_correct` and hands it to every per-read worker; computing
/// it per read here was O(reads × table) = quadratic. It is now a caller
/// argument, computed once in `Pipeline::run`.
pub(crate) fn correct_one(
    cfg: &CorrectConfig,
    ch: &CountTable,
    rec: &OwnedRecord,
    mode: i32,
) -> Option<(Vec<u8>, Vec<u8>)> {
    let mut s = seq_conv(&rec.seq, &rec.qual, cfg.qual_threshold);
    let n = s.len();
    if n < cfg.k {
        return None;
    }
    let n_n = s.iter().filter(|c| c.ob > 3).count();
    if n_n as f64 > n as f64 * 0.05 {
        return None;
    }
    ec_kcov(cfg.k, cfg.min_cov, &mut s, ch);
    // BFC `bfc_ec1`: with a solid island, anchor there. Without one, try
    // the greedy single-substitution probe over successive first-k-mers;
    // on success apply that one base fix and re-anchor, else NO_SOLID.
    let (start, end) = if let Some(se) = best_island(cfg.k, &s) {
        se
    } else {
        let mut bstart = 0usize;
        let mut ec = -1i32;
        let mut bend;
        loop {
            let (e, x) = ec_first_kmer(cfg.k, &s, bstart);
            bend = e;
            if bend >= n {
                break;
            }
            ec = bfc_ec_greedy_k(cfg.k, mode, &x, ch);
            if ec >= 0 {
                break;
            }
            if bend + (cfg.k >> 1) >= n {
                break;
            }
            bstart = bend - (cfg.k >> 1);
        }
        if ec < 0 {
            return None;
        }
        s[bend - (ec as usize >> 2)].b = (ec & 3) as u8;
        let ne = bend + 1;
        (ne - cfg.k, ne)
    };

    let mut ec0 = Vec::new();
    if ec1dir(cfg, ch, &s, &mut ec0, start, n) < 0 {
        return None;
    }
    revcomp(&mut s);
    let mut ec1 = Vec::new();
    if ec1dir(cfg, ch, &s, &mut ec1, n - end, n) < 0 {
        return None;
    }
    revcomp(&mut ec1);
    revcomp(&mut s);

    for i in 0..n {
        let b = if ec0[i].b == ec1[i].b {
            if ec0[i].b > 3 { s[i].b } else { ec0[i].b }
        } else if ec1[i].b > 3 {
            ec0[i].b
        } else if ec0[i].b > 3 {
            ec1[i].b
        } else {
            s[i].ob
        };
        s[i].b = b;
    }

    let mut out_seq = Vec::with_capacity(n);
    let mut out_qual = Vec::with_capacity(n);
    for c in &s {
        let is_diff = c.b != c.ob;
        out_seq.push(if is_diff {
            b"acgtn"[c.b.min(4) as usize]
        } else {
            b"ACGTN"[c.b.min(4) as usize]
        });
        if !rec.qual.is_empty() {
            out_qual.push(if is_diff {
                34 + c.ob
            } else if c.q != 0 {
                b'?'
            } else {
                b'+'
            });
        }
    }
    Some((out_seq, out_qual))
}