rskim 2.3.1

The most intelligent context optimization engine for coding agents. Code-aware AST parsing, command rewriting, output compression.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291

//! TypeScript compiler output compression (#51)
//!
//! Three-tier parser for `tsc` output:
//!
//! - **Tier 1 (regex on stderr):** Parse tsc error format
//!   `file(line,col): error TSxxxx: message` from stderr.
//!
//! - **Tier 2 (regex on combined):** Same regex on combined stdout+stderr
//!   in case tsc writes to an unexpected stream.
//!
//! - **Tier 3 (passthrough):** Return raw output when nothing can be parsed.

use std::process::ExitCode;
use std::sync::LazyLock;

use regex::Regex;

use super::run_parsed_command;
use crate::output::canonical::BuildResult;
use crate::output::ParseResult;
use crate::runner::CommandOutput;

// ============================================================================
// Public entry point
// ============================================================================

/// Run `tsc` with output compression.
///
/// tsc writes errors to stderr in its standard format. No flag injection
/// is needed (unlike cargo).
pub(crate) fn run(args: &[String], show_stats: bool) -> anyhow::Result<ExitCode> {
    run_parsed_command(
        "tsc",
        args,
        &[],
        "npm install -g typescript",
        show_stats,
        parse_tsc,
    )
}

// ============================================================================
// Three-tier parser
// ============================================================================

/// Parse tsc output through three degradation tiers.
fn parse_tsc(output: &CommandOutput) -> ParseResult<BuildResult> {
    // Tier 1: Regex on stderr (primary tsc output stream)
    if let Some(result) = try_tier1_regex(&output.stderr) {
        return result;
    }

    // Tier 2: Regex on combined stdout+stderr (in case tsc writes to unexpected stream)
    let combined = format!("{}\n{}", output.stdout, output.stderr);
    if let Some(result) = try_tier2_combined(&combined) {
        return result;
    }

    // If both stdout and stderr are empty/whitespace, it's a successful build
    if output.stdout.trim().is_empty() && output.stderr.trim().is_empty() {
        let result = BuildResult::new(true, 0, 0, None, vec![]);
        return ParseResult::Full(result);
    }

    // Tier 3: Passthrough
    let passthrough = if output.stderr.is_empty() {
        output.stdout.clone()
    } else if output.stdout.is_empty() {
        output.stderr.clone()
    } else {
        combined
    };

    ParseResult::Passthrough(passthrough)
}

/// Compiled tsc error line pattern: `file(line,col): error TSxxxx: message`
///
/// Shared between tier 1 and tier 2 parsers. Compiled once via `LazyLock`.
static TSC_ERROR_RE: LazyLock<Regex> = LazyLock::new(|| {
    Regex::new(r"^(.+)\((\d+),(\d+)\): error (TS\d+): (.+)$").expect("valid regex")
});

/// Tier 1: Parse tsc errors from stderr using regex.
///
/// tsc writes errors in the format:
/// `src/index.ts(10,5): error TS2304: Cannot find name 'foo'.`
///
/// Returns `Full` if any lines match the tsc error pattern.
/// Empty stderr is NOT handled here -- it is checked after tier 2 in `parse_tsc`.
fn try_tier1_regex(stderr: &str) -> Option<ParseResult<BuildResult>> {
    if stderr.trim().is_empty() {
        return None;
    }

    let mut error_count: usize = 0;
    let mut error_messages: Vec<String> = Vec::new();
    let mut any_match = false;

    for line in stderr.lines() {
        if let Some(caps) = TSC_ERROR_RE.captures(line) {
            any_match = true;
            error_count += 1;

            let file = caps.get(1).map_or("", |m| m.as_str());
            let line_num = caps.get(2).map_or("", |m| m.as_str());
            let ts_code = caps.get(4).map_or("", |m| m.as_str());
            let message = caps.get(5).map_or("", |m| m.as_str());

            error_messages.push(format!("{ts_code}: {message} ({file}:{line_num})"));
        }
    }

    if !any_match {
        return None;
    }

    let result = BuildResult::new(false, 0, error_count, None, error_messages);
    Some(ParseResult::Full(result))
}

/// Tier 2: Same regex on combined stdout+stderr.
///
/// Fallback in case tsc output goes to an unexpected stream.
fn try_tier2_combined(combined: &str) -> Option<ParseResult<BuildResult>> {
    let mut error_count: usize = 0;
    let mut error_messages: Vec<String> = Vec::new();

    for line in combined.lines() {
        if let Some(caps) = TSC_ERROR_RE.captures(line) {
            error_count += 1;

            let file = caps.get(1).map_or("", |m| m.as_str());
            let line_num = caps.get(2).map_or("", |m| m.as_str());
            let ts_code = caps.get(4).map_or("", |m| m.as_str());
            let message = caps.get(5).map_or("", |m| m.as_str());

            error_messages.push(format!("{ts_code}: {message} ({file}:{line_num})"));
        }
    }

    if error_count == 0 {
        return None;
    }

    let result = BuildResult::new(false, 0, error_count, None, error_messages);
    Some(ParseResult::Degraded(
        result,
        vec!["tsc: structured parse failed, using combined stdout+stderr".to_string()],
    ))
}

// ============================================================================
// Tests
// ============================================================================

#[cfg(test)]
mod tests {
    use super::*;
    use std::path::PathBuf;
    use std::time::Duration;

    fn fixtures_dir() -> PathBuf {
        PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("tests/fixtures/cmd/build")
    }

    fn load_fixture(name: &str) -> String {
        std::fs::read_to_string(fixtures_dir().join(name))
            .unwrap_or_else(|e| panic!("Failed to load fixture {name}: {e}"))
    }

    fn make_output(stdout: &str, stderr: &str, exit_code: Option<i32>) -> CommandOutput {
        CommandOutput {
            stdout: stdout.to_string(),
            stderr: stderr.to_string(),
            exit_code,
            duration: Duration::from_millis(100),
        }
    }

    // ========================================================================
    // Tier 1: Regex on stderr
    // ========================================================================

    #[test]
    fn test_tier1_tsc_errors() {
        let stderr = load_fixture("tsc_errors.txt");
        let output = make_output("", &stderr, Some(2));
        let result = parse_tsc(&output);

        assert!(
            result.is_full(),
            "expected Full, got {:?}",
            result.tier_name()
        );
        if let ParseResult::Full(build_result) = &result {
            assert_eq!(build_result.errors, 3, "expected 3 errors");
            assert!(!build_result.success, "expected failure");
        }
    }

    #[test]
    fn test_tier1_tsc_success() {
        // Empty stdout+stderr means successful compilation
        let output = make_output("", "", Some(0));
        let result = parse_tsc(&output);

        assert!(
            result.is_full(),
            "expected Full for empty output, got {:?}",
            result.tier_name()
        );
        if let ParseResult::Full(build_result) = &result {
            assert!(build_result.success, "expected success");
            assert_eq!(build_result.errors, 0, "expected 0 errors");
        }
    }

    #[test]
    fn test_tsc_group_by_file() {
        let stderr = load_fixture("tsc_errors.txt");
        let output = make_output("", &stderr, Some(2));
        let result = parse_tsc(&output);

        if let ParseResult::Full(build_result) = &result {
            // Verify errors reference different files
            let src_index_errors: Vec<_> = build_result
                .error_messages
                .iter()
                .filter(|m| m.contains("src/index.ts"))
                .collect();
            let src_utils_errors: Vec<_> = build_result
                .error_messages
                .iter()
                .filter(|m| m.contains("src/utils.ts"))
                .collect();

            assert_eq!(
                src_index_errors.len(),
                2,
                "expected 2 errors from src/index.ts"
            );
            assert_eq!(
                src_utils_errors.len(),
                1,
                "expected 1 error from src/utils.ts"
            );
        } else {
            panic!("expected Full result");
        }
    }

    // ========================================================================
    // Tier 2: Combined fallback
    // ========================================================================

    #[test]
    fn test_tier2_tsc_errors_on_stdout() {
        // tsc output on stdout instead of stderr (unusual but possible)
        let tsc_output = "src/main.ts(5,1): error TS2304: Cannot find name 'x'.\n";
        let output = make_output(tsc_output, "", Some(2));
        let result = parse_tsc(&output);

        assert!(
            result.is_degraded(),
            "expected Degraded for stdout-only tsc errors, got {:?}",
            result.tier_name()
        );
        if let ParseResult::Degraded(build_result, markers) = &result {
            assert_eq!(build_result.errors, 1, "expected 1 error");
            assert!(markers.iter().any(|m| m.contains("combined")));
        }
    }

    // ========================================================================
    // Tier 3: Passthrough
    // ========================================================================

    #[test]
    fn test_tier3_passthrough() {
        // Non-tsc output that doesn't match any pattern
        let output = make_output("", "some random error text\n", Some(1));
        let result = parse_tsc(&output);

        assert!(
            result.is_passthrough(),
            "expected Passthrough, got {:?}",
            result.tier_name()
        );
    }
}