rsconstruct 0.9.121

Rust based fast build system
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133

use crate::common::run_rsconstruct_with_env;
use std::fs;
use std::path::Path;
use tempfile::TempDir;

const CONFIG: &str = "[processor.checker.iluacheck]\nsrc_dirs = [\"src\"]\n";

fn setup_project(config: &str, files: &[(&str, &str)]) -> TempDir {
    let temp_dir = TempDir::new().expect("Failed to create temp dir");
    fs::write(temp_dir.path().join("rsconstruct.toml"), config)
        .expect("Failed to write rsconstruct.toml");
    for (name, content) in files {
        let path = temp_dir.path().join(name);
        fs::create_dir_all(path.parent().unwrap()).expect("Failed to create dir");
        fs::write(&path, content).expect("Failed to write source file");
    }
    temp_dir
}

fn build(project_path: &Path) -> std::process::Output {
    run_rsconstruct_with_env(project_path, &["build"], &[("NO_COLOR", "1")])
}

fn combined_output(output: &std::process::Output) -> String {
    format!(
        "{}{}",
        String::from_utf8_lossy(&output.stdout),
        String::from_utf8_lossy(&output.stderr)
    )
}

fn assert_passes(output: &std::process::Output, what: &str) {
    assert!(
        output.status.success(),
        "{what} must pass: {}",
        combined_output(output)
    );
}

fn assert_fails_with(output: &std::process::Output, what: &str, needle: &str) {
    assert!(!output.status.success(), "{what} must fail");
    let text = combined_output(output);
    assert!(
        text.contains(needle),
        "{what}: {needle:?} not reported: {text}"
    );
}

#[test]
fn iluacheck_clean_file_passes() {
    let temp_dir = setup_project(CONFIG, &[("src/ok.lua", "local x = 1\nprint(x)\n")]);
    assert_passes(&build(temp_dir.path()), "a clean Lua file");
}

#[test]
fn iluacheck_reports_in_luacheck_format() {
    let source = "local x = 1\ny = 2\nprint(z.w)\n";
    let temp_dir = setup_project(CONFIG, &[("src/bad.lua", source)]);
    let output = build(temp_dir.path());
    assert_fails_with(
        &output,
        "an unused local",
        "src/bad.lua:1:7: (W211) unused variable 'x'",
    );
    assert_fails_with(
        &output,
        "a global assignment",
        "src/bad.lua:2:1: (W111) setting non-standard global variable 'y'",
    );
    assert_fails_with(
        &output,
        "an undefined global",
        "src/bad.lua:3:7: (W113) accessing undefined variable 'z'",
    );
}

/// With `allow_defined_top`, a global set at the top of one file is
/// defined for every file checked together, as in one luacheck run.
#[test]
fn iluacheck_implicit_globals_span_files() {
    let config = "[processor.checker.iluacheck]\nsrc_dirs = [\"src\"]\nallow_defined_top = true\n";
    let temp_dir = setup_project(
        config,
        &[
            ("src/a.lua", "SHARED = {}\n"),
            ("src/b.lua", "print(SHARED)\n"),
        ],
    );
    assert_passes(&build(temp_dir.path()), "a global defined in another file");
}

#[test]
fn iluacheck_reads_luacheckrc() {
    let temp_dir = setup_project(
        CONFIG,
        &[
            ("src/vimrc.lua", "vim.opt.number = true\n"),
            (".luacheckrc", "files[\"src\"] = {globals = {\"vim\"}}\n"),
        ],
    );
    assert_passes(
        &build(temp_dir.path()),
        "a global the configuration declares",
    );
}

#[test]
fn iluacheck_rejects_an_invalid_configuration() {
    let temp_dir = setup_project(
        CONFIG,
        &[
            ("src/a.lua", "print(1)\n"),
            (".luacheckrc", "std = \"nope\"\n"),
        ],
    );
    assert_fails_with(
        &build(temp_dir.path()),
        "an unknown std",
        "in config loaded from .luacheckrc: invalid value of option 'std': unknown std 'nope'",
    );
}

#[test]
fn iluacheck_honours_inline_options() {
    let temp_dir = setup_project(
        CONFIG,
        &[(
            "src/a.lua",
            "-- luacheck: globals FOO\nFOO = 1\nlocal unused = 1 -- luacheck: ignore\n",
        )],
    );
    assert_passes(&build(temp_dir.path()), "findings silenced inline");
}