rsconstruct 0.9.113

Rust based fast build system
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175

use crate::common::{make_executable, run_rsconstruct_with_env, setup_project_with_config};
use serde_json::Value;
use std::fs;

/// A `[dependencies] cargo` entry is a crate, judged by `cargo install
/// --list`: a name no crate carries is reported missing, and the fix doctor
/// names is the same `cargo install --locked` that install-deps runs.
#[test]
fn doctor_checks_cargo_dependencies_against_cargo_install_list() {
    let temp_dir = setup_project_with_config(
        "[dependencies]\ncargo = [\"rsconstruct-fake-missing-crate\"]\n\n[processor.generator.tera]\nsrc_dirs = [\"tera.templates\"]\n",
    );
    let project_path = temp_dir.path();
    fs::create_dir_all(project_path.join("tera.templates")).unwrap();

    let output =
        run_rsconstruct_with_env(project_path, &["--json", "doctor"], &[("NO_COLOR", "1")]);
    let parsed: Value =
        serde_json::from_slice(&output.stdout).expect("doctor --json should emit valid JSON");
    let checks = parsed["checks"]
        .as_array()
        .expect("doctor --json should have a checks array");
    let missing = checks
        .iter()
        .find(|c| {
            c["name"]
                .as_str()
                .is_some_and(|n| n.starts_with("rsconstruct-fake-missing-crate"))
        })
        .expect("doctor should report the declared crate");
    assert_eq!(missing["status"], "fail");
    assert_eq!(missing["category"], "dependency");
    assert_eq!(
        missing["install_hint"],
        "cargo install --locked --force rsconstruct-fake-missing-crate"
    );
}

/// A package.json dependency is a project-local install: doctor judges it
/// by the project's own node_modules, not by a global copy or a binary on
/// PATH, and the fix it names is install-deps (which runs `npm ci`).
#[test]
fn doctor_checks_package_json_dependencies_in_node_modules() {
    let temp_dir =
        setup_project_with_config("[processor.generator.tera]\nsrc_dirs = [\"tera.templates\"]\n");
    let project_path = temp_dir.path();
    fs::create_dir_all(project_path.join("tera.templates")).unwrap();
    fs::write(
        project_path.join("package.json"),
        r#"{"devDependencies": {"rsconstruct-fake-installed": "1.0.0", "rsconstruct-fake-missing": "1.0.0"}}"#,
    )
    .unwrap();
    fs::write(
        project_path.join("package-lock.json"),
        r#"{"lockfileVersion": 3, "packages": {"node_modules/rsconstruct-fake-installed": {"version": "1.0.0"}, "node_modules/rsconstruct-fake-missing": {"version": "1.0.0"}}}"#,
    )
    .unwrap();
    let installed = project_path.join("node_modules/rsconstruct-fake-installed");
    fs::create_dir_all(&installed).unwrap();
    fs::write(installed.join("package.json"), r#"{"version": "1.0.0"}"#).unwrap();

    let output =
        run_rsconstruct_with_env(project_path, &["--json", "doctor"], &[("NO_COLOR", "1")]);
    let parsed: Value =
        serde_json::from_slice(&output.stdout).expect("doctor --json should emit valid JSON");
    let checks = parsed["checks"]
        .as_array()
        .expect("doctor --json should have a checks array");
    let find = |prefix: &str| {
        checks
            .iter()
            .find(|c| c["name"].as_str().is_some_and(|n| n.starts_with(prefix)))
            .unwrap_or_else(|| panic!("doctor should report {prefix}"))
    };
    assert_eq!(find("rsconstruct-fake-installed")["status"], "ok");
    let missing = find("rsconstruct-fake-missing");
    assert_eq!(missing["status"], "fail");
    assert_eq!(missing["install_hint"], "rsconstruct tool install-deps");
}

/// The lock is what makes the install reproducible, so a manifest that
/// declares packages without one is an error, not a floating install.
#[test]
fn doctor_rejects_package_json_without_lock() {
    let temp_dir =
        setup_project_with_config("[processor.generator.tera]\nsrc_dirs = [\"tera.templates\"]\n");
    let project_path = temp_dir.path();
    fs::create_dir_all(project_path.join("tera.templates")).unwrap();
    fs::write(
        project_path.join("package.json"),
        r#"{"devDependencies": {"stylelint": "latest"}}"#,
    )
    .unwrap();

    let output = run_rsconstruct_with_env(project_path, &["doctor"], &[("NO_COLOR", "1")]);
    assert!(
        !output.status.success(),
        "doctor should fail without a lock"
    );
    let stderr = String::from_utf8_lossy(&output.stderr);
    assert!(
        stderr.contains("package-lock.json"),
        "error should name the missing lock: {stderr}"
    );
}

/// The regression this guards: `doctor` used to probe `[dependencies] system`
/// entries with `which()`, treating packages as if they were tools. That
/// misreports in both directions — a binary-less package like aspell-en (a
/// dictionary) showed as missing even when installed, and any binary that
/// happens to share a package's name showed as installed without the package
/// being on. The probe must go through the package manager, the same one
/// `tool install-deps` uses.
///
/// The test plants a fake binary on PATH whose name is not a real package.
/// The old which()-based doctor reported it ok; the package-manager probe
/// must report it missing. This assumes a supported package manager exists
/// (dpkg/rpm/pacman/brew) — on a machine without one, `install-deps` bails
/// anyway, so that environment is already unsupported.
#[test]
fn doctor_system_dependency_is_probed_as_package_not_tool() {
    let temp_dir = setup_project_with_config(
        "[processor.generator.tera]\nsrc_dirs = [\"tera.templates\"]\n\n[dependencies]\nsystem = [\"rsconstruct-fake-system-package\"]\n",
    );
    let project_path = temp_dir.path();
    fs::create_dir_all(project_path.join("tera.templates")).unwrap();

    // A binary with the package's exact name, on PATH.
    let bin_dir = project_path.join("fakebin");
    fs::create_dir_all(&bin_dir).unwrap();
    let fake = bin_dir.join("rsconstruct-fake-system-package");
    fs::write(&fake, "#!/bin/sh\nexit 0\n").unwrap();
    make_executable(&fake);
    let path = format!(
        "{}:{}",
        bin_dir.display(),
        std::env::var("PATH").expect("PATH must be set")
    );

    let output = run_rsconstruct_with_env(
        project_path,
        &["--json", "doctor"],
        &[("NO_COLOR", "1"), ("PATH", &path)],
    );
    assert!(
        output.status.success(),
        "doctor failed to run: {}",
        String::from_utf8_lossy(&output.stderr)
    );

    let parsed: Value =
        serde_json::from_slice(&output.stdout).expect("doctor --json should emit valid JSON");
    let checks = parsed["checks"]
        .as_array()
        .expect("doctor --json should have a checks array");
    let check = checks
        .iter()
        .find(|c| {
            c["name"]
                .as_str()
                .is_some_and(|n| n.starts_with("rsconstruct-fake-system-package"))
        })
        .expect("doctor should report on the declared system dependency");

    assert_eq!(
        check["status"], "fail",
        "a fake binary on PATH is not an installed system package; doctor must ask \
         the package manager, not which(). Check was: {check}",
    );
    assert_eq!(check["category"], "dependency");
    assert_eq!(
        check["install_hint"], "rsconstruct tool install-deps",
        "the fix for a missing system dependency is install-deps, not a tool install",
    );
}