rs3gw 0.2.1

High-Performance AI/HPC Object Storage Gateway powered by scirs2-io
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
//! Dataset Registry - Version control and lineage tracking for ML datasets
//!
//! This module provides a dataset registry system for tracking dataset versions,
//! metadata, splits, and lineage relationships with models.
//!
//! # Features
//!
//! - Dataset registration and versioning
//! - Dataset split management (train/validation/test)
//! - Dataset metadata and statistics
//! - Lineage tracking (dataset → model relationships)
//! - Provenance information (source, transformations)
//! - Annotation version control
//! - Dataset diff capabilities
//!
//! # Example
//!
//! ```no_run
//! use rs3gw::storage::dataset_registry::{DatasetRegistry, DatasetSplit};
//!
//! # async fn example() -> Result<(), Box<dyn std::error::Error>> {
//! let registry = DatasetRegistry::new("./datasets-registry".into()).await?;
//!
//! // Register a new dataset
//! let dataset = registry.register_dataset(
//!     "imagenet-subset",
//!     "ImageNet validation subset for testing"
//! ).await?;
//!
//! // Create a new version with splits
//! let version = registry.create_dataset_version(
//!     "imagenet-subset",
//!     "s3://bucket/datasets/imagenet-v1/",
//!     None
//! ).await?;
//!
//! // Add split information
//! registry.add_dataset_split(
//!     &dataset.name,
//!     version.version,
//!     DatasetSplit::Train,
//!     "s3://bucket/datasets/imagenet-v1/train/",
//!     10000
//! ).await?;
//!
//! // Link dataset to model for reproducibility
//! registry.link_dataset_to_model(&dataset.name, version.version, "my-classifier", 1).await?;
//! # Ok(())
//! # }
//! ```

use chrono::{DateTime, Utc};
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::path::PathBuf;
use std::sync::Arc;
use thiserror::Error;
use tokio::fs;
use tokio::sync::RwLock;
use tracing::info;

/// Dataset registry errors
#[derive(Debug, Error)]
pub enum DatasetRegistryError {
    #[error("Dataset not found: {0}")]
    DatasetNotFound(String),

    #[error("Version not found: {dataset}/{version}")]
    VersionNotFound { dataset: String, version: u32 },

    #[error("Dataset already exists: {0}")]
    DatasetAlreadyExists(String),

    #[error("Split not found: {split:?}")]
    SplitNotFound { split: DatasetSplit },

    #[error("I/O error: {0}")]
    IoError(#[from] std::io::Error),

    #[error("Serialization error: {0}")]
    SerializationError(#[from] serde_json::Error),
}

pub type DatasetRegistryResult<T> = Result<T, DatasetRegistryError>;

/// Dataset split types
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, Hash)]
pub enum DatasetSplit {
    /// Training set
    Train,
    /// Validation set
    Validation,
    /// Test set
    Test,
    /// Full dataset (unsplit)
    Full,
}

/// Registered dataset information
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RegisteredDataset {
    /// Dataset name (unique identifier)
    pub name: String,
    /// Dataset description
    pub description: String,
    /// Creation timestamp
    pub created_at: DateTime<Utc>,
    /// Last update timestamp
    pub last_updated: DateTime<Utc>,
    /// Latest version number
    pub latest_version: u32,
    /// Tags for categorization
    pub tags: HashMap<String, String>,
}

/// Dataset version information
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct DatasetVersion {
    /// Dataset name
    pub dataset_name: String,
    /// Version number (monotonically increasing)
    pub version: u32,
    /// Source URI (e.g., s3://bucket/path/dataset/)
    pub source: String,
    /// Creation timestamp
    pub created_at: DateTime<Utc>,
    /// Last update timestamp
    pub last_updated: DateTime<Utc>,
    /// Dataset metadata
    pub metadata: DatasetMetadata,
    /// Dataset splits
    pub splits: HashMap<DatasetSplit, SplitInfo>,
    /// Models trained on this dataset version
    pub trained_models: Vec<ModelReference>,
    /// Tags for this version
    pub tags: HashMap<String, String>,
}

/// Dataset metadata
#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct DatasetMetadata {
    /// Total size in bytes
    pub total_size: u64,
    /// Number of samples/records
    pub num_samples: Option<u64>,
    /// Data format (CSV, Parquet, Images, etc.)
    pub format: Option<String>,
    /// Schema information
    pub schema: Option<String>,
    /// Statistical summary
    pub statistics: HashMap<String, serde_json::Value>,
    /// Provenance information
    pub provenance: DatasetProvenance,
    /// Custom metadata
    pub custom: HashMap<String, String>,
}

/// Dataset provenance information
#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct DatasetProvenance {
    /// Original data source
    pub source: Option<String>,
    /// Collection method/process
    pub collection_method: Option<String>,
    /// Transformations applied
    pub transformations: Vec<String>,
    /// Parent dataset versions (for derived datasets)
    pub parent_versions: Vec<String>,
    /// Creation script or process
    pub creation_script: Option<String>,
    /// Creator information
    pub created_by: Option<String>,
    /// License information
    pub license: Option<String>,
    /// Citation information
    pub citation: Option<String>,
}

/// Split information
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct SplitInfo {
    /// Split type
    pub split: DatasetSplit,
    /// URI to split data
    pub uri: String,
    /// Number of samples in this split
    pub num_samples: u64,
    /// Split percentage (0.0-1.0)
    pub percentage: Option<f64>,
    /// Checksum for integrity
    pub checksum: Option<String>,
}

/// Reference to a model trained on this dataset
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ModelReference {
    /// Model name
    pub model_name: String,
    /// Model version
    pub model_version: u32,
    /// Timestamp when link was created
    pub linked_at: DateTime<Utc>,
    /// Which split was used (Train, Validation, etc.)
    pub split_used: DatasetSplit,
}

/// Dataset registry implementation
pub struct DatasetRegistry {
    /// Storage root directory
    root: PathBuf,
    /// In-memory cache of registered datasets
    datasets: Arc<RwLock<HashMap<String, RegisteredDataset>>>,
    /// In-memory cache of dataset versions (dataset_name -> version -> DatasetVersion)
    versions: Arc<RwLock<HashMap<String, HashMap<u32, DatasetVersion>>>>,
}

impl DatasetRegistry {
    /// Create a new dataset registry
    pub async fn new(root: PathBuf) -> DatasetRegistryResult<Self> {
        fs::create_dir_all(&root).await?;

        let registry = Self {
            root: root.clone(),
            datasets: Arc::new(RwLock::new(HashMap::new())),
            versions: Arc::new(RwLock::new(HashMap::new())),
        };

        // Load existing datasets and versions from disk
        registry.load_from_disk().await?;

        Ok(registry)
    }

    /// Load all datasets and versions from disk
    async fn load_from_disk(&self) -> DatasetRegistryResult<()> {
        let datasets_path = self.root.join("datasets");

        if !datasets_path.exists() {
            fs::create_dir_all(&datasets_path).await?;
            return Ok(());
        }

        let mut dir = fs::read_dir(&datasets_path).await?;
        while let Some(entry) = dir.next_entry().await? {
            if entry.file_type().await?.is_file()
                && entry.path().extension().and_then(|s| s.to_str()) == Some("json")
            {
                if let Ok(content) = fs::read_to_string(entry.path()).await {
                    if let Ok(dataset) = serde_json::from_str::<RegisteredDataset>(&content) {
                        self.datasets
                            .write()
                            .await
                            .insert(dataset.name.clone(), dataset.clone());

                        // Load versions for this dataset
                        self.load_versions(&dataset.name).await?;
                    }
                }
            }
        }

        info!(
            "Loaded {} datasets from registry",
            self.datasets.read().await.len()
        );
        Ok(())
    }

    /// Load all versions for a dataset
    async fn load_versions(&self, dataset_name: &str) -> DatasetRegistryResult<()> {
        let versions_path = self.root.join("versions").join(dataset_name);

        if !versions_path.exists() {
            return Ok(());
        }

        let mut versions_map = HashMap::new();
        let mut dir = fs::read_dir(&versions_path).await?;

        while let Some(entry) = dir.next_entry().await? {
            if entry.file_type().await?.is_file()
                && entry.path().extension().and_then(|s| s.to_str()) == Some("json")
            {
                if let Ok(content) = fs::read_to_string(entry.path()).await {
                    if let Ok(version) = serde_json::from_str::<DatasetVersion>(&content) {
                        versions_map.insert(version.version, version);
                    }
                }
            }
        }

        if !versions_map.is_empty() {
            self.versions
                .write()
                .await
                .insert(dataset_name.to_string(), versions_map);
        }

        Ok(())
    }

    /// Register a new dataset
    pub async fn register_dataset(
        &self,
        name: &str,
        description: &str,
    ) -> DatasetRegistryResult<RegisteredDataset> {
        let mut datasets = self.datasets.write().await;

        if datasets.contains_key(name) {
            return Err(DatasetRegistryError::DatasetAlreadyExists(name.to_string()));
        }

        let dataset = RegisteredDataset {
            name: name.to_string(),
            description: description.to_string(),
            created_at: Utc::now(),
            last_updated: Utc::now(),
            latest_version: 0,
            tags: HashMap::new(),
        };

        // Save to disk
        self.save_dataset(&dataset).await?;

        datasets.insert(name.to_string(), dataset.clone());
        info!("Registered new dataset: {}", name);

        Ok(dataset)
    }

    /// Create a new dataset version
    pub async fn create_dataset_version(
        &self,
        dataset_name: &str,
        source: &str,
        metadata: Option<DatasetMetadata>,
    ) -> DatasetRegistryResult<DatasetVersion> {
        // Get or create the dataset
        let mut datasets = self.datasets.write().await;
        let dataset = datasets
            .get_mut(dataset_name)
            .ok_or_else(|| DatasetRegistryError::DatasetNotFound(dataset_name.to_string()))?;

        // Increment version number
        dataset.latest_version += 1;
        dataset.last_updated = Utc::now();

        let version_num = dataset.latest_version;

        // Create new version
        let version = DatasetVersion {
            dataset_name: dataset_name.to_string(),
            version: version_num,
            source: source.to_string(),
            created_at: Utc::now(),
            last_updated: Utc::now(),
            metadata: metadata.unwrap_or_default(),
            splits: HashMap::new(),
            trained_models: Vec::new(),
            tags: HashMap::new(),
        };

        // Save dataset with updated latest_version
        self.save_dataset(dataset).await?;

        // Save version
        self.save_version(&version).await?;

        // Update in-memory cache
        let mut versions = self.versions.write().await;
        versions
            .entry(dataset_name.to_string())
            .or_insert_with(HashMap::new)
            .insert(version_num, version.clone());

        info!("Created dataset version: {}/{}", dataset_name, version_num);

        Ok(version)
    }

    /// Add a split to a dataset version
    pub async fn add_dataset_split(
        &self,
        dataset_name: &str,
        version_num: u32,
        split: DatasetSplit,
        uri: &str,
        num_samples: u64,
    ) -> DatasetRegistryResult<()> {
        let mut versions = self.versions.write().await;

        let dataset_versions = versions
            .get_mut(dataset_name)
            .ok_or_else(|| DatasetRegistryError::DatasetNotFound(dataset_name.to_string()))?;

        let version = dataset_versions.get_mut(&version_num).ok_or_else(|| {
            DatasetRegistryError::VersionNotFound {
                dataset: dataset_name.to_string(),
                version: version_num,
            }
        })?;

        let split_info = SplitInfo {
            split,
            uri: uri.to_string(),
            num_samples,
            percentage: None,
            checksum: None,
        };

        version.splits.insert(split, split_info);
        version.last_updated = Utc::now();

        // Save to disk
        self.save_version(version).await?;

        info!(
            "Added split {:?} to dataset {}/{}",
            split, dataset_name, version_num
        );

        Ok(())
    }

    /// Link a dataset version to a model (for reproducibility)
    pub async fn link_dataset_to_model(
        &self,
        dataset_name: &str,
        dataset_version: u32,
        model_name: &str,
        model_version: u32,
    ) -> DatasetRegistryResult<()> {
        let mut versions = self.versions.write().await;

        let dataset_versions = versions
            .get_mut(dataset_name)
            .ok_or_else(|| DatasetRegistryError::DatasetNotFound(dataset_name.to_string()))?;

        let version = dataset_versions.get_mut(&dataset_version).ok_or_else(|| {
            DatasetRegistryError::VersionNotFound {
                dataset: dataset_name.to_string(),
                version: dataset_version,
            }
        })?;

        let model_ref = ModelReference {
            model_name: model_name.to_string(),
            model_version,
            linked_at: Utc::now(),
            split_used: DatasetSplit::Train, // Default to Train
        };

        version.trained_models.push(model_ref);
        version.last_updated = Utc::now();

        // Save to disk
        self.save_version(version).await?;

        info!(
            "Linked dataset {}/{} to model {}/{}",
            dataset_name, dataset_version, model_name, model_version
        );

        Ok(())
    }

    /// Get a specific dataset version
    pub async fn get_dataset_version(
        &self,
        dataset_name: &str,
        version_num: u32,
    ) -> DatasetRegistryResult<Option<DatasetVersion>> {
        let versions = self.versions.read().await;

        Ok(versions
            .get(dataset_name)
            .and_then(|v| v.get(&version_num))
            .cloned())
    }

    /// Get latest version of a dataset
    pub async fn get_latest_version(
        &self,
        dataset_name: &str,
    ) -> DatasetRegistryResult<Option<DatasetVersion>> {
        let versions = self.versions.read().await;

        let dataset_versions = match versions.get(dataset_name) {
            Some(v) => v,
            None => return Ok(None),
        };

        let mut all_versions: Vec<_> = dataset_versions.values().collect();
        all_versions.sort_by_key(|v| v.version);

        Ok(all_versions.last().map(|v| (*v).clone()))
    }

    /// List all versions of a dataset
    pub async fn list_dataset_versions(
        &self,
        dataset_name: &str,
    ) -> DatasetRegistryResult<Vec<DatasetVersion>> {
        let versions = self.versions.read().await;

        let dataset_versions = versions
            .get(dataset_name)
            .map(|v| v.values().cloned().collect())
            .unwrap_or_default();

        Ok(dataset_versions)
    }

    /// Get registered dataset
    pub async fn get_dataset(
        &self,
        name: &str,
    ) -> DatasetRegistryResult<Option<RegisteredDataset>> {
        Ok(self.datasets.read().await.get(name).cloned())
    }

    /// List all registered datasets
    pub async fn list_datasets(&self) -> Vec<RegisteredDataset> {
        self.datasets.read().await.values().cloned().collect()
    }

    /// Delete a dataset and all its versions
    pub async fn delete_dataset(&self, dataset_name: &str) -> DatasetRegistryResult<()> {
        // Remove from memory
        self.datasets.write().await.remove(dataset_name);
        self.versions.write().await.remove(dataset_name);

        // Remove from disk
        let dataset_path = self
            .root
            .join("datasets")
            .join(format!("{}.json", dataset_name));
        if dataset_path.exists() {
            fs::remove_file(dataset_path).await?;
        }

        let versions_dir = self.root.join("versions").join(dataset_name);
        if versions_dir.exists() {
            fs::remove_dir_all(versions_dir).await?;
        }

        info!("Deleted dataset: {}", dataset_name);
        Ok(())
    }

    /// Save dataset to disk
    async fn save_dataset(&self, dataset: &RegisteredDataset) -> DatasetRegistryResult<()> {
        let datasets_dir = self.root.join("datasets");
        fs::create_dir_all(&datasets_dir).await?;

        let path = datasets_dir.join(format!("{}.json", dataset.name));
        let content = serde_json::to_string_pretty(dataset)?;
        fs::write(path, content).await?;

        Ok(())
    }

    /// Save dataset version to disk
    async fn save_version(&self, version: &DatasetVersion) -> DatasetRegistryResult<()> {
        let versions_dir = self.root.join("versions").join(&version.dataset_name);
        fs::create_dir_all(&versions_dir).await?;

        let path = versions_dir.join(format!("v{}.json", version.version));
        let content = serde_json::to_string_pretty(version)?;
        fs::write(path, content).await?;

        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::env;

    async fn create_test_registry() -> DatasetRegistry {
        let temp_dir =
            env::temp_dir().join(format!("test_dataset_registry_{}", uuid::Uuid::new_v4()));
        DatasetRegistry::new(temp_dir)
            .await
            .expect("Failed to create registry")
    }

    #[tokio::test]
    async fn test_register_dataset() {
        let registry = create_test_registry().await;

        let dataset = registry
            .register_dataset("test-dataset", "A test dataset")
            .await
            .expect("Failed to register dataset");

        assert_eq!(dataset.name, "test-dataset");
        assert_eq!(dataset.description, "A test dataset");
        assert_eq!(dataset.latest_version, 0);
    }

    #[tokio::test]
    async fn test_create_dataset_version() {
        let registry = create_test_registry().await;

        registry
            .register_dataset("test-dataset", "A test dataset")
            .await
            .expect("Failed to register dataset");

        let version = registry
            .create_dataset_version("test-dataset", "s3://bucket/dataset/", None)
            .await
            .expect("Failed to create version");

        assert_eq!(version.version, 1);
        assert_eq!(version.dataset_name, "test-dataset");
    }

    #[tokio::test]
    async fn test_add_dataset_split() {
        let registry = create_test_registry().await;

        registry
            .register_dataset("test-dataset", "A test dataset")
            .await
            .expect("Failed to register dataset");

        let version = registry
            .create_dataset_version("test-dataset", "s3://bucket/dataset/", None)
            .await
            .expect("Failed to create version");

        registry
            .add_dataset_split(
                "test-dataset",
                version.version,
                DatasetSplit::Train,
                "s3://bucket/dataset/train/",
                10000,
            )
            .await
            .expect("Failed to add split");

        let updated = registry
            .get_dataset_version("test-dataset", version.version)
            .await
            .expect("Failed to get version")
            .expect("Version not found");

        assert_eq!(updated.splits.len(), 1);
        assert!(updated.splits.contains_key(&DatasetSplit::Train));
    }

    #[tokio::test]
    async fn test_link_dataset_to_model() {
        let registry = create_test_registry().await;

        registry
            .register_dataset("test-dataset", "A test dataset")
            .await
            .expect("Failed to register dataset");

        let version = registry
            .create_dataset_version("test-dataset", "s3://bucket/dataset/", None)
            .await
            .expect("Failed to create version");

        registry
            .link_dataset_to_model("test-dataset", version.version, "my-model", 1)
            .await
            .expect("Failed to link dataset");

        let updated = registry
            .get_dataset_version("test-dataset", version.version)
            .await
            .expect("Failed to get version")
            .expect("Version not found");

        assert_eq!(updated.trained_models.len(), 1);
        assert_eq!(updated.trained_models[0].model_name, "my-model");
        assert_eq!(updated.trained_models[0].model_version, 1);
    }

    #[tokio::test]
    async fn test_get_latest_version() {
        let registry = create_test_registry().await;

        registry
            .register_dataset("test-dataset", "A test dataset")
            .await
            .expect("Failed to register dataset");

        let _v1 = registry
            .create_dataset_version("test-dataset", "s3://bucket/dataset_v1/", None)
            .await
            .expect("Failed to create v1");
        let v2 = registry
            .create_dataset_version("test-dataset", "s3://bucket/dataset_v2/", None)
            .await
            .expect("Failed to create v2");

        let latest = registry
            .get_latest_version("test-dataset")
            .await
            .expect("Failed to get latest version");

        let latest_version = latest.expect("Latest version should be Some");
        assert_eq!(latest_version.version, v2.version);
    }

    #[tokio::test]
    async fn test_list_datasets() {
        let registry = create_test_registry().await;

        registry
            .register_dataset("dataset1", "First dataset")
            .await
            .expect("Failed to register dataset1");
        registry
            .register_dataset("dataset2", "Second dataset")
            .await
            .expect("Failed to register dataset2");

        let datasets = registry.list_datasets().await;
        assert_eq!(datasets.len(), 2);
    }

    #[tokio::test]
    async fn test_delete_dataset() {
        let registry = create_test_registry().await;

        registry
            .register_dataset("test-dataset", "A test dataset")
            .await
            .expect("Failed to register dataset");
        registry
            .create_dataset_version("test-dataset", "s3://bucket/dataset/", None)
            .await
            .expect("Failed to create version");

        registry
            .delete_dataset("test-dataset")
            .await
            .expect("Failed to delete dataset");

        let dataset = registry
            .get_dataset("test-dataset")
            .await
            .expect("Failed to get dataset");
        assert!(dataset.is_none());
    }

    #[tokio::test]
    async fn test_persistence() {
        let temp_dir =
            env::temp_dir().join(format!("test_dataset_persist_{}", uuid::Uuid::new_v4()));

        // Create registry and add data
        {
            let registry = DatasetRegistry::new(temp_dir.clone())
                .await
                .expect("Failed to create registry");

            registry
                .register_dataset("persist-dataset", "A persistent dataset")
                .await
                .expect("Failed to register dataset");
            registry
                .create_dataset_version("persist-dataset", "s3://bucket/dataset/", None)
                .await
                .expect("Failed to create version");
        }

        // Reload from disk
        {
            let registry = DatasetRegistry::new(temp_dir.clone())
                .await
                .expect("Failed to reload registry");

            let dataset = registry
                .get_dataset("persist-dataset")
                .await
                .expect("Failed to get dataset")
                .expect("Dataset not found");

            assert_eq!(dataset.name, "persist-dataset");
            assert_eq!(dataset.latest_version, 1);

            let versions = registry
                .list_dataset_versions("persist-dataset")
                .await
                .expect("Failed to list versions");
            assert_eq!(versions.len(), 1);
        }

        // Cleanup
        let _ = fs::remove_dir_all(temp_dir).await;
    }
}